On 15/09/2020 02:44, Jesse Brandeburg wrote: > kernel-doc script as used by W=1, is confused by the macro > usage inside the header describing the efx_ptp_data struct. > > drivers/net/ethernet/sfc/ptp.c:345: warning: Function parameter or member > 'MC_CMD_PTP_IN_TRANSMIT_LENMAX' not described in 'efx_ptp_data' > > After some discussion on the list, break this patch out to > a separate one, and fix the issue through a creative > macro declaration. > > Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com> > Cc: Edward Cree <ec...@solarflare.com> I still don't love it, but it'll do, so have an Acked-by: Edward Cree <ec...@solarflare.com>
(But please make sure whoever maintains scripts/kernel-doc knows that it's breaking on a reasonable construct and forcing the code to be _less_ self-documenting than it otherwise could be.)