[PATCH v2 00/17] RDMA: Improve use of umem in DMA drivers

2020-09-04 Thread Jason Gunthorpe
Most RDMA drivers rely on a linear table of DMA addresses organized in some device specific page size. For a while now the core code has had the rdma_for_each_block() SG iterator to help break a umem into DMA blocks for use in the device lists. Improve on this by adding rdma_umem_for_each_dma_blo

Re: [PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 09:15:20 + Henrik Bjoernlund wrote: > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. > > Connectivity Fault Management (CFM) comprises capabilities for > detecting, verifying, and isolating connectivity failures in > Virtual Bridged Networks. These

Re: [PATCH v2 net-next 0/2] ionic: add devlink dev flash support

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 11:20:11 -0700 Shannon Nelson wrote: > It's probably related to this discussion: > https://lore.kernel.org/linux-sparse/ecdd10cb-0022-8f8a-ec36-9d51b3ae8...@pensando.io/ > > I thought we'd worked out our struct alignment issues, but I'll see if I > can carve out some time to ta

Re: [PATCH v2 net-next 0/2] ionic: add devlink dev flash support

2020-09-04 Thread Shannon Nelson
On 9/4/20 3:47 PM, Jakub Kicinski wrote: On Fri, 4 Sep 2020 11:20:11 -0700 Shannon Nelson wrote: It's probably related to this discussion: https://lore.kernel.org/linux-sparse/ecdd10cb-0022-8f8a-ec36-9d51b3ae8...@pensando.io/ I thought we'd worked out our struct alignment issues, but I'll see i

[PATCH net-next 1/9] net: ethernet: ti: ale: add cpsw_ale_get_num_entries api

2020-09-04 Thread Grygorii Strashko
Add cpsw_ale_get_num_entries() API to return number of ALE table entries and update existing drivers to use it. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 10 ++ drivers/net/ethernet/ti/cpsw_ale.c | 5 + drivers/net/ethernet/ti/cpsw_a

[PATCH net-next 2/9] net: ethernet: ti: ale: add static configuration

2020-09-04 Thread Grygorii Strashko
As existing, as newly introduced CPSW ALE versions have differences in supported features and ALE table formats. Especially it's actual for the recent AM65x/J721E/J7200 and future AM64x SoCs, which supports features like: auto-aging, classifiers, Link aggregation, additional HW filtering, etc. The

[PATCH net-next 0/9] net: ethernet: ti: ale: add static configuration

2020-09-04 Thread Grygorii Strashko
Hi All, As existing, as newly introduced CPSW ALE versions have differences in supported features and ALE table formats. Especially it's actual for the recent AM65x/J721E/J7200 and future AM64x SoCs, which supports more features like: auto-aging, classifiers, Link aggregation, additional HW filte

[PATCH net-next 4/9] net: netcp: ethss: use dev_id for ale configuration

2020-09-04 Thread Grygorii Strashko
The previous patch has introduced possibility to select CPSW ALE by using ALE dev_id identifier. Switch TI Keystone 2 NETCP driver to use dev_id and perform clean up by removing "ale_entries" configuration code. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/netcp_ethss.c | 18

[PATCH net-next 5/9] net: ethernet: ti: am65-cpsw: use dev_id for ale configuration

2020-09-04 Thread Grygorii Strashko
The previous patch has introduced possibility to select CPSW ALE by using ALE dev_id identifier. Switch TI TI AM65x/J721E CPSW NUSS driver to use dev_id. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH net-next 3/9] net: ethernet: ti: cpsw: use dev_id for ale configuration

2020-09-04 Thread Grygorii Strashko
The previous patch has introduced possibility to select CPSW ALE by using ALE dev_id identifier. Switch TI cpsw driver to use dev_id="cpsw" and perform clean up by removing "ale_entries" configuration code. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 6 -- driv

[PATCH net-next 7/9] net: ethernet: ti: am65-cpsw: enable hw auto ageing

2020-09-04 Thread Grygorii Strashko
The AM65x ALE supports HW auto-ageing which can be enabled by programming ageing interval in ALE_AGING_TIMER register. For this CPSW fck_clk frequency has to be know by ALE. This patch extends cpsw_ale_params with bus_freq field and enables ALE HW auto ageing for AM65x CPSW2G ALE version. Signed-

[PATCH net-next 9/9] net: ethernet: ti: ale: add support for multi port k3 cpsw versions

2020-09-04 Thread Grygorii Strashko
The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5 CPSW ALE, but has more extended functions and different ALE VLAN entry format. This patch adds support for for multi port TI J721E (CPSW9g) ALE variant. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_

[PATCH net-next 8/9] net: ethernet: ti: ale: switch to use tables for vlan entry description

2020-09-04 Thread Grygorii Strashko
The ALE VLAN entries are too much differ between different TI CPSW ALE versions. So, handling them using flags, defines and get/set functions became over-complicated. This patch introduces tables to describe the ALE VLAN entries fields, which are different between TI CPSW ALE versions, and new get

[PATCH net-next 6/9] net: ethernet: ti: ale: make usage of ale dev_id mandatory

2020-09-04 Thread Grygorii Strashko
Hence all existing driver updated to use ALE dev_id the usage of ale dev_id can be made mandatory and cpsw_ale_create() can be updated to use "features" property from ALE static configuration. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 28 +-

Re: [PATCH bpf-next v3 3/8] libbpf: Add BPF_PROG_BIND_MAP syscall and use it on .metadata section

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 6:29 PM Alexei Starovoitov wrote: > > On Wed, Sep 02, 2020 at 07:31:33PM -0700, Andrii Nakryiko wrote: > > On Fri, Aug 28, 2020 at 12:37 PM Stanislav Fomichev wrote: > > > > > > From: YiFei Zhu > > > > > > The patch adds a simple wrapper bpf_prog_bind_map around the syscal

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-04 Thread Baptiste Covolato
Hi Michael, On Thu, Sep 3, 2020 at 11:29 AM Michael Chan wrote: > If tg3_reset_task() fails, the device state is left in an inconsistent > state with IFF_RUNNING still set but NAPI state not enabled. A > subsequent operation, such as ifdown or AER error can cause it to > soft lock up when it tri

Re: [PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Yonghong Song
On 9/4/20 1:30 PM, Andrii Nakryiko wrote: On Fri, Sep 4, 2020 at 12:49 PM Yonghong Song wrote: Commit 41c48f3a98231 ("bpf: Support access to bpf map fields") added support to access map fields with CORE support. For example, struct bpf_map { __u32 max_entr

RE: [Intel-wired-lan] [PATCH][v2] i40e: optimise prefetch page refcount

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of Li > RongQing > Sent: Friday, July 31, 2020 3:38 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; > k...@kernel.org; Bowers, AndrewX ; > Nguyen, Anthony L > Subject: [Intel-wired-lan] [PATCH][v2] i40e: optimise prefetch page refcount > > ref

Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-04 Thread Jakub Kicinski
On Fri, 04 Sep 2020 11:30:28 +0200 Jesper Dangaard Brouer wrote: > @@ -3211,8 +3211,7 @@ static int bpf_skb_net_shrink(struct sk_buff *skb, u32 > off, u32 len_diff, > > static u32 __bpf_skb_max_len(const struct sk_buff *skb) > { > - return skb->dev ? skb->dev->mtu + skb->dev->hard_header_l

RE: [PATCH][v3] i40e: optimise prefetch page refcount

2020-09-04 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org > On Behalf Of Li RongQing > Sent: Tuesday, August 18, 2020 12:08 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [PATCH][v3] i40e: optimise prefetch page refcount > > refcount of rx_buffer page will be added here originally, so pr

Re: [PATCH bpf-next 0/6] xsk: exit NAPI loop when AF_XDP Rx ring is full

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 16:32:56 +0200 Björn Töpel wrote: > On 2020-09-04 16:27, Jesper Dangaard Brouer wrote: > > On Fri, 4 Sep 2020 15:53:25 +0200 > > Björn Töpel wrote: > > > >> On my machine the "one core scenario Rx drop" performance went from > >> ~65Kpps to 21Mpps. In other words, from "not

RE: [RFC v2 02/11] Drivers: hv: vmbus: Move __vmbus_open()

2020-09-04 Thread Michael Kelley
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM > > Pure function movement, no functional changes. The move is made, because > in a later change, __vmbus_open() will rely on some static functions > afterwards, so we sperate the move and the modification of s/sperate/separate/ > __vmbu

Re: PROBLEM: QinQ not working with qlcnic drivers

2020-09-04 Thread Jakub Kicinski
CC: qlcnic maintainers On Fri, 4 Sep 2020 11:25:27 +0200 MyNet SysAdmin wrote: > *[1.] One line summary of the problem:* > > QinQ not working with qlcnicdrivers > > *[2.] Full description of the problem/report:* > > QinQ networking operations don’t happenproperly: a QinQ message can be > recei

Re: [PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 4:20 PM Yonghong Song wrote: > > > > On 9/4/20 1:30 PM, Andrii Nakryiko wrote: > > On Fri, Sep 4, 2020 at 12:49 PM Yonghong Song wrote: > >> > >> Commit 41c48f3a98231 ("bpf: Support access > >> to bpf map fields") added support to access map fields > >> with CORE support. F

Re: [PATCH net-next 8/9] net: ethernet: ti: ale: switch to use tables for vlan entry description

2020-09-04 Thread Jakub Kicinski
On Sat, 5 Sep 2020 02:09:23 +0300 Grygorii Strashko wrote: > The ALE VLAN entries are too much differ between different TI CPSW ALE > versions. So, handling them using flags, defines and get/set functions > became over-complicated. > > This patch introduces tables to describe the ALE VLAN entries

Re: [PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Alexei Starovoitov
On Fri, Sep 4, 2020 at 5:08 PM Andrii Nakryiko wrote: > > On Fri, Sep 4, 2020 at 4:20 PM Yonghong Song wrote: > > > > > > > > On 9/4/20 1:30 PM, Andrii Nakryiko wrote: > > > On Fri, Sep 4, 2020 at 12:49 PM Yonghong Song wrote: > > >> > > >> Commit 41c48f3a98231 ("bpf: Support access > > >> to bp

Re: [PATCH net-next 9/9] net: ethernet: ti: ale: add support for multi port k3 cpsw versions

2020-09-04 Thread Jakub Kicinski
On Sat, 5 Sep 2020 02:09:24 +0300 Grygorii Strashko wrote: > The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5 > CPSW ALE, but has more extended functions and different ALE VLAN entry > format. > > This patch adds support for for multi port TI J721E (CPSW9g) ALE variant.

RE: [RFC v2 03/11] Drivers: hv: vmbus: Introduce types of GPADL

2020-09-04 Thread Michael Kelley
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM > > This patch introduces two types of GPADL: HV_GPADL_{BUFFER, RING}. The > types of GPADL are purely the concept in the guest, IOW the hypervisor > treat them as the same. > > The reason of introducing the types of GPADL is to support g

RE: [RFC v2 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication

2020-09-04 Thread Michael Kelley
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM > > When communicating with Hyper-V, HV_HYP_PAGE_SIZE should be used since > that's the page size used by Hyper-V and Hyper-V expects all > page-related data using the unit of HY_HYP_PAGE_SIZE, for example, the > "pfn" in hv_page_buffer is

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Xie He
Thank you for your email, Jakub! On Fri, Sep 4, 2020 at 3:14 PM Jakub Kicinski wrote: > > Since this is a tunnel protocol on top of HDLC interfaces, and > hdlc_setup_dev() sets dev->hard_header_len = 16; should we actually > set the needed_headroom to 10 + 16 = 26? I'm not clear on where/if > hdl

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Xie He
On Fri, Sep 4, 2020 at 6:28 PM Xie He wrote: > > The HDLC device is not actually prepending any header when it is used > with this driver. When the PVC device has prepended its header and > handed over the skb to the HDLC device, the HDLC device just hands it > over to the hardware driver for tran

RE: [PATCH] ice: Fix memleak in ice_set_ringparam

2020-09-04 Thread Brown, Aaron F
> From: Dinghao Liu > Sent: Wednesday, August 26, 2020 7:34 PM > To: dinghao@zju.edu.cn; k...@umn.edu > Cc: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski ; Alexei > Starovoitov ; Daniel Borkmann ; > Jesper Dangaard Brouer ; John Fastabend > ; intel-wired-...@lists.osuosl.org; > netde

[PATCH net] hv_netvsc: Fix hibernation for mlx5 VF driver

2020-09-04 Thread Dexuan Cui
mlx5_suspend()/resume() keep the network interface, so during hibernation netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence netvsc_resume() should call netvsc_vf_changed() to switch the data path back to the VF after hibernation. Similarly, netvsc_suspend() should not call n

RE: [RFC v2 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K

2020-09-04 Thread Michael Kelley
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM > > Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when > communicating with Hyper-V, a guest should always use HV_HYP_PAGE_SIZE > as the unit for page related data. For storvsc, the data is > vmbus_packet_mpb_array. And since in s

RE: [Intel-wired-lan] [PATCH net-next v2 1/3] i40e, xsk: remove HW descriptor prefetch in AF_XDP path

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Björn Töpel > Sent: Tuesday, August 25, 2020 4:36 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; b...@vger.kernel.org; Topel, Bjorn > ; Karlsson, Magnus ; > k...@kernel.org > Subject: [Intel-wired-lan] [PATCH net-next v2 1/3] i40e, xs

Re: [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV

2020-09-04 Thread wanghai (M)
在 2020/9/4 21:26, Willem de Bruijn 写道: On Fri, Sep 4, 2020 at 3:09 PM Wang Hai wrote: BPDU_TYPE_TCN is never used after it was introduced. So better to remove it. This comment does not cover the patch contents. Otherwise the patch looks good to me. Thanks for your review, I will revise this

RE: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: use 16B HW descriptors instead of 32B

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Björn Töpel > Sent: Tuesday, August 25, 2020 4:36 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; b...@vger.kernel.org; Topel, Bjorn > ; Karlsson, Magnus ; > k...@kernel.org > Subject: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: us

RE: [Intel-wired-lan] [PATCH net-next v2 3/3] i40e, xsk: move buffer allocation out of the Rx processing loop

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Björn Töpel > Sent: Tuesday, August 25, 2020 4:36 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; b...@vger.kernel.org; Topel, Bjorn > ; Karlsson, Magnus ; > k...@kernel.org > Subject: [Intel-wired-lan] [PATCH net-next v2 3/3] i40e, xs

[PATCH net] ibmvnic: add missing parenthesis in do_reset()

2020-09-04 Thread Jakub Kicinski
Indentation and logic clearly show that this code is missing parenthesis. Fixes: 9f1345737790 ("ibmvnic fix NULL tx_pools and rx_tools issue at do_reset") Signed-off-by: Jakub Kicinski --- CC: m...@linux.vnet.ibm.com CC: d...@linux.ibm.com CC: tlfal...@linux.ibm.com CC: jal...@linux.ibm.com I ra

linux-next: manual merge of the akpm-current tree with the net-next tree

2020-09-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: mm/filemap.c between commit: 76cd61739fd1 ("mm/error_inject: Fix allow_error_inject function signatures.") from the net-next tree and commit: 2cb138387ead ("mm/filemap: fix storing to a THP shadow entry") from

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 18:57:27 -0700 Xie He wrote: > On Fri, Sep 4, 2020 at 6:28 PM Xie He wrote: > > > > The HDLC device is not actually prepending any header when it is used > > with this driver. When the PVC device has prepended its header and > > handed over the skb to the HDLC device, the HDLC d

Re: [PATCH] atm: eni: fix the missed pci_disable_device() for eni_init_one()

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 10:51:03 +0800 Jing Xiangfeng wrote: > eni_init_one() misses to call pci_disable_device() in an error path. > Jump to err_disable to fix it. > > Signed-off-by: Jing Xiangfeng Please make sure you add appropriate fixes tags, here: Fixes: ede58ef28e10 ("atm: remove deprecated u

[net-next] tipc: fix a deadlock when flushing scheduled work

2020-09-04 Thread Hoang Huu Le
In the commit fdeba99b1e58 ("tipc: fix use-after-free in tipc_bcast_get_mode"), we're trying to make sure the tipc_net_finalize_work work item finished if it enqueued. But calling flush_scheduled_work() is not just affecting above work item but either any scheduled work. This has turned out to be o

Re: [Patch net] act_ife: load meta modules before tcf_idr_check_alloc()

2020-09-04 Thread Jakub Kicinski
On Thu, 3 Sep 2020 19:10:11 -0700 Cong Wang wrote: > The following deadlock scenario is triggered by syzbot: > > Thread A: Thread B: > tcf_idr_check_alloc() > ... > populate_metalist() > rtnl_unlock() > rtnl_lock() >

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-04 Thread Lukas Wunner
On Fri, Sep 04, 2020 at 11:14:37PM +0200, Daniel Borkmann wrote: > On 9/4/20 6:21 PM, Lukas Wunner wrote: > > nft and tc are orthogonal, i.e. filtering/mangling versus queueing. > > However tc has gained the ability to filter packets as well, hence > > there's some overlap in functionality. Natura

[PATCH net-next 0/2] net: two updates related to UDP GSO

2020-09-04 Thread Huazhong Tan
There are two updates relates to UDP GSO. #1 adds a new GSO type for UDPv6 #2 adds check for UDP GSO when csum is disable in netdev_fix_features(). Changes since RFC V2: - modifies the timing of setting UDP GSO type when doing UDP GRO in #1. Changes since RFC V1: - updates NETIF_F_GSO_LAST sugges

[PATCH net-next 2/2] net: disable UDP GSO features when CSUM is disable

2020-09-04 Thread Huazhong Tan
When CSUM is not available, UDP GSO should be disable as well. Signed-off-by: Huazhong Tan --- net/core/dev.c | 12 1 file changed, 12 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index d42c9ea..0c78306 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9402,6 +9402

[PATCH net-next 1/2] udp: add a GSO type for UDPv6

2020-09-04 Thread Huazhong Tan
In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled separately, for example, checksum offload, so add new GSO type SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands for UDPv4. Signed-off-by: Huazhong Tan --- drivers/net/bonding/bond_main.c | 4 +++-

[PATCH] tipc: fix shutdown() of connection oriented socket

2020-09-04 Thread Tetsuo Handa
I confirmed that the problem fixed by commit 2a63866c8b51a3f7 ("tipc: fix shutdown() of connectionless socket") also applies to stream socket. -- #include #include #include int main(int argc, char *argv[]) { int fds[2] = { -1, -1 }; socketpair(PF_TIPC, SOCK_STREAM /* or

Re: [PATCH] net/packet: fix overflow in tpacket_rcv

2020-09-04 Thread Salvatore Bonaccorso
Hi, On Fri, Sep 04, 2020 at 04:36:48PM +0200, gre...@linuxfoundation.org wrote: > On Fri, Sep 04, 2020 at 02:22:46PM +, Nuernberger, Stefan wrote: > > On Fri, 2020-09-04 at 16:16 +0200, Greg Kroah-Hartman wrote: > > > On Fri, Sep 04, 2020 at 03:30:52PM +0200, Stefan Nuernberger wrote: > > > >

<    1   2   3