Indentation and logic clearly show that this code is missing
parenthesis.

Fixes: 9f1345737790 ("ibmvnic fix NULL tx_pools and rx_tools issue at do_reset")
Signed-off-by: Jakub Kicinski <k...@kernel.org>
---
CC: m...@linux.vnet.ibm.com
CC: d...@linux.ibm.com
CC: tlfal...@linux.ibm.com
CC: jal...@linux.ibm.com

I randomly noticed this when doing a net -> net-next merge.

Folks, please: (a) make more of an effort testing your code, especially
for fixes!, and (b) try making your code COMPILE_TEST-able, I'm 100% sure
buildbot would've caught this immediately if it wasn't for the arch
dependency.

 drivers/net/ethernet/ibm/ibmvnic.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c 
b/drivers/net/ethernet/ibm/ibmvnic.c
index d3a774331afc..1b702a43a5d0 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -2032,16 +2032,18 @@ static int do_reset(struct ibmvnic_adapter *adapter,
 
                } else {
                        rc = reset_tx_pools(adapter);
-                       if (rc)
+                       if (rc) {
                                netdev_dbg(adapter->netdev, "reset tx pools 
failed (%d)\n",
                                                rc);
                                goto out;
+                       }
 
                        rc = reset_rx_pools(adapter);
-                       if (rc)
+                       if (rc) {
                                netdev_dbg(adapter->netdev, "reset rx pools 
failed (%d)\n",
                                                rc);
                                goto out;
+                       }
                }
                ibmvnic_disable_irqs(adapter);
        }
-- 
2.26.2

Reply via email to