[PATCH nf] netfilter: ctnetlink: fix mark based dump filtering regression

2020-09-01 Thread Martin Willi
conntrack mark based dump filtering may falsely skip entries if a mask is given: If the mask-based check does not filter out the entry, the else-if check is always true and compares the mark without considering the mask. The if/else-if logic seems wrong. Given that the mask during filter setup is

[PATCH] mwifiex: Remove unnecessary braces from HostCmd_SET_SEQ_NO_BSS_INFO

2020-09-01 Thread Nathan Chancellor
A new warning in clang points out when macro expansion might result in a GNU C statement expression. There is an instance of this in the mwifiex driver: drivers/net/wireless/marvell/mwifiex/cmdevt.c:217:34: warning: '}' and ')' tokens terminating statement expression appear in different macro expa

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-01 Thread Yunsheng Lin
On 2020/9/1 14:48, Eric Dumazet wrote: > > > On 8/31/20 5:55 PM, Yunsheng Lin wrote: >> Currently there is concurrent reset and enqueue operation for the >> same lockless qdisc when there is no lock to synchronize the >> q->enqueue() in __dev_xmit_skb() with the qdisc reset operation in >> qdisc_

Re: [PATCH 1/5] net: phy: smsc: skip ENERGYON interrupt if disabled

2020-09-01 Thread Marco Felsch
Hi Andrew, thanks for your fast response :) On 20-08-31 16:02, Andrew Lunn wrote: > On Mon, Aug 31, 2020 at 03:48:32PM +0200, Marco Felsch wrote: > > Don't enable the interrupt if the platform disable the energy detection > > by "smsc,disable-energy-detect". > > > > Signed-off-by: Marco Felsch

Re: [PATCH 5/5] net: phy: smsc: LAN8710/LAN8720: remove PHY_RST_AFTER_CLK_EN flag

2020-09-01 Thread Marco Felsch
Hi Andrew, On 20-08-31 16:11, Andrew Lunn wrote: > On Mon, Aug 31, 2020 at 03:48:36PM +0200, Marco Felsch wrote: > > Don't reset the phy without respect to the phy-state-machine because > > this breaks the phy IRQ mode. We can archive the same behaviour if the > > refclk in is specified. > > > >

Re: [PATCH 4/5] net: phy: smsc: add phy refclk in support

2020-09-01 Thread Marco Felsch
On 20-08-31 16:08, Andrew Lunn wrote: > > + priv->refclk = devm_clk_get_optional(dev, NULL); > > + if (IS_ERR(priv->refclk)) { > > + if (PTR_ERR(priv->refclk) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + > > + /* Clocks are optional all errors should

Re: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-09-01 Thread Jiri Pirko
Sat, Aug 29, 2020 at 05:43:58AM CEST, pa...@nvidia.com wrote: > > >> From: Jakub Kicinski >> Sent: Friday, August 28, 2020 10:14 PM >> >> On Fri, 28 Aug 2020 04:27:19 + Parav Pandit wrote: >> > > From: Jakub Kicinski >> > > Sent: Friday, August 28, 2020 3:12 AM >> > > >> > > On Thu, 27 Aug 2

Re: [PATCH 4/5] net: phy: smsc: add phy refclk in support

2020-09-01 Thread Marco Felsch
On 20-08-31 09:32, Florian Fainelli wrote: > > > On 8/31/2020 6:48 AM, Marco Felsch wrote: > > Add support to specify the clock provider for the phy refclk and don't > > rely on 'magic' host clock setup. [1] tried to address this by > > introducing a flag and fixing the corresponding host. But th

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Yann Ylavic
On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau wrote: > > +/* > + * Generate some initially weak seeding values to allow > + * the prandom_u32() engine to be started. > + */ > +static int __init prandom_init_early(void) > +{ > + int i; > + unsigned long v0, v1, v2, v3; > + > +

[PATCH bpf-next v2] bpf: {cpu,dev}map: change various functions return type from int to void

2020-09-01 Thread Björn Töpel
From: Björn Töpel The functions bq_enqueue(), bq_flush_to_queue(), and bq_xmit_all() in {cpu,dev}map.c always return zero. Changing the return type from int to void makes the code easier to follow. Suggested-by: David Ahern Signed-off-by: Björn Töpel --- kernel/bpf/cpumap.c | 11 +++

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Willy Tarreau
On Tue, Sep 01, 2020 at 10:33:40AM +0200, Yann Ylavic wrote: > On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau wrote: > > > > +/* > > + * Generate some initially weak seeding values to allow > > + * the prandom_u32() engine to be started. > > + */ > > +static int __init prandom_init_early(voi

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Sedat Dilek
On Tue, Sep 1, 2020 at 10:39 AM Willy Tarreau wrote: > > On Tue, Sep 01, 2020 at 10:33:40AM +0200, Yann Ylavic wrote: > > On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau wrote: > > > > > > +/* > > > + * Generate some initially weak seeding values to allow > > > + * the prandom_u32() engine t

Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication

2020-09-01 Thread Jason Wang
On 2020/9/1 下午1:24, Kishon Vijay Abraham I wrote: Hi, On 28/08/20 4:04 pm, Cornelia Huck wrote: On Thu, 9 Jul 2020 14:26:53 +0800 Jason Wang wrote: [Let me note right at the beginning that I first noted this while listening to Kishon's talk at LPC on Wednesday. I might be very confused abou

RE: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-09-01 Thread Parav Pandit
> From: Jiri Pirko > Sent: Tuesday, September 1, 2020 1:49 PM > > >> > How? How do we tell that pfnum A means external system. > >> > Want to avoid such 'implicit' notion. > >> > >> How do you tell that controller A means external system? > > Perhaps the attr name could be explicitly containin

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Willy Tarreau
On Tue, Sep 01, 2020 at 10:46:16AM +0200, Sedat Dilek wrote: > Will you push the updated patchset to your prandom Git - for easy fetching? Yeah if you want, feel free to use this one : https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/log/?h=20200901-siphash-noise Willy

Re: [01/28] hostap: Mark 'freq_list' as __maybe_unused

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > 'freq_list' is used in some source files which include hostap.h, but > not all. The compiler complains about the times it's not used. Mark > it as __maybe_used to tell the compiler that this is not only okay, > it's expected. > > Fixes the following W=1 kernel build warning(

Re: [15/28] mt7601u: phy: Fix misnaming when documented function parameter 'dac'

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Function > parameter or member 'dac' not described in 'mt7601u_set_tx_dac' > drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Excess function > paramet

RE: sysfs output without newlines

2020-09-01 Thread David Laight
From: Joe Perches > Sent: 29 August 2020 21:34 ... > > On 8/29/20 9:23 PM, Joe Perches wrote: > > > While doing an investigation for a possible treewide conversion of > > > sysfs output using sprintf/snprintf/scnprintf, I discovered > > > several instances of sysfs output without terminating newlin

Re: [PATCH 00/32] Set 2: Rid W=1 warnings in Wireless

2020-09-01 Thread Kalle Valo
Lee Jones writes: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are quite a few W=1 warnings in the Wireless. My plan > is to work through all of them over the next few weeks.

Re: [PATCH 01/32] wireless: marvell: mwifiex: sdio: Move 'static const struct's into their own header file

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > Only include these tables in the 1 source file they are used. > > Fixes hundreds of W=1 warnings! > > Fixes the following W=1 kernel build warning(s): > > In file included from drivers/net/wireless/marvell/mwifiex/main.h:59, > from drivers/net/wireless/marvell/mwifiex/main

Re: [PATCH bpf-next v2] bpf: {cpu,dev}map: change various functions return type from int to void

2020-09-01 Thread Jesper Dangaard Brouer
On Tue, 1 Sep 2020 10:39:28 +0200 Björn Töpel wrote: > From: Björn Töpel > > The functions bq_enqueue(), bq_flush_to_queue(), and bq_xmit_all() in > {cpu,dev}map.c always return zero. Changing the return type from int > to void makes the code easier to follow. > > Suggested-by: David Ahern >

Re: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-09-01 Thread Jiri Pirko
Tue, Sep 01, 2020 at 10:53:23AM CEST, pa...@nvidia.com wrote: > >> From: Jiri Pirko >> Sent: Tuesday, September 1, 2020 1:49 PM >> >> >> > How? How do we tell that pfnum A means external system. >> >> > Want to avoid such 'implicit' notion. >> >> >> >> How do you tell that controller A means exte

Re: [02/32] rsi: Add description for function param 'sta'

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/rsi/rsi_91x_mac80211.c:1021: warning: Function > parameter or member 'sta' not described in 'rsi_mac80211_set_key' > > Cc: Amitkumar Karwar > Cc: Siva Rebbagondla > Cc: Kalle Valo > Cc: "David S. M

Re: [PATCH net-next 00/15] net: bridge: mcast: initial IGMPv3 support (part 1)

2020-09-01 Thread Nikolay Aleksandrov
On 31/08/2020 18:08, Nikolay Aleksandrov wrote: > Hi all, > This patch-set implements the control plane for initial IGMPv3 support. [snip] Self-NAK, my torture tests uncovered (a rather obvious) locking issue with the dump code. The src groups will have to be traversed with RCU, and thus RCU-frie

Re: [16/32] brcmfmac: btcoex: Update 'brcmf_btcoex_state' and demote others

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > The function headers are either very weakly documented or not at all. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:94: warning: > Function parameter or member 'reg50' not described in 'brcmf_btcoex_info'

Re: [PATCH 12/16] wireless: mediatek: convert tasklets to use new tasklet_setup() API

2020-09-01 Thread Kalle Valo
Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-of

Re: [PATCH][next] mediatek: Use fallthrough pseudo-keyword

2020-09-01 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highl

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Sedat Dilek
kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/log/?h=20200901-siphash-noise > Thanks, - sed@ -

Re: [PATCH bpf-next v2] bpf: {cpu,dev}map: change various functions return type from int to void

2020-09-01 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > From: Björn Töpel > > The functions bq_enqueue(), bq_flush_to_queue(), and bq_xmit_all() in > {cpu,dev}map.c always return zero. Changing the return type from int > to void makes the code easier to follow. > > Suggested-by: David Ahern > Signed-off-by: Björn Töpel Acked-

[PATCH net-next] octeontx2-pf: Add UDP segmentation offload support

2020-09-01 Thread sunil.kovvuri
From: Sunil Goutham Defines UDP segmentation algorithm in hardware and supports offloading UDP segmentation. Signed-off-by: Sunil Goutham --- .../ethernet/marvell/octeontx2/nic/otx2_common.c | 89 ++ .../ethernet/marvell/octeontx2/nic/otx2_common.h | 5 +- .../net/ethe

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-09-01 Thread Kalle Valo
Mauro Carvalho Chehab wrote: > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > >wlcore: PHY firmware version: Rev 8.2.0.0.242 >wlcore: firmware booted (Rev 8.9.0.0.79)

Re: p54: avoid accessing the data mapped to streaming DMA

2020-09-01 Thread Kalle Valo
Jia-Ju Bai wrote: > In p54p_tx(), skb->data is mapped to streaming DMA on line 337: > mapping = pci_map_single(..., skb->data, ...); > > Then skb->data is accessed on line 349: > desc->device_addr = ((struct p54_hdr *)skb->data)->req_id; > > This access may cause data inconsistency between

Re: [PATCH] rtl818x_pci: switch from 'pci_' to 'dma_' API

2020-09-01 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'rtl8180_i

Re: [PATCH] rtlwifi: switch from 'pci_' to 'dma_' API

2020-09-01 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > The only file where some GFP_ flags ar

Re: [PATCH][next] rtlwifi: Use fallthrough pseudo-keyword

2020-09-01 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

[PATCH] net: usb: dm9601: Add USB ID of Keenetic Plus DSL

2020-09-01 Thread Kamil Lorenc
Keenetic Plus DSL is a xDSL modem that uses dm9620 as its USB interface. Signed-off-by: Kamil Lorenc --- drivers/net/usb/dm9601.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index b91f92e4e5f2..915ac75b55fc 100644 --- a/drivers/net/

Re: [PATCH 2/2] random32: add noise from network and scheduling activity

2020-09-01 Thread Eric Dumazet
On 8/31/20 11:43 PM, Willy Tarreau wrote: > With the removal of the interrupt perturbations in previous random32 > change (random32: make prandom_u32() output unpredictable), the PRNG > has become 100% deterministic again. While SipHash is expected to be > way more robust against brute force tha

Re: [PATCH] drivers: reduce the param length of the line

2020-09-01 Thread Heiner Kallweit
On 01.09.2020 10:11, tongc...@whu.edu.cn wrote: > I run the checkpatch script against the c source, and the following output > says it prefers a maximum of 75 chars per-line. > That's wrong. As the name suggests, checkpatch is meant to be used with patches, not with source files. > #./scripts/ch

Re: PMTUD broken inside network namespace with multipath routing

2020-09-01 Thread mastertheknife
Hello David. I was able to solve it while troubleshooting some fragmentation issue. The VTI interfaces had MTU of 1480 by default. I reduced to them to the real PMTUD (1366) and now its all working just fine. I am not sure how its related and why, but seems like it solved the issue. P.S: while re

Re: PMTUD broken inside network namespace with multipath routing

2020-09-01 Thread mastertheknife
Hello David, A quick correction; The issue is not solved, it was a mistake in my testing. The issue is still there. Kfir On Tue, Sep 1, 2020 at 1:40 PM mastertheknife wrote: > > Hello David. > > I was able to solve it while troubleshooting some fragmentation issue. > The VTI interfaces had MTU

RE: [EXTERNAL] Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-09-01 Thread Bouganim, Raz
We are going to release a new FW version 8.9.0.0.83 that contains support with the new IGTK key. In addition, we also going to release a new patch that mandates the driver to work with an 8.9.0.0.83 FW version or above. We going to push it today/tomorrow. [PATCH] wl18xx: Update the latest firm

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-09-01 Thread Christoph Hellwig
On Thu, Aug 20, 2020 at 07:33:48PM +0200, Tomasz Figa wrote: > > It wasn't meant to be too insulting, but I found this out when trying > > to figure out how to just disable it. But it also ends up using > > the actual dma attr flags for it's own consistency checks, so just > > not setting the flag

Re: [PATCH net-next] vhost: fix typo in error message

2020-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2020 at 10:39:09AM +0800, Yunsheng Lin wrote: > "enable" should be "disable" when the function name is > vhost_disable_notify(), which does the disabling work. > > Signed-off-by: Yunsheng Lin Acked-by: Michael S. Tsirkin Why net-next though? It's a bugfix, can go into net. >

Re: [PATCH v2] Bluetooth: Clear suspend tasks on unregister

2020-09-01 Thread Marcel Holtmann
Hi Abhishek, > While unregistering, make sure to clear the suspend tasks before > cancelling the work. If the unregister is called during resume from > suspend, this will unnecessarily add 2s to the resume time otherwise. > > Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race) > Signed-o

Re: [PATCH net-next v3 1/3] net: openvswitch: improve coding style

2020-09-01 Thread Tonghao Zhang
On Wed, Aug 26, 2020 at 5:51 AM Stefano Brivio wrote: > > On Tue, 25 Aug 2020 13:06:34 +0800 > xiangxia.m@gmail.com wrote: > > > +++ b/net/openvswitch/datapath.c > > > > [...] > > > > @@ -2095,7 +2099,7 @@ static void ovs_update_headroom(struct datapath *dp, > > unsigned int new_headroom) > >

Re: [PATCH 2/2] random32: add noise from network and scheduling activity

2020-09-01 Thread Willy Tarreau
Hi Eric, On Tue, Sep 01, 2020 at 12:24:38PM +0200, Eric Dumazet wrote: > There is not much entropy here really : > > 1) dev & txq are mostly constant on a typical host (at least the kind of > hosts that is targeted by > Amit Klein and others in their attacks. > > 2) len is also known by the at

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-09-01 Thread Kalle Valo
Douglas Anderson wrote: > If we have a per CE (Copy Engine) IRQ then we have no summary > register. Right now the code generates a summary register by > iterating over all copy engines and seeing if they have an interrupt > pending. > > This has a problem. Specifically if _none_ if the Copy En

[net-next v2 0/4] tipc: add more features to TIPC encryption

2020-09-01 Thread Tuong Lien
This series adds some new features to TIPC encryption: - Patch 1 ("tipc: optimize key switching time and logic") optimizes the code and logic in preparation for the following commits. - Patch 2 ("tipc: introduce encryption master key") introduces support of 'master key' for authentication of new

[net-next v2 1/4] tipc: optimize key switching time and logic

2020-09-01 Thread Tuong Lien
We reduce the lasting time for a pending TX key to be active as well as for a passive RX key to be freed which generally helps speed up the key switching. It is not expected to be too fast but should not be too slow either. Also the key handling logic is simplified that a pending RX key will be rem

RE: [net] tipc: fix using smp_processor_id() in preemptible

2020-09-01 Thread Tuong Tong Lien
> -Original Message- > From: Eric Dumazet > Sent: Monday, August 31, 2020 7:48 PM > To: Tuong Tong Lien ; Eric Dumazet > ; da...@davemloft.net; > jma...@redhat.com; ma...@donjonn.com; ying@windriver.com; > netdev@vger.kernel.org > Cc: tipc-discuss...@lists.sourceforge.net > Subject

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-09-01 Thread Kalle Valo
Doug Anderson writes: > On Wed, Aug 26, 2020 at 7:51 AM Kalle Valo wrote: >> >> Douglas Anderson wrote: >> >> > If we have a per CE (Copy Engine) IRQ then we have no summary >> > register. Right now the code generates a summary register by >> > iterating over all copy engines and seeing if the

[PATCH net-next v4 0/3] net: openvswitch: improve the codes

2020-09-01 Thread xiangxia . m . yue
From: Tonghao Zhang This series patches are not bug fix, just improve codes. Tonghao Zhang (3): net: openvswitch: improve the coding style net: openvswitch: refactor flow free function net: openvswitch: remove unused keep_flows net/openvswitch/actions.c| 5 +-- net/openvswitch/datap

Re: [PATCH 4/5] net: phy: smsc: add phy refclk in support

2020-09-01 Thread Andrew Lunn
> Yes, I got this. > > > , or assuming a prior state, > > This is the our case. Isn't it the purpose of the bootloader to setup > the HW? This is a bit of a philosophical discussion. For PCs developers would definitely agree, the firmware should be setting up most of the hardware. And the firmwa

[net-next v2 2/4] tipc: introduce encryption master key

2020-09-01 Thread Tuong Lien
In addition to the supported cluster & per-node encryption keys for the en/decryption of TIPC messages, we now introduce one option for user to set a cluster key as 'master key', which is simply a symmetric key like the former but has a longer life cycle. It has two purposes: - Authentication of n

Re: [PATCH net-next v2 1/3] net: openvswitch: improve coding style

2020-09-01 Thread Tonghao Zhang
On Tue, Sep 1, 2020 at 2:41 AM David Miller wrote: > > From: Tonghao Zhang > Date: Mon, 31 Aug 2020 21:00:28 +0800 > > > On Thu, Aug 27, 2020 at 3:23 AM Pravin Shelar wrote: > >> > >> On Mon, Aug 24, 2020 at 12:37 AM wrote: > >> > > >> > From: Tonghao Zhang > >> > > >> > Not change the logic,

[net-next v2 3/4] tipc: add automatic session key exchange

2020-09-01 Thread Tuong Lien
With support from the master key option in the previous commit, it becomes easy to make frequent updates/exchanges of session keys between authenticated cluster nodes. Basically, there are two situations where the key exchange will take in place: - When a new node joins the cluster (with the maste

Re: [PATCH] ath6kl: wmi: remove set but not used 'rate'

2020-09-01 Thread Kalle Valo
Jason Yan writes: > This addresses the following gcc warning with "make W=1": > > drivers/net/wireless/ath/ath6kl/wmi.c: In function > ‘ath6kl_wmi_bitrate_reply_rx’: > drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ > set but not used [-Wunused-but-set-variable] > 1204 |

[PATCH net-next v4 3/3] net: openvswitch: remove unused keep_flows

2020-09-01 Thread xiangxia . m . yue
From: Tonghao Zhang keep_flows was introduced by [1], which used as flag to delete flows or not. When rehashing or expanding the table instance, we will not flush the flows. Now don't use it anymore, remove it. [1] - https://github.com/openvswitch/ovs/commit/acd051f1761569205827dc9b037e15568a8d

[PATCH net-next v4 2/3] net: openvswitch: refactor flow free function

2020-09-01 Thread xiangxia . m . yue
From: Tonghao Zhang Decrease table->count and ufid_count unconditionally, because we only don't use count or ufid_count to count when flushing the flows. To simplify the codes, we remove the "count" argument of table_instance_flow_free. To avoid a bug when deleting flows in the future, add WARN_

[PATCH net-next v4 1/3] net: openvswitch: improve the coding style

2020-09-01 Thread xiangxia . m . yue
From: Tonghao Zhang Not change the logic, just improve the coding style. Cc: Pravin B Shelar Signed-off-by: Tonghao Zhang Acked-by: Pravin B Shelar --- v4: improve the codes suggested by Stefano http://patchwork.ozlabs.org/project/netdev/patch/20200825050636.14153-2-xiangxia.m@gmail.com -

[net-next v2 4/4] tipc: add automatic rekeying for encryption key

2020-09-01 Thread Tuong Lien
Rekeying is required for security since a key is less secure when using for a long time. Also, key will be detached when its nonce value (or seqno ...) is exhausted. We now make the rekeying process automatic and configurable by user. Basically, TIPC will at a specific interval generate a new key

[PATCH v4 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-09-01 Thread Kurt Kanzenbach
From: Kamil Alkhouri The switch has the ability to take hardware generated time stamps per port for PTPv2 event messages in Rx and Tx direction. That is useful for achieving needed time synchronization precision for TSN devices/switches. So add support for it. There are two directions: * RX

[PATCH v4 3/7] net: dsa: hellcreek: Add PTP clock support

2020-09-01 Thread Kurt Kanzenbach
From: Kamil Alkhouri The switch has internal PTP hardware clocks. Add support for it. There are three clocks: * Synchronized * Syntonized * Free running Currently the synchronized clock is exported to user space which is a good default for the beginning. The free running clock might be expor

[PATCH v4 5/7] net: dsa: hellcreek: Add PTP status LEDs

2020-09-01 Thread Kurt Kanzenbach
The switch has two controllable I/Os which are usually connected to LEDs. This is useful to immediately visually see the PTP status. These provide two signals: * is_gm This LED can be activated if the current device is the grand master in that PTP domain. * sync_good This LED can be

[PATCH v4 7/7] dt-bindings: net: dsa: Add documentation for Hellcreek switches

2020-09-01 Thread Kurt Kanzenbach
Add basic documentation and example. Signed-off-by: Kurt Kanzenbach --- .../bindings/net/dsa/hellcreek.yaml | 127 ++ 1 file changed, 127 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dsa/hellcreek.yaml diff --git a/Documentation/devicetree/bi

[PATCH v4 6/7] dt-bindings: Add vendor prefix for Hirschmann

2020-09-01 Thread Kurt Kanzenbach
Hirschmann is building devices for automation and networking. Add them to the vendor prefixes. Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Doc

[PATCH v4 0/7] Hirschmann Hellcreek DSA driver

2020-09-01 Thread Kurt Kanzenbach
Hi, this series adds a DSA driver for the Hirschmann Hellcreek TSN switch IP. Characteristics of that IP: * Full duplex Ethernet interface at 100/1000 Mbps on three ports * IEEE 802.1Q-compliant Ethernet Switch * IEEE 802.1Qbv Time-Aware scheduling support * IEEE 1588 and IEEE 802.1AS support

[PATCH v4 1/7] net: dsa: Add tag handling for Hirschmann Hellcreek switches

2020-09-01 Thread Kurt Kanzenbach
The Hirschmann Hellcreek TSN switches have a special tagging protocol for frames exchanged between the CPU port and the master interface. The format is a one byte trailer indicating the destination or origin port. It's quite similar to the Micrel KSZ tagging. That's why the implementation is based

[PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-09-01 Thread Kurt Kanzenbach
Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are implementing features needed for Time Sensitive Networking (TSN) such as support for the Time Precision Protocol and various shapers like the Time Aware Shaper. This driver includes basic support for networking: * VLAN

Re: [01/30] mwifiex: pcie: Move tables to the only place they're used

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > Saves on 10's of complains about 'defined but not used' variables. > > Fixes the following W=1 kernel build warning(s): > > In file included from drivers/net/wireless/marvell/mwifiex/main.h:57, > from drivers/net/wireless/marvell/mwifiex/main.c:22: > drivers/net/wireless/m

Re: [ovs-dev] [PATCH net-next] net: openvswitch: fixes crash if nf_conncount_init() fails

2020-09-01 Thread Tonghao Zhang
On Mon, Aug 31, 2020 at 5:58 PM Eelco Chaudron wrote: > > If nf_conncount_init fails currently the dispatched work is not canceled, > causing problems when the timer fires. This change fixes this by not > scheduling the work until all initialization is successful. > > Fixes: a65878d6f00b ("net: op

RE: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread David Laight
From: Willy Tarreau > Sent: 01 September 2020 07:43 ... > +/* > + * Generate some initially weak seeding values to allow > + * the prandom_u32() engine to be started. > + */ > +static int __init prandom_init_early(void) > +{ > + int i; > + unsigned long v0, v1, v2, v3; > + > + if (!

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Willy Tarreau
On Tue, Sep 01, 2020 at 01:10:18PM +, David Laight wrote: > From: Willy Tarreau > > Sent: 01 September 2020 07:43 > ... > > +/* > > + * Generate some initially weak seeding values to allow > > + * the prandom_u32() engine to be started. > > + */ > > +static int __init prandom_init_early(void) >

Re: [24/30] mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > 'mwifiex_1d_to_wmm_queue' is used in'; main.c, txrx.c and uap_txrx.c > > ... but not used in 14 other source files which include 'wmm.h'. > > Fixes the following W=1 kernel build warning(s): > > In file included from drivers/net/wireless/marvell/mwifiex/init.c:25: > driver

Re: [PATCH] libertas_tf: Remove unused macro QOS_CONTROL_LEN

2020-09-01 Thread Kalle Valo
YueHaibing wrote: > There is no caller in tree. > > Signed-off-by: YueHaibing Patch applied to wireless-drivers-next.git, thanks. 2c92790b1203 libertas_tf: Remove unused macro QOS_CONTROL_LEN -- https://patchwork.kernel.org/patch/11744379/ https://wireless.wiki.kernel.org/en/developers/doc

Re: [PATCH 06/28] lib82596: move DMA allocation into the callers of i82596_probe

2020-09-01 Thread Thomas Bogendoerfer
On Wed, Aug 19, 2020 at 08:55:33AM +0200, Christoph Hellwig wrote: > This allows us to get rid of the LIB82596_DMA_ATTR defined and prepare > for untangling the coherent vs non-coherent DMA allocation API. > > Signed-off-by: Christoph Hellwig > --- > drivers/net/ethernet/i825xx/lasi_82596.c | 24

Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-09-01 Thread Vladimir Oltean
Hi Kurt, On Tue, Sep 01, 2020 at 02:50:09PM +0200, Kurt Kanzenbach wrote: > Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are > implementing features needed for Time Sensitive Networking (TSN) such as > support > for the Time Precision Protocol and various shapers like

[PATCH net-next 3/6] net: mvpp2: ensure the port is forced down while changing modes

2020-09-01 Thread Russell King
Ensure that the port is forced down while reconfiguring, controlling this via mac_prepare() and mac_finish() so that it is down while we are configuring our (future) PCS. Signed-off-by: Russell King --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 47 ++- 1 file changed, 36 in

[PATCH net-next 2/6] net: mvpp2: convert to use mac_prepare()/mac_finish()

2020-09-01 Thread Russell King
Convert mvpp2 to use the mac_prepare() and mac_finish() methods in preparation to converting mvpp2 to split-PCS support. Signed-off-by: Russell King --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 48 ++- 1 file changed, 37 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH net-next 0/6] Convert mvpp2 to split PCS support

2020-09-01 Thread Russell King - ARM Linux admin
Hi, This series converts the mvpp2 driver to use the split PCS support that has been merged into phylink last time around. I've been running this for some time here and, apart from the recent bug fix sent to net-next, have not seen any issues on DT based systems. I have not tested ACPI setups, alt

[PATCH net-next 1/6] net: mvpp2: tidy up ACPI hack

2020-09-01 Thread Russell King
Tidy up the ACPI hack so that we can minimise the function prototypes for this. This avoids adding further prototypes unnecessarily. Signed-off-by: Russell King --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 36 +-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --

[PATCH net-next 6/6] net: mvpp2: split xlg and gmac pcs

2020-09-01 Thread Russell King
Split the XLG and GMAC PCS implementations and switch between them during the mac_prepare() method. Signed-off-by: Russell King --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 110 +- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/drivers/net/ethernet/marvell

[PATCH net-next 4/6] net: mvpp2: move GMAC reset handling into mac_prepare()/mac_finish()

2020-09-01 Thread Russell King
Move the GMAC reset handling into mac_prepare() / mac_finish() Signed-off-by: Russell King --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 53 --- 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/et

[PATCH net-next 5/6] net: mvpp2: convert to phylink pcs operations

2020-09-01 Thread Russell King
Convert mvpp2 to phylink's new pcs support. Signed-off-by: Russell King --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h| 1 + .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 292 +++--- 2 files changed, 177 insertions(+), 116 deletions(-) diff --git a/drivers/net/ethernet/marve

Re: [PATCH 08/28] MIPS: make dma_sync_*_for_cpu a little less overzealous

2020-09-01 Thread Thomas Bogendoerfer
On Wed, Aug 19, 2020 at 08:55:35AM +0200, Christoph Hellwig wrote: > When transferring DMA ownership back to the CPU there should never > be any writeback from the cache, as the buffer was owned by the > device until now. Instead it should just be invalidated for the > mapping directions where the

Re: [PATCH 10/28] MIPS/jazzdma: decouple from dma-direct

2020-09-01 Thread Thomas Bogendoerfer
On Wed, Aug 19, 2020 at 08:55:37AM +0200, Christoph Hellwig wrote: > The jazzdma ops implement support for a very basic IOMMU. Thus we really > should not use the dma-direct code that takes physical address limits > into account. This survived through the great MIPS DMA ops cleanup mostly > becau

[PATCH net-next] net/tls: Implement getsockopt SOL_TLS TLS_RX

2020-09-01 Thread Yutaro Hayakawa
From: Yutaro Hayakawa Implement the getsockopt SOL_TLS TLS_RX which is currently missing. The primary usecase is to use it in conjunction with TCP_REPAIR to checkpoint/restore the TLS record layer state. TLS connection state usually exists on the user space library. So basically we can easily ex

Re: [PATCH 09/28] MIPS/jazzdma: remove the unused vdma_remap function

2020-09-01 Thread Thomas Bogendoerfer
On Wed, Aug 19, 2020 at 08:55:36AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > arch/mips/include/asm/jazzdma.h | 2 - > arch/mips/jazz/jazzdma.c| 70 - > 2 files changed, 72 deletions(-) Acked-by: Thomas Bogendoerfer -- C

Re: [27/30] brcmsmac: phy_lcn: Remove a bunch of unused variables

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:11: > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function > ‘wlc_lcnphy_rx_iq_cal’: > drivers/net/wireless/b

Re: [11/30] zd1211rw: zd_chip: Correct misspelled function argument

2020-09-01 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Function > parameter or member 'status' not described in 'zd_rx_rate' > drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Excess function > paramete

[PATCH] pktgen: fix error message with wrong function name

2020-09-01 Thread Leesoo Ahn
Error on calling kthread_create_on_node prints wrong function name, kernel_thread. Signed-off-by: Leesoo Ahn --- net/core/pktgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 95f4c6b8f51a..44fdbb9c6e53 100644 --- a/net/core/pktg

Re: [net] tipc: fix using smp_processor_id() in preemptible

2020-09-01 Thread Eric Dumazet
On 9/1/20 5:18 AM, Tuong Tong Lien wrote: > > >> -Original Message- >> From: Eric Dumazet >> Sent: Monday, August 31, 2020 7:48 PM >> To: Tuong Tong Lien ; Eric Dumazet >> ; da...@davemloft.net; >> jma...@redhat.com; ma...@donjonn.com; ying@windriver.com; >> netdev@vger.kernel.o

[PATCH net-next] liquidio: Remove unneeded cast from memory allocation

2020-09-01 Thread YueHaibing
Remove unneeded return value cast. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c b/drivers/net/ether

Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support

2020-09-01 Thread Kurt Kanzenbach
On Tue Aug 25 2020, Vladimir Oltean wrote: > On Tue, Aug 25, 2020 at 11:23:56AM +0200, Kurt Kanzenbach wrote: >> On Mon Aug 24 2020, Vinicius Costa Gomes wrote: >> > Hi, >> > >> > Kurt Kanzenbach writes: >> > >> [snip] >> >> + /* Setup timer for schedule switch: The IP core only allows to set a >>

[PATCH net-next] net: sungem: Remove unneeded cast from memory allocation

2020-09-01 Thread YueHaibing
Remove dma_alloc_coherent return value cast. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/sun/sungem.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index eeb85

Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-09-01 Thread Vladimir Oltean
On Tue, Sep 01, 2020 at 04:05:42PM +0200, Kurt Kanzenbach wrote: > Hi Vladimir, > > On Tue Sep 01 2020, Vladimir Oltean wrote: > > Hi Kurt, > > > > On Tue, Sep 01, 2020 at 02:50:09PM +0200, Kurt Kanzenbach wrote: > [snip] > >> +struct hellcreek { > >> + const struct hellcreek_platform_data *pdata

[PATCH net-next] net/mlx5e: kTLS, Avoid kzalloc(GFP_KERNEL) under spinlock

2020-09-01 Thread YueHaibing
A spin lock is held before kzalloc, it may sleep with holding the spinlock, so we should use GFP_ATOMIC instead. This is detected by coccinelle. Fixes: 0419d8c9d8f8 ("net/mlx5e: kTLS, Add kTLS RX resync support") Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktl

Re: [PATCH bpf-next v2] bpf: {cpu,dev}map: change various functions return type from int to void

2020-09-01 Thread Daniel Borkmann
On 9/1/20 10:39 AM, Björn Töpel wrote: From: Björn Töpel The functions bq_enqueue(), bq_flush_to_queue(), and bq_xmit_all() in {cpu,dev}map.c always return zero. Changing the return type from int to void makes the code easier to follow. Suggested-by: David Ahern Signed-off-by: Björn Töpel

Re: [PATCH 0/2] prandom_u32: make output less predictable

2020-09-01 Thread Sedat Dilek
gt; Cc: Sedat Dilek > I have tested with the patchset from [1]. ( Later I saw, you dropped "WIP: tcp: reuse incoming skb hash in tcp_conn_request()". ) - Sedat - https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/log/?h=20200901-siphash-noise > -- > 2.28.0

Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-09-01 Thread Kurt Kanzenbach
Hi Vladimir, On Tue Sep 01 2020, Vladimir Oltean wrote: > Hi Kurt, > > On Tue, Sep 01, 2020 at 02:50:09PM +0200, Kurt Kanzenbach wrote: [snip] >> +struct hellcreek { >> +const struct hellcreek_platform_data *pdata; >> +struct device *dev; >> +struct dsa_switch *ds; >> +struct hellc

  1   2   3   >