Re: [PATCH] net: cdc_ncm: Fix build error

YueHaibing writes: > If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails: > > drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to > `usbnet_cdc_update_filter' > > Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this. Ouch. For some reason I assumed that was always s

Re: [PATCH net-next v3 0/3] net: openvswitch: improve codes

On Tue, Aug 25, 2020 at 9:37 AM David Miller wrote: > > From: xiangxia.m@gmail.com > Date: Tue, 25 Aug 2020 13:06:33 +0800 > > > From: Tonghao Zhang > > > > This series patches are not bug fix, just improve codes. > > Pravin, please review this patch series. > Sorry for delay. I will have a l

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

On Tue, Aug 25, 2020 at 8:02 PM Andrew Lunn wrote: > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: > > + if (netif_msg_pktdata(ax_local)) { > > + int loop; > > + netdev_info(ndev, "TX packet len %d, total len %d, seq %d\n", > > +

Re: [PATCH v2 3/6] netlink/compat: Append NLMSG_DONE/extack to frag_list

On Wed, 2020-08-26 at 02:49 +0100, Dmitry Safonov wrote: > Modules those use netlink may supply a 2nd skb, (via frag_list) > that contains an alternative data set meant for applications > using 32bit compatibility mode. Do note, however, that until this day the facility here was only used by (and

Re: [PATCH net-next v2] gtp: add notification mechanism

Le 25/08/2020 à 19:01, Harald Welte a écrit : > Hi Nicolas, > > thanks a lot for your patch. > > On Tue, Aug 25, 2020 at 05:57:15PM +0200, Nicolas Dichtel wrote: >> Like all other network functions, let's notify gtp context on creation and >> deletion. > > While this may be in-line with typical

[PATCH bpf-next] libbpf: Fix unintentional success return code in bpf_object__load

There are code paths where EINVAL is returned directly without setting errno. In that case, errno could be 0, which would mask the failure. For example, if a careless programmer set log_level to 1 out of laziness, they would have to spend a long time trying to figure out why. Fixes: 4f33ddb4e3

Re: [net-next v5 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

On Tue, Aug 25, 2020 at 05:20:03PM -0700, David Miller wrote: > From: Vadym Kochan > Date: Tue, 25 Aug 2020 15:20:08 +0300 > > > +int prestera_dsa_parse(struct prestera_dsa *dsa, const u8 *dsa_buf) > > +{ > > + __be32 *dsa_words = (__be32 *)dsa_buf; > > + enum prestera_dsa_cmd cmd; > > + u3

Re: [PATCH ipsec] xfrmi: drop ignore_df check before updating pmtu

On Mon, Aug 10, 2020 at 02:20:20PM +0200, Sabrina Dubroca wrote: > 2020-08-07, 17:41:09 +0200, Bram Yvakh wrote: > > If the packet doesn't have the DF bit set (so the stack can fragment > the packet at will), or if the stack decided that it can ignore it and > fragment anyway, there's no need to c

Re: WARNING: ODEBUG bug in __do_softirq

syzbot has found a reproducer for the following issue on: HEAD commit:3a00d3df Add linux-next specific files for 20200825 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=15080fa990 kernel config: https://syzkaller.appspot.com/x/.config?x=9ef0a5f95935d4

[PATCH][next] selftests/bpf: fix spelling mistake "scoket" -> "socket"

From: Colin Ian King There is a spelling mistake an a check error message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/bpf/prog_tests/d_path.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/prog_tests/d_path.c b/tools/test

Re: ethernet-phy-ieee802.3-c22 binding and reset-gpios

Hi Andrew, On Tue, Aug 25, 2020 at 03:14:00PM +0200, Andrew Lunn wrote: > On Tue, Aug 25, 2020 at 11:09:33AM +0200, Sascha Hauer wrote: > > Hi All, > > > > I am using the ethernet phy binding here that looks like: > > > > ethphy1: ethernet-phy@1 { > > compatible = "ethernet-phy-ieee802.3-c22

Re: [PATCH v12 bpf-next 10/14] bpf: Add d_path helper

On Tue, Aug 25, 2020 at 03:58:32PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 25, 2020 at 12:23 PM Jiri Olsa wrote: > > #define __BPF_FUNC_MAPPER(FN) \ > > FN(unspec), \ > > @@ -3655,7 +3668,8 @@ union bpf_attr { > > FN(get_task_stack),

Re: [PATCH bpf-next v3 0/4] bpf: verifier: use target program's type for access verifications

Udip Pant writes: > This patch series adds changes in verifier to make decisions such as granting > of read / write access or enforcement of return code status based on > the program type of the target program while using dynamic program > extension (of type BPF_PROG_TYPE_EXT). > > The BPF_PROG_T

Re: [PATCH v12 bpf-next 13/14] selftests/bpf: Add test for d_path helper

On Tue, Aug 25, 2020 at 04:06:14PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 25, 2020 at 12:22 PM Jiri Olsa wrote: > > + > > +static int trigger_fstat_events(pid_t pid) > > +{ > > + int sockfd = -1, procfd = -1, devfd = -1; > > + int localfd = -1, indicatorfd = -1; > > + int

[PATCH 01/30] wireless: marvell: mwifiex: pcie: Move tables to the only place they're used

Saves on 10's of complains about 'defined but not used' variables. Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/marvell/mwifiex/main.h:57, from drivers/net/wireless/marvell/mwifiex/main.c:22: drivers/net/wireless/marvell/mwifiex/pcie.h:310:41: war

[PATCH 09/30] wireless: zydas: zd1211rw: zd_chip: Fix formatting

Kerneldoc expects attributes/parameters to be in '@*.: ' format and gets confused if the variable does not follow the type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Function parameter or member 'rx_frame'

[PATCH 27/30] wireless: broadcom: brcm80211: phy_lcn: Remove a bunch of unused variables

Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:11: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c: In function ‘wlc_lcnphy_rx_iq_cal’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/ph

[PATCH 18/30] wireless: ath: ath9k: ar9001_initvals: Remove unused array 'ar5416Bank6_9100'

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9001_initvals.h:462:18: warning: ‘ar5416Bank6_9100’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.ker

[PATCH 26/30] wireless: ath: ath9k: ar5008_initvals: Move ar5416Bank{0,1,2,3,7} to where they are used

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_initvals.h:627:18: warning: ‘ar5416Bank7’ defined but not used [-Wunused-const-variable=] 627 | static const u32 ar5416Bank7[][2] = { | ^~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:548:18: w

[PATCH 24/30] wireless: marvell: mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused

'mwifiex_1d_to_wmm_queue' is used in'; main.c, txrx.c and uap_txrx.c ... but not used in 14 other source files which include 'wmm.h'. Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/marvell/mwifiex/init.c:25: drivers/net/wireless/marvell/mwifiex/wmm.

[PATCH 16/30] wireless: rsi: rsi_91x_sdio: Fix a few kernel-doc related issues

- File headers do not make for good kernel-doc candidates - Kernel-doc header lines should start with " *" - Fix doc-rot issue Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_sdio.c:25: warning: cannot understand function prototype: 'u16 dev_oper_mode = DEV_

[PATCH 25/30] wireless: ath: ath9k: ar5008_initvals: Remove unused table entirely

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_initvals.h:553:18: warning: ‘ar5416Bank6’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.kernel.o

[PATCH 28/30] wireless: broadcom: brcm80211: phy_n: Remove a bunch of unused variables

Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function ‘wlc_phy_spurwar_nphy’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.

[PATCH 29/30] wireless: broadcom: brcm80211: phytbl_lcn: Remove unused array 'dot11lcnphytbl_rx_gain_info_rev1'

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c:1510:33: warning: ‘dot11lcnphytbl_rx_gain_info_rev1’ defined but not used [-Wunused-const-variable=] Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin C

[PATCH 30/30] wireless: broadcom: brcm80211: phytbl_n: Remove a few unused arrays

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9218:18: warning: ‘papd_cal_scalars_tbl_core1_rev3’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c:9151:18: warning

[PATCH 21/30] wireless: realtek: rtw88: debug: Remove unused variables 'val'

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtw88/debug.c: In function ‘rtw_debug_get_mac_page’: drivers/net/wireless/realtek/rtw88/debug.c:430:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/realtek/rtw88/debug.c:

[PATCH 20/30] wireless: wl3501_cs: Fix a bunch of formatting issues related to function docs

Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/wl3501_cs.c:57: drivers/net/wireless/wl3501_cs.c:143: warning: Function parameter or member 'reg_domain' not described in 'iw_valid_channel' drivers/net/wireless/wl3501_cs.c:143: warning: Function param

[PATCH 19/30] wireless: intersil: hostap: hostap_hw: Remove unused variable 'fc'

Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/intersil/hostap/hostap_cs.c:196: drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_tx_80211’: drivers/net/wireless/intersil/hostap/hostap_hw.c:1806:18: warning: variable ‘fc’ set bu

[PATCH 23/30] wireless: intersil: prism54: isl_ioctl: Remove unused variable 'j'

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intersil/prism54/isl_ioctl.c: In function ‘prism54_update_stats’: drivers/net/wireless/intersil/prism54/isl_ioctl.c:166:6: warning: variable ‘j’ set but not used [-Wunused-but-set-variable] Cc: Luis Chamberlain Cc: Kalle V

[PATCH 22/30] wireless: rsi: rsi_91x_sdio_ops: File headers are not good kernel-doc candidates

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_sdio_ops.c:24: warning: Incorrect use of kernel-doc format: * rsi_sdio_master_access_msword() - This function sets the AHB master access drivers/net/wireless/rsi/rsi_91x_sdio_ops.c:32: warning: Function paramete

[PATCH 15/30] wireless: ti: wlcore: debugfs: Remove unused variable 'res'

Fixes the following W=1 kernel build warning(s): Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Luciano Coelho Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ti/wlcore/debugfs.h | 6 +++--- 1 file changed, 3 insert

[PATCH 10/30] wireless: zydas: zd1211rw: zd_mac: Add missing or incorrect function documentation

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'hw' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'skb' not described in 'zd_m

[PATCH 07/30] wireless: intersil: orinoco_usb: Downgrade non-conforming kernel-doc headers

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intersil/orinoco/orinoco_usb.c:434: warning: Function parameter or member 'upriv' not described in 'ezusb_req_queue_run' drivers/net/wireless/intersil/orinoco/orinoco_usb.c:716: warning: Function parameter or member 'req' no

[PATCH 14/30] wireless: ath: ath6kl: wmi: Remove unused variable 'rate'

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath6kl/wmi.c: In function ‘ath6kl_wmi_bitrate_reply_rx’: drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ set but not used [-Wunused-but-set-variable] Cc: Kalle Valo Cc: "David S. Miller" Cc: Jak

[PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_'

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function parameter 'ptr' description in 'wmi_buffer_block'

[PATCH 17/30] wireless: ath: ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280'

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9002_initvals.h:900:18: warning: ‘ar9280PciePhy_clkreq_off_L1_9280’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-

[PATCH 13/30] wireless: broadcom: brcm80211: brcmfmac: fwsignal: Finish documenting 'brcmf_fws_mac_descriptor'

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:389: warning: Function parameter or member 'name' not described in 'brcmf_fws_mac_descriptor' drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:389: warning: Function paramete

[PATCH 04/30] wireless: intel: iwlegacy: 3945-rs: Remove all non-conformant kernel-doc headers

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlegacy/3945-rs.c:136: warning: Function parameter or member 'rs_sta' not described in 'il3945_rate_scale_flush_wins' drivers/net/wireless/intel/iwlegacy/3945-rs.c:243: warning: Function parameter or member 'rs_sta' n

[PATCH 08/30] wireless: broadcom: brcmsmac: phy_cmn: Remove a unused variables 'vbat' and 'temp'

Fixes the following W=1 kernel build warning(s): In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c:12: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c: In function ‘wlc_phy_upd_env_txpwr_rate_limits’: drivers/net/wireless/broadcom/brcm80211/br

[PATCH 06/30] wireless: broadcom: brcmfmac: p2p: Fix a couple of function headers

Most likely caused by doc-rot. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:977: warning: Function parameter or member 'wdev' not described in 'brcmf_p2p_remain_on_channel' drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2048: w

[PATCH 11/30] wireless: zydas: zd1211rw: zd_chip: Correct misspelled function argument

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Function parameter or member 'status' not described in 'zd_rx_rate' drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1385: warning: Excess function parameter 'rx_status' description in 'z

[PATCH 02/30] wireless: broadcom: brcmsmac: ampdu: Remove a couple set but unused variables

Fixes the following W=1 kernel build warning(s): from drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:18: drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function ‘brcms_c_ampdu_dotxstatus_complete’: drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:850:7: warning:

[PATCH 03/30] wireless: intel: iwlegacy: 3945-mac: Remove all non-conformant kernel-doc headers

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlegacy/3945-mac.c:821: warning: Function parameter or member 'il' not described in 'il3945_setup_handlers' drivers/net/wireless/intel/iwlegacy/3945-mac.c:915: warning: Function parameter or member 'il' not described

[PATCH 05/30] wireless: intel: iwlegacy: 3945: Remove all non-conformant kernel-doc headers

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlegacy/3945.c:104: warning: Function parameter or member 'il' not described in 'il3945_disable_events' drivers/net/wireless/intel/iwlegacy/3945.c:273: warning: Function parameter or member 'il' not described in 'il39

[PATCH 00/30] Set 3: Rid W=1 warnings in Wireless

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. There are quite a few W=1 warnings in the Wireless. My plan is to work through all of them over the next few weeks. Hopefully it won't be too long

Re: [PATCH net-next 1/6] xdp: introduce mb in xdp_buff/xdp_frame

Jesper Dangaard Brouer writes: On Sun, 23 Aug 2020 17:08:30 +0300 Shay Agroskin wrote: > diff --git a/include/net/xdp.h b/include/net/xdp.h > index 3814fb631d52..42f439f9fcda 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -72,7 +72,8 @@ struct xdp_buff { >void *data_ha

[PATCH] net: mdiobus: fix device unregistering in mdiobus_register

__mdiobus_register() can fail between calling device_register() and setting bus->state to MDIOBUS_REGISTERED. When this happens the caller will call mdiobus_free() which then frees the mdio bus structure. This is not allowed as the embedded struct device is already registered, thus must be freed dr

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

On Wed, Aug 26, 2020 at 07:21:35AM +0530, Allen Pais wrote: > On Thu, Aug 20, 2020 at 3:09 AM James Bottomley > wrote: > > > > On Wed, 2020-08-19 at 21:54 +0530, Allen wrote: > > > > [...] > > > > > > Since both threads seem to have petered out, let me suggest in > > > > > > kernel.h: > > > > > >

[PATCH bpf-next] selftests/bpf: Fix open call in trigger_fstat_events

Alexei reported compile breakage on newer systems with following error: In file included from /usr/include/fcntl.h:290:0, 4814 from ./test_progs.h:29, 4815 from .../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:3: 4816In function ‘open’, 4817

Re: [PATCH 25/32] wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming function headers

On 2020-08-21 10:16, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:52: warning: Incorrect use of kernel-doc format: * Addressing - theory of operations drivers/net/wireless/ath/wil6210/wmi.c:70: warning: Incorrect use of kernel-doc fo

Re: [PATCH net backport 5.6.14-5.8.3 v1] net: openvswitch: introduce common code for flushing flows

On Tue, Aug 25, 2020 at 01:25:32PM +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > [ Upstream commit 77b981c82c1df7c7ad32a046f17f007450b46954 ] That is not what this commit is :( Please fix up and resend with the correct commit. thanks, greg k-h

INFO: task can't die in p9_fd_close

Hello, syzbot found the following issue on: HEAD commit:494d311a Add linux-next specific files for 20200821 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=10615b3690 kernel config: https://syzkaller.appspot.com/x/.config?x=a61d44f28687f508 dashboard

Re: INFO: task can't die in p9_fd_close

On Wed, Aug 26, 2020 at 03:38:15AM -0700, syzbot wrote: > console output: https://syzkaller.appspot.com/x/log.txt?x=10615b3690 > kernel config: https://syzkaller.appspot.com/x/.config?x=a61d44f28687f508 > dashboard link: https://syzkaller.appspot.com/bug?extid=fbe34b643e462f65e542 > compiler:

Re: WARNING: ODEBUG bug in __do_softirq

On Wed, Aug 26 2020 at 01:54, syzbot wrote: Cc+: David Howells > syzbot has found a reproducer for the following issue on: > > HEAD commit:3a00d3df Add linux-next specific files for 20200825 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=15080fa99

Re: [PATCH 25/32] wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming function headers

On Wed, 26 Aug 2020, me...@codeaurora.org wrote: > On 2020-08-21 10:16, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/ath/wil6210/wmi.c:52: warning: Incorrect use of > > kernel-doc format: * Addressing - theory of operations > > drivers/net/

[PATCH] rxrpc: Fix memleak in rxkad_verify_response

When kmalloc() on ticket fails, response should be freed to prevent memleak. Signed-off-by: Dinghao Liu --- net/rxrpc/rxkad.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 52a24d4ef5d8..e08130e5746b 100644 --- a/net/rxrpc/rxkad.

Re: [PATCH v2] net: dp83869: Fix RGMII internal delay configuration

Hello On 8/26/20 12:00 AM, Daniel Gorsulowski wrote: The RGMII control register at 0x32 indicates the states for the bits RGMII_TX_CLK_DELAY and RGMII_RX_CLK_DELAY as follows: RGMII Transmit/Receive Clock Delay 0x0 = RGMII transmit clock is shifted with respect to transmit/receive data

[PATCH] netlink: fix a data race in netlink_rcv_wake()

The data races were reported by KCSAN: BUG: KCSAN: data-race in netlink_recvmsg / skb_queue_tail write (marked) to 0x8c0986e5a8c8 of 8 bytes by interrupt on cpu 3: skb_queue_tail+0xcc/0x120 __netlink_sendskb+0x55/0x80 netlink_broadcast_filtered+0x465/0x7e0 nlmsg_notify+0x8f/0x120 rtnl_not

Re: [net-next v5 1/2] seg6: inherit DSCP of inner IPv4 packets

On 26/08/2020 02:45, David Ahern wrote: On 8/25/20 5:45 PM, Ahmed Abdelsalam wrote: Hi David The seg6 encap is implemented through the seg6_lwt rather than seg6_local_lwt. ok. I don't know the seg6 code; just taking a guess from a quick look. We can add a flag(SEG6_IPTUNNEL_DSCP) in seg6

[PATCH net-next 3/3] net/mlx4_en: RX, Add a prefetch command for small L1_CACHE_BYTES

A single cacheline might not contain the packet header for small L1_CACHE_BYTES values. Use net_prefetch() as it issues an additional prefetch in this case. Signed-off-by: Tariq Toukan Reviewed-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- 1 file changed, 1 insertion

[PATCH net-next 0/3] net_prefetch API

Hi, This patchset adds a common net API for L1 cacheline size-aware prefetch. Patch 1 introduces the common API in net and aligns the drivers to use it. Patches 2 and 3 add usage in mlx4 and mlx5 Eth drivers. Series generated against net-next commit: 079f921e9f4d Merge tag 'batadv-next-for-davem

[PATCH net-next 2/3] net/mlx5e: RX, Add a prefetch command for small L1_CACHE_BYTES

A single cacheline might not contain the packet header for small L1_CACHE_BYTES values. Use net_prefetch() as it issues an additional prefetch in this case. Signed-off-by: Tariq Toukan Reviewed-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c| 4 ++-- drivers/net/eth

[PATCH net-next 1/3] net: Take common prefetch code structure into a function

Many device drivers use the same prefetch code structure to deal with small L1 cacheline size. Take this code into a function and call it from the drivers. Suggested-by: Jakub Kicinski Signed-off-by: Tariq Toukan Reviewed-by: Saeed Mahameed --- drivers/net/ethernet/chelsio/cxgb3/sge.c

Re: ethernet-phy-ieee802.3-c22 binding and reset-gpios

On Wed, Aug 26, 2020 at 10:58:57AM +0200, Sascha Hauer wrote: > Hi Andrew, > > Well there is only one phy connected to the bus, so it makes no > difference if I say the reset GPIO is for the whole bus or for a single > phy only. The per bus reset should work, but currently it doesn't. First > reas

Re: [PATCH] net: dp83869: Fix RGMII internal delay configuration

On Tue, Aug 25, 2020 at 02:57:35PM -0500, Dan Murphy wrote: > Andrew > > On 8/25/20 8:37 AM, Andrew Lunn wrote: > > On Tue, Aug 25, 2020 at 02:07:21PM +0200, Daniel Gorsulowski wrote: > > > The RGMII control register at 0x32 indicates the states for the bits > > > RGMII_TX_CLK_DELAY and RGMII_RX_C

Re: [PATCH] net: dp83869: Fix RGMII internal delay configuration

Andrew On 8/26/20 7:58 AM, Andrew Lunn wrote: On Tue, Aug 25, 2020 at 02:57:35PM -0500, Dan Murphy wrote: Andrew On 8/25/20 8:37 AM, Andrew Lunn wrote: On Tue, Aug 25, 2020 at 02:07:21PM +0200, Daniel Gorsulowski wrote: The RGMII control register at 0x32 indicates the states for the bits RGM

Re: [net-next v5 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

> There is a limitation on the DMA range. Current device can't handle > whole ZONE_DMA range, so there is a "backup" mechanism which copies the > entire packet if the mapping was failed or if the packet's mapped > address is out of this range, this is done on both rx and tx directions. If you use

[PATCHv9 bpf-next 4/5] selftests/bpf: add xdp_redirect_multi test

Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test we have 3 forward groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. We will also test both DEVMAP and DEVMAP_HASH

[PATCHv9 bpf-next 0/5] xdp: add a new helper for dev map multicast support

This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv9 bpf-next 5/5] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL

Use helper bpf_redirect_map() and bpf_redirect_map_multi() to test bpf arg ARG_CONST_MAP_PTR and ARG_CONST_MAP_PTR_OR_NULL. Make sure the map arg could be verified correctly when it is NULL or valid map pointer. Add devmap and devmap_hash in struct bpf_test due to bpf_redirect_{map, map_multi} lim

[PATCHv9 bpf-next 2/5] xdp: add a new helper for dev map multicast support

This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv9 bpf-next 3/5] sample/bpf: add xdp_redirect_map_multicast test

This is a sample for xdp multicast. In the sample we could forward all packets between given interfaces. Signed-off-by: Hangbin Liu --- v9: use NULL directly for arg2 and redefine the maps with btf format v6-v8: no update v5: add a null_map as we have strict the arg2 to ARG_CONST_MAP_PTR. Mo

[PATCHv9 bpf-next 1/5] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be used when we want to allow NULL pointer for map parameter. The bpf helper need to take care and check if the map is NULL when use this type. Signed-off-by: Hangbin Liu --- v9: merge the patch from [1] in to this series. v1-v8:

[GIT PULL] virtio: bugfixes

The following changes since commit d012a7190fc1fd72ed48911e77ca97ba4521bccd: Linux 5.9-rc2 (2020-08-23 14:08:43 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to cbb523594eb718944b726ba5

Re: [PATCH bpf-next] selftests/bpf: Fix open call in trigger_fstat_events

On Wed, Aug 26, 2020 at 3:19 AM Jiri Olsa wrote: > > Alexei reported compile breakage on newer systems with > following error: > > In file included from /usr/include/fcntl.h:290:0, > 4814 from ./test_progs.h:29, > 4815 from > .../bpf-next/tools/testing/selft

Re: [PATCH] net: hns3: Fix for geneve tx checksum bug

From: Yi Li Date: Wed, 26 Aug 2020 13:11:50 +0800 > when skb->encapsulation is 0, skb->ip_summed is CHECKSUM_PARTIAL > and it is udp packet, which has a dest port as the IANA assigned. > the hardware is expected to do the checksum offload, but the > hardware will not do the checksum offload when

WARNING: refcount bug in qdisc_put (2)

Hello, syzbot found the following issue on: HEAD commit:6a9dc5fd lib: Revert use of fallthrough pseudo-keyword in .. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15ee850e90 kernel config: https://syzkaller.appspot.com/x/.config?x=978db74cb30aa994 das

Re: [PATCH] net: cdc_ncm: Fix build error

From: YueHaibing Date: Wed, 26 Aug 2020 14:52:31 +0800 > If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails: > > drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to > `usbnet_cdc_update_filter' > > Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this. > > Reported

Re: [net-next v5 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

From: Vadym Kochan Date: Wed, 26 Aug 2020 11:17:44 +0300 > Initially there was (in RFC patch set), not locking, but _rcu list API > used, because the port list is modified only by 1 writer when creating > the port or deleting it on switch uninit (the really theoretical case > which might happen i

Re: Regarding possible bug in net/wan/x25_asy.c

On Mon, Aug 24, 2020 at 01:49:04PM -0700, Xie He wrote: > On Mon, Aug 24, 2020 at 7:13 AM Madhuparna Bhowmik > wrote: > > > > Sure, I had a look at it and since you are already working on fixing > > this driver, don't think there is a need for a patch to fix the > > particular race condition bug.

WARNING: refcount bug in red_destroy

Hello, syzbot found the following issue on: HEAD commit:6a9dc5fd lib: Revert use of fallthrough pseudo-keyword in .. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15c685ee90 kernel config: https://syzkaller.appspot.com/x/.config?x=891ca5711a9f1650 das

general protection fault in nexthop_is_blackhole

Hello, syzbot found the following issue on: HEAD commit:c3d8f220 Merge tag 'kbuild-fixes-v5.9' of git://git.kernel.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11c48c9690 kernel config: https://syzkaller.appspot.com/x/.config?x=bb68b9e8a8cc842f das

general protection fault in rt6_fill_node

Hello, syzbot found the following issue on: HEAD commit:d7223aa5 Merge branch 'l2tp-replace-custom-logging-code-wi.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1399802e90 kernel config: https://syzkaller.appspot.com/x/.config?x=3d400a47d1416652 das

Re: [PATCH net-next] inet: remove inet_sk_copy_descendant()

From: Eric Dumazet Date: Wed, 26 Aug 2020 06:50:16 -0700 > This is no longer used, SCTP now uses a private helper. > > Signed-off-by: Eric Dumazet Applied, thanks Eric.

Re: [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

>This doesn't seem appropriate at all. If anything UC addresses >should be blocked and the Intel driver change reverted. We have >a well defined way to add secondary UC addresses and the MC interfaces >are not it. As I understand by ‘well defined way’ you mean macvlan feature. But macvlan is mo

Re: [PATCH 00/49] DRM driver for Hikey 970

Le mardi 25 août 2020 à 13:30 +0200, Mauro Carvalho Chehab a écrit : > Em Tue, 25 Aug 2020 05:29:29 +1000 > Dave Airlie escreveu: > > > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart > > wrote: > > > Hi Mauro, > > > > > > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

Douglas Anderson wrote: > If we have a per CE (Copy Engine) IRQ then we have no summary > register. Right now the code generates a summary register by > iterating over all copy engines and seeing if they have an interrupt > pending. > > This has a problem. Specifically if _none_ if the Copy En

Re: [PATCH net-next 3/3] net/mlx4_en: RX, Add a prefetch command for small L1_CACHE_BYTES

On 8/26/20 5:54 AM, Tariq Toukan wrote: > A single cacheline might not contain the packet header for > small L1_CACHE_BYTES values. > Use net_prefetch() as it issues an additional prefetch > in this case. > > Signed-off-by: Tariq Toukan > Reviewed-by: Saeed Mahameed > --- > drivers/net/ether

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote: > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >>

Re: [PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

Hi, On Wed, Aug 26, 2020 at 7:51 AM Kalle Valo wrote: > > Douglas Anderson wrote: > > > If we have a per CE (Copy Engine) IRQ then we have no summary > > register. Right now the code generates a summary register by > > iterating over all copy engines and seeing if they have an interrupt > > pen

RE: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

From: Lukasz Stelmach > Sent: 26 August 2020 15:59 > > It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote: > > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: > >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > >> connected to a CPU with a 8/16-bit

[PATCH v20 06/23] LSM: Use lsmblob in security_secctx_to_secid

Change security_secctx_to_secid() to fill in a lsmblob instead of a u32 secid. Multiple LSMs may be able to interpret the string, and this allows for setting whichever secid is appropriate. Change security_secmark_relabel_packet() to use a lsmblob instead of a u32 secid. In some other cases there i

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

On Wed, Aug 26, 2020 at 12:55:28PM +0300, Dan Carpenter wrote: > On Wed, Aug 26, 2020 at 07:21:35AM +0530, Allen Pais wrote: > > On Thu, Aug 20, 2020 at 3:09 AM James Bottomley > > wrote: > > > > > > On Wed, 2020-08-19 at 21:54 +0530, Allen wrote: > > > > > [...] > > > > > > > Since both threads s

[PATCH v20 14/23] LSM: Ensure the correct LSM context releaser

Add a new lsmcontext data structure to hold all the information about a "security context", including the string, its size and which LSM allocated the string. The allocation information is necessary because LSMs have different policies regarding the lifecycle of these strings. SELinux allocates and

[PATCH v20 15/23] LSM: Use lsmcontext in security_secid_to_secctx

Replace the (secctx,seclen) pointer pair with a single lsmcontext pointer to allow return of the LSM identifier along with the context and context length. This allows security_release_secctx() to know how to release the context. Callers have been modified to use or save the returned data from the n

[PATCH net-next v5 1/3] smsc95xx: remove redundant function arguments

This patch removes arguments netdev and phy_id from the functions smsc95xx_mdio_read_nopm and smsc95xx_mdio_write_nopm. Both removed arguments are recovered from a new argument `struct usbnet *dev`. Signed-off-by: Andre Edich --- drivers/net/usb/smsc95xx.c | 35 +

[PATCH v20 17/23] LSM: security_secid_to_secctx in netlink netfilter

Change netlink netfilter interfaces to use lsmcontext pointers, and remove scaffolding. Reviewed-by: Kees Cook Reviewed-by: John Johansen Acked-by: Stephen Smalley Signed-off-by: Casey Schaufler cc: netdev@vger.kernel.org --- net/netfilter/nfnetlink_queue.c | 31 --

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

On Mon, Aug 24, 2020 at 10:25:45AM -0700, David Miller wrote: > From: Mira Ressel > Date: Mon, 24 Aug 2020 14:38:26 + > > > Set the perm_addr of veth devices to whatever MAC has been assigned to > > the device. Otherwise, it remains all zero, with the consequence that > > ipv6_generate_stable

[PATCH v20 18/23] NET: Store LSM netlabel data in a lsmblob

Netlabel uses LSM interfaces requiring an lsmblob and the internal storage is used to pass information between these interfaces, so change the internal data from a secid to a lsmblob. Update the netlabel interfaces and their callers to accommodate the change. This requires that the modules using ne

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

From: Mira Ressel Date: Wed, 26 Aug 2020 15:20:00 + > I'm setting the peer->perm_addr, which would otherwise be zero, to its > dev_addr, which has been either generated randomly by the kernel or > provided by userland in a netlink attribute. Which by definition makes it not necessarily a "pe

  1   2   3   >