Em Wed, 19 Aug 2020 12:52:06 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart
> wrote:
> > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> > > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> > > > This patch series port t
Hi Sam,
Em Wed, 19 Aug 2020 22:48:00 +0200
Sam Ravnborg escreveu:
> Hi Mauro.
>
> It seems my review comments failed to reach dri-devel - likely due to
> the size of the mail.
Probably. It reached here properly.
> Link:
> https://lore.kernel.org/linux-devicetree/20200819173558.ga3...@ravnborg
On 2020-08-19 10:48 p.m., Sam Ravnborg wrote:
> Hi Mauro.
>
> It seems my review comments failed to reach dri-devel - likely due to
> the size of the mail.
Right, some e-mails in this thread went through the dri-devel moderation
queue due to their sizes. This mail of yours did as well, because yo
b->media->send_msg() requires rcu_read_lock(), as we can see
elsewhere in tipc, tipc_bearer_xmit, tipc_bearer_xmit_skb
and tipc_bearer_bc_xmit().
Syzbot has reported this issue as:
net/tipc/bearer.c:466 suspicious rcu_dereference_check() usage!
Workqueue: cryptd cryptd_queue_worker
Call Tr
Hi Josh,
On Fri, Jul 3, 2020 at 2:14 AM Josh Hunt wrote:
{snip}
> Initial results with Cong's patch look promising, so far no stalls. We
> will let it run over the long weekend and report back on Tuesday.
>
> Paolo - I have concerns about possible performance regression with the
> change as well.
On Wed, 19 Aug 2020 14:58:05 -0700
John Fastabend wrote:
> Jakub Kicinski wrote:
> > On Wed, 19 Aug 2020 22:22:23 +0200 Lorenzo Bianconi wrote:
> > > > On Wed, 19 Aug 2020 15:13:51 +0200 Lorenzo Bianconi wrote:
> > > > > Enable the capability to receive jumbo frames even if the interface is
Em Wed, 19 Aug 2020 20:28:44 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote:
> >
> > On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote:
> >
> > >
> > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> > > wrote:
> > > > So, IMO, the best is to keep
On Wed, 19 Aug 2020 15:13:49 +0200
Lorenzo Bianconi wrote:
> diff --git a/net/core/xdp.c b/net/core/xdp.c
> index 884f140fc3be..006b24b5d276 100644
> --- a/net/core/xdp.c
> +++ b/net/core/xdp.c
> @@ -370,19 +370,55 @@ static void __xdp_return(void *data, struct
> xdp_mem_info *mem, bool napi_dir
> Jakub Kicinski wrote:
> > On Wed, 19 Aug 2020 22:22:23 +0200 Lorenzo Bianconi wrote:
> > > > On Wed, 19 Aug 2020 15:13:51 +0200 Lorenzo Bianconi wrote:
> > > > > Enable the capability to receive jumbo frames even if the interface is
> > > > > running in XDP mode
> > > > >
> > > > > Signed-off-
> On Wed, 19 Aug 2020 15:13:49 +0200
> Lorenzo Bianconi wrote:
>
> > diff --git a/net/core/xdp.c b/net/core/xdp.c
> > index 884f140fc3be..006b24b5d276 100644
> > --- a/net/core/xdp.c
> > +++ b/net/core/xdp.c
> > @@ -370,19 +370,55 @@ static void __xdp_return(void *data, struct
> > xdp_mem_info *
On Wed, 19 Aug 2020 15:13:48 +0200
Lorenzo Bianconi wrote:
> Update multi-buffer bit (mb) in xdp_buff to notify XDP/eBPF layer and
> XDP remote drivers if this is a "non-linear" XDP buffer
>
> Signed-off-by: Lorenzo Bianconi
> ---
> drivers/net/ethernet/marvell/mvneta.c | 3 +++
> 1 file chang
Em Wed, 19 Aug 2020 14:36:52 -0700
John Stultz escreveu:
> On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> wrote:
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
> >
> > I added this series, together with the regulator driver and
>
On Thu, Aug 20, 2020 at 08:58:38AM +0200, Willy Tarreau wrote:
> I've just pushed a new branch "20200820-siphash-noise" that I also
> rebased onto latest master. It's currently running make allmodconfig
> here, so that will take a while, but I think it's OK as ran
The Hirschmann Hellcreek TSN switches have a special tagging protocol for frames
exchanged between the CPU port and the master interface. The format is a one
byte trailer indicating the destination or origin port.
It's quite similar to the Micrel KSZ tagging. That's why the implementation is
based
The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic
schedules may be configured individually on each front port. Each port has eight
egress queues. The traffic is mapped to a traffic class respectively via the PCP
field of a VLAN tagged frame.
The TAPRIO Qdisc already implemen
Hi,
this series adds a DSA driver for the Hirschmann Hellcreek TSN switch
IP. Characteristics of that IP:
* Full duplex Ethernet interface at 100/1000 Mbps on three ports
* IEEE 802.1Q-compliant Ethernet Switch
* IEEE 802.1Qbv Time-Aware scheduling support
* IEEE 1588 and IEEE 802.1AS support
Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are
implementing features needed for Time Sensitive Networking (TSN) such as support
for the Time Precision Protocol and various shapers like the Time Aware Shaper.
This driver includes basic support for networking:
* VLAN
> On Wed, 19 Aug 2020 15:13:48 +0200
> Lorenzo Bianconi wrote:
>
> > Update multi-buffer bit (mb) in xdp_buff to notify XDP/eBPF layer and
> > XDP remote drivers if this is a "non-linear" XDP buffer
> >
> > Signed-off-by: Lorenzo Bianconi
> > ---
> > drivers/net/ethernet/marvell/mvneta.c | 3 +
The switch has two controllable I/Os which are usually connected to LEDs. This
is useful to immediately visually see the PTP status.
These provide two signals:
* is_gm
This LED can be activated if the current device is the grand master in that
PTP domain.
* sync_good
This LED can be
Add basic documentation and example.
Signed-off-by: Kurt Kanzenbach
---
.../bindings/net/dsa/hellcreek.yaml | 125 ++
1 file changed, 125 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/dsa/hellcreek.yaml
diff --git a/Documentation/devicetree/bi
Hirschmann is building devices for automation and networking. Add them to the
vendor prefixes.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Florian Fainelli
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Doc
From: Kamil Alkhouri
The switch has the ability to take hardware generated time stamps per port for
PTPv2 event messages in Rx and Tx direction. That is useful for achieving needed
time synchronization precision for TSN devices/switches. So add support for it.
There are two directions:
* RX
From: Kamil Alkhouri
The switch has internal PTP hardware clocks. Add support for it. There are three
clocks:
* Synchronized
* Syntonized
* Free running
Currently the synchronized clock is exported to user space which is a good
default for the beginning. The free running clock might be expor
> 7f0a838254bd ("bpf, xdp: Maintain info on attached XDP BPF programs in
> net_device")
> inadvertently changed which XDP mode is assumed when no mode flags are
> specified explicitly. Previously, driver mode was preferred, if driver
> supported it. If not, generic SKB mode was chosen. That commit
On Wed, 19 Aug 2020 13:57:51 -0700
Andrii Nakryiko wrote:
> On Wed, Aug 19, 2020 at 2:29 AM Lorenzo Bianconi wrote:
> >
> > Hi Andrii,
> >
> > working on xdp multi-buff I figured out now xdp generic is the default
> > choice
> > if not specified by userspace. In particular after commit 7f0a8382
Hi Andrew,
On Fri, Aug 14, 2020 at 03:18:15PM +0200, Andrew Lunn wrote:
> > > > Currently
> > > >
> > > > compatible = "marvell,prestera"
> > > >
> > > > is used as default, so may be
> > > >
> > > > you mean to support few matching including particular silicon too, like
> > > > ?
> > > >
Fixed flash presence check for 82576 controllers so the part
number string is read the displayed correctly.
Signed-off-by: Gal Hammer
---
drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/
On Thu, Aug 20, 2020 at 1:22 AM David Miller wrote:
>
> From: "Jason A. Donenfeld"
> Date: Sat, 15 Aug 2020 09:41:02 +0200
>
> > A user reported that packets from wireguard were possibly ignored by XDP
> > [1]. Another user reported that modifying packets from layer 3
> > interfaces results in im
From: Kees Cook
commit 4969f8a073977123504609d7310b42a588297aa4 upstream.
The sock counting (sock_update_netprioidx() and sock_update_classid())
was missing from pidfd's implementation of received fd installation. Add
a call to the new __receive_sock() helper.
Cc: Christian Brauner
Cc: Christo
Thanks for submitting the patch. The code changes looks okay to me.
The driver is now moved out of staging so 'staging' prefix is not
required in subject. For future patches on wilc driver, the 'staging'
prefix can be removed.
For this patch, I am not sure if Kalle can apply as is otherwise pleas
From: Kees Cook
commit 4969f8a073977123504609d7310b42a588297aa4 upstream.
The sock counting (sock_update_netprioidx() and sock_update_classid())
was missing from pidfd's implementation of received fd installation. Add
a call to the new __receive_sock() helper.
Cc: Christian Brauner
Cc: Christo
On 20/08/20 11:18 am, Dinghao Liu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> When devm_clk_get() returns -EPROBE_DEFER, sdio_priv
> should be freed just like when wilc_cfg80211_init()
> fails.
>
> Fixes: 8692b047e86cf ("staging: wil
On 20/08/20 11:22 am, Dinghao Liu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> When devm_clk_get() returns -EPROBE_DEFER, spi_priv
> should be freed just like when wilc_cfg80211_init()
> fails.
>
> Fixes: 854d66df74aed ("staging: wil
The phy-connection-type parameter is described in ePAPR 1.1:
Specifies interface type between the Ethernet device and a physical
layer (PHY) device. The value of this property is specific to the
implementation.
Signed-off-by: Madalin Bucur
---
Documentation/devicetree/bindings/net/ethernet-cont
On Tue, Aug 18, 2020 at 08:19 PM CEST, Alexei Starovoitov wrote:
> On Tue, Aug 18, 2020 at 8:49 AM Jakub Sitnicki wrote:
>> : rcu_read_lock();
>> : run_array =
>> rcu_dereference(net->bpf.run_array[NETNS_BPF_SK_LOOKUP]);
>> 0.01 :
On Thu, Aug 20, 2020 at 7:02 AM Christoph Hellwig wrote:
>
> On Wed, Aug 19, 2020 at 03:07:04PM +0100, Robin Murphy wrote:
> >> FWIW, I asked back in time what the plan is for non-coherent
> >> allocations and it seemed like DMA_ATTR_NON_CONSISTENT and
> >> dma_sync_*() was supposed to be the righ
Hi,
On Wed, 2020-08-19 at 20:23 -0700, Yonghong Song wrote:
> On 8/19/20 7:27 PM, Fāng-ruì Sòng wrote:
> > > > >
> > I think this is resolve_btfids's bug. GNU ld and LLD are innocent.
> > These .debug_* sections work fine if their sh_addralign is 1.
> > When the section flag SHF_COMPRESSED is set
On Tue, Apr 28, 2020 at 10:11:19PM +0200, Daniel Borkmann wrote:
> > https://lore.kernel.org/netdev/bbdee6355234e730ef686f9321bd072bcf4bb232.1584523237.git.dan...@iogearbox.net/
> >
> > In the ensuing discussion it turned out that the performance argument
> > may be addressed by a rearrangement of
On Wed, Aug 19, 2020 at 08:23:10PM -0700, Yonghong Song wrote:
>
>
> On 8/19/20 7:27 PM, Fāng-ruì Sòng wrote:
> > > > > section(36) .comment, size 44, link 0, flags 30, type=1
> > > > > section(37) .debug_aranges, size 45684, link 0, flags 800, type=1
> > > > > - fixing wrong alignme
>> implemented a read callback with an udelay(1U). This fails to
>> compile on ARM because the delay is >1ms. I doubt that it is needed to
>> spin for 10ms even if possible on x86.
>>
>> >From looking at the code, the context appears to be preemptible so
> using
>> usleep() should work and av
Truncation of DMA_BIT_MASK to 32-bit dma_addr_t is semantically safe,
but the compiler was warning because it was happening implicitly.
Insert explicit casts to suppress the warnings.
Reported-by: Randy Dunlap
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100.c | 8
1 file
On Tue, Jul 28, 2020 at 21:09:10 +0200, Stephan Mueller wrote:
> Am Dienstag, 28. Juli 2020, 17:47:30 CEST schrieb Antony Antony:
>
> Hi Antony,
>
> > when enabled, 1, redact XFRM SA secret in the netlink response to
> > xfrm_get_sa() or dump all sa.
> >
> > e.g
> > echo 1 > /proc/sys/net/core/x
When using the ETF Qdisc in combination with a bridge and DSA, then all packets
gets dropped due to invalid time stamps. The setup looks like this:
Transmit path:
Application -> bridge (br0) -> DSA slave ports (lan0, lan1) -> ETF Qdisc
-> ethernet (eth0)
The user space application us
IPv6 filters can occupy up to 4 slots and will exhaust HPFILTER
region much sooner. So, continue searching for free slots in the
HASH or NORMAL filter regions, as long as the rule's priority does
not conflict with existing rules in those regions.
Signed-off-by: Rahul Kundu
---
.../net/ethernet/c
On Thu, Aug 20, 2020 at 6:45 AM Christoph Hellwig wrote:
>
> On Wed, Aug 19, 2020 at 04:11:52PM +0200, Tomasz Figa wrote:
> > > > By the way, as a videobuf2 reviewer, I'd appreciate being CC'd on any
> > > > series related to the subsystem-facing DMA API changes, since
> > > > videobuf2 is one of
On 8/20/20 1:57 PM, Kurt Kanzenbach wrote:
When using the ETF Qdisc in combination with a bridge and DSA, then all packets
gets dropped due to invalid time stamps. The setup looks like this:
Transmit path:
Application -> bridge (br0) -> DSA slave ports (lan0, lan1) -> ETF Qdisc
->
On Wed, 19 Aug 2020 at 23:41, John Fastabend wrote:
>
> John Fastabend wrote:
> > Lorenz Bauer wrote:
> > > Allow calling bpf_map_update_elem on sockmap and sockhash from a BPF
> > > context. The synchronization required for this is a bit fiddly: we
> > > need to prevent the socket from changing i
On Thu, Aug 20, 2020 at 7:20 AM Christoph Hellwig wrote:
>
> On Thu, Aug 20, 2020 at 06:43:47AM +0200, Christoph Hellwig wrote:
> > On Wed, Aug 19, 2020 at 03:57:53PM +0200, Tomasz Figa wrote:
> > > > > Could you explain what makes you think it's unused? It's a feature of
> > > > > the UAPI genera
The for loop in i40e_set_vsi_promisc() reports errors via dev_err() but
does not propage the error up the call chain. Instead it continues the
loop and potentially overwrites the reported error value.
This results in the error being recorded in the log buffer, but the
caller might never know anythi
On 20.08.2020 12:43, Yuusuke Ashizuka wrote:
When this driver is built as a module, I cannot rmmod it after insmoding
it.
This is because that this driver calls ravb_mdio_init() at the time of
"That" not needed here at all; perhaps can be fixed while applying...
probe, and module->refcnt
Hi Mauro,
On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 19 Aug 2020 12:52:06 -0700 John Stultz escreveu:
> > On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart wrote:
> > > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> > > > On Wed, Aug 19, 2020
External Email
Hi Andrew,
My name is Mickey and I'm the SW group manager in Marvell working on the
Switchdev drivers for the Prestera Switching family.
In addition to Vadym's reply, please have my comments inline;
On Fri, Aug 14, 2020 at 03:18:15PM +0200, Andrew Lunn wrote:
> > > > > Currently
On Wed, 19 Aug 2020 at 21:46, Yonghong Song wrote:
>
>
>
> On 8/19/20 2:24 AM, Lorenz Bauer wrote:
> > Add a test which copies a socket from a sockmap into another sockmap
> > or sockhash. This excercises bpf_map_update_elem support from BPF
> > context. Compare the socket cookies from source and
The ath9k_htc driver hides all LEDs related code behind
CONFIG_MAC80211_LEDS ifdefs so it does not really require the
MAC80211_LEDS. The code builds and works just fine. Convert the
"select" into "imply" to allow disabling LED trigger when not needed.
Signed-off-by: Krzysztof Kozlowski
---
dri
when enabled, 1, redact XFRM SA secret in the netlink response to
xfrm_get_sa() or dump all sa.
e.g
echo 1 > /proc/sys/net/core/xfrm_redact_secret
ip xfrm state
src 172.16.1.200 dst 172.16.1.100
proto esp spi 0x0002 reqid 2 mode tunnel
replay-window 0
aead rfc4106(gcm(a
On Thu, Aug 20, 2020 at 10:05 AM Willy Tarreau wrote:
>
> On Thu, Aug 20, 2020 at 08:58:38AM +0200, Willy Tarreau wrote:
> > I've just pushed a new branch "20200820-siphash-noise" that I also
> > rebased onto latest master. It's currently running make allm
add debugfs node for querying sq/rq info, mac table, sq ci table,
rq cqe info, global table, function table, port and vlan table.
Signed-off-by: Luo bin
---
drivers/net/ethernet/huawei/hinic/Makefile|3 +-
.../net/ethernet/huawei/hinic/hinic_debugfs.c | 1354 +
.../net/et
Hi Guys,
>> so when I take empty object and compile like:
>>
>> $ echo 'int main(int argc, char **argv) { return 0; }' | gcc -c -o ex.o -g
>> -gz=zlib -x c -
>> $ ld -o ex --compress-debug-sections=zlib ex.o
Thanks Mark. I have now created a binutils PR for this bug, and I am looking
into
From: Jakub Sitnicki
> Sent: 20 August 2020 11:30
> Subject: Re: BPF sk_lookup v5 - TCP SYN and UDP 0-len flood benchmarks
>
> On Tue, Aug 18, 2020 at 08:19 PM CEST, Alexei Starovoitov wrote:
> > On Tue, Aug 18, 2020 at 8:49 AM Jakub Sitnicki wrote:
> >> : rcu_read_l
On Thu, 2020-08-20 at 11:47 +0200, Jason A. Donenfeld wrote:
> On Wed, Aug 19, 2020 at 8:42 PM syzbot
> wrote:
> > syzbot has bisected this issue to:
> >
> > commit e7096c131e5161fa3b8e52a650d7719d2857adfd
> > Author: Jason A. Donenfeld
> > Date: Sun Dec 8 23:27:34 2019 +
> >
> > net:
On 8/19/20 3:45 PM, Geert Uytterhoeven wrote:
> - Remove pinctrl consumer properties, as they are handled by core
So you're removing them even from the example?
> dt-schema,
> - Document missing properties,
> - Document missing PHY child node,
> - Add "additionalProperties: false"
Also, s/Fixed/fix/ in the subject. Nearly missed it. :-)
skb_mpls_push() and skb_mpls_pop() expect skb->data at mac header. Check
this assumption or we would get wrong mac_header and network_header.
Signed-off-by: Miaohe Lin
---
net/core/skbuff.c | 8
1 file changed, 8 insertions(+)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index e1
On 8/20/20 3:29 PM, Sergei Shtylyov wrote:
>Also, s/Fixed/fix/ in the subject. Nearly missed it. :-)
And overall, I'd call the patch "ravb: fix module unloading".
MBR, Sergei
On Wed, 19 Aug 2020 at 21:13, Yonghong Song wrote:
>
>
>
> On 8/19/20 2:24 AM, Lorenz Bauer wrote:
> > The verifier assumes that map values are simple blobs of memory, and
> > therefore treats ARG_PTR_TO_MAP_VALUE, etc. as such. However, there are
> > map types where this isn't true. For example,
On Wed, Aug 19, 2020 at 8:42 PM syzbot
wrote:
>
> syzbot has bisected this issue to:
>
> commit e7096c131e5161fa3b8e52a650d7719d2857adfd
> Author: Jason A. Donenfeld
> Date: Sun Dec 8 23:27:34 2019 +
>
> net: WireGuard secure network tunnel
>
> bisection log: https://syzkaller.appspot.
When this driver is built as a module, I cannot rmmod it after insmoding
it.
This is because that this driver calls ravb_mdio_init() at the time of
probe, and module->refcnt is incremented by alloc_mdio_bitbang() called
after that.
Therefore, even if ifup is not performed, the driver is in use and
On Tue, Jul 28, 2020 at 01:07:14AM +, Jianyong Wu wrote:
>
>
> > -Original Message-
> > From: Will Deacon
> > Sent: Monday, July 27, 2020 7:38 PM
> > To: Jianyong Wu
> > Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> > t...@linutronix.de; pbonz...@redhat.co
Hi Sergei,
On Thu, Aug 20, 2020 at 2:26 PM Sergei Shtylyov
wrote:
> On 8/19/20 3:45 PM, Geert Uytterhoeven wrote:
>
> > - Remove pinctrl consumer properties, as they are handled by core
>
>So you're removing them even from the example?
Yes, as they're completely generic.
> > dt-schema
On Sat, May 02, 2020 at 04:26:56PM +0200, Wolfram Sang wrote:
> The 'pengutronix' address is defunct for years. Use the proper contact
> address.
>
> Signed-off-by: Wolfram Sang
Ping?
> ---
> drivers/net/can/mscan/mpc5xxx_can.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On 8/19/20 11:48 PM, Xin Long wrote:
> With disabling bh in the whole sctp_get_port_local(), when
> snum == 0 and too many ports have been used, the do-while
> loop will take the cpu for a long time and cause cpu stuck:
>
> [ ] watchdog: BUG: soft lockup - CPU#11 stuck for 22s!
> [ ] RIP: 0
General issue (that I think must be resolved/discussed as part of this initial
patchset).
When XDP_REDIRECT'ing a multi-buffer xdp_frame out of another driver's
ndo_xdp_xmit(), what happens if the remote driver doesn't understand the
multi-buffer format?
My guess it that it will only send the f
Hi,
On Wed, Aug 19, 2020 at 9:08 PM Jesse Brandeburg
wrote:
>
> sundeep.l...@gmail.com wrote:
>
> > From: Zyta Szpak
> >
> > Four new mbox messages ids and handler are added in order to
> > enable or disable timestamping procedure on tx and rx side.
> > Additionally when PTP is enabled, the pack
On Wed, Aug 19, 2020 at 02:40:52PM +, David Laight wrote:
>
> The number of output and input streams was never being reduced, eg when
> processing received INIT or INIT_ACK chunks.
> The effect is that DATA chunks can be sent with invalid stream ids
> and then discarded by the remote system.
>
>
>
> General issue (that I think must be resolved/discussed as part of this initial
> patchset).
I was thinking about this issue as well.
>
> When XDP_REDIRECT'ing a multi-buffer xdp_frame out of another driver's
> ndo_xdp_xmit(), what happens if the remote driver doesn't understand the
> multi-
Hi,
On Wed, Aug 19, 2020 at 9:30 PM Jesse Brandeburg
wrote:
>
> sundeep.l...@gmail.com wrote:
>
> > From: Aleksey Makarov
> >
> > This patch adds driver for Precision Time
> > Protocol Clock and Timestamping block found on
> > Octeontx2 platform. The driver does initial
> > configuration and exp
Hi,
On Wed, Aug 19, 2020 at 10:30 PM Jesse Brandeburg
wrote:
>
> sundeep.l...@gmail.com wrote:
>
> > From: Aleksey Makarov
> >
> > This patch adds PTP clock and uses it in Octeontx2
> > network device. PTP clock uses mailbox calls to
> > access the hardware counter on the RVU side.
> >
> > Co-de
From: Amit Cohen
Similar to other print functions we need to flush buffered data
in order to work with pipes and output redirects.
Without it, stdout output is buffered and not written to the disk.
This is useful when writing scripts that rely on devlink-monitor output.
Signed-off-by: Amit Coh
Em Wed, 19 Aug 2020 19:35:58 +0200
Sam Ravnborg escreveu:
I'm already handling the other comments from your review (I'll send a
more complete comment about them after finishing), but I have a doubt
what you meant about this:
> +static int kirin_drm_bind(struct device *dev)
> > +{
> > + struct
Don't go via map->ops to call sock_map_update_elem, since we know
what function to call in bpf_map_update_value. Since we currently
don't allow calling map_update_elem from BPF context, we can remove
ops->map_update_elem and rename the function to sock_map_update_elem_sys.
Signed-off-by: Lorenz Ba
Add a test which copies a socket from a sockmap into another sockmap
or sockhash. This excercises bpf_map_update_elem support from BPF
context. Compare the socket cookies from source and destination to
ensure that the copy succeeded.
Signed-off-by: Lorenz Bauer
---
.../selftests/bpf/prog_tests/s
Merge the two very similar functions sock_map_update_elem and
sock_hash_update_elem into one.
Signed-off-by: Lorenz Bauer
---
net/core/sock_map.c | 49 +++--
1 file changed, 7 insertions(+), 42 deletions(-)
diff --git a/net/core/sock_map.c b/net/core/sock
On 8/20/20 2:25 AM, Jesper Dangaard Brouer wrote:
>>> diff --git a/net/core/dev.c b/net/core/dev.c
>>> index a00aa737ce29..1f85880ee412 100644
>>> --- a/net/core/dev.c
>>> +++ b/net/core/dev.c
>>> @@ -8747,9 +8747,9 @@ static enum bpf_xdp_mode dev_xdp_mode(u32 flags)
>>> {
>>> if (flags &
Initializing psock->sk_proto and other saved callbacks is only
done in sk_psock_update_proto, after sk_psock_init has returned.
The logic for this is difficult to follow, and needlessly complex.
Instead, initialize psock->sk_proto whenever we allocate a new
psock. Additionally, assert the followin
The verifier assumes that map values are simple blobs of memory, and
therefore treats ARG_PTR_TO_MAP_VALUE, etc. as such. However, there are
map types where this isn't true. For example, sockmap and sockhash store
sockets. In general this isn't a big problem: we can just
write helpers that explicit
Allow calling bpf_map_update_elem on sockmap and sockhash from a BPF
context. The synchronization required for this is a bit fiddly: we
need to prevent the socket from changing its state while we add it
to the sockmap, since we rely on getting a callback via
sk_prot->unhash. However, we can't just
We're currently building a control plane for our BPF socket dispatch
work. As part of that, we have a need to create a copy of an existing
sockhash, to allow us to change the keys. I previously proposed allowing
privileged userspace to look up sockets, which doesn't work due to
security concerns (s
On Tue, Aug 18, 2020 at 05:41:57PM -0700, Andrii Nakryiko wrote:
> On Tue, Aug 18, 2020 at 1:44 PM Carlos Neira wrote:
> >
> > Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs.
> > This change folds a test case into test_progs.
> >
> > Changes from V4:
> > - Added accident
On 8/20/20 3:47 AM, Edward Cree wrote:
> Truncation of DMA_BIT_MASK to 32-bit dma_addr_t is semantically safe,
> but the compiler was warning because it was happening implicitly.
> Insert explicit casts to suppress the warnings.
>
> Reported-by: Randy Dunlap
> Signed-off-by: Edward Cree
Acked-
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'rtl8180_init_rx_ring()' and
'rtl8180_init_tx_ring()
On 8/19/20 9:27 PM, Jakub Kicinski wrote:
uAPI uses xdp_md, not xdp_buff. Fix comments.
Signed-off-by: Jakub Kicinski
---
include/uapi/linux/bpf.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index 0480f893fac
On 8/19/20 11:14 PM, Andrii Nakryiko wrote:
BPF_CALL | BPF_JMP32 is explicitly not allowed by verifier for BPF helper
calls, so don't detect it as a valid call. Also drop the check on func_id
pointer, as it's currently always non-null.
Reported-by: Yonghong Song
Fixes: 109cea5a594f ("libbpf:
On 8/19/20 4:53 AM, Xu Wang wrote:
Simplify the return expression.
Signed-off-by: Xu Wang
Applied, thanks!
On 8/19/20 6:27 AM, Alexei Starovoitov wrote:
From: Alexei Starovoitov
v5->v6:
- refactored Makefiles with Andrii's help
- switched to explicit $(MAKE) style
- switched to userldlibs instead of userldflags
- fixed build issue with libbpf Makefile due to invocation from kbuild
- fixed m
On 8/19/20 11:14 PM, Andrii Nakryiko wrote:
GCC compilers older than version 5 don't support __builtin_mul_overflow yet.
Given GCC 4.9 is the minimal supported compiler for building kernel and the
fact that libbpf is a dependency of resolve_btfids, which is dependency of
CONFIG_DEBUG_INFO_BTF=
On 8/19/20 1:05 PM, Toke Høiland-Jørgensen wrote:
The error message emitted by bpf_object__init_user_btf_maps() was using the
wrong section ID.
Signed-off-by: Toke Høiland-Jørgensen
Applied, thanks!
On 8/19/20 11:14 PM, Andrii Nakryiko wrote:
GCC 4.9 seems to be more strict in some regards. Fix two minor issue it
reported.
Fixes: 1c1052e0140a ("tools/testing/selftests/bpf: Add self-tests for new helper
bpf_get_ns_current_pid_tgid.")
Fixes: 2d7824ffd25c ("selftests: bpf: Add test for sk_
On 8/19/20 11:14 PM, Andrii Nakryiko wrote:
Record which built-ins are optional and needed for some of recent BPF CO-RE
subtests. Document Clang diff that fixed corner-case issue with
__builtin_btf_type_id().
Suggested-by: Alexei Starovoitov
Signed-off-by: Andrii Nakryiko
Acked-by: Yongho
Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs.
This change folds both tests into test_progs.
Changes from V5:
- Fold both tests into test_progs.
Signed-off-by: Carlos Neira
---
tools/testing/selftests/bpf/.gitignore| 1 -
tools/testing/selftests/bpf/Makefil
From: Peilin Ye
__smc_diag_dump() is potentially copying uninitialized kernel stack memory
into socket buffers, since the compiler may leave a 4-byte hole near the
beginning of `struct smcd_diag_dmbinfo`. Fix it by initializing `dinfo`
with memset().
Cc: sta...@vger.kernel.org
Fixes: 4b1b7d3b30a
1 - 100 of 309 matches
Mail list logo
