Re: [PATCH net-next RFC 02/13] devlink: Add reload levels data to dev get

2020-07-29 Thread Moshe Shemesh
On 7/28/2020 3:58 AM, Jakub Kicinski wrote: On Mon, 27 Jul 2020 14:02:22 +0300 Moshe Shemesh wrote: Expose devlink reload supported levels and driver's default level to the user through devlink dev get command. Examples: $ devlink dev show pci/:82:00.0: reload_levels_info: default

Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread Ahmed S. Darwish
On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > Manual repetition is boring and error prone. > > Signed-off-by: Peter Zijlstra (Intel) > --- ... > +/** > + * typedef seqcount_LOCKNAME_t - sequence counter with spinlock associated

Re: [PATCH 5/5] seqcount: More consistent seqprop names

2020-07-29 Thread Ahmed S. Darwish
On Wed, Jul 29, 2020 at 03:52:54PM +0200, Peter Zijlstra wrote: > Attempt uniformity and brevity. > > Signed-off-by: Peter Zijlstra (Intel) > --- Acked-by: Ahmed S. Darwish

Re: [PATCH net-next RFC 09/13] devlink: Add enable_remote_dev_reset generic parameter

2020-07-29 Thread Moshe Shemesh
On 7/28/2020 3:59 AM, Jakub Kicinski wrote: On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote: The enable_remote_dev_reset devlink param flags that the host admin allows device resets that can be initiated by other hosts. This parameter is useful for setups where a device is shared by dif

AW: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

2020-07-29 Thread Gaube, Marvin (THSE-TL1)
Hello, I just tried a VLAN-enabled bridge. All ingress packets definitely have the 802.1q-Tag on CPU ingress, double-checked that. Tried again with VLAN21-Tagged frames coming in the physical port. It seems that the bridge also handles all packets from lan1 as untagged. When I add lan1 to the br

Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command

2020-07-29 Thread Moshe Shemesh
On 7/28/2020 11:06 PM, Jakub Kicinski wrote: On Tue, 28 Jul 2020 12:18:30 -0700 Jacob Keller wrote: On 7/28/2020 11:44 AM, Jakub Kicinski wrote: From user perspective what's important is what the reset achieves (and perhaps how destructive it is). We can define the reset levels as: $ devlin

Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread Matthew Wilcox
On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > Manual repetition is boring and error prone. Yes, but generated functions are hard to grep for, and I'm pretty sure that kernel-doc doesn't know how to expand macros into comments that it can then extract documentation from. I've b

Re: AW: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

2020-07-29 Thread Florian Fainelli
On 7/29/2020 7:49 AM, Gaube, Marvin (THSE-TL1) wrote: > Hello, > I just tried a VLAN-enabled bridge. > All ingress packets definitely have the 802.1q-Tag on CPU ingress, > double-checked that. Tried again with VLAN21-Tagged frames coming in the > physical port. > It seems that the bridge also

Re: [PATCH v2 1/5] perf record: Set PERF_RECORD_PERIOD if attr->freq is set.

2020-07-29 Thread Athira Rajeev
> On 28-Jul-2020, at 9:33 PM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 28, 2020 at 05:43:47PM +0200, Jiri Olsa escreveu: >> On Tue, Jul 28, 2020 at 01:57:30AM -0700, Ian Rogers wrote: >>> From: David Sharp >>> >>> evsel__config() would only set PERF_RECORD_PERIOD if it set attr->freq

Re: Bug: ip utility fails to show routes with large # of multipath next-hops

2020-07-29 Thread David Ahern
On 7/29/20 5:43 AM, Ido Schimmel wrote: > On Tue, Jul 28, 2020 at 05:52:44PM -0700, Ashutosh Grewal wrote: >> Hello David and all, >> >> I hope this is the correct way to report a bug. > > Sure > >> >> I observed this problem with 256 v4 next-hops or 128 v6 next-hops (or >> 128 or so # of v4 next

Re: [PATCH iproute2] tc: Add space after format specifier

2020-07-29 Thread David Ahern
On 7/27/20 11:53 PM, Briana Oursler wrote: > I made the subject PATCH iproute2 after the question discussion with > everyone, but I realized that the patch it fixes is in iproute2-next > but not yet in iproute2. Sorry about the confusion. Should I resend to > iproute2-next? no, it is fine.

Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread peterz
On Wed, Jul 29, 2020 at 03:55:07PM +0100, Matthew Wilcox wrote: > On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > > Manual repetition is boring and error prone. > > Yes, but generated functions are hard to grep for, and I'm pretty sure > that kernel-doc doesn't know how to expand

Re: [PATCH v8 bpf-next 13/13] selftests/bpf: Add set test to resolve_btfids

2020-07-29 Thread Jiri Olsa
On Tue, Jul 28, 2020 at 12:56:02PM -0700, Andrii Nakryiko wrote: > On Wed, Jul 22, 2020 at 2:15 PM Jiri Olsa wrote: > > > > Adding test to for sets resolve_btfids. We're checking that > > testing set gets properly resolved and sorted. > > > > Signed-off-by: Jiri Olsa > > --- > > .../selftests/bp

Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-29 Thread Jiri Olsa
On Tue, Jul 28, 2020 at 12:47:03PM -0700, Andrii Nakryiko wrote: > On Wed, Jul 22, 2020 at 2:14 PM Jiri Olsa wrote: > > > > Adding d_path helper function that returns full path for > > given 'struct path' object, which needs to be the kernel > > BTF 'path' object. The path is returned in buffer pr

Re: [PATCH v8 bpf-next 06/13] bpf: Factor btf_struct_access function

2020-07-29 Thread Jiri Olsa
On Tue, Jul 28, 2020 at 04:27:21PM -0700, Andrii Nakryiko wrote: SNIP > > > kernel/bpf/btf.c | 73 +++- > > 1 file changed, 60 insertions(+), 13 deletions(-) > > > > diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c > > index 841be6c49f11..1ab5fd5bf992

Re: [net-next PATCH v7 1/6] Documentation: ACPI: DSD: Document MDIO PHY

2020-07-29 Thread Rafael J. Wysocki
Hi Andrew, On Tue, Jul 28, 2020 at 10:34 PM Andrew Lunn wrote: > > Hi Everybody > > So i think it is time to try to bring this discussion to some sort of > conclusion. > > No ACPI maintainer is willing to ACK any of these patches. Nor are > they willing to NACK them. Let's first clarify one thin

Re: [PATCH v8 bpf-next 07/13] bpf: Add btf_struct_ids_match function

2020-07-29 Thread Jiri Olsa
On Tue, Jul 28, 2020 at 04:35:16PM -0700, Andrii Nakryiko wrote: SNIP > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h > > index bae557ff2da8..c981e258fed3 100644 > > --- a/include/linux/bpf.h > > +++ b/include/linux/bpf.h > > @@ -1306,6 +1306,8 @@ int btf_struct_access(struct bpf_verif

Re: [PATCH v5 bpf-next 4/6] bpf, x64: rework pro/epilogue and tailcall handling in JIT

2020-07-29 Thread Maciej Fijalkowski
On Wed, Jul 29, 2020 at 12:07:52AM +0200, Daniel Borkmann wrote: > On 7/24/20 7:35 PM, Maciej Fijalkowski wrote: > > This commit serves two things: > > 1) it optimizes BPF prologue/epilogue generation > > 2) it makes possible to have tailcalls within BPF subprogram > > > > Both points are related

Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread peterz
On Wed, Jul 29, 2020 at 05:33:41PM +0200, pet...@infradead.org wrote: > On Wed, Jul 29, 2020 at 03:55:07PM +0100, Matthew Wilcox wrote: > > On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > > > Manual repetition is boring and error prone. > > > > Yes, but generated functions are ha

[bpf PATCH v2 0/5] Fix sock_ops field read splat

2020-07-29 Thread John Fastabend
Doing some refactoring resulted in a kernel splat when reading sock_ops fields. Patch 1, has the details and proposed fix for sock_ops sk field access. Patch 2, has the details and proposed fix for reading sock_ops->sk field Patch 3, Gives a reproducer and test to verify the fix. I used the netc

[bpf PATCH v2 1/5] bpf: sock_ops ctx access may stomp registers in corner case

2020-07-29 Thread John Fastabend
I had a sockmap program that after doing some refactoring started spewing this splat at me: [18610.807284] BUG: unable to handle kernel NULL pointer dereference at 0001 [...] [18610.807359] Call Trace: [18610.807370] ? 0xc114d0d5 [18610.807382] __cgroup_bpf_run_filter_sock_o

Re: [PATCH net-next] sfc_ef100: remove duplicated include from ef100_netdev.c

2020-07-29 Thread Edward Cree
On 29/07/2020 03:19, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing Acked-by: Edward Cree

[bpf PATCH v2 3/5] bpf, selftests: Add tests for ctx access in sock_ops with single register

2020-07-29 Thread John Fastabend
To verify fix ("bpf: sock_ops ctx access may stomp registers in corner case") we want to force compiler to generate the following code when accessing a field with BPF_TCP_SOCK_GET_COMMON, r1 = *(u32 *)(r1 + 96) // r1 is skops ptr Rather than depend on clang to do this we add the test with in

[bpf PATCH v2 4/5] bpf, selftests: Add tests for sock_ops load with r9, r8.r7 registers

2020-07-29 Thread John Fastabend
Loads in sock_ops case when using high registers requires extra logic to ensure the correct temporary value is used. We need to ensure the temp register does not use either the src_reg or dst_reg. Lets add an asm test to force the logic is triggered. The xlated code is here, 30: (7b) *(u64 *)(r

[net-next 11/15] ice: Allow all VLANs in safe mode

2020-07-29 Thread Tony Nguyen
From: Brett Creeley Currently the PF VSI's context parameters are left in a bad state when going into safe mode. This is causing VLAN traffic to not pass. Fix this by configuring the PF VSI to allow all VLAN tagged traffic. Also, remove redundant comment explaining the safe mode flow in ice_prob

[net-next 14/15] ice: disable no longer needed workaround for FW logging

2020-07-29 Thread Tony Nguyen
From: Ben Shelton For the FW logging info AQ command, we currently set the ICE_AQ_FLAG_RD in order to work around a FW issue. This issue has been fixed so remove the workaround. Signed-off-by: Ben Shelton Tested-by: Andrew Bowers Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-07-29

2020-07-29 Thread Tony Nguyen
This series contains updates to the ice driver only. Dave works around LFC settings not being preserved through link events. Fixes link issues with GLOBR reset and handling of multiple link events. Nick restores VF MSI-X after PCI reset. Kiran corrects the error code returned in ice_aq_sw_rules

[bpf PATCH v2 5/5] bpf, selftests: Add tests to sock_ops for loading sk

2020-07-29 Thread John Fastabend
Add tests to directly accesse sock_ops sk field. Then use it to ensure a bad pointer access will fault if something goes wrong. We do three tests: The first test ensures when we read sock_ops sk pointer into the same register that we don't fault as described earlier. Here r9 is chosen as the temp

[net-next 07/15] ice: Add RL profile bit mask check

2020-07-29 Thread Tony Nguyen
From: Tarun Singh Mask bits before accessing the profile type field. Signed-off-by: Tarun Singh Tested-by: Andrew Bowers Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_sched.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ether

[bpf PATCH v2 2/5] bpf: sock_ops sk access may stomp registers when dst_reg = src_reg

2020-07-29 Thread John Fastabend
Similar to patch ("bpf: sock_ops ctx access may stomp registers") if the src_reg = dst_reg when reading the sk field of a sock_ops struct we generate xlated code, 53: (61) r9 = *(u32 *)(r9 +28) 54: (15) if r9 == 0x0 goto pc+3 56: (79) r9 = *(u64 *)(r9 +0) This stomps on the r9 reg to do the

[net-next 12/15] ice: cleanup VSI on probe fail

2020-07-29 Thread Tony Nguyen
From: Marcin Szycik As part of ice_setup_pf_sw() a PF VSI is setup; release the VSI in case of failure. Signed-off-by: Marcin Szycik Tested-by: Andrew Bowers Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletio

[net-next 01/15] ice: Implement LFC workaround

2020-07-29 Thread Tony Nguyen
From: Dave Ertman There is a bug where the LFC settings are not being preserved through a link event. The registers in question are the ones that are touched (and restored) when a set_local_mib AQ command is performed. On a link-up event, make sure that a set_local_mib is being performed. Move

[net-next 04/15] ice: restore VF MSI-X state during PCI reset

2020-07-29 Thread Tony Nguyen
From: Nick Nunley During a PCI FLR the MSI-X Enable flag in the VF PCI MSI-X capability register will be cleared. This can lead to issues when a VF is assigned to a VM because in these cases the VF driver receives no indication of the PF PCI error/reset and additionally it is incapable of restori

[net-next 10/15] ice: need_wakeup flag might not be set for Tx

2020-07-29 Thread Tony Nguyen
From: Krzysztof Kazimierczak This is a port of i40e commit 705639572e8c ("i40e: need_wakeup flag might not be set for Tx"). Quoting the original commit message: "The need_wakeup flag for Tx might not be set for AF_XDP sockets that are only used to send packets. This happens if there is at least

[net-next 13/15] ice: reduce scope of variable

2020-07-29 Thread Tony Nguyen
From: Bruce Allan The scope of the macro local variable 'i' can be reduced. Do so to avoid static analysis tools from complaining. Signed-off-by: Bruce Allan Tested-by: Andrew Bowers Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_controlq.c | 6 -- 1 file changed, 4 i

[net-next 02/15] ice: Fix link broken after GLOBR reset

2020-07-29 Thread Tony Nguyen
From: Dave Ertman After a GLOBR, the link was broken so that a link up situation was being seen as a link down. The problem was that the rebuild process was updating the port_info link status without doing any of the other things that need to be done when link changes. This was causing the port

[net-next 08/15] ice: Adjust scheduler default BW weight

2020-07-29 Thread Tony Nguyen
From: Tarun Singh By default the queues are configured in legacy mode. The default BW settings for legacy/advanced modes are different. The existing code was using the advanced mode default value of 1 which was incorrect. This caused the unbalanced BW sharing among siblings. The recommended defau

[net-next 03/15] ice: fix link event handling timing

2020-07-29 Thread Tony Nguyen
From: Dave Ertman When the driver experiences a link event (especially link up) there can be multiple events generated. Some of these are link fault and still have a state of DOWN set. The problem happens when the link comes UP during the PF driver handling one of the LINK DOWN events. The stat

[net-next 05/15] ice: return correct error code from ice_aq_sw_rules

2020-07-29 Thread Tony Nguyen
From: Kiran Patil Return ICE_ERR_DOES_NOT_EXIST return code if admin command error code is ICE_AQ_RC_ENOENT (not exist). ice_aq_sw_rules is used when switch rule is getting added/deleted/updated. In case of delete/update switch rule, admin command can return ICE_AQ_RC_ENOENT error code if such ru

[net-next 06/15] ice: fix overwriting TX/RX descriptor values when rebuilding VSI

2020-07-29 Thread Tony Nguyen
From: Paul M Stillwell Jr If a user sets the value of the TX or RX descriptors to some non-default value using 'ethtool -G' then we need to not overwrite the values when we rebuild the VSI. The VSI rebuild could happen as a result of a user setting the number of queues via the 'ethtool -L' comman

[net-next 15/15] ice: fix unused parameter warning

2020-07-29 Thread Tony Nguyen
Depending on PAGE_SIZE, the following unused parameter warning can be reported: drivers/net/ethernet/intel/ice/ice_txrx.c: In function ‘ice_rx_frame_truesize’: drivers/net/ethernet/intel/ice/ice_txrx.c:513:21: warning: unused parameter ‘size’ [-Wunused-parameter] unsigned int size) The '

[net-next 09/15] ice: distribute Tx queues evenly

2020-07-29 Thread Tony Nguyen
From: Victor Raj Distribute the Tx queues evenly across all queue groups. This will help the queues to get more equal sharing among the queues when all are in use. In the previous algorithm, the next queue group node will be picked up only after the previous one filled with max children. For exa

RE: [net-next 05/15] ice: return correct error code from ice_aq_sw_rules

2020-07-29 Thread Patil, Kiran
ACK -Original Message- From: Nguyen, Anthony L Sent: Wednesday, July 29, 2020 9:24 AM To: da...@davemloft.net Cc: Patil, Kiran ; netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; Kirsher, Jeffrey T ; Nguyen, Anthony L ; Bowers, AndrewX Subject: [net-next 05/15] ice: re

RE: [net-next 11/15] ice: Allow all VLANs in safe mode

2020-07-29 Thread Creeley, Brett
ACK. Thanks, Brett > -Original Message- > From: Nguyen, Anthony L > Sent: Wednesday, July 29, 2020 9:24 AM > To: da...@davemloft.net > Cc: Creeley, Brett ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; Kirsher, > Jeffrey T ; Nguyen, Anthony L > ; Bowers, AndrewX >

[PATCH ipsec 2/2] espintcp: count packets dropped in espintcp_rcv

2020-07-29 Thread Sabrina Dubroca
Currently, espintcp_rcv drops packets silently, which makes debugging issues difficult. Count packets as either XfrmInHdrError (when the packet was too short or contained invalid data) or XfrmInError (for other issues). Signed-off-by: Sabrina Dubroca --- net/xfrm/espintcp.c | 6 ++ 1 file ch

[PATCH ipsec 1/2] espintcp: handle short messages instead of breaking the encap socket

2020-07-29 Thread Sabrina Dubroca
Currently, short messages (less than 4 bytes after the length header) will break the stream of messages. This is unnecessary, since we can still parse messages even if they're too short to contain any usable data. This is also bogus, as keepalive messages (a single 0xff byte), though not needed wit

[PATCH] net: add support for threaded NAPI polling

2020-07-29 Thread Felix Fietkau
For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI poll function does not perform well. Since NAPI poll is bound to the CPU it was scheduled from, we can easily end up with a few very busy CPUs spending most of their time in softirq/ksoftirqd and some idle ones. Introduc

Re: [PATCH iproute2] tc: Add space after format specifier

2020-07-29 Thread David Ahern
On 7/27/20 11:20 PM, Briana Oursler wrote: > Add space after format specifier in print_string call. Fixes broken > qdisc tests within tdc testing suite. Per suggestion from Petr Machata, > remove a space and change spacing in tc/q_event.c to complete the fix. > > Tested fix in tdc using: > ./tdc.p

Re: [PATCH net 2/2] net/sched: act_ct: Set offload timeout when setting the offload bit

2020-07-29 Thread Marcelo Ricardo Leitner
On Wed, Jul 29, 2020 at 03:55:53PM +0300, Roi Dayan wrote: > > > On 2020-07-28 5:42 PM, Marcelo Ricardo Leitner wrote: > > On Tue, Jul 28, 2020 at 02:57:59PM +0300, Roi Dayan wrote: > >> On heavily loaded systems the GC can take time to go over all existing > >> conns and reset their timeout. At

RE: [Intel-wired-lan] [PATCH 4/4] ixgbe/ixgbe_ethtool.c: Remove unnecessary usages of memset.

2020-07-29 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Suraj Upadhyay > Sent: Tuesday, July 14, 2020 12:42 PM > To: Kirsher, Jeffrey T ; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; kernel-janit...@vger.kernel.org; intel-wired- > l...@lists.osuosl.org; linux-ke

RE: [Intel-wired-lan] [PATCH net-next] ice: mark PM functions as __maybe_unused

2020-07-29 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Wei Yongjun > Sent: Monday, July 27, 2020 6:42 PM > To: Hulk Robot ; Kirsher, Jeffrey T > ; Jakub Kicinski ; Alexei > Starovoitov ; Daniel Borkmann ; > Jesper Dangaard Brouer ; John Fastabend > ; Abodunrin, Akeem G > > Cc: intel-

Re: [PATCH] atm: Fix atm_dev reference count leaks in atmtcp_remove_persistent()

2020-07-29 Thread Markus Elfring
… > The refcount leaks issues occur in two error handling paths. Can it be nicer to use the term “reference count” for the commit message? > Fix the issue by … I suggest to replace this wording by the tag “Fixes”. … > +++ b/drivers/atm/atmtcp.c > @@ -433,9 +433,15 @@ static int atmtcp_remove

Re: [PATCH] net: add support for threaded NAPI polling

2020-07-29 Thread Eric Dumazet
On 7/29/20 9:50 AM, Felix Fietkau wrote: > For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI > poll function does not perform well. Since NAPI poll is bound to the CPU it > was scheduled from, we can easily end up with a few very busy CPUs spending > most of their tim

Re: [PATCH v4 bpf 2/2] selftests/bpf: extend map-in-map selftest to detect memory leaks

2020-07-29 Thread Andrii Nakryiko
On Wed, Jul 29, 2020 at 7:29 AM Jakub Sitnicki wrote: > > On Wed, Jul 29, 2020 at 06:09 AM CEST, Andrii Nakryiko wrote: > > Add test validating that all inner maps are released properly after skeleton > > is destroyed. To ensure determinism, trigger kernel-side synchronize_rcu() > > before checkin

Re: [PATCH v8 bpf-next 07/13] bpf: Add btf_struct_ids_match function

2020-07-29 Thread Andrii Nakryiko
On Wed, Jul 29, 2020 at 9:04 AM Jiri Olsa wrote: > > On Tue, Jul 28, 2020 at 04:35:16PM -0700, Andrii Nakryiko wrote: > > SNIP > > > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h > > > index bae557ff2da8..c981e258fed3 100644 > > > --- a/include/linux/bpf.h > > > +++ b/include/linux/bpf.

[PATCH net] ionic: unlock queue mutex in error path

2020-07-29 Thread Shannon Nelson
On an error return, jump to the unlock at the end to be sure to unlock the queue_lock mutex. Fixes: 0925e9db4dc8 ("ionic: use mutex to protect queue operations") Reported-by: kernel test robot Reported-by: Julia Lawall Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic

Encantada de conocerte

2020-07-29 Thread Laura J. Richardson
Hola querido amigo, Soy Laura J. Richardson de los Estados Unidos. Por favor, me gustaría comunicarme con usted. estaré esperando tu respuesta. Laura.

Re: [PATCH v4 bpf-next 2/4] bpf: Add BPF program and map iterators as built-in BPF programs.

2020-07-29 Thread Andrii Nakryiko
On Fri, Jul 24, 2020 at 1:39 PM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > The program and map iterators work similar to seq_file-s. > Once the program is pinned in bpffs it can be read with "cat" tool > to print human readable output. In this case about BPF programs and maps. > F

KASAN: use-after-free Write in __alloc_skb (3)

2020-07-29 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:68845a55 Merge branch 'akpm' into master (patches from And.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10f85f7890 kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267 das

[PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

2020-07-29 Thread David Thompson
This patch adds build and driver logic for the "mlxbf_gige" Ethernet driver from Mellanox Technologies. The second generation BlueField SoC from Mellanox supports an out-of-band GigaBit Ethernet management port to the Arm subsystem. This driver supports TCP/IP network connectivity for that port, a

Re: [PATCH] net/mlx5e: fix bpf_prog reference count leaks in mlx5e_alloc_rq

2020-07-29 Thread Markus Elfring
… > The refcount leak issues take place in two error handling paths. Can an other wording be a bit nicer for the commit message? > Fix the issue by … I suggest to replace this wording by the tag “Fixes”. Regards, Markus

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-29 Thread Eugenio Perez Martin
On Tue, Jul 21, 2020 at 4:55 AM Jason Wang wrote: > > > On 2020/7/20 下午7:16, Eugenio Pérez wrote: > > On Mon, Jul 20, 2020 at 11:27 AM Michael S. Tsirkin wrote: > >> On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: > >>> On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin >

Re: [PATCH v2 1/5] perf record: Set PERF_RECORD_PERIOD if attr->freq is set.

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:30AM -0700, Ian Rogers escreveu: > From: David Sharp > > evsel__config() would only set PERF_RECORD_PERIOD if it set attr->freq There is no such thing as 'PERF_RECORD_PERIOD', its PERF_SAMPLE_PERIOD, also... > from perf record options. When it is set by libpfm even

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:31AM -0700, Ian Rogers escreveu: > From: Stephane Eranian > > Before: > $ perf record -c 1 --pfm-events=cycles:period=7 > > Would yield a cycles event with period=1, instead of 7. I tried the equivalent without libpfm and it works: $ perf record

Re: [PATCH v8 bpf-next 07/13] bpf: Add btf_struct_ids_match function

2020-07-29 Thread Jiri Olsa
On Wed, Jul 29, 2020 at 10:51:26AM -0700, Andrii Nakryiko wrote: > On Wed, Jul 29, 2020 at 9:04 AM Jiri Olsa wrote: > > > > On Tue, Jul 28, 2020 at 04:35:16PM -0700, Andrii Nakryiko wrote: > > > > SNIP > > > > > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h > > > > index bae557ff2da8..c

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:33AM -0700, Ian Rogers escreveu: > If events in a group explicitly set a frequency or period with leader > sampling, don't disable the samples on those events. > > Prior to 5.8: > perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' > would clear

Re: [PATCH ghak90 V9 06/13] audit: add contid support for signalling the audit daemon

2020-07-29 Thread Richard Guy Briggs
On 2020-07-05 11:10, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs wrote: > > > > Add audit container identifier support to the action of signalling the > > audit daemon. > > > > Since this would need to add an element to the audit_sig_info struct, > > a new record type AU

Re: [PATCH] net/mlx5e: fix bpf_prog refcnt leaks in mlx5e_alloc_rq

2020-07-29 Thread Saeed Mahameed
On Wed, 2020-07-29 at 20:33 +0800, Xin Xiong wrote: > The function invokes bpf_prog_inc(), which increases the refcount of > a > bpf_prog object "rq->xdp_prog" if the object isn't NULL. > > The refcount leak issues take place in two error handling paths. When > mlx5_wq_ll_create() or mlx5_wq_cyc_c

Re: [PATCH net] vxlan: Ensure FDB dump is performed under RCU

2020-07-29 Thread David Miller
From: Ido Schimmel Date: Wed, 29 Jul 2020 11:34:36 +0300 > From: Ido Schimmel > > The commit cited below removed the RCU read-side critical section from > rtnl_fdb_dump() which means that the ndo_fdb_dump() callback is invoked > without RCU protection. > > This results in the following warning

Re: 回复: INFO: rcu detected stall in tc_modify_qdisc

2020-07-29 Thread Vinicius Costa Gomes
Hi, "Zhang, Qiang" writes: > > 发件人: linux-kernel-ow...@vger.kernel.org > 代表 syzbot > 发送时间: 2020年7月29日 13:53 > 收件人: da...@davemloft.net; fweis...@gmail.com; j...@mojatatu.com; > j...@resnulli.us; linux-ker...@vger.kernel.org; mi...@kernel.org; > netde

Re: [PATCH net] ipv4: Silence suspicious RCU usage warning

2020-07-29 Thread David Miller
From: Ido Schimmel Date: Wed, 29 Jul 2020 11:37:13 +0300 > From: Ido Schimmel > > fib_trie_unmerge() is called with RTNL held, but not from an RCU > read-side critical section. This leads to the following warning [1] when > the FIB alias list in a leaf is traversed with > hlist_for_each_entry_r

Re: [PATCH net 0/6] mlxsw fixes

2020-07-29 Thread David Miller
From: Ido Schimmel Date: Wed, 29 Jul 2020 12:26:42 +0300 > From: Ido Schimmel > > This patch set contains various fixes for mlxsw. > > Patches #1-#2 fix two trap related issues introduced in previous cycle. > > Patches #3-#5 fix rare use-after-frees discovered by syzkaller. After > over a wee

Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down

2020-07-29 Thread David Miller
From: Jisheng Zhang Date: Wed, 29 Jul 2020 17:49:09 +0800 > mvneta has switched to phylink, so the comment should look > like "We may have called phylink_speed_down before". > > Signed-off-by: Jisheng Zhang > --- > Since v1: > - drop patch2 which tries to avoid link flapping when changing mtu

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-07-29 Thread Richard Guy Briggs
On 2020-07-05 11:10, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs wrote: > > > > Create a new audit record AUDIT_CONTAINER_ID to document the audit > > container identifier of a process if it is present. > > > > Called from audit_log_exit(), syscalls are covered. > > > >

RE: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

2020-07-29 Thread David Thompson
> -Original Message- > From: David Thompson > Sent: Wednesday, July 29, 2020 2:29 PM > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; k...@kernel.org; Jiri Pirko ; > David Thompson ; Asmaa Mnebhi > > Subject: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver > > T

Re: [PATCH] uapi, seg6_iptunnel: Add missing include in seg6_iptunnel.h

2020-07-29 Thread David Miller
From: Ioana-Ruxandra Stancioi Date: Wed, 29 Jul 2020 10:49:03 + > From: Ioana-Ruxandra Stăncioi > > Include in uapi/linux/seg6_iptunnel.h to fix the > following linux/seg6_iptunnel.h compilation error: > >invalid application of 'sizeof' to incomplete type 'struct ipv6hdr' >hea

Re: [PATCH ghak90 V9 02/13] audit: add container id

2020-07-29 Thread Richard Guy Briggs
On 2020-07-05 11:09, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs wrote: > > > > Implement the proc fs write to set the audit container identifier of a > > process, emitting an AUDIT_CONTAINER_OP record to document the event. > > > > This is a write from the container orc

Re: [PATCH v8 bpf-next 01/13] selftests/bpf: Fix resolve_btfids test

2020-07-29 Thread Jiri Olsa
On Tue, Jul 28, 2020 at 01:27:49PM -0700, Andrii Nakryiko wrote: > On Wed, Jul 22, 2020 at 2:13 PM Jiri Olsa wrote: > > > > The linux/btf_ids.h header is now using CONFIG_DEBUG_INFO_BTF > > config, so we need to have it defined when it's available. > > > > Signed-off-by: Jiri Olsa > > --- > > su

Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-29 Thread Al Viro
On Wed, Jul 22, 2020 at 11:12:19PM +0200, Jiri Olsa wrote: > +BPF_CALL_3(bpf_d_path, struct path *, path, char *, buf, u32, sz) > +{ > + char *p = d_path(path, buf, sz - 1); > + int len; > + > + if (IS_ERR(p)) { > + len = PTR_ERR(p); > + } else { > + len = s

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-07-29

2020-07-29 Thread David Miller
From: Tony Nguyen Date: Wed, 29 Jul 2020 09:23:50 -0700 > This series contains updates to the ice driver only. ... > The following are changes since commit > 490ed0b908d371cd9ab63fc142213e5d02d810ee: > Merge branch 'net-stmmac-improve-WOL' > and are available in the git repository at: > git

Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-29 Thread Al Viro
On Wed, Jul 22, 2020 at 11:12:19PM +0200, Jiri Olsa wrote: > +BTF_SET_START(btf_whitelist_d_path) > +BTF_ID(func, vfs_truncate) > +BTF_ID(func, vfs_fallocate) > +BTF_ID(func, dentry_open) > +BTF_ID(func, vfs_getattr) > +BTF_ID(func, filp_close) > +BTF_SET_END(btf_whitelist_d_path) While we are at

general protection fault in security_inode_getattr

2020-07-29 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:92ed3019 Linux 5.8-rc7 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=140003ac90 kernel config: https://syzkaller.appspot.com/x/.config?x=84f076779e989e69 dashboard link: https://syzkaller.appspot

Re: [PATCH net-next] fib: fix fib_rules_ops indirect calls wrappers

2020-07-29 Thread David Miller
From: Brian Vazquez Date: Wed, 29 Jul 2020 11:10:18 -0700 > This patch fixes: > commit b9aaec8f0be5 ("fib: use indirect call wrappers in the most common > fib_rules_ops") which didn't consider the case when > CONFIG_IPV6_MULTIPLE_TABLES is not set. > > Reported-by: Stephen Rothwell > Fixes: b9a

Re: [PATCH v4 bpf 2/2] selftests/bpf: extend map-in-map selftest to detect memory leaks

2020-07-29 Thread Jakub Sitnicki
On Wed, Jul 29, 2020 at 07:48 PM CEST, Andrii Nakryiko wrote: > On Wed, Jul 29, 2020 at 7:29 AM Jakub Sitnicki wrote: >> >> On Wed, Jul 29, 2020 at 06:09 AM CEST, Andrii Nakryiko wrote: [...] >> > +/* >> > + * Trigger synchronize_cpu() in kernel. >> >> Nit: synchronize_*r*cu(). > > welp, yeah >

Re: [PATCH] net/mlx5e: fix bpf_prog refcnt leaks in mlx5e_alloc_rq

2020-07-29 Thread David Miller
From: Saeed Mahameed Date: Wed, 29 Jul 2020 19:02:15 + > On Wed, 2020-07-29 at 20:33 +0800, Xin Xiong wrote: >> The function invokes bpf_prog_inc(), which increases the refcount of >> a >> bpf_prog object "rq->xdp_prog" if the object isn't NULL. >> >> The refcount leak issues take place in t

Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

2020-07-29 Thread David Miller
From: David Thompson Date: Wed, 29 Jul 2020 19:41:30 + > It's been pointed out to me that this section is incomplete, and I apologize. ... David, do you have any idea what kind of burdon you create by quoting an entire HUGE patch just to add some commentary to a small portion? Take a look

Re: [PATCH] netfilter: ip6tables: Remove redundant null checks

2020-07-29 Thread Pablo Neira Ayuso
Applied, thanks.

Re: [PATCH v2] netfilter: Replace HTTP links with HTTPS ones

2020-07-29 Thread Pablo Neira Ayuso
On Sat, Jul 25, 2020 at 07:02:25PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. Applied.

Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

2020-07-29 Thread Jakub Kicinski
On Wed, 29 Jul 2020 14:29:15 -0400 David Thompson wrote: > This patch adds build and driver logic for the "mlxbf_gige" > Ethernet driver from Mellanox Technologies. Please fix these W=1 C=1 warnings: drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:256:29: warning: Using plain integer

Re: [PATCH] net/mlx5e: fix bpf_prog refcnt leaks in mlx5e_alloc_rq

2020-07-29 Thread Saeed Mahameed
On Wed, 2020-07-29 at 13:28 -0700, David Miller wrote: > From: Saeed Mahameed > Date: Wed, 29 Jul 2020 19:02:15 + > > >> Fix this issue by jumping to the error handling path > >> err_rq_wq_destroy > >> when either function fails. > >> > > > > Fixes: 422d4c401edd ("net/mlx5e: RX, Split WQ ob

Re: [PATCH net-next RFC 09/13] devlink: Add enable_remote_dev_reset generic parameter

2020-07-29 Thread Jakub Kicinski
On Wed, 29 Jul 2020 17:42:12 +0300 Moshe Shemesh wrote: > On 7/28/2020 3:59 AM, Jakub Kicinski wrote: > > On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote: > >> The enable_remote_dev_reset devlink param flags that the host admin > >> allows device resets that can be initiated by other hosts

Re: [PATCH net] selftests/bpf: add xdpdrv mode for test_xdp_redirect

2020-07-29 Thread Song Liu
On Wed, Jul 29, 2020 at 1:59 AM Hangbin Liu wrote: > > This patch add xdpdrv mode for test_xdp_redirect.sh since veth has > support native mode. After update here is the test result: > > ]# ./test_xdp_redirect.sh > selftests: test_xdp_redirect xdpgeneric [PASS] > selftests: test_xdp_redirect xdpdr

Re: [PATCH bpf-next v2] Documentation/bpf: Use valid and new links in index.rst

2020-07-29 Thread Song Liu
On Wed, Jul 29, 2020 at 6:17 AM Tiezhu Yang wrote: > > There exists an error "404 Not Found" when I click the html link of > "Documentation/networking/filter.rst" in the BPF documentation [1], > fix it. > > Additionally, use the new links about "BPF and XDP Reference Guide" > and "bpf(2)" to avoid

Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command

2020-07-29 Thread Jakub Kicinski
On Wed, 29 Jul 2020 17:54:08 +0300 Moshe Shemesh wrote: > On 7/28/2020 11:06 PM, Jakub Kicinski wrote: > > On Tue, 28 Jul 2020 12:18:30 -0700 Jacob Keller wrote: > >> On 7/28/2020 11:44 AM, Jakub Kicinski wrote: > >>> From user perspective what's important is what the reset achieves (and > >>>

Re: [PATCH net] selftests/bpf: add xdpdrv mode for test_xdp_redirect

2020-07-29 Thread William Tu
On Wed, Jul 29, 2020 at 1:59 PM Song Liu wrote: > > On Wed, Jul 29, 2020 at 1:59 AM Hangbin Liu wrote: > > > > This patch add xdpdrv mode for test_xdp_redirect.sh since veth has > > support native mode. After update here is the test result: > > > > ]# ./test_xdp_redirect.sh > > selftests: test_xd

Re: [PATCH net-next RFC 02/13] devlink: Add reload levels data to dev get

2020-07-29 Thread Jakub Kicinski
On Wed, 29 Jul 2020 17:37:41 +0300 Moshe Shemesh wrote: > > The fact that the driver supports fw_live_patch, does not necessarily > > mean that the currently running FW can be live upgraded to the > > currently flashed one, right? > > That's correct, though the feature is supported, the firmware

[RFC PATCH 3/3] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table

2020-07-29 Thread Mathieu Desnoyers
As per RFC4443, the destination address field for ICMPv6 error messages is copied from the source address field of the invoking packet. In configurations with Virtual Routing and Forwarding tables, looking up which routing table to use for sending ICMPv6 error messages is currently done by using t

[RFC PATCH 1/3] selftests: Add VRF icmp error route lookup test

2020-07-29 Thread Mathieu Desnoyers
From: Michael Jeanson The objective is to check that the incoming vrf routing table is selected to send an ICMP error back to the source when the ttl of a packet reaches 1 while it is forwarded between different vrfs. The first test sends a ping with a ttl of 1 from h1 to h2 and parses the outpu

[RFC PATCH 2/3] ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table

2020-07-29 Thread Mathieu Desnoyers
As per RFC792, ICMP errors should be sent to the source host. However, in configurations with Virtual Routing and Forwarding tables, looking up which routing table to use is currently done by using the destination net_device. commit 9d1a6c4ea43e ("net: icmp_route_lookup should use rt dev to deter

Re: [PATCH v5 bpf-next 4/6] bpf, x64: rework pro/epilogue and tailcall handling in JIT

2020-07-29 Thread Maciej Fijalkowski
On Wed, Jul 29, 2020 at 06:10:44PM +0200, Maciej Fijalkowski wrote: > On Wed, Jul 29, 2020 at 12:07:52AM +0200, Daniel Borkmann wrote: > > On 7/24/20 7:35 PM, Maciej Fijalkowski wrote: > > > This commit serves two things: > > > 1) it optimizes BPF prologue/epilogue generation > > > 2) it makes poss

<    1   2   3   >