> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Wei Yongjun
> Sent: Monday, July 27, 2020 6:42 PM
> To: Hulk Robot <[email protected]>; Kirsher, Jeffrey T
> <[email protected]>; Jakub Kicinski <[email protected]>; Alexei
> Starovoitov <[email protected]>; Daniel Borkmann <[email protected]>;
> Jesper Dangaard Brouer <[email protected]>; John Fastabend
> <[email protected]>; Abodunrin, Akeem G
> <[email protected]>
> Cc: [email protected]; Wei Yongjun
> <[email protected]>; [email protected]
> Subject: [Intel-wired-lan] [PATCH net-next] ice: mark PM functions as
> __maybe_unused
> 
> In certain configurations without power management support, the following
> warnings happen:
> 
> drivers/net/ethernet/intel/ice/ice_main.c:4214:12: warning:
>  'ice_resume' defined but not used [-Wunused-function]
>  4214 | static int ice_resume(struct device *dev)
>       |            ^~~~~~~~~~
> drivers/net/ethernet/intel/ice/ice_main.c:4150:12: warning:
>  'ice_suspend' defined but not used [-Wunused-function]
>  4150 | static int ice_suspend(struct device *dev)
>       |            ^~~~~~~~~~~
> 
> Mark these functions as __maybe_unused to make it clear to the compiler
> that this is going to happen based on the configuration, which is the standard
> for these types of functions.
> 
> Fixes: 769c500dcc1e ("ice: Add advanced power mgmt for WoL")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Andrew Bowers <[email protected]>


Reply via email to