Re: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

On Tue, Jun 16, 2020 at 02:51:27AM +0800, Brown, Aaron F wrote: > > From: Chen Yu > > Sent: Thursday, May 21, 2020 10:59 AM > > To: Kirsher, Jeffrey T ; David S. Miller > > ; Jakub Kicinski ; Kok, Auke-jan H > > ; Jeff Garzik > > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux

RE: [PATCH bpf 1/2] bpf: bpf_probe_read_kernel_str() has to return amount of data read on success

Andrii Nakryiko wrote: > During recent refactorings, bpf_probe_read_kernel_str() started returning 0 on > success, instead of amount of data successfully read. This majorly breaks > applications relying on bpf_probe_read_kernel_str() and bpf_probe_read_str() > and their results. Fix this by returni

[PATCH 01/02] net: phy: marvell: Add Marvell 88E1340 support

Add Marvell 88E1340 support Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 23 +++ include/linux/marvell_phy.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 7fc8e10c5f33..4cc4e25fed2d 1006

[PATCH 02/02] net: phy: marvell: Add Marvell 88E1548 support

Add Marvell 88E1548 support Signed-off-by: Maxim Kochetkov --- drivers/net/phy/marvell.c | 24 include/linux/marvell_phy.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 4cc4e25fed2d..f0d4ca87e4bc 100

RE: [PATCH] [bpf] xdp_monitor_user: Fix null pointer dereference

Gaurav Singh wrote: > Memset() on the pointer right after malloc() can cause > a null pointer dereference if it failed to allocate memory. > Fix this by replacing malloc/memset with a single calloc(). > > Signed-off-by: Gaurav Singh > --- > samples/bpf/xdp_monitor_user.c | 8 ++-- > 1 file c

RE: [PATCH] [bpf] xdp_redirect_cpu_user: Fix null pointer dereference

Gaurav Singh wrote: > Memset() on the pointer right after malloc() can cause > a null pointer dereference if it failed to allocate memory. > Fix this by replacing malloc/memset with a single calloc(). > > Signed-off-by: Gaurav Singh > --- > samples/bpf/xdp_redirect_cpu_user.c | 11 +++ >

[PATCH 2/2] MAINTAINERS: update ieee802154 project website URL

Update URL to our new home. Signed-off-by: Stefan Schmidt --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 50659d76976b..6cd52c922bfa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8225,7 +8225,7 @@ M:Alexander Aring M:

[PATCH 1/2] docs: net: ieee802154: change link to new project URL

We finally came around to setup a new project website. Update the reference here. Signed-off-by: Stefan Schmidt --- Documentation/networking/ieee802154.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/ieee802154.rst b/Documentation/networking/

[PATCH net] mlxsw: spectrum: Adjust headroom buffers for 8x ports

From: Ido Schimmel The port's headroom buffers are used to store packets while they traverse the device's pipeline and also to store packets that are egress mirrored. On Spectrum-3, ports with eight lanes use two headroom buffers between which the configured headroom size is split. In order to

Re: [PATCH 1/1] openvswitch: fix infoleak in conntrack

On Mon, Jun 15, 2020 at 7:13 PM Xidong Wang wrote: > > From: xidongwang > > The stack object “zone_limit” has 3 members. In function > ovs_ct_limit_get_default_limit(), the member "count" is > not initialized and sent out via “nla_put_nohdr”. > > Signed-off-by: xidongwang Looks good. Acked-by:

Re: [ovs-dev] [PATCH 1/1] openvswitch: fix infoleak in conntrack

On Tue, Jun 16, 2020 at 10:13 AM Xidong Wang wrote: > > From: xidongwang > > The stack object “zone_limit” has 3 members. In function > ovs_ct_limit_get_default_limit(), the member "count" is > not initialized and sent out via “nla_put_nohdr”. > > Signed-off-by: xidongwang > --- > net/openvswit

[PATCH] net: macb: reject unsupported rgmii delays

The macb driver does not support configuring rgmii delays. At least for the Zynq GEM, delays are not supported by the hardware at all. However, the driver happily accepts and ignores any such delays. When operating in a mac to phy connection, the delay setting applies to the phy. Since the MAC doe

Re: [PATCH 3/5] Huawei BMA: Adding Huawei BMA driver: host_veth_drv

Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc1 next-20200616] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH] ath10k: Wait until copy complete is actually done before completing

Douglas Anderson wrote: > On wcn3990 we have "per_ce_irq = true". That makes the > ath10k_ce_interrupt_summary() function always return 0xfff. The > ath10k_ce_per_engine_service_any() function will see this and think > that _all_ copy engines have an interrupt. Without checking, the > ath10k_ce

Re: [PATCH net v2 2/2] net/sched: act_gate: fix configuration of the periodic timer

On Tue, 16 Jun 2020 at 04:00, David Miller wrote: > > From: Vladimir Oltean > Date: Tue, 16 Jun 2020 00:55:50 +0300 > > > On Mon, 15 Jun 2020 at 22:33, Davide Caratti wrote: > >> > >> assigning a dummy value of 'clock_id' to avoid cancellation of the cycle > >> timer before its initialization wa

[PATCH] ipvs: avoid drop first packet by reusing conntrack

Since 'commit f719e3754ee2 ("ipvs: drop first packet to redirect conntrack")', when a new TCP connection meet the conditions that need reschedule, the first syn packet is dropped, this cause one second latency for the new connection, more discussion about this problem can easy search from google, s

Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

On Tue, 16 Jun 2020 at 04:55, Alexei Starovoitov wrote: > > On Mon, Jun 15, 2020 at 7:43 AM Lorenz Bauer wrote: > > > > On Fri, 12 Jun 2020 at 23:36, Alexei Starovoitov > > wrote: > > > > > > On Fri, Jun 12, 2020 at 9:02 AM Lorenz Bauer wrote: > > > > > > > > Using BPF_PROG_ATTACH on a flow dis

[PATCH 2/2] net: ethernet: mvneta: Add 2500BaseX support for SoCs without comphy

The older SoCs like Armada XP support a 2500BaseX mode in the datasheets referred to as DR-SGMII (Double rated SGMII) or HS-SGMII (High Speed SGMII). This is an upclocked 1000BaseX mode, thus PHY_INTERFACE_MODE_2500BASEX is the appropriate mode define for it. adding support for it merely means writ

[PATCH 1/2] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy

The MVNETA_SERDES_CFG register is only available on older SoCs like the Armada XP. On newer SoCs like the Armada 38x the fields are moved to comphy. This patch moves the writes to this register next to the comphy initialization, so that depending on the SoC either comphy or MVNETA_SERDES_CFG is con

Re: net/80211: simplify mesh code

Acked-by: Linus Lüssing

[PATCH] ipvs: avoid drop first packet by reusing conntrack

Since 'commit f719e3754ee2 ("ipvs: drop first packet to redirect conntrack")', when a new TCP connection meet the conditions that need reschedule, the first syn packet is dropped, this cause one second latency for the new connection, more discussion about this problem can easy search from google, s

Re: [ovs-dev] [PATCH 1/1] openvswitch: fix infoleak in conntrack

On Mon, Jun 15, 2020 at 07:13:01PM -0700, Xidong Wang wrote: > From: xidongwang > > The stack object “zone_limit” has 3 members. In function > ovs_ct_limit_get_default_limit(), the member "count" is > not initialized and sent out via “nla_put_nohdr”. Hi Xidong, thanks for your patch. It appear

Re: [PATCHv4 bpf-next 1/2] xdp: add a new helper for dev map multicast support

On Fri, 12 Jun 2020 16:54:08 +0800 Hangbin Liu wrote: > On Wed, Jun 10, 2020 at 12:18:59PM +0200, Jesper Dangaard Brouer wrote: > > On Tue, 26 May 2020 22:05:38 +0800 > > Hangbin Liu wrote: > > > > > diff --git a/net/core/xdp.c b/net/core/xdp.c > > > index 90f44f382115..acdc63833b1f 100644 >

Re: [PATCH 4/5] Huawei BMA: Adding Huawei BMA driver: cdev_veth_drv

Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc1 next-20200616] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCHv4 bpf-next 1/2] xdp: add a new helper for dev map multicast support

On Wed, 10 Jun 2020 12:29:35 +0200 Toke Høiland-Jørgensen wrote: > Jesper Dangaard Brouer writes: > > > On Tue, 26 May 2020 22:05:38 +0800 > > Hangbin Liu wrote: > > > >> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c > >> index a51d9fb7a359..ecc5c44a5bab 100644 > >> --- a/kernel/b

Re: [PATCH] net: usb: ax88179_178a: fix packet alignment padding

Hi David, > > Those last two bytes - 96 1f - aren't part of the original packet. > > Does this happen for non-tail packets in a multi-packet cluster? I believe so, yes. I haven't been able to reliably reproduce the multi- packet behaviour though, so input from ASIX would be good. > > Because t

Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

On Wed, 27 May 2020 17:04:50 +0200 Toke Høiland-Jørgensen wrote: > Hangbin Liu writes: > > > On Wed, May 27, 2020 at 12:21:54PM +0200, Toke Høiland-Jørgensen > > wrote: > >> > The example in patch 2 is functional, but not a lot of effort > >> > has been made on performance optimisation

Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper

Hi, Am Dienstag, 16. Juni 2020, 03:12:25 CEST schrieb David Miller: > From: David Miller > Date: Mon, 15 Jun 2020 18:11:29 -0700 (PDT) > > + return devm_phy_package_join(&phydev->mdio.dev, phydev, > > +vsc8531->base_addr, 0); > > But it is still dereferenced her

Re: [PATCH v4 1/3] mm/slab: Use memzero_explicit() in kzfree()

On Tue, Jun 16, 2020 at 08:42:08AM +0200, Michal Hocko wrote: > On Mon 15-06-20 21:57:16, Waiman Long wrote: > > The kzfree() function is normally used to clear some sensitive > > information, like encryption keys, in the buffer before freeing it back > > to the pool. Memset() is currently used for

Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

On Tue, Jun 16, 2020 at 11:09:22AM +0200, Jesper Dangaard Brouer wrote: > > > BTW, when using pktgen, I got an panic because the skb don't have enough > > > header room. The code path looks like > > > > > > do_xdp_generic() > > > - netif_receive_generic_xdp() > > > - skb_headroom(skb) < XDP_P

[PATCH 01/11] bpf: Add btfid tool to resolve BTF IDs in ELF object

The btfid tool scans Elf object for .BTF_ids section and resolves its symbols with BTF IDs. It will be used to during linking time to resolve arrays of BTF IDs used in verifier, so these IDs do not need to be resolved in runtime. The expected layout of .BTF_ids section is described in btfid.c hea

[PATCH 07/11] bpf: Allow nested BTF object to be refferenced by BTF object + offset

Adding btf_struct_address function that takes 2 BTF objects and offset as arguments and checks whether object A is nested in object B on given offset. This function is be used when checking the helper function PTR_TO_BTF_ID arguments. If the argument has an offset value, the btf_struct_address wil

[PATCH] e1000e: continue to init phy even when failed to disable ULP

After commit "e1000e: disable s0ix entry and exit flows for ME systems", some ThinkPads always failed to disable ulp by ME. commit "e1000e: Warn if disabling ULP failed" break out of init phy: error log: [ 42.364753] e1000e :00:1f.6 enp0s31f6: Failed to disable ULP [ 42.524626] e1000e

[PATCH 04/11] bpf: Resolve BTF IDs in vmlinux image

Run btfid on vmlinux object during linking, so the .BTF_ids section is processed and IDs are resolved. Signed-off-by: Jiri Olsa --- Makefile | 3 ++- include/linux/bpf.h | 5 + kernel/bpf/btf_ids.c | 12 kernel/trace/bpf_trace.c | 2 -- net/core/filte

[PATCHv3 0/9] bpf: Add d_path helper

hi, adding d_path helper to return full path for 'path' object. I originally added and used 'file_path' helper, which did the same, but used 'struct file' object. Then realized that file_path is just a wrapper for d_path, so we'd cover more calling sites if we add d_path helper and allowed resolvi

[PATCH 03/11] bpf: Add btf_ids object

Adding support to generate .BTF_ids section that would hold various BTF IDs list for verifier. Adding macros help to define lists of BTF IDs placed in .BTF_ids section. They are initially filled with zeros (during compilation) and resolved later during the linking phase by btfid tool. Following d

[PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

The btfid tool will be used during the vmlinux linking, so it's necessary it's ready for it. Signed-off-by: Jiri Olsa --- Makefile | 22 ++ tools/Makefile | 3 +++ tools/bpf/Makefile | 5 - 3 files changed, 25 insertions(+), 5 deletions(-) diff --git a/Ma

[PATCH 05/11] bpf: Remove btf_id helpers resolving

Now when we moved the helpers btf_id into .BTF_ids section, we can remove the code that resolve those IDs in runtime. Signed-off-by: Jiri Olsa --- kernel/bpf/btf.c | 88 +++- 1 file changed, 4 insertions(+), 84 deletions(-) diff --git a/kernel/bpf/btf

[PATCH 08/11] bpf: Add BTF whitelist support

Adding support to define 'whitelist' of BTF IDs, which is also sorted. Following defines sorted list of BTF IDs that is accessible within kernel code as btf_whitelist_d_path and its count is in btf_whitelist_d_path_cnt variable. extern int btf_whitelist_d_path[]; extern int btf_whitelist_d_pa

[PATCH 09/11] bpf: Add d_path helper

Adding d_path helper function that returns full path for give 'struct path' object, which needs to be the kernel BTF 'path' object. The helper calls directly d_path function. Updating also bpf.h tools uapi header and adding 'path' to bpf_helpers_doc.py script. Signed-off-by: Jiri Olsa --- incl

[PATCH 06/11] bpf: Do not pass enum bpf_access_type to btf_struct_access

There's no need for it. Signed-off-by: Jiri Olsa --- include/linux/bpf.h | 1 - kernel/bpf/btf.c | 3 +-- kernel/bpf/verifier.c | 2 +- net/ipv4/bpf_tcp_ca.c | 2 +- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index f18c23dcc858

[PATCH 11/11] selftests/bpf: Add test for d_path helper

Adding test for d_path helper which is pretty much copied from Wenbo Zhang's test for bpf_get_fd_path, which never made it in. I've failed so far to compile the test with kernel header, so for now adding 'struct file' with f_path member that has same offset as kernel's file object. Original-patc

[PATCH 10/11] selftests/bpf: Add verifier test for d_path helper

Adding verifier test for attaching tracing program and calling d_path helper from within and testing that it's allowed for dentry_open function and denied for 'd_path' function with appropriate error. Signed-off-by: Jiri Olsa --- tools/testing/selftests/bpf/test_verifier.c | 13 ++- tools/

Re: [PATCHv4 bpf-next 1/2] xdp: add a new helper for dev map multicast support

HI Jesper, On Tue, Jun 16, 2020 at 10:55:06AM +0200, Jesper Dangaard Brouer wrote: > > Is there anything else I should do except add the following line? > > nxdpf->mem.type = MEM_TYPE_PAGE_ORDER0; > > You do realize that you also have copied over the mem.id, right? Thanks for the reminding.

Re: [PATCH net v2 2/2] net/sched: act_gate: fix configuration of the periodic timer

hello Vladimir, thanks a lot for reviewing this. On Tue, 2020-06-16 at 00:55 +0300, Vladimir Oltean wrote: [...] > > diff --git a/net/sched/act_gate.c b/net/sched/act_gate.c > > index 6775ccf355b0..3c529a4bcca5 100644 > > --- a/net/sched/act_gate.c > > +++ b/net/sched/act_gate.c > > @@ -272,6 +

Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper

On Tue, Jun 16, 2020 at 11:10:27AM +0200, Heiko Stübner wrote: > > > > You also need to provide a proper header posting when you repost this series > > after fixing this bug. > > not sure I understand what you mean with "header posting" here. David is requesting that you send a "0/N" email summa

Re: [Intel-wired-lan] [PATCH] e1000e: continue to init phy even when failed to disable ULP

Dear Aaron, Thank you for your patch. (Rant: Some more fallout from the other patch, which nobody reverted.) Am 16.06.20 um 12:05 schrieb Aaron Ma: After commit "e1000e: disable s0ix entry and exit flows for ME systems", some ThinkPads always failed to disable ulp by ME. Please add the (sho

Re: [Intel-wired-lan] [PATCH] e1000e: continue to init phy even when failed to disable ULP

On 6/16/20 6:20 PM, Paul Menzel wrote: > Dear Aaron, > > > Thank you for your patch. > > (Rant: Some more fallout from the other patch, which nobody reverted.) > Would you like a revert? Thanks, Aaron > Am 16.06.20 um 12:05 schrieb Aaron Ma: >> After commit "e1000e: disable s0ix entry and ex

[PATCH bpf] xdp: handle frame_sz in xdp_convert_zc_to_xdp_frame()

In commit 34cc0b338a61 we only handled the frame_sz in convert_to_xdp_frame(). This patch will also handle frame_sz in xdp_convert_zc_to_xdp_frame(). Fixes: 34cc0b338a61 ("xdp: Xdp_frame add member frame_sz and handle in convert_to_xdp_frame") Signed-off-by: Hangbin Liu --- net/core/xdp.c | 1 +

Re: [PATCH net v2 2/2] net/sched: act_gate: fix configuration of the periodic timer

Hi Davide, On Tue, 16 Jun 2020 at 13:13, Davide Caratti wrote: > > hello Vladimir, > > thanks a lot for reviewing this. > > On Tue, 2020-06-16 at 00:55 +0300, Vladimir Oltean wrote: > > [...] > > > > diff --git a/net/sched/act_gate.c b/net/sched/act_gate.c > > > index 6775ccf355b0..3c529a4bcca5 1

KASAN: use-after-free Read in __smsc95xx_mdio_read

Hello, syzbot found the following crash on: HEAD commit:7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15f8334610 kernel config: https://syzkaller.appspot.com/x/.config?x=d195fe572fb15312 das

[PATCH rdma-next v2 00/11] RAW format dumps through RDMAtool

From: Leon Romanovsky Changelog: v2: * Converted to specific nldev ops for RAW. * Rebased on top of v5.8-rc1. v1: https://lore.kernel.org/linux-rdma/20200527135408.480878-1-l...@kernel.org * Maor dropped controversial change to dummy interface. v0: https://lore.kernel.org/linux-rdma/2020051309

[PATCH mlx5-next v2 01/11] net/mlx5: Export resource dump interface

From: Maor Gottlieb Export some of the resource dump API. mlx5_ib driver will use it in downstream patches. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- .../mellanox/mlx5/core/diag/rsc_dump.c| 3 ++ .../mellanox/mlx5/core/diag/rsc_dump.h| 33 +--

[PATCH mlx5-next v2 02/11] net/mlx5: Add support in query QP, CQ and MKEY segments

From: Maor Gottlieb Introduce new resource dump segments - PRM_QUERY_QP, PRM_QUERY_CQ and PRM_QUERY_MKEY. These segments contains the resource dump in PRM query format. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.c | 3

[PATCH rdma-rc] RDMA/mlx5: Fix missed RST2INIT and INIT2INIT steps during ECE handshake

From: Leon Romanovsky Missed step during ECE handshake left userspace application with less options for the ECE handshake with a need to do workarounds. Fixes: 50aec2c3135e ("RDMA/mlx5: Return ECE data after modify QP") Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/qpc.c | 8 +

Re: [PATCH net] net: core: reduce recursion limit value

On Tue, 16 Jun 2020 at 00:21, Florian Westphal wrote: > Hi Florian, Thank you for the review! > Taehee Yoo wrote: > > In the current code, ->ndo_start_xmit() can be executed recursively only > > 10 times because of stack memory. > > But, in the case of the vxlan, 10 recursion limit value result

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > From: wenxu > > In the function __flow_block_indr_cleanup, The match stataments > this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv > is totally different data with the flow_indr_dev->cb_priv. > > Store the rep

Re: [PATCH] e1000e: continue to init phy even when failed to disable ULP

> On Jun 16, 2020, at 18:05, Aaron Ma wrote: > > After commit "e1000e: disable s0ix entry and exit flows for ME systems", > some ThinkPads always failed to disable ulp by ME. > commit "e1000e: Warn if disabling ULP failed" break out of init phy: > > error log: > [ 42.364753] e1000e :00:

Re: [PATCH] e1000e: continue to init phy even when failed to disable ULP

On 6/16/20 7:23 PM, Kai-Heng Feng wrote: > > >> On Jun 16, 2020, at 18:05, Aaron Ma wrote: >> >> After commit "e1000e: disable s0ix entry and exit flows for ME systems", >> some ThinkPads always failed to disable ulp by ME. >> commit "e1000e: Warn if disabling ULP failed" break out of init ph

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

On Mon, Jun 15, 2020 at 10:54:52PM +0300, Yehezkel Bernat wrote: > On Mon, Jun 15, 2020 at 6:55 PM Mika Westerberg > wrote: > > > > On Mon, Jun 15, 2020 at 06:41:32PM +0300, Yehezkel Bernat wrote: > > > > I think you are talking about the "prtstns" property in the network > > > > driver. There we

[kbuild] Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper

Hi Heiko, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on sparc-next/master net/master linus/master v5.8-rc1 next-20200616] [cannot apply to robh/for-next] [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH net v2 2/2] net/sched: act_gate: fix configuration of the periodic timer

On Tue, 2020-06-16 at 13:38 +0300, Vladimir Oltean wrote: > Hi Davide, > > On Tue, 16 Jun 2020 at 13:13, Davide Caratti wrote: > > hello Vladimir, > > > > thanks a lot for reviewing this. > > > > On Tue, 2020-06-16 at 00:55 +0300, Vladimir Oltean wrote: [...] > > > What if you split the "repl

Re: [PATCH] dpaa_eth: fix usage as DSA master, try 3

On Tue, 26 May 2020 at 03:58, David Miller wrote: > > From: Vladimir Oltean > Date: Mon, 25 May 2020 00:22:51 +0300 > > > From: Vladimir Oltean > > > > The dpaa-eth driver probes on compatible string for the MAC node, and > > the fman/mac.c driver allocates a dpaa-ethernet platform device that >

Re: [PATCH v4 1/3] mm/slab: Use memzero_explicit() in kzfree()

On 6/15/20 11:30 PM, Eric Biggers wrote: On Mon, Jun 15, 2020 at 09:57:16PM -0400, Waiman Long wrote: The kzfree() function is normally used to clear some sensitive information, like encryption keys, in the buffer before freeing it back to the pool. Memset() is currently used for the buffer clea

Re: [PATCH] [bpf] xdp_redirect_cpu_user: Fix null pointer dereference

On 6/14/20 9:04 PM, Gaurav Singh wrote: Memset() on the pointer right after malloc() can cause a null pointer dereference if it failed to allocate memory. Fix this by replacing malloc/memset with a single calloc(). Signed-off-by: Gaurav Singh Squashed all three same fixes into one and pushed

[PATCH] net: ath10k: fix memcpy size from untrusted input

A compromized ath10k peripheral is able to control the size argument of memcpy in ath10k_pci_hif_exchange_bmi_msg. The min result from previous line is not used as the size argument for memcpy. Instead, xfer.resp_len comes from untrusted stream dma input. The value comes from "nbytes" in ath10k_pc

Re: [PATCH ipsec] xfrm: policy: match with both mark and mask on user interfaces

On Mon, Jun 15, 2020 at 5:56 PM Tobias Brunner wrote: > > Hi Xin, > > > To fix this duplicated policies issue, and also fix the issue in > > commit ed17b8d377ea ("xfrm: fix a warning in xfrm_policy_insert_list"), > > when doing add/del/get/update on user interfaces, this patch is to change > > to

RATE not being printed on tc -s class show dev XXXX

Good Morning. I am using debian buster 10.4 with iproute2 compile version 5.7.0. I am testing Traffic Control but on the statistics no Rate value is shown. For example in the following link "https://paste.ubuntu.com/10963208/";, i see following output: vv

RATE not being printed on tc -s class show dev XXXX

Good Morning. I am using debian buster 10.4 with iproute2 compile version 5.7.0. I am testing Traffic Control but on the statistics no Rate value is shown. For example in the following link "https://paste.ubuntu.com/10963208/";, i see following output: vv

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

在 2020/6/16 18:51, Simon Horman 写道: > On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: >> From: wenxu >> >> In the function __flow_block_indr_cleanup, The match stataments >> this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv >> is totally different data with th

Re: [PATCH net v2 2/2] net/sched: act_gate: fix configuration of the periodic timer

On Tue, 16 Jun 2020 at 15:43, Davide Caratti wrote: > > On Tue, 2020-06-16 at 13:38 +0300, Vladimir Oltean wrote: > > Hi Davide, > > > > On Tue, 16 Jun 2020 at 13:13, Davide Caratti wrote: > > > hello Vladimir, > > > > > > thanks a lot for reviewing this. > > > > > > On Tue, 2020-06-16 at 00:55 +

Re: [PATCH net] ip_tunnel: fix use-after-free in ip_tunnel_lookup()

On Tue, 16 Jun 2020 at 01:02, Eric Dumazet wrote: > Hi Eric, Thank you for the review! > > On 6/15/20 8:06 AM, Taehee Yoo wrote: > > In the datapath, the ip_tunnel_lookup() is used and it internally uses > > fallback tunnel device pointer, which is fb_tunnel_dev. > > This pointer is protected by

Re: [PATCH v4 2/3] mm, treewide: Rename kzfree() to kfree_sensitive()

Last time you sent this we couldn't decide which tree it should go through. Either the crypto tree or through Andrew seems like the right thing to me. Also the other issue is that it risks breaking things if people add new kzfree() instances while we are doing the transition. Could you just add

[PATCH bpf] devmap: use bpf_map_area_alloc() for allocating hash buckets

Syzkaller discovered that creating a hash of type devmap_hash with a large number of entries can hit the memory allocator limit for allocating contiguous memory regions. There's really no reason to use kmalloc_array() directly in the devmap code, so just switch it to the existing bpf_map_area_alloc

Re: [PATCH net] ip6_gre: fix use-after-free in ip6gre_tunnel_lookup()

On Tue, 16 Jun 2020 at 10:17, David Miller wrote: > Hi David, Thank you for the review :) > From: Taehee Yoo > Date: Mon, 15 Jun 2020 15:07:51 + > > > In the datapath, the ip6gre_tunnel_lookup() is used and it internally uses > > fallback tunnel device pointer, which is fb_tunnel_dev. > > T

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > > 在 2020/6/16 18:51, Simon Horman 写道: > > On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > >> From: wenxu > >> > >> In the function __flow_block_indr_cleanup, The match stataments > >> this->cb_priv == cb_priv is always fa

Re: [PATCHv4 bpf-next 1/2] xdp: add a new helper for dev map multicast support

On Tue, 16 Jun 2020 18:11:33 +0800 Hangbin Liu wrote: > HI Jesper, > > On Tue, Jun 16, 2020 at 10:55:06AM +0200, Jesper Dangaard Brouer wrote: > > > Is there anything else I should do except add the following line? > > > nxdpf->mem.type = MEM_TYPE_PAGE_ORDER0; > > > > You do realize that yo

[PATCH net 1/2] Revert "dpaa_eth: fix usage as DSA master, try 3"

From: Vladimir Oltean This reverts commit 5d14c304bfc14b4fd052dc83d5224376b48f52f0. The Fixes: tag was incorrect, and it was subsequently backported to the incorrect stable trees, breaking them. Reported-by: Joakim Tjernlund Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/freescale/d

[PATCH net 0/2] Reapply DSA fix for dpaa-eth with proper Fixes: tag

From: Vladimir Oltean Joakim notified me that this breaks stable trees. It turns out that my assessment about who-broke-who was wrong. The real Fixes: tag should have been: Fixes: 060ad66f9795 ("dpaa_eth: change DMA device") which changes the device on which SET_NETDEV_DEV is made. git describ

[PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

From: Vladimir Oltean The dpaa-eth driver probes on compatible string for the MAC node, and the fman/mac.c driver allocates a dpaa-ethernet platform device that triggers the probing of the dpaa-eth net device driver. All of this is fine, but the problem is that the struct device of the dpaa_eth

Re: [PATCH v4 3/3] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()

On Mon, Jun 15, 2020 at 09:57:18PM -0400, Waiman Long wrote: > In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc() > was incorrectly paired with kzfree(). According to David Sterba, there > isn't any sensitive information in the subvol_info that needs to be > cleared before fr

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

On Tue, 2020-06-16 at 17:41 +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > The dpaa-eth driver probes on compatible string for the MAC node, and > the fman/mac.c driver allocates a dpaa-ethernet platform device that > triggers the probing of the dpaa-eth net device driver. > > All of

Re: [PATCH] e1000e: add ifdef to avoid dead code

On 6/13/20 11:11 PM, Greg Thelen wrote: > Commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > systems") added e1000e_check_me() but it's only called from > CONFIG_PM_SLEEP protected code. Thus builds without CONFIG_PM_SLEEP > see: > drivers/net/ethernet/intel/e1000e/netde

Re: [PATCH 01/02] net: phy: marvell: Add Marvell 88E1340 support

On Tue, Jun 16, 2020 at 10:01:11AM +0300, Maxim Kochetkov wrote: > Add Marvell 88E1340 support Hi Maxim Are you sure this is an 88E1340, not a 88E1340S? Marvells DSDT SDK has: MAD_88E1340S = 0x1C,/* 88E1340S */ MAD_88E1340 = 0x1e,/* 88E1340/x0a */ MAD_88E1340M = 0x1f,/*

Re: [PATCH v4 10/11] seccomp: Switch addfd to Extensible Argument ioctl

On Mon, Jun 15, 2020 at 08:25:23PM -0700, Kees Cook wrote: > This patch is based on discussions[1] with Sargun Dhillon, Christian > Brauner, and David Laight. Instead of building size into the addfd > structure, make it a function of the ioctl command (which is how sizes are > normally passed to io

Re: [PATCH v4 09/11] selftests/seccomp: Rename user_trap_syscall() to user_notif_syscall()

On Mon, Jun 15, 2020 at 08:25:22PM -0700, Kees Cook wrote: > The user_trap_syscall() helper creates a filter with > SECCOMP_RET_USER_NOTIF. To avoid confusion with SECCOMP_RET_TRAP, rename > the helper to user_notif_syscall(). > > Additionally fix a redundant "return" after XFAIL. > > Signed-off-

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

Hi Joakim, On Tue, 16 Jun 2020 at 17:51, Joakim Tjernlund wrote: > > On Tue, 2020-06-16 at 17:41 +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > The dpaa-eth driver probes on compatible string for the MAC node, and > > the fman/mac.c driver allocates a dpaa-ethernet platform devi

Re: [PATCH v4 08/11] selftests/seccomp: Make kcmp() less required

On Mon, Jun 15, 2020 at 08:25:21PM -0700, Kees Cook wrote: > The seccomp tests are a bit noisy without CONFIG_CHECKPOINT_RESTORE (due > to missing the kcmp() syscall). The seccomp tests are more accurate with > kcmp(), but it's not strictly required. Refactor the tests to use > alternatives (compar

Re: [PATCH net v2 2/2] net/sched: act_gate: fix configuration of the periodic timer

On Tue, 2020-06-16 at 17:23 +0300, Vladimir Oltean wrote: > > (but again, this would be a fix for 'entries' - not for 'hitimer', so I > > plan to work on it as a separate patch, that fits better 'net-next' rather > > than 'net'). > > Targeting net-next would mean that the net tree would still keep

Re: [Patch net] net: change addr_list_lock back to static key

On Tue, 16 Jun 2020 at 06:33, Cong Wang wrote: > Hi Cong, > On Sat, Jun 13, 2020 at 9:03 AM Taehee Yoo wrote: > > > > On Thu, 11 Jun 2020 at 08:21, Cong Wang wrote: > > > > > > > Hi Cong :) > > > > > On Wed, Jun 10, 2020 at 7:48 AM Taehee Yoo wrote: > > > > > > > > On Tue, 9 Jun 2020 at 06:53

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

On Tue, 2020-06-16 at 17:56 +0300, Vladimir Oltean wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Hi Joakim, > > On Tue, 16 Jun 2020 at 17:51, Joakim Tjernl

Re: linux-next: build failures after merge of the vfs tree

On Tue, Jun 16, 2020 at 04:38:49AM +0100, Al Viro wrote: > > Folded and pushed Thanks Al. Here's another one that I just got, could you add this one too? diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c index c405722adfe1..c4f273e2fe78

Re: [PATCH v4 3/3] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()

On 6/16/20 10:48 AM, David Sterba wrote: On Mon, Jun 15, 2020 at 09:57:18PM -0400, Waiman Long wrote: In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc() was incorrectly paired with kzfree(). According to David Sterba, there isn't any sensitive information in the subvol_inf

Re: [PATCH v4 2/3] mm, treewide: Rename kzfree() to kfree_sensitive()

On 6/16/20 10:26 AM, Dan Carpenter wrote: Last time you sent this we couldn't decide which tree it should go through. Either the crypto tree or through Andrew seems like the right thing to me. Also the other issue is that it risks breaking things if people add new kzfree() instances while we ar

[PATCH net] ionic: export features for vlans to use

Set up vlan_features for use by any vlans above us. Fixes: beead698b173 ("ionic: Add the basic NDO callbacks for netdev support") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/pensando/io

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

On Tue, 16 Jun 2020 at 18:04, Joakim Tjernlund wrote: > > On Tue, 2020-06-16 at 17:56 +0300, Vladimir Oltean wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is safe. >

Re: [PATCH bpf] xdp: handle frame_sz in xdp_convert_zc_to_xdp_frame()

On Tue, 16 Jun 2020 18:35:18 +0800 Hangbin Liu wrote: > In commit 34cc0b338a61 we only handled the frame_sz in convert_to_xdp_frame(). > This patch will also handle frame_sz in xdp_convert_zc_to_xdp_frame(). > > Fixes: 34cc0b338a61 ("xdp: Xdp_frame add member frame_sz and handle in > convert_to

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

On Tue, 16 Jun 2020 at 18:08, Vladimir Oltean wrote: > > On Tue, 16 Jun 2020 at 18:04, Joakim Tjernlund > wrote: > > > > On Tue, 2020-06-16 at 17:56 +0300, Vladimir Oltean wrote: > > > CAUTION: This email originated from outside of the organization. Do not > > > click links or open attachments u

Re: linux-next: build failures after merge of the vfs tree

On Wed, Jun 17, 2020 at 12:38:07AM +1000, Herbert Xu wrote: > On Tue, Jun 16, 2020 at 04:38:49AM +0100, Al Viro wrote: > > > > Folded and pushed > > Thanks Al. Here's another one that I just got, could you add this > one too? Done...

Re: [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4

On Tue, 2020-06-16 at 18:12 +0300, Vladimir Oltean wrote: > On Tue, 16 Jun 2020 at 18:08, Vladimir Oltean wrote: > > On Tue, 16 Jun 2020 at 18:04, Joakim Tjernlund > > wrote: > > > On Tue, 2020-06-16 at 17:56 +0300, Vladimir Oltean wrote: > > > > CAUTION: This email originated from outside of the

  1   2   3   >