Hi Heiko, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] [also build test WARNING on sparc-next/master net/master linus/master v5.8-rc1 next-20200616] [cannot apply to robh/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Heiko-Stuebner/net-phy-mscc-move-shared-probe-code-into-a-helper/20200615-224727 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2 config: i386-randconfig-m021-20200616 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> smatch warnings: drivers/net/phy/mscc/mscc_main.c:2002 vsc8574_probe() error: potentially dereferencing uninitialized 'vsc8531'. # https://github.com/0day-ci/linux/commit/5be350208c014ad5e0afd06868ccaaefd6216345 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 5be350208c014ad5e0afd06868ccaaefd6216345 vim +/vsc8531 +2002 drivers/net/phy/mscc/mscc_main.c 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1984 static int vsc8574_probe(struct phy_device *phydev) 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1985 { 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1986 struct vsc8531_private *vsc8531; ^^^^^^^ 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1987 int rc; 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1988 u32 default_mode[4] = {VSC8531_LINK_1000_ACTIVITY, 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1989 VSC8531_LINK_100_ACTIVITY, VSC8531_LINK_ACTIVITY, 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1990 VSC8531_DUPLEX_COLLISION}; 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1991 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1992 rc = vsc85xx_probe_helper(phydev, default_mode, 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1993 ARRAY_SIZE(default_mode), 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1994 VSC8584_SUPP_LED_MODES, 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1995 vsc8584_hw_stats, 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1996 ARRAY_SIZE(vsc8584_hw_stats)); 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1997 if (rc < 0) 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 1998 return rc; 00d70d8e0e7811 drivers/net/phy/mscc.c Quentin Schulz 2018-10-08 1999 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 2000 vsc8584_get_base_addr(phydev); 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 2001 return devm_phy_package_join(&phydev->mdio.dev, phydev, 5be350208c014a drivers/net/phy/mscc/mscc_main.c Heiko Stuebner 2020-06-15 @2002 vsc8531->base_addr, 0); ^^^^^^^^^^^^^^^^^^ Not initialized. 00d70d8e0e7811 drivers/net/phy/mscc.c Quentin Schulz 2018-10-08 2003 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- kbu...@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
