Re: [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask

2020-06-10 Thread Greg Kroah-Hartman
On Tue, Jun 09, 2020 at 11:35:31PM -0700, Joe Perches wrote: > On Wed, 2020-06-10 at 08:31 +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 09, 2020 at 09:58:07AM -0700, Joe Perches wrote: > > > On Tue, 2020-06-09 at 13:16 +0200, Greg Kroah-Hartman wrote: > > > > What is wrong with the existing con

Re: [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask

2020-06-10 Thread Joe Perches
On Wed, 2020-06-10 at 09:09 +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 11:35:31PM -0700, Joe Perches wrote: > > On Wed, 2020-06-10 at 08:31 +0200, Greg Kroah-Hartman wrote: > > > On Tue, Jun 09, 2020 at 09:58:07AM -0700, Joe Perches wrote: > > > > On Tue, 2020-06-09 at 13:16 +0200,

[PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-10 Thread Manivannan Sadhasivam
Hello, This series adds CAN network driver support for Microchip MCP25XXFD CAN Controller with MCP2517FD as the target controller version. This series is mostly inspired (or taken) from the previous iterations posted by Martin Sperl. I've trimmed down the parts which are not necessary for the init

[PATCH 1/6] dt-bindings: can: Document devicetree bindings for MCP25XXFD

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl Add devicetree YAML bindings for Microchip MCP25XXFD CAN controller. Signed-off-by: Martin Sperl [mani: converted to YAML binding] Signed-off-by: Manivannan Sadhasivam --- .../bindings/net/can/microchip,mcp25xxfd.yaml | 82 +++ 1 file changed, 82 insertions(

[PATCH 5/6] can: mcp25xxfd: Optimize TEF read by avoiding unnecessary SPI transfers

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl We have already enough information to know how many tx-messages have been terminated so that we do not have to query TEF every time if there is anything pending but we can read the tefs blindly. This avoids 1 SPI transfer per TEF read. Signed-off-by: Martin Sperl Signed-off-

[PATCH 6/6] MAINTAINERS: Add entry for Microchip MCP25XXFD CAN network driver

2020-06-10 Thread Manivannan Sadhasivam
Add MAINTAINERS entry for Microchip MCP25XXFD CAN network driver. Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b816a453b10e..591b6fc2d83a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10360,6 +10

[PATCH 3/6] can: mcp25xxfd: Add support for CAN reception

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl Add un-optimized CAN2.0 and CAN-FD reception support. On a Rasperry pi 3 it is already able to process CAN2.0 Frames with DLC=0 on a CAN bus with 1MHz without losing any packets on the SPI side. Packets still get lost inside the network stack. Signed-off-by: Martin Sperl [ma

[PATCH 2/6] can: mcp25xxfd: Add Microchip MCP25XXFD CAN-FD driver infrastructure

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl This commit adds basic driver support for the Microchip MCP25XXFD CAN-FD controller series. This driver currently supports MCP2517FD as the target controller. The MCP2517FD is capable of transmitting and receiving standard data frames, extended data frames, remote frames and C

[PATCH 4/6] can: mcp25xxfd: Add CAN transmission support

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl Add un-optimized CAN2.0 and CAN-FD transmission support. On a Rpi3 we can saturate the CAN bus at 1MHz transmitting CAN2.0 frames with DLC=0 for the number of configured tx-fifos. Afterwards we need some time to recover the state before we can fill in the fifos again. With 7

[RESEND PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-10 Thread Manivannan Sadhasivam
Hello, This series adds CAN network driver support for Microchip MCP25XXFD CAN Controller with MCP2517FD as the target controller version. This series is mostly inspired (or taken) from the previous iterations posted by Martin Sperl. I've trimmed down the parts which are not necessary for the init

[RESEND PATCH 3/6] can: mcp25xxfd: Add support for CAN reception

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl Add un-optimized CAN2.0 and CAN-FD reception support. On a Rasperry pi 3 it is already able to process CAN2.0 Frames with DLC=0 on a CAN bus with 1MHz without losing any packets on the SPI side. Packets still get lost inside the network stack. Signed-off-by: Martin Sperl [ma

[RESEND PATCH 2/6] can: mcp25xxfd: Add Microchip MCP25XXFD CAN-FD driver infrastructure

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl This commit adds basic driver support for the Microchip MCP25XXFD CAN-FD controller series. This driver currently supports MCP2517FD as the target controller. The MCP2517FD is capable of transmitting and receiving standard data frames, extended data frames, remote frames and C

[RESEND PATCH 1/6] dt-bindings: can: Document devicetree bindings for MCP25XXFD

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl Add devicetree YAML bindings for Microchip MCP25XXFD CAN controller. Signed-off-by: Martin Sperl [mani: converted to YAML binding] Signed-off-by: Manivannan Sadhasivam --- .../bindings/net/can/microchip,mcp25xxfd.yaml | 82 +++ 1 file changed, 82 insertions(

[RESEND PATCH 5/6] can: mcp25xxfd: Optimize TEF read by avoiding unnecessary SPI transfers

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl We have already enough information to know how many tx-messages have been terminated so that we do not have to query TEF every time if there is anything pending but we can read the tefs blindly. This avoids 1 SPI transfer per TEF read. Signed-off-by: Martin Sperl Signed-off-

[RESEND PATCH 4/6] can: mcp25xxfd: Add CAN transmission support

2020-06-10 Thread Manivannan Sadhasivam
From: Martin Sperl Add un-optimized CAN2.0 and CAN-FD transmission support. On a Rpi3 we can saturate the CAN bus at 1MHz transmitting CAN2.0 frames with DLC=0 for the number of configured tx-fifos. Afterwards we need some time to recover the state before we can fill in the fifos again. With 7

[RESEND PATCH 6/6] MAINTAINERS: Add entry for Microchip MCP25XXFD CAN network driver

2020-06-10 Thread Manivannan Sadhasivam
Add MAINTAINERS entry for Microchip MCP25XXFD CAN network driver. Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b816a453b10e..591b6fc2d83a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10360,6 +10

correct use of PHY_INTERFACE_MODE_RGMII{,_TXID,_RXID,_ID}

2020-06-10 Thread Helmut Grohne
Hi, I've been trying to write a dt for a board and got quite confused about the RGMII delays. That's why I looked into it and got even more confused by what I found. Different drivers handle this quite differently. Let me summarize. Some drivers handle the RGMII modes individually. This is how I

ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Heiner Kallweit
Since ethtool 5.7 following happens (kernel is latest linux-next): ethtool -s enp3s0 wol g netlink error: No such file or directory With ethtool 5.6 this doesn't happen. I also checked the latest ethtool git version (5.7 + some fixes), error still occurs. Heiner

[PATCH v4 0/3] Add support for SQI and master-slave

2020-06-10 Thread Oleksij Rempel
This patch set is extending ethtool to make it more usable on automotive PHYs like NXP TJA11XX. They make use of new KAPI (currently in net-next, will go probably to the kernel 5.8-rc1): - PHY master-slave role configuration and status informaton. Mostly needed for 100Base-T1 PHYs due the lack o

[PATCH v4 2/3] netlink: add master/slave configuration support

2020-06-10 Thread Oleksij Rempel
This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of auto-negotiation support, we needed to be able to configure the MASTER-SLAVE role of the port manually or from an application in user space. The same UAPI can be used for 1000BASE-T or MultiGBASE-T devices to force MASTER or S

[PATCH v4 3/3] netlink: add LINKSTATE SQI support

2020-06-10 Thread Oleksij Rempel
Some PHYs provide Signal Quality Index (SQI) if the link is in active state. This information can help to diagnose cable and system design related issues. Signed-off-by: Oleksij Rempel Reviewed-by: Florian Fainelli Reviewed-by: Michal Kubecek --- netlink/desc-ethtool.c | 2 ++ netlink/setting

[PATCH v4 1/3] update UAPI header copies

2020-06-10 Thread Oleksij Rempel
Update to linux/master: 5b14671be58d00 ("Merge tag 'fuse-update-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse") Signed-off-by: Oleksij Rempel --- uapi/linux/ethtool.h | 16 +++- uapi/linux/ethtool_netlink.h | 153 ++- uapi/linux/gen

Re: [PATCH bpf] libbpf: handle GCC noreturn-turned-volatile quirk

2020-06-10 Thread Jean-Philippe Brucker
On Tue, Jun 09, 2020 at 10:23:35PM -0700, Andrii Nakryiko wrote: > Handle a GCC quirk of emitting extra volatile modifier in DWARF (and > subsequently preserved in BTF by pahole) for function pointers marked as > __attribute__((noreturn)). This was the way to mark such functions before GCC > 2.5 ad

[PATCH net] mptcp: fix races between shutdown and recvmsg

2020-06-10 Thread Paolo Abeni
The msk sk_shutdown flag is set by a workqueue, possibly introducing some delay in user-space notification. If the last subflow carries some data with the fin packet, the user space can wake-up before RCV_SHUTDOWN is set. If it executes unblocking recvmsg(), it may return with an error instead of e

[PATCH net] mptcp: don't leak msk in token container

2020-06-10 Thread Paolo Abeni
If a listening MPTCP socket has unaccepted sockets at close time, the related msks are freed via mptcp_sock_destruct(), which in turn does not invoke the proto->destroy() method nor the mptcp_token_destroy() function. Due to the above, the child msk socket is not removed from the token container,

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Heiner Kallweit
On 10.06.2020 10:26, Heiner Kallweit wrote: > Since ethtool 5.7 following happens (kernel is latest linux-next): > > ethtool -s enp3s0 wol g > netlink error: No such file or directory > > With ethtool 5.6 this doesn't happen. I also checked the latest ethtool > git version (5.7 + some fixes), err

Re: [PATCH net v3 3/3] esp, ah: modernize the crypto algorithm selections

2020-06-10 Thread Tobias Brunner
Hi Eric, > + Note that RFC 8221 considers AH itself to be "NOT RECOMMENDED". It is > + better to use ESP only, using an AEAD cipher such as AES-GCM. What's NOT RECOMMENDED according to the RFC is the combination of ESP+AH (i.e. use ESP only for confidentiality and AH for authenticati

RE: correct use of PHY_INTERFACE_MODE_RGMII{,_TXID,_RXID,_ID}

2020-06-10 Thread Ioana Ciornei
Hi Helmut, > Subject: correct use of PHY_INTERFACE_MODE_RGMII{,_TXID,_RXID,_ID} > > Hi, > > I've been trying to write a dt for a board and got quite confused about the > RGMII delays. That's why I looked into it and got even more confused by what I > found. Different drivers handle this quite

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Michal Kubecek
On Wed, Jun 10, 2020 at 10:52:26AM +0200, Heiner Kallweit wrote: > On 10.06.2020 10:26, Heiner Kallweit wrote: > > Since ethtool 5.7 following happens (kernel is latest linux-next): > > > > ethtool -s enp3s0 wol g > > netlink error: No such file or directory > > > > With ethtool 5.6 this doesn't

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Christian Brauner
On Tue, Jun 09, 2020 at 09:52:12PM -0700, Kees Cook wrote: > Hi, > > This extends the recent work hch did for scm_detach_fds(), and updates > the compat path as well, fixing bugs in the process. Additionally, > an effectively incomplete and open-coded __scm_install_fd() is fixed > in pidfd_getfd()

[PATCH] net: cadence: macb: disable NAPI on error

2020-06-10 Thread Corentin Labbe
When the PHY is not working, the macb driver crash on a second try to setup it. [ 78.545994] macb e000b000.ethernet eth0: Could not attach PHY (-19) ifconfig: SIOCSIFFLAGS: No such device [ 78.655457] [ cut here ] [ 78.656014] kernel BUG at /linux-next/include/linux/ne

Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

2020-06-10 Thread Jesper Dangaard Brouer
On Wed, 10 Jun 2020 10:35:08 +0800 Hangbin Liu wrote: > On Tue, Jun 09, 2020 at 10:31:19PM +0200, Toke Høiland-Jørgensen wrote: > > > Oh, sorry for the typo, the numbers make me crazy, it should be only > > > ingress i40e, egress veth. Here is the right description: > > > > > > Kernel 5.7 + my

Re: [MPTCP] [PATCH net] mptcp: fix races between shutdown and recvmsg

2020-06-10 Thread Matthieu Baerts
Hi Paolo, On 10/06/2020 10:47, Paolo Abeni wrote: The msk sk_shutdown flag is set by a workqueue, possibly introducing some delay in user-space notification. If the last subflow carries some data with the fin packet, the user space can wake-up before RCV_SHUTDOWN is set. If it executes unblockin

Re: [MPTCP] [PATCH net] mptcp: don't leak msk in token container

2020-06-10 Thread Matthieu Baerts
Hi Paolo, On 10/06/2020 10:49, Paolo Abeni wrote: If a listening MPTCP socket has unaccepted sockets at close time, the related msks are freed via mptcp_sock_destruct(), which in turn does not invoke the proto->destroy() method nor the mptcp_token_destroy() function. Due to the above, the child

Re: [PATCHv4 bpf-next 1/2] xdp: add a new helper for dev map multicast support

2020-06-10 Thread Jesper Dangaard Brouer
On Tue, 26 May 2020 22:05:38 +0800 Hangbin Liu wrote: > diff --git a/net/core/xdp.c b/net/core/xdp.c > index 90f44f382115..acdc63833b1f 100644 > --- a/net/core/xdp.c > +++ b/net/core/xdp.c > @@ -475,3 +475,29 @@ void xdp_warn(const char *msg, const char *func, const > int line) > WARN(1, "

[PATCH bpf] bpf: tcp: recv() should return 0 when the peer socket is closed

2020-06-10 Thread Sabrina Dubroca
If the peer is closed, we will never get more data, so tcp_bpf_wait_data will get stuck forever. In case we passed MSG_DONTWAIT to recv(), we get EAGAIN but we should actually get 0. >From man 2 recv: RETURN VALUE When a stream socket peer has performed an orderly shutdown, the retur

Re: [PATCHv4 bpf-next 1/2] xdp: add a new helper for dev map multicast support

2020-06-10 Thread Jesper Dangaard Brouer
On Tue, 26 May 2020 22:05:38 +0800 Hangbin Liu wrote: > diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c > index a51d9fb7a359..ecc5c44a5bab 100644 > --- a/kernel/bpf/devmap.c > +++ b/kernel/bpf/devmap.c [...] > +int dev_map_enqueue_multi(struct xdp_buff *xdp, struct net_device *dev_rx, > +

Re: [PATCHv4 bpf-next 1/2] xdp: add a new helper for dev map multicast support

2020-06-10 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Tue, 26 May 2020 22:05:38 +0800 > Hangbin Liu wrote: > >> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c >> index a51d9fb7a359..ecc5c44a5bab 100644 >> --- a/kernel/bpf/devmap.c >> +++ b/kernel/bpf/devmap.c > [...] > >> +int dev_map_enqueue_multi(struct

Re: [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask

2020-06-10 Thread Stanimir Varbanov
Hi Greg, On 6/9/20 2:16 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 01:45:58PM +0300, Stanimir Varbanov wrote: >> This adds description of the level bitmask feature. >> >> Cc: Jonathan Corbet (maintainer:DOCUMENTATION) >> >> Signed-off-by: Stanimir Varbanov >> --- >> Documentation/a

Re: correct use of PHY_INTERFACE_MODE_RGMII{,_TXID,_RXID,_ID}

2020-06-10 Thread Helmut Grohne
Hi Ioana, On Wed, Jun 10, 2020 at 11:10:23AM +0200, Ioana Ciornei wrote: > > freescale/dpaa2/dpaa2-mac.c is interesting. It checks whether any rgmii mode > > other than PHY_INTERFACE_MODE_RGMII is used and complains that delays are > > not supported in that case. The above comment says that the MA

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Heiner Kallweit
On 10.06.2020 11:13, Michal Kubecek wrote: > On Wed, Jun 10, 2020 at 10:52:26AM +0200, Heiner Kallweit wrote: >> On 10.06.2020 10:26, Heiner Kallweit wrote: >>> Since ethtool 5.7 following happens (kernel is latest linux-next): >>> >>> ethtool -s enp3s0 wol g >>> netlink error: No such file or dire

Re: [PATCH RFC v6 02/11] vhost: use batched get_vq_desc version

2020-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2020 at 11:14:49AM +0800, Jason Wang wrote: > > On 2020/6/8 下午8:52, Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > > > Signed-off-by: Michael S. Tsirkin > > Signed-off-by: Eugenio Pérez > > Link: https://lore.kernel.org/r/2020040118

Re: [RFC PATCH bpf-next 2/2] i40e: avoid xdp_do_redirect() call when "redirect_tail_call" is set

2020-06-10 Thread Björn Töpel
On Tue, 9 Jun 2020 at 21:47, Toke Høiland-Jørgensen wrote: > > Björn Töpel writes: > > > From: Björn Töpel > > > > If an XDP program, where all the bpf_redirect_map() calls are tail > > calls (as defined by the previous commit), the driver does not need to > > explicitly call xdp_do_redirect().

Re: [PATCH RFC v6 02/11] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Mon, Jun 8, 2020 at 2:53 PM Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Eugenio Pérez > Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com > Signed-off-by: Michael S. Ts

[PATCH RFC v7 00/14] vhost: ring format independence

2020-06-10 Thread Michael S. Tsirkin
This intentionally leaves "fixup" changes separate - hopefully that is enough to fix vhost-net crashes reported here, but it helps me keep track of what changed. I will naturally squash them later when we are done. This adds infrastructure required for supporting multiple ring formats. The idea

[PATCH RFC v7 07/14] fixup! vhost: format-independent API for used buffers

2020-06-10 Thread Michael S. Tsirkin
--- drivers/vhost/vhost.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index e5763d81bf0f..7a587b13095c 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -2421,7 +2421,7 @@ int vhost_get_av

[PATCH RFC v7 10/14] vhost/net: avoid iov length math

2020-06-10 Thread Michael S. Tsirkin
Now that API exposes buffer length, we no longer need to scan IOVs to figure it out. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 830fe84912a5..0b509be8d7b1 10

[PATCH RFC v7 04/14] vhost/net: pass net specific struct pointer

2020-06-10 Thread Michael S. Tsirkin
In preparation for further cleanup, pass net specific pointer to ubuf callbacks so we can move net specific fields out to net structures. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/net

[PATCH RFC v7 14/14] vhost: drop head based APIs

2020-06-10 Thread Michael S. Tsirkin
Everyone's using buf APIs, no need for head based ones anymore. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 64 ++- drivers/vhost/vhost.h | 12 2 files changed, 8 insertions(+), 68 deletions(-) diff --git a/drivers/vhost/vhost.c

[PATCH RFC v7 12/14] vhost/scsi: switch to buf APIs

2020-06-10 Thread Michael S. Tsirkin
Switch to buf APIs. Doing this exposes a spec violation in vhost scsi: all used bufs are marked with length 0. Fix that is left for another day. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/scsi.c | 73 ++-- 1 file changed, 44 insertions(+), 29 dele

[PATCH RFC v7 13/14] vhost/vsock: switch to the buf API

2020-06-10 Thread Michael S. Tsirkin
A straight-forward conversion. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vsock.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index a483cec31d5c..61c6d3dd2ae3 100644 --- a/drivers/vhos

[PATCH RFC v7 09/14] vhost/net: convert to new API: heads->bufs

2020-06-10 Thread Michael S. Tsirkin
Convert vhost net to use the new format-agnostic API. In particular, don't poke at vq internals such as the heads array. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 154 +++- 1 file changed, 82 insertions(+), 72 deletions(-) diff --git a/d

[PATCH RFC v7 11/14] vhost/test: convert to the buf API

2020-06-10 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c index 7d69778aaa26..12304eb8da15 100644 --- a/drivers/vhost/test.c +++ b/drivers/vhost/test.c @@ -44,9 +

[PATCH RFC v7 05/14] vhost: reorder functions

2020-06-10 Thread Michael S. Tsirkin
Reorder functions in the file to not rely on forward declarations, in preparation to making them static down the road. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/vhost/vhost.

[PATCH RFC v7 02/14] fixup! vhost: option to fetch descriptors through an independent struct

2020-06-10 Thread Michael S. Tsirkin
--- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 180b7b58c76b..11433d709651 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -2614,7 +2614,7 @@ int vhost_get_vq_desc_batch(struct vhost

[PATCH RFC v7 08/14] fixup! vhost: use batched get_vq_desc version

2020-06-10 Thread Michael S. Tsirkin
--- drivers/vhost/vhost.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 7a587b13095c..03e6bca02288 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -2205,10 +2205,6 @@ static int fetch_buf(struct vhost_virtqueue *vq)

[PATCH RFC v7 06/14] vhost: format-independent API for used buffers

2020-06-10 Thread Michael S. Tsirkin
Add a new API that doesn't assume used ring, heads, etc. For now, we keep the old APIs around to make it easier to convert drivers. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.c | 52 ++- drivers/vhost/vhost.h | 17 +- 2 files cha

[PATCH RFC v7 01/14] vhost: option to fetch descriptors through an independent struct

2020-06-10 Thread Michael S. Tsirkin
The idea is to support multiple ring formats by converting to a format-independent array of descriptors. This costs extra cycles, but we gain in ability to fetch a batch of descriptors in one go, which is good for code cache locality. When used, this causes a minor performance degradation, it's b

[PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Michael S. Tsirkin
As testing shows no performance change, switch to that now. Signed-off-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 2 +- drivers/vhost/vhost.c | 318

Re: [PATCH bpf] libbpf: handle GCC noreturn-turned-volatile quirk

2020-06-10 Thread Daniel Borkmann
On 6/10/20 7:23 AM, Andrii Nakryiko wrote: Handle a GCC quirk of emitting extra volatile modifier in DWARF (and subsequently preserved in BTF by pahole) for function pointers marked as __attribute__((noreturn)). This was the way to mark such functions before GCC 2.5 added noreturn attribute. Drop

RE: correct use of PHY_INTERFACE_MODE_RGMII{,_TXID,_RXID,_ID}

2020-06-10 Thread Ioana Ciornei
> Subject: Re: correct use of PHY_INTERFACE_MODE_RGMII{,_TXID,_RXID,_ID} > > Hi Ioana, > > On Wed, Jun 10, 2020 at 11:10:23AM +0200, Ioana Ciornei wrote: > > > freescale/dpaa2/dpaa2-mac.c is interesting. It checks whether any > > > rgmii mode other than PHY_INTERFACE_MODE_RGMII is used and compla

[PATCH ethtool] netlink: fix error message suppression

2020-06-10 Thread Michal Kubecek
Rewrite of nlsock_process_reply() used a bool variable to store the value of nlctx->suppress_nlerr before passing to nlsock_process_ack(). This causes the value of 2 (suppress all error/warning messages) to be converted to 1 (suppress only -EOPNOTSUPP). As a result, -ENOENT returned by failed genet

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Michal Kubecek
On Wed, Jun 10, 2020 at 12:50:30PM +0200, Heiner Kallweit wrote: > On 10.06.2020 11:13, Michal Kubecek wrote: > > Just to make sure you are hitting the same problem I'm just looking at, > > please check if > > > > - your kernel is built with ETHTOOL_NETLINK=n > > No, because I have PHYLIB=m. > No

[PATCH 1/1] net: stmmac: gmac3: add auxiliary snapshot support

2020-06-10 Thread Olivier Dautricourt
From: Artem Panfilov This patch adds support for time stamping external inputs for GMAC3. The documentation defines 4 auxiliary snapshots ATSEN0 to ATSEN3 which can be toggled by writing the Timestamp Control Register. When the gmac detects a pps rising edge on one of it's auxiliary inputs, an

Re: [PATCH 02/15] iwlwifi: mvm: fix gcc-10 zero-length-bounds warning

2020-06-10 Thread Luciano Coelho
On Thu, 2020-04-30 at 23:30 +0200, Arnd Bergmann wrote: > gcc-10 complains when a zero-length array is accessed: > > drivers/net/wireless/intel/iwlwifi/mvm/tx.c: In function > 'iwl_mvm_rx_ba_notif': > drivers/net/wireless/intel/iwlwifi/mvm/tx.c:1929:17: warning: array subscript > 9 is outside th

Re: [RFC PATCH bpf-next 0/2] bpf_redirect_map() tail call detection and xdp_do_redirect() avoidance

2020-06-10 Thread Jesper Dangaard Brouer
> Björn Töpel writes: > > > Is this a good idea? I have only measured for AF_XDP redirects, but > > all XDP_REDIRECT targets should benefit. For AF_XDP the rxdrop > > scenario went from 21.5 to 23.2 Mpps on my machine. Do remember that you are reporting saving 3.4 nanosec (from 21.5 to 23.2

Re: [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask

2020-06-10 Thread Greg Kroah-Hartman
On Wed, Jun 10, 2020 at 01:29:20PM +0300, Stanimir Varbanov wrote: > Hi Greg, > > On 6/9/20 2:16 PM, Greg Kroah-Hartman wrote: > > On Tue, Jun 09, 2020 at 01:45:58PM +0300, Stanimir Varbanov wrote: > >> This adds description of the level bitmask feature. > >> > >> Cc: Jonathan Corbet (maintainer:

Re: [PATCH 6/9] net: wireless: intel: fix wiki website url

2020-06-10 Thread Luca Coelho
Flavio Suligoi wrote: > In some Intel files, the wiki url is still the old > "wireless.kernel.org" instead of the new > "wireless.wiki.kernel.org" > > Signed-off-by: Flavio Suligoi Patch applied to iwlwifi-next.git, thanks. e00c6d8d491b net: wireless: intel: fix wiki website url

Re: [PATCH] iwlwifi: mvm: Remove unused inline function iwl_mvm_tid_to_ac_queue

2020-06-10 Thread Luca Coelho
YueHaibing wrote: > commit cfbc6c4c5b91 ("iwlwifi: mvm: support mac80211 TXQs model") > left behind this, remove it. > > Signed-off-by: YueHaibing Patch applied to iwlwifi-next.git, thanks. f12694634153 iwlwifi: mvm: Remove unused inline function iwl_mvm_tid_to_ac_queue

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Wed, Jun 10, 2020 at 1:36 PM Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Eugenio Pérez > Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com > Signed-off-by: Michael S. T

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Stanimir Varbanov
On 6/9/20 2:14 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 01:46:03PM +0300, Stanimir Varbanov wrote: >> Here we introduce few debug macros with levels (low, medium and >> high) and debug macro for firmware. Enabling the particular level >> will be done by dynamic debug with levels.

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Greg Kroah-Hartman
On Wed, Jun 10, 2020 at 04:29:27PM +0300, Stanimir Varbanov wrote: > > > On 6/9/20 2:14 PM, Greg Kroah-Hartman wrote: > > On Tue, Jun 09, 2020 at 01:46:03PM +0300, Stanimir Varbanov wrote: > >> Here we introduce few debug macros with levels (low, medium and > >> high) and debug macro for firmware

Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-06-10 Thread Vadym Kochan
On Wed, Jun 03, 2020 at 04:16:32PM +0200, Jiri Pirko wrote: > Thu, May 28, 2020 at 05:12:40PM CEST, vadym.koc...@plvision.eu wrote: > > [...] > > >+} > >+ > >+int prestera_hw_port_info_get(const struct prestera_port *port, > >+ u16 *fp_id, u32 *hw_id, u32 *dev_id) > > Pl

Re: [PATCH RFC v7 02/14] fixup! vhost: option to fetch descriptors through an independent struct

2020-06-10 Thread Eugenio Pérez
On Wed, 2020-06-10 at 07:35 -0400, Michael S. Tsirkin wrote: > --- > drivers/vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 180b7b58c76b..11433d709651 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers

Re: [Patch net v2] genetlink: fix memory leaks in genl_family_rcv_msg_dumpit()

2020-06-10 Thread Ido Schimmel
On Tue, Jun 02, 2020 at 09:49:10PM -0700, Cong Wang wrote: > diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c > index 9f357aa22b94..bcbba0bef1c2 100644 > --- a/net/netlink/genetlink.c > +++ b/net/netlink/genetlink.c > @@ -513,15 +513,58 @@ static void genl_family_rcv_msg_attrs_free(co

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Pérez
On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Eugenio Pérez > Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com > Signed-off-by: Michael S.

Re: [RESEND PATCH 2/6] can: mcp25xxfd: Add Microchip MCP25XXFD CAN-FD driver infrastructure

2020-06-10 Thread kernel test robot
Hi Manivannan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on linus/master v5.7 next-20200610] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to

Re: [Patch net] net: change addr_list_lock back to static key

2020-06-10 Thread Taehee Yoo
On Tue, 9 Jun 2020 at 06:53, Cong Wang wrote: > Hi Cong, Thank you for this work! > The dynamic key update for addr_list_lock still causes troubles, > for example the following race condition still exists: > > CPU 0: CPU 1: > (RCU read lock) (RTNL lock) >

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Kees Cook
On Wed, Jun 10, 2020 at 11:47:35AM +0200, Christian Brauner wrote: > On Tue, Jun 09, 2020 at 09:52:12PM -0700, Kees Cook wrote: > > Hi, > > > > This extends the recent work hch did for scm_detach_fds(), and updates > > the compat path as well, fixing bugs in the process. Additionally, > > an effec

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2020 at 04:29:29PM +0200, Eugenio Pérez wrote: > On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > > > Signed-off-by: Michael S. Tsirkin > > Signed-off-by: Eugenio Pérez > > Link: https://lore.kernel.o

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Wed, Jun 10, 2020 at 5:08 PM Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2020 at 04:29:29PM +0200, Eugenio Pérez wrote: > > On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > > > As testing shows no performance change, switch to that now. > > > > > > Signed-off-by: Michael S. Tsi

Re: [PATCH RFC v7 04/14] vhost/net: pass net specific struct pointer

2020-06-10 Thread Eugenio Pérez
On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > In preparation for further cleanup, pass net specific pointer > to ubuf callbacks so we can move net specific fields > out to net structures. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/net.c | 14 +++--- > 1

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2020 at 02:37:50PM +0200, Eugenio Perez Martin wrote: > > +/* This function returns a value > 0 if a descriptor was found, or 0 if > > none were found. > > + * A negative code is returned on error. */ > > +static int fetch_descs(struct vhost_virtqueue *vq) > > +{ > > + int re

Fw: [Bug 208121] New: IPsec AH ICV Padding for IPv4

2020-06-10 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 10 Jun 2020 09:32:26 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 208121] New: IPsec AH ICV Padding for IPv4 https://bugzilla.kernel.org/show_bug.cgi?id=208121 Bug ID: 208121 Summary: I

Re: [PATCH] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-10 Thread Florian Fainelli
On 6/9/2020 11:26 PM, Sascha Hauer wrote: > Hi Andrew, > > +Cc Maxime Chevallier > > On Tue, Jun 09, 2020 at 03:28:48PM +0200, Andrew Lunn wrote: >> On Tue, Jun 09, 2020 at 03:11:52PM +0200, Sascha Hauer wrote: >>> The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode >>> called

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Florian Fainelli
On 6/10/2020 3:50 AM, Heiner Kallweit wrote: > On 10.06.2020 11:13, Michal Kubecek wrote: >> On Wed, Jun 10, 2020 at 10:52:26AM +0200, Heiner Kallweit wrote: >>> On 10.06.2020 10:26, Heiner Kallweit wrote: Since ethtool 5.7 following happens (kernel is latest linux-next): ethtool

Re: [PATCH net v3 3/3] esp, ah: modernize the crypto algorithm selections

2020-06-10 Thread Eric Biggers
On Wed, Jun 10, 2020 at 11:03:55AM +0200, Tobias Brunner wrote: > Hi Eric, > > > + Note that RFC 8221 considers AH itself to be "NOT RECOMMENDED". It is > > + better to use ESP only, using an AEAD cipher such as AES-GCM. > > What's NOT RECOMMENDED according to the RFC is the combination

Re: [PATCH iproute2 net-next 1/2] ipnexthop: support for fdb nexthops

2020-06-10 Thread David Ahern
On 6/8/20 9:46 PM, Roopa Prabhu wrote: > @@ -70,6 +71,12 @@ static int nh_dump_filter(struct nlmsghdr *nlh, int reqlen) > return err; > } > > + if (filter.fdb) { > + addattr_l(nlh, reqlen, NHA_FDB, NULL, 0); missing 'err = ' > + if (err) >

[PATCH net v4 0/3] esp, ah: improve crypto algorithm selections

2020-06-10 Thread Eric Biggers
This series consolidates and modernizes the lists of crypto algorithms that are selected by the IPsec kconfig options, and adds CRYPTO_SEQIV since it no longer gets selected automatically by other things. See previous discussion at https://lkml.kernel.org/netdev/20200604192322.22142-1-ebigg...@ker

[PATCH net v4 1/3] esp, ah: consolidate the crypto algorithm selections

2020-06-10 Thread Eric Biggers
From: Eric Biggers Instead of duplicating the algorithm selections between INET_AH and INET6_AH and between INET_ESP and INET6_ESP, create new tristates XFRM_AH and XFRM_ESP that do the algorithm selections, and make these be selected by the corresponding INET* options. Suggested-by: Herbert Xu

[PATCH net v4 2/3] esp: select CRYPTO_SEQIV

2020-06-10 Thread Eric Biggers
From: Eric Biggers Commit f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") made CRYPTO_CTR stop selecting CRYPTO_SEQIV. This breaks IPsec for most users since GCM and several other encryption algorithms require "seqiv" -- and RFC 8221 lists AES-GCM as "MUST" be implemented. Just make

[PATCH net v4 3/3] esp, ah: modernize the crypto algorithm selections

2020-06-10 Thread Eric Biggers
From: Eric Biggers The crypto algorithms selected by the ESP and AH kconfig options are out-of-date with the guidance of RFC 8221, which lists the legacy algorithms MD5 and DES as "MUST NOT" be implemented, and some more modern algorithms like AES-GCM and HMAC-SHA256 as "MUST" be implemented. But

Re: [PATCH RFC v2 6/9] net: phy: add support for probing MMDs >= 8 for devices-in-package

2020-06-10 Thread Calvin Johnson
Hi Russell, On Wed, May 27, 2020 at 11:34:11AM +0100, Russell King wrote: > Add support for probing MMDs above 7 for a valid devices-in-package > specifier, but only probe the vendor MMDs for this if they also report > that there the device is present in status register 2. This avoids > issues wh

Re: [Intel-wired-lan] [PATCH] e1000e: Squash an unused function warning

2020-06-10 Thread Neftin, Sasha
On 6/10/2020 04:49, Palmer Dabbelt wrote: From: Palmer Dabbelt e1000e_check_me is only used under CONFIG_PM_SLEEP but exists unconditionally, which triggers a warning. Signed-off-by: Palmer Dabbelt --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Wed, Jun 10, 2020 at 5:13 PM Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2020 at 02:37:50PM +0200, Eugenio Perez Martin wrote: > > > +/* This function returns a value > 0 if a descriptor was found, or 0 if > > > none were found. > > > + * A negative code is returned on error. */ > > > +stati

Re: [PATCHv2 ipsec] xfrm: fix a warning in xfrm_policy_insert_list

2020-06-10 Thread Xin Long
On Tue, Jun 9, 2020 at 10:18 PM Tobias Brunner wrote: > > Hi Xin, > > >> I guess we could workaround this issue in strongSwan by installing > >> policies that share the same mark and selector with the same priority, > >> so only one instance is ever installed in the kernel. But the inability > >>

Re: [PATCH 2/2] pidfd: Replace open-coded partial __scm_install_fd()

2020-06-10 Thread Sargun Dhillon
On Tue, Jun 09, 2020 at 09:52:14PM -0700, Kees Cook wrote: > The sock counting (sock_update_netprioidx() and sock_update_classid()) > was missing from this implementation of fd installation, compared to > SCM_RIGHTS. Use the new scm helper to get the work done, after adjusting > it to return the in

Re: [PATCH RFC v2 6/9] net: phy: add support for probing MMDs >= 8 for devices-in-package

2020-06-10 Thread Russell King - ARM Linux admin
On Wed, Jun 10, 2020 at 09:46:33PM +0530, Calvin Johnson wrote: > Hi Russell, > > On Wed, May 27, 2020 at 11:34:11AM +0100, Russell King wrote: > > Add support for probing MMDs above 7 for a valid devices-in-package > > specifier, but only probe the vendor MMDs for this if they also report > > tha

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Kees Cook
On Wed, Jun 10, 2020 at 11:47:35AM +0200, Christian Brauner wrote: > On Tue, Jun 09, 2020 at 09:52:12PM -0700, Kees Cook wrote: > > Hi, > > > > This extends the recent work hch did for scm_detach_fds(), and updates > > the compat path as well, fixing bugs in the process. Additionally, > > an effec

RE: [(RFC) PATCH ] be2net: Allow a VF to use physical link state.

2020-06-10 Thread dwilder
On 2020-06-09 14:58, Jakub Kicinski wrote: On Mon, 8 Jun 2020 17:00:59 -0700 David Wilder wrote: Hyper-visors owning a PF are allowed by Emulex specification to provide a VF with separate physical and/or logical link states. However, on linux, a VF driver must chose one or the other. My scena

  1   2   >