Hi Paolo, On 10/06/2020 10:49, Paolo Abeni wrote:
If a listening MPTCP socket has unaccepted sockets at close time, the related msks are freed via mptcp_sock_destruct(), which in turn does not invoke the proto->destroy() method nor the mptcp_token_destroy() function.Due to the above, the child msk socket is not removed from the token container, leading to later UaF. Address the issue explicitly removing the token even in the above error path. Fixes: 79c0949e9a09 ("mptcp: Add key generation and token tree")
> Signed-off-by: Paolo Abeni <pab...@redhat.com> Thank you for the patch, it looks good to me! Reviewed-by: Matthieu Baerts <matthieu.bae...@tessares.net> Cheers, Matt -- Matthieu Baerts | R&D Engineer matthieu.bae...@tessares.net Tessares SA | Hybrid Access Solutions www.tessares.net 1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
