> On Tue, Jun 09, 2020 at 12:02:39AM +0200, Lorenzo Bianconi wrote:
> > Disable frames injection in mvneta_xdp_xmit routine during hw
> > re-configuration in order to avoid hardware hangs
>
> Hi Lorenzo
>
> Why does mvneta_tx() also not need the same protection?
>
> Andrew
Hi Andrew,
So fa
a, .
On Mon, Jun 8, 2020 at 8:02 PM Tobias Brunner wrote:
>
> Hi Steffen, Xin,
>
> This change could be problematic. Actually, it's not really this one
> but the original one that causes the issue:
> > Fixes: 7cb8a93968e3 ("xfrm: Allow inserting policies with matching mark and
> > different pr
This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of
auto-negotiation support, we needed to be able to configure the
MASTER-SLAVE role of the port manually or from an application in user
space.
The same UAPI can be used for 1000BASE-T or MultiGBASE-T devices to
force MASTER or S
Update to net-dev:
dc0f3ed1973 ("net: phy: at803x: add cable diagnostics support for ATH9331 and
ATH8032")
Signed-off-by: Oleksij Rempel
---
uapi/linux/ethtool.h | 25 ++-
uapi/linux/ethtool_netlink.h | 326 +++
uapi/linux/genetlink.h | 2 +
uapi
Some PHYs provide Signal Quality Index (SQI) if the link is in active
state. This information can help to diagnose cable and system design
related issues.
Signed-off-by: Oleksij Rempel
Reviewed-by: Florian Fainelli
Reviewed-by: Michal Kubecek
---
netlink/desc-ethtool.c | 2 ++
netlink/setting
This patch set is extending ethtool to make it more usable on automotive
PHYs like NXP TJA11XX.
They make use of new KAPI (currently in net-next, will go probably to the
kernel 5.8-rc1):
- PHY master-slave role configuration and status informaton. Mostly needed
for 100Base-T1 PHYs due the lack o
On 8 Jun 2020, at 18:58, Yonghong Song wrote:
On 6/8/20 7:11 AM, Eelco Chaudron wrote:
I'm trying for a while to do a fentry/fexit trace an EXT program
attached to an XDP program. To make it easier to explain I've
created a test case (see patch below) to show the issue.
Without the changes
On Fri, Jun 05, 2020 at 10:46 AM CEST, dihu wrote:
> When user application calls read() with MSG_PEEK flag to read data
> of bpf sockmap socket, kernel panic happens at
> __tcp_bpf_recvmsg+0x12c/0x350. sk_msg is not removed from ingress_msg
> queue after read out under MSG_PEEK flag is set. Because
The primary objective of this patch series is to change the behaviour
of pci_alloc_irq_vectors_affinity() such that it forwards the MSI-X enable
error code when appropriate. In the process, though, it was pointed out
that there are multiple places in the kernel which check/ask for message
signalled
Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz
Reviewed-by: Andy Shevchenko
---
drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz
Reviewed-by: Andy Shevchenko
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +--
drivers/net/ethernet
Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz
Reviewed-by: Andy Shevchenko
---
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 4 +---
1 file changed, 1 insert
Currently rx_count_frames in stmmac_rx_refill always 0, which leads to
use_rx_wd false, and IOC bit of rx_desc3 true forever. Fix it.
Fixes: 6fa9d691b91ac ("net: stmmac: Prevent divide-by-zero")
Signed-off-by: Biao Huang
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +--
1 file chang
On Mon, 8 Jun 2020 18:34:10 -0700
Alexei Starovoitov wrote:
> On Mon, Jun 08, 2020 at 06:51:12PM +0200, Jesper Dangaard Brouer wrote:
> > Make it easier to handle UAPI/kABI extensions by avoid BPF using/returning
> > file descriptor value zero. Use this in recent devmap extension to keep
> > olde
On 07-Jun-20 21:17, Florian Fainelli wrote:
>
>
> On 6/7/2020 7:59 AM, Amit Cohen wrote:
>> Currently, drivers can only tell whether the link is up/down using
>> LINKSTATE_GET, but no additional information is given.
>>
>> Add attributes to LINKSTATE_GET command in order to allow drivers
>> to ex
Add dev_dbg_level macro wrapper over dynamic debug one for
dev_dbg variants.
Signed-off-by: Stanimir Varbanov
---
include/linux/dev_printk.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/linux/dev_printk.h b/include/linux/dev_printk.h
index 7b50551833e1..d639dc60d84d 10064
This will be useful when debugging specific issues related to
firmware HFI interface.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/Makefile| 2 +-
drivers/media/platform/qcom/venus/core.c | 5
drivers/media/platform/qcom/venus/core.h | 3 +++
drive
Here we introduce few debug macros with levels (low, medium and
high) and debug macro for firmware. Enabling the particular level
will be done by dynamic debug with levels.
For example to enable debug messages with low level:
echo 'module venus_dec level 0x01 +p' > debugfs/dynamic_debug/control
I
The SSR (SubSystem Restart) is used to simulate an error on FW
side of Venus. We support following type of triggers - fatal error,
div by zero and watchdog IRQ.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/dbgfs.c | 31 +++
1 file changed, 31 inserti
Introduce new pr_debug_level macro over dynamic_debug level one
to allow dynamic debugging to show only important messages.
Signed-off-by: Stanimir Varbanov
---
include/linux/printk.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/printk.h b/include/linux/printk.h
index
This will allow dynamic debug users and driver writers to group
debug messages by level bitmask. The level bitmask should be a
hex number.
Done this functionality by extending dynamic debug metadata with
new level member and propagate it over all the users. Also
introduce new dynamic_pr_debug_le
This adds description of the level bitmask feature.
Cc: Jonathan Corbet (maintainer:DOCUMENTATION)
Signed-off-by: Stanimir Varbanov
---
Documentation/admin-guide/dynamic-debug-howto.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Documentation/admin-guide/dynamic-debug-howt
Hello,
Here is the third version of dynamic debug improvements in Venus
driver. As has been suggested on previous version by Joe [1] I've
made the relevant changes in dynamic debug core to handle leveling
as more generic way and not open-code/workaround it in the driver.
About changes:
- added
On Tue, Jun 09, 2020 at 01:45:58PM +0300, Stanimir Varbanov wrote:
> +level
> +The given level will be a bitmask ANDed with the level of the each
> ``pr_debug()``
> +callsite. This will allow to group debug messages and show only those of
> the
> +same level. The -p flag takes preced
On Tue, Jun 09, 2020 at 01:46:02PM +0300, Stanimir Varbanov wrote:
> +int venus_dbgfs_init(struct venus_core *core)
> +{
> + core->root = debugfs_create_dir("venus", NULL);
> + if (IS_ERR(core->root))
> + return IS_ERR(core->root);
You really do not care, and obviously did not
On Tue, Jun 09, 2020 at 01:46:01PM +0300, Stanimir Varbanov wrote:
> Introduce new pr_debug_level macro over dynamic_debug level one
> to allow dynamic debugging to show only important messages.
What does "important messages" mean???
On Tue, Jun 09, 2020 at 01:45:57PM +0300, Stanimir Varbanov wrote:
> Here is the third version of dynamic debug improvements in Venus
> driver. As has been suggested on previous version by Joe [1] I've
> made the relevant changes in dynamic debug core to handle leveling
> as more generic way and n
On Tue, Jun 09, 2020 at 01:46:03PM +0300, Stanimir Varbanov wrote:
> Here we introduce few debug macros with levels (low, medium and
> high) and debug macro for firmware. Enabling the particular level
> will be done by dynamic debug with levels.
>
> For example to enable debug messages with low le
On Tue, Jun 09, 2020 at 01:45:58PM +0300, Stanimir Varbanov wrote:
> This adds description of the level bitmask feature.
>
> Cc: Jonathan Corbet (maintainer:DOCUMENTATION)
>
> Signed-off-by: Stanimir Varbanov
> ---
> Documentation/admin-guide/dynamic-debug-howto.rst | 10 ++
> 1 file c
Hi Xiaoliang,
On Tue, 2 Jun 2020 at 11:50, Xiaoliang Yang wrote:
>
> Hi Vladimir,
>
> On Tus, 2 Jun 2020 at 16:04,
> > First of all, net-next has just closed yesterday and will be closed for the
> > following 2 weeks:
> > https://eur01.safelinks.protection.outlook.com/?url=http:%2F%2Fvger.kernel
Please find the patch below.
Thanks and regards,
Gaurav.
>From Gaurav Singh # This line is ignored.
From: Gaurav Singh
Reply-To:
Subject:
In-Reply-To:
Signed-off-by: Gaurav Singh
---
samples/bpf/xdp_rxq_info_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/xdp_rxq_info_user.c b/samples/bpf/xdp_rxq_info_user.c
index 4fe47502ebed..490b07b7df78 100644
--- a/samples/bpf/xdp_rxq_info_user.c
+++ b/samples/bpf/xdp
On Tue, Jun 09, 2020 at 07:38:38AM -0400, Gaurav Singh wrote:
> Please find the patch below.
>
> Thanks and regards,
> Gaurav.
>
> >From Gaurav Singh # This line is ignored.
> From: Gaurav Singh
> Reply-To:
> Subject:
> In-Reply-To:
>
>
I think something went wrong in your submission, jus
On Tue, Jun 09, 2020 at 07:38:39AM -0400, Gaurav Singh wrote:
> Signed-off-by: Gaurav Singh
> ---
> samples/bpf/xdp_rxq_info_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I know I don't take patches without any changelog text, maybe other
maintainers are more lax...
The memset call is made right after malloc call. To fix this, add the null
check right after malloc and then do memset.
Signed-off-by: Gaurav Singh
---
samples/bpf/xdp_rxq_info_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/xdp_rxq_info_user.c b/samples/b
On Mon, Jun 08, 2020 at 05:08:01PM +0100, Russell King - ARM Linux admin wrote:
> On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote:
> > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode
> > called DRSGMII.
> >
> > This patch adds a corresponding phy-mode string 'drs
On Fri, 5 Jun 2020 09:58:26 -0700
Alexei Starovoitov wrote:
> On Fri, Jun 5, 2020 at 1:23 AM Jesper Dangaard Brouer
> wrote:
> >
> > Great. If we can remove this requirement of -1 init (and let zero mean
> > feature isn't used), then I'm all for exposing expose in uapi/bpf.h.
>
> Not having
On Tue, 9 Jun 2020 08:08:03 -0400
Gaurav Singh wrote:
> The memset call is made right after malloc call. To fix this, add the null
> check right after malloc and then do memset.
>
Did you read the section about how long lines should be in desc?
> Signed-off-by: Gaurav Singh
> ---
> sample
On Tue 2020-06-09 13:45:59, Stanimir Varbanov wrote:
> This will allow dynamic debug users and driver writers to group
> debug messages by level bitmask. The level bitmask should be a
> hex number.
>
> Done this functionality by extending dynamic debug metadata with
> new level member and propaga
The word 'descriptor' is misspelled throughout the tree.
Fix it up accordingly:
decriptors -> descriptors
Signed-off-by: Kieran Bingham
---
drivers/net/wan/lmc/lmc_main.c| 2 +-
drivers/net/wireless/ath/ath10k/usb.c | 2 +-
drivers/net/wireless/ath/ath6kl/usb.c | 2 +-
drivers/net/w
I wouldn't normally go through spelling fixes, but I caught sight of
this typo twice, and then foolishly grepped the tree for it, and saw how
pervasive it was.
so here I am ... fixing a typo globally... but with an addition in
scripts/spelling.txt so it shouldn't re-appear ;-)
Cc: linux-arm-ker..
Hi Allan,
On Mon, 8 Jun 2020 at 16:56, Allan W. Nielsen
wrote:
>
> On 03.06.2020 13:04, Vladimir Oltean wrote:
> >On Tue, 2 Jun 2020 at 11:38, Allan W. Nielsen
> > wrote:
> >>
> >> Hi Xiaoliang,
> >>
> >> Happy to see that you are moving in the directions of multi chain - this
> >> seems ilke a m
On Mon, Jun 08, 2020 at 04:57:37PM +0200, Andrew Lunn wrote:
> On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote:
> > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode
> > called DRSGMII.
> >
> > This patch adds a corresponding phy-mode string 'drsgmii' and parses it
On Tue, Jun 09, 2020 at 09:41:10AM +0200, Lorenzo Bianconi wrote:
> > On Tue, Jun 09, 2020 at 12:02:39AM +0200, Lorenzo Bianconi wrote:
> > > Disable frames injection in mvneta_xdp_xmit routine during hw
> > > re-configuration in order to avoid hardware hangs
> >
> > Hi Lorenzo
> >
> > Why does m
The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode
called DRSGMII. Depending on the Port MAC Control Register0 PortType
setting this seems to be either an overclocked SGMII mode or 2500BaseX.
This patch adds the necessary Serdes Configuration setting for the
2.5Gbps modes. There
On Tue, Jun 09, 2020 at 02:55:35PM +0200, Sascha Hauer wrote:
> On Mon, Jun 08, 2020 at 04:57:37PM +0200, Andrew Lunn wrote:
> > On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote:
> > > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode
> > > called DRSGMII.
> > >
> >
Hi Andrew,
On Tue, Jun 09, 2020 at 03:12:16PM +0200, Andrew Lunn wrote:
> On Tue, Jun 09, 2020 at 02:55:35PM +0200, Sascha Hauer wrote:
> > On Mon, Jun 08, 2020 at 04:57:37PM +0200, Andrew Lunn wrote:
> > > On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote:
> > > > The Marvell MVNETA Et
On Tue, Jun 09, 2020 at 03:11:52PM +0200, Sascha Hauer wrote:
> The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode
> called DRSGMII. Depending on the Port MAC Control Register0 PortType
> setting this seems to be either an overclocked SGMII mode or 2500BaseX.
>
> This patch adds
From: Heiko Stuebner
At least VSC8530/8531/8540/8541 contain a clock output that can emit
a predefined rate of 25, 50 or 125MHz.
This may then feed back into the network interface as source clock.
So follow the example the at803x already set and introduce a
vsc8531,clk-out-frequency property to
From: Heiko Stuebner
The different probe functions share a lot of code, so move the
common parts into a helper to reduce duplication.
Signed-off-by: Heiko Stuebner
---
changes in v2:
- new patch as suggested by Andrew
drivers/net/phy/mscc/mscc_main.c | 97 +---
1 f
V2:
- Defer changing BPF-syscall to start at file-descriptor 1
- Use {} to zero initialise struct.
The recent commit fbee97feed9b ("bpf: Add support to attach bpf program to a
devmap entry"), introduced ability to attach (and run) a separate XDP
bpf_prog for each devmap entry. A bpf_prog is added
For special type maps (e.g. devmap and cpumap) the map-value data-layout is
a configuration interface. This is uapi that can only be tail extended.
Thus, new members (and thus features) can only be added to the end of this
structure, and the kernel uses the map->value_size from userspace to
determi
Sync tools uapi bpf.h header file and update selftests that use
struct bpf_devmap_val.
Signed-off-by: Jesper Dangaard Brouer
---
tools/include/uapi/linux/bpf.h | 13 +
.../selftests/bpf/prog_tests/xdp_devmap_attach.c |8
.../selftests/bpf/progs/te
READ_ONCE should be used when reading rings prior to accessing the
statistics pointer. Introduce this as well as the corresponding WRITE_ONCE
usage when allocating and freeing the rings, to ensure protected access.
Signed-off-by: Ciara Loftus
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 29
The READ_ONCE macro is used when reading rings prior to accessing the
statistics pointer. The corresponding WRITE_ONCE usage when allocating and
freeing the rings to ensure protected access was not in place. Introduce
this.
Signed-off-by: Ciara Loftus
---
drivers/net/ethernet/intel/ice/ice_lib.c
READ_ONCE should be used when reading rings prior to accessing the
statistics pointer. Introduce this as well as the corresponding WRITE_ONCE
usage when allocating and freeing the rings, to ensure protected access.
Signed-off-by: Ciara Loftus
---
drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 1
On 6/9/20 7:31 AM, Jesper Dangaard Brouer wrote:
> This patch remove the minus-1 checks, and have zero mean feature isn't used.
>
For consistency this should apply to other XDP fd uses as well -- like
IFLA_XDP_EXPECTED_FD and IFLA_XDP_FD.
On Mon, Jun 08, 2020 at 04:50:37PM -0700, Andrii Nakryiko wrote:
> On Mon, Jun 8, 2020 at 8:23 AM Jean-Philippe Brucker
> wrote:
> >
> > When trying to convert the BTF for a function pointer marked "noreturn"
> > to C code, bpftool currently generates a syntax error. This happens with
> > the exit
From: Willem de Bruijn
Allow running the test across two machines, to test nic hw offload.
Add options
-A: receiver address
-r: receive only
-t: transmit only
-T: SO_RCVTIMEO value
Signed-off-by: Willem de Bruijn
---
tools/testing/selftests/net/so_txtime.c | 60 -
1 fi
From: Willem de Bruijn
Pace transmission of segments in a UDP GSO datagram.
Batching datagram protocol stack traversals with UDP_SEGMENT saves
significant cycles for large data transfers.
But GSO packets are sent at once. Pacing traffic to internet clients
often requires sending just a few MSS
From: Willem de Bruijn
UDP segmentation offload with UDP_SEGMENT can significantly reduce the
transmission cycle cost per byte for protocols like QUIC.
Pacing offload with SO_TXTIME can improve accuracy and cycle cost of
pacing for such userspace protocols further.
But the maximum GSO size buil
From: Willem de Bruijn
Optionally segment skbs on FQ enqueue, to later send segments at
their individual delivery time.
Segmentation on enqueue is new for FQ, but already happens in TBF,
CAKE and netem.
This slow patch should probably be behind a static_branch.
Signed-off-by: Willem de Bruijn
From: Willem de Bruijn
When sending multiple segments per interval and the device supports
hardware segmentation, build one GSO segment per interval.
Signed-off-by: Willem de Bruijn
---
net/core/dev.c | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --g
From: Willem de Bruijn
Support sending more than 1B payload and passing segment size.
- add option '-s' to send more than 1B payload
- add option '-m' to configure mss
If size exceeds mss, enable UDP_SEGMENT.
Optionally also allow configuring multi release time.
- add option '-M' to set relea
From: Willem de Bruijn
Enable passing an SCM_TXTIME ('-x'), optionally configured to use
multi release (SOF_TXTIME_MULTI_RELEASE) ('-X').
With multi release, the segments that make up a single udp gso packet
can be released over time, as opposed to burst at once.
Repurpose the lower 8 bits of t
There are some memory leaks in dccp_init() and dccp_fini().
In dccp_fini() and the error handling path in dccp_init(), free lhash2
is missing. Add inet_hashinfo2_free_mod() to do it.
If inet_hashinfo2_init_mod() failed in dccp_init(),
percpu_counter_destroy() should be called to destroy dccp_orph
Hi Xin,
>> I guess we could workaround this issue in strongSwan by installing
>> policies that share the same mark and selector with the same priority,
>> so only one instance is ever installed in the kernel. But the inability
>> to address the exact policy when querying/deleting still looks like
From: Biao Huang
Date: Jun/09/2020, 10:41:33 (UTC+00:00)
> - rx_q->rx_count_frames += priv->rx_coal_frames;
> - if (rx_q->rx_count_frames > priv->rx_coal_frames)
> + if (rx_q->rx_count_frames >= priv->rx_coal_frames)
This is no right. If you want to RX IC bit
From: Russell King - ARM Linux admin
Date: Jun/05/2020, 18:10:34 (UTC+00:00)
> This is incorrect - you should not mask the link partner's advertisement
> with our advertisement like this; consider the table in 802.3 for
> resolving the pause modes, where simply doing a bitwise-and operation
> bet
> On Tue, Jun 09, 2020 at 09:41:10AM +0200, Lorenzo Bianconi wrote:
> > > On Tue, Jun 09, 2020 at 12:02:39AM +0200, Lorenzo Bianconi wrote:
> > > > Disable frames injection in mvneta_xdp_xmit routine during hw
> > > > re-configuration in order to avoid hardware hangs
> > >
> > > Hi Lorenzo
> > >
On 6/9/20 7:09 AM, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> Optionally segment skbs on FQ enqueue, to later send segments at
> their individual delivery time.
>
> Segmentation on enqueue is new for FQ, but already happens in TBF,
> CAKE and netem.
>
> This slow patch should proba
On 6/9/20 8:00 AM, Eric Dumazet wrote:
>
>
> On 6/9/20 7:09 AM, Willem de Bruijn wrote:
>> From: Willem de Bruijn
>>
>> Optionally segment skbs on FQ enqueue, to later send segments at
>> their individual delivery time.
>>
>> Segmentation on enqueue is new for FQ, but already happens in TBF,
On Tue, 9 Jun 2020 07:47:06 -0600
David Ahern wrote:
> On 6/9/20 7:31 AM, Jesper Dangaard Brouer wrote:
> > This patch remove the minus-1 checks, and have zero mean feature isn't used.
> >
>
> For consistency this should apply to other XDP fd uses as well -- like
> IFLA_XDP_EXPECTED_FD and IF
On wcn3990 we have "per_ce_irq = true". That makes the
ath10k_ce_interrupt_summary() function always return 0xfff. The
ath10k_ce_per_engine_service_any() function will see this and think
that _all_ copy engines have an interrupt. Without checking, the
ath10k_ce_per_engine_service() assumes that i
Fixes an error condition reported by checkpatch.pl which caused by
assigning a variable in an if condition in
wg_noise_handshake_consume_initiation().
Signed-off-by: Frank Werner-Krippendorf
---
drivers/net/wireguard/noise.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/d
Begin forwarded message:
Date: Mon, 08 Jun 2020 21:53:11 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 208107] New: hard lock with CONFIG_CGROUP_NET_PRIO enabled
https://bugzilla.kernel.org/show_bug.cgi?id=208107
Bug ID: 208107
On 6/9/20 4:13 AM, Matthew Wilcox wrote:
> On Tue, Jun 09, 2020 at 01:45:57PM +0300, Stanimir Varbanov wrote:
>> Here is the third version of dynamic debug improvements in Venus
>> driver. As has been suggested on previous version by Joe [1] I've
>> made the relevant changes in dynamic debug core
On Tue, 2020-06-09 at 13:45 +0300, Stanimir Varbanov wrote:
> Hello,
>
> Here is the third version of dynamic debug improvements in Venus
> driver. As has been suggested on previous version by Joe [1] I've
> made the relevant changes in dynamic debug core to handle leveling
> as more generic way
Hello,
On Sun, Jun 7, 2020 at 3:00 AM Florian Westphal wrote:
>
> Eric Dumazet wrote:
> > > Sure! TCP_DEFER_ACCEPT delays the creation of the socket until data
> > > has been sent by the client *or* the specified time has expired upon
> > > which a last SYN/ACK is sent and if the client replies
(adding Jim Cromie and comments)
On Tue, 2020-06-09 at 09:03 -0700, Randy Dunlap wrote:
> On 6/9/20 4:13 AM, Matthew Wilcox wrote:
> > On Tue, Jun 09, 2020 at 01:45:57PM +0300, Stanimir Varbanov wrote:
> > > Here is the third version of dynamic debug improvements in Venus
> > > driver. As has bee
Jakub Sitnicki wrote:
> When sockhash gets destroyed while sockets are still linked to it, we will
> walk the bucket lists and delete the links. However, we are not freeing the
> list elements after processing them, leaking the memory.
>
> The leak can be triggered by close()'ing a sockhash map wh
On Tue, 2020-06-09 at 13:16 +0200, Greg Kroah-Hartman wrote:
> What is wrong with the existing control of dynamic
> debug messages that you want to add another type of arbitrary grouping
> to it?
There is no existing grouping mechanism.
Many drivers and some subsystems used an internal one
befor
Jakub Sitnicki wrote:
> We can end up modifying the sockhash bucket list from two CPUs when a
> sockhash is being destroyed (sock_hash_free) on one CPU, while a socket
> that is in the sockhash is unlinking itself from it on another CPU
> it (sock_hash_delete_from_link).
>
> This results in access
On Sun, 07 Jun 2020 16:45:32 -0700 (PDT)
David Miller wrote:
> From: Stephen Hemminger
> Date: Sun, 7 Jun 2020 15:30:19 -0700
>
> > Open source projects have been working hard to remove the terms master and
> > slave
> > in API's and documentation. Apparently, Linux hasn't gotten the message.
From: Björn Töpel
If an XDP program, where all the bpf_redirect_map() calls are tail
calls (as defined by the previous commit), the driver does not need to
explicitly call xdp_do_redirect().
The driver checks the active XDP program, and notifies the BPF helper
indirectly via xdp_set_redirect_tai
From: Björn Töpel
The bpf_redirect_map() BPF helper is used to redirect a packet to the
endpoint referenced by a map element. Currently, there is no
restrictment how the helper is called, e.g.
ret = bpf_redirect_map(...);
...
ret = bpf_redirect_map(...);
... // e.g. modify packet
retur
I hacked a quick PoC, based on the input from my earlier post [1].
Quick recap; For certain XDP programs, would it be possible to get rid
of the xdp_do_redirect() call (and the per-cpu write/read), and
instead perform the action directly from the BPF helper? If so, that
would potentially make the
On 09/06/2020 17:58, Joe Perches wrote:
> On Tue, 2020-06-09 at 13:16 +0200, Greg Kroah-Hartman wrote:
>> What is wrong with the existing control of dynamic
>> debug messages that you want to add another type of arbitrary grouping
>> to it?
> There is no existing grouping mechanism.
>
> Many drive
On Tue, 2020-06-09 at 18:42 +0100, Edward Cree wrote:
> On 09/06/2020 17:58, Joe Perches wrote:
> > On Tue, 2020-06-09 at 13:16 +0200, Greg Kroah-Hartman wrote:
> > > What is wrong with the existing control of dynamic
> > > debug messages that you want to add another type of arbitrary grouping
> >
On Tue, Jun 9, 2020 at 2:04 AM Jakub Sitnicki wrote:
>
> On Fri, Jun 05, 2020 at 10:46 AM CEST, dihu wrote:
> > When user application calls read() with MSG_PEEK flag to read data
> > of bpf sockmap socket, kernel panic happens at
> > __tcp_bpf_recvmsg+0x12c/0x350. sk_msg is not removed from ingres
On Tue, Jun 9, 2020 at 10:51 AM John Fastabend wrote:
>
> Jakub Sitnicki wrote:
> > We can end up modifying the sockhash bucket list from two CPUs when a
> > sockhash is being destroyed (sock_hash_free) on one CPU, while a socket
> > that is in the sockhash is unlinking itself from it on another C
On 09/06/2020 18:56, Joe Perches wrote:
> These are _not_ netif_ control flags. Some are though.
> For instance:
>
> $ git grep "MODULE_PARM.*\bdebug\b" drivers/net | head -10
> [...]
>
> These are all level/class output controls.
TIL, thanks! I should have looked deeperrather than assuming
they
On Mon, Jun 8, 2020 at 8:17 AM David Ahern wrote:
>
> This is a new context that does not handle metadata at the moment, so
> mark data_meta invalid.
>
> Fixes: fbee97feed9b ("bpf: Add support to attach bpf program to a devmap
> entry")
> Signed-off-by: David Ahern
Applied. Thanks
On Mon, Jun 8, 2020 at 9:22 AM Lorenz Bauer wrote:
>
> When using BPF_PROG_ATTACH to attach a program to a cgroup in
> BPF_F_ALLOW_MULTI mode, it is not possible to replace a program
> with itself. This is because the check for duplicate programs
> doesn't take the replacement program into account
Hi Stephen
> A common example is that master/slave is unclear and would be clearer
> as primary/secondary or active/backup or controller/worker.
802.3, cause 32.1.2, 2015 version:
A 100BASE-T2 PHY can be configured either as a master PHY or as a
slave PHY. The master-slave relationship bet
From: Stephen Hemminger
Date: Tue, 9 Jun 2020 10:19:35 -0700
> Yes, words do matter and convey a lot of implied connotation and
> meaning.
What is your long term plan? Will you change all of the UAPI for
bonding for example?
Or will we have a partial solution to the problem?
Disclaimer: *definitely* not speaking for my employer.
On 09/06/2020 18:19, Stephen Hemminger wrote:
> How many times have you or Linus argued about variable naming.
> Yes, words do matter and convey a lot of implied connotation and meaning.
Connotation, unlike denotation, is widely variable. I w
On Tue, Jun 09, 2020 at 03:31:41PM +0200, Jesper Dangaard Brouer wrote:
> For special type maps (e.g. devmap and cpumap) the map-value data-layout is
> a configuration interface. This is uapi that can only be tail extended.
> Thus, new members (and thus features) can only be added to the end of thi
On Tue, Jun 09, 2020 at 11:36:33AM -0700, David Miller wrote:
> From: Stephen Hemminger
> Date: Tue, 9 Jun 2020 10:19:35 -0700
>
> > Yes, words do matter and convey a lot of implied connotation and
> > meaning.
>
> What is your long term plan? Will you change all of the UAPI for
> bonding for e
On Tue, 2020-06-09 at 11:36 -0700, David Miller wrote:
> From: Stephen Hemminger
> Date: Tue, 9 Jun 2020 10:19:35 -0700
>
> > Yes, words do matter and convey a lot of implied connotation and
> > meaning.
>
> What is your long term plan? Will you change all of the UAPI for
> bonding for example?
1 - 100 of 184 matches
Mail list logo
