Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-01 Thread David Miller
From: patrickeigens...@gmail.com Date: Mon, 1 Jun 2020 13:12:01 +0200 > From: Patrick Eigensatz > > After allocating the spare nexthop group it should be tested for kzalloc() > returning NULL, instead the already used nexthop group (which cannot be > NULL at this point) had been tested so far.

Re: [PATCH net-next 00/14] devlink: Add support for control packet traps

2020-06-01 Thread David Miller
From: Ido Schimmel Date: Fri, 29 May 2020 21:36:35 +0300 > So far device drivers were only able to register drop and exception > packet traps with devlink. These traps are used for packets that were > either dropped by the underlying device or encountered an exception > (e.g., missing neighbour e

Re: [PATCH] lan743x: Added fixed link and RGMII support

2020-06-01 Thread David Miller
From: Roelof Berg Date: Fri, 29 May 2020 21:30:02 +0200 > Microchip lan7431 is frequently connected to a phy. However, it > can also be directly connected to a MII remote peer without > any phy in between. For supporting such a phyless hardware setup > in Linux we utilized phylib, which supports

Re: [PATCH] flow_dissector: work around stack frame size warning

2020-06-01 Thread David Miller
From: Arnd Bergmann Date: Fri, 29 May 2020 22:13:58 +0200 > The fl_flow_key structure is around 500 bytes, so having two of them > on the stack in one function now exceeds the warning limit after an > otherwise correct change: > > net/sched/cls_flower.c:298:12: error: stack frame size of 1056 by

Re: [PATCH] net: vmxnet3: fix possible buffer overflow caused by bad DMA value in vmxnet3_get_rss()

2020-06-01 Thread David Miller
From: Jia-Ju Bai Date: Sat, 30 May 2020 10:41:50 +0800 > The value adapter->rss_conf is stored in DMA memory, and it is assigned > to rssConf, so rssConf->indTableSize can be modified at anytime by > malicious hardware. Because rssConf->indTableSize is assigned to n, > buffer overflow may occur w

[PATCH 4.19 12/95] sctp: Dont add the shutdown timer if its already been added

2020-06-01 Thread Greg Kroah-Hartman
From: Neil Horman [ Upstream commit 20a785aa52c82246055a089e55df9dac47d67da1 ] This BUG halt was reported a while back, but the patch somehow got missed: PID: 2879 TASK: c16adaa0 CPU: 1 COMMAND: "sctpn" #0 [f418dd28] crash_kexec at c04a7d8c #1 [f418dd7c] oops_end at c0863e02 #2 [f418dd9

Re: pull request: bluetooth-next 2020-06-01

2020-06-01 Thread David Miller
From: Johan Hedberg Date: Mon, 1 Jun 2020 10:08:03 +0300 > Here's one last bluetooth-next pull request for 5.8, which I hope can > still be accepted. > > - Enabled Wide-Band Speech (WBS) support for Qualcomm wcn3991 > - Multiple fixes/imprvovements to Qualcomm-based devices > - Fix GAP/SEC/SE

Re: [PATCH v2] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-06-01 Thread David Miller
From: Richard Sailer Date: Sat, 30 May 2020 18:31:59 +0200 > @@ -375,6 +375,14 @@ int dccp_ioctl(struct sock *sk, int cmd, unsigned long > arg) > goto out; > > switch (cmd) { > + case SIOCOUTQ: { > + /* Using sk_wmem_alloc here because sk_wmem_queued is not

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread David Miller
From: "Jason A. Donenfeld" Date: Mon, 1 Jun 2020 00:29:45 -0600 > This is a series of 1, and the sole patch inside of it has justification > regarding that patch itself. But I thought I'd mention in the cover > letter that this is being sent right at the tail end of the net-next > cycle, before

Re: [PATCH net-next v2 0/3] bridge: mrp: Add support for MRA role

2020-06-01 Thread David Miller
From: Horatiu Vultur Date: Sat, 30 May 2020 18:09:45 + > This patch series extends the MRP with the MRA role. > A node that has the MRA role can behave as a MRM or as a MRC. In case there > are > multiple nodes in the topology that has the MRA role then only one node can > behave as MRM and

Re: [PATCH net-next] net/sched: fix a couple of splats in the error path of tfc_gate_init()

2020-06-01 Thread David Miller
From: Cong Wang Date: Mon, 1 Jun 2020 11:48:54 -0700 > You applied a wrong version. There is a V2 of this patch, and I had some > review for it. I just noticed that, sorry. Please send follow-ups, as needed.

Re: [PATCH iproute2-next 0/2] Implement filter terse dump mode support

2020-06-01 Thread David Ahern
On 5/21/20 12:01 PM, David Ahern wrote: > On 5/14/20 7:23 AM, Vlad Buslov wrote: >> Implement support for terse dump mode which provides only essential >> classifier/action info (handle, stats, cookie, etc.). Use new >> TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from >> kernel

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-01 Thread Song Liu
On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > Currenty lsm uses bpf_tracing_func_proto helpers which do > not include stack trace or perf event output. It's useful > to have those for bpftrace lsm support [1]. > > Using tracing_prog_func_proto helpers for lsm programs. How about using raw_

Re: [PATCH net-next] cls_flower: remove mpls_opts_policy

2020-06-01 Thread David Miller
From: Guillaume Nault Date: Sat, 30 May 2020 20:49:56 +0200 > Compiling with W=1 gives the following warning: > net/sched/cls_flower.c:731:1: warning: ‘mpls_opts_policy’ defined but not > used [-Wunused-const-variable=] > > The TCA_FLOWER_KEY_MPLS_OPTS contains a list of > TCA_FLOWER_KEY_MPLS_O

Re: [PATCH net v2] tun: correct header offsets in napi frags mode

2020-06-01 Thread David Miller
From: Willem de Bruijn Date: Sat, 30 May 2020 15:41:31 -0400 > From: Willem de Bruijn > > Tun in IFF_NAPI_FRAGS mode calls napi_gro_frags. Unlike netif_rx and > netif_gro_receive, this expects skb->data to point to the mac layer. > > But skb_probe_transport_header, __skb_get_hash_symmetric, an

Re: [PATCH net-next] net: phy: broadcom: don't export RDB/legacy access methods

2020-06-01 Thread David Miller
From: Michael Walle Date: Sat, 30 May 2020 22:34:04 +0200 > Don't export __bcm_phy_enable_rdb_access() and > __bcm_phy_enable_legacy_access() functions. They aren't used outside this > module and it was forgotten to provide a prototype for these functions. > Just make them static for now. > > Fi

Re: [PATCH net-next v4 0/7] dpaa2-eth: add PFC support

2020-06-01 Thread David Miller
From: Ioana Ciornei Date: Sun, 31 May 2020 00:08:07 +0300 > This patch set adds support for Priority Flow Control in DPAA2 Ethernet > devices. > > The first patch make the necessary changes so that multiple > traffic classes are configured. The dequeue priority > of the maximum 8 traffic classes

Re: [PATCH net-next] net/sched: fix a couple of splats in the error path of tfc_gate_init()

2020-06-01 Thread Cong Wang
On Mon, Jun 1, 2020 at 11:49 AM Davide Caratti wrote: > hello Dave, > > for this patch I will probably need to send a follow-up, because > the TC action overwrite case probably has still some issues [1] [2]. > I can do that targeting the 'net' tree, unless Po or Cong have some > objections. > > Ok

Re: [PATCH net-next v7 09/10] net: phy: smsc: use phy_read_poll_timeout() to simplify the code

2020-06-01 Thread Kevin Groeneveld
Resent as plain text this time. Sorry to those that got this twice. On Mon, Mar 23, 2020 at 11:10 AM Dejin Zheng wrote: > > use phy_read_poll_timeout() to replace the poll codes for > simplify lan87xx_read_status() function. > > Suggested-by: Andrew Lunn > Reviewed-by: Florian Fainelli > Signe

Re: [PATCH 7/9] bpf: Compile the BTF id whitelist data in vmlinux

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 8:10 AM Jiri Olsa wrote: > > On Fri, May 29, 2020 at 01:48:58PM -0700, Andrii Nakryiko wrote: > > On Thu, May 28, 2020 at 10:24 AM Jiri Olsa wrote: > > > > > > On Thu, May 14, 2020 at 03:46:26PM -0700, Andrii Nakryiko wrote: > > > > > > SNIP > > > > > > > > I was thinking

Re: [PATCH net-next] switch cmsghdr_from_user_compat_to_kern() to copy_from_user()

2020-06-01 Thread David Miller
From: Al Viro Date: Sun, 31 May 2020 02:06:55 +0100 > no point getting compat_cmsghdr field-by-field > > Signed-off-by: Al Viro Applied, thanks Al.

Re: [PATCH net-next] vxlan: fix dereference of nexthop group in nexthop update path

2020-06-01 Thread David Miller
From: Roopa Prabhu Date: Sat, 30 May 2020 22:17:20 -0700 > From: Roopa Prabhu > > fix dereference of nexthop group in fdb nexthop group > update validation path. > > Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries") > Reported-by: Ido Schimmel > Suggested-by: Ido Schimmel > Sig

Re: [net-next 00/14][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-31

2020-06-01 Thread David Miller
From: Jeff Kirsher Date: Sun, 31 May 2020 05:36:05 -0700 > This series contains updates to the ice driver only. Pulled, thanks Jeff.

Re: [PATCH v2 net-next] net: dsa: sja1105: suppress -Wmissing-prototypes in sja1105_vl.c

2020-06-01 Thread David Miller
From: Vladimir Oltean Date: Sun, 31 May 2020 21:25:51 +0300 > From: Vladimir Oltean > > Newer C compilers are complaining about the fact that there are no > function prototypes in sja1105_vl.c for the non-static functions. > Give them what they want. > > Signed-off-by: Vladimir Oltean > Revie

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-01 Thread kbuild test robot
nfig: m68k-randconfig-r011-20200601 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .confi

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Jason A. Donenfeld
Hi Dave, On Mon, Jun 1, 2020 at 12:00 PM David Miller wrote: > This is going to make nearly every -stable backport not apply cleanly, > which is a severe burdon for everyone having to maintain stable trees. This possibility had occurred to me too, which is why I mentioned the project being suffi

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Joe Perches
On Mon, 2020-06-01 at 13:33 -0600, Jason A. Donenfeld wrote: > Hi Dave, > > On Mon, Jun 1, 2020 at 12:00 PM David Miller wrote: > > This is going to make nearly every -stable backport not apply cleanly, > > which is a severe burdon for everyone having to maintain stable trees. > > This possibili

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-06-01 Thread Cong Wang
On Mon, Jun 1, 2020 at 6:40 AM Jiri Pirko wrote: > The first command just says "early drop position should be processed by > block 10" > > The second command just adds a filter to the block 10. This is exactly why it looks odd to me, because it _reads_ like 'tc qdisc' creates the block to hold tc

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-06-01 Thread Cong Wang
On Sat, May 30, 2020 at 1:55 AM Petr Machata wrote: > > > Cong Wang writes: > > > On Thu, May 28, 2020 at 2:48 AM Petr Machata wrote: > >> So you propose to have further division within the block? To have sort > >> of namespaces within blocks or chains, where depending on the context, > >> only

Re: [PATCH v3] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Vladimir Oltean
Hi Sergei, On Mon, 1 Jun 2020 at 21:48, Sergei Shtylyov wrote: > > On 06/01/2020 12:58 PM, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > Sometimes debugging a device is easiest using devmem on its register > > map, and that can be seen with /proc/iomem. But some device drivers have

Re: [PATCH v3] devres: keep both device name and resource name in pretty name

2020-06-01 Thread Sergei Shtylyov
On 06/01/2020 11:03 PM, Vladimir Oltean wrote: > Hi Sergei, > > On Mon, 1 Jun 2020 at 21:48, Sergei Shtylyov > wrote: >> >> On 06/01/2020 12:58 PM, Vladimir Oltean wrote: >> >>> From: Vladimir Oltean >>> >>> Sometimes debugging a device is easiest using devmem on its register >>> map, and that c

Re: [bpf-next PATCH v3] bpf: Add rx_queue_mapping to bpf_sock

2020-06-01 Thread Alexei Starovoitov
On Tue, May 26, 2020 at 5:34 PM Amritha Nambiar wrote: > > Add "rx_queue_mapping" to bpf_sock. This gives read access for the > existing field (sk_rx_queue_mapping) of struct sock from bpf_sock. > Semantics for the bpf_sock rx_queue_mapping access are similar to > sk_rx_queue_get(), i.e the value

[PATCH bpf-next] libbpf: add _GNU_SOURCE for reallocarray to ringbuf.c

2020-06-01 Thread Andrii Nakryiko
On systems with recent enough glibc, reallocarray compat won't kick in, so reallocarray() itself has to come from stdlib.h include. But _GNU_SOURCE is necessary to enable it. So add it. Fixes: 4cff2ba58bf1 ("libbpf: Add BPF ring buffer support") Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/r

Re: [PATCH bpf-next v2 1/3] sock: move sock_valbool_flag to header

2020-06-01 Thread Alexei Starovoitov
On Wed, May 27, 2020 at 1:00 PM Dmitry Yakunin wrote: > > This is preparation for usage in bpf_setsockopt. > > Signed-off-by: Dmitry Yakunin > Acked-by: Martin KaFai Lau Applied the set. Thanks

Re: [PATCH bpf-next] libbpf: add _GNU_SOURCE for reallocarray to ringbuf.c

2020-06-01 Thread Song Liu
On Mon, Jun 1, 2020 at 1:26 PM Andrii Nakryiko wrote: > > On systems with recent enough glibc, reallocarray compat won't kick in, so > reallocarray() itself has to come from stdlib.h include. But _GNU_SOURCE is > necessary to enable it. So add it. > > Fixes: 4cff2ba58bf1 ("libbpf: Add BPF ring buf

Re: [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

2020-06-01 Thread Agarwal, Anchal
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 5/19/20 7:26 PM, Anchal Agarwal wrote: > Many legacy device drivers do not implement power management (PM)

Re: [bpf-next PATCH 1/3] bpf: refactor sockmap redirect code so its easy to reuse

2020-06-01 Thread Song Liu
On Fri, May 29, 2020 at 4:07 PM John Fastabend wrote: > > We will need this block of code called from tls context shortly > lets refactor the redirect logic so its easy to use. This also > cleans up the switch stmt so we have fewer fallthrough cases. > > No logic changes are intended. > > Fixes: d

[PATCH net-next] af-packet: new flag to indicate all csums are good

2020-06-01 Thread Victor Julien
Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate that the driver has completely validated the checksums in the packet. The flag differs from TP_STATUS_CSUM_VALID in that it will only be set if all the layers are valid, while TP_STATUS_CSUM_VALID is set as well if only the IP layer is

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread David Miller
Jason, I'm not discussing this. I have to backport these fixes and it makes more work for me, as well as others. I'm also quite sad that the most important thing you could find to work on was figuring out how many columns should be in a line.

Re: [PATCH stable-4.19.y] net: phy: reschedule state machine if AN has not completed in PHY_AN state

2020-06-01 Thread Vladimir Oltean
On Mon, 1 Jun 2020 at 03:28, Russell King - ARM Linux admin wrote: > > On Mon, Jun 01, 2020 at 12:00:16AM +0300, Vladimir Oltean wrote: > > This is all relevant because our options for the stable trees boil > > down to 2 choices: > > - Revert f62265b53ef34a372b657c99e23d32e95b464316, fix an API m

Re: [PATCH 01/12] xen/manage: keep track of the on-going suspend mode

2020-06-01 Thread Agarwal, Anchal
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 5/19/20 7:24 PM, Anchal Agarwal wrote: > > +enum suspend_modes { > + NO_SUSPEND = 0, > +

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread Alexei Starovoitov
On Fri, May 29, 2020 at 3:07 PM David Ahern wrote: > > Implementation of Daniel's proposal for allowing DEVMAP entries to be > a device index, program fd pair. > > Programs are run after XDP_REDIRECT and have access to both Rx device > and Tx device. > > v4 > - moved struct bpf_devmap_val from uap

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Michal Kubecek
On Mon, Jun 01, 2020 at 01:33:46PM -0600, Jason A. Donenfeld wrote: > Hi Dave, > > On Mon, Jun 1, 2020 at 12:00 PM David Miller wrote: > > This is going to make nearly every -stable backport not apply cleanly, > > which is a severe burdon for everyone having to maintain stable trees. > > This po

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Jason A. Donenfeld
Hi Dave, On Mon, Jun 1, 2020 at 2:56 PM David Miller wrote: > Jason, I'm not discussing this. > > I have to backport these fixes and it makes more work for me, as well > as others. As I said earlier, no problem, and I understand. > I'm also quite sad that the most important thing you could find

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Jason A. Donenfeld
On Mon, Jun 1, 2020 at 3:13 PM Michal Kubecek wrote: > It's not only about stable. The code has been backported e.g. into SLE15 > SP2 and openSUSE Leap 15.2 kernels which which are deep in RC phase so > that we would face the choice between backporting this huge patch in > a maintenance update and

Re: [PATCH v3 net-next 13/13] net: dsa: felix: introduce support for Seville VSC9953 switch

2020-06-01 Thread Jakub Kicinski
On Sun, 31 May 2020 15:26:40 +0300 Vladimir Oltean wrote: > From: Maxim Kochetkov > > This is another switch from Vitesse / Microsemi / Microchip, that has > 10 port (8 external, 2 internal) and is integrated into the Freescale / > NXP T1040 PowerPC SoC. It is very similar to Felix from NXP LS102

Re: [PATCH v3 net-next 12/13] net: dsa: felix: move probing to felix_vsc9959.c

2020-06-01 Thread Jakub Kicinski
On Sun, 31 May 2020 15:26:39 +0300 Vladimir Oltean wrote: > From: Vladimir Oltean > > Felix is not actually meant to be a DSA driver only for the switch > inside NXP LS1028A, but an umbrella for all Vitesse / Microsemi / > Microchip switches that are register-compatible with Ocelot and that are >

Re: [PATCH stable-4.19.y] net: phy: reschedule state machine if AN has not completed in PHY_AN state

2020-06-01 Thread Russell King - ARM Linux admin
On Mon, Jun 01, 2020 at 11:57:30PM +0300, Vladimir Oltean wrote: > On Mon, 1 Jun 2020 at 03:28, Russell King - ARM Linux admin > wrote: > > And yes, I do have some copper SFP modules that have an (inaccessible) > > AR803x PHY on them - Microtik S-RJ01 to be exact. I forget exactly > > which varia

Re: [bpf-next PATCH 2/3] bpf: fix running sk_skb program types with ktls

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 8:20 AM John Fastabend wrote: > > > @@ -1793,11 +1795,12 @@ int tls_sw_recvmsg(struct sock *sk, > > > > > > if (to_decrypt <= len && !is_kvec && !is_peek && > > > ctx->control == TLS_RECORD_TYPE_DATA && > > > - prot->version != TLS_1

Re: [PATCH bpf-next RFC 2/3] bpf: devmap dynamic map-value storage area based on BTF

2020-06-01 Thread Alexei Starovoitov
On Fri, May 29, 2020 at 05:59:45PM +0200, Jesper Dangaard Brouer wrote: > + > +/* Expected BTF layout that match struct bpf_devmap_val */ > +static const struct expect layout[] = { > + {BTF_KIND_INT, true,0, 4, "ifindex"}, > + {BTF_KIND_UNION,false, 32, 4

Re: [PATCH stable-4.19.y] net: phy: reschedule state machine if AN has not completed in PHY_AN state

2020-06-01 Thread Vladimir Oltean
On Tue, 2 Jun 2020 at 00:21, Russell King - ARM Linux admin wrote: > > On Mon, Jun 01, 2020 at 11:57:30PM +0300, Vladimir Oltean wrote: > > On Mon, 1 Jun 2020 at 03:28, Russell King - ARM Linux admin > > wrote: > > > And yes, I do have some copper SFP modules that have an (inaccessible) > > > AR8

[PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload.

2020-06-01 Thread Huy Nguyen
During IPsec performance testing, we see bad ICMP checksum. The error packet has duplicated ESP trailer due to double validate_xmit_xfrm calls. The first call is from ip_output, but the packet cannot be sent because netif_xmit_frozen_or_stopped is true and the packet gets dev_requeue_skb. The sec

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread David Miller
From: Michal Kubecek Date: Mon, 1 Jun 2020 23:13:07 +0200 > On Mon, Jun 01, 2020 at 01:33:46PM -0600, Jason A. Donenfeld wrote: >> This possibility had occurred to me too, which is why I mentioned the >> project being sufficiently young that this can work out. It's not >> actually in any LTS yet,

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Jakub Kicinski
On Mon, 1 Jun 2020 08:39:18 +0200 Jiri Pirko wrote: > > If the permanent (NVRAM) parameter is true, all loaded new drivers > > will indicate support for this feature and set the runtime value to > > true by default. The runtime value would not be true if any loaded > > driver is too old or has set

Re: [PATCH net-next] af-packet: new flag to indicate all csums are good

2020-06-01 Thread David Miller
From: Victor Julien Date: Mon, 1 Jun 2020 22:49:37 +0200 > @@ -472,6 +472,12 @@ TP_STATUS_CSUM_VALID This flag indicates that at > least the transport > validated on the kernel side. If the flag is not set > then we are free to check the checksum

net-next is CLOSED

2020-06-01 Thread David Miller
The net-next tree is CLOSED, submit bug fixes only at this time. Alexei has told me that the bpf-next pull request is pending and I will take that in when I get it from him. Thanks.

Re: [PATCH bpf-next v2 1/3] sock: move sock_valbool_flag to header

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 1:32 PM Alexei Starovoitov wrote: > > On Wed, May 27, 2020 at 1:00 PM Dmitry Yakunin wrote: > > > > This is preparation for usage in bpf_setsockopt. > > > > Signed-off-by: Dmitry Yakunin > > Acked-by: Martin KaFai Lau > > Applied the set. Thanks I had to drop it due to n

Re: [PATCH v2 net-next 0/3] Extending bpf_setsockopt with SO_BINDTODEVICE sockopt

2020-06-01 Thread Alexei Starovoitov
On Sat, May 30, 2020 at 2:11 PM Ferenc Fejes wrote: > > This option makes it possible to programatically bind sockets > to netdevices. With the help of this option sockets > of VRF unaware applications could be distributed between > multiple VRFs with an eBPF program. This lets the applications >

Re: [PATCH v3 bpf-next 2/2] xdp: rename convert_to_xdp_frame in xdp_convert_buff_to_frame

2020-06-01 Thread Alexei Starovoitov
On Thu, May 28, 2020 at 2:12 PM Jesper Dangaard Brouer wrote: > > On Thu, 28 May 2020 22:47:29 +0200 > Lorenzo Bianconi wrote: > > > In order to use standard 'xdp' prefix, rename convert_to_xdp_frame > > utility routine in xdp_convert_buff_to_frame and replace all the > > occurrences > > > > Sign

Re: [net-next 10/11] net/mlx5e: kTLS, Add kTLS RX resync support

2020-06-01 Thread Jakub Kicinski
On Sun, 31 May 2020 15:06:28 +0300 Boris Pismenny wrote: > On 30/05/2020 0:50, Jakub Kicinski wrote: > > On Fri, 29 May 2020 20:44:29 + Saeed Mahameed wrote: > >>> I thought you said that resync requests are guaranteed to never fail? > >> > >> I didn't say that :), maybe tariq did say this

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > not include stack trace or perf event output. It's useful > > to have those for bpftrace lsm support [1]. > > > > Using tracin

Re: [PATCH bpf-next] libbpf: add _GNU_SOURCE for reallocarray to ringbuf.c

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 1:36 PM Song Liu wrote: > > On Mon, Jun 1, 2020 at 1:26 PM Andrii Nakryiko wrote: > > > > On systems with recent enough glibc, reallocarray compat won't kick in, so > > reallocarray() itself has to come from stdlib.h include. But _GNU_SOURCE is > > necessary to enable it. S

Re: [PATCH bpf-next v2 00/12] Link-based program attachment to network namespaces

2020-06-01 Thread Alexei Starovoitov
On Sun, May 31, 2020 at 1:28 AM Jakub Sitnicki wrote: > > One of the pieces of feedback from recent review of BPF hooks for socket > lookup [0] was that new program types should use bpf_link-based > attachment. > > This series introduces new bpf_link type for attaching to network > namespace. All

Re: [PATCH net-next 0/1] wireguard column reformatting for end of cycle

2020-06-01 Thread Jason A. Donenfeld
On Mon, Jun 1, 2020 at 3:40 PM David Miller wrote: > > From: Michal Kubecek > Date: Mon, 1 Jun 2020 23:13:07 +0200 > > > On Mon, Jun 01, 2020 at 01:33:46PM -0600, Jason A. Donenfeld wrote: > >> This possibility had occurred to me too, which is why I mentioned the > >> project being sufficiently y

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread David Ahern
On 6/1/20 3:12 PM, Alexei Starovoitov wrote: > In patch 5 I had to fix: > /data/users/ast/net-next/tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c: > In function ‘test_neg_xdp_devmap_helpers’: > /data/users/ast/net-next/tools/testing/selftests/bpf/test_progs.h:106:3: > warning: ‘duration

Re: [PATCH bpf-next v2 04/12] bpf: Add link-based BPF program attachment to network namespace

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:29 AM Jakub Sitnicki wrote: > > Extend bpf() syscall subcommands that operate on bpf_link, that is > LINK_CREATE, LINK_UPDATE, OBJ_GET_INFO, to accept attach types tied to > network namespaces (only flow dissector at the moment). > > Link-based and prog-based attachment c

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 01, 2020 at 04:28:02PM -0600, David Ahern wrote: > On 6/1/20 3:12 PM, Alexei Starovoitov wrote: > > In patch 5 I had to fix: > > /data/users/ast/net-next/tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c: > > In function ‘test_neg_xdp_devmap_helpers’: > > /data/users/ast/net-ne

Re: [PATCH bpf-next v2 05/12] bpf, cgroup: Return ENOLINK for auto-detached links on update

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:29 AM Jakub Sitnicki wrote: > > Failure to update a bpf_link because it has been auto-detached by a dying > cgroup currently results in EINVAL error, even though the arguments passed > to bpf() syscall are not wrong. > > bpf_links attaching to netns in this case will retu

Re: [PATCH bpf-next v2 06/12] libbpf: Add support for bpf_link-based netns attachment

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:29 AM Jakub Sitnicki wrote: > > Add bpf_program__attach_nets(), which uses LINK_CREATE subcommand to create typo: nets -> netns > an FD-based kernel bpf_link, for attach types tied to network namespace, > that is BPF_FLOW_DISSECTOR for the moment. > > Signed-off-by: Jak

Re: [PATCH net-next] tipc: Fix NULL pointer dereference in __tipc_sendstream()

2020-06-01 Thread David Miller
From: YueHaibing Date: Thu, 28 May 2020 22:34:07 +0800 > tipc_sendstream() may send zero length packet, then tipc_msg_append() > do not alloc skb, skb_peek_tail() will get NULL, msg_set_ack_required > will trigger NULL pointer dereference. > > Reported-by: syzbot+8eac6d030e7807c21...@syzkaller.a

Re: [PATCH bpf-next v2 07/12] bpftool: Extract helpers for showing link attach type

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:32 AM Jakub Sitnicki wrote: > > Code for printing link attach_type is duplicated in a couple of places, and > likely will be duplicated for future link types as well. Create helpers to > prevent duplication. > > Suggested-by: Andrii Nakryiko > Signed-off-by: Jakub Sitnic

Re: [PATCH bpf-next 4/6] bpf: cpumap: add the possibility to attach an eBPF program to cpumap

2020-06-01 Thread Alexei Starovoitov
On Sun, May 31, 2020 at 11:46:49PM +0200, Lorenzo Bianconi wrote: > + > + prog = READ_ONCE(rcpu->prog); > for (i = 0; i < n; i++) { > - void *f = frames[i]; > + void *f = xdp_frames[i]; > struct page *page = vir

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-06-01 Thread Petr Machata
Cong Wang writes: > On Mon, Jun 1, 2020 at 6:40 AM Jiri Pirko wrote: >> The first command just says "early drop position should be processed by >> block 10" >> >> The second command just adds a filter to the block 10. > This is exactly why it looks odd to me, because it _reads_ like > 'tc qdi

Re: [PATCH bpf-next v2 08/12] bpftool: Support link show for netns-attached links

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:31 AM Jakub Sitnicki wrote: > > Make `bpf link show` aware of new link type, that is links attached to > netns. When listing netns-attached links, display netns inode number as its > identifier and link attach type. > > Sample session: > > # readlink /proc/self/ns/net >

Re: [PATCH bpf-next v2 11/12] selftests/bpf: Convert test_flow_dissector to use BPF skeleton

2020-06-01 Thread Andrii Nakryiko
On Sun, May 31, 2020 at 1:29 AM Jakub Sitnicki wrote: > > Switch flow dissector test setup from custom BPF object loader to BPF > skeleton to save boilerplate and prepare for testing higher-level API for > attaching flow dissector with bpf_link. > > To avoid depending on program order in the BPF o

Re: [PATCH 01/12] xen/manage: keep track of the on-going suspend mode

2020-06-01 Thread Boris Ostrovsky
On 6/1/20 5:00 PM, Agarwal, Anchal wrote: >  > > I don't see these last two used anywhere. Are you, in fact, > distinguishing between PM suspend and hibernation? > > Yes, I am. Unless there is a better way to distinguish at runtime which I > haven't figured out yet. > The initial desig

Re: [PATCH net] ipv6: fix IPV6_ADDRFORM operation logic

2020-06-01 Thread David Miller
From: Hangbin Liu Date: Mon, 1 Jun 2020 11:55:03 +0800 > Socket option IPV6_ADDRFORM supports UDP/UDPLITE and TCP at present. > Previously the checking logic looks like: > if (sk->sk_protocol == IPPROTO_UDP || sk->sk_protocol == IPPROTO_UDPLITE) > do_some_check; > else if (sk->sk_protocol

Re: [PATCH net v4] cxgb4/chcr: Enable ktls settings at run time

2020-06-01 Thread David Miller
From: Rohit Maheshwari Date: Mon, 1 Jun 2020 13:08:29 +0530 > Current design enables ktls setting from start, which is not > efficient. Now the feature will be enabled when user demands > TLS offload on any interface. > > v1->v2: > - taking ULD module refcount till any single connection exists.

Re: [PATCH net] crypto/chcr: IPV6 code needs to be in CONFIG_IPV6

2020-06-01 Thread David Miller
From: Rohit Maheshwari Date: Mon, 1 Jun 2020 19:33:32 +0530 > Error messages seen while building kernel with CONFIG_IPV6 > disabled. > > Signed-off-by: Rohit Maheshwari Applied.

pull-request: bpf-next 2020-06-01

2020-06-01 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. We've added 55 non-merge commits during the last 1 day(s) which contain a total of 91 files changed, 4986 insertions(+), 463 deletions(-). The main changes are: 1) Add rx_queue_mapping to bpf_sock from Amritha.

Re: [PATCH net-next V2 0/2] Fixing compilation warnings and errors

2020-06-01 Thread David Miller
From: Ayush Sawal Date: Mon, 1 Jun 2020 23:11:57 +0530 > Patch 1: Fixes the warnings seen when compiling using sparse tool. > > Patch 2: Fixes a cocci check error introduced after commit > 567be3a5d227 ("crypto: chelsio - > Use multiple txq/rxq per tfm to process the requests"). > > V1->V2 >

Re: [PATCH] pch_gbe: free skb on octal, nibble, and crc errors

2020-06-01 Thread David Miller
From: David Franck Date: Mon, 1 Jun 2020 11:49:07 -0400 > This patch prevents memory leak when octal, nibble, and crc errors are > encountered. > Typical user is not impacted with the issue because frequent octal, nibble, > or crc errors are unlikely. > > Signed-off-by: David G Franck Applied.

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-01 Thread Song Liu
On Mon, Jun 1, 2020 at 3:12 PM Alexei Starovoitov wrote: > > On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > > not include stack trace or perf event output. It's use

Re: [PATCH 5/5] sfc: add missing annotation for efx_ef10_try_update_nic_stats_vf()

2020-06-01 Thread David Miller
From: Jules Irenge Date: Mon, 1 Jun 2020 19:45:52 +0100 > Sparse reports a warning at efx_ef10_try_update_nic_stats_vf() > warning: context imbalance in efx_ef10_try_update_nic_stats_vf() > - unexpected unlock > The root cause is the missing annotation at > efx_ef10_try_update_nic_stats_vf

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread Andrii Nakryiko
On Mon, Jun 1, 2020 at 3:28 PM David Ahern wrote: > > On 6/1/20 3:12 PM, Alexei Starovoitov wrote: > > In patch 5 I had to fix: > > /data/users/ast/net-next/tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c: > > In function ‘test_neg_xdp_devmap_helpers’: > > /data/users/ast/net-next/tools

Re: pull-request: bpf-next 2020-06-01

2020-06-01 Thread David Miller
From: Alexei Starovoitov Date: Mon, 1 Jun 2020 15:50:24 -0700 > The following pull-request contains BPF updates for your *net-next* tree. Pulled, thanks Alexei.

linux-next: Fixes tag needs some work in the net-next tree

2020-06-01 Thread Stephen Rothwell
Hi all, In commit 055be6865dea ("Crypto/chcr: Fixes a coccinile check error") Fixes tag Fixes: 567be3a5d227 ("crypto: has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing quotes Please do not split Fixes tags over more than one

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jakub Kicinski
On Mon, 1 Jun 2020 11:58:38 +0200 Jiri Pirko wrote: > > Documentation/networking/devlink/bnxt.rst | 4 ++ > > .../networking/devlink/devlink-params.rst | 28 ++ > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +- > > drivers/net/ethernet/broadcom/bnxt/bnx

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Jakub Kicinski
On Mon, 1 Jun 2020 21:01:42 +0530 Vasundhara Volam wrote: > > I think that the legacy ethtool should stick with the "ordinary fw reset", > > becase that is what user expects. You should add an attribute to > > "devlink dev reload" to trigger the "live fw reset" > > Okay. > > I am planning to ad

Re: [PATCH 02/12] xenbus: add freeze/thaw/restore callbacks support

2020-06-01 Thread Agarwal, Anchal
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 5/19/20 7:25 PM, Anchal Agarwal wrote: > > int xenbus_dev_resume(struct device *dev) > { > -

Re: [PATCH net-next v5] hinic: add set_channels ethtool_ops support

2020-06-01 Thread luobin (L)
On 2020/6/2 1:53, David Miller wrote: From: Luo bin Date: Mon, 1 Jun 2020 18:57:48 +0800 @@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev) struct hinic_txq *txq; struct hinic_qp *qp; + if (unlikely(!netif_carrier_ok(netdev)))

[PATCH net-next v6] hinic: add set_channels ethtool_ops support

2020-06-01 Thread Luo bin
add support to change TX/RX queue number with "ethtool -L combined". V5 -> V6: remove check for carrier in hinic_xmit_frame V4 -> V5: change time zone in patch header V3 -> V4: update date in patch header V2 -> V3: remove check for zero channels->combined_count V1 -> V2: update commit message("eth

Re: [PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload

2020-06-01 Thread Huy Nguyen
PSB On 5/22/2020 7:25 PM, Saeed Mahameed wrote: On Thu, 2020-05-21 at 16:49 -0500, Huy Nguyen wrote: During IPsec performance testing, we see bad ICMP checksum. The issue is that the error packet that has duplicated ESP trailer. For example, this below ping reply skb is collected at mlx5e_xmit.

Re: [PATCH] Bluetooth: Check scan state before disabling during suspend

2020-06-01 Thread Abhishek Pandit-Subedi
Hey linux-bluetooth, We found this bug when reverting some Chromium maintained patches in our repository that was conditionally dropping LE scan enable commands if it wasn't toggling between true/false. On some Intel controllers, disabling LE scan when it's already disabled resulted in a "Command

Re: [virtio-dev] Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-01 Thread Jason Wang
On 2020/5/30 上午2:30, Rob Miller wrote: Given the need for 4K doorbell such that QEMU can easily map, ect, and assuming that I have a HW device which exposes 2 VQ's, with a notification area off of BAR3, offset=whatever, notifier_multiplier=4, we don't need to have 2 x 4K pages mapped into the

linux-next: manual merge of the net-next tree with the clk tree

2020-06-01 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.txt between commit: 7b9e111a5216 ("dt-bindings: clock: mediatek: document clk bindings for Mediatek MT6765 SoC") from the clk tree and commit: 9f9d1e

linux-next: build warning after merge of the net-next tree

2020-06-01 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: warning: 'cxgb4_uld_in_use' defined but not used [-Wunused-function] 666 | static bool cxgb4_uld_in_use(struct adapter *adap

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-01 Thread David Ahern
On 6/1/20 4:52 PM, Andrii Nakryiko wrote: > Do you have specific examples of inconsistencies? Seems like duration is: nope, just a quick grep trying to understand why it compiled cleanly for me and looking at similar tests. > 1. either static variable, and thus zero-initialized; > 2. is initializ

[PATCH net-next] vmxnet3: allow rx flow hash ops only when rss is enabled

2020-06-01 Thread Ronak Doshi
It makes sense to allow changes to get/set rx flow hash callback only when rss is enabled. This patch restricts get_rss_hash_opts and set_rss_hash_opts methods to allow querying and configuring different Rx flow hash configurations only when rss is enabled Signed-off-by: Ronak Doshi --- drivers/

Re: [RFC PATCH] net: usb: ax88179_178a: fix packet alignment padding

2020-06-01 Thread Jeremy Kerr
Hi Freddy and Allan, Just following up on the RFC patch below: Can you confirm whether the packet len (in the hardware-provided packet RX metadata) includes the two-byte padding field? Is this the same for all ax88179 devices? Cheers, Jeremy > Using a AX88179 device (0b95:1790), I see two byte

<    1   2   3   >