On Mon, May 4, 2020 at 6:06 PM Cong Wang wrote:
>
> On Mon, May 4, 2020 at 12:08 PM Josh Poimboeuf wrote:
> >
> > On Sat, May 02, 2020 at 11:36:11PM -0700, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD commit:8999dc89 net/x25: Fix null-ptr-deref
On Tue, May 05, 2020 at 02:18:14AM +0200, Andrew Lunn wrote:
> Add new ethtool netlink calls to trigger the starting of a PHY cable
> test.
>
> Add Kconfig'ury to ETHTOOL_NETLINK so that PHYLIB is not a module when
> ETHTOOL_NETLINK is builtin, which would result in kernel linking errors.
>
> v2:
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()") will broke this driver.
> idm_base and nicpm_base were optional, after this change, they are
> mandatory. it will probe fails with -22 when the dtb doesn't have them
> defined. so revert part of this comm
From: SeongJae Park
This reverts commit 333f7909a8573145811c4ab7d8c9092301707721.
The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
deallocation of 'socket_alloc' to be done asynchronously using RCU, as
same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate
so
From: SeongJae Park
This reverts commit 6d7855c54e1e269275d7c504f8f62a0b7a5b3f18.
The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
deallocation of 'socket_alloc' to be done asynchronously using RCU, as
same to 'sock.wq'.
The change made 'socket_alloc' live longer than befor
From: SeongJae Park
The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
deallocation of 'socket_alloc' to be done asynchronously using RCU, as
same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate
socket_sq with socket itself") made those to have same life cycle
Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/ath/ath11k/dp_rx.c:2964:1-39: WARNING: Assignment
> of 0/1 to bool variable
> drivers/net/wireless/ath/ath11k/dp_rx.c:2965:1-38: WARNING: Assignment
> of 0/1 to bool variable
>
> Signed-off-by: Jason Yan
> Signed
On 04/05/2020 19:57, Clay McClure wrote:
My recent commit b6d49cab44b5 ("net: Make PTP-specific drivers depend on
PTP_1588_CLOCK")
exposes a missing dependency in defconfigs that select TI_CPTS without
selecting PTP_1588_CLOCK, leading to linker errors of the form:
drivers/net/ethernet/ti/cp
No need to convert '==' expression to bool. This fixes the following
coccicheck warning:
drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:68:11-16: WARNING:
conversion to bool not needed here
Signed-off-by: Jason Yan
---
drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 3 +--
1 file changed, 1
Fix the following coccicheck warning:
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c:105:2-38: WARNING:
Assignment of 0/1 to bool variable
Signed-off-by: Jason Yan
---
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/
Fix the following coccicheck warning:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1585:3-25:
WARNING: Assignment of 0/1 to bool variable
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1588:3-25:
WARNING: Assignment of 0/1 to bool variable
Signed-off-by: Jason Yan
---
driv
On Tue, May 05, 2020 at 09:28:40AM +0200, SeongJae Park wrote:
> From: SeongJae Park
>
> This reverts commit 333f7909a8573145811c4ab7d8c9092301707721.
>
> The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> deallocation of 'socket_alloc' to be done asynchronously using RCU, a
Fix the following coccicheck warning:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:1548:17-31: WARNING:
Comparison to bool
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:1148:16-24: WARNING:
Comparison to bool
drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c:1158:30-38: WARNING:
Comparison to b
On Tue, May 05, 2020 at 09:28:41AM +0200, SeongJae Park wrote:
> From: SeongJae Park
>
> This reverts commit 6d7855c54e1e269275d7c504f8f62a0b7a5b3f18.
>
> The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> deallocation of 'socket_alloc' to be done asynchronously using RCU, a
Fix the following coccicheck warning:
drivers/net/ethernet/qlogic/qede/qede_main.c:1717:5-19: WARNING:
Assignment of 0/1 to bool variable
Signed-off-by: Jason Yan
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/eth
Fix the following coccicheck warning:
drivers/net/ethernet/ti/cpsw_new.c:1924:2-17: WARNING: Assignment of
0/1 to bool variable
drivers/net/ethernet/ti/cpsw_new.c:1231:1-16: WARNING: Assignment of
0/1 to bool variable
Signed-off-by: Jason Yan
---
drivers/net/ethernet/ti/cpsw_new.c | 4 ++--
1 f
Fix the following coccicheck warning:
drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of
0/1 to bool variable
drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of
0/1 to bool variable
Signed-off-by: Jason Yan
---
drivers/net/ethernet/agere/et131x.c | 4 ++--
1
No need to convert '==' expression to bool. This fixes the following
coccicheck warning:
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1189:63-68: WARNING:
conversion to bool not needed here
Signed-off-by: Jason Yan
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
1 file changed, 1
Fix the following coccicheck warning:
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1991:5-46: WARNING:
Comparison to bool
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1993:10-54: WARNING:
Comparison to bool
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2380:5-38: WARNING:
Comparison
On 05/04/2020 7:33, Jason Yan wrote:
Fix the following coccicheck warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1781:9-12:
WARNING: Comparison to bool
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8:
WARNING: Comparison to bool
Signed-off-by: Jason Yan
Rev
"Gustavo A. R. Silva" wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int
From: Yunjian Wang
The method ndo_start_xmit() returns a value of type netdev_tx_t. Fix
the ndo function to use the correct type.
Signed-off-by: Yunjian Wang
---
drivers/net/ethernet/ni/nixge.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ni/nixge.
On Tue, 5 May 2020 09:45:11 +0200 Greg KH wrote:
> On Tue, May 05, 2020 at 09:28:40AM +0200, SeongJae Park wrote:
> > From: SeongJae Park
> >
> > This reverts commit 333f7909a8573145811c4ab7d8c9092301707721.
> >
> > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> > deal
On Tue, 5 May 2020 09:45:35 +0200 Greg KH wrote:
> On Tue, May 05, 2020 at 09:28:41AM +0200, SeongJae Park wrote:
> > From: SeongJae Park
> >
> > This reverts commit 6d7855c54e1e269275d7c504f8f62a0b7a5b3f18.
> >
> > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> > deal
From: SeongJae Park
The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
deallocation of 'socket_alloc' to be done asynchronously using RCU, as
same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate
socket_sq with socket itself") made those to have same life cycle
From: SeongJae Park
This reverts commit 333f7909a8573145811c4ab7d8c9092301707721.
The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
deallocation of 'socket_alloc' to be done asynchronously using RCU, as
same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate
so
From: SeongJae Park
This reverts commit 6d7855c54e1e269275d7c504f8f62a0b7a5b3f18.
The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
deallocation of 'socket_alloc' to be done asynchronously using RCU, as
same to 'sock.wq'.
The change made 'socket_alloc' live longer than befor
On Tue, 2020-05-05 at 15:45 +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of
> 0/1 to bool variable
> drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of
> 0/1 to bool variable
>
> Signed-of
>> Do you distinguish between releasing items and the role of such a pointer?
> I didn't distinguish these.
How do you think about to clarify this aspect a bit more (according to computer
science)
besides your subsequent constructive feedback?
Regards,
Markus
On Tue, May 05, 2020 at 02:18:15AM +0200, Andrew Lunn wrote:
> Add the attributes needed to report cable test results to userspace.
> The reports are expected to be per twisted pair. A nested property per
> pair can report the result of the cable test. A nested property can
> also report the length
On Tue, May 05, 2020 at 02:18:16AM +0200, Andrew Lunn wrote:
> Make some helpers for building ethtool netlink messages available
> outside the compilation unit, so they can be used for building
> messages which are not simple get/set.
>
> Signed-off-by: Andrew Lunn
> ---
Reviewed-by: Michal Kube
There's no callers in-tree anymore.
Signed-off-by: YueHaibing
---
drivers/net/ethernet/tehuti/tehuti.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/net/ethernet/tehuti/tehuti.c
b/drivers/net/ethernet/tehuti/tehuti.c
index 40a2ce0ca808..e28727297563 100644
--- a/drive
There's no callers in-tree anymore.
Signed-off-by: YueHaibing
---
drivers/net/ethernet/sun/cassini.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/net/ethernet/sun/cassini.c
b/drivers/net/ethernet/sun/cassini.c
index 3ee6ab104cb9..e6e25960da4f 100644
--- a/drivers/net
On Mon, 4 May 2020 11:37:53 +0300
Denis Kirjanov wrote:
> +static int xennet_create_page_pool(struct netfront_queue *queue)
> +{
> + int err;
> + struct page_pool_params pp_params = {
> + .order = 0,
> + .flags = 0,
> + .pool_size = NET_RX_RING_SIZE,
>
commit b5f69ccf6765 ("ixgbe: avoid bringing rings up/down as macvlans are
added/removed")
left behind this, remove it.
Signed-off-by: YueHaibing
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 29 ---
1 file changed, 29 deletions(-)
diff --git a/drivers/net/ethernet/intel/i
commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig
option")
left behind this, remove it.
Signed-off-by: YueHaibing
---
drivers/net/can/c_can/c_can.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_c
commit 84411f73b884 ("net: mv643xx_eth: Avoid setting the initial TCP checksum")
left behind this, remove it.
Signed-off-by: YueHaibing
---
drivers/net/ethernet/marvell/mv643xx_eth.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c
b/drivers/net
There's no caller in-tree since
commit 2af6106ae949 ("net: stmmac: Introducing support for Page Pool")
Signed-off-by: YueHaibing
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b/
commit 4ca3221fe4b6 ("myri10ge: Convert from LRO to GRO")
left behind this, remove it.
Signed-off-by: YueHaibing
---
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
b/drivers/net/e
There's no callers in-tree.
Signed-off-by: YueHaibing
---
drivers/net/ethernet/microchip/encx24j600-regmap.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c
b/drivers/net/ethernet/microchip/encx24j600-regmap.c
index 1f496fac7033..5bd7fb
On Mon, May 4, 2020 at 7:46 PM Cong Wang wrote:
>
> Sorry for the delay. I lost connection to my dev machine, I am trying
> to setup this on my own laptop.
Sorry to hear that. I will gladly give you access to my testing
machine where all this nasty stuff happens every time so you can test
it in p
commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related
code.")
left behind this, remove it.
Signed-off-by: YueHaibing
---
net/sunrpc/svcauth_unix.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
index 6c8f8
There's no callers in-tree anymore since commit 5952fde10c35 ("net:
sched: choke: remove dead filter classify code")
Signed-off-by: YueHaibing
---
net/sched/sch_choke.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c
index a36974e9c601..2d350
commit 05cc5a39ddb7 ("bnx2x: add vlan filtering offload")
left behind this, remove it.
Signed-off-by: YueHaibing
---
.../net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 21 ---
1 file changed, 21 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
b/drivers/
On Tue, May 5, 2020 at 3:59 AM Dejin Zheng wrote:
> On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote:
> > (Markus is clearly not taking the hint, but FYI for everyone else:)
> Brian, Thanks very much for your reminder, These comments have always
> bothered me. Now I can put it on my b
There's no callers in-tree
Signed-off-by: YueHaibing
---
drivers/net/usb/sierra_net.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c
index 389d19dd7909..0abd257b634c 100644
--- a/drivers/net/usb/sierra_net.c
+++ b/drivers/net/u
> Perhaps we need to find a good researcher student who may do a MD
> dissertation out of the case :-)
I got the impression that some research is performed already around
affected areas.
Would you like to reuse any more experiences from there?
Regards,
Markus
This patch adds FLOW_ACTION_HW_STATS_DONT_CARE which tells the driver
that the frontend does not need counters, this hw stats type request
never fails. The FLOW_ACTION_HW_STATS_DISABLED type explicitly requests
the driver to disable the stats, however, if the driver cannot disable
counters, it bail
Hi Stephen, David,
> -Original Message-
> From: Stephen Hemminger
> Sent: 2020年5月5日 8:05
> To: Po Liu
> Cc: da...@davemloft.net; linux-ker...@vger.kernel.org;
> netdev@vger.kernel.org; vinicius.go...@intel.com; v...@buslov.dev;
> Claudiu Manoil ; Vladimir Oltean
> ; Alexandru Marginean
> -Original Message-
> From: David Miller
> Sent: Tuesday, May 5, 2020 1:40 AM
> To: Ooi, Joyce
> Cc: thor.tha...@linux.intel.com; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; Westergreen, Dalon ;
> Tan, Ley Foon ; See, Chin Liang
> ; Nguyen, Dinh
> Subject: Re: [PATCHv2 01/1
Hi Stephen,
> -Original Message-
> From: Stephen Hemminger
> Sent: 2020年5月5日 8:07
> To: Po Liu
> Cc: da...@davemloft.net; linux-ker...@vger.kernel.org;
> netdev@vger.kernel.org; vinicius.go...@intel.com; v...@buslov.dev;
> Claudiu Manoil ; Vladimir Oltean
> ; Alexandru Marginean
> ; mich
On Mon, May 04, 2020 at 07:21 PM CEST, John Fastabend wrote:
> In these two cases sk_msg layout was getting confused with some helper
> sequences.
>
> I found these while cleaning up test_sockmap to do a better job covering
> the different scenarios. Those patches will go to bpf-next and include
>
Tue, May 05, 2020 at 11:21:59AM CEST, pa...@netfilter.org wrote:
>This patch adds FLOW_ACTION_HW_STATS_DONT_CARE which tells the driver
>that the frontend does not need counters, this hw stats type request
>never fails. The FLOW_ACTION_HW_STATS_DISABLED type explicitly requests
>the driver to disab
Remove duplicated include.
Signed-off-by: YueHaibing
---
drivers/net/ipa/ipa_mem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c
index aa8f6b0f3d50..3ef814119aab 100644
--- a/drivers/net/ipa/ipa_mem.c
+++ b/drivers/net/ipa/ipa_mem.c
@@ -
On Tue, May 05, 2020 at 11:49:00AM +0200, Jiri Pirko wrote:
> Tue, May 05, 2020 at 11:21:59AM CEST, pa...@netfilter.org wrote:
> >This patch adds FLOW_ACTION_HW_STATS_DONT_CARE which tells the driver
> >that the frontend does not need counters, this hw stats type request
> >never fails. The FLOW_AC
Andrii Nakryiko writes:
> On Mon, May 4, 2020 at 2:13 AM Eelco Chaudron wrote:
>>
>> When the probe code was failing for any reason ENOTSUP was returned, even
>> if this was due to no having enough lock space. This patch fixes this by
>> returning EPERM to the user application, so it can respond
Hi Andrew,
Am 2020-05-05 02:18, schrieb Andrew Lunn:
The Marvell PHYs have a couple of different register sets for
performing cable tests. Page 7 provides the simplest to use.
Signed-off-by: Andrew Lunn
---
drivers/net/phy/marvell.c | 202 ++
1 file changed
g TI_K3_AM65_CPSW_NUSS
> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
> select TI_DAVINCI_MDIO
> imply PHY_TI_GMII_SEL
> + imply TI_AM65_CPTS
Should this be TI_K3_AM65_CPTS ?
I did an arm64 allmodconfig build on todays next tag: next-20200505
and got t
Fix dt_binding_check fail:
Fix Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml: $id: relative
path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/net/ti,k3-am654-cpts.yaml#
Unknown file referenced: [Errno 2] No such file or directory:
'/
On 05/05/2020 07:05, Rob Herring wrote:
On Fri, 1 May 2020 23:50:05 +0300, Grygorii Strashko wrote:
Document device tree bindings for TI AM654/J721E SoC The Common Platform
Time Sync (CPTS) module. The CPTS module is used to facilitate host control
of time sync operations. Main features of CP
To properly identify this node, we need to use ethernet-phy-id0180.dc80.
And add missing required properties.
Signed-off-by: Oleksij Rempel
---
.../devicetree/bindings/net/nxp,tja11xx.yaml | 55 ---
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git a/Documentation/de
On Tue, May 05, 2020 at 02:18:17AM +0200, Andrew Lunn wrote:
> Provide infrastructure for PHY drivers to report the cable test
> results. A netlink skb is associated to the phydev. Helpers will be
> added which can add results to this skb. Once the test has finished
> the results are sent to user
On Tue, May 05, 2020 at 02:18:18AM +0200, Andrew Lunn wrote:
> The PHY drivers can use these helpers for reporting the results. The
> results get translated into netlink attributes which are added to the
> pre-allocated skbuf.
>
> Signed-off-by: Andrew Lunn
> ---
[...]
> diff --git a/net/ethtool/
On Tue, May 05, 2020 at 02:18:19AM +0200, Andrew Lunn wrote:
> The Marvell PHYs have a couple of different register sets for
> performing cable tests. Page 7 provides the simplest to use.
>
> Signed-off-by: Andrew Lunn
> ---
> drivers/net/phy/marvell.c | 202 +
ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
select TI_DAVINCI_MDIO
imply PHY_TI_GMII_SEL
+ imply TI_AM65_CPTS
Should this be TI_K3_AM65_CPTS ?
I did an arm64 allmodconfig build on todays next tag: next-20200505
and got this undefined symbol:
aarch64-linux-gnu
onfig
> >> @@ -100,6 +100,7 @@ config TI_K3_AM65_CPSW_NUSS
> >> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
> >> select TI_DAVINCI_MDIO
> >> imply PHY_TI_GMII_SEL
> >> + imply TI_AM65_CPTS
> >
> >
On Tue, May 05, 2020 at 02:18:20AM +0200, Andrew Lunn wrote:
> Since running a cable test is disruptive, put the interface into
> operative state testing while the test is running.
>
> Signed-off-by: Andrew Lunn
> ---
Reviewed-by: Michal Kubecek
Things could be simplified a bit by putting neti
While running selftests bpf test_sysctl on stable rc 4.19 branch kernel
on arm64 hikey device. The following warning was noticed.
[ 118.957395] test_bpf: #296 BPF_MAXINSNS: exec all MSH
[ 148.966435] [ cut here ]
[ 148.988349] NETDEV WATCHDOG: eth0 (asix): transmit queue
On Tue, May 05, 2020 at 02:18:21AM +0200, Andrew Lunn wrote:
> Given that it takes time to run a cable test, send a notify message at
> the start, as well as when it is completed.
>
> Signed-off-by: Andrew Lunn
> ---
> net/ethtool/cabletest.c | 39 +++
> 1 fil
CC-ing sta...@vger.kernel.org and adding some more explanations.
On Tue, 5 May 2020 10:10:33 +0200 SeongJae Park wrote:
> From: SeongJae Park
>
> The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> deallocation of 'socket_alloc' to be done asynchronously using RCU, as
> sam
t;> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
> > >> select TI_DAVINCI_MDIO
> > >> imply PHY_TI_GMII_SEL
> > >> + imply TI_AM65_CPTS
> > >
> > > Should this be TI_K3_AM65_CPTS ?
instead of
The following lockdep splat happens reproducibly on 5.7-rc4
Thanks,
tglx
WARNING: inconsistent lock state
5.7.0-rc4+ #79 Not tainted
inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
ip/356 [HC0[0]:SC1[1]:HE1:SE0] tak
Tue, May 05, 2020 at 12:08:14PM CEST, pa...@netfilter.org wrote:
>On Tue, May 05, 2020 at 11:49:00AM +0200, Jiri Pirko wrote:
>> Tue, May 05, 2020 at 11:21:59AM CEST, pa...@netfilter.org wrote:
>> >This patch adds FLOW_ACTION_HW_STATS_DONT_CARE which tells the driver
>> >that the frontend does not
Hi Anders,
On 05/05/2020 14:59, Anders Roxell wrote:
On Tue, 5 May 2020 at 13:16, Anders Roxell wrote:
On Tue, 5 May 2020 at 13:05, Grygorii Strashko wrote:
On 05/05/2020 13:17, Anders Roxell wrote:
On Fri, 1 May 2020 at 22:50, Grygorii Strashko wrote:
The MCU CPSW Common Platform Time S
On Tue, 2020-05-05 at 13:54 +0200, SeongJae Park wrote:
> CC-ing sta...@vger.kernel.org and adding some more explanations.
>
> On Tue, 5 May 2020 10:10:33 +0200 SeongJae Park
> wrote:
>
> >
> > From: SeongJae Park
> >
> > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made
> > t
From: Jérôme Pouiller
The WF200 can be used on SPI and SDIO. When using SDIO bus, the driver
normally use the in band IRQ provided by the SDIO bus. However, WF200
also provides support for a dedicated IRQ line. This feature is used
when in-band IRQ does not work or to allows some kind of Wake-On-
From: Jérôme Pouiller
In case of error in wfx_probe(), wdev->hw is freed. Since an error
occurred, wfx_free_common() is called, then wdev->hw is freed again.
Cc: Michał Mirosław
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/dr
From: Jérôme Pouiller
The kernel coding style expects no space after cast operator. This patch
make the wfx driver compliant with this rule.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_rx.c | 2 +-
drivers/staging/wfx/hif_tx.c | 4 ++--
drivers/staging/wfx/hwio.c | 4 ++--
From: Jérôme Pouiller
Some function prototypes were not correctly aligned and/or exceed 80
columns.
In some other cases, the prototypes were written on more lines than
necessary.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 3 +--
drivers/staging/wfx/hif_tx.c | 24
From: Jérôme Pouiller
When the chip starts in SDIO mode, the external IRQ (aka Out-Of-Band
IRQ) cannot be used before to configure it. Therefore, the first
exchanges with the chip have to be done without the OOB IRQ.
This patch allow to poll the data until the OOB IRQ is correctly setup.
In orde
From: Jérôme Pouiller
The kernel coding style promotes the use of kernel types (u8, u16, u32,
etc...) instead of the C99 ones.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 5 ++---
drivers/staging/wfx/hif_tx_mib.c | 2 +-
drivers/staging/wfx/hif_tx_mib.h | 2 +-
driver
From: Jérôme Pouiller
Currently, the ISR check if bus->core is not NULL. But, it is a useless
check. bus->core is initialiased before to request IRQ and it is not
assigned to NULL when it is released.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bus_sdio.c | 9 +
drivers/stag
From: Jérôme Pouiller
In order to keep the compilation times reasonable, we try to only
include the necessary headers (especially header included from other
headers).
This patch clean up unnecessary headers inclusions.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_rx.h| 3 +-
From: Jérôme Pouiller
Currently, the SPI implementation use a workqueue to acknowledge IRQ
while the SDIO-OOB implementation use a threaded IRQ.
The threaded also offers the advantage to allow level triggered IRQs.
Uniformize the code and use threaded IRQ in both case. Therefore, prefer
level t
From: Jérôme Pouiller
The function get_firmware() is only used from fwio.c. It can be declared
static.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/fwio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c
i
From: Jérôme Pouiller
It is possible to check if an IRQ is ending by polling the control
register. This function must used with care: if an IRQ fires while the
host reads control register, the IRQ can be lost. However, it could be
useful in some cases.
Signed-off-by: Jérôme Pouiller
---
driver
From: Jérôme Pouiller
Sparse tool noticed that wfx_enable_beacon() is never used outside of
sta.c. Therefore, it can be declared static.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/sta.c b/
From: Jérôme Pouiller
When possible, we prefer to use the macro ARRAY_SIZE rather than hard
coding the number of elements.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c
From: Jérôme Pouiller
The device take a few hundreds of milliseconds to start. However, the
current code wait up to 10 second for the chip. We can safely reduce
this value to 1 second. Thanks to that change, it is no more necessary
to use an interruptible timeout.
Signed-off-by: Jérôme Pouiller
From: Jérôme Pouiller
When used over SDIO bus, device is able to use an external line to
signal IRQs (also called Out-Of-Band IRQ). The current code have several
problems:
1. The ISR cannot directly acknowledge IRQ since access to the bus is
not atomic. This patch use a threaded IRQ to sol
From: Jérôme Pouiller
Currently, the driver explicitly exclude support for chip with version
number it does not know. However, it unlikely that any futur hardware
change would break the driver. Therefore, we prefer to invert the test
and only exclude the versions we know the driver does not suppo
On Tue, May 05, 2020 at 09:28:39AM +0200, SeongJae Park wrote:
> From: SeongJae Park
>
> The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> deallocation of 'socket_alloc' to be done asynchronously using RCU, as
> same to 'sock.wq'. And the following commit 333f7909a857 ("coa
On 05/05/2020 14:59, Anders Roxell wrote:
On Tue, 5 May 2020 at 13:16, Anders Roxell wrote:
On Tue, 5 May 2020 at 13:05, Grygorii Strashko wrote:
hi Anders,
Hi Grygorii,
Hi again,
On 05/05/2020 13:17, Anders Roxell wrote:
On Fri, 1 May 2020 at 22:50, Grygorii Strashko wrote:
Print to system log when SMC links are available or go down, link group
state changes or pnetids are applied to and removed from devices.
The log entries are triggered by either user configuration actions or
adapter activation/deactivation events and are not expected to happen
often. The entries he
From: YueHaibing
commit bac6de7b6370 ("net/smc: eliminate cursor read and write calls")
left behind this.
Signed-off-by: YueHaibing
Signed-off-by: Karsten Graul
---
net/smc/smc_cdc.h | 17 -
1 file changed, 17 deletions(-)
diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h
in
Patch 1 adds the logging of important state changes to enable SMC-R
users to detect SMC-R link groups that are not redundant and require
user actions. Patch 2 is a contribution to clean up an unused inline
function.
Karsten Graul (1):
net/smc: log important pnetid and state change events
YueH
> +static int at803x_cable_test_get_status(struct phy_device *phydev,
> + bool *finished)
> +{
> + struct at803x_priv *priv = phydev->priv;
> + static const int ethtool_pair[] = {
> + ETHTOOL_A_CABLE_PAIR_0, ETHTOOL_A_CABLE_PAIR_1,
> +
> > +
> > +-++-+
> > + | ``ETHTOOL_A_CABLE_TEST_HEADER`` | nested | reply header
> >|
> > +
> > +-++-+
> > + | ``ETHTOOL_A_CABLE_TES
> > +int ethnl_cable_test_alloc(struct phy_device *phydev)
> > +{
> > + int err = -ENOMEM;
> > +
> > + phydev->skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> > + if (!phydev->skb)
> > + goto out;
> > +
> > + phydev->ehdr = ethnl_bcastmsg_put(phydev->skb,
> > +
> > +int ethnl_cable_test_fault_length(struct phy_device *phydev, u8 pair, u32
> > cm)
> > +{
> > + struct nlattr *nest;
> > + int ret = -EMSGSIZE;
> > +
> > + nest = nla_nest_start(phydev->skb,
> > + ETHTOOL_A_CABLE_TEST_NTF_FAULT_LENGTH);
> > + if (!nest)
> > +
1 - 100 of 459 matches
Mail list logo