[PATCH net-next 7/7] selftests: mlxsw: Add a test case for devlink-trap

2019-08-21 Thread Ido Schimmel
From: Ido Schimmel Test generic devlink-trap functionality over mlxsw. These tests are not specific to a single trap, but do not check the devlink-trap common infrastructure either. Currently, the only test case is device deletion (by reloading the driver) while packets are being trapped. Signe

[PATCH net-next 3/7] mlxsw: Add layer 2 discard trap IDs

2019-08-21 Thread Ido Schimmel
From: Ido Schimmel Add the trap IDs used to report layer 2 drops. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/trap.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/trap.h b/drivers/net/ethernet/mella

[PATCH net-next 2/7] mlxsw: reg: Add new trap actions

2019-08-21 Thread Ido Schimmel
From: Ido Schimmel Subsequent patches will add discard traps support in mlxsw. The driver cannot configure such traps with a normal trap action, but needs to use exception trap action, which also increments an error counter. On the other hand, when these traps are initialized or set to drop acti

[PATCH net-next 4/7] mlxsw: Add trap group for layer 2 discards

2019-08-21 Thread Ido Schimmel
From: Ido Schimmel Discard trap groups are defined in a different enum so that they could all share the same policer ID: MLXSW_REG_HTGT_TRAP_GROUP_MAX + 1. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 8 1 file changed, 8 insertions

[PATCH net-next 1/7] mlxsw: core: Add API to set trap action

2019-08-21 Thread Ido Schimmel
From: Ido Schimmel Up until now the action of a trap was never changed during its lifetime. This is going to change by subsequent patches that will allow devlink to control the action of certain traps. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/co

[PATCH net-next 6/7] selftests: mlxsw: Add test cases for devlink-trap L2 drops

2019-08-21 Thread Ido Schimmel
From: Ido Schimmel Test that each supported packet trap is triggered under the right conditions and that packets are indeed dropped and not forwarded. Signed-off-by: Ido Schimmel --- .../net/mlxsw/devlink_trap_l2_drops.sh| 484 ++ 1 file changed, 484 insertions(+) crea

[PATCH net-next 5/7] mlxsw: spectrum: Add devlink-trap support

2019-08-21 Thread Ido Schimmel
From: Ido Schimmel Register supported packet traps (layer 2 drops only, currently) and associated trap group with devlink during driver initialization. The amount of traffic generated by these packet drop traps is capped at 10Kpps to ensure the CPU is not overwhelmed by incoming packets. Signed

[PATCH net-next 0/7] mlxsw: Add devlink-trap support

2019-08-21 Thread Ido Schimmel
From: Ido Schimmel This patchset adds devlink-trap support in mlxsw. Patches #1-#4 add the necessary APIs and defines in mlxsw. Patch #5 implements devlink-trap support for layer 2 drops. More drops will be added in the future. Patches #6-#7 add selftests to make sure that all the new code pat

RE: Help needed - Kernel lockup while running ipsec

2019-08-21 Thread Vakul Garg
> -Original Message- > From: Vakul Garg > Sent: Tuesday, August 20, 2019 4:08 PM > To: Florian Westphal > Cc: netdev@vger.kernel.org > Subject: RE: Help needed - Kernel lockup while running ipsec > > > > > > > > -Original Message- > > > From: Florian Westphal > > > Sent: Tue

[PATCH iproute2-next v2] tc: add dualpi2 scheduler module

2019-08-21 Thread Tilmans, Olivier (Nokia - BE/Antwerp)
From: Olga Albisser DualPI2 AQM is a combination of the DualQ Coupled-AQM with a PI2 base-AQM, able to control scalable congestion controls like DCTCP and TCP-Prague, implemented as a Linux qdisc. This patch adds support to tc to configure it through its netlink interface. Signed-off-by: Olga A

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-21 Thread Toshiaki Makita
On 19/08/20 (火) 3:15:46, Jakub Kicinski wrote: I'm on vacation and replying slowly. Sorry for any inconvenience. On Sat, 17 Aug 2019 23:01:59 +0900, Toshiaki Makita wrote: On 19/08/17 (土) 3:52:24, Jakub Kicinski wrote: On Fri, 16 Aug 2019 10:28:10 +0900, Toshiaki Makita wrote: On 2019/08/16

[PATCH bpf-next 0/2] tools: bpftool: work with frozen maps

2019-08-21 Thread Quentin Monnet
Hi, This is a simple set to add support for BPF map freezing to bpftool. First patch makes bpftool indicate if a map is frozen when listing BPF maps. Second patch adds a command to freeze a map loaded on the system. Quentin Monnet (2): tools: bpftool: show frozen status for maps tools: bpftool

[PATCH bpf-next 1/2] tools: bpftool: show frozen status for maps

2019-08-21 Thread Quentin Monnet
When listing maps, read their "frozen" status from procfs, and tell if maps are frozen. As commit log for map freezing command mentions that the feature might be extended with flags (e.g. for write-only instead of read-only) in the future, use an integer and not a boolean for JSON output. Signed-

[PATCH bpf-next 2/2] tools: bpftool: add "bpftool map freeze" subcommand

2019-08-21 Thread Quentin Monnet
Add a new subcommand to freeze maps from user space. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- .../bpf/bpftool/Documentation/bpftool-map.rst | 9 + tools/bpf/bpftool/bash-completion/bpftool | 4 +-- tools/bpf/bpftool/map.c | 34 +++

Re: [PATCH v1] ocfs2/dlm: Move BITS_TO_BYTES() to bitops.h for wider use

2019-08-21 Thread Andy Shevchenko
On Wed, Aug 21, 2019 at 09:29:04AM +0800, Joseph Qi wrote: > On 19/8/21 00:31, Andy Shevchenko wrote: > > There are users already and will be more of BITS_TO_BYTES() macro. > > Move it to bitops.h for wider use. > > > > Signed-off-by: Andy Shevchenko > > --- > > drivers/net/ethernet/broadcom/bnx

Re: [PATCH net-next 3/6] net: dsa: Delete the VID from the upstream port as well

2019-08-21 Thread Vladimir Oltean
On Wed, 21 Aug 2019 at 06:30, Vivien Didelot wrote: > > On Wed, 21 Aug 2019 01:09:39 +0300, Vladimir Oltean wrote: > > I mean I made an argument already for the hack in 4/6 ("Don't program > > the VLAN as pvid on the upstream port"). If the hack gets accepted > > like that, I have no further need

Re: [PATCH RFC ipsec-next 0/7] ipsec: add TCP encapsulation support (RFC 8229)

2019-08-21 Thread Sabrina Dubroca
2019-08-21, 08:59:11 +0200, Steffen Klassert wrote: > On Fri, Aug 16, 2019 at 04:18:14PM +0200, Sabrina Dubroca wrote: > > Hi Steffen, > > > > 2019-06-25, 12:11:33 +0200, Sabrina Dubroca wrote: > > > This patchset introduces support for TCP encapsulation of IKE and ESP > > > messages, as defined b

Re: [PATCH v2 2/4] bpf: fix 'struct pt_reg' typo in documentation

2019-08-21 Thread Quentin Monnet
2019-08-21 00:08 UTC+0100 ~ Peter Wu > There is no 'struct pt_reg'. > > Signed-off-by: Peter Wu Reviewed-by: Quentin Monnet Thanks for the fix! Quentin

Re: [PATCH spi for-5.4 1/5] spi: Use an abbreviated pointer to ctlr->cur_msg in __spi_pump_messages

2019-08-21 Thread Mark Brown
On Tue, Aug 20, 2019 at 10:36:43PM +0300, Vladimir Oltean wrote: > On Tue, 20 Aug 2019 at 21:21, Mark Brown wrote: > > On Sun, Aug 18, 2019 at 09:25:56PM +0300, Vladimir Oltean wrote: > > > /* Extract head of queue */ > > > - ctlr->cur_msg = > > > - list_first_entry(&ctlr->

[PATCH] trivial: netns: fix typo in 'struct net.passive' description

2019-08-21 Thread Mike Rapoport
Replace 'decided' with 'decide' so that comment would be /* To decide when the network namespace should be freed. */ Signed-off-by: Mike Rapoport --- include/net/net_namespace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/net_namespace.h b/include/net/net_nam

Re: [PATCH bpf-next 2/2] tools: bpftool: add "bpftool map freeze" subcommand

2019-08-21 Thread Daniel Borkmann
On 8/21/19 10:52 AM, Quentin Monnet wrote: Add a new subcommand to freeze maps from user space. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- .../bpf/bpftool/Documentation/bpftool-map.rst | 9 + tools/bpf/bpftool/bash-completion/bpftool | 4 +-- tools/bpf/bpftool/

Re: [PATCH bpf-next v2 2/4] selftests/bpf: test_progs: remove global fail/success counts

2019-08-21 Thread Daniel Borkmann
On 8/19/19 9:17 PM, Stanislav Fomichev wrote: Now that we have a global per-test/per-environment state, there is no longer need to have global fail/success counters (and there is no need to save/get the diff before/after the test). Thanks for the improvements, just a small comment below, otherw

[PATCH bpf] flow_dissector: Fix potential use-after-free on BPF_PROG_DETACH

2019-08-21 Thread Jakub Sitnicki
Call to bpf_prog_put(), with help of call_rcu(), queues an RCU-callback to free the program once a grace period has elapsed. The callback can run together with new RCU readers that started after the last grace period. New RCU readers can potentially see the "old" to-be-freed or already-freed pointe

Re: [PATCH bpf-next 2/2] tools: bpftool: add "bpftool map freeze" subcommand

2019-08-21 Thread Quentin Monnet
2019-08-21 13:40 UTC+0200 ~ Daniel Borkmann > On 8/21/19 10:52 AM, Quentin Monnet wrote: >> Add a new subcommand to freeze maps from user space. >> >> Signed-off-by: Quentin Monnet >> Reviewed-by: Jakub Kicinski >> --- >>   .../bpf/bpftool/Documentation/bpftool-map.rst |  9 + >>   tools/bpf/

Re: [PATCH bpf-next 2/2] tools: bpftool: add "bpftool map freeze" subcommand

2019-08-21 Thread Daniel Borkmann
On 8/21/19 2:58 PM, Quentin Monnet wrote: 2019-08-21 13:40 UTC+0200 ~ Daniel Borkmann On 8/21/19 10:52 AM, Quentin Monnet wrote: Add a new subcommand to freeze maps from user space. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski ---   .../bpf/bpftool/Documentation/bpftool-map.rs

Re: [PATCH bpf-next v4] libbpf: add xsk_ring_prod__nb_free() function

2019-08-21 Thread Magnus Karlsson
On Wed, Aug 14, 2019 at 3:51 PM Eelco Chaudron wrote: > > When an AF_XDP application received X packets, it does not mean X > frames can be stuffed into the producer ring. To make it easier for > AF_XDP applications this API allows them to check how many frames can > be added into the ring. > > Th

[PATCH 1/2] rtnetlink: gate MAC address with an LSM hook

2019-08-21 Thread Jeff Vander Stoep
MAC addresses are often considered sensitive because they are usually unique and can be used to identify/track a device or user [1]. The MAC address is accessible via the RTM_NEWLINK message type of a netlink route socket[2]. Ideally we could grant/deny access to the MAC address on a case-by-case

[PATCH 2/2] selinux: use netlink_receive hook

2019-08-21 Thread Jeff Vander Stoep
Add the nlmsg_readpriv permission to netlink_route socket class. Currently this is only used to restrict MAC address access. Signed-off-by: Jeff Vander Stoep --- security/selinux/hooks.c| 6 ++ security/selinux/include/classmap.h | 2 +- 2 files changed, 7 insertions(+), 1 deleti

Re: [PATCH bpf-next v4] libbpf: add xsk_ring_prod__nb_free() function

2019-08-21 Thread Eelco Chaudron
On 21 Aug 2019, at 15:11, Magnus Karlsson wrote: On Wed, Aug 14, 2019 at 3:51 PM Eelco Chaudron wrote: When an AF_XDP application received X packets, it does not mean X frames can be stuffed into the producer ring. To make it easier for AF_XDP applications this API allows them to check how

Re: [PATCH 1/2] rtnetlink: gate MAC address with an LSM hook

2019-08-21 Thread Jeffrey Vander Stoep
On Wed, Aug 21, 2019 at 3:45 PM Jeff Vander Stoep wrote: > > MAC addresses are often considered sensitive because they are > usually unique and can be used to identify/track a device or > user [1]. > > The MAC address is accessible via the RTM_NEWLINK message type of a > netlink route socket[2]. I

Re: [PATCH rdma-next 0/3] RDMA RX RoCE Steering Support

2019-08-21 Thread Leon Romanovsky
On Tue, Aug 20, 2019 at 01:54:59PM -0400, Doug Ledford wrote: > On Mon, 2019-08-19 at 14:36 +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi, > > > > This series from Mark extends mlx5 with RDMA_RX RoCE flow steering > > support > > for DEVX and QP objects. > > > > Thanks > > > >

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-21 Thread Richard Cochran
On Tue, Aug 20, 2019 at 09:38:45PM -0700, Richard Cochran wrote: > Overall, the PTP switch use case is well supported by Linux. The > synchronization of the management CPU to the PTP, while nice to have, > is not required to implement a Transparent Clock. Your specific > application might require

[PATCH] i40e: check __I40E_VF_DISABLE bit in i40e_sync_filters_subtask

2019-08-21 Thread Stefan Assmann
While testing VF spawn/destroy the following panic occured. BUG: unable to handle kernel NULL pointer dereference at 0029 [...] Workqueue: i40e i40e_service_task [i40e] RIP: 0010:i40e_sync_vsi_filters+0x6fd/0xc60 [i40e] [...] Call Trace: ? __switch_to_asm+0x35/0x70 ? __switch_to_asm+

Re: [PATCH bpf-next v4] libbpf: add xsk_ring_prod__nb_free() function

2019-08-21 Thread Magnus Karlsson
On Wed, Aug 21, 2019 at 3:46 PM Eelco Chaudron wrote: > > > > On 21 Aug 2019, at 15:11, Magnus Karlsson wrote: > > > On Wed, Aug 14, 2019 at 3:51 PM Eelco Chaudron > > wrote: > >> > >> When an AF_XDP application received X packets, it does not mean X > >> frames can be stuffed into the producer r

Re: [PATCH 1/2] rtnetlink: gate MAC address with an LSM hook

2019-08-21 Thread Casey Schaufler
On 8/21/2019 6:45 AM, Jeff Vander Stoep wrote: > MAC addresses are often considered sensitive because they are > usually unique and can be used to identify/track a device or > user [1]. > > The MAC address is accessible via the RTM_NEWLINK message type of a > netlink route socket[2]. Ideally we cou

[PATCH net-next v2 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-08-21 Thread René van Dorst
* Re-add SGMII support but now with PHYLINK API support So the SGMII changes are more clear * Move SGMII block setup from mtk_gmac_sgmii_path_setup() to mtk_mac_config() * Merge mtk_setup_hw_path() into mtk_mac_config() * Remove mediatek,physpeed property, fixed-link supports now any speed so

[PATCH net-next v2 0/3] net: ethernet: mediatek: convert to PHYLINK

2019-08-21 Thread René van Dorst
These patches converts mediatek driver to PHYLINK API. v1->v2: * Rebase for mt76x8 changes * Phylink improvements and clean-ups after review * SGMII port doesn't support 2.5Gbit in SGMII mode only in BASE-X mode. Refactor the code. René van Dorst (3): net: ethernet: mediatek: Add basic PHYLIN

[PATCH net-next v2 3/3] dt-bindings: net: ethernet: Update mt7622 docs and dts to reflect the new phylink API

2019-08-21 Thread René van Dorst
This patch the removes the recently added mediatek,physpeed property. Use the fixed-link property speed = <2500> to set the phy in 2.5Gbit. See mt7622-bananapi-bpi-r64.dts for a working example. Signed-off-by: René van Dorst Cc: devicet...@vger.kernel.org Cc: Rob Herring -- v1->v2: * SGMII port

[PATCH net-next v2 1/3] net: ethernet: mediatek: Add basic PHYLINK support

2019-08-21 Thread René van Dorst
This convert the basics to PHYLINK API. SGMII support is not in this patch. Signed-off-by: René van Dorst -- v1->v2: * Also report 1000Base-X support suggested by Russell King * Reverse christmas on many places suggested by David Miller * Rebase too pickup the mt76x8 changes. --- drivers/net/eth

[PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5

2019-08-21 Thread René van Dorst
1. net: dsa: mt7530: Convert to PHYLINK API This patch converts mt7530 to PHYLINK API. 2. dt-bindings: net: dsa: mt7530: Add support for port 5 3. net: dsa: mt7530: Add support for port 5 These 2 patches adding support for port 5 of the switch. v1->v2: * Mostly phylink improvements after re

[PATCH net-next v2 2/3] dt-bindings: net: dsa: mt7530: Add support for port 5

2019-08-21 Thread René van Dorst
MT7530 port 5 has many modes/configurations. Update the documentation how to use port 5. Signed-off-by: René van Dorst Cc: devicet...@vger.kernel.org Cc: Rob Herring v1->v2: * Adding extra note about RGMII2 and gpio use. rfc->v1: * No change --- .../devicetree/bindings/net/dsa/mt7530.txt| 2

[PATCH net-next v2 3/3] net: dsa: mt7530: Add support for port 5

2019-08-21 Thread René van Dorst
Adding support for port 5. Port 5 can muxed/interface to: - internal 5th GMAC of the switch; can be used as 2nd CPU port or as extra port with an external phy for a 6th ethernet port. - internal PHY of port 0 or 4; Used in most applications so that port 0 or 4 is the WAN port and interfaces wi

[PATCH net-next v2 1/3] net: dsa: mt7530: Convert to PHYLINK API

2019-08-21 Thread René van Dorst
Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst v1->v2: * Refactor "unsupported" phy_interface part in mt7530_phylink_mac_validate() suggested by Russell King * Report and return when phylink tries to use autoneg_inband in mt7530_phylink_mac_config() suggested by Russell King * R

Re: [PATCH 1/2] rtnetlink: gate MAC address with an LSM hook

2019-08-21 Thread Jeffrey Vander Stoep
On Wed, Aug 21, 2019 at 4:34 PM Casey Schaufler wrote: > > On 8/21/2019 6:45 AM, Jeff Vander Stoep wrote: > > MAC addresses are often considered sensitive because they are > > usually unique and can be used to identify/track a device or > > user [1]. > > > > The MAC address is accessible via the R

Re: [PATCH bpf-next v4] libbpf: add xsk_ring_prod__nb_free() function

2019-08-21 Thread Magnus Karlsson
On Wed, Aug 21, 2019 at 4:14 PM Magnus Karlsson wrote: > > On Wed, Aug 21, 2019 at 3:46 PM Eelco Chaudron wrote: > > > > > > > > On 21 Aug 2019, at 15:11, Magnus Karlsson wrote: > > > > > On Wed, Aug 14, 2019 at 3:51 PM Eelco Chaudron > > > wrote: > > >> > > >> When an AF_XDP application receive

Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action

2019-08-21 Thread Edward Cree
On 20/08/2019 19:35, Pablo Neira Ayuso wrote: > With one action that says "mangle an IPv6 at offset ip6 daddr field" > the driver has more global view on what is going on, rather than > having four actions to mangle four 32-bit words at some offset. But the action doesn't say that, it still says "m

Re: Help needed - Kernel lockup while running ipsec

2019-08-21 Thread Florian Westphal
Vakul Garg wrote: > > Policy refcount is decreasing properly on 4.19. > > Same should be on the latest kernel too. > > On kernel-4.14, I find dst_release() is getting called through > xfrm_output_one(). > However since dst->__refcnt gets decremented to '1', > the call_rcu(&dst->rcu_head, dst_de

Re: [PATCH 1/2] ipv4/icmp: fix rt dst dev null pointer dereference

2019-08-21 Thread Julian Anastasov
Hello, On Mon, 19 Aug 2019, Hangbin Liu wrote: > In __icmp_send() there is a possibility that the rt->dst.dev is NULL, > e,g, with tunnel collect_md mode, which will cause kernel crash. > Here is what the code path looks like, for GRE: > > - ip6gre_tunnel_xmit > - ip6gre_xmit_ipv4 >

Re: [PATCH bpf-next v2 2/4] selftests/bpf: test_progs: remove global fail/success counts

2019-08-21 Thread Stanislav Fomichev
On 08/21, Daniel Borkmann wrote: > On 8/19/19 9:17 PM, Stanislav Fomichev wrote: > > Now that we have a global per-test/per-environment state, there > > is no longer need to have global fail/success counters (and there > > is no need to save/get the diff before/after the test). > > Thanks for the

Re: [PATCH v2 net] gve: Copy and paste bug in gve_get_stats()

2019-08-21 Thread Catherine Sullivan
On Tue, Aug 20, 2019 at 2:11 AM Dan Carpenter wrote: > > There is a copy and paste error so we have "rx" where "tx" was intended > in the priv->tx[] array. > > Fixes: f5cedc84a30d ("gve: Add transmit and receive support") > Signed-off-by: Dan Carpenter > --- > v2: fix a typo in the subject: buy -

Re: [PATCH v2 3/4] bpf: clarify when bpf_trace_printk discards lines

2019-08-21 Thread Alexei Starovoitov
On Tue, Aug 20, 2019 at 5:04 PM Peter Wu wrote: > > On Tue, Aug 20, 2019 at 04:22:23PM -0700, Alexei Starovoitov wrote: > > On Wed, Aug 21, 2019 at 12:08:59AM +0100, Peter Wu wrote: > > > I opened /sys/kernel/tracing/trace once and kept reading from it. > > > bpf_trace_printk somehow did not seem

Re: net: micrel: confusion about phyids used in driver

2019-08-21 Thread Florian Fainelli
+Allan, On 8/20/19 1:25 PM, Uwe Kleine-König wrote: > Hello Nicolas, > > there are some open questions regarding details about some PHYs > supported in the drivers/net/phy/micrel.c driver. > > On Thu, Aug 08, 2019 at 10:36:37AM +0200, Uwe Kleine-König wrote: >> On Tue, Jul 02, 2019 at 08:55:07PM

Re: various TLS bug fixes...

2019-08-21 Thread Jakub Kicinski
On Tue, 20 Aug 2019 23:51:12 -0700, Jakub Kicinski wrote: > > If you have more details I can also spend some cycles looking into it. > > Awesome, I'll let you know what the details are as soon as I get them. Just a quick update on that. The test case is nginx running with ktls offload. The cl

mips32r2: nftables build warning: the frame size of 1168 bytes is larger than

2019-08-21 Thread René van Dorst
Hi Pablo, I have a building warning when compiling for a mips32r2 device. Using latest net-next tree. net/netfilter/nf_tables_offload.c: In function 'nft_flow_rule_create': net/netfilter/nf_tables_offload.c:73:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-t

Re: [PATCH 29/38] cls_flower: Convert handle_idr to XArray

2019-08-21 Thread Vlad Buslov
On Wed 21 Aug 2019 at 01:32, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Inline __fl_get() into fl_get(). Use the RCU lock explicitly for > lookups and walks instead of relying on RTNL. The xa_lock protects us, > but remains nested under the RTNL for now. > > Signed-off-by: Matt

Re: [PATCH 30/38] cls_flower: Use XArray list of filters in fl_walk

2019-08-21 Thread Vlad Buslov
On Wed 21 Aug 2019 at 01:32, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Instead of iterating over every filter attached to every mark, just > iterate over each filter. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > net/sched/cls_flower.c | 15 ++- > 1 file cha

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-21 Thread Jakub Kicinski
On Wed, 21 Aug 2019 17:49:33 +0900, Toshiaki Makita wrote: > > Having an implementation nor support a feature of another implementation > > and degrade gracefully to the slower one is not necessarily breakage. > > We need to make a concious decision here, hence the clarifying question. > > As I

Zdravstvujte! Vas interesujut klientskie bazy dannyh?

2019-08-21 Thread prodawez
Zdravstvujte! Vas interesujut klientskie bazy dannyh?

Re: net: micrel: confusion about phyids used in driver

2019-08-21 Thread allan.niel...@microchip.com
The 08/21/2019 10:24, Florian Fainelli wrote: > +Allan, > > On 8/20/19 1:25 PM, Uwe Kleine-König wrote: > > Hello Nicolas, > > > > there are some open questions regarding details about some PHYs > > supported in the drivers/net/phy/micrel.c driver. > > > > On Thu, Aug 08, 2019 at 10:36:37AM +020

Re: [PATCH 31/38] cls_flower: Use XArray marks instead of separate list

2019-08-21 Thread Vlad Buslov
On Wed 21 Aug 2019 at 01:32, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Remove the hw_filter list in favour of using one of the XArray mark > bits which lets us iterate more efficiently than walking a linked list. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > net/sched/c

Re: [PATCH bpf-next 0/2] tools: bpftool: work with frozen maps

2019-08-21 Thread Daniel Borkmann
On 8/21/19 10:52 AM, Quentin Monnet wrote: Hi, This is a simple set to add support for BPF map freezing to bpftool. First patch makes bpftool indicate if a map is frozen when listing BPF maps. Second patch adds a command to freeze a map loaded on the system. Quentin Monnet (2): tools: bpftool

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-21 Thread Alexei Starovoitov
On Tue, Aug 20, 2019 at 01:47:01PM +0200, Toke Høiland-Jørgensen wrote: > iproute2 uses its own bpf loader to load eBPF programs, which has > evolved separately from libbpf. Since we are now standardising on > libbpf, this becomes a problem as iproute2 is slowly accumulating > feature incompatibili

Re: [PATCH 33/38] act_api: Convert action_idr to XArray

2019-08-21 Thread Vlad Buslov
On Wed 21 Aug 2019 at 01:32, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Replace the mutex protecting the IDR with the XArray spinlock. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/net/act_api.h | 6 +- > net/sched/act_api.c | 127 +---

RE: net: micrel: confusion about phyids used in driver

2019-08-21 Thread Woojung.Huh
Hi Allan & Florian, > > > So we're in need of someone who can get their hands on some more > > > detailed documentation than publicly available to allow to make the > > > driver handle the KSZ8051MLL correctly without breaking other stuff. > > > > > > I assume you are in a different department of

Re: [PATCH net-next 0/7] mlxsw: Add devlink-trap support

2019-08-21 Thread David Miller
From: Ido Schimmel Date: Wed, 21 Aug 2019 10:19:30 +0300 > From: Ido Schimmel > > This patchset adds devlink-trap support in mlxsw. > > Patches #1-#4 add the necessary APIs and defines in mlxsw. > > Patch #5 implements devlink-trap support for layer 2 drops. More drops > will be added in the

Re: [PATCH] trivial: netns: fix typo in 'struct net.passive' description

2019-08-21 Thread David Miller
From: Mike Rapoport Date: Wed, 21 Aug 2019 14:29:29 +0300 > Replace 'decided' with 'decide' so that comment would be > > /* To decide when the network namespace should be freed. */ > > Signed-off-by: Mike Rapoport Applied.

[net-next 03/15] i40e: add check on i40e_configure_tx_ring() return value

2019-08-21 Thread Jeff Kirsher
From: huhai When i40e_configure_tx_ring(vsi->tx_rings[i]) returns an error, we should exit from i40e_vsi_configure_tx and return the error, instead of continuing to check whether xdp is enable, and configure the xdp transmit ring. Signed-off-by: huhai Tested-by: Andrew Bowers Signed-off-by: Je

[net-next 04/15] i40e: fix shifts of signed values

2019-08-21 Thread Jeff Kirsher
From: Beilei Xing This patch fixes following error reported by cppcheck: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour Signed-off-by: Beilei Xing Signed-off-by: Ferruh Yigit Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/i40e/i40e_re

[net-next 09/15] i40e: Update x722 FW API version to 1.9

2019-08-21 Thread Jeff Kirsher
From: Piotr Azarewicz Upcoming x722 FW increment API version to 1.9, so we must bump up version number as well. x722 will support PHY access AQ command as x710 does. Signed-off-by: Piotr Azarewicz Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_a

[net-next 11/15] i40e: Remove function i40e_update_dcb_config()

2019-08-21 Thread Jeff Kirsher
From: Grzegorz Siwik This patch removes function i40e_update_dcb_config(). Instead of i40e_update_dcb_config() we use i40e_init_dcb(), which implements the correct NVM read. Signed-off-by: Grzegorz Siwik Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e

[net-next 01/15] i40e: reduce stack usage in i40e_set_fc

2019-08-21 Thread Jeff Kirsher
From: Arnd Bergmann The functions i40e_aq_get_phy_abilities_resp() and i40e_set_fc() both have giant structure on the stack, which makes each one use stack frames larger than 500 bytes. As clang decides one function into the other, we get a warning for exceeding the frame size limit on 32-bit ar

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-21

2019-08-21 Thread Jeff Kirsher
This series contains updates to i40e driver only. Arnd Bergmann reduces the stack usage which was causing warnings on 32-bit architectures due to large structure sizes for 2 functions getting inlined, so use noinline_for_stack to prevent the compilers from combining the 2 functions. Mauro S. M. R

[net-next 07/15] i40e: Update x710 FW API version to 1.9

2019-08-21 Thread Jeff Kirsher
From: Piotr Azarewicz Upcoming x710 FW increment API version to 1.9 due to Extend PHY access AQ command support. SW is ready for that support as well. Signed-off-by: Piotr Azarewicz Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 2

[net-next 12/15] i40e: make i40e_set_mac_type() public

2019-08-21 Thread Jeff Kirsher
From: Piotr Kwapulinski Make i40e_set_mac_type() public. i40e driver requires i40e_set_mac_type() to be public. It is required for recovery mode handling. Without this patch recovery mode could not be detected in i40e_probe(). Signed-off-by: Piotr Kwapulinski Tested-by: Andrew Bowers Signed-of

[net-next 05/15] i40e: Add drop mode parameter to set mac config

2019-08-21 Thread Jeff Kirsher
From: Sylwia Wnuczko This patch adds "drop mode" parameter to set mac config AQ command. This bit controls the behavior when a no-drop packet is blocking a TC queue. 0 – The PF driver is notified. 1 – The blocking packet is dropped and then the PF driver is notified. Signed-off-by: Sylwia Wnuczk

[net-next 06/15] i40e: check_recovery_mode had wrong if statement

2019-08-21 Thread Jeff Kirsher
From: Adrian Podlawski Function check_recovery_mode had wrong if statement. Now we check proper FWS1B register values, which are responsible for the recovery mode. Recovery mode has 4 values for x710 and 2 for x722. That's why we need 6 different flags which are defined in the code. Now in the if

[net-next 02/15] i40e: Check if transceiver implements DDM before access

2019-08-21 Thread Jeff Kirsher
From: "Mauro S. M. Rodrigues" Similar to the ixgbe issue fixed in: 655c91414579 ("ixgbe: Check DDM existence in transceiver before access) i40e has the same issue when reading eeprom from SFP's module that comply with SFF-8472 but not implement the Digital Diagnostic Monitoring (DDM) interface d

[net-next 08/15] i40e: reset veb.tc_stats when resetting veb.stats

2019-08-21 Thread Jeff Kirsher
From: Jacob Keller The stats structure for the VEB switch statistics is reset periodically, but the tc_stats are not reset at the same time. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 1 file chang

[net-next 15/15] i40e: fix retrying in i40e_aq_get_phy_capabilities

2019-08-21 Thread Jeff Kirsher
From: Marcin Formela Fixed a bug where driver was breaking out of the loop and reporting an error without retrying first. Signed-off-by: Marcin Formela Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_common.c | 17 ++--- 1 file change

[net-next 10/15] i40e: Fix crash caused by stress setting of VF MAC addresses

2019-08-21 Thread Jeff Kirsher
From: Slawomir Laba Add update to the VSI pointer passed to the i40e_set_vf_mac function. If VF is in reset state the driver waits in i40e_set_vf_mac function for the reset to be complete, yet after reset the vsi pointer that was passed into this function is no longer valid. The patch updates lo

[net-next 13/15] i40e: allow reset in recovery mode

2019-08-21 Thread Jeff Kirsher
From: Piotr Kwapulinski Driver waits after issuing a reset. When a reset takes too long a driver gives up. Implemented by invoking PF reset in a loop. After defined number of unsuccessful PF reset trials it returns error. Without this patch PF reset fails when NIC is in recovery mode. Signed-off

[net-next 14/15] i40e: Persistent LLDP support

2019-08-21 Thread Jeff Kirsher
From: Sylwia Wnuczko This patch adds a function to read NVM module data and uses it to read current LLDP agent configuration from NVM API version 1.8. Signed-off-by: Sylwia Wnuczko Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_dcb.c| 18 ++

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-21 Thread Vladimir Oltean
Hi Richard, On Wed, 21 Aug 2019 at 17:08, Richard Cochran wrote: > > On Tue, Aug 20, 2019 at 09:38:45PM -0700, Richard Cochran wrote: > > Overall, the PTP switch use case is well supported by Linux. The > > synchronization of the management CPU to the PTP, while nice to have, > > is not required

Re: VRF notes when using ipv6 and flushing tables.

2019-08-21 Thread Ben Greear
On 08/20/2019 08:02 PM, David Ahern wrote: On 8/20/19 2:27 PM, Ben Greear wrote: I recently spend a few days debugging what in the end was user error on my part. Here are my notes in hope they help someone else. First, 'ip -6 route show vrf vrfX' will not show some of the routes (like local ro

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-21 Thread Andrii Nakryiko
On Tue, Aug 20, 2019 at 4:47 AM Toke Høiland-Jørgensen wrote: > > iproute2 uses its own bpf loader to load eBPF programs, which has > evolved separately from libbpf. Since we are now standardising on > libbpf, this becomes a problem as iproute2 is slowly accumulating > feature incompatibilities wi

Re: [PATCH 33/38] act_api: Convert action_idr to XArray

2019-08-21 Thread Matthew Wilcox
On Wed, Aug 21, 2019 at 07:41:19PM +, Vlad Buslov wrote: > > @@ -301,18 +292,18 @@ static int tcf_del_walker(struct tcf_idrinfo > > *idrinfo, struct sk_buff *skb, > > if (nla_put_string(skb, TCA_KIND, ops->kind)) > > goto nla_put_failure; > > > > - mutex_lock(&idrinfo->lock

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-21 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Tue, Aug 20, 2019 at 01:47:01PM +0200, Toke Høiland-Jørgensen wrote: >> iproute2 uses its own bpf loader to load eBPF programs, which has >> evolved separately from libbpf. Since we are now standardising on >> libbpf, this becomes a problem as iproute2 is slowly ac

Re: [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5

2019-08-21 Thread Andrew Lunn
On Wed, Aug 21, 2019 at 04:45:44PM +0200, René van Dorst wrote: > 1. net: dsa: mt7530: Convert to PHYLINK API >This patch converts mt7530 to PHYLINK API. > 2. dt-bindings: net: dsa: mt7530: Add support for port 5 > 3. net: dsa: mt7530: Add support for port 5 >These 2 patches adding support

[PATCH bpf] bpf: fix precision tracking in presence of bpf2bpf calls

2019-08-21 Thread Alexei Starovoitov
While adding extra tests for precision tracking and extra infra to adjust verifier heuristics the existing test "calls: cross frame pruning - liveness propagation" started to fail. The root cause is the same as described in verifer.c comment: * Also if parent's curframe > frame where backtracking

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-21 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Aug 20, 2019 at 4:47 AM Toke Høiland-Jørgensen > wrote: >> >> iproute2 uses its own bpf loader to load eBPF programs, which has >> evolved separately from libbpf. Since we are now standardising on >> libbpf, this becomes a problem as iproute2 is slowly accumula

Re: [PATCH 24/38] cls_u32: Convert tc_u_common->handle_idr to XArray

2019-08-21 Thread Jakub Kicinski
On Tue, 20 Aug 2019 15:32:45 -0700, Matthew Wilcox wrote: > @@ -305,8 +306,12 @@ static void *u32_get(struct tcf_proto *tp, u32 handle) > /* Protected by rtnl lock */ > static u32 gen_new_htid(struct tc_u_common *tp_c, struct tc_u_hnode *ptr) > { > - int id = idr_alloc_cyclic(&tp_c->handle_i

Re: [PATCH 24/38] cls_u32: Convert tc_u_common->handle_idr to XArray

2019-08-21 Thread Matthew Wilcox
On Wed, Aug 21, 2019 at 02:13:08PM -0700, Jakub Kicinski wrote: > On Tue, 20 Aug 2019 15:32:45 -0700, Matthew Wilcox wrote: > > @@ -305,8 +306,12 @@ static void *u32_get(struct tcf_proto *tp, u32 handle) > > /* Protected by rtnl lock */ > > static u32 gen_new_htid(struct tc_u_common *tp_c, struct

[PATCH] net/ncsi: Fix the payload copying for the request coming from Netlink

2019-08-21 Thread Justin.Lee1
The request coming from Netlink should use the OEM generic handler. The standard command handler expects payload in bytes/words/dwords but the actual payload is stored in data if the request is coming from Netlink. Signed-off-by: Justin Lee --- net/ncsi/ncsi-cmd.c | 11 +-- 1 file chan

Re: [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-21

2019-08-21 Thread Jakub Kicinski
On Wed, 21 Aug 2019 13:16:08 -0700, Jeff Kirsher wrote: > This series contains updates to i40e driver only. Patch 12 should really be squashed into 13, 7 and 9 could also be combined. But not a big deal, I guess.

Re: [PATCH 24/38] cls_u32: Convert tc_u_common->handle_idr to XArray

2019-08-21 Thread Jakub Kicinski
On Wed, 21 Aug 2019 14:25:42 -0700, Matthew Wilcox wrote: > On Wed, Aug 21, 2019 at 02:13:08PM -0700, Jakub Kicinski wrote: > > On Tue, 20 Aug 2019 15:32:45 -0700, Matthew Wilcox wrote: > > > @@ -305,8 +306,12 @@ static void *u32_get(struct tcf_proto *tp, u32 > > > handle) > > > /* Protected by

[PATCH ipsec-next 1/7] net: add queue argument to __skb_wait_for_more_packets and __skb_{,try_}recv_datagram

2019-08-21 Thread Sabrina Dubroca
This will be used by ESP over TCP to handle the queue of IKE messages. Signed-off-by: Sabrina Dubroca --- include/linux/skbuff.h | 11 --- net/core/datagram.c| 26 -- net/ipv4/udp.c | 3 ++- net/unix/af_unix.c | 7 --- 4 files changed, 30 ins

[PATCH ipsec-next 2/7] skbuff: Avoid sleeping in skb_send_sock_locked

2019-08-21 Thread Sabrina Dubroca
From: Herbert Xu For a function that needs to be called with the socket spinlock held, sleeping would seem to be a bad idea. This function does in fact avoid sleeping when calling kernel_sendpage_locked on the page part of the skb. However, it doesn't do that when sending the linear part. Resu

[PATCH ipsec-next 3/7] xfrm: introduce xfrm_trans_queue_net

2019-08-21 Thread Sabrina Dubroca
This will be used by TCP encapsulation to write packets to the encap socket without holding the user socket's lock. Without this reinjection, we're already holding the lock of the user socket, and then try to lock the encap socket as well when we enqueue the encrypted packet. While at it, add a BU

[PATCH ipsec-next 4/7] xfrm: add route lookup to xfrm4_rcv_encap

2019-08-21 Thread Sabrina Dubroca
At this point, with TCP encapsulation, the dst may be gone, but xfrm_input needs one. Signed-off-by: Sabrina Dubroca --- net/ipv4/xfrm4_protocol.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/ipv4/xfrm4_protocol.c b/net/ipv4/xfrm4_protocol.c index bcab48944c15..1665e1a05ec5 1

[PATCH ipsec-next 0/7] ipsec: add TCP encapsulation support (RFC 8229)

2019-08-21 Thread Sabrina Dubroca
This patchset introduces support for TCP encapsulation of IKE and ESP messages, as defined by RFC 8229 [0]. It is an evolution of what Herbert Xu proposed in January 2018 [1] that addresses the main criticism against it, by not interfering with the TCP implementation at all. The networking stack no

  1   2   >