On Tue, Aug 20, 2019 at 10:36:43PM +0300, Vladimir Oltean wrote: > On Tue, 20 Aug 2019 at 21:21, Mark Brown <broo...@kernel.org> wrote:
> > On Sun, Aug 18, 2019 at 09:25:56PM +0300, Vladimir Oltean wrote: > > > /* Extract head of queue */ > > > - ctlr->cur_msg = > > > - list_first_entry(&ctlr->queue, struct spi_message, queue); > > > + mesg = list_first_entry(&ctlr->queue, struct spi_message, queue); > > > + ctlr->cur_msg = mesg; > > Why mesg when the existing code uses msg as an abbreviation here? > Does it matter? I took from spi_finalize_current_message which also uses mesg. It's particularly visible when it's on the same line, flags up a question about if things are the same. Other things not being great doesn't preclude making this one better.
signature.asc
Description: PGP signature
