Re: [PATCH rdma-next 0/2] DEVX VHCA tunnel support

2019-07-07 Thread Leon Romanovsky
On Fri, Jul 05, 2019 at 02:40:07PM -0300, Jason Gunthorpe wrote: > On Mon, Jul 01, 2019 at 09:14:00PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi, > > > > Those two patches introduce VHCA tunnel mechanism to DEVX interface > > needed for Bluefield SOC. See extensive commit m

[PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Users have several ways to debug the kernel and understand why a packet was dropped. For example, using "drop monitor" and "perf". Both utilities trace kfree_skb(), which is the function called when a packet is freed as part of a failure. The information provided by these tools

[PATCH net-next 03/11] devlink: Add generic packet traps and groups

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Add generic packet traps and groups that can report dropped packets as well as exceptions such as TTL error. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- include/net/devlink.h | 40 net/core/devlink.c| 12 2

[PATCH net-next 08/11] mlxsw: reg: Add new trap action

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Subsequent patches will add discard traps support in mlxsw. The driver cannot configure such traps with a normal trap action, but need to use exception trap action, which also increments an error counter. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethe

[PATCH net-next 09/11] mlxsw: Add layer 2 discard trap IDs

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Add the trap IDs used to report layer 2 drops. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/trap.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/trap.h b/drivers/net/ethernet/mella

[PATCH net-next 07/11] mlxsw: core: Add API to set trap action

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Up until now the action of a trap was never changed during its lifetime. This is going to change by subsequent patches that will allow devlink to control the action of certain traps. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/co

[PATCH net-next 02/11] devlink: Add packet trap infrastructure

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Add the basic packet trap infrastructure that allows device drivers to register their supported packet traps and trap groups with devlink. Each driver is expected to provide basic information about each supported trap, such as name and ID, but also the supported metadata types

[PATCH net-next 01/11] devlink: Create helper to fill port type information

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel The function that fills port attributes in a netlink message fills the port type attributes together with other attributes such as the device handle. The port type attributes will also need to be filled for trapped packets by a subsequent patch. Prevent code duplication and c

[PATCH net-next 04/11] Documentation: Add devlink-trap documentation

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Add initial documentation of the devlink-trap mechanism, explaining the background, motivation and the semantics of the interface. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- Documentation/networking/devlink-trap.rst | 179 ++ Documentation/netw

[PATCH net-next 05/11] netdevsim: Add devlink-trap support

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Have netdevsim register its trap groups and traps with devlink during initialization and periodically report trapped packets to devlink core. Since netdevsim is not a real device, the trapped packets are emulated using a workqueue that periodically reports a UDP packet with a

[PATCH net-next 11/11] mlxsw: spectrum: Add devlink-trap support

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Register supported packet traps (layer 2 drops only, currently) and associated trap group with devlink during driver initialization. The code is placed in a new file (spectrum_trap.c) to which the existing packet traps will be moved to once they are exposed via devlink. The am

[PATCH net-next 10/11] mlxsw: Add trap group for layer 2 discards

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Discard trap groups are defined in a different enum so that they could all share the same policer ID: MLXSW_REG_HTGT_TRAP_GROUP_MAX + 1. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 8 1 file changed, 8 insertions

[PATCH net-next 06/11] Documentation: Add description of netdevsim traps

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- .../networking/devlink-trap-netdevsim.rst | 20 +++ Documentation/networking/devlink-trap.rst | 11 ++ Documentation/networking/index.rst| 1 + drivers/net/netdevsim/dev.c

[PATCH iproute2-next 0/7] Add devlink-trap support

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel This patchset adds devlink-trap support in iproute2. Patch #1 increases the number of options devlink can handle. Patches #2-#4 gradually add support for all devlink-trap commands. Patches #5-#6 perform small tweaks in devlink code. Patch #7 adds a man page for devlink-trap

[PATCH iproute2-next 4/7] devlink: Add devlink trap monitor support

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel According to the reporting state of individual traps, a notification is sent to user space about each trapped packet. Allow the user to monitor such events by having iproute2 subscribe to the 'DEVLINK_GENL_MCGRP_TRAP_NAME' group. An error is not returned in case subscription fa

[PATCH iproute2-next 6/7] devlink: Add fflush() to print functions

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Similar to commit 09e0528cf977 ("ip: mroute: add fflush to print_mroute"), we need to add fflush() to the print functions to get the following to work: # devlink mon &> log Without it, stdout output is buffered and not written to the disk. This is useful when writing tests t

[PATCH iproute2-next 1/7] devlink: Increase number of supported options

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Currently, the number of supported options is capped at 32 which is a problem given we are about to add a few more and go over the limit. Increase the limit to 64 options. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- devlink/devlink.c | 24

[PATCH iproute2-next 7/7] devlink: Add man page for devlink-trap

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- man/man8/devlink-monitor.8 | 3 +- man/man8/devlink-trap.8| 166 + man/man8/devlink.8 | 11 ++- 3 files changed, 178 insertions(+), 2 deletions(-) create mode 100644 man/

[PATCH iproute2-next 5/7] devlink: Set NETLINK_NO_ENOBUFS when monitoring events

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel If we lost an event, there is nothing we can do in order to recover it. Set above mentioned socket option on the netlink socket when monitoring devlink events, so that `devlink monitor` will not abort in case we are not draining the receive buffer fast enough. The number of ev

[PATCH iproute2-next 2/7] devlink: Add devlink trap set and show commands

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel The trap set command allows the user to set the action and reporting state of an individual trap. Example: # devlink trap set netdevsim/netdevsim10 trap blackhole_route action trap report true The trap show command allows the user to get the current status of an individual t

[PATCH iproute2-next 3/7] devlink: Add devlink trap group set and show commands

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel These commands are similar to the trap set and show commands, but operate on a trap group and not individual traps. Example: # devlink trap group set netdevsim/netdevsim10 group l3_drops action trap report true # devlink -jps trap group show netdevsim/netdevsim10 group l3_dro

[PATCH net-next v4 0/4] net/sched: Introduce tc connection tracking

2019-07-07 Thread Paul Blakey
Hi, This patch series add connection tracking capabilities in tc sw datapath. It does so via a new tc action, called act_ct, and new tc flower classifier matching on conntrack state, mark and label. Usage is as follows: $ tc qdisc add dev ens1f0_0 ingress $ tc qdisc add dev ens1f0_1 ingress $ t

[PATCH net-next v4 3/4] net/sched: cls_flower: Add matching on conntrack info

2019-07-07 Thread Paul Blakey
New matches for conntrack mark, label, zone, and state. Signed-off-by: Paul Blakey Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: Yossi Kuperman Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 16 ++ net/sched/cls_flower.c | 127 ++

[PATCH net-next v4 2/4] net/flow_dissector: add connection tracking dissection

2019-07-07 Thread Paul Blakey
Retreives connection tracking zone, mark, label, and state from a SKB. Signed-off-by: Paul Blakey Signed-off-by: Marcelo Ricardo Leitner Acked-by: Jiri Pirko --- include/linux/skbuff.h | 10 ++ include/net/flow_dissector.h | 15 +++ net/core/flow_dissector.c| 44 +

[RFC PATCH net-next 2/5] Documentation: Add a section for devlink-trap testing

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Signed-off-by: Ido Schimmel --- Documentation/networking/devlink-trap.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/networking/devlink-trap.rst b/Documentation/networking/devlink-trap.rst index 906cdeb0d1f3..b29aac6fe5fd 100644 --- a/Document

[RFC PATCH net-next 0/5] selftests: Add devlink-trap selftests

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Patch #1 adds test cases for the generic devlink-trap infrastructure over netdevsim. Patch #2 mentions the previous patch in the devlink-trap documentation. This is meant to serve as a reminder for people to add test cases when the infrastructure is extended. Patches #3-#5 ad

[RFC PATCH net-next 1/5] selftests: devlink_trap: Add test cases for devlink-trap

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Add test cases for devlink-trap on top of the netdevsim implementation. The tests focus on the devlink-trap core infrastructure and user space API. They test both good and bad flows and also dismantle of the netdev and devlink device used to report trapped packets. This allow

[PATCH net-next v4 1/4] net/sched: Introduce action ct

2019-07-07 Thread Paul Blakey
Allow sending a packet to conntrack module for connection tracking. The packet will be marked with conntrack connection's state, and any metadata such as conntrack mark and label. This state metadata can later be matched against with tc classifers, for example with the flower classifier as below.

[PATCH net-next v4 4/4] tc-tests: Add tc action ct tests

2019-07-07 Thread Paul Blakey
Add 13 tests ensuring the command line is doing what is supposed to do. Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: Marcelo Ricardo Leitner --- .../selftests/tc-testing/tc-tests/actions/ct.json | 314 + 1 file changed, 314 insertions(+) create mode 100644 tools/t

Re: [PATCH 1/2] proc: revalidate directories created with proc_net_mkdir()

2019-07-07 Thread Alexey Dobriyan
On Sun, Jul 07, 2019 at 02:03:20AM +0100, Al Viro wrote: > On Sat, Jul 06, 2019 at 07:52:02PM +0300, Alexey Dobriyan wrote: > > +struct proc_dir_entry *_proc_mkdir(const char *name, umode_t mode, > > + struct proc_dir_entry **parent, void *data) > > Two underscor

[RFC PATCH net-next 5/5] selftests: mlxsw: Add a test case for devlink-trap

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Test generic devlink-trap functionality over mlxsw. These tests are not specific to a single trap, but do not check the devlink-trap common infrastructure either. Currently, the only test case is device deletion (by reloading the driver) while packets are being trapped. Signe

[RFC PATCH net-next 3/5] selftests: forwarding: devlink_lib: Add devlink-trap helpers

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Add helpers to interact with devlink-trap, such as setting the action of a trap and retrieving statistics. Signed-off-by: Ido Schimmel --- .../selftests/net/forwarding/devlink_lib.sh | 125 ++ 1 file changed, 125 insertions(+) diff --git a/tools/testing/se

[RFC PATCH net-next 4/5] selftests: mlxsw: Add test cases for devlink-trap L2 drops

2019-07-07 Thread Ido Schimmel
From: Ido Schimmel Test that each supported packet trap is triggered under the right conditions and that packets are indeed dropped and not forwarded. Signed-off-by: Ido Schimmel --- .../net/mlxsw/devlink_trap_l2_drops.sh| 487 ++ 1 file changed, 487 insertions(+) crea

pull request: bluetooth-next 2019-07-07

2019-07-07 Thread Johan Hedberg
Hi Dave, Here's the main bluetooth-next pull request for 5.3: - Added support for new devices from Qualcomm, Realtek and Broadcom and MediaTek - Various fixes to 6LoWPAN - Fix L2CAP PSM namespace separation for LE & BR/EDR - Fix behavior with Microsoft Surface Precision Mouse - Added supp

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-07 Thread Ido Schimmel
More info that I did not want to put in the cover letter: Wrote a Wireshark dissector [1] for devlink packets. It dissects various devlink packets and is especially useful for trap report packets. Both the metadata about the trapped packet (e.g., trap reason) and also the trapped Ethernet packet i

[PATCH net-next iproute2 1/3] tc: add NLA_F_NESTED flag to all actions options nested block

2019-07-07 Thread Paul Blakey
Strict netlink validation now requires this flag on all nested attributes, add it for action options. Signed-off-by: Paul Blakey --- tc/m_action.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tc/m_action.c b/tc/m_action.c index ab6bc0a..2d36a69 100644 --- a/tc/m_action.c

[PATCH net-next iproute2 3/3] tc: flower: Add matching on conntrack info

2019-07-07 Thread Paul Blakey
Matches on conntrack state, zone, mark, and label. Signed-off-by: Paul Blakey Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: Yossi Kuperman Acked-by: Jiri Pirko Acked-by: Roi Dayan --- include/uapi/linux/pkt_cls.h | 17 +++ man/man8/tc-flower.8 | 35 ++ tc/f_flower.c

[PATCH net-next iproute2 2/3] tc: Introduce tc ct action

2019-07-07 Thread Paul Blakey
New tc action to send packets to conntrack module, commit them, and set a zone, labels, mark, and nat on the connection. It can also clear the packet's conntrack state by using clear. Usage: ct clear ct commit [force] [zone] [mark] [label] [nat] ct [nat] [zone] Signed-off-by: Paul Blake

[PATCH net-next iproute2 0/3] net/sched: Introduce tc connection tracking

2019-07-07 Thread Paul Blakey
Hi, This patch series add connection tracking capabilities in tc. It does so via a new tc action, called act_ct, and new tc flower classifier matching. Act ct and relevant flower matches, are still under review in net-next mailing list. Usage is as follows: $ tc qdisc add dev ens1f0_0 ingress $

[PATCH net-next] ipv6: elide flowlabel check if no exclusive leases exist

2019-07-07 Thread Willem de Bruijn
From: Willem de Bruijn Processes can request ipv6 flowlabels with cmsg IPV6_FLOWINFO. If not set, by default an autogenerated flowlabel is selected. Explicit flowlabels require a control operation per label plus a datapath check on every connection (every datagram if unconnected). This is partic

[PATCH net-next v2] skbuff: increase verbosity when dumping skb data

2019-07-07 Thread Willem de Bruijn
From: Willem de Bruijn skb_warn_bad_offload and netdev_rx_csum_fault trigger on hard to debug issues. Dump more state and the header. Optionally dump the entire packet and linear segment. This is required to debug checksum bugs that may include bytes past skb_tail_pointer(). Both call sites cal

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-07-07 Thread Ido Schimmel
On Fri, Jul 05, 2019 at 12:01:49PM -0400, Vivien Didelot wrote: > Hi Ido, > > On Sun, 23 Jun 2019 07:09:52 +, Ido Schimmel wrote: > > > Russell, Ido, Florian, so far I understand that a multicast-unaware > > > bridge must flood unknown traffic everywhere (CPU included); > > > and a multicast-

[PATCH net-next 01/16] Revert "net/mlx5e: Fix mlx5e_tx_reporter_create return value"

2019-07-07 Thread Tariq Toukan
From: Aya Levin This reverts commit 2e5b0534622fa87fd570d54af2d01ce304b88077. This commit was needed prior to commit f6b19b354d50 ("net: devlink: select NET_DEVLINK from drivers") Then, reporter's pointer could have been a NULL. But with NET_DEVLINK mandatory to MLX5_CORE in Kconfig, pointer can

[PATCH net-next 08/16] net/mlx5e: Extend tx diagnose function

2019-07-07 Thread Tariq Toukan
From: Aya Levin The following patches in the set enhance the diagnostics info of tx reporter. Therefore, it is better to pass a pointer to the SQ for further data extraction. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 20 +++

[PATCH net-next 10/16] net/mlx5e: Add cq info to tx reporter diagnose

2019-07-07 Thread Tariq Toukan
From: Aya Levin Add cq information to general diagnose output: CQ size and stride size. Per SQ add information about the related CQ: cqn and CQ's HW status. $ devlink health diagnose pci/:00:0b.0 reporter tx Common config: SQ: stride size: 64 size: 1024 CQ: stride size: 64 size: 1024

[PATCH net-next 09/16] net/mlx5e: Extend tx reporter diagnostics output

2019-07-07 Thread Tariq Toukan
From: Aya Levin Enhance tx reporter's diagnostics output to include: information common to all SQs: SQ size, SQ stride size. In addition add channel ix, cc and pc. $ devlink health diagnose pci/:00:0b.0 reporter tx Common config: SQ: stride size: 64 size: 1024 SQs: channel ix: 0 sqn:

[PATCH net-next 04/16] net/mlx5e: TX reporter cleanup

2019-07-07 Thread Tariq Toukan
From: Aya Levin Remove redundant include file. Signed-off-by: Aya Levin Acked-by: Jiri Pirko Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b

[PATCH net-next 13/16] net/mlx5e: Recover from CQE error on ICOSQ

2019-07-07 Thread Tariq Toukan
From: Aya Levin Add support for recovery from error on completion on ICOSQ. Deactivate RQ and flush, then deactivate ICOSQ. Set the queue back to ready state (firmware) and reset the ICOSQ and the RQ (software resources). Finally, activate the ICOSQ and the RQ. Signed-off-by: Aya Levin Signed-o

[PATCH net-next 00/16] mlx5e devlink health reporters

2019-07-07 Thread Tariq Toukan
Hi Dave, I'm submitting this series myself as Saeed is on vacation. This series from Aya to the mlx5e driver introduces changes in devlink health reporters. Most noticeable is adding a new reporter, RX reporter, which reports and recovers from timeout and completion errors in the receive path. I

[PATCH net-next 05/16] net/mlx5e: Rename reporter header file

2019-07-07 Thread Tariq Toukan
From: Aya Levin Rename reporter.h -> health.h so patches in the set can use it for health related functionality. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en/health.h | 15 +++ drivers/net/ethernet/mellanox/mlx5/core/en/r

[PATCH net-next 07/16] net/mlx5e: Generalize tx reporter's functionality

2019-07-07 Thread Tariq Toukan
From: Aya Levin Prepare for code sharing with rx reporter, which is added in the following patches in the set. Introduce a generic error_ctx for agnostic recovery despatch. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/Makefile | 5 +- ..

[PATCH net-next 11/16] net/mlx5e: Add support to rx reporter diagnose

2019-07-07 Thread Tariq Toukan
From: Aya Levin Add rx reporter, which supports diagnose call-back. Diagnostics output include: information common to all RQs: RQ type, RQ size, RQ stride size, CQ size and CQ stride size. In addition advertise information per RQ and its related icosq and attached CQ. $ devlink health diagnose p

[PATCH net-next 06/16] net/mlx5e: Change naming convention for reporter's functions

2019-07-07 Thread Tariq Toukan
From: Aya Levin Change from mlx5e_tx_reporter_* to mlx5e_reporter_tx_*. In the following patches in the set rx reporter is added, the new naming convention is more uniformed. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en/health.h | 8

[PATCH net-next 14/16] net/mlx5e: Recover from rx timeout

2019-07-07 Thread Tariq Toukan
From: Aya Levin Add support for recovery from rx timeout. On driver open we post NOP work request on the rx channels to trigger napi in order to fillup the rx rings. In case napi wasn't scheduled due to a lost interrupt, perform EQ recovery. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan

[PATCH net-next 03/16] net/mlx5e: Set tx reporter only on successful creation

2019-07-07 Thread Tariq Toukan
From: Aya Levin When failing to create tx reporter, don't set the reporter's pointer. Creating a reporter is not mandatory for driver load, avoid garbage/error pointer. Signed-off-by: Aya Levin Acked-by: Jiri Pirko Signed-off-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/en/report

[PATCH net-next 12/16] net/mlx5e: Split open/close ICOSQ into stages

2019-07-07 Thread Tariq Toukan
From: Aya Levin Align ICOSQ open/close behaviour with RQ and SQ. Split open flow into open and activate where open handles creation and activate enables the queue. Do a symmetric thing in close flow: split into close and deactivate. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan --- dri

[PATCH net-next 02/16] net/mlx5e: Fix error flow in tx reporter diagnose

2019-07-07 Thread Tariq Toukan
From: Aya Levin Fix tx reporter's diagnose call back. Propagate error when failing to gather diagnostics information or failing to print diagnostic data per queue. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 4 ++-- 1 fil

[PATCH net-next 15/16] net/mlx5e: RX, Handle CQE with error at the earliest stage

2019-07-07 Thread Tariq Toukan
From: Saeed Mahameed Just to be aligned with the MPWQE handlers, handle RX WQE with error for legacy RQs in the top RX handlers, just before calling skb_from_cqe(). CQE error handling will now be called at the same stage regardless of the RQ type or netdev mode NIC, Representor, IPoIB, etc .. T

[PATCH net-next 16/16] net/mlx5e: Recover from CQE with error on RQ

2019-07-07 Thread Tariq Toukan
From: Aya Levin Add support for recovery from error on completion on RQ by setting the queue back to ready state. Handle only errors with a syndrome indicating the RQ might enter error state and could be recovered. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan --- drivers/net/ethernet/

[PATCH net-next] r8169: sync few chip names with vendor driver

2019-07-07 Thread Heiner Kallweit
This patch syncs the name of few chip versions with the latest vendor driver version. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/

Re: [PATCH net-next v4 1/4] net/sched: Introduce action ct

2019-07-07 Thread Florian Westphal
Paul Blakey wrote: > +/* Determine whether skb->_nfct is equal to the result of conntrack lookup. > */ > +static bool tcf_ct_skb_nfct_cached(struct net *net, struct sk_buff *skb, > +u16 zone_id, bool force) > +{ > + enum ip_conntrack_info ctinfo; > + struct

Re: More complex PBR rules

2019-07-07 Thread David Ahern
On 7/6/19 5:06 PM, Markus Moeller wrote: > Hi Network developers > > I am new to this group and wonder if you can advise how I could > implement more complex PBR rules to achieve for example load balancing. > The requirement I have is to route based on e.g. a hash like: > >  hash(src-ip+dst-ip) m

[PATCH net-next v7 5/5] tc-tests: actions: add MPLS tests

2019-07-07 Thread John Hurley
Add a new series of selftests to verify the functionality of act_mpls in TC. Signed-off-by: John Hurley Reviewed-by: Simon Horman Acked-by: Jakub Kicinski --- tools/testing/selftests/tc-testing/config |1 + .../tc-testing/tc-tests/actions/mpls.json | 1088

[PATCH net-next v7 0/5] Add MPLS actions to TC

2019-07-07 Thread John Hurley
This patchset introduces a new TC action module that allows the manipulation of the MPLS headers of packets. The code impliments functionality including push, pop, and modify. Also included are tests for the new funtionality. Note that these will require iproute2 changes to be submitted soon. NOT

[PATCH net-next v7 1/5] net: core: move push MPLS functionality from OvS to core helper

2019-07-07 Thread John Hurley
Open vSwitch provides code to push an MPLS header to a packet. In preparation for supporting this in TC, move the push code to an skb helper that can be reused. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Willem de Bruijn Acked-by: Cong Wang -

[PATCH net-next v7 3/5] net: core: add MPLS update core helper and use in OvS

2019-07-07 Thread John Hurley
Open vSwitch allows the updating of an existing MPLS header on a packet. In preparation for supporting similar functionality in TC, move this to a common skb helper function. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Willem de Bruijn Acked-by

[PATCH net-next v7 4/5] net: sched: add mpls manipulation actions to TC

2019-07-07 Thread John Hurley
Currently, TC offers the ability to match on the MPLS fields of a packet through the use of the flow_dissector_key_mpls struct. However, as yet, TC actions do not allow the modification or manipulation of such fields. Add a new module that registers TC action ops to allow manipulation of MPLS. Thi

[PATCH net-next v7 2/5] net: core: move pop MPLS functionality from OvS to core helper

2019-07-07 Thread John Hurley
Open vSwitch provides code to pop an MPLS header to a packet. In preparation for supporting this in TC, move the pop code to an skb helper that can be reused. Remove the, now unused, update_ethertype static function from OvS. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Reviewed-by: S

Re: [PATCH iproute2-next] ip: bond: add peer notification delay support

2019-07-07 Thread Stephen Hemminger
On Sat, 6 Jul 2019 23:11:45 +0200 Vincent Bernat wrote: > Ability to tweak the delay between gratuitous ND/ARP packets has been > added in kernel commit 07a4ddec3ce9 ("bonding: add an option to > specify a delay between peer notifications"), through > IFLA_BOND_PEER_NOTIF_DELAY attribute. Add su

[RFC PATCH net-next 0/6] tc-taprio offload for SJA1105 DSA

2019-07-07 Thread Vladimir Oltean
Using Vinicius Costa Gomes' configuration interface for 802.1Qbv (later resent by Voon Weifeng for the stmmac driver), I am submitting for review a draft implementation of this offload for a DSA switch. I don't want to insist too much on the hardware specifics of SJA1105 which isn't otherwise very

[RFC PATCH net-next 1/6] Revert "Merge branch 'net-sched-Add-txtime-assist-support-for-taprio'"

2019-07-07 Thread Vladimir Oltean
This reverts commit 0a7960c798ca975ca4c5595e5539fc8f8b79, reversing changes made to 8747d82d3c32df488ea0fe9b86bdb53a8a04a7b8. This returns the tc-taprio state to where it was when Voon Weifeng had resent Vinicius Costa Gomes 's patch "taprio: Add support for hardware offloading" (also resent

[RFC PATCH net-next 3/6] net: dsa: Pass tc-taprio offload to drivers

2019-07-07 Thread Vladimir Oltean
tc-taprio is a qdisc based on the enhancements for scheduled traffic specified in IEEE 802.1Qbv (later merged in 802.1Q). This qdisc has a software implementation and an optional offload through which compatible Ethernet ports may configure their egress 802.1Qbv schedulers. Signed-off-by: Vladimi

[RFC PATCH net-next 6/6] net: dsa: sja1105: Configure the Time-Aware Shaper via tc-taprio offload

2019-07-07 Thread Vladimir Oltean
This qdisc offload is the closest thing to what the SJA1105 supports in hardware for time-based egress shaping. The switch core really is built around SAE AS6802/TTEthernet (a TTTech standard) but can be made to operate similarly to IEEE 802.1Qbv with some constraints: - The gate control list is a

[RFC PATCH net-next 5/6] net: dsa: sja1105: Advertise the 8 TX queues

2019-07-07 Thread Vladimir Oltean
This is a preparation patch for the tc-taprio offload (and potentially for other future offloads such as tc-mqprio). Instead of looking directly at skb->priority during xmit, let's get the netdev queue and the queue-to-traffic-class mapping, and put the resulting traffic class into the dsa_8021q P

[RFC PATCH net-next 2/6] taprio: Add support for hardware offloading

2019-07-07 Thread Vladimir Oltean
From: Vinicius Costa Gomes This allows taprio to offload the schedule enforcement to capable network cards, resulting in more precise windows and less CPU usage. The important detail here is the difference between the gate_mask in taprio and gate_mask for the network driver. For the driver, each

[RFC PATCH net-next 4/6] net: dsa: sja1105: Add static config tables for scheduling

2019-07-07 Thread Vladimir Oltean
In order to support tc-taprio offload, the TTEthernet egress scheduling core registers must be made visible through the static interface. Signed-off-by: Vladimir Oltean --- .../net/dsa/sja1105/sja1105_dynamic_config.c | 8 + .../net/dsa/sja1105/sja1105_static_config.c | 167

Re: [RFC PATCH net-next 2/6] taprio: Add support for hardware offloading

2019-07-07 Thread Andrew Lunn
On Sun, Jul 07, 2019 at 08:29:17PM +0300, Vladimir Oltean wrote: > From: Vinicius Costa Gomes > > This allows taprio to offload the schedule enforcement to capable > network cards, resulting in more precise windows and less CPU usage. > > The important detail here is the difference between the g

Re: [RFC PATCH net-next 0/6] tc-taprio offload for SJA1105 DSA

2019-07-07 Thread Andrew Lunn
> - Configuring the switch over SPI cannot apparently be done from this > ndo_setup_tc callback because it runs in atomic context. I also have > some downstream patches to offload tc clsact matchall with mirred > action, but in that case it looks like the atomic context restriction > does n

[PATCH iproute2-next] ip: bond: add peer notification delay support

2019-07-07 Thread Vincent Bernat
Ability to tweak the delay between gratuitous ND/ARP packets has been added in kernel commit 07a4ddec3ce9 ("bonding: add an option to specify a delay between peer notifications"), through IFLA_BOND_PEER_NOTIF_DELAY attribute. Add support to set and show this value. Example: $ ip -d link set b

Re: [PATCH iproute2-next] ip: bond: add peer notification delay support

2019-07-07 Thread Stephen Hemminger
On Sun, 7 Jul 2019 19:51:15 +0200 Vincent Bernat wrote: > Ability to tweak the delay between gratuitous ND/ARP packets has been > added in kernel commit 07a4ddec3ce9 ("bonding: add an option to > specify a delay between peer notifications"), through > IFLA_BOND_PEER_NOTIF_DELAY attribute. Add su

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-07 Thread David Miller
From: Ido Schimmel Date: Sun, 7 Jul 2019 10:58:17 +0300 > Users have several ways to debug the kernel and understand why a packet > was dropped. For example, using "drop monitor" and "perf". Both > utilities trace kfree_skb(), which is the function called when a packet > is freed as part of a fa

Re: [PATCH net-next v4 1/4] devlink: Refactor physical port attributes

2019-07-07 Thread Jiri Pirko
Sat, Jul 06, 2019 at 08:23:47PM CEST, pa...@mellanox.com wrote: >To support additional devlink port flavours and to support few common >and few different port attributes, make following changes. > >1. Move physical port attributes to a different structure >2. Return such attritubes in netlink respo

Re: [PATCH net-next v4 2/4] devlink: Introduce PCI PF port flavour and port attribute

2019-07-07 Thread Jiri Pirko
Sat, Jul 06, 2019 at 08:23:48PM CEST, pa...@mellanox.com wrote: >In an eswitch, PCI PF may have port which is normally represented >using a representor netdevice. >To have better visibility of eswitch port, its association with >PF and a representor netdevice, introduce a PCI PF port >flavour and p

Re: [PATCH net-next v4 3/4] devlink: Introduce PCI VF port flavour and port attribute

2019-07-07 Thread Jiri Pirko
Sat, Jul 06, 2019 at 08:23:49PM CEST, pa...@mellanox.com wrote: >In an eswitch, PCI VF may have port which is normally represented using >a representor netdevice. >To have better visibility of eswitch port, its association with VF, >and its representor netdevice, introduce a PCI VF port flavour. >

Re: [PATCH 1/2] proc: revalidate directories created with proc_net_mkdir()

2019-07-07 Thread David Miller
From: Alexey Dobriyan Date: Sun, 7 Jul 2019 11:03:51 +0300 > On Sun, Jul 07, 2019 at 02:03:20AM +0100, Al Viro wrote: >> On Sat, Jul 06, 2019 at 07:52:02PM +0300, Alexey Dobriyan wrote: >> > +struct proc_dir_entry *_proc_mkdir(const char *name, umode_t mode, >> > + str

Re: [PATCH net-next v4 4/4] net/mlx5e: Register devlink ports for physical link, PCI PF, VFs

2019-07-07 Thread Jiri Pirko
Sat, Jul 06, 2019 at 08:23:50PM CEST, pa...@mellanox.com wrote: >Register devlink port of physical port, PCI PF and PCI VF flavour >for each PF, VF when a given devlink instance is in switchdev mode. > >Implement ndo_get_devlink_port callback API to make use of registered >devlink ports. >This elim

Re: pull request: bluetooth-next 2019-07-07

2019-07-07 Thread David Miller
From: Johan Hedberg Date: Sun, 7 Jul 2019 11:07:49 +0300 > Here's the main bluetooth-next pull request for 5.3: > > - Added support for new devices from Qualcomm, Realtek and Broadcom and >MediaTek > - Various fixes to 6LoWPAN > - Fix L2CAP PSM namespace separation for LE & BR/EDR > - Fi

Re: [PATCH net-next] r8169: sync few chip names with vendor driver

2019-07-07 Thread David Miller
From: Heiner Kallweit Date: Sun, 7 Jul 2019 13:59:54 +0200 > This patch syncs the name of few chip versions with the latest vendor > driver version. > > Signed-off-by: Heiner Kallweit Applied, thanks.

Re: [PATCH iproute2-next] ip: bond: add peer notification delay support

2019-07-07 Thread Vincent Bernat
❦ 7 juillet 2019 11:40 -07, Stephen Hemminger : > Looks good. I notice that all these flags don't show up in any man > page. Yes, "bond type" is not described at all in the manual page. I'll come with a patch. -- Your manuscript is both good and original, but the part that is good is not origi

Re: [PATCH net-next] tipc: use rcu dereference functions properly

2019-07-07 Thread David Miller
From: David Miller Date: Sat, 06 Jul 2019 15:15:44 -0700 (PDT) > From: Xin Long > Date: Sat, 6 Jul 2019 14:48:48 +0800 > >> Hi, David, I saw this patch in "Changes Requested". > > I just put it back to Under Review, thanks. Applied to net-next, thank you.

Re: [RFC PATCH net-next 2/6] taprio: Add support for hardware offloading

2019-07-07 Thread Vladimir Oltean
On Sun, 7 Jul 2019 at 20:39, Andrew Lunn wrote: > > On Sun, Jul 07, 2019 at 08:29:17PM +0300, Vladimir Oltean wrote: > > From: Vinicius Costa Gomes > > > > This allows taprio to offload the schedule enforcement to capable > > network cards, resulting in more precise windows and less CPU usage. >

Re: [RFC PATCH net-next 0/6] tc-taprio offload for SJA1105 DSA

2019-07-07 Thread Vladimir Oltean
On Sun, 7 Jul 2019 at 20:47, Andrew Lunn wrote: > > > - Configuring the switch over SPI cannot apparently be done from this > > ndo_setup_tc callback because it runs in atomic context. I also have > > some downstream patches to offload tc clsact matchall with mirred > > action, but in that c

Re: [PATCH net 0/2] net/tls: fix poll() wake up

2019-07-07 Thread David Miller
From: Jakub Kicinski Date: Thu, 4 Jul 2019 14:50:35 -0700 > This small fix + selftest series is very similar to the previous > commit 04b25a5411f9 ("net/tls: fix no wakeup on partial reads"). > This time instead of recvmsg we're fixing poll wake up. Series applied and patch #1 queued up for -st

[PATCH] phy: added a PHY_BUSY state into phy_state_machine

2019-07-07 Thread kwangdo.yi
When mdio driver polling the phy state in the phy_state_machine, sometimes it results in -ETIMEDOUT and link is down. But the phy is still alive and just didn't meet the polling deadline. Closing the phy link in this case seems too radical. Failing to meet the deadline happens very rarely. When s

Re: More complex PBR rules

2019-07-07 Thread Markus Moeller
Hi David, I read up about multipath routing and ecmp. It seems to do what I am looking for. Thank you Markus -Original Message- From: David Ahern Sent: Sunday, July 7, 2019 2:24 PM To: Markus Moeller ; netdev@vger.kernel.org Subject: Re: More complex PBR rules On 7/6/19 5:06 PM, M

Re: [PATCH net 0/6] gtp: fix several bugs

2019-07-07 Thread David Miller
From: Taehee Yoo Date: Wed, 3 Jul 2019 00:20:34 +0900 > This patch series fixes several bugs in the gtp module. I reviewed these carefully by hand and decided to apply these now. Thanks Taehee.

Re: [PATCH v2 net-next 0/3] tc-testing: Add JSON verification and simple traffic generation

2019-07-07 Thread David Miller
From: Lucas Bates Date: Wed, 3 Jul 2019 20:44:59 -0400 > This patchset introduces JSON as a verification method in tdc and adds a new > plugin, scapyPlugin, as a way to send traffic to test tc filters and actions. > This version includes the patch signoffs missing in the previous submission. >

RE: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for configuration attributes.

2019-07-07 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Jakub Kicinski > Sent: Saturday, July 6, 2019 1:09 AM > To: Sudarsana Reddy Kalluru > Cc: da...@davemloft.net; netdev@vger.kernel.org; Michal Kalderon > ; Ariel Elior ; Jiri Pirko > > Subject: Re: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support

Re: [PATCH net-next] gve: Fix error return code in gve_alloc_qpls()

2019-07-07 Thread David Miller
From: Wei Yongjun Date: Fri, 5 Jul 2019 01:16:42 + > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: f5cedc84a30d ("gve: Add transmit and receive support") > Signed-off-by: Wei Yongjun Applied, thank you.

Re: [PATCH] phy: added a PHY_BUSY state into phy_state_machine

2019-07-07 Thread Florian Fainelli
+Andrew, Heiner (please CC PHY library maintainers). On 7/7/2019 3:32 PM, kwangdo.yi wrote: > When mdio driver polling the phy state in the phy_state_machine, > sometimes it results in -ETIMEDOUT and link is down. But the phy > is still alive and just didn't meet the polling deadline. > Closing t

  1   2   >