[PATCH net-next 7/8] mlxsw: spectrum: Set up PTP shaper when port status has changed

2019-07-04 Thread Ido Schimmel
From: Shalom Toledo When getting port up down event (PUDE), change the PTP shaper configuration based on hardware time stamping on/off and the port's speed. Signed-off-by: Shalom Toledo Reviewed-by: Petr Machata Acked-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mella

[PATCH net-next 0/8] mlxsw: Enable/disable PTP shapers

2019-07-04 Thread Ido Schimmel
From: Ido Schimmel Shalom says: In order to get more accurate hardware time stamping in Spectrum-1, the driver needs to apply a shaper on the port for speeds lower than 40Gbps. This shaper is called a PTP shaper and it is applied on hierarchy 0, which is the port hierarchy. This shaper may affec

[PATCH net-next 3/8] mlxsw: reg: Add QoS PTP Shaper Configuration Register

2019-07-04 Thread Ido Schimmel
From: Shalom Toledo The QPSC allows advanced configuration of the PTP shapers. Signed-off-by: Shalom Toledo Acked-by: Jiri Pirko Reviewed-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 107 ++ 1 file changed, 107 insertions(+

[PATCH net-next 5/8] mlxsw: spectrum: Add new operation for getting the port's speed

2019-07-04 Thread Ido Schimmel
From: Shalom Toledo New operation for getting the port's speed as part of port-type-speed operations. Signed-off-by: Shalom Toledo Acked-by: Jiri Pirko Reviewed-by: Petr Machata Signed-off-by: Ido Schimmel --- .../net/ethernet/mellanox/mlxsw/spectrum.c| 68 +++ .../net/e

[PATCH net-next 6/8] mlxsw: spectrum_ptp: Enable/disable PTP shaper on a port when getting HWTSTAMP on/off

2019-07-04 Thread Ido Schimmel
From: Shalom Toledo In order to get more accurate hardware time stamping, the driver needs to enable PTP shaper on the port, for speeds lower than 40 Gbps. Enable the PTP shaper on the port when the user turns on the hardware time stamping, and disable it when the user turns off the hardware tim

[PATCH net-next 2/8] mlxsw: spectrum: Add note about the PTP shaper

2019-07-04 Thread Ido Schimmel
From: Shalom Toledo Add note about disabling the PTP shaper when calling to mlxsw_sp_port_ets_maxrate_set(). Signed-off-by: Shalom Toledo Acked-by: Jiri Pirko Reviewed-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 5 +++-- 1 file changed,

[PATCH net-next 8/8] mlxsw: spectrum_ptp: Apply the PTP shaper enable/disable logic

2019-07-04 Thread Ido Schimmel
From: Shalom Toledo Apply by filling the PTP shaper parameters array. Signed-off-by: Shalom Toledo Reviewed-by: Petr Machata Acked-by: Jiri Pirko Signed-off-by: Ido Schimmel --- .../ethernet/mellanox/mlxsw/spectrum_ptp.c| 44 +++ 1 file changed, 44 insertions(+) diff --

[PATCH net-next 4/8] mlxsw: spectrum_ptp: Set the PTP shaper parameters

2019-07-04 Thread Ido Schimmel
From: Shalom Toledo Set the PTP shaper parameters during the ptp_init(). For different speeds, there are different parameters. When the port's speed changes and PTP shaper is enabled, the firmware changes the ETS shaper values according to the PTP shaper parameters for this new speed. The PTP s

[PATCH net-next 1/8] mlxsw: reg: Add ptps field in QoS ETS Element Configuration Register

2019-07-04 Thread Ido Schimmel
From: Shalom Toledo The PTP Shaper field is used for enabling and disabling of port-rate based shaper which is slightly lower than port rate. Signed-off-by: Shalom Toledo Acked-by: Jiri Pirko Reviewed-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h

Re: [PATCH v2 2/4] net: dsa: vsc73xx: Split vsc73xx driver

2019-07-04 Thread Linus Walleij
On Wed, Jul 3, 2019 at 7:21 PM Pawel Dembicki wrote: > This driver (currently) only takes control of the switch chip over > SPI and configures it to route packages around when connected to a > CPU port. But Vitesse chip support also parallel interface. > > This patch split driver into two parts:

Re: [rdma 14/16] RDMA/irdma: Add ABI definitions

2019-07-04 Thread Leon Romanovsky
On Wed, Jul 03, 2019 at 07:12:57PM -0700, Jeff Kirsher wrote: > From: Mustafa Ismail > > Add ABI definitions for irdma. > > Signed-off-by: Mustafa Ismail > Signed-off-by: Shiraz Saleem > --- > include/uapi/rdma/irdma-abi.h | 130 ++ > 1 file changed, 130 insertio

Re: [PATCH net-next 1/3] devlink: Introduce PCI PF port flavour and port attribute

2019-07-04 Thread Jiri Pirko
Wed, Jul 03, 2019 at 06:13:17PM CEST, pa...@mellanox.com wrote: > > >> -Original Message- >> From: Jiri Pirko >> Sent: Wednesday, July 3, 2019 8:05 PM >> To: Andrew Lunn >> Cc: Parav Pandit ; Jakub Kicinski >> ; Jiri Pirko ; >> netdev@vger.kernel.org; Saeed Mahameed ; >> vivien.dide...@gm

Re: [for-next V2 10/10] RDMA/core: Provide RDMA DIM support for ULPs

2019-07-04 Thread Leon Romanovsky
On Wed, Jul 03, 2019 at 11:56:04AM -0700, Sagi Grimberg wrote: > > > Hi Sagi, > > > > I'm not sharing your worries about bad out-of-the-box experience for a > > number of reasons. > > > > First of all, this code is part of upstream kernel and will take time > > till users actually start to use it a

Re: [PATCH net-next v5 5/5] selftests: tc-tests: actions: add MPLS tests

2019-07-04 Thread Davide Caratti
On Wed, 2019-07-03 at 01:25 +0100, John Hurley wrote: > Add a new series of selftests to verify the functionality of act_mpls in > TC. > > Signed-off-by: John Hurley > Reviewed-by: Simon Horman > Acked-by: Jakub Kicinski > --- > .../tc-testing/tc-tests/actions/mpls.json | 812 > +

Re: [PATCH net-next 3/3] selftests: forwarding: Test multipath hashing on inner IP pkts for GRE tunnel

2019-07-04 Thread Ido Schimmel
On Wed, Jul 03, 2019 at 11:19:34AM -0400, Stephen Suryaputra wrote: > Add selftest scripts for multipath hashing on inner IP pkts when there > is a single GRE tunnel but there are multiple underlay routes to reach > the other end of the tunnel. > > Four cases are covered in these scripts: > -

[PATCH v2 bpf-next] selftests/bpf: fix "alu with different scalars 1" on s390

2019-07-04 Thread Ilya Leoshkevich
BPF_LDX_MEM is used to load the least significant byte of the retrieved test_val.index, however, on big-endian machines it ends up retrieving the most significant byte. Use the correct least significant byte offset on big-endian machines. Signed-off-by: Ilya Leoshkevich --- v1->v2: - use __BYTE

Re: i.mx6ul with DSA in multi chip addressing mode - no MDIO access

2019-07-04 Thread Benjamin Beckmeyer
On 03.07.19 17:55, Andrew Lunn wrote: > On Wed, Jul 03, 2019 at 03:10:34PM +0200, Benjamin Beckmeyer wrote: >> Hey folks, >> >> I'm having a problem with a custom i.mx6ul board. When DSA is loaded I can't >> get access to the switch via MDIO, but the DSA is working properly. I set up >> a bridge

[PATCH bpf-next] tools: bpftool: add "prog run" subcommand to test-run programs

2019-07-04 Thread Quentin Monnet
Add a new "bpftool prog run" subcommand to run a loaded program on input data (and possibly with input context) passed by the user. Print output data (and output context if relevant) into a file or into the console. Print return value and duration for the test run into the console. A "repeat" arg

[PATCH] tools bpftool: Fix json dump crash on powerpc

2019-07-04 Thread Jiri Olsa
Michael reported crash with by bpf program in json mode on powerpc: # bpftool prog -p dump jited id 14 [{ "name": "0xda9aa760", "insns": [{ "pc": "0x0", "operation": "nop", "operands": [null ] }

[PATCH][net-next] net: remove unused parameter from skb_checksum_try_convert

2019-07-04 Thread Li RongQing
the check parameter is never used Signed-off-by: Li RongQing --- include/linux/skbuff.h | 8 +++- net/ipv4/gre_demux.c | 2 +- net/ipv4/udp.c | 3 +-- net/ipv6/udp.c | 3 +-- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/include/linux/skbuff.h b/include/li

Re: [PATCH ipsec] xfrm: policy: fix bydst hlist corruption on hash rebuild

2019-07-04 Thread Steffen Klassert
On Tue, Jul 02, 2019 at 12:46:00PM +0200, Florian Westphal wrote: > syzbot reported following spat: > > BUG: KASAN: use-after-free in __write_once_size include/linux/compiler.h:221 > BUG: KASAN: use-after-free in hlist_del_rcu include/linux/rculist.h:455 > BUG: KASAN: use-after-free in xfrm_hash_r

Re: [PATCH ipsec v2] xfrm interface: fix memory leak on creation

2019-07-04 Thread Steffen Klassert
On Tue, Jul 02, 2019 at 05:51:39PM +0200, Nicolas Dichtel wrote: > The following commands produce a backtrace and return an error but the xfrm > interface is created (in the wrong netns): > $ ip netns add foo > $ ip netns add bar > $ ip -n foo netns set bar 0 > $ ip -n foo link add xfrmi0 link-netn

Re: [PATCH v6 net-next 1/5] xdp: allow same allocator usage

2019-07-04 Thread Ivan Khoronzhuk
On Wed, Jul 03, 2019 at 07:40:13PM +0200, Jesper Dangaard Brouer wrote: On Wed, 3 Jul 2019 13:18:59 +0300 Ivan Khoronzhuk wrote: First of all, it is an absolute requirement that each RX-queue have their own page_pool object/allocator. And this change is intendant to handle special case, where

Re: bug: tpacket_snd can cause data corruption

2019-07-04 Thread Frank de Brabander
On 03-07-19 18:07, Willem de Bruijn wrote: On Wed, Jul 3, 2019 at 7:08 AM Frank de Brabander wrote: In commit 5cd8d46e a fix was applied for data corruption in tpacket_snd. A selftest was added in commit 358be656 which validates this fix. Unfortunately this bug still persists, although since

[PATCH net-next v3 1/4] net/sched: Introduce action ct

2019-07-04 Thread Paul Blakey
Allow sending a packet to conntrack module for connection tracking. The packet will be marked with conntrack connection's state, and any metadata such as conntrack mark and label. This state metadata can later be matched against with tc classifers, for example with the flower classifier as below.

[PATCH net-next v3 2/4] net/flow_dissector: add connection tracking dissection

2019-07-04 Thread Paul Blakey
Retreives connection tracking zone, mark, label, and state from a SKB. Signed-off-by: Paul Blakey Signed-off-by: Marcelo Ricardo Leitner Acked-by: Jiri Pirko --- include/linux/skbuff.h | 10 ++ include/net/flow_dissector.h | 15 +++ net/core/flow_dissector.c| 44 +

[PATCH net-next v3 4/4] tc-tests: Add tc action ct tests

2019-07-04 Thread Paul Blakey
Add 13 tests ensuring the command line is doing what is supposed to do. Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: Marcelo Ricardo Leitner --- .../selftests/tc-testing/tc-tests/actions/ct.json | 314 + 1 file changed, 314 insertions(+) create mode 100644 tools/t

[PATCH net-next v3 0/4] net/sched: Introduce tc connection tracking

2019-07-04 Thread Paul Blakey
Hi, This patch series add connection tracking capabilities in tc sw datapath. It does so via a new tc action, called act_ct, and new tc flower classifier matching on conntrack state, mark and label. Usage is as follows: $ tc qdisc add dev ens1f0_0 ingress $ tc qdisc add dev ens1f0_1 ingress $ t

[PATCH net-next v3 3/4] net/sched: cls_flower: Add matching on conntrack info

2019-07-04 Thread Paul Blakey
New matches for conntrack mark, label, zone, and state. Signed-off-by: Paul Blakey Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: Yossi Kuperman Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 16 ++ net/sched/cls_flower.c | 127 ++

Re: [net-next 0/3][pull request] Intel Wired LAN ver Updates 2019-07-03

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 07:12:49PM -0700, Jeff Kirsher wrote: > This series contains updates to i40e an ice drivers only and is required > for a series of changes being submitted to the RDMA maintainer/tree. > Vice Versa, the Intel RDMA driver patches could not be applied to > net-next due to depen

Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 07:12:50PM -0700, Jeff Kirsher wrote: > From: Tony Nguyen > > The RDMA block does not advertise on the PCI bus or any other bus. > Thus the ice driver needs to provide access to the RDMA hardware block > via a virtual bus; utilize the platform bus to provide this access. >

Re: [rdma 1/1] RDMA/irdma: Add Kconfig and Makefile

2019-07-04 Thread Jason Gunthorpe
On Wed, Jul 03, 2019 at 07:12:43PM -0700, Jeff Kirsher wrote: > From: Shiraz Saleem > > Add Kconfig and Makefile to build irdma driver and mark i40iw > deprecated/obsolete, since the irdma driver is replacing it and supports > x722 devices. Patch 1/1? Series looks mangled... > diff --git a/driv

Re: [rdma 14/16] RDMA/irdma: Add ABI definitions

2019-07-04 Thread Jason Gunthorpe
On Thu, Jul 04, 2019 at 10:40:21AM +0300, Leon Romanovsky wrote: > On Wed, Jul 03, 2019 at 07:12:57PM -0700, Jeff Kirsher wrote: > > From: Mustafa Ismail > > > > Add ABI definitions for irdma. > > > > Signed-off-by: Mustafa Ismail > > Signed-off-by: Shiraz Saleem > > include/uapi/rdma/irdma-abi

Re: [PATCH ipsec v2] xfrm interface: fix memory leak on creation

2019-07-04 Thread Nicolas Dichtel
Le 04/07/2019 à 12:22, Steffen Klassert a écrit : [snip] > > Applied, thanks a lot! > I suppose that this patch will be queued for stable trees? Regards, Nicolas

[PATCH iproute2 0/1] Fix s64 argument parsing

2019-07-04 Thread Kurt Kanzenbach
Hi, while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time parameter is incorrectly configured. The problem is the utility function get_s64() used by TAPRIO doesn't parse the value correctly. Thanks, Kurt Kurt Kanzenbach (1): utils: Fix get_s64() function lib/utils.c | 2 +-

[PATCH iproute2 1/1] utils: Fix get_s64() function

2019-07-04 Thread Kurt Kanzenbach
get_s64() uses internally strtoll() to parse the value out of a given string. strtoll() returns a long long. However, the intermediate variable is long only which might be 32 bit on some systems. So, fix it. Signed-off-by: Kurt Kanzenbach --- lib/utils.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA

2019-07-04 Thread Greg KH
On Thu, Jul 04, 2019 at 12:16:41PM +, Jason Gunthorpe wrote: > On Wed, Jul 03, 2019 at 07:12:50PM -0700, Jeff Kirsher wrote: > > From: Tony Nguyen > > > > The RDMA block does not advertise on the PCI bus or any other bus. > > Thus the ice driver needs to provide access to the RDMA hardware bl

RE: [for-next V2 10/10] RDMA/core: Provide RDMA DIM support for ULPs

2019-07-04 Thread Idan Burstein
The essence of the dynamic in DIM is that it would fit to the workload running on the cores. For user not to trade bandwidth/cqu% and latency with a module parameter they don't know how to config. If DIM consistently hurts latency of latency critical workloads we should debug and fix. This is w

Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA

2019-07-04 Thread Jason Gunthorpe
On Thu, Jul 04, 2019 at 02:29:50PM +0200, Greg KH wrote: > On Thu, Jul 04, 2019 at 12:16:41PM +, Jason Gunthorpe wrote: > > On Wed, Jul 03, 2019 at 07:12:50PM -0700, Jeff Kirsher wrote: > > > From: Tony Nguyen > > > > > > The RDMA block does not advertise on the PCI bus or any other bus. > >

[PATCH bpf-next v3 0/6] add need_wakeup flag to the AF_XDP rings

2019-07-04 Thread Magnus Karlsson
This patch set adds support for a new flag called need_wakeup in the AF_XDP Tx and fill rings. When this flag is set by the driver, it means that the application has to explicitly wake up the kernel Rx (for the bit in the fill ring) or kernel Tx (for bit in the Tx ring) processing by issuing a sysc

[PATCH bpf-next v3 1/6] xsk: replace ndo_xsk_async_xmit with ndo_xsk_wakeup

2019-07-04 Thread Magnus Karlsson
This commit replaces ndo_xsk_async_xmit with ndo_xsk_wakeup. This new ndo provides the same functionality as before but with the addition of a new flags field that is used to specifiy if Rx, Tx or both should be woken up. The previous ndo only woke up Tx, as implied by the name. The i40e and ixgbe

Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA

2019-07-04 Thread Greg KH
On Thu, Jul 04, 2019 at 12:37:33PM +, Jason Gunthorpe wrote: > On Thu, Jul 04, 2019 at 02:29:50PM +0200, Greg KH wrote: > > On Thu, Jul 04, 2019 at 12:16:41PM +, Jason Gunthorpe wrote: > > > On Wed, Jul 03, 2019 at 07:12:50PM -0700, Jeff Kirsher wrote: > > > > From: Tony Nguyen > > > > >

[PATCH bpf-next v3 2/6] xsk: add support for need_wakeup flag in AF_XDP rings

2019-07-04 Thread Magnus Karlsson
This commit adds support for a new flag called need_wakeup in the AF_XDP Tx and fill rings. When this flag is set, it means that the application has to explicitly wake up the kernel Rx (for the bit in the fill ring) or kernel Tx (for bit in the Tx ring) processing by issuing a syscall. Poll() can w

[PATCH bpf-next v3 3/6] i40e: add support for AF_XDP need_wakup feature

2019-07-04 Thread Magnus Karlsson
This patch adds support for the need_wakeup feature of AF_XDP. If the application has told the kernel that it might sleep using the new bind flag XDP_USE_NEED_WAKEUP, the driver will then set this flag if it has no more buffers on the NIC Rx ring and yield to the application. For Tx, it will set th

[PATCH bpf-next v3 4/6] ixgbe: add support for AF_XDP need_wakup feature

2019-07-04 Thread Magnus Karlsson
This patch adds support for the need_wakeup feature of AF_XDP. If the application has told the kernel that it might sleep using the new bind flag XDP_USE_NEED_WAKEUP, the driver will then set this flag if it has no more buffers on the NIC Rx ring and yield to the application. For Tx, it will set th

[PATCH bpf-next v3 6/6] samples/bpf: add use of need_sleep flag in xdpsock

2019-07-04 Thread Magnus Karlsson
This commit adds using the need_sleep flag to the xdpsock sample application. It is turned on by default as we think it is a feature that seems to always produce a performance benefit, if the application has been written taking advantage of it. It can be turned off in the sample app by using the '-

[PATCH bpf-next v3 5/6] libbpf: add support for need_wakeup flag in AF_XDP part

2019-07-04 Thread Magnus Karlsson
This commit adds support for the new need_wakeup flag in AF_XDP. The xsk_socket__create function is updated to handle this and a new function is introduced called xsk_ring_prod__needs_wakeup(). This function can be used by the application to check if Rx and/or Tx processing needs to be explicitly w

Re: [PATCH net-next 8/8] net: mscc: PTP Hardware Clock (PHC) support

2019-07-04 Thread kbuild test robot
Hi Antoine, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Antoine-Tenart/net-mscc-PTP-Hardware-Clock-PHC-support/20190702-182042 config: x86_64-randconfig-s2-07041950 (attached as .config) compiler:

Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA

2019-07-04 Thread Jason Gunthorpe
On Thu, Jul 04, 2019 at 02:42:47PM +0200, Greg KH wrote: > On Thu, Jul 04, 2019 at 12:37:33PM +, Jason Gunthorpe wrote: > > On Thu, Jul 04, 2019 at 02:29:50PM +0200, Greg KH wrote: > > > On Thu, Jul 04, 2019 at 12:16:41PM +, Jason Gunthorpe wrote: > > > > On Wed, Jul 03, 2019 at 07:12:50PM

[PATCH net-next v2 0/4] qed*/devlink: Devlink support for config attributes.

2019-07-04 Thread Sudarsana Reddy Kalluru
The patch series adds support for managing the config attributes using devlink interfaces. Patch (1) adds the APIs for publishing the devlink port params. Clubbing this qed patches as per the review comment (i.e., need at least one consumer for the new APIs). Patches (2)-(4) adds the qed/qede dev

[PATCH net-next v2 3/4] qed*: Add new file for devlink implementation.

2019-07-04 Thread Sudarsana Reddy Kalluru
Moving devlink implementation from qed to qede driver. The change is required as qede is the actual PCI driver and qed is only the control driver. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 1 - drivers/net/ethernet/

[PATCH net-next v2 4/4] qed*: Add devlink support for configuration attributes.

2019-07-04 Thread Sudarsana Reddy Kalluru
This patch adds implementation for devlink callbacks for reading and configuring the device attributes. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- Documentation/networking/devlink-params-qede.txt | 72 drivers/net/ethernet/qlogic/qed/qed_main.c | 38 +

[PATCH net-next v2 2/4] qed: Add APIs for device attributes configuration.

2019-07-04 Thread Sudarsana Reddy Kalluru
The patch adds driver APIs for reading/configuring the device attributes. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 17 drivers/net/ethernet/qlogic/qed/qed_mcp.c | 64 +++ drivers/net/et

[PATCH net-next v2 1/4] devlink: Add APIs to publish/unpublish the port parameters.

2019-07-04 Thread Sudarsana Reddy Kalluru
Kernel has no interface to publish the devlink port parameters. This is required for exporting the port params to the user space, so that user can read or update the port params. This patch adds devlink interfaces (for drivers) to publish/unpublish the devlink port parameters. Signed-off-by: Sudar

Re: i.mx6ul with DSA in multi chip addressing mode - no MDIO access

2019-07-04 Thread Andrew Lunn
On Thu, Jul 04, 2019 at 10:54:47AM +0200, Benjamin Beckmeyer wrote: > > On 03.07.19 17:55, Andrew Lunn wrote: > > On Wed, Jul 03, 2019 at 03:10:34PM +0200, Benjamin Beckmeyer wrote: > >> Hey folks, > >> > >> I'm having a problem with a custom i.mx6ul board. When DSA is loaded I > >> can't > >> g

Re: [PATCH net-next v5 5/5] selftests: tc-tests: actions: add MPLS tests

2019-07-04 Thread John Hurley
On Thu, Jul 4, 2019 at 9:40 AM Davide Caratti wrote: > > On Wed, 2019-07-03 at 01:25 +0100, John Hurley wrote: > > Add a new series of selftests to verify the functionality of act_mpls in > > TC. > > > > Signed-off-by: John Hurley > > Reviewed-by: Simon Horman > > Acked-by: Jakub Kicinski > > -

Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA

2019-07-04 Thread Greg KH
On Thu, Jul 04, 2019 at 12:48:29PM +, Jason Gunthorpe wrote: > On Thu, Jul 04, 2019 at 02:42:47PM +0200, Greg KH wrote: > > On Thu, Jul 04, 2019 at 12:37:33PM +, Jason Gunthorpe wrote: > > > On Thu, Jul 04, 2019 at 02:29:50PM +0200, Greg KH wrote: > > > > On Thu, Jul 04, 2019 at 12:16:41PM

Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA

2019-07-04 Thread Jason Gunthorpe
On Thu, Jul 04, 2019 at 03:46:12PM +0200, Greg KH wrote: > On Thu, Jul 04, 2019 at 12:48:29PM +, Jason Gunthorpe wrote: > > On Thu, Jul 04, 2019 at 02:42:47PM +0200, Greg KH wrote: > > > On Thu, Jul 04, 2019 at 12:37:33PM +, Jason Gunthorpe wrote: > > > > On Thu, Jul 04, 2019 at 02:29:50PM

[PATCH] net: netsec: Sync dma for device on buffer allocation

2019-07-04 Thread Ilias Apalodimas
Quoting Arnd, We have to do a sync_single_for_device /somewhere/ before the buffer is given to the device. On a non-cache-coherent machine with a write-back cache, there may be dirty cache lines that get written back after the device DMA's data into it (e.g. from a previous memset from before the

[PATCH net-next v6 0/5] Add MPLS actions to TC

2019-07-04 Thread John Hurley
This patchset introduces a new TC action module that allows the manipulation of the MPLS headers of packets. The code impliments functionality including push, pop, and modify. Also included are tests for the new funtionality. Note that these will require iproute2 changes to be submitted soon. NOT

[PATCH net-next v6 1/5] net: core: move push MPLS functionality from OvS to core helper

2019-07-04 Thread John Hurley
Open vSwitch provides code to push an MPLS header to a packet. In preparation for supporting this in TC, move the push code to an skb helper that can be reused. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Willem de Bruijn Acked-by: Cong Wang -

[PATCH net-next v6 3/5] net: core: add MPLS update core helper and use in OvS

2019-07-04 Thread John Hurley
Open vSwitch allows the updating of an existing MPLS header on a packet. In preparation for supporting similar functionality in TC, move this to a common skb helper function. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Willem de Bruijn Acked-by

[PATCH net-next v6 2/5] net: core: move pop MPLS functionality from OvS to core helper

2019-07-04 Thread John Hurley
Open vSwitch provides code to pop an MPLS header to a packet. In preparation for supporting this in TC, move the pop code to an skb helper that can be reused. Remove the, now unused, update_ethertype static function from OvS. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Reviewed-by: S

[PATCH net-next v6 4/5] net: sched: add mpls manipulation actions to TC

2019-07-04 Thread John Hurley
Currently, TC offers the ability to match on the MPLS fields of a packet through the use of the flow_dissector_key_mpls struct. However, as yet, TC actions do not allow the modification or manipulation of such fields. Add a new module that registers TC action ops to allow manipulation of MPLS. Thi

[PATCH net-next v6 5/5] selftests: tc-tests: actions: add MPLS tests

2019-07-04 Thread John Hurley
Add a new series of selftests to verify the functionality of act_mpls in TC. Signed-off-by: John Hurley Reviewed-by: Simon Horman Acked-by: Jakub Kicinski --- tools/testing/selftests/tc-testing/config | 1 + .../tc-testing/tc-tests/actions/mpls.json | 812 ++

Re: i.mx6ul with DSA in multi chip addressing mode - no MDIO access

2019-07-04 Thread Benjamin Beckmeyer
> On Thu, Jul 04, 2019 at 10:54:47AM +0200, Benjamin Beckmeyer wrote: >> On 03.07.19 17:55, Andrew Lunn wrote: >>> On Wed, Jul 03, 2019 at 03:10:34PM +0200, Benjamin Beckmeyer wrote: Hey folks, I'm having a problem with a custom i.mx6ul board. When DSA is loaded I can't g

[net-next, PATCH, v2] net: netsec: Sync dma for device on buffer allocation

2019-07-04 Thread Ilias Apalodimas
Quoting Arnd, We have to do a sync_single_for_device /somewhere/ before the buffer is given to the device. On a non-cache-coherent machine with a write-back cache, there may be dirty cache lines that get written back after the device DMA's data into it (e.g. from a previous memset from before the

Re: bonded active-backup ethernet-wifi drops packets

2019-07-04 Thread Brian J. Murrell
On Tue, 2019-06-18 at 14:57 -0400, Brian J. Murrell wrote: > Hi. > > I have an active-backup bonded connection on a 5.1.6 kernel where the > slaves are an Ethernet interface and a wifi interface. The goal is > to > have network transparent (i.e. same and IP address on both > interfaces) > interfa

Re: [net-next, PATCH, v2] net: netsec: Sync dma for device on buffer allocation

2019-07-04 Thread Arnd Bergmann
On Thu, Jul 4, 2019 at 4:46 PM Ilias Apalodimas wrote: > diff --git a/drivers/net/ethernet/socionext/netsec.c > b/drivers/net/ethernet/socionext/netsec.c > index 5544a722543f..ada7626bf3a2 100644 > --- a/drivers/net/ethernet/socionext/netsec.c > > + dma_start = page_pool_get_dma_addr(page);

Re: i.mx6ul with DSA in multi chip addressing mode - no MDIO access

2019-07-04 Thread Andrew Lunn
> &mdio0 { > interrupt-parent = <&gpio1>; > interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; > > switch0: switch0@2 { > compatible = "marvell,mv88e6190"; > reg = <2>; > pinctrl-0 = <&pinctrl_gpios>; > reset-gpios = <&gpio

[PATCH net] ipv4: Fix NULL pointer dereference in ipv4_neigh_lookup()

2019-07-04 Thread Ido Schimmel
From: Ido Schimmel Both ip_neigh_gw4() and ip_neigh_gw6() can return either a valid pointer or an error pointer, but the code currently checks that the pointer is not NULL. Fix this by checking that the pointer is not an error pointer, as this can result in a NULL pointer dereference [1]. Specif

Re: [PATCH mlx5-next 4/5] net/mlx5: Introduce TLS TX offload hardware bits and structures

2019-07-04 Thread Saeed Mahameed
On Wed, Jul 3, 2019 at 5:27 AM wrote: > > On Wed, Jul 03, 2019 at 07:39:32AM +, Saeed Mahameed wrote: > > From: Eran Ben Elisha > > > > Add TLS offload related IFC structs, layouts and enumerations. > > > > Signed-off-by: Eran Ben Elisha > > Signed-off-by: Tariq Toukan > > Signed-off-by: Sa

Re: [PATCH mlx5-next 0/5] Mellanox, mlx5 low level updates 2019-07-02

2019-07-04 Thread Saeed Mahameed
On Wed, 2019-07-03 at 07:39 +, Saeed Mahameed wrote: > Hi All, > > This series includes some low level updates to mlx5 driver, required > for > shared mlx5-next branch. > > Tariq extends the WQE control fields names. > Eran adds the required HW definitions and structures for upcoming TLS > su

Re: [PATCH mlx5-next 4/5] net/mlx5: Introduce TLS TX offload hardware bits and structures

2019-07-04 Thread Leon Romanovsky
On Thu, Jul 04, 2019 at 01:06:58PM -0400, Saeed Mahameed wrote: > On Wed, Jul 3, 2019 at 5:27 AM wrote: > > > > On Wed, Jul 03, 2019 at 07:39:32AM +, Saeed Mahameed wrote: > > > From: Eran Ben Elisha > > > > > > Add TLS offload related IFC structs, layouts and enumerations. > > > > > > Signed

Re: [PATCH mlx5-next 0/5] Mellanox, mlx5 low level updates 2019-07-02

2019-07-04 Thread Leon Romanovsky
On Thu, Jul 04, 2019 at 05:10:25PM +, Saeed Mahameed wrote: > On Wed, 2019-07-03 at 07:39 +, Saeed Mahameed wrote: > > Hi All, > > > > This series includes some low level updates to mlx5 driver, required > > for > > shared mlx5-next branch. > > > > Tariq extends the WQE control fields names

"local" interfaces, in forwarding state, are mutually "blind", and fail to connect

2019-07-04 Thread James Feeney
I have a question - maybe someone can point me in the right direction? When there exist two or more "local" interfaces on the "host" system, where sysctl "net.ipv4.conf..forwarding=1" has been set, and where each interface has an IP address on a different subnet, then, when a frame arrives at a

Re: [PATCH mlx5-next 4/5] net/mlx5: Introduce TLS TX offload hardware bits and structures

2019-07-04 Thread Saeed Mahameed
On Thu, Jul 4, 2019 at 1:15 PM Leon Romanovsky wrote: > > On Thu, Jul 04, 2019 at 01:06:58PM -0400, Saeed Mahameed wrote: > > On Wed, Jul 3, 2019 at 5:27 AM wrote: > > > > > > On Wed, Jul 03, 2019 at 07:39:32AM +, Saeed Mahameed wrote: > > > > From: Eran Ben Elisha > > > > > > > > Add TLS of

Contract Offer

2019-07-04 Thread SAKI NISHIYO
We’d like to contract your services for a period of 12 months. Please advise if you are open to new opportunities. Regards, SAKI NISHIYO

Re: [PATCH v2 bpf-next] selftests/bpf: fix "alu with different scalars 1" on s390

2019-07-04 Thread Y Song
On Thu, Jul 4, 2019 at 1:52 AM Ilya Leoshkevich wrote: > > BPF_LDX_MEM is used to load the least significant byte of the retrieved > test_val.index, however, on big-endian machines it ends up retrieving > the most significant byte. > > Use the correct least significant byte offset on big-endian ma

Re: [PATCH] tools bpftool: Fix json dump crash on powerpc

2019-07-04 Thread Quentin Monnet
2019-07-04 10:58 UTC+0200 ~ Jiri Olsa > Michael reported crash with by bpf program in json mode on powerpc: > > # bpftool prog -p dump jited id 14 > [{ > "name": "0xda9aa760", > "insns": [{ > "pc": "0x0", > "operation": "nop", >

Re: [net-next, PATCH, v2] net: netsec: Sync dma for device on buffer allocation

2019-07-04 Thread Jesper Dangaard Brouer
On Thu, 4 Jul 2019 17:46:09 +0300 Ilias Apalodimas wrote: > Quoting Arnd, > > We have to do a sync_single_for_device /somewhere/ before the > buffer is given to the device. On a non-cache-coherent machine with > a write-back cache, there may be dirty cache lines that get written back > after th

Re: "local" interfaces, in forwarding state, are mutually "blind", and fail to connect

2019-07-04 Thread Andrew Lunn
On Thu, Jul 04, 2019 at 11:11:21AM -0600, James Feeney wrote: > I have a question - maybe someone can point me in the right direction? > > When there exist two or more "local" interfaces Hi James What exactly do you mean by a 'local' interface? The IP address on the interface has scope local?

Re: [net-next, PATCH, v2] net: netsec: Sync dma for device on buffer allocation

2019-07-04 Thread Ilias Apalodimas
On Thu, Jul 04, 2019 at 07:39:44PM +0200, Jesper Dangaard Brouer wrote: > On Thu, 4 Jul 2019 17:46:09 +0300 > Ilias Apalodimas wrote: > > > Quoting Arnd, > > > > We have to do a sync_single_for_device /somewhere/ before the > > buffer is given to the device. On a non-cache-coherent machine with

Re: [PATCH rdma-next v5 11/17] RDMA/netlink: Implement counter dumpit calback

2019-07-04 Thread Jason Gunthorpe
On Tue, Jul 02, 2019 at 01:02:40PM +0300, Leon Romanovsky wrote: > diff --git a/include/uapi/rdma/rdma_netlink.h > b/include/uapi/rdma/rdma_netlink.h > index 0cb47d23fd86..22c5bc7a82dd 100644 > +++ b/include/uapi/rdma/rdma_netlink.h > @@ -283,6 +283,8 @@ enum rdma_nldev_command { > > RDMA_

Re: [PATCH rdma-next v5 06/17] RDMA/counter: Add "auto" configuration mode support

2019-07-04 Thread Jason Gunthorpe
On Tue, Jul 02, 2019 at 01:02:35PM +0300, Leon Romanovsky wrote: > From: Mark Zhang > > In auto mode all QPs belong to one category are bind automatically to > a single counter set. Currently only "qp type" is supported. > > In this mode the qp counter is set in RST2INIT modification, and when >

[pull request][net-next 00/14] Mellanox, mlx5 updates 2019-07-04

2019-07-04 Thread Saeed Mahameed
Hi Dave, This series adds two features to mlx5 driver. 1) From Shay, add the support for devlink fw query 2) From Tariq and Eran, KTLS tx support. For more information please see tag log below. Please pull and let me know if there is any problem. Please note that the series starts with a merge

[net-next 03/14] net/mlx5: Accel, Expose accel wrapper for IPsec FPGA function

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Do not directly call fpga version of IPsec function from main.c. Wrap it by an accel version, and call the wrapper. This will allow deprecating the FPGA IPsec stubs in downstream patch. Signed-off-by: Tariq Toukan Reviewed-by: Boris Pismenny Signed-off-by: Saeed Mahameed -

[net-next 05/14] net/mlx5: Add crypto library to support create/destroy encryption key

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Encryption key create / destroy is done via CREATE_GENERAL_OBJECT / DESTROY_GENERAL_OBJECT commands. To be used in downstream patches by TLS API wrappers, to configure the TIS context with the encryption key. Signed-off-by: Tariq Toukan Signed-off-by: Eran Ben Elisha Signed

[net-next 10/14] net/mlx5e: Tx, Don't implicitly assume SKB-less wqe has one WQEBB

2019-07-04 Thread Saeed Mahameed
From: Eran Ben Elisha When polling a CQE of an SKB-less WQE, don't assume it consumed only one WQEBB. Use wi->num_wqebbs directly instead. In the downstream patch, SKB-less WQEs might have more the one WQEBB, thus this change is needed. Signed-off-by: Eran Ben Elisha Signed-off-by: Tariq Toukan

[net-next 06/14] net/mlx5: Accel, Add core TLS support for the Connect-X family

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Add support for the new TLS implementation of the Connect-X family. Introduce a new compilation flag MLX5_TLS for it. Signed-off-by: Tariq Toukan Signed-off-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/Kconfig | 13 - .../

[net-next 13/14] net/mlx5e: Introduce a fenced NOP WQE posting function

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Similar to the existing mlx5e_post_nop(), but marks a fence in the WQE control segment. Added as a separate new function to not hurt the performance of the common case. To be used in a downstream patch of the series. Signed-off-by: Tariq Toukan Reviewed-by: Boris Pismenny

[net-next 12/14] net/mlx5e: Re-work TIS creation functions

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Let the EN TIS creation function (mlx5e_create_tis) be responsible for applying common mdev related fields. Other specific fields must be set by the caller and passed within the inbox. Signed-off-by: Tariq Toukan Reviewed-by: Boris Pismenny Signed-off-by: Saeed Mahameed ---

[net-next 04/14] net/mlx5: Kconfig, Better organize compilation flags

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Always contain all acceleration functions declarations in 'accel' files, independent to the flags setting. For this, introduce new flags CONFIG_FPGA_{IPSEC/TLS} and use stubs where needed. This obsoletes the need for stubs in 'fpga' files. Remove them. Also use the new flags

[net-next 14/14] net/mlx5e: Add kTLS TX HW offload support

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Add support for transmit side kernel-TLS acceleration. Offload the crypto encryption to HW. Per TLS connection: - Use a separate TIS to maintain the HW context. - Use a separate encryption key. - Maintain static and progress HW contexts by posting the proper WQEs at creation

[net-next 01/14] net/mlx5: Added fw version query command

2019-07-04 Thread Saeed Mahameed
From: Shay Agroskin Using the MCQI and MCQS registers, we query the running and pending fw version of the HCA. The MCQS is queried with sequentially increasing component index, until a component of type BOOT_IMG is found. Querying this component's version using the MCQI register yields the runnin

[net-next 07/14] net/mlx5e: Move helper functions to a new txrx datapath header

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Take datapath helper functions to a new header file en/txrx.h. Signed-off-by: Eran Ben Elisha Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 102 --- .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 163

[net-next 02/14] net/mlx5: Added devlink info callback

2019-07-04 Thread Saeed Mahameed
From: Shay Agroskin The callback is invoked using 'devlink dev info ' command and returns the running and pending firmware version of the HCA and the name of the kernel driver. If there is a pending firmware version (a new version is burned but the HCA still runs with the previous) it is returne

[net-next 08/14] net/mlx5e: Tx, Enforce L4 inline copy when needed

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan When ctrl->tisn field exists, this indicates an operation (HW offload) on the TCP payload. For such WQEs, inline the headers up to L4. This is in preparation for kTLS HW offload support, added in a downstream patch. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed

[net-next 09/14] net/mlx5e: Tx, Make SQ WQE fetch function type generic

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Change mlx5e_sq_fetch_wqe to be agnostic to the Work Queue Element (WQE) type. Before this patch, it was specific for struct mlx5e_tx_wqe. In order to allow the change, the function now returns the generic void pointer, and gets the WQE size to do the zero memset. Signed-off-

[net-next 11/14] net/mlx5e: Tx, Unconstify SQ stop room

2019-07-04 Thread Saeed Mahameed
From: Tariq Toukan Use an SQ field for stop_room, and use the larger value only if TLS is supported. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 + .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 14 ++ .../net

  1   2   >