Wed, Jul 03, 2019 at 06:13:17PM CEST, pa...@mellanox.com wrote: > > >> -----Original Message----- >> From: Jiri Pirko <j...@resnulli.us> >> Sent: Wednesday, July 3, 2019 8:05 PM >> To: Andrew Lunn <and...@lunn.ch> >> Cc: Parav Pandit <pa...@mellanox.com>; Jakub Kicinski >> <jakub.kicin...@netronome.com>; Jiri Pirko <j...@mellanox.com>; >> netdev@vger.kernel.org; Saeed Mahameed <sae...@mellanox.com>; >> vivien.dide...@gmail.com; f.faine...@gmail.com >> Subject: Re: [PATCH net-next 1/3] devlink: Introduce PCI PF port flavour and >> port attribute >> >> Wed, Jul 03, 2019 at 04:09:58PM CEST, and...@lunn.ch wrote: >> >> However, we expose it for DEVLINK_PORT_FLAVOUR_CPU and >> >> DEVLINK_PORT_FLAVOUR_DSA. Not sure if it makes sense there either. >> >> Ccing Florian, Andrew and Vivien. >> >> What do you guys think? >> > >> >Hi Jiri >> > >> >DSA and CPU ports are physical ports of the switch. And there can be >> >multiple DSA ports, and maybe sometime real soon now, multiple CPU >> >ports. So having a number associated with them is useful. >> >> Okay. Makes sense. >> >Ok. I should probably update the comment section for port_number as its scope >is expanded. >Should I revise the series with updated comment?
Please do. Also put a check to not fillup port_number attribute in case of pf/vf flavour. Thanks! > >> > >> > Andrew
