[PATCH net-next] Revert "net: ena: ethtool: add extra properties retrieval via get_priv_flags"

2019-06-25 Thread Jakub Kicinski
This reverts commit 315c28d2b714 ("net: ena: ethtool: add extra properties retrieval via get_priv_flags"). As discussed at netconf and on the mailing list we can't allow for the the abuse of private flags for exposing arbitrary device labels. Signed-off-by: Jakub Kicinski --- .../net/ethernet/

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-25 Thread Eric Dumazet
On 6/25/19 2:35 AM, Daniel Borkmann wrote: > > But wasn't the whole point of 9c4c325252c5 ("skbuff: preserve sock reference > when > scrubbing the skb.") to defer orphaning to as late as possible? If I'm not > missing > anything, then above would reintroduce the issues that 9c4c325252c5 was

Re: Warnings generated from tcp_sacktag_write_queue.

2019-06-25 Thread Eric Dumazet
On 6/25/19 8:57 AM, Chinmay Agarwal wrote: > > The kernel version used is 4.14. > Do not use this old version please.

Re: [PATCH bpf] tools: bpftool: use correct argument in cgroup errors

2019-06-25 Thread Roman Gushchin
On Tue, Jun 25, 2019 at 09:56:31AM -0700, Jakub Kicinski wrote: > cgroup code tries to use argv[0] as the cgroup path, > but if it fails uses argv[1] to report errors. > > Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations") > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monne

[net-next 1/1] tipc: rename function msg_get_wrapped() to msg_inner_hdr()

2019-06-25 Thread Jon Maloy
We rename the inline function msg_get_wrapped() to the more comprehensible msg_inner_hdr(). Signed-off-by: Jon Maloy --- net/tipc/bcast.c | 4 ++-- net/tipc/link.c | 2 +- net/tipc/msg.h | 4 ++-- net/tipc/node.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/net/tipc

[PATCH V2 mlx5-next 01/13] net/mlx5: Introduce vport metadata matching bits and enum constants

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu When a dual-port VHCA sends a RoCE packet on its non-native port, and the packet arrives to its affiliated vport FDB, a mismatch might occur on the rules that match the packet source vport. So we replace the match on source port with the match on metadata that was configured in i

[PATCH V2 mlx5-next 00/13] Mellanox, mlx5 vport metadata matching

2019-06-25 Thread Saeed Mahameed
This series includes mlx5 updates for both rdma and net-next trees. In case of no objection it will be applied to mlx5-next branch and later on will be sent as pull request to rdma and net-next. From Jianbo, Vport meta data matching: Hardware steering has no notion of vport number, and vport is a

[PATCH V2 mlx5-next 02/13] net/mlx5: Get vport ACL namespace by vport index

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu The ingress and egress ACL root namespaces are created per vport and stored into arrays. However, the vport number is not the same as the index. Passing the array index, instead of vport number, to get the correct ingress and egress acl namespace. Fixes: 9b93ab981e3b ("net/mlx5:

[PATCH V2 mlx5-next 03/13] net/mlx5: Support allocating modify header context from ingress ACL

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu That modify header action can be then attached to a steering rule in the ingress ACL. Signed-off-by: Jianbo Liu Reviewed-by: Eli Britstein Reviewed-by: Roi Dayan Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 4

[PATCH V2 mlx5-next 13/13] net/mlx5: E-Switch, Enable vport metadata matching if firmware supports it

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu As the ingress ACL rules save vhca id and vport number to packet's metadata REG_C_0, and the metadata matching for the rules in both fast path and slow path are all added, enable this feature if supported. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan Reviewed-by: Mark Bloc

[PATCH V2 mlx5-next 06/13] net/mlx5: E-Switch, Tag packet with vport number in VF vports and uplink ingress ACLs

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu When a dual-port VHCA sends a RoCE packet on its non-native port, and the packet arrives to its affiliated vport FDB, a mismatch might occur on the rules that match the packet source vport as it is not represented by single VHCA only in this case. So we change to match on metadat

[PATCH V2 mlx5-next 08/13] net/mlx5: E-Switch, Add match on vport metadata for rule in fast path

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu If FW's capabilities and configurations meet the requirement of vport metadata matching, this feature will be used. As the information about vport number and vhca_id related to packet is already stored to its metadata register, which is used as an indicator for perticular vport,

[PATCH V2 mlx5-next 07/13] net/mlx5e: Specifying known origin of packets matching the flow

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu In vport metadata matching, source port number is replaced by metadata. While FW has no idea about what it is in the metadata, a syndrome will happen. Specify a known origin to avoid the syndrome. However, there is no functional change because ANY_VPORT (0) is filled in flow_sour

[PATCH V2 mlx5-next 09/13] net/mlx5: E-Switch, Add query and modify esw vport context functions

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu Add esw vport query and modify functions, and exposing them is needed for enabling or disabling registers passed as metatdata to vport NIC_RX table in slow path. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../n

[PATCH V2 mlx5-next 04/13] net/mlx5: Introduce a helper API to check VF vport

2019-06-25 Thread Saeed Mahameed
From: Parav Pandit Introduce a helper API mlx5_eswitch_is_vf_vport() to check if a given vport_num belongs to VF or not. Signed-off-by: Parav Pandit Reviewed-by: Jianbo Liu Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2 ++ drivers/net/ethern

[PATCH V2 mlx5-next 11/13] net/mlx5: E-Switch, Add match on vport metadata for rule in slow path

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu In slow path, packet that not matched by any offloaded rule is forwarded to eswitch vport manager for further processing. Add matching on metadata for peer miss rules in FDB, and rules which forward packet to correct representor in esw manager NIC_RX table. Signed-off-by: Jianbo

[PATCH V2 mlx5-next 10/13] net/mlx5: E-Switch, Pass metadata from FDB to eswitch manager

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu In order to do matching on metadata in slow path when demuxing traffic to representors, explicitly enable the feature that allows HW to pass metadata REG_C_0 from FDB to eswitch manager NIC_RX table. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan Reviewed-by: Mark Bloch Sig

[PATCH V2 mlx5-next 05/13] net/mlx5: Add flow context for flow tag

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu Refactor the flow data structures, add new flow_context and move flow_tag into it, as flow_tag doesn't belong to the rule action. Signed-off-by: Jianbo Liu Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/flow.c | 13 --- d

[PATCH V2 mlx5-next 12/13] RDMA/mlx5: Add vport metadata matching for IB representors

2019-06-25 Thread Saeed Mahameed
From: Jianbo Liu If vport metadata matching is enabled in eswitch, the rule created must be changed to match on the metadata, instead of source port. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/main.c

Re: [PATCH net] ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop

2019-06-25 Thread David Ahern
On 6/24/19 6:14 PM, Stephen Suryaputra wrote: > In commit 19e4e768064a8 ("ipv4: Fix raw socket lookup for local > traffic"), the dif argument to __raw_v4_lookup() is coming from the > returned value of inet_iif() but the change was done only for the first > lookup. Subsequent lookups in the while l

Re: [PATCH 0/1] Fix broken build of mlx5

2019-06-25 Thread Saeed Mahameed
On Tue, 2019-06-25 at 11:27 -0400, Jes Sorensen wrote: > From: Jes Sorensen > > This fixes an obvious build error that could have been caught by > simply building the code before pushing out the patch. > Hi Jes, Just tested again, as I have tested before submitting the blamed patch, and as we

Re: [PATCH 1/1] mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled

2019-06-25 Thread Saeed Mahameed
On Tue, 2019-06-25 at 11:27 -0400, Jes Sorensen wrote: > From: Jes Sorensen > > The previous patch broke the build with a static declaration for > a public function. > > Fixes: 8f0916c6dc5c (net/mlx5e: Fix ethtool rxfh commands when > CONFIG_MLX5_EN_RXNFC is disabled) > Signed-off-by: Jes Sorens

Re: [PATCH 0/1] Fix broken build of mlx5

2019-06-25 Thread Jes Sorensen
On 6/25/19 1:54 PM, Saeed Mahameed wrote: > On Tue, 2019-06-25 at 11:27 -0400, Jes Sorensen wrote: >> From: Jes Sorensen >> >> This fixes an obvious build error that could have been caught by >> simply building the code before pushing out the patch. >> > > Hi Jes, > > Just tested again, as I hav

Re: [PATCH net] net/sched: flower: fix infinite loop in fl_walk()

2019-06-25 Thread Cong Wang
Hello, On Tue, Jun 25, 2019 at 8:47 AM Davide Caratti wrote: > hello Cong, > > I tested the above patch, but I still see the infinite loop on kernel > 5.2.0-0.rc5.git0.1.fc31.i686 . > > idr_get_next_ul() returns the entry in the radix tree which is greater or > equal to '*nextid' (which has the s

Re: [PATCH v2 bpf-next 00/11] BTF-defined BPF map definitions

2019-06-25 Thread Andrii Nakryiko
On Fri, Jun 21, 2019 at 10:56 AM Andrii Nakryiko wrote: > > On Fri, Jun 21, 2019 at 3:29 AM Lorenz Bauer wrote: > > > > On Fri, 21 Jun 2019 at 05:20, Andrii Nakryiko > > wrote: > > > > > > On Thu, Jun 20, 2019 at 7:49 AM Lorenz Bauer wrote: > > > > > > > > On Tue, 18 Jun 2019 at 22:37, Andrii

Re: [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches

2019-06-25 Thread Florian Fainelli
On 6/25/19 4:20 AM, Benedikt Spranger wrote: > On Sat, 22 Jun 2019 19:24:10 -0700 > Florian Fainelli wrote: > >> Something like this should take care of that (untested). You might >> have to explicitly set the IMP port (port 8) in B53_UC_FWD_EN and >> B53_MC_FWD_EN, though since you turn on manag

[PATCH net-next 1/1] tc-testing: add ingress qdisc tests

2019-06-25 Thread Roman Mashak
Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/qdiscs/ingress.json| 102 + 1 file changed, 102 insertions(+) create mode 100644 tools/testing/selftests/tc-testing/tc-tests/qdiscs/ingress.json diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/i

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-25 Thread Joe Stringer
On Mon, Jun 24, 2019 at 11:37 PM Eric Dumazet wrote: > On 6/24/19 8:17 PM, Joe Stringer wrote: > > On Fri, Jun 21, 2019 at 1:59 PM Florian Westphal wrote: > >> Joe Stringer wrote: > >>> However, if I drop these lines then I end up causing sockets to > >>> release references too many times. Seems

[PATCH bpf-next 3/4] libbpf: add libbpf_[get|put]_bpf_permission()

2019-06-25 Thread Song Liu
This patch adds two more API to libbpf: libbpf_get_bpf_permission() and libbpf_put_bpf_permission(). For root, these two APIs are no-op. Signed-off-by: Song Liu --- tools/lib/bpf/libbpf.c | 54 tools/lib/bpf/libbpf.h | 7 ++ tools/lib/bpf/libbpf

[PATCH bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-06-25 Thread Song Liu
This patch introduce unprivileged BPF access. The access control is achieved via device /dev/bpf. Users with access to /dev/bpf are able to access BPF syscall. Two ioctl command are added to /dev/bpf: The first two commands get/put permission to access sys_bpf. This permission is noted by setting

[PATCH bpf-next 4/4] bpftool: use libbpf_[get|put]_bpf_permission()

2019-06-25 Thread Song Liu
This patch calls libbpf_[get|put]_bpf_permission() from bpftool. This allows users with access to /dev/bpf to perform operations like root. Signed-off-by: Song Liu --- tools/bpf/bpftool/feature.c | 2 +- tools/bpf/bpftool/main.c| 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff

[PATCH bpf-next 2/4] bpf: sync tools/include/uapi/linux/bpf.h

2019-06-25 Thread Song Liu
Sync changes for bpf_dev_ioctl. Signed-off-by: Song Liu --- tools/include/uapi/linux/bpf.h | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index b077507efa3f..ec3ae452cfd7 100644 --- a/tools/include/uapi/linux/bpf.h +++ b/t

[PATCH bpf-next 0/4] sys_bpf() access control via /dev/bpf

2019-06-25 Thread Song Liu
Currently, most access to sys_bpf() is limited to root. However, there are use cases that would benefit from non-privileged use of sys_bpf(), e.g. systemd. This set introduces a new model to control the access to sys_bpf(). A special device, /dev/bpf, is introduced to manage access to sys_bpf(). U

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-25 Thread Joe Stringer
On Tue, Jun 25, 2019 at 4:07 AM Jamal Hadi Salim wrote: > > On 2019-06-24 11:26 p.m., Joe Stringer wrote: > [..] > > > > I haven't got as far as UDP yet, but I didn't see any need for a > > dependency on netfilter. > > I'd be curious to see what you did. My experience, even for TCP is > the socket

RE: [PATCH net-next 10/16] qlge: Factor out duplicated expression

2019-06-25 Thread Manish Chopra
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Benjamin Poirier > Sent: Monday, June 24, 2019 1:22 PM > To: David Miller > Cc: Manish Chopra ; GR-Linux-NIC-Dev nic-...@marvell.com>; netdev@vger.kernel.org > Subject: Re: [PATCH net-next 10/16] qlge: Factor out du

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Daniel Santos
Hello, Although I'm new to the entire Ethernet / *MII subsystem and I haven't touched DSA yet, I've recently had to add some of this functionality to the older OpenWRT drivers for swconfig control over the ports.  René, do you have an actual datasheet or programming guide for the mt7530?  I only h

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-25 Thread Jonathan Lemon
On 20 Jun 2019, at 1:39, Kevin Laatz wrote: This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limits where we can place chunks within the umem a

Hola

2019-06-25 Thread Farida Hamed
Hola como estas

Re: [PATCH iproute2 1/2] devlink: fix format string warning for 32bit targets

2019-06-25 Thread Stephen Hemminger
On Tue, 25 Jun 2019 14:49:04 +0300 Baruch Siach wrote: > diff --git a/devlink/devlink.c b/devlink/devlink.c > index 436935f88bda..b400fab17578 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -1726,9 +1726,9 @@ static void pr_out_u64(struct dl *dl, const char *name, > uint64_t val

Re: [PATCH iproute2 2/2] devlink: fix libc and kernel headers collision

2019-06-25 Thread Stephen Hemminger
On Tue, 25 Jun 2019 14:49:05 +0300 Baruch Siach wrote: > +/* Suppress linux/sysinfo.h to avoid > + * collision of struct sysinfo definition > + * with musl libc headers > + */ You only need a small comment for this. #define _LINUX_SYSINFO_H /* avoid collision with musl header */

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Andrew Lunn
> But will there still be a mechanism to ignore link partner's advertising > and force these parameters? >From man 1 ethtool: -a --show-pause Queries the specified Ethernet device for pause parameter information. -A --pause Changes the pause parameters

Re: [PATCH RFC net-next 4/5] dt-bindings: net: dsa: mt7530: Add mediatek,ephy-handle to isolate ext. phy

2019-06-25 Thread Florian Fainelli
On 6/25/19 2:30 AM, René van Dorst wrote: > Quoting Florian Fainelli : > > Hi Florian > >> On 6/24/19 7:52 AM, René van Dorst wrote: >>> On some platforum the external phy can only interface to the port 5 >>> of the >>> switch because the RGMII TX and RX lines are swapped. But it still >>> can be

[PATCH net] net: make skb_dst_force return false when dst was cleared

2019-06-25 Thread Florian Westphal
XFRM and netfilter don't expect that skb_dst_force() can cause skb to lose its dst entry. I got a bug report with a skb->dst NULL dereference in netfilter output path. The backtrace contains nf_reinject(), so the dst might have been cleared when skb got queued to userspace. The xfrm part of this

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Daniel Santos
On 6/25/19 2:02 PM, Andrew Lunn wrote: >> But will there still be a mechanism to ignore link partner's advertising >> and force these parameters? > >From man 1 ethtool: > >-a --show-pause > Queries the specified Ethernet device for pause parameter > information. > >-A

Re: [PATCH net] net/sched: flower: fix infinite loop in fl_walk()

2019-06-25 Thread Cong Wang
On Tue, Jun 25, 2019 at 11:07 AM Cong Wang wrote: > On one hand, its callers should not need to worry about details > like overflow. On the other hand, in fact it does exactly what its > callers tell it to do, the problematic part is actually the > incremented id. On 64bit, it is fairly easy, we c

Re: [PATCH 00/26] Netfilter updates for net-next

2019-06-25 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 25 Jun 2019 02:12:07 +0200 > The following patches contains Netfilter updates for net-next: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git > > This batch comes with a conflict resolution between a

Re: [PATCH net] net: make skb_dst_force return false when dst was cleared

2019-06-25 Thread Eric Dumazet
On 6/25/19 12:22 PM, Florian Westphal wrote: > XFRM and netfilter don't expect that skb_dst_force() can cause skb to lose > its dst entry. > > I got a bug report with a skb->dst NULL dereference in netfilter > output path. The backtrace contains nf_reinject(), so the dst > might have been clea

Re: [PATCH net] ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop

2019-06-25 Thread David Miller
From: Stephen Suryaputra Date: Mon, 24 Jun 2019 20:14:06 -0400 > In commit 19e4e768064a8 ("ipv4: Fix raw socket lookup for local > traffic"), the dif argument to __raw_v4_lookup() is coming from the > returned value of inet_iif() but the change was done only for the first > lookup. Subsequent loo

Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-25 Thread David Miller
From: Lucas Bates Date: Mon, 24 Jun 2019 21:00:27 -0400 > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system, where the network namespace > functionality was split from the main script. > > It introduces the concept of required plugins for testcas

Re: [PATCH net] ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop

2019-06-25 Thread Stefano Brivio
On Tue, 25 Jun 2019 12:47:38 -0700 (PDT) David Miller wrote: > From: Stephen Suryaputra > Date: Mon, 24 Jun 2019 20:14:06 -0400 > > > In commit 19e4e768064a8 ("ipv4: Fix raw socket lookup for local > > traffic"), the dif argument to __raw_v4_lookup() is coming from the > > returned value of ine

Re: [PATCH net] net: make skb_dst_force return false when dst was cleared

2019-06-25 Thread Florian Westphal
Eric Dumazet wrote: > > -static inline void skb_dst_force(struct sk_buff *skb) > > +static inline bool skb_dst_force(struct sk_buff *skb) > > { > > if (skb_dst_is_noref(skb)) { > > struct dst_entry *dst = skb_dst(skb); > > @@ -313,7 +314,10 @@ static inline void skb_dst_force(stru

Re: [PATCH v4 rdma-next 2/3] RDMA/qedr: Add doorbell overflow recovery support

2019-06-25 Thread Jason Gunthorpe
On Mon, Jun 24, 2019 at 01:28:08PM +0300, Michal Kalderon wrote: > +/* Map the kernel doorbell recovery memory entry */ > +int qedr_mmap_db_rec(struct vm_area_struct *vma) > +{ > + unsigned long len = vma->vm_end - vma->vm_start; > + > + return remap_pfn_range(vma, vma->vm_start, > +

Re: [PATCH iproute2] ip/iptoken: fix dump error when ipv6 disabled

2019-06-25 Thread Stephen Hemminger
On Tue, 25 Jun 2019 17:35:50 +0800 Hangbin Liu wrote: > When we disable IPv6 from the start up (ipv6.disable=1), there will be > no IPv6 route info in the dump message. If we return -1 when > ifi->ifi_family != AF_INET6, we will get error like > > $ ip token list > Dump terminated > > which wil

Re: [PATCH bpf] bpf: fix BPF_ALU32 | BPF_ARSH on BE arches

2019-06-25 Thread Song Liu
On Tue, Jun 25, 2019 at 12:31 PM Jiong Wang wrote: > > Yauheni reported the following code do not work correctly on BE arches: > >ALU_ARSH_X: >DST = (u64) (u32) ((*(s32 *) &DST) >> SRC); >CONT; >ALU_ARSH_K: >DST = (u64) (u32) ((*(s32

Re: [PATCH net] vrf: reset rt_iif for recirculated mcast out pkts

2019-06-25 Thread David Ahern
On 6/25/19 4:33 AM, Stephen Suryaputra wrote: > @@ -363,10 +376,20 @@ int ip_mc_output(struct net *net, struct sock *sk, > struct sk_buff *skb) > #endif > ) { > struct sk_buff *newskb = skb_clone(skb, GFP_ATOMIC); > - if (newskb) > +

Re: [PATCH rdma-next v1 11/12] IB/mlx5: Implement DEVX dispatching event

2019-06-25 Thread Jason Gunthorpe
On Tue, Jun 25, 2019 at 05:41:49PM +0300, Yishai Hadas wrote: > > > > Why don't we return EIO as soon as is-destroyed happens? What is the > > > > point of flushing out the accumulated events? > > > > > > It follows the above uverb code/logic that returns existing events even in > > > that case, a

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Vladimir Oltean
Hi Russell, On 6/24/19 6:39 PM, Russell King - ARM Linux admin wrote: Hi, On Mon, Jun 24, 2019 at 04:52:47PM +0200, René van Dorst wrote: Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 237 +-- drivers/net/dsa

Re: [EXT] [PATCH V2] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-25 Thread Guilherme Piccoli
Sudarsana, let me ask you something: why does the register is reading value 0x0 always in the TX timestamp routine if the RX filter is set to None? This is the main cause of the thread reschedule thing. Of course this thread thing is important to fix, but I was discussing with my leader here and w

Re: [PATCH net] vrf: reset rt_iif for recirculated mcast out pkts

2019-06-25 Thread David Miller
From: Stephen Suryaputra Date: Tue, 25 Jun 2019 06:33:59 -0400 > Multicast egress packets has skb_rtable(skb)->rt_iif set to the oif. > Depending on the socket, these packets might be recirculated back as > input and raw sockets that are opened for them are bound to the VRF. But > since skb_rtabl

Re: [PATCH 1/1] mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled

2019-06-25 Thread David Miller
From: Jes Sorensen Date: Tue, 25 Jun 2019 11:27:08 -0400 > From: Jes Sorensen > > The previous patch broke the build with a static declaration for > a public function. > > Fixes: 8f0916c6dc5c (net/mlx5e: Fix ethtool rxfh commands when > CONFIG_MLX5_EN_RXNFC is disabled) > Signed-off-by: Jes S

Re: [net-next 1/1] tipc: simplify stale link failure criteria

2019-06-25 Thread David Miller
From: Jon Maloy Date: Tue, 25 Jun 2019 17:36:43 +0200 > In commit a4dc70d46cf1 ("tipc: extend link reset criteria for stale > packet retransmission") we made link retransmission failure events > dependent on the link tolerance, and not only of the number of failed > retransmission attempts, as we

Re: [PATCH net] vrf: reset rt_iif for recirculated mcast out pkts

2019-06-25 Thread David Ahern
On 6/25/19 2:22 PM, David Ahern wrote: > On 6/25/19 4:33 AM, Stephen Suryaputra wrote: >> @@ -363,10 +376,20 @@ int ip_mc_output(struct net *net, struct sock *sk, >> struct sk_buff *skb) >> #endif >> ) { >> struct sk_buff *newskb = skb_clone(skb, GFP_ATOMIC);

Re: [net-next 1/1] tipc: eliminate unnecessary skb expansion during retransmission

2019-06-25 Thread David Miller
From: Jon Maloy Date: Tue, 25 Jun 2019 18:08:13 +0200 > We increase the allocated headroom for the buffer copies to be > retransmitted. This eliminates the need for the lower stack levels > (UDP/IP/L2) to expand the headroom in order to add their own headers. > > Signed-off-by: Jon Maloy Appli

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Andrew Lunn
On Tue, Jun 25, 2019 at 02:27:55PM -0500, Daniel Santos wrote: > On 6/25/19 2:02 PM, Andrew Lunn wrote: > >> But will there still be a mechanism to ignore link partner's advertising > >> and force these parameters? > > >From man 1 ethtool: > > > >-a --show-pause > > Queries th

Re: [PATCH net] vrf: reset rt_iif for recirculated mcast out pkts

2019-06-25 Thread Stephen Suryaputra
On Tue, Jun 25, 2019 at 4:22 PM David Ahern wrote: > > On 6/25/19 4:33 AM, Stephen Suryaputra wrote: > > @@ -363,10 +376,20 @@ int ip_mc_output(struct net *net, struct sock *sk, > > struct sk_buff *skb) > > #endif > > ) { > > struct sk_buff *newskb = skb_cl

Re: [PATCH net-next] Revert "net: ena: ethtool: add extra properties retrieval via get_priv_flags"

2019-06-25 Thread David Miller
From: Jakub Kicinski Date: Tue, 25 Jun 2019 09:59:56 -0700 > This reverts commit 315c28d2b714 ("net: ena: ethtool: add extra properties > retrieval via get_priv_flags"). > > As discussed at netconf and on the mailing list we can't allow > for the the abuse of private flags for exposing arbitrar

Re: [net-next 1/1] tipc: rename function msg_get_wrapped() to msg_inner_hdr()

2019-06-25 Thread David Miller
From: Jon Maloy Date: Tue, 25 Jun 2019 19:37:00 +0200 > We rename the inline function msg_get_wrapped() to the more > comprehensible msg_inner_hdr(). > > Signed-off-by: Jon Maloy Applied, thanks Jon.

Re: [PATCH net-next 1/1] tc-testing: add ingress qdisc tests

2019-06-25 Thread David Miller
From: Roman Mashak Date: Tue, 25 Jun 2019 14:18:52 -0400 > Signed-off-by: Roman Mashak Applied.

What to do when a bridge port gets its pvid deleted?

2019-06-25 Thread Vladimir Oltean
Hi, A number of DSA drivers (BCM53XX, Microchip KSZ94XX, Mediatek MT7530 at the very least), as well as Mellanox Spectrum (I didn't look at all the pure switchdev drivers) try to restore the pvid to a default value on .port_vlan_del. Sure, the port stops receiving traffic when its pvid is a VLAN I

Re: [PATCH bpf-next 0/4] sys_bpf() access control via /dev/bpf

2019-06-25 Thread Stanislav Fomichev
On 06/25, Song Liu wrote: > Currently, most access to sys_bpf() is limited to root. However, there are > use cases that would benefit from non-privileged use of sys_bpf(), e.g. > systemd. > > This set introduces a new model to control the access to sys_bpf(). A > special device, /dev/bpf, is intro

Re: [PATCH net] vrf: reset rt_iif for recirculated mcast out pkts

2019-06-25 Thread David Ahern
On 6/25/19 2:42 PM, Stephen Suryaputra wrote: > On Tue, Jun 25, 2019 at 4:22 PM David Ahern wrote: >> >> On 6/25/19 4:33 AM, Stephen Suryaputra wrote: >>> @@ -363,10 +376,20 @@ int ip_mc_output(struct net *net, struct sock *sk, >>> struct sk_buff *skb) >>> #endif >>> ) { >>>

[for-next V2 04/10] linux/dim: Rename net_dim_sample() to net_dim_update_sample()

2019-06-25 Thread Saeed Mahameed
From: Tal Gilboa In order to avoid confusion between the function and the similarly named struct. In preparation for removing the 'net' prefix from dim members. Signed-off-by: Tal Gilboa Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/broadcom/bcmsysport.c| 4 ++-- drivers/net/

[for-next V2 10/10] RDMA/core: Provide RDMA DIM support for ULPs

2019-06-25 Thread Saeed Mahameed
From: Yamin Friedman Added the interface in the infiniband driver that applies the rdma_dim adaptive moderation. There is now a special function for allocating an ib_cq that uses rdma_dim. Performance improvement (ConnectX-5 100GbE, x86) running FIO benchmark over NVMf between two equal end-host

[for-next V2 03/10] linux/dim: Rename externally exposed macros

2019-06-25 Thread Saeed Mahameed
From: Tal Gilboa Renamed macros in use by external drivers. Signed-off-by: Tal Gilboa Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/broadcom/bcmsysport.c | 4 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c | 2 +- dri

[pull request][for-next V2 0/7] Generic DIM lib for netdev and RDMA

2019-06-25 Thread Saeed Mahameed
Hi Dave, Doug & Jason This series improves DIM - Dynamically-tuned Interrupt Moderation- to be generic for netdev and RDMA use-cases. From Tal and Yamin: First 7 patches provide the necessary refactoring to current net_dim library which affect some net drivers who are using the API. The last 3

[for-next V2 02/10] linux/dim: Remove "net" prefix from internal DIM members

2019-06-25 Thread Saeed Mahameed
From: Tal Gilboa Only renaming functions and structs which aren't used by an external code. Signed-off-by: Tal Gilboa Signed-off-by: Saeed Mahameed --- include/linux/dim.h | 86 include/linux/net_dim.h | 87 -

[for-next V2 07/10] linux/dim: Add completions count to dim_sample

2019-06-25 Thread Saeed Mahameed
From: Yamin Friedman Added a measurement of completions per/msec to allow for completion based dim algorithms. In order to use dynamic interrupt moderation with RDMA we need to have a different measurment than packets per second. This change is meant to prepare for adding a new DIM method. All

[for-next V2 01/10] linux/dim: Move logic to dim.h

2019-06-25 Thread Saeed Mahameed
From: Tal Gilboa In preparation for supporting more implementations of the DIM algorithm, I'm moving what would become common logic to a common library. Downstream DIM implementations will use the common lib for their implementation. Signed-off-by: Tal Gilboa Signed-off-by: Saeed Mahameed ---

[for-next V2 05/10] linux/dim: Rename externally used net_dim members

2019-06-25 Thread Saeed Mahameed
From: Tal Gilboa Removed 'net' prefix from functions and structs used by external drivers. Signed-off-by: Tal Gilboa Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/broadcom/bcmsysport.c| 16 +- drivers/net/ethernet/broadcom/bcmsysport.h| 2 +- drivers/net/ethernet/bro

[for-next V2 06/10] linux/dim: Move implementation to .c files

2019-06-25 Thread Saeed Mahameed
From: Tal Gilboa Moved all logic from dim.h and net_dim.h to dim.c and net_dim.c. This is both more structurally appealing and would allow to only expose externally used functions. Signed-off-by: Tal Gilboa Signed-off-by: Saeed Mahameed --- MAINTAINERS | 2

Re: [PATCH bpf-next] libbpf: fix max() type mismatch for 32bit

2019-06-25 Thread Song Liu
On Tue, Jun 25, 2019 at 1:28 PM Ivan Khoronzhuk wrote: > > It fixes build error for 32bit caused by type mismatch > size_t/unsigned long. > > Signed-off-by: Ivan Khoronzhuk Acked-by: Song Liu > --- > tools/lib/bpf/libbpf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[for-next V2 09/10] RDMA/nldev: Added configuration of RDMA dynamic interrupt moderation to netlink

2019-06-25 Thread Saeed Mahameed
From: Yamin Friedman Added parameter in ib_device for enabling dynamic interrupt moderation so that it can be configured in userspace using rdma tool. In order to set dim for an ib device the command is: rdma dev set [DEV] dim [on|off] Please set on/off. rdma dev show 0: mlx5_0: node_type ca fw

[for-next V2 08/10] linux/dim: Implement rdma_dim

2019-06-25 Thread Saeed Mahameed
From: Yamin Friedman rdma_dim implements a different algorithm than net_dim and is based on completions which is how we can implement interrupt moderation in RDMA. The algorithm optimizes for number of completions and ratio between completions and events. It also has a feature for fast reduction

Re: [PATCH bpf-next 0/4] sys_bpf() access control via /dev/bpf

2019-06-25 Thread Alexei Starovoitov
On 6/25/19 1:51 PM, Stanislav Fomichev wrote: > On 06/25, Song Liu wrote: >> Currently, most access to sys_bpf() is limited to root. However, there are >> use cases that would benefit from non-privileged use of sys_bpf(), e.g. >> systemd. >> >> This set introduces a new model to control the access

Re: [PATCH 1/1] mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled

2019-06-25 Thread Saeed Mahameed
On Tue, 2019-06-25 at 13:34 -0700, David Miller wrote: > From: Jes Sorensen > Date: Tue, 25 Jun 2019 11:27:08 -0400 > > > From: Jes Sorensen > > > > The previous patch broke the build with a static declaration for > > a public function. > > > > Fixes: 8f0916c6dc5c (net/mlx5e: Fix ethtool rxfh

Re: What to do when a bridge port gets its pvid deleted?

2019-06-25 Thread Vladimir Oltean
On Tue, 25 Jun 2019 at 23:49, Vladimir Oltean wrote: > > Hi, > > A number of DSA drivers (BCM53XX, Microchip KSZ94XX, Mediatek MT7530 > at the very least), as well as Mellanox Spectrum (I didn't look at all > the pure switchdev drivers) try to restore the pvid to a default value > on .port_vlan_de

Re: [PATCH net-next] Revert "net: ena: ethtool: add extra properties retrieval via get_priv_flags"

2019-06-25 Thread Machulsky, Zorik
As we agreed during Netconf discussion we'll look into other alternative - the devlink tool that should potentially answer our needs. On 6/25/19, 1:43 PM, "David Miller" wrote: From: Jakub Kicinski Date: Tue, 25 Jun 2019 09:59:56 -0700 > This reverts commit 315c28d2b714 ("n

Re: [pull request][for-next V2 0/7] Generic DIM lib for netdev and RDMA

2019-06-25 Thread Saeed Mahameed
On Tue, 2019-06-25 at 20:57 +, Saeed Mahameed wrote: > Hi Dave, Doug & Jason > > This series improves DIM - Dynamically-tuned Interrupt > Moderation- to be generic for netdev and RDMA use-cases. > > From Tal and Yamin: > > First 7 patches provide the necessary refactoring to current net_dim

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread René van Dorst
Quoting Andrew Lunn : Hi Andrew, On Tue, Jun 25, 2019 at 02:27:55PM -0500, Daniel Santos wrote: On 6/25/19 2:02 PM, Andrew Lunn wrote: >> But will there still be a mechanism to ignore link partner's advertising >> and force these parameters? > >From man 1 ethtool: > >-a --show-pause >

Re: [PATCH 1/1] mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled

2019-06-25 Thread David Miller
From: Saeed Mahameed Date: Tue, 25 Jun 2019 21:01:58 + > BTW is there a way to clear up "Awaiting Upstream" clutter [1] for mlx5 > patches that are already pulled ? > > [1] > https://patchwork.ozlabs.org/project/netdev/list/?series=&submitter=&state=8&q=mlx5&archive=&delegate= I don't unde

Re: [PATCH net-next] Revert "net: ena: ethtool: add extra properties retrieval via get_priv_flags"

2019-06-25 Thread David Miller
From: Jakub Kicinski Date: Tue, 25 Jun 2019 09:59:56 -0700 > This reverts commit 315c28d2b714 ("net: ena: ethtool: add extra properties > retrieval via get_priv_flags"). > > As discussed at netconf and on the mailing list we can't allow > for the the abuse of private flags for exposing arbitrar

Re: [PATCH 0/1] Fix broken build of mlx5

2019-06-25 Thread Saeed Mahameed
On Tue, 2019-06-25 at 14:01 -0400, Jes Sorensen wrote: > On 6/25/19 1:54 PM, Saeed Mahameed wrote: > > On Tue, 2019-06-25 at 11:27 -0400, Jes Sorensen wrote: > > > From: Jes Sorensen > > > > > > This fixes an obvious build error that could have been caught by > > > simply building the code before

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 09:02:46PM +0200, Andrew Lunn wrote: > > But will there still be a mechanism to ignore link partner's advertising > > and force these parameters? > > From man 1 ethtool: > >-a --show-pause > Queries the specified Ethernet device for pause parameter >

Re: [for-next V2 10/10] RDMA/core: Provide RDMA DIM support for ULPs

2019-06-25 Thread Sagi Grimberg
+static int ib_poll_dim_handler(struct irq_poll *iop, int budget) +{ + struct ib_cq *cq = container_of(iop, struct ib_cq, iop); + struct dim *dim = cq->dim; + int completed; + + completed = __ib_process_cq(cq, budget, cq->wc, IB_POLL_BATCH); + if (completed < budg

Re: [for-next V2 09/10] RDMA/nldev: Added configuration of RDMA dynamic interrupt moderation to netlink

2019-06-25 Thread Sagi Grimberg
On 6/25/19 1:57 PM, Saeed Mahameed wrote: From: Yamin Friedman Added parameter in ib_device for enabling dynamic interrupt moderation so that it can be configured in userspace using rdma tool. In order to set dim for an ib device the command is: rdma dev set [DEV] dim [on|off] Please set on

Re: [PATCH bpf-next 0/4] sys_bpf() access control via /dev/bpf

2019-06-25 Thread Stanislav Fomichev
On 06/25, Alexei Starovoitov wrote: > On 6/25/19 1:51 PM, Stanislav Fomichev wrote: > > On 06/25, Song Liu wrote: > >> Currently, most access to sys_bpf() is limited to root. However, there are > >> use cases that would benefit from non-privileged use of sys_bpf(), e.g. > >> systemd. > >> > >> This

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 10:41:48PM +0200, Andrew Lunn wrote: > On Tue, Jun 25, 2019 at 02:27:55PM -0500, Daniel Santos wrote: > > On 6/25/19 2:02 PM, Andrew Lunn wrote: > > >> But will there still be a mechanism to ignore link partner's advertising > > >> and force these parameters? > > > >From man

Re: [for-next V2 01/10] linux/dim: Move logic to dim.h

2019-06-25 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [for-next V2 02/10] linux/dim: Remove "net" prefix from internal DIM members

2019-06-25 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 11:24:01PM +0300, Vladimir Oltean wrote: > Hi Russell, > > On 6/24/19 6:39 PM, Russell King - ARM Linux admin wrote: > > This should be removed - state->link is not for use in mac_config. > > Even in fixed mode, the link can be brought up/down by means of a > > gpio, and th

<    1   2   3   >