On 6/25/19 1:54 PM, Saeed Mahameed wrote: > On Tue, 2019-06-25 at 11:27 -0400, Jes Sorensen wrote: >> From: Jes Sorensen <jsoren...@fb.com> >> >> This fixes an obvious build error that could have been caught by >> simply building the code before pushing out the patch. >> > > Hi Jes, > > Just tested again, as I have tested before submitting the blamed patch, > and as we test on every single new patch in our build automation. > > both combinations CONFIG_MLX5_EN_RXNFC=y/n work on latest net-next, > what am i missing ?
Linus' tree: [jes@xpeas linux.git]$ grep mlx5e_get_rxnfc drivers/net/ethernet/mellanox/mlx5/core/*.c drivers/net/ethernet/mellanox/mlx5/core/en/*.h drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:static int mlx5e_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *info, u32 *rule_locs) drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: .get_rxnfc = mlx5e_get_rxnfc, drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c:int mlx5e_get_rxnfc(struct net_device *dev, drivers/net/ethernet/mellanox/mlx5/core/en/fs.h:int mlx5e_get_rxnfc(struct net_device *dev, static vs non static functions, with a prototype that is non static. Jes
