On 2019/6/14 下午2:00, Michael S. Tsirkin wrote:
On Fri, Jun 14, 2019 at 11:28:59AM +0800, Jason Wang wrote:
On 2019/6/14 上午12:24, Willem de Bruijn wrote:
From: Willem de Bruijn
NAPI tx mode improves TCP behavior by enabling TCP small queues (TSQ).
TSQ reduces queuing ("bufferbloat") and burs
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Also, there is no need to store the individual debugfs file name, just
remove the whole directory all at once, savin
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Because we don't care if debugfs works or not, this trickles back a bit
so we can clean things up by making some fun
This set of tests is a rewrite of Edward's earlier tests:
https://patchwork.ozlabs.org/patch/877221/
Signed-off-by: Alexei Starovoitov
---
tools/testing/selftests/bpf/verifier/loops1.c | 161 ++
1 file changed, 161 insertions(+)
create mode 100644 tools/testing/selftests/bpf/ver
The commit 7640ead93924 partially resolved the issue of callees
incorrectly pruning the callers.
With introduction of bounded loops and jmps_processed heuristic
single verifier state may contain multiple branches and calls.
It's possible that new verifier state (for future pruning) will be
allocate
v1->v2: addressed Andrii's feedback.
this patch set introduces verifier support for bounded loops and
adds several other improvements.
Ideally they would be introduced one at a time,
but to support bounded loop the verifier needs to 'step back'
in the patch 1. That patch introduces tracking of spi
Allow the verifier to validate the loops by simulating their execution.
Exisiting programs have used '#pragma unroll' to unroll the loops
by the compiler. Instead let the verifier simulate all iterations
of the loop.
In order to do that introduce parentage chain of bpf_verifier_state and
'branches'
Compilers often spill induction variables into the stack,
hence it is necessary for the verifier to track scalar values
of the registers through stack slots.
Also few bpf programs were incorrectly rejected in the past,
since the verifier was not able to track such constants while
they were used to
This patch extends is_branch_taken() logic from JMP+K instructions
to JMP+X instructions.
Conditional branches are often done when src and dst registers
contain known scalars. In such case the verifier can follow
the branch that is going to be taken when program executes.
That speeds up the verific
fix tests that incorrectly assumed that the verifier
cannot track constants through stack.
Signed-off-by: Alexei Starovoitov
Acked-by: Andrii Nakryiko
---
.../bpf/verifier/direct_packet_access.c | 3 +-
.../bpf/verifier/helper_access_var_len.c | 28 ++-
2 files chang
Add a bunch of loop tests. Most of them are created by replacing
'#pragma unroll' with '#pragma clang loop unroll(disable)'
Several tests are artificially large:
/* partial unroll. llvm will unroll loop ~150 times.
* C loop count -> 600.
* Asm loop count -> 4.
* 16k insns in loop body.
Fix tests that assumed no loops.
Signed-off-by: Alexei Starovoitov
Acked-by: Andrii Nakryiko
---
tools/testing/selftests/bpf/test_verifier.c | 11 --
tools/testing/selftests/bpf/verifier/calls.c | 22
tools/testing/selftests/bpf/verifier/cfg.c | 11 ++
3
Introduce precision tracking logic that
helps cilium programs the most:
old clang old clangnew clang new clang
with all patches with all patches
bpf_lb-DLB_L3.o 1838 2728 1923 2216
bpf_lb-DLB_L4.o 3218 3562
Hi Greg,
Acked-by: Jukka Rissanen
Cheers,
Jukka
On Fri, 2019-06-14 at 09:14 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic
> should
> never do something different based on th
Thu, Jun 13, 2019 at 07:43:57PM CEST, john.hur...@netronome.com wrote:
>Currently, TC offers the ability to match on the MPLS fields of a packet
>through the use of the flow_dissector_key_mpls struct. However, as yet, TC
>actions do not allow the modification or manipulation of such fields.
>
>Add
Thu, Jun 13, 2019 at 07:43:58PM CEST, john.hur...@netronome.com wrote:
>A recent addition to TC actions is the ability to manipulate the MPLS
>headers on packets.
>
>In preparation to offload such actions to hardware, update the IR code to
>accept and prepare the new actions.
>
>Signed-off-by: John
On Fri, Jun 14, 2019 at 12:35:38AM -0700, Alexei Starovoitov wrote:
> On Fri, Jun 14, 2019 at 09:08:52AM +0200, Peter Zijlstra wrote:
> > On Thu, Jun 13, 2019 at 08:20:30PM -0500, Josh Poimboeuf wrote:
> > > On Thu, Jun 13, 2019 at 01:57:11PM -0700, Alexei Starovoitov wrote:
> >
> > > > and to pat
Patch1: Jesper showed concerns around devmap free and flush race when
reviewing my XDP bulk TX patch set, and I think indeed there is a
race. Patch1 fix it.
Patch2: While reviewing dev_map_free I found bulk queue was not freed.
Patch2 fix it.
Patch3: Some days ago David Ahern reported
.ndo_xdp_xmit() assumes it is called under RCU. For example virtio_net
uses RCU to detect it has setup the resources for tx. The assumption
accidentally broke when introducing bulk queue in devmap.
Fixes: 5d053f9da431 ("bpf: devmap prepare xdp frames for bulking")
Reported-by: David Ahern
Signed-
dev_map_free() waits for flush_needed bitmap to be empty in order to
ensure all flush operations have completed before freeing its entries.
However the corresponding clear_bit() was called before using the
entries, so the entries could be used after free.
All access to the entries needs to be done
dev_map_free() forgot to free bulk queue when freeing its entries.
Fixes: 5d053f9da431 ("bpf: devmap prepare xdp frames for bulking")
Signed-off-by: Toshiaki Makita
---
kernel/bpf/devmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index e001fb1
Thu, Jun 13, 2019 at 08:16:49AM CEST, liuhang...@gmail.com wrote:
>On Tue, May 28, 2019 at 01:24:31PM +0200, Jiri Pirko wrote:
>> Tue, May 28, 2019 at 12:02:11PM CEST, liuhang...@gmail.com wrote:
>> >On Tue, May 28, 2019 at 11:08:23AM +0200, Jiri Pirko wrote:
>> >> >+static int team_ethtool_get_lin
Mon, May 27, 2019 at 05:31:10AM CEST, liuhang...@gmail.com wrote:
>Like bond, add ethtool get_link_ksettings to show the total speed.
>
>Signed-off-by: Hangbin Liu
Acked-by: Jiri Pirko
Use extack error reporting mechanism in addition to returning -EINVAL
NL_SET_ERR_* code shamelessy copy/paste/adjusted from act_pedit &
sch_cake and used as reference as to what I should have done in the
first place.
Signed-off-by: Kevin Darbyshire-Bryant
---
net/sched/act_ctinfo.c | 23 +++
After commit b38ff4075a80, the following command does not work anymore:
$ ip xfrm state add src 10.125.0.2 dst 10.125.0.1 proto esp spi 34 reqid 1 \
mode tunnel enc 'cbc(aes)' 0xb0abdba8b782ad9d364ec81e3a7d82a1 auth-trunc \
'hmac(sha1)' 0xe26609ebd00acb6a4d51fca13e49ea78a72c73e6 96 flag align4
On 13.06.2019 21:53, Jeff Kirsher wrote:
From: "Gustavo A. R. Silva"
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function ‘i40e_run_xdp_zc’:
Le 05/06/2019 à 23:08, Lucas Bates a écrit :
> Apologies for the delay in getting this out. I've been busy
> with other things and this change was a little trickier than
> I expected.
>
> This patch restores the original behaviour for tdc prior to the
> introduction of the plugin system, where the
On Fri, Jun 14, 2019 at 02:55:47AM +0300, Ioana Ciornei wrote:
> After today's discussion with Russell King about what phylink exposes in
> .mac_config(): https://marc.info/?l=linux-netdev&m=156043794316709&w=2
> I am submitting for initial review the dpaa2-mac driver model.
>
> At the moment, pau
Hello!
On 13.06.2019 21:53, Jeff Kirsher wrote:
From: Piotr Marczak
Driver did not check response on LLDP flag change and always returned
SUCCESS.
This patch now checks for an error and returns an error code and has
additional information in the log.
Signed-off-by: Piotr Marczak
Tested-by:
On Fri, Jun 14, 2019 at 03:42:23AM +0200, Andrew Lunn wrote:
> > +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if)
> > +{
> > + switch (eth_if) {
> > + case DPMAC_ETH_IF_RGMII:
> > + return PHY_INTERFACE_MODE_RGMII;
>
> So the MAC cannot insert RGMII delays? I didn't see any
Hi Rob,
On Thu, Jun 13, 2019 at 11:32:30AM -0600, Rob Herring wrote:
> On Thu, Jun 13, 2019 at 7:25 AM Maxime Ripard
> wrote:
> > On Mon, Jun 10, 2019 at 12:59:29PM -0600, Rob Herring wrote:
> > > On Mon, Jun 10, 2019 at 8:31 AM Andrew Lunn wrote:
> > > >
> > > > > +required:
> > > > > + - com
On 2019-06-14, at 10:59:22 +0100, Jeremy Sowden wrote:
> On 2019-06-14, at 10:53:46 +0200, Steffen Klassert wrote:
> > On Fri, Jun 14, 2019 at 04:26:26PM +0800, Young Xiao wrote:
> > > We leak the allocated out_skb in case pfkey_xfrm_policy2msg()
> > > fails. Fix this by freeing it on error.
> > >
On Fri, Jun 14, 2019 at 11:13:38AM +0100, Jeremy Sowden wrote:
>
> That reminds me. Stephen Rothwell reported a problem with the "Fixes:"
> tag:
>
> On 2019-05-29, at 07:48:12 +1000, Stephen Rothwell wrote:
> > In commit
> >
> > 7c80eb1c7e2b ("af_key: fix leaks in key_pol_get_resp and dump_sp.
--
Benötigen Sie dringend einen Kredit? Wenn ja, antworten Sie für weitere
Details
On Fri, Jun 14, 2019 at 02:55:51AM +0300, Ioana Ciornei wrote:
> The dpaa2-mac driver binds to DPAA2 DPMAC objects, dynamically
> discovered on the fsl-mc bus. It acts as a proxy between the PHY
> management layer and the MC firmware, delivering any configuration
> changes to the firmware and also
On 2019-06-14, at 12:17:08 +0200, Steffen Klassert wrote:
> On Fri, Jun 14, 2019 at 11:13:38AM +0100, Jeremy Sowden wrote:
> > That reminds me. Stephen Rothwell reported a problem with the
> > "Fixes:" tag:
> >
> > On 2019-05-29, at 07:48:12 +1000, Stephen Rothwell wrote:
> > > In commit
> > >
> >
While reviewing the DPAA2 work, it has become apparent that we need
better documentation about which members of the phylink link state
structure are valid in the mac_config call. Improve this
documentation.
Signed-off-by: Russell King
---
include/linux/phylink.h | 13 -
1 file chang
On 13/06/2019 21:38, Stephen Suryaputra wrote:
> Multipath hash policy value of 0 isn't distributing since the outer IP
> dest and src aren't varied eventhough the inner ones are. Since the flow
> is on the inner ones in the case of tunneled traffic, hashing on them is
> desired.
>
> This is done
Hi Jesper,
Minot nit picks mostly,
On Thu, Jun 13, 2019 at 08:28:42PM +0200, Jesper Dangaard Brouer wrote:
> This patch is needed before we can allow drivers to use page_pool for
> DMA-mappings. Today with page_pool and XDP return API, it is possible to
> remove the page_pool object (from rhasht
Toshiaki Makita writes:
> dev_map_free() waits for flush_needed bitmap to be empty in order to
> ensure all flush operations have completed before freeing its entries.
> However the corresponding clear_bit() was called before using the
> entries, so the entries could be used after free.
>
> All a
Toshiaki Makita writes:
> .ndo_xdp_xmit() assumes it is called under RCU. For example virtio_net
> uses RCU to detect it has setup the resources for tx. The assumption
> accidentally broke when introducing bulk queue in devmap.
>
> Fixes: 5d053f9da431 ("bpf: devmap prepare xdp frames for bulking"
On Fri, Jun 14, 2019 at 09:04:38AM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Also, there is no need to store the in
On Fri, 14 Jun 2019 17:20:14 +0900
Toshiaki Makita wrote:
> dev_map_free() forgot to free bulk queue when freeing its entries.
>
> Fixes: 5d053f9da431 ("bpf: devmap prepare xdp frames for bulking")
> Signed-off-by: Toshiaki Makita
> ---
> kernel/bpf/devmap.c | 1 +
> 1 file changed, 1 insertio
On Fri, Jun 14, 2019 at 9:10 AM Jiri Pirko wrote:
>
> Thu, Jun 13, 2019 at 07:43:57PM CEST, john.hur...@netronome.com wrote:
> >Currently, TC offers the ability to match on the MPLS fields of a packet
> >through the use of the flow_dissector_key_mpls struct. However, as yet, TC
> >actions do not a
Toke Høiland-Jørgensen writes:
> Toshiaki Makita writes:
>
>> dev_map_free() waits for flush_needed bitmap to be empty in order to
>> ensure all flush operations have completed before freeing its entries.
>> However the corresponding clear_bit() was called before using the
>> entries, so the ent
On Fri, 14 Jun 2019 13:04:53 +0200
Toke Høiland-Jørgensen wrote:
> Toshiaki Makita writes:
>
> > dev_map_free() waits for flush_needed bitmap to be empty in order to
> > ensure all flush operations have completed before freeing its entries.
> > However the corresponding clear_bit() was called b
On 19/06/14 (金) 21:10:38, Toke Høiland-Jørgensen wrote:
Toke Høiland-Jørgensen writes:
Toshiaki Makita writes:
dev_map_free() waits for flush_needed bitmap to be empty in order to
ensure all flush operations have completed before freeing its entries.
However the corresponding clear_bit() wa
On 19/06/14 (金) 20:58:06, Jesper Dangaard Brouer wrote:
On Fri, 14 Jun 2019 17:20:14 +0900
Toshiaki Makita wrote:
dev_map_free() forgot to free bulk queue when freeing its entries.
Fixes: 5d053f9da431 ("bpf: devmap prepare xdp frames for bulking")
Signed-off-by: Toshiaki Makita
---
kernel/
Toshiaki Makita writes:
> On 19/06/14 (金) 21:10:38, Toke Høiland-Jørgensen wrote:
>> Toke Høiland-Jørgensen writes:
>>
>>> Toshiaki Makita writes:
>>>
dev_map_free() waits for flush_needed bitmap to be empty in order to
ensure all flush operations have completed before freeing its en
On 2019-06-13 21:09, Jakub Kicinski wrote:
> On Thu, 13 Jun 2019 14:01:39 +, Maxim Mikityanskiy wrote:
>> On 2019-06-12 23:23, Jakub Kicinski wrote:
>>> On Wed, 12 Jun 2019 15:56:48 +, Maxim Mikityanskiy wrote:
Currently, libbpf uses the number of combined channels as the maximum
On 2019-06-13 17:45, Maciej Fijalkowski wrote:
> On Thu, 13 Jun 2019 14:01:39 +
> Maxim Mikityanskiy wrote:
>
>> On 2019-06-12 23:23, Jakub Kicinski wrote:
>>> On Wed, 12 Jun 2019 15:56:48 +, Maxim Mikityanskiy wrote:
Currently, libbpf uses the number of combined channels as the maxi
On 2019-06-13 20:29, Jakub Kicinski wrote:
> On Thu, 13 Jun 2019 14:01:39 +, Maxim Mikityanskiy wrote:
>> On 2019-06-12 23:10, Jakub Kicinski wrote:
>>> On Wed, 12 Jun 2019 15:56:43 +, Maxim Mikityanskiy wrote:
The typical XDP memory scheme is one packet per page. Change the AF_XDP
>>>
in the case of IPoIB with SRIOV enabled hardware
ip link show command incorrecly prints
0 instead of a VF hardware address.
Before:
11: ib1: mtu 2044 qdisc pfifo_fast
state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd
0
in the case of IPoIB with SRIOV enabled hardware
ip link show command incorrecly prints
0 instead of a VF hardware address.
Before:
11: ib1: mtu 2044 qdisc pfifo_fast
state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd
0
in IPoIB case we can't see a VF broadcast address for but
can see for PF
Before:
11: ib1: mtu 2044 qdisc pfifo_fast
state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd
00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:f
in IPoIB case we can't see a VF broadcast address for but
can see for PF
Before:
11: ib1: mtu 2044 qdisc pfifo_fast
state UP mode DEFAULT group default qlen 256
link/infiniband
80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd
00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:f
On 6/13/19, Michal Kubecek wrote:
> On Thu, Jun 13, 2019 at 04:20:03PM +0200, Denis Kirjanov wrote:
>> in IPoIB case we can't see a VF broadcast address for but
>> can see for PF
>>
>> Before:
>> 11: ib1: mtu 2044 qdisc pfifo_fast
>> state UP mode DEFAULT group default qlen 256
>> link/infini
On Fri, Jun 14, 2019 at 3:50 AM Maxime Ripard wrote:
>
> Hi Rob,
>
> On Thu, Jun 13, 2019 at 11:32:30AM -0600, Rob Herring wrote:
> > On Thu, Jun 13, 2019 at 7:25 AM Maxime Ripard
> > wrote:
> > > On Mon, Jun 10, 2019 at 12:59:29PM -0600, Rob Herring wrote:
> > > > On Mon, Jun 10, 2019 at 8:31 A
On 2019-06-13 10:37, Magnus Karlsson wrote:
>
> This patch set adds support for a new flag called need_wakeup in the
> AF_XDP Tx and fill rings. When this flag is set by the driver, it
> means that the application has to explicitly wake up the kernel Rx
> (for the bit in the fill ring) or kernel T
On 6/13/19 11:59 AM, Andrea Claudi wrote:
> make provides a handy -C option to change directory before reading
> the makefiles or doing anything else.
>
> Use that instead of the "cd dir && make && cd .." pattern, thus
> simplifying sintax for some makefiles.
>
> Changes from v1:
> - Drop an obvi
> Subject: Re: [PATCH RFC 2/6] dpaa2-eth: add support for new link state APIs
>
> > /**
> > + * Advertised link speeds
> > + */
> > +#define DPNI_ADVERTISED_10BASET_FULL BIT_ULL(0)
> > +#define DPNI_ADVERTISED_100BASET_FULL BIT_ULL(1)
> > +#define DPNI_ADVERTISED_1000BASET_FULL
On 6/12/19 10:01 AM, Roman Mashak wrote:
> Hangbin Liu writes:
>
>> Add a new parameter '-Numeric' to show the number of protocol, scope,
>> dsfield, etc directly instead of converting it to human readable name.
>> Do the same on tc and ss.
>>
>> This patch is based on David Ahern's previous patc
> Subject: Re: [PATCH RFC 3/6] dpaa2-mac: add MC API for the DPMAC object
>
> > +/**
> > + * dpmac_set_link_state() - Set the Ethernet link status
> > + * @mc_io: Pointer to opaque I/O object
> > + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
> > + * @token: Token of DPMAC
> Subject: Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver
>
> > +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if) {
> > + switch (eth_if) {
> > + case DPMAC_ETH_IF_RGMII:
> > + return PHY_INTERFACE_MODE_RGMII;
>
> So the MAC cannot insert RGMII delays? I didn't see anyth
On Fri, 14 Jun 2019 13:38:04 +
Maxim Mikityanskiy wrote:
> On 2019-06-13 10:37, Magnus Karlsson wrote:
> >
> > This patch set adds support for a new flag called need_wakeup in the
> > AF_XDP Tx and fill rings. When this flag is set by the driver, it
> > means that the application has to expl
These patches aim to prevent act_mirred causing stack overflow events from
recursively calling packet xmit or receive functions. Such events can
occur with poor TC configuration that causes packets to travel in loops
within the system.
Florian Westphal advises that a recursion crash and packets lo
The TC_ACT_REINSERT return type was added as an in-kernel only option to
allow a packet ingress or egress redirect. This is used to avoid
unnecessary skb clones in situations where they are not required. If a TC
hook returns this code then the packet is 'reinserted' and no skb consume
is carried ou
TC hooks allow the application of filters and actions to packets at both
ingress and egress of the network stack. It is possible, with poor
configuration, that this can produce loops whereby an ingress hook calls
a mirred egress action that has an egress hook that redirects back to
the first ingres
On 6/11/19 10:10 AM, Matteo Croce wrote:
> Refactor the netns and ipvrf code so less steps are needed to exec commands
> in a netns or a VRF context.
> Also remove some code which became dead. bloat-o-meter output:
>
This breaks the vrf reset after namespace switch
# ip vrf ls
Name
John Hurley wrote:
> TC hooks allow the application of filters and actions to packets at both
> ingress and egress of the network stack. It is possible, with poor
> configuration, that this can produce loops whereby an ingress hook calls
> a mirred egress action that has an egress hook that redire
From: Shijie Luo
Suppose we have two interfaces eth0 and eth1 in two hosts, follow
the same steps in the two hosts:
# sysctl -w net.ipv4.conf.eth1.route_localnet=1
# sysctl -w net.ipv4.conf.eth1.arp_announce=2
# ip route del 127.0.0.0/8 dev lo table local
and then set ip to eth1 in host1 like:
#
Hi,
On Fri, Jun 14, 2019 at 07:37:49AM -0600, Rob Herring wrote:
> > > For '-gpio', we may be okay because the suffix is handled in the GPIO
> > > core. It should be safe to update the binding to use the preferred
> > > form.
> >
> > It might require a bit of work though in drivers, since the fall
This patchset introduces a new TC action module that allows the
manipulation of the MPLS headers of packets. The code impliments
functionality including push, pop, and modify.
Also included are tests for the new funtionality. Note that these will
require iproute2 changes to be submitted soon.
v2-
Add a new series of selftests to verify the functionality of act_mpls in
TC.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
---
.../tc-testing/tc-tests/actions/mpls.json | 744 +
1 file changed, 744 insertions(+)
create mode 100644
tools/testing/selftests/
Currently, TC offers the ability to match on the MPLS fields of a packet
through the use of the flow_dissector_key_mpls struct. However, as yet, TC
actions do not allow the modification or manipulation of such fields.
Add a new module that registers TC action ops to allow manipulation of
MPLS. Thi
Alexei Starovoitov writes:
> On Wed, Jun 12, 2019 at 8:25 AM Jiong Wang wrote:
>>
>>
>> Jiong Wang writes:
>>
>> > Alexei Starovoitov writes:
>> >
>> >> On Wed, Jun 12, 2019 at 4:32 AM Naveen N. Rao
>> >> wrote:
>> >>>
>> >>> Currently, for constant blinding, we re-allocate the bpf program to
> Subject: Re: [PATCH RFC 0/6] DPAA2 MAC Driver
>
> On Fri, Jun 14, 2019 at 02:55:47AM +0300, Ioana Ciornei wrote:
> > After today's discussion with Russell King about what phylink exposes
> > in
> > .mac_config(): https://marc.info/?l=linux-netdev&m=156043794316709&w=2
> > I am submitting for ini
From: Heiner Kallweit
Date: Fri, 14 Jun 2019 07:51:33 +0200
> Few registers have been added or changed its purpose with version
> RTL8168e-vl, so create a helper for identifying chip versions from
> RTL8168e-vl.
Series applied, thanks Heiner.
From: Greg Kroah-Hartman
Date: Fri, 14 Jun 2019 09:04:38 +0200
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Also, there is no need to store the indiv
From: Jiri Pirko
Date: Fri, 14 Jun 2019 10:32:25 +0200
> Long story short, I'm okay with your patch. Thanks!
This patch should therefore be reposted.
From: Kevin Darbyshire-Bryant
Date: Fri, 14 Jun 2019 10:09:44 +0100
> Use extack error reporting mechanism in addition to returning -EINVAL
>
> NL_SET_ERR_* code shamelessy copy/paste/adjusted from act_pedit &
> sch_cake and used as reference as to what I should have done in the
> first place.
>
From: Sergei Shtylyov
Date: Fri, 14 Jun 2019 12:42:52 +0300
> On 13.06.2019 21:53, Jeff Kirsher wrote:
>
>> + "Device configuration forbids SW from starting the LLDP agent.\n");
>> +return (-EINVAL);
>
>() not needed. None was used above, so why have them
On Fri, Jun 14, 2019 at 11:13:55AM +0200, Nicolas Dichtel wrote:
> After commit b38ff4075a80, the following command does not work anymore:
> $ ip xfrm state add src 10.125.0.2 dst 10.125.0.1 proto esp spi 34 reqid 1 \
> mode tunnel enc 'cbc(aes)' 0xb0abdba8b782ad9d364ec81e3a7d82a1 auth-trunc \
>
From: Russell King - ARM Linux admin
Date: Fri, 14 Jun 2019 11:37:49 +0100
> While reviewing the DPAA2 work, it has become apparent that we need
> better documentation about which members of the phylink link state
> structure are valid in the mac_config call. Improve this
> documentation.
>
> S
On Fri, Jun 14, 2019 at 12:26 AM Alexei Starovoitov wrote:
>
> Compilers often spill induction variables into the stack,
> hence it is necessary for the verifier to track scalar values
> of the registers through stack slots.
>
> Also few bpf programs were incorrectly rejected in the past,
> since
On 06/13, Stanislav Fomichev wrote:
> > > My canonical example when reasoning about multiple progs was that each one
> > > of them would implement handling for a particular level+optname. So only
> > > a single one form the chain would return 2 or 0, the rest would return 1
> > > without touching t
> Subject: Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver
>
> On Fri, Jun 14, 2019 at 02:55:51AM +0300, Ioana Ciornei wrote:
> > The dpaa2-mac driver binds to DPAA2 DPMAC objects, dynamically
> > discovered on the fsl-mc bus. It acts as a proxy between the PHY
> > management layer and the MC
On Fri, Jun 14, 2019 at 12:26 AM Alexei Starovoitov wrote:
>
> This patch extends is_branch_taken() logic from JMP+K instructions
> to JMP+X instructions.
> Conditional branches are often done when src and dst registers
> contain known scalars. In such case the verifier can follow
> the branch tha
On Wed, Jun 12, 2019 at 11:52 AM Jakub Kicinski
wrote:
>
> Brendan reports that the use of netem's packet corruption capability
> leads to strange crashes. This seems to be caused by
> commit d66280b12bd7 ("net: netem: use a list in addition to rbtree")
> which uses skb->next pointer to construct
On Fri, Jun 14, 2019 at 12:26 AM Alexei Starovoitov wrote:
>
> Add a bunch of loop tests. Most of them are created by replacing
> '#pragma unroll' with '#pragma clang loop unroll(disable)'
>
> Several tests are artificially large:
> /* partial unroll. llvm will unroll loop ~150 times.
>* C l
> Subject: Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver
>
> On Fri, Jun 14, 2019 at 03:42:23AM +0200, Andrew Lunn wrote:
> > > +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if) {
> > > + switch (eth_if) {
> > > + case DPMAC_ETH_IF_RGMII:
> > > + return PHY_INTERFACE_MODE_RGMI
On Thu, Jun 13, 2019 at 10:44 AM John Hurley wrote:
> +static inline void tcf_mpls_set_eth_type(struct sk_buff *skb, __be16
> ethertype)
> +{
> + struct ethhdr *hdr = eth_hdr(skb);
> +
> + skb_postpull_rcsum(skb, &hdr->h_proto, ETH_TLEN);
> + hdr->h_proto = ethertype;
> +
On Fri, Jun 14, 2019 at 04:54:56PM +, Ioana Ciornei wrote:
> > Subject: Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver
> >
> > On Fri, Jun 14, 2019 at 03:42:23AM +0200, Andrew Lunn wrote:
> > > > +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if) {
> > > > + switch (eth_if) {
On Fri, Jun 14, 2019 at 8:13 AM Jiong Wang wrote:
>
>
> Alexei Starovoitov writes:
>
> > On Wed, Jun 12, 2019 at 8:25 AM Jiong Wang wrote:
> >>
> >>
> >> Jiong Wang writes:
> >>
> >> > Alexei Starovoitov writes:
> >> >
> >> >> On Wed, Jun 12, 2019 at 4:32 AM Naveen N. Rao
> >> >> wrote:
> >> >>>
On Fri, 14 Jun 2019 13:25:24 +
Maxim Mikityanskiy wrote:
> On 2019-06-13 17:45, Maciej Fijalkowski wrote:
> > On Thu, 13 Jun 2019 14:01:39 +
> > Maxim Mikityanskiy wrote:
> >
> >> On 2019-06-12 23:23, Jakub Kicinski wrote:
> >>> On Wed, 12 Jun 2019 15:56:48 +, Maxim Mikityanskiy
On 6/14/19 8:58 AM, John Hurley wrote:
> Currently, TC offers the ability to match on the MPLS fields of a packet
> through the use of the flow_dissector_key_mpls struct. However, as yet, TC
> actions do not allow the modification or manipulation of such fields.
>
> Add a new module that registers
Signed-off-by: Pete Morici
---
ip/ipmacsec.c| 28 +++-
man/man8/ip-macsec.8 | 2 +-
2 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/ip/ipmacsec.c b/ip/ipmacsec.c
index 54cd2b8..ad6ad7d 100644
--- a/ip/ipmacsec.c
+++ b/ip/ipmacsec.c
@@ -95,7 +95,7
Add JSON output support to q_netem.
The normal output is untouched.
In JSON output always use seconds as the base of time units,
and non-percentage numbers (0.01 instead of 1%). Try to always
report the fields, even if they are zero.
All this should make the output more machine-friendly.
Signed-
On Fri, 2019-06-14 at 15:32 +0200, Denis Kirjanov wrote:
> in IPoIB case we can't see a VF broadcast address for but
> can see for PF
>
> Before:
> 11: ib1: mtu 2044 qdisc pfifo_fast
> state UP mode DEFAULT group default qlen 256
> link/infiniband
> 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:0
--
Greetings,
I have an intending proposal for you please i need you to contact my
private
E-mail (dralbertddzo...@gmail.com) for more updates,
Best Wishes.
DR ALBERT ZONGO
--
1 - 100 of 199 matches
Mail list logo
