From: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>
Date: Fri, 14 Jun 2019 12:42:52 +0300

> On 13.06.2019 21:53, Jeff Kirsher wrote:
> 
>> + "Device configuration forbids SW from starting the LLDP agent.\n");
>> +                                    return (-EINVAL);
> 
>    () not needed. None was used above, so why have them here?
 ...
>> +                                             i40e_aq_str(&pf->hw,
>> +                                                         adq_err));
>> +                                    return (-EINVAL);
> 
>    Neither they are needed here...

Yeah these need to be fixed.

Reply via email to