Re: EoGRE sends undersized frames without padding

2019-06-05 Thread Steinar H. Gunderson
On Tue, Jun 04, 2019 at 09:31:42PM -0700, Cong Wang wrote: >> This works fine for large packets, but the system in the other end >> drops smaller packets, such as ARP requests and small ICMP pings. > Is the other end Linux too? Yes and no. The other end is Linux with Open vSwitch, which sends the

Re: [PATCH v2 bpf-next 1/2] xdp: Add tracepoint for bulk XDP_TX

2019-06-05 Thread Jesper Dangaard Brouer
On Wed, 5 Jun 2019 14:36:12 +0900 Toshiaki Makita wrote: > This is introduced for admins to check what is happening on XDP_TX when > bulk XDP_TX is in use, which will be first introduced in veth in next > commit. Is the plan that this tracepoint 'xdp:xdp_bulk_tx' should be used by all drivers?

Re: Cutting the link on ndo_stop - phy_stop or phy_disconnect?

2019-06-05 Thread Vladimir Oltean
On Wed, 5 Jun 2019 at 06:06, Florian Fainelli wrote: > > > > On 6/4/2019 4:46 PM, Vladimir Oltean wrote: > > On Wed, 5 Jun 2019 at 02:24, Russell King - ARM Linux admin > > wrote: > >> > >> On Wed, Jun 05, 2019 at 02:03:19AM +0300, Vladimir Oltean wrote: > >>> On Wed, 5 Jun 2019 at 01:59, Russell

Re: [PATCH net-next 2/3] indirect call wrappers: add helpers for 3 and 4 ways switch

2019-06-05 Thread Paolo Abeni
On Mon, 2019-06-03 at 22:27 +, Saeed Mahameed wrote: > On Mon, 2019-06-03 at 11:51 +0200, Paolo Abeni wrote: > > On Fri, 2019-05-31 at 18:30 +, Saeed Mahameed wrote: > > > On Fri, 2019-05-31 at 14:53 +0200, Paolo Abeni wrote: > > > > Experimental results[1] has shown that resorting to sever

Re: Cutting the link on ndo_stop - phy_stop or phy_disconnect?

2019-06-05 Thread Russell King - ARM Linux admin
On Tue, Jun 04, 2019 at 07:25:46PM -0700, Florian Fainelli wrote: > On 6/4/2019 2:36 PM, Russell King - ARM Linux admin wrote: > > Normally the PHY receives traffic, and passes it to the MAC which > > just ignores the signals it receives from the PHY, so no processing > > beyond the PHY receiving t

Re: [PATCH v4 bpf-next 1/2] bpf: Allow bpf_map_lookup_elem() on an xskmap

2019-06-05 Thread Björn Töpel
On Tue, 4 Jun 2019 at 20:13, Martin Lau wrote: > > On Tue, Jun 04, 2019 at 10:25:23AM -0700, Jonathan Lemon wrote: > > On 4 Jun 2019, at 9:43, Jesper Dangaard Brouer wrote: > > > > > On Mon, 3 Jun 2019 09:38:51 -0700 > > > Jonathan Lemon wrote: > > > > > >> Currently, the AF_XDP code uses a separ

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-05 Thread Petr Machata
Richard Cochran writes: > On Mon, Jun 03, 2019 at 03:12:42PM +0300, Ido Schimmel wrote: >> +struct mlxsw_sp_ptp_clock * >> +mlxsw_sp1_ptp_clock_init(struct mlxsw_sp *mlxsw_sp, struct device *dev) [...] >> +clock->ptp_info = mlxsw_sp1_ptp_clock_info; >> +clock->ptp = ptp_clock_register(

Re: [RFC PATCH bpf-next 1/4] libbpf: fill the AF_XDP fill queue before bind() call

2019-06-05 Thread Björn Töpel
On Tue, 4 Jun 2019 at 17:06, Maciej Fijalkowski wrote: > > On Tue, 4 Jun 2019 10:06:36 +0200 > Björn Töpel wrote: > > > On 2019-06-03 15:19, Maciej Fijalkowski wrote: > > > Let's get into the driver via ndo_bpf with command set to XDP_SETUP_UMEM > > > with fill queue that already contains some av

Re: [RFC PATCH bpf-next 3/4] libbpf: move xdp program removal to libbpf

2019-06-05 Thread Björn Töpel
On Tue, 4 Jun 2019 at 17:07, Maciej Fijalkowski wrote: > > On Tue, 4 Jun 2019 10:07:25 +0200 > Björn Töpel wrote: > > > > > On 2019-06-03 15:19, Maciej Fijalkowski wrote: > > > Since xsk support in libbpf loads the xdp program interface, make it > > > also responsible for its removal. Store the p

Re: [RFC PATCH bpf-next 4/4] libbpf: don't remove eBPF resources when other xsks are present

2019-06-05 Thread Björn Töpel
On Tue, 4 Jun 2019 at 17:07, Maciej Fijalkowski wrote: > > On Tue, 4 Jun 2019 10:08:03 +0200 > Björn Töpel wrote: > > > On 2019-06-03 15:19, Maciej Fijalkowski wrote: > > > In case where multiple xsk sockets are attached to a single interface > > > and one of them gets detached, the eBPF maps and

Re: Cutting the link on ndo_stop - phy_stop or phy_disconnect?

2019-06-05 Thread Russell King - ARM Linux admin
On Wed, Jun 05, 2019 at 11:27:59AM +0300, Vladimir Oltean wrote: > On Wed, 5 Jun 2019 at 06:06, Florian Fainelli wrote: > > > > > > > > On 6/4/2019 4:46 PM, Vladimir Oltean wrote: > > > On Wed, 5 Jun 2019 at 02:24, Russell King - ARM Linux admin > > > wrote: > > >> > > >> On Wed, Jun 05, 2019 at

[PATCH net-next 0/3] dpaa2-eth: Add support for MQPRIO offloading

2019-06-05 Thread Ioana Radulescu
Add support for adding multiple TX traffic classes with mqprio. We have one netdev queue and one hardware frame queue per TC. Ioana Radulescu (3): dpaa2-eth: Refactor xps code dpaa2-eth: Support multiple traffic classes on Tx dpaa2-eth: Add mqprio support drivers/net/ethernet/freescale/dpa

[PATCH net-next 3/3] dpaa2-eth: Add mqprio support

2019-06-05 Thread Ioana Radulescu
Implement mqprio qdisc support by mapping traffic classes to different hardware enqueue priorities. The maximum number of supported traffic classes is an attribute of each DPNI object. The traffic classes map to hardware priorities from highest (0) to lowest (highest prio number). The driver assig

[PATCH net-next 2/3] dpaa2-eth: Support multiple traffic classes on Tx

2019-06-05 Thread Ioana Radulescu
DPNI objects can have multiple traffic classes, as reflected by the num_tc attribute. Until now we ignored its value and only used traffic class 0. This patch adds support for multiple Tx traffic classes; the skb priority information received from the stack is used to select the hardware Tx queue

[PATCH net-next 1/3] dpaa2-eth: Refactor xps code

2019-06-05 Thread Ioana Radulescu
Move the code configuring xps on the netdev TX queues to a separate function. A subsequent patch will need to call this in another context as well. Signed-off-by: Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 45 +--- 1 file changed, 32 insertions(+),

Re: [PATCH bpf] selftests/bpf: move test_lirc_mode2_user to TEST_GEN_PROGS_EXTENDED

2019-06-05 Thread Daniel Borkmann
On 06/04/2019 04:35 AM, Hangbin Liu wrote: > test_lirc_mode2_user is included in test_lirc_mode2.sh test and should > not be run directly. > > Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program") > Signed-off-by: Hangbin Liu Applied, thanks!

Re: [PATCH net-next 1/2] bpf_xdp_redirect_map: Add flag to return XDP_PASS on map lookup failure

2019-06-05 Thread Jesper Dangaard Brouer
On Tue, 04 Jun 2019 17:24:10 +0200 Toke Høiland-Jørgensen wrote: > The bpf_redirect_map() helper used by XDP programs doesn't return any > indication of whether it can successfully redirect to the map index it was > given. Instead, BPF programs have to track this themselves, leading to > progra

[PATCH] net: phy: marvell10g: allow PHY to probe without firmware

2019-06-05 Thread Russell King
Allow the PHY to probe when there is no firmware, but do not allow the link to come up by forcing the PHY state to PHY_HALTED in a similar way to phy_error(). Signed-off-by: Russell King --- Depends on "net: phy: marvell10g: report if the PHY fails to boot firmware" drivers/net/phy/marvell10g.c

[PATCH net] inet_connection_sock: remove unused parameter of reqsk_queue_unlink func

2019-06-05 Thread Zhiqiang Liu
small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink func is never used in the func, so we can remove it. Signed-off-by: Zhiqiang Liu --- net/ipv4/inet_connection_sock.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/ipv4/inet_connectio

Re: [RFC][PATCH kernel_bpf] honor CAP_NET_ADMIN for BPF_PROG_LOAD

2019-06-05 Thread Andreas Steinmetz
On Tue, 2019-05-28 at 14:04 -0700, Song Liu wrote: > > if (type != BPF_PROG_TYPE_SOCKET_FILTER && > > type != BPF_PROG_TYPE_CGROUP_SKB && > > You should extend this if () statement instead of adding another > if () below. Reworking the if-statement is possible but the result

Re: [RFC][PATCH kernel_bpf] honor CAP_NET_ADMIN for BPF_PROG_LOAD

2019-06-05 Thread Andreas Steinmetz
On Mon, 2019-06-03 at 19:12 +0200, Nicolas Dichtel wrote: > It makes sense to me. > Do you plan to submit it formally? > > Looking a bit more at this topic, I see that most part of the bpf > code uses > capable(CAP_NET_ADMIN). I don't see why we cannot use > ns_capable(CAP_NET_ADMIN). If there is

Re: Cutting the link on ndo_stop - phy_stop or phy_disconnect?

2019-06-05 Thread Vladimir Oltean
On Wed, 5 Jun 2019 at 12:31, Russell King - ARM Linux admin wrote: > > On Wed, Jun 05, 2019 at 11:27:59AM +0300, Vladimir Oltean wrote: > > On Wed, 5 Jun 2019 at 06:06, Florian Fainelli wrote: > > > > > > > > > > > > On 6/4/2019 4:46 PM, Vladimir Oltean wrote: > > > > On Wed, 5 Jun 2019 at 02:24,

Re: [PATCH V2] Fix memory leak in sctp_process_init

2019-06-05 Thread Neil Horman
On Wed, Jun 05, 2019 at 04:16:24AM +0800, Xin Long wrote: > On Tue, Jun 4, 2019 at 4:34 AM Neil Horman wrote: > > > > syzbot found the following leak in sctp_process_init > > BUG: memory leak > > unreferenced object 0x88810ef68400 (size 1024): > > comm "syz-executor273", pid 7046, jiffies 42

Re: [PATCH net-next 4/9] mlxsw: reg: Add Management UTC Register

2019-06-05 Thread Shalom Toledo
On 04/06/2019 17:17, Richard Cochran wrote: > On Mon, Jun 03, 2019 at 03:12:39PM +0300, Ido Schimmel wrote: >> From: Shalom Toledo >> >> The MTUTC register configures the HW UTC counter. > > Why is this called the "UTC" counter? > > The PTP time scale is TAI. Is this counter intended to reflect

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-05 Thread Shalom Toledo
On 04/06/2019 17:28, Richard Cochran wrote: > On Mon, Jun 03, 2019 at 03:12:42PM +0300, Ido Schimmel wrote: > >> +static int >> +mlxsw_sp1_ptp_update_phc_settime(struct mlxsw_sp_ptp_clock *clock, u64 nsec) > > Six words ^^^ > > What is wrong with "mlxsw_phc_settime" ? I can drop the "update". B

Re: [PATCH net-next 6/9] ptp: ptp_clock: Publish scaled_ppm_to_ppb

2019-06-05 Thread Shalom Toledo
On 04/06/2019 17:21, Richard Cochran wrote: > On Mon, Jun 03, 2019 at 03:12:41PM +0300, Ido Schimmel wrote: >> From: Shalom Toledo >> >> Publish scaled_ppm_to_ppb to allow drivers to use it. > > But why? See my comment in patch #7 > >> @@ -63,7 +63,7 @@ static void enqueue_external_timestamp(s

[PATCH v3 net 0/4] s390/qeth: fixes 2019-06-05

2019-06-05 Thread Julian Wiedmann
Hi Dave, one more shot... now with patch 2 fixed up so that it uses the dst entry returned from dst_check(). >From the v1 cover letter: Please apply the following set of qeth fixes to -net. - The first two patches fix issues in the L3 driver's cast type selection for transmitted skbs. - Ale

[PATCH v3 net 4/4] s390/qeth: handle error when updating TX queue count

2019-06-05 Thread Julian Wiedmann
netif_set_real_num_tx_queues() can return an error, deal with it. Fixes: 73dc2daf110f ("s390/qeth: add TX multiqueue support for OSA devices") Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff

[PATCH v3 net 1/4] s390/qeth: handle limited IPv4 broadcast in L3 TX path

2019-06-05 Thread Julian Wiedmann
When selecting the cast type of a neighbourless IPv4 skb (eg. on a raw socket), qeth_l3 falls back to the packet's destination IP address. For this case we should classify traffic sent to 255.255.255.255 as broadcast. This fixes DHCP requests, which were misclassified as unicast (and for IQD interf

[PATCH v3 net 2/4] s390/qeth: check dst entry before use

2019-06-05 Thread Julian Wiedmann
While qeth_l3 uses netif_keep_dst() to hold onto the dst, a skb's dst may still have been obsoleted (via dst_dev_put()) by the time that we end up using it. The dst then points to the loopback interface, which means the neighbour lookup in qeth_l3_get_cast_type() determines a bogus cast type of RTN

[PATCH v3 net 3/4] s390/qeth: fix VLAN attribute in bridge_hostnotify udev event

2019-06-05 Thread Julian Wiedmann
From: Alexandra Winter Enabling sysfs attribute bridge_hostnotify triggers a series of udev events for the MAC addresses of all currently connected peers. In case no VLAN is set for a peer, the device reports the corresponding MAC addresses with VLAN ID 4096. This currently results in attribute V

Re: [RFC][PATCH kernel_bpf] honor CAP_NET_ADMIN for BPF_PROG_LOAD

2019-06-05 Thread Nicolas Dichtel
Le 05/06/2019 à 12:59, Andreas Steinmetz a écrit : [snip] > If there is a change for this to get accepted, sure, I'm willing to > submit this formally (need some advice, though). At least, you need to submit it without the RFC tag. RFC patches are not aimed to be merged. Regards, Nicolas

[ipsec-next:testing 4/6] net/xfrm/xfrm_state.c:1792:9: error: '__xfrm6_tmpl_sort_cmp' undeclared; did you mean 'xfrm_tmpl_sort'?

2019-06-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git testing head: ca78a3eaad69bd08ba41c144c21881dc694d4a32 commit: 8dc6e3891a4be64c0cca5e8fe2c3ad33bc06543e [4/6] xfrm: remove state and template sort indirections from xfrm_state_afinfo config: i386-randconfig-x003-201

Re: Cutting the link on ndo_stop - phy_stop or phy_disconnect?

2019-06-05 Thread Russell King - ARM Linux admin
On Wed, Jun 05, 2019 at 02:46:13AM +0300, Vladimir Oltean wrote: > On Wed, 5 Jun 2019 at 02:24, Russell King - ARM Linux admin > wrote: > > No - but that has nothing to do with phylib internals, more to do with > > the higher levels of networking. ndo_stop() will not be called unless > > ndo_open

Re: DSA with MV88E6321 and imx28

2019-06-05 Thread Andrew Lunn
> I got the devicetree from somebody that is why German is in it. But > first I wanted to get it running before I tidy it up. The switch is > strapped to single mode (so I can read SMI addresses 0x10-0x16 and > 0x1b-0x1e directly). Hi Benjamin You have miss-understood what reg means. There are

[PATCH net] pktgen: do not sleep with the thread lock held.

2019-06-05 Thread Paolo Abeni
Currently, the process issuing a "start" command on the pktgen procfs interface, acquires the pktgen thread lock and never release it, until all pktgen threads are completed. The above can blocks indefinitely any other pktgen command and any (even unrelated) netdevice removal - as the pktgen netdev

Re: Cutting the link on ndo_stop - phy_stop or phy_disconnect?

2019-06-05 Thread Russell King - ARM Linux admin
On Wed, Jun 05, 2019 at 01:16:31PM +0100, Russell King - ARM Linux admin wrote: > On Wed, Jun 05, 2019 at 02:46:13AM +0300, Vladimir Oltean wrote: > > On Wed, 5 Jun 2019 at 02:24, Russell King - ARM Linux admin > > wrote: > > > No - but that has nothing to do with phylib internals, more to do with

Re: [PATCH] net: phy: marvell10g: allow PHY to probe without firmware

2019-06-05 Thread Andrew Lunn
On Wed, Jun 05, 2019 at 11:43:16AM +0100, Russell King wrote: > Allow the PHY to probe when there is no firmware, but do not allow the > link to come up by forcing the PHY state to PHY_HALTED in a similar way > to phy_error(). > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew

Re: [ipsec-next:testing 4/6] net/xfrm/xfrm_state.c:1792:9: error: '__xfrm6_tmpl_sort_cmp' undeclared; did you mean 'xfrm_tmpl_sort'?

2019-06-05 Thread Florian Westphal
kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git > testing > head: ca78a3eaad69bd08ba41c144c21881dc694d4a32 > commit: 8dc6e3891a4be64c0cca5e8fe2c3ad33bc06543e [4/6] xfrm: remove state and > template sort indirections from xfrm_state_

[PATCH v3 net-next] net: fec_ptp: Use dev_err() instead of pr_err()

2019-06-05 Thread Fabio Estevam
dev_err() is more appropriate for printing error messages inside drivers, so switch to dev_err(). Signed-off-by: Fabio Estevam Acked-by: Fugang Duan --- Changes since v2: - Made it a standalone patch - Collected Andy's Ack drivers/net/ethernet/freescale/fec_ptp.c | 2 +- 1 file changed, 1 inse

Re: DSA with MV88E6321 and imx28

2019-06-05 Thread Benjamin Beckmeyer
>> I got the devicetree from somebody that is why German is in it. But >> first I wanted to get it running before I tidy it up. The switch is >> strapped to single mode (so I can read SMI addresses 0x10-0x16 and >> 0x1b-0x1e directly). > Hi Benjamin > > You have miss-understood what reg means. > >

Re: DSA with MV88E6321 and imx28

2019-06-05 Thread Andrew Lunn
> Here is my device tree > > mdio { > #address-cells = <1>; > #size-cells = <0>; > > switch0: switch0@0 { > compatible = "marvell,mv88e6085"; > reg = <0x0>; > pinctrl-0 = <&lcd

[RFC net-next 0/2] net: stmmac: Convert to phylink

2019-06-05 Thread Jose Abreu
For review and testing only. This converts stmmac to use phylink. Besides the code redution this will allow to gain more flexibility. Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Jose Abreu (2): net: stmmac: Prepare to convert to phylink net: stmmac: Con

Re: DSA with MV88E6321 and imx28

2019-06-05 Thread Benjamin Beckmeyer
>> Here is my device tree >> >> mdio { >> #address-cells = <1>; >> #size-cells = <0>; >> >> switch0: switch0@0 { >> compatible = "marvell,mv88e6085"; >> reg = <0x0>; >> pinctrl-0

Re: [PATCH net] inet_connection_sock: remove unused parameter of reqsk_queue_unlink func

2019-06-05 Thread Eric Dumazet
On 6/5/19 3:49 AM, Zhiqiang Liu wrote: > small cleanup: "struct request_sock_queue *queue" parameter of > reqsk_queue_unlink > func is never used in the func, so we can remove it. > > Signed-off-by: Zhiqiang Liu > --- SGTM Reviewed-by: Eric Dumazet

[PATCH v2 net-next 0/2] ipv6: tcp: more control on RST flowlabels

2019-06-05 Thread Eric Dumazet
First patch allows to reflect incoming IPv6 flowlabel on RST packets sent when no socket could handle the packet. Second patch makes sure we send the same flowlabel for RST or ACK packets on behalf of TIME_WAIT sockets. Eric Dumazet (2): ipv6: tcp: enable flowlabel reflection in some RST packet

[PATCH v2 net-next 1/2] ipv6: tcp: enable flowlabel reflection in some RST packets

2019-06-05 Thread Eric Dumazet
When RST packets are sent because no socket could be found, it makes sense to use flowlabel_reflect sysctl to decide if a reflection of the flowlabel is requested. This extends commit 22b6722bfa59 ("ipv6: Add sysctl for per namespace flow label reflection"), for some TCP RST packets. In order to

[PATCH v2 net-next 2/2] ipv6: tcp: send consistent flowlabel in TIME_WAIT state

2019-06-05 Thread Eric Dumazet
After commit 1d13a96c74fc ("ipv6: tcp: fix flowlabel value in ACK messages"), we stored in tw_flowlabel the flowlabel, in the case ACK packets needed to be sent on behalf of a TIME_WAIT socket. We can use the same field so that RST packets sent from TIME_WAIT state also use a consistent flowlabel.

[PATCH 2/2] net: stmmac: socfpga: fix phy and ptp_ref setup for Arria10/Stratix10

2019-06-05 Thread Dinh Nguyen
On the Arria10, Agilex, and Stratix10 SoC, there are a few differences from the Cyclone5 and Arria5: - The emac PHY setup bits are in separate registers. - The PTP reference clock select mask is different. - The register to enable the emac signal from FPGA is different. Thus, this patch creates

[PATCH 1/2] dt-bindings: socfpga-dwmac: add "altr,socfpga-stmmac-a10-s10" binding

2019-06-05 Thread Dinh Nguyen
Add the "altr,socfpga-stmmac-a10-s10" binding for Arria10/Agilex/Stratix10 implementation of the stmmac ethernet controller. On the Arria10, Agilex, and Stratix10 SoCs, there are a few differences from the Cyclone5 and Arria5: - The emac PHY setup bits are in separate registers. - The PT

Re: [PATCH net-next 1/2] bpf_xdp_redirect_map: Add flag to return XDP_PASS on map lookup failure

2019-06-05 Thread Jonathan Lemon
On 5 Jun 2019, at 3:39, Jesper Dangaard Brouer wrote: On Tue, 04 Jun 2019 17:24:10 +0200 Toke Høiland-Jørgensen wrote: The bpf_redirect_map() helper used by XDP programs doesn't return any indication of whether it can successfully redirect to the map index it was given. Instead, BPF progr

Re: [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied

2019-06-05 Thread David Ahern
On 6/4/19 10:58 PM, Lorenzo Colitti wrote: > As for making this change in 5.3: we might be able to structure the > code differently in a future Android release, assuming the same > userspace code can work on kernels back to 4.4 (not sure it can, since > the semantics changed in 4.8). But even if we

[RFC PATCH net-next 1/2] tcp: ulp: add functions to dump ulp-specific information

2019-06-05 Thread Davide Caratti
currently, only getsockopt(TCP_ULP) can be invoked to know if a ULP is on top of a TCP socket. Extend idiag_get_aux() and idiag_get_aux_size(), introduced by commit b37e88407c1d ("inet_diag: allow protocols to provide additional data"), to report the ULP name and other information that can be made

[RFC PATCH net-next 2/2] net: tls: export protocol version and cipher to socket diag

2019-06-05 Thread Davide Caratti
When an application configures kernel TLS on top of a TCP socket, it's now possible for inet_diag_handler to collect information regarding the protocol version and the cipher, in case INET_DIAG_INFO is requested. Signed-off-by: Davide Caratti --- include/uapi/linux/inet_diag.h | 1 + include/ua

[RFC PATCH net-next 0/2] net: extend INET_DIAG_INFO with information specific to TCP ULP

2019-06-05 Thread Davide Caratti
The current kernel does not provide any diagnostic tool, except getsockopt(TCP_ULP), to know more about TCP sockets that have an upper layer protocol (ULP) on top of them. This series extends the set of information exported by INET_DIAG_INFO, to include data that are specific to the ULP (and that m

Re: [PATCH v4 bpf-next 1/2] bpf: Allow bpf_map_lookup_elem() on an xskmap

2019-06-05 Thread Jonathan Lemon
On 5 Jun 2019, at 1:45, Björn Töpel wrote: > On Tue, 4 Jun 2019 at 20:13, Martin Lau wrote: >> >> On Tue, Jun 04, 2019 at 10:25:23AM -0700, Jonathan Lemon wrote: >>> On 4 Jun 2019, at 9:43, Jesper Dangaard Brouer wrote: >>> On Mon, 3 Jun 2019 09:38:51 -0700 Jonathan Lemon wrote: >>>

[PATCH bpf-next 0/1] bpf: add XDP_SOCK type

2019-06-05 Thread Jonathan Lemon
Have the xskmap version of bpf_map_lookup_elem() return an XDP_SOCK type. This can be used to verify the existence of an entry, and then check the sock properties. Further improvements would include passing the pointer directly to a helper for redirrection instead of referencing the map again.

[PATCH 1/1] bpf: Allow bpf_map_lookup_elem() on an xskmap

2019-06-05 Thread Jonathan Lemon
Currently, the AF_XDP code uses a separate map in order to determine if an xsk is bound to a queue. Instead of doing this, have bpf_map_lookup_elem() return a xdp_sock. Rearrange some xdp_sock members to eliminate structure holes. Signed-off-by: Jonathan Lemon --- include/linux/bpf.h

Quation needed For June Inquiry

2019-06-05 Thread Jpexcc Salesi
Hello dear, We are in the market for your products after meeting at your stand during last expo. Please kindly send us your latest catalog and price list so as to start a new project/order as promised during the exhibition. I would appreciate your response about the above details required

Re: [PATCH 1/1] bpf: Allow bpf_map_lookup_elem() on an xskmap

2019-06-05 Thread Björn Töpel
On Wed, 5 Jun 2019 at 17:58, Jonathan Lemon wrote: > > Currently, the AF_XDP code uses a separate map in order to > determine if an xsk is bound to a queue. Instead of doing this, > have bpf_map_lookup_elem() return a xdp_sock. > > Rearrange some xdp_sock members to eliminate structure holes. > >

Re: [PATCH net-next 4/9] mlxsw: reg: Add Management UTC Register

2019-06-05 Thread Richard Cochran
On Wed, Jun 05, 2019 at 11:30:06AM +, Shalom Toledo wrote: > On 04/06/2019 17:17, Richard Cochran wrote: > > On Mon, Jun 03, 2019 at 03:12:39PM +0300, Ido Schimmel wrote: > >> From: Shalom Toledo > >> > >> The MTUTC register configures the HW UTC counter. > > > > Why is this called the "UTC"

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-05 Thread Richard Cochran
On Wed, Jun 05, 2019 at 08:30:21AM +0200, Jiri Pirko wrote: > Tue, Jun 04, 2019 at 04:28:19PM CEST, richardcoch...@gmail.com wrote: > >On Mon, Jun 03, 2019 at 03:12:42PM +0300, Ido Schimmel wrote: > > > >> +static int > >> +mlxsw_sp1_ptp_update_phc_settime(struct mlxsw_sp_ptp_clock *clock, u64 > >

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-05 Thread Richard Cochran
On Wed, Jun 05, 2019 at 09:00:09AM +, Petr Machata wrote: > We don't build the PTP module at all unless CONFIG_PTP_1588_CLOCK is > enabled, and fall back to inline stubs unless it IS_REACHABLE. I believe > this should be OK. Please use "imply PTP_1588_CLOCK" in your kconfig, just like the othe

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-05 Thread Richard Cochran
On Wed, Jun 05, 2019 at 11:44:21AM +, Shalom Toledo wrote: > On 04/06/2019 17:28, Richard Cochran wrote: > > Now I see why you did this. Nice try. > > I didn't try anything. > > The reason is that the hardware units is in ppb and not in scaled_ppm(or ppm), > so I just converted to ppb in ord

Re: Cutting the link on ndo_stop - phy_stop or phy_disconnect?

2019-06-05 Thread Florian Fainelli
On 6/5/2019 1:45 AM, Russell King - ARM Linux admin wrote: > On Tue, Jun 04, 2019 at 07:25:46PM -0700, Florian Fainelli wrote: >> On 6/4/2019 2:36 PM, Russell King - ARM Linux admin wrote: >>> Normally the PHY receives traffic, and passes it to the MAC which >>> just ignores the signals it recei

Re: [PATCH RFC iproute2-next v4] tc: add support for action act_ctinfo

2019-06-05 Thread Joe Perches
On Mon, 2019-06-03 at 14:50 +0100, Kevin Darbyshire-Bryant wrote: > ctinfo is an action restoring data stored in conntrack marks to various > fields. At present it has two independent modes of operation, > restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack > marks into packet s

Re: [PATCH 1/1] bpf: Allow bpf_map_lookup_elem() on an xskmap

2019-06-05 Thread Jonathan Lemon
On 5 Jun 2019, at 10:16, Björn Töpel wrote: On Wed, 5 Jun 2019 at 17:58, Jonathan Lemon wrote: Currently, the AF_XDP code uses a separate map in order to determine if an xsk is bound to a queue. Instead of doing this, have bpf_map_lookup_elem() return a xdp_sock. Rearrange some xdp_sock mem

Re: [PATCH net-next v2 0/2] r8169: factor out firmware handling

2019-06-05 Thread David Miller
From: Heiner Kallweit Date: Wed, 5 Jun 2019 07:59:02 +0200 > Let's factor out firmware handling into a separate source code file. > This simplifies reading the code and makes clearer what the interface > between driver and firmware handling is. > > v2: > - fix small whitespace issue in patch 2

Re: DSA with MV88E6321 and imx28

2019-06-05 Thread Andrew Lunn
> I removed all phy-handle for the internal ports and in the mdio part > is only port 2 and 6 by now. But the Serdes ports are still not be > recognized. So maybe there is still something wrong? What do you mean by SERDES? Do you mean they are connected to an SFP cage? If so, you need to add an S

Re: [PATCH bpf-next 1/7] bpf: implement getsockopt and setsockopt hooks

2019-06-05 Thread Martin Lau
On Tue, Jun 04, 2019 at 02:35:18PM -0700, Stanislav Fomichev wrote: > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and > BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks. > > BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments. > BPF_CGROUP_GETSOCKOPT can modify the supplied bu

Re: [PATCH v3 net 0/4] s390/qeth: fixes 2019-06-05

2019-06-05 Thread David Miller
From: Julian Wiedmann Date: Wed, 5 Jun 2019 13:48:47 +0200 > one more shot... now with patch 2 fixed up so that it uses the > dst entry returned from dst_check(). Looks good, series applied, thanks.

[PATCH] revert async probing of VMBus network devices.

2019-06-05 Thread Stephen Hemminger
Doing asynchronous probing can lead to reordered network device names. And because udev doesn't have any useful information to construct a persistent name, this causes VM's to sporadically boot with reordered device names and no connectivity. This shows up on the Ubuntu image on larger VM's where

RE: [PATCH] revert async probing of VMBus network devices.

2019-06-05 Thread Haiyang Zhang
> -Original Message- > From: linux-hyperv-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Stephen Hemminger > Sent: Wednesday, June 5, 2019 2:51 PM > To: netdev@vger.kernel.org > Cc: linux-hyp...@vger.kernel.org; Stephen Hemminger > > Subject: [PATCH] revert async probing of

Re: [PATCH RFC iproute2-next v4] tc: add support for action act_ctinfo

2019-06-05 Thread Stephen Hemminger
On Wed, 05 Jun 2019 11:23:59 -0700 Joe Perches wrote: > Strict 80 column limits with long identifiers are just silly. > > I don't know how strictly enforced the iproute2 80 column limit > actually is, but I suggest ignoring that limit where appropriate. Not strictly enforced, but long identifi

Re: [PATCH net-next 4/9] mlxsw: reg: Add Management UTC Register

2019-06-05 Thread Shalom Toledo
On 05/06/2019 20:23, Richard Cochran wrote: > On Wed, Jun 05, 2019 at 11:30:06AM +, Shalom Toledo wrote: >> On 04/06/2019 17:17, Richard Cochran wrote: >>> On Mon, Jun 03, 2019 at 03:12:39PM +0300, Ido Schimmel wrote: From: Shalom Toledo The MTUTC register configures the HW UTC

Re: [PATCH net] pktgen: do not sleep with the thread lock held.

2019-06-05 Thread David Miller
From: Paolo Abeni Date: Wed, 5 Jun 2019 14:34:46 +0200 > @@ -3062,20 +3062,49 @@ static int thread_is_running(const struct > pktgen_thread *t) > return 0; > } > > -static int pktgen_wait_thread_run(struct pktgen_thread *t) > +static bool pktgen_lookup_thread(struct pktgen_net *pn, stru

Re: [PATCH v3 net-next] net: fec_ptp: Use dev_err() instead of pr_err()

2019-06-05 Thread David Miller
From: Fabio Estevam Date: Wed, 5 Jun 2019 10:10:35 -0300 > dev_err() is more appropriate for printing error messages inside > drivers, so switch to dev_err(). > > Signed-off-by: Fabio Estevam > Acked-by: Fugang Duan > --- > Changes since v2: > - Made it a standalone patch > - Collected Andy's

Re: [PATCH bpf-next 1/7] bpf: implement getsockopt and setsockopt hooks

2019-06-05 Thread Stanislav Fomichev
On 06/05, Martin Lau wrote: > On Tue, Jun 04, 2019 at 02:35:18PM -0700, Stanislav Fomichev wrote: > > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and > > BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks. > > > > BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments. > > BPF_CGRO

Re: [PATCH net-next 7/9] mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations

2019-06-05 Thread Shalom Toledo
On 05/06/2019 20:40, Richard Cochran wrote: > On Wed, Jun 05, 2019 at 11:44:21AM +, Shalom Toledo wrote: >> On 04/06/2019 17:28, Richard Cochran wrote: >>> Now I see why you did this. Nice try. >> >> I didn't try anything. >> >> The reason is that the hardware units is in ppb and not in scaled

Re: [PATCH bpf-next 1/7] bpf: implement getsockopt and setsockopt hooks

2019-06-05 Thread Andrii Nakryiko
On Tue, Jun 4, 2019 at 2:35 PM Stanislav Fomichev wrote: > > Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and > BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks. > > BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments. > BPF_CGROUP_GETSOCKOPT can modify the supplied buffer. > B

[net-next 2/2] i40e: Check and set the PF driver state first in i40e_ndo_set_vf_mac

2019-06-05 Thread Jeff Kirsher
From: Lihong Yang The PF driver state flag __I40E_VIRTCHNL_OP_PENDING needs to be checked and set at the beginning of i40e_ndo_set_vf_mac. Otherwise, if there are error conditions before it, the flag will be cleared unexpectedly by this function to cause potential race conditions. Hence move the

[net-next 1/2] i40e: Do not check VF state in i40e_ndo_get_vf_config

2019-06-05 Thread Jeff Kirsher
From: Lihong Yang The VF configuration returned in i40e_ndo_get_vf_config is already stored by the PF. There is no dependency on any specific state of the VF to return the configuration. Drop the check against I40E_VF_STATE_INIT since it is not needed. Signed-off-by: Lihong Yang Tested-by: Andr

Re: [PATCH net v2] ethtool: fix potential userspace buffer overflow

2019-06-05 Thread Michal Kubecek
On Mon, Jun 03, 2019 at 04:57:13PM -0400, Vivien Didelot wrote: > ethtool_get_regs() allocates a buffer of size ops->get_regs_len(), > and pass it to the kernel driver via ops->get_regs() for filling. > > There is no restriction about what the kernel drivers can or cannot do > with the open ethtoo

[net-next 15/15] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

2019-06-05 Thread Jeff Kirsher
From: Kangjie Lu If ixgbevf_write_msg_read_ack fails, return its error code upstream Signed-off-by: Kangjie Lu Tested-by: Andrew Bowers Reviewed-by: Mukesh Ojha Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[net-next 14/15] ixgbe: implement support for SDP/PPS output on X550 hardware

2019-06-05 Thread Jeff Kirsher
From: Jacob Keller Similar to the X540 hardware, enable support for generating a 1pps output signal on SDP0. This support is slightly different to the X540 hardware, because of the register layout changes. First, the system time register is now represented in 'cycles' and 'billions of cycles'. S

[net-next 04/15] ixgbe: fix AF_XDP tx packet count

2019-06-05 Thread Jeff Kirsher
From: William Tu The total_packets count at ixgbe_clean_xdp_tx_irq is always zero when testing with xdpsock -t -N. Set the gso_segs to 1 to make the tx packet count correct. Signed-off-by: William Tu Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ix

[net-next 05/15] ixgbe: reduce PTP Tx timestamp timeout to 1 second

2019-06-05 Thread Jeff Kirsher
From: Jacob Keller Previously we waited for a whole 15 seconds before we cleared the Tx timestamp state. This is astronomically long compared to the worst case timings expected by our devices. In addition, this is longer than the wait in ptp4l when it detects a fault (caused by missing Tx timesta

[net-next 11/15] ixgbe: Use LLDP ethertype define ETH_P_LLDP

2019-06-05 Thread Jeff Kirsher
From: Anirudh Venkataramanan Remove references to IXGBE_ETH_P_LLD and use ETH_P_LLDP instead. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 -- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c |

[net-next 03/15] ixgbe: fix AF_XDP tx byte count

2019-06-05 Thread Jeff Kirsher
From: William Tu The tx bytecount is done twice. When running './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3' The avg packet size is 120 instead of 60. So remove the extra one. Signed-off-by: William Tu Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/i

[net-next 07/15] ixgbe: use 'cc' instead of 'hw_cc' for local variable

2019-06-05 Thread Jeff Kirsher
From: Jacob Keller The ixgbe_ptp.c file sometimes uses hw_cc as the local variable for the cycle counter in ixgbe_ptp_read_X550. However, we use just 'cc' as a local variable for this by convention else where in the file. Convert this lone usage of 'hw_cc' into just the shorter 'cc' name to matc

[net-next 06/15] ixgbe: fix PTP SDP pin setup on X540 hardware

2019-06-05 Thread Jeff Kirsher
From: Jacob Keller The function ixgbe_ptp_setup_sdp_X540 attempts to program a software defined pin, in order to generate a pulse-per-second output on SDP 0. It does work to generate the output, but does not align the output on the full second. Additionally, it does not take into account the cyc

[net-next 09/15] net: Add a define for LLDP ethertype

2019-06-05 Thread Jeff Kirsher
From: Anirudh Venkataramanan Add a new define ETH_P_LLDP for Link Layer Discovery Protocol (LLDP) ethertype. Suggested-by: Bruce Allan Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insert

[net-next 01/15] ixgbe: add tracking of AF_XDP zero-copy state for each queue pair

2019-06-05 Thread Jeff Kirsher
From: Jan Sokolowski Here, we add a bitmap to the ixgbe_adapter that tracks if a certain queue pair has been "zero-copy enabled" via the ndo_bpf. The bitmap is used in ixgbe_xsk_umem, and enables zero-copy if and only if XDP is enabled, the corresponding qid in the bitmap is set, and the umem is

[net-next 12/15] ice: Use LLDP ethertype define ETH_P_LLDP

2019-06-05 Thread Jeff Kirsher
Instead of using a local define for the LLDP ethertype, use the kernel define ETH_P_LLDP. Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_lib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethern

[net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2019-06-05

2019-06-05 Thread Jeff Kirsher
This series contains updates to mainly ixgbe, with a few updates to i40e, net, ice and hns2 driver. Jan adds support for tracking each queue pair for whether or not AF_XDP zero copy is enabled. Also updated the ixgbe driver to use the netdev-provided umems so that we do not need to contain these

[net-next 08/15] ixgbe: add a kernel documentation comment for ixgbe_ptp_get_ts_config

2019-06-05 Thread Jeff Kirsher
From: Jacob Keller This function was missing a documentation comment. Add one now. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethern

[net-next 13/15] net: hns3: Use LLDP ethertype define ETH_P_LLDP

2019-06-05 Thread Jeff Kirsher
From: Anirudh Venkataramanan Remove references to HCLGE_MAC_ETHERTYPE_LLDP and use ETH_P_LLDP instead. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 1 - drivers/net/ethernet/hisilicon/

[net-next 02/15] ixgbe: remove umem from adapter

2019-06-05 Thread Jeff Kirsher
From: Jan Sokolowski As current implementation of netdev already contains and provides umems for us, we no longer have the need to contain these structures in ixgbe_adapter. Refactor the code to operate on netdev-provided umems. Signed-off-by: Jan Sokolowski Tested-by: Andrew Bowers Signed-of

[net-next 10/15] i40e: Use LLDP ethertype define ETH_P_LLDP

2019-06-05 Thread Jeff Kirsher
From: Anirudh Venkataramanan Remove references to I40E_ETH_P_LLDP and use ETH_P_LLDP instead. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e.h | 2 -- drivers/net/ethernet/intel/i40e/i40e_debugfs.c |

[PATCH bpf 1/2] bpf: fix unconnected udp hooks

2019-06-05 Thread Daniel Borkmann
Intention of cgroup bind/connect/sendmsg BPF hooks is to act transparently to applications as also stated in original motivation in 7828f20e3779 ("Merge branch 'bpf-cgroup-bind-connect'"). When recently integrating the latter two hooks into Cilium to enable host based load-balancing with Kubernetes

  1   2   3   >