Re: [PATCH] [PATCH net, stable 4.19.y, 1/1] net: hns: Fix WARNING when hns modules installed

2019-04-25 Thread Graeme Gregory
On Tue, Apr 23, 2019 at 12:48:57AM +0800, xiaoj...@hisilicon.com wrote: > From: Jun Xiao > > Commit dfdf26babc98 upstream > > this patch need merge to 4.19.y stable kernel > > Fix Conflict:already fixed the confilct dfdf26babc98 with Yonglong Liu > > stable candidate:user cannot connect to the

Re: 32-bit zext time complexity (Was Re: [PATCH bpf-next] selftests/bpf: two scale tests)

2019-04-25 Thread Jiong Wang
Alexei Starovoitov writes: > On Thu, Apr 25, 2019 at 12:07:06AM +0100, Jiong Wang wrote: >> >> Alexei Starovoitov writes: >> >> > Add two tests to check that sequence of 1024 jumps is verifiable. >> > >> > Signed-off-by: Alexei Starovoitov >> > --- >> > tools/testing/selftests/bpf/test_verif

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-25 Thread Bruno Prémont
Hi Eric, On Wed, 24 Apr 2019 08:47:27 -0700 Eric Dumazet wrote: > On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: > > > > Hi Eric, > > > > I'm seeing issues with this patch as well, not as regular as for > > Richard but still (about up to one in 30-50 TCP sessions). > > > > In my case I have

Re: [PATCH 4.14 stable v2 0/5] net: ip6 defrag: backport fixes

2019-04-25 Thread Lars Persson
On 4/23/19 7:48 PM, Peter Oskolkov wrote: Lars Persson reported that a label was unused in the previous version of this patchset, so I'm sending a v2 that fixes it. Sorry for the mess/v2. v2 changes: handle overlapping fragments the way it is done upstream. This is a backport of a 5.1rc patch

Re: [PATCH net-next v2] net: sched: flower: refactor reoffload for concurrent access

2019-04-25 Thread Jiri Pirko
Wed, Apr 24, 2019 at 08:53:31AM CEST, vla...@mellanox.com wrote: >Recent changes that introduced unlocked flower did not properly account for >case when reoffload is initiated concurrently with filter updates. To fix >the issue, extend flower with 'hw_filters' list that is used to store >filters th

[PATCH] samples: bpf: add hbm sample to .gitignore

2019-04-25 Thread Daniel T. Lee
This commit adds hbm to .gitignore which is currently ommited from the ignore file. Signed-off-by: Daniel T. Lee --- samples/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore index 59e40998e249..c7498457595a 100644 --- a/samples/bp

RE: [PATCH net] packet: validate address length if non-zero

2019-04-25 Thread David Laight
From: Willem de Bruijn > Sent: 24 April 2019 20:35 > On Wed, Apr 24, 2019 at 3:14 PM Willem de Bruijn > wrote: > > > > On Tue, Apr 23, 2019 at 2:21 PM Willem de Bruijn > > wrote: > > > > > > On Tue, Apr 23, 2019 at 1:21 PM Willem de Bruijn > > > wrote: > > > > > > > > On Tue, Apr 23, 2019 at 1:0

Re: [PATCH net] net: phy: marvell: Fix buffer overrun with stats counters

2019-04-25 Thread Sergei Shtylyov
Hello! On 25.04.2019 1:33, Andrew Lunn wrote: marvell_get_sset_count() returns how many statistics counters there are. If the PHY supports fibre, there are 3, otherwise two. marvell_get_strings() does not make this distinction, and always returns 3 strings. This then often results in writing p

Re: 32-bit zext time complexity (Was Re: [PATCH bpf-next] selftests/bpf: two scale tests)

2019-04-25 Thread Jiong Wang
> On 25 Apr 2019, at 08:25, Jiong Wang wrote: > > > Alexei Starovoitov writes: > >> On Thu, Apr 25, 2019 at 12:07:06AM +0100, Jiong Wang wrote: >>> >>> Alexei Starovoitov writes: >>> Add two tests to check that sequence of 1024 jumps is verifiable. Signed-off-by: Alexei Star

Re: [PATCH 0/5] isdn: deprecate non-mISDN drivers

2019-04-25 Thread Arnd Bergmann
On Wed, Apr 24, 2019 at 4:30 PM Marcel Holtmann wrote: > > Hi Arnd, > > > When isdn4linux came up in the context of another patch series, I > > remembered that we had discussed removing it a while ago. > >> > >> NAK. > >> > >> I do not care about isdn4linux, but this is a purely CAPI based

Re: [PATCH v2 bpf-next 3/3] bpftool: add bash completions for btf command

2019-04-25 Thread Quentin Monnet
2019-04-24 22:03 UTC-0700 ~ > From: Andrii Nakryiko > > Add full support for btf command in bash-completion script. > > Cc: Quentin Monnet > Cc: Yonghong Song > Cc: Daniel Borkmann > Cc: Alexei Starovoitov > Signed-off-by: Andrii Nakryiko > --- > tools/bpf/bpftool/bash-completion/bpftool

Re: [PATCH 0/5] isdn: deprecate non-mISDN drivers

2019-04-25 Thread Marcel Holtmann
Hi Arnd, >>> When isdn4linux came up in the context of another patch series, I >>> remembered that we had discussed removing it a while ago. NAK. I do not care about isdn4linux, but this is a purely CAPI based driver. So removing (or moving to staging) CAPI

Re: [PATCH 5/5] isdn: move capi drivers to staging

2019-04-25 Thread Arnd Bergmann
On Wed, Apr 24, 2019 at 3:06 PM Thomas Jarosch wrote: > > Hi Arnd, > > > Ok, interesting. My understanding was that mISDN CAPI support > > was done purely in user space, on top of the mISDN interface. > > > > I don't see any interfaction between the two in the kernel code, > > but if the capi modu

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-25 Thread Bruno Prémont
Hi Eric, On Thu, 25 Apr 2019 09:55:31 +0200 Bruno Prémont wrote: > Hi Eric, > > On Wed, 24 Apr 2019 08:47:27 -0700 Eric Dumazet wrote: > > On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: > > > > > > Hi Eric, > > > > > > I'm seeing issues with this patch as well, not as regular as for > > >

Zdravstvuyte! Vas interesuyut kliyentskiye bazy dannykh?

2019-04-25 Thread netdev
Zdravstvuyte! Vas interesuyut kliyentskiye bazy dannykh?

Re: TC stats / hw offload question

2019-04-25 Thread Edward Cree
On 24/04/2019 16:03, Edward Cree wrote: > static int efx_tc_flower_replace(struct efx_nic *efx, >                 struct net_device *net_dev, >                             struct tc_cls_flower_offload *tc) > { >     struct efx_tc_action_set *act; > >     /* parse the match */

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-25 Thread Eric Dumazet
On Thu, Apr 25, 2019 at 6:13 AM Bruno Prémont wrote: > > Hi Eric, > > On Thu, 25 Apr 2019 09:55:31 +0200 Bruno Prémont wrote: > > Hi Eric, > > > > On Wed, 24 Apr 2019 08:47:27 -0700 Eric Dumazet wrote: > > > On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: > > > > > > > > Hi Eric, > > > > > >

Re: [PATCH rdma-next 0/8] User space steering

2019-04-25 Thread Jason Gunthorpe
On Sun, Mar 31, 2019 at 07:44:42PM +0300, Leon Romanovsky wrote: > net/mlx5: Expose TIR ICM address in command outbox > net/mlx5: Introduce new TIR creation core API > IB/mlx5: Expose TIR ICM address to user space These are applied to for-next now Thanks, Jason

pull request: bluetooth-next 2019-04-25

2019-04-25 Thread Johan Hedberg
Hi Dave, Here's the main bluetooth-next pull request for the 5.2 kernel. - Added support for Mediatek SDIO controllers - Added support for Broadcom BCM2076B1 UART controller - Added support for Marvel SD8987 chipset - Fix buffer overflow bug in hidp protocol - Various other smaller fixes & i

Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

2019-04-25 Thread Hangbin Liu
On Tue, Apr 23, 2019 at 11:32:13AM +0200, Miroslav Lichvar wrote: > If those values I described above were in an array called ts_map > indexed by the RX filter enum, I think the check could just be: > > (ts_map[old_filter] & ts_map[new_filter]) == tsmap[old_filter] > > The individual bits w

Re: [PATCH net] packet: validate address length if non-zero

2019-04-25 Thread Willem de Bruijn
On Thu, Apr 25, 2019 at 5:32 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 24 April 2019 20:35 > > On Wed, Apr 24, 2019 at 3:14 PM Willem de Bruijn > > wrote: > > > > > > On Tue, Apr 23, 2019 at 2:21 PM Willem de Bruijn > > > wrote: > > > > > > > > On Tue, Apr 23, 2019 at 1:21 PM W

[patch net-next v4 01/16] netdevsim: move device registration on bus to be done earlier in init

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko As a dependency of the subsequent patch, mode device registration to be done earlier, directly in nsim_newlink(). Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/netdev.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drive

[patch net-next v4 00/16] netdevsim: implement proper device model

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Currently the model of netdevsim is a bit odd in multiple ways. 1) devlink instance is not in any way related with actual netdevsim netdevices. Instead, it is created per-namespace. 2) multi-port netdevsim device is done using "link" attribute. 3) netdevsim bus is there only t

[patch net-next v4 04/16] netdevsim: put netdevsim bus code into separate file

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko As the code related to netdevsim bus is going to get bigger, move the existing code to a separate file. Signed-off-by: Jiri Pirko --- rfc->v1: - rebased --- drivers/net/netdevsim/Makefile| 2 +- drivers/net/netdevsim/bus.c | 24 drivers/net/

[patch net-next v4 02/16] netdevsim: create devlink instance per netdevsim instance

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Currently there is one devlink instance created per network namespace. That is quite odd considering the fact that devlink instance should represent an ASIC. The following patches are going to move the devlink instance even more down to a bus device, but until then, have one devl

[patch net-next v4 14/16] netdevsim: extend device attrs to support port addition and deletion

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko In order to test flows in core, it is beneficial to maintain previously supported possibility to add and delete ports during netdevsim lifetime. Do it by extending device sysfs attrs by "new_port" and "del_port". Signed-off-by: Jiri Pirko --- v3->v4: - fix wrapping of function

[patch net-next v4 12/16] netdevsim: change debugfs tree topology

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko With the model where dev is represented by devlink and ports are represented by devlink ports, make debugfs file names independent on netdev names. Change the topology to the one illustrated by the following example: $ ls /sys/kernel/debug/netdevsim/ netdevsim1 $ ls /sys/kernel/

[patch net-next v4 08/16] netdevsim: add bus attributes to add new and delete devices

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Add a way to add new netdevsim device on netdevsim bus and also to delete existing netdevsim device from the bus. Track the bus devices in using a list. Signed-off-by: Jiri Pirko --- v3->v4: - fix wrapping of function declararions according to Jakub's rules. --- drivers/net/ne

[patch net-next v4 16/16] netdevsim: implement ndo_get_devlink_port

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Implement ndo_get_devlink_port and allow switch_id and port_name to be handled by devlink. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/netdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c i

[patch net-next v4 09/16] netdevsim: rename dev_init/exit() functions and make them independent on ns

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko These functions are going to be called from bus probe/release(), therefore make them independent on ns struct and rename accordingly. Signed-off-by: Jiri Pirko --- v3->v4: - fix wrapping of function declararions according to Jakub's rules. --- drivers/net/netdevsim/dev.c

[patch net-next v4 13/16] netdevsim: implement dev probe/remove skeleton with port initialization

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Implement netdevsim bus probing of netdevsim devices. For every probed device create a devlink instance. According to the user-passed value, create a number of ports represented by devlink port instances. Signed-off-by: Jiri Pirko --- v3->v4: - fix wrapping of function declarar

[patch net-next v4 06/16] netdevsim: add stub netdevsim driver implementation

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko In order to bus probing to work correctly, register a simple netdevsim driver implementation. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/bus.c b/driv

[patch net-next v4 15/16] netdevsim: move netdev creation/destruction to dev probe

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Remove the existing way to create netdevsim over rtnetlink and move the netdev creation/destruction to dev probe, so for every probed port, a netdevsim-netdev instance is created. Adjust selftests to work with new interface. Signed-off-by: Jiri Pirko --- v3->v4: - fixed the te

[patch net-next v4 11/16] netdevsim: generate random switch id instead of using dev id

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Current implementation of parent_id/switch_id does not follow the original idea of being unique. The values are "0", "1", etc. Instead of that, generate 32 random bytes. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/dev.c | 3 +++ drivers/net/netdevsim/netdev.c

[patch net-next v4 03/16] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko The existing devlink.c code is going to be extended to represent asic device on a bus. As this is about more than just devlink, rename the file. Do appropriate prefix renaming alongside with that. Signed-off-by: Jiri Pirko --- rfc->v1: - remove the trailing "\" from the makefil

[patch net-next v4 05/16] netdevsim: move device registration and related code to bus.c

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Move netdevsim device registration into bus.c and alongside with that the related sysfs attributes. Introduce new struct nsim_bus_dev to represent a netdevsim device on netdevsim bus. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 142 +-

[patch net-next v4 07/16] netdevsim: use ida for bus device ids

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko Instead of increments of u32 value, use ida to manage bus device ids. Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/bus.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c index 5b

[patch net-next v4 10/16] netdevsim: merge sdev into dev

2019-04-25 Thread Jiri Pirko
From: Jiri Pirko As previously introduce dev which is mapped 1:1 to a bus device covers the purpose of the original shared device, merge the sdev code into dev. Signed-off-by: Jiri Pirko --- rfc->v1: - rebased --- drivers/net/netdevsim/Makefile | 2 +- drivers/net/netdevsim/bpf.c

Re: [patch net-next v4 00/16] netdevsim: implement proper device model

2019-04-25 Thread Jiri Pirko
I skipped v3 for some odd reason, in case you would wonder.

[PATCH net-next] ibmvnic: Add device identification to requested IRQs

2019-04-25 Thread Murilo Fossa Vicentini
The ibmvnic driver currently uses the same fixed name when using request_irq, this makes it hard to parse when multiple VNIC devices are available at the same time. This patch adds the unit_address as the device identification along with an id for each queue. The original idea was to use the inter

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-25 Thread Bruno Prémont
On Thu, 25 Apr 2019 06:30:24 -0700 Eric Dumazet wrote: > On Thu, Apr 25, 2019 at 6:13 AM Bruno Prémont wrote: > > On Thu, 25 Apr 2019 09:55:31 +0200 Bruno Prémont wrote: > > > On Wed, 24 Apr 2019 08:47:27 -0700 Eric Dumazet wrote: > > > > On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: >

RE: [PATCH net] packet: validate address length if non-zero

2019-04-25 Thread David Laight
From: Willem de Bruijn > Sent: 25 April 2019 14:57 ... > > I've just done a bit of software archaeology. > > > > Prior to 2.6.14-rc3 the send code ignored sll_halen, it was only set by the > > receive code. > > So it is not surprising that old application code leaves it as zero. > > > > The old re

Zdravstvuyte! Vas interesuyut kliyentskiye bazy dannykh?

2019-04-25 Thread netdev
Zdravstvuyte! Vas interesuyut kliyentskiye bazy dannykh?

Re: [PATCH bpf v3 0/2] bpf: mark registers in all frames after pkt/null checks

2019-04-25 Thread Yonghong Song
On 4/24/19 12:49 PM, Paul Chaignon wrote: > In case of a null check on a pointer inside a subprog, we should mark all > registers with this pointer as either safe or unknown, in both the current > and previous frames. Currently, only spilled registers and registers in > the current frame are mar

Re: [PATCH v2 bpf-next 1/3] bpftool: add ability to dump BTF types

2019-04-25 Thread Yonghong Song
On 4/24/19 10:03 PM, andrii.nakry...@gmail.com wrote: > From: Andrii Nakryiko > > Add new `btf dump` sub-command to bpftool. It allows to dump > human-readable low-level BTF types representation of BTF types. BTF can > be retrieved from few different sources: >- from BTF object by ID; >

Re: [PATCH v2 bpf-next 2/3] bpftool/docs: add btf sub-command documentation

2019-04-25 Thread Yonghong Song
On 4/24/19 10:03 PM, andrii.nakry...@gmail.com wrote: > From: Andrii Nakryiko > > Document usage and sample output format for `btf dump` sub-command. > > Cc: Daniel Borkmann > Cc: Alexei Starovoitov > Cc: Yonghong Song > Cc: Martin KaFai Lau > Cc: Song Liu > Cc: Arnaldo Carvalho de Melo

Re: [patch net-next v4 06/16] netdevsim: add stub netdevsim driver implementation

2019-04-25 Thread Sergei Shtylyov
Hello! On 04/25/2019 04:59 PM, Jiri Pirko wrote: > From: Jiri Pirko > > In order to bus probing to work correctly, register a simple netdevsim "In order for", perhaps? > driver implementation. > > Signed-off-by: Jiri Pirko [...] MBR, Sergei

Re: [PATCH net] packet: validate address length if non-zero

2019-04-25 Thread Willem de Bruijn
On Thu, Apr 25, 2019 at 10:35 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 25 April 2019 14:57 > ... > > > I've just done a bit of software archaeology. > > > > > > Prior to 2.6.14-rc3 the send code ignored sll_halen, it was only set by > > > the receive code. > > > So it is not su

Re: [PATCH 4.14 stable v2 0/5] net: ip6 defrag: backport fixes

2019-04-25 Thread Peter Oskolkov
On Thu, Apr 25, 2019 at 1:13 AM Lars Persson wrote: > > On 4/23/19 7:48 PM, Peter Oskolkov wrote: > > Lars Persson reported that a label was unused in > > the previous version of this patchset, so I'm sending a v2 that fixes it. > > > > Sorry for the mess/v2. > > > > v2 changes: handle overlappin

[bpf PATCH v2 0/3] sockmap/ktls fixes

2019-04-25 Thread John Fastabend
Series of fixes for sockmap and ktls, see patches for descriptions. v2: fix build issue for CONFIG_TLS_DEVICE and fixup couple comments from Jakub. --- John Fastabend (3): bpf: tls, implement unhash to avoid transition out of ESTABLISHED bpf: sockmap remove duplicate queue free

pull-request: ieee802154 for net 2019-04-25

2019-04-25 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. Another fix from Kangjie Lu to ensure better checking regmap updates in the mcr20a driver. Nothing else I have pending for the final release. If there are any problems let me know. --- During the preparation of this pull request a work

[bpf PATCH v2 1/3] bpf: tls, implement unhash to avoid transition out of ESTABLISHED

2019-04-25 Thread John Fastabend
It is possible (via shutdown()) for TCP socks to go through TCP_CLOSE state via tcp_disconnect() without calling into close callback. This would allow a kTLS enabled socket to exist outside of ESTABLISHED state which is not supported. Solve this the same way we solved the sock{map|hash} case by ad

[bpf PATCH v2 2/3] bpf: sockmap remove duplicate queue free

2019-04-25 Thread John Fastabend
In tcp bpf remove we free the cork list and purge the ingress msg list. However we do this before the ref count reaches zero so it could be possible some other access is in progress. In this case (tcp close and/or tcp_unhash) we happen to also hold the sock lock so no path exists but lets fix it ot

[bpf PATCH v2 3/3] bpf: sockmap fix msg->sg.size account on ingress skb

2019-04-25 Thread John Fastabend
When converting a skb to msg->sg we forget to set the size after the latest ktls/tls code conversion. This patch can be reached by doing a redir into ingress path from BPF skb sock recv hook. Then trying to read the size fails. Fix this by setting the size. Fixes: 604326b41a6fb ("bpf, sockmap: co

Re: BUG: KASAN: use-after-free Read in tun_net_xmit

2019-04-25 Thread YueHaibing
On 2019/4/24 20:25, YueHaibing wrote: > On 2019/4/24 17:11, Jason Wang wrote: >> >> On 2019/4/24 上午12:41, Cong Wang wrote: >>> On Mon, Apr 22, 2019 at 11:42 PM Jason Wang wrote: On 2019/4/23 下午2:00, Cong Wang wrote: > On Mon, Apr 22, 2019 at 2:41 AM Jason Wang wrote: >> On 2019/

[PATCH net] ipv6: invert flowlabel sharing check in process and user mode

2019-04-25 Thread Willem de Bruijn
From: Willem de Bruijn A request for a flowlabel fails in process or user exclusive mode must fail if the caller pid or uid does not match. Invert the test. Previously, the test was unsafe wrt PID recycling, but indeed tested for inequality: fl1->owner != fl->owner Fixes: 4f82f45730c68 ("net ip

Re: [PATCH v2 bpf-next 3/3] bpftool: add bash completions for btf command

2019-04-25 Thread Andrii Nakryiko
On Thu, Apr 25, 2019 at 4:15 AM Quentin Monnet wrote: > > 2019-04-24 22:03 UTC-0700 ~ > > From: Andrii Nakryiko > > > > Add full support for btf command in bash-completion script. > > > > Cc: Quentin Monnet > > Cc: Yonghong Song > > Cc: Daniel Borkmann > > Cc: Alexei Starovoitov > > Signed-o

[PATCH net-next 4/8] s390/qeth: use IS_* helpers for checking device type

2019-04-25 Thread Julian Wiedmann
We have helper macros for all possible device types, replace all remaining open-coded accesses to the type fields. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 +- drivers/s390/net/qeth_core_main.c | 80 +++ drivers/s390/net/qeth_c

[PATCH net-next 7/8] s390/qeth: extract helper to determine L2 cast type

2019-04-25 Thread Julian Wiedmann
This de-duplicates the L2 and L3 cast-type code, and makes the L2 code a bit more robust by removing the fragile assumption that skb->data always points to the Ethernet Header. This would break in code paths where we pushed the HW header onto the skb. Signed-off-by: Julian Wiedmann --- drivers/s

[PATCH net-next 2/8] s390/qeth: remove RX seqno in skb->cb

2019-04-25 Thread Julian Wiedmann
It's unclear what exact purpose this seqno may have served in the past. But it's certainly no longer used anymore, as the following napi_gro_receive() will straight away clear this part of the cb again. Suggested-by: Karsten Graul Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h

[PATCH net-next 8/8] s390/qeth: trust non-IP cast type in qeth_l3_fill_header()

2019-04-25 Thread Julian Wiedmann
When building the L3 HW header for non-IP packets, trust the cast type that was passed as parameter. qeth_l3_get_cast_type() has most likely also used h_dest to determine the cast type, so we get the same result, and can remove that duplicated code. In the unlikely case that we would get a _differe

[PATCH net-next 0/8] s390/qeth: updates 2019-04-25

2019-04-25 Thread Julian Wiedmann
Hi Dave, please apply one more patch series for qeth to net-next. Nothing special, just a bunch of cleanups. Thanks, Julian Arnd Bergmann (1): s390: qeth: address type mismatch warning Julian Wiedmann (7): s390/qeth: remove RX seqno in skb->cb s390/qeth: clean up stale buffer state docume

[PATCH net-next 5/8] s390/qeth: don't clear Output buffers on every queue init

2019-04-25 Thread Julian Wiedmann
On the first initialization of a queue, its Output Buffers are in a clean state with no attached resources. On every subsequent initialization, qeth_l?_stop_card() has previously put them in a clean state via qeth_drain_output_queues(). So the call to qeth_clear_output_buffer() is redundant and can

[PATCH net-next 6/8] s390/qeth: cache max number of available buffer elements

2019-04-25 Thread Julian Wiedmann
The QETH_MAX_BUFFER_ELEMENTS() macro effectively returns a constant value. To avoid some redundant pointer chasing and computations in the xmit hot path, cache this value in the queue struct. Take this as opportunity to shrink some of the queue struct's fields to their appropriate value range, sli

[PATCH net-next 3/8] s390/qeth: clean up stale buffer state documentation

2019-04-25 Thread Julian Wiedmann
We don't keep track of Input Buffer states, so remove the comments that make it sound like the qeth_qdio_buffer_states enum applies to Input Buffers. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 41 + 1 file changed, 13 insertions(+),

[PATCH net-next 1/8] s390: qeth: address type mismatch warning

2019-04-25 Thread Julian Wiedmann
From: Arnd Bergmann clang produces a harmless warning for each use for the qeth_adp_supported macro: drivers/s390/net/qeth_l2_main.c:559:31: warning: implicit conversion from enumeration type 'enum qeth_ipa_setadp_cmd' to different enumeration type 'enum qeth_ipa_funcs' [-Wenum-conversion

Re: [PATCH v2 bpf-next 3/3] bpftool: add bash completions for btf command

2019-04-25 Thread Quentin Monnet
2019-04-25 09:14 UTC-0700 ~ Andrii Nakryiko > On Thu, Apr 25, 2019 at 4:15 AM Quentin Monnet > wrote: >> >> 2019-04-24 22:03 UTC-0700 ~ >>> From: Andrii Nakryiko >>> >>> Add full support for btf command in bash-completion script. >>> >>> Cc: Quentin Monnet >>> Cc: Yonghong Song >>> Cc: Daniel

Re: [PATCH v2 bpf-next 3/3] bpftool: add bash completions for btf command

2019-04-25 Thread Andrii Nakryiko
On Thu, Apr 25, 2019 at 9:33 AM Quentin Monnet wrote: > > 2019-04-25 09:14 UTC-0700 ~ Andrii Nakryiko > > On Thu, Apr 25, 2019 at 4:15 AM Quentin Monnet > > wrote: > >> > >> 2019-04-24 22:03 UTC-0700 ~ > >>> From: Andrii Nakryiko > >>> > >>> Add full support for btf command in bash-completion

Re: [PATCH net-next] ibmvnic: Add device identification to requested IRQs

2019-04-25 Thread Mauro Rodrigues
On Thu, Apr 25, 2019 at 11:02:33AM -0300, Murilo Fossa Vicentini wrote: > The ibmvnic driver currently uses the same fixed name when using > request_irq, this makes it hard to parse when multiple VNIC devices are > available at the same time. This patch adds the unit_address as the device > identif

[PATCH net-next 0/4] net/tls: small code cleanup

2019-04-25 Thread Jakub Kicinski
Hi! This small patch set cleans up tls (mostly offload parts). Other than avoiding unnecessary error messages - no functional changes here. Jakub Kicinski (4): net/tls: don't log errors every time offload can't proceed net/tls: remove old exports of sk_destruct functions net/tls: move defin

[PATCH net-next 1/4] net/tls: don't log errors every time offload can't proceed

2019-04-25 Thread Jakub Kicinski
Currently when CONFIG_TLS_DEVICE is set each time kTLS connection is opened and the offload is not successful (either because the underlying device doesn't support it or e.g. it's tables are full) a rate limited error will be printed to the logs. There is nothing wrong with failing TLS offload. S

[PATCH net-next 3/4] net/tls: move definition of tls ops into net/tls.h

2019-04-25 Thread Jakub Kicinski
There seems to be no reason for tls_ops to be defined in netdevice.h which is included in a lot of places. Don't wrap the struct/enum declaration in ifdefs, it trickles down unnecessary ifdefs into driver code. Signed-off-by: Jakub Kicinski Reviewed-by: Reviewed-by: Simon Horman --- include/li

[PATCH net-next 4/4] net/tls: byte swap device req TCP seq no upon setting

2019-04-25 Thread Jakub Kicinski
To avoid a sparse warning byteswap the be32 sequence number before it's stored in the atomic value. While at it drop unnecessary brackets and use kernel's u64 type. Signed-off-by: Jakub Kicinski Reviewed-by: Reviewed-by: Simon Horman --- include/net/tls.h| 2 +- net/tls/tls_device.c | 2 +-

[PATCH net-next 2/4] net/tls: remove old exports of sk_destruct functions

2019-04-25 Thread Jakub Kicinski
tls_device_sk_destruct being set on a socket used to indicate that socket is a kTLS device one. That is no longer true - now we use sk_validate_xmit_skb pointer for that purpose. Remove the export. tls_device_attach() needs to be moved. While at it, remove the dead declaration of tls_sk_destruct

Re: virtio_net: suspicious RCU usage with xdp

2019-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote: > On 2019/04/25 2:37, Michael S. Tsirkin wrote: > > On Wed, Apr 24, 2019 at 11:13:42AM -0600, David Ahern wrote: > >> seeing an RCU warning testing xdp with virtio net. net-next as of commit > >> b2f97f7de2f6a4df8e431330cf467576486651

Re: [PATCH net-next] ibmvnic: Add device identification to requested IRQs

2019-04-25 Thread Thomas Falcon
On 4/25/19 9:02 AM, Murilo Fossa Vicentini wrote: The ibmvnic driver currently uses the same fixed name when using request_irq, this makes it hard to parse when multiple VNIC devices are available at the same time. This patch adds the unit_address as the device identification along with an id f

Re: [PATCH 0/5] isdn: deprecate non-mISDN drivers

2019-04-25 Thread Paul Bolle
Arnd Bergmann schreef op do 25-04-2019 om 13:08 [+0200]: > The gigaset driver is similar here, you can use it for any kind of wireless > ISDN > communication, Nit: the wireless part is strictly DECT (for the M101 and M105 hardware). > but apparently there is little use for that without a physica

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-25 Thread Heiner Kallweit
On 19.04.2019 01:30, David Miller wrote: > From: Heiner Kallweit > Date: Wed, 17 Apr 2019 00:06:28 +0200 > >> This driver is the only user of PHY_10GBIT_FEC_FEATURES. So we may be >> able to remove this predefined feature constant later. Setting >> phydev->advertising to what is supported is done

Re: [bpf-next PATCH] bpf: sockmap, test tool support to skip cgroup arg

2019-04-25 Thread Andrii Nakryiko
On Thu, Apr 25, 2019 at 12:19 AM John Fastabend wrote: > > Its handy to not have to setup a cgroup environment when running > test_sockmap with user specified options. This patch setups a cgroup > environment, similar to how it is done with the auto test suite, when > the user does not provide a c

Re: virtio_net: suspicious RCU usage with xdp

2019-04-25 Thread Jesper Dangaard Brouer
On Thu, 25 Apr 2019 13:03:39 -0400 "Michael S. Tsirkin" wrote: > On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote: > > On 2019/04/25 2:37, Michael S. Tsirkin wrote: > > > On Wed, Apr 24, 2019 at 11:13:42AM -0600, David Ahern wrote: > > >> seeing an RCU warning testing xdp with

Re: virtio_net: suspicious RCU usage with xdp

2019-04-25 Thread David Ahern
On 4/25/19 11:41 AM, Jesper Dangaard Brouer wrote: > On Thu, 25 Apr 2019 13:03:39 -0400 > "Michael S. Tsirkin" wrote: > >> On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote: >>> On 2019/04/25 2:37, Michael S. Tsirkin wrote: On Wed, Apr 24, 2019 at 11:13:42AM -0600, David Aher

Re: [PATCH 1/2] spi: Micrel eth switch: declare missing of table

2019-04-25 Thread Mark Brown
On Tue, Apr 23, 2019 at 07:33:10PM +0200, Heiner Kallweit wrote: > Except having "switch" in the name this driver is solely a SPI driver > and it uses no network code at all. And it has no dependency on any > network driver. Therefore I wouldn't consider it a network driver. > Else any functionali

Re: [bpf PATCH v2 0/3] sockmap/ktls fixes

2019-04-25 Thread Jakub Kicinski
On Thu, 25 Apr 2019 09:02:50 -0700, John Fastabend wrote: > Series of fixes for sockmap and ktls, see patches for descriptions. > > v2: fix build issue for CONFIG_TLS_DEVICE and fixup couple comments from > Jakub. Ah, right my comment about the rx side sleeping was fairly nonsensical, the loc

Re: [PATCH net-next 1/4] net/tls: don't log errors every time offload can't proceed

2019-04-25 Thread Saeed Mahameed
On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote: > Currently when CONFIG_TLS_DEVICE is set each time kTLS > connection is opened and the offload is not successful > (either because the underlying device doesn't support > it or e.g. it's tables are full) a rate limited error > will be printe

Re: [bpf PATCH v2 0/3] sockmap/ktls fixes

2019-04-25 Thread John Fastabend
On 4/25/19 11:30 AM, Jakub Kicinski wrote: > On Thu, 25 Apr 2019 09:02:50 -0700, John Fastabend wrote: >> Series of fixes for sockmap and ktls, see patches for descriptions. >> >> v2: fix build issue for CONFIG_TLS_DEVICE and fixup couple comments from >> Jakub. > > Ah, right my comment about

Re: virtio_net: suspicious RCU usage with xdp

2019-04-25 Thread Maciej Fijalkowski
On Thu, 25 Apr 2019 11:44:27 -0600 David Ahern wrote: > On 4/25/19 11:41 AM, Jesper Dangaard Brouer wrote: > > On Thu, 25 Apr 2019 13:03:39 -0400 > > "Michael S. Tsirkin" wrote: > > > >> On Thu, Apr 25, 2019 at 01:58:48PM +0900, Toshiaki Makita wrote: > >>> On 2019/04/25 2:37, Michael S. Ts

Re: [bpf PATCH v2 0/3] sockmap/ktls fixes

2019-04-25 Thread Jakub Kicinski
On Thu, 25 Apr 2019 11:49:18 -0700, John Fastabend wrote: > On 4/25/19 11:30 AM, Jakub Kicinski wrote: > > On Thu, 25 Apr 2019 09:02:50 -0700, John Fastabend wrote: > >> Series of fixes for sockmap and ktls, see patches for descriptions. > >> > >> v2: fix build issue for CONFIG_TLS_DEVICE and fix

Re: [PATCH net-next 1/4] net/tls: don't log errors every time offload can't proceed

2019-04-25 Thread Jakub Kicinski
On Thu, 25 Apr 2019 18:37:19 +, Saeed Mahameed wrote: > On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote: > > Currently when CONFIG_TLS_DEVICE is set each time kTLS > > connection is opened and the offload is not successful > > (either because the underlying device doesn't support > > it

Re: [PATCH v3 bpf-next 0/4] add btf dumping to bpftool

2019-04-25 Thread Quentin Monnet
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko This patch set adds a new `bpftool btf dump` sub-command, which allows to dump BTF contents (only types for now). Currently it only outputs low-level content, almost 1:1 with binary BTF format, but follow up patches will add ability to dump BTF types a

Re: [PATCH v3 bpf-next 1/4] bpftool: add ability to dump BTF types

2019-04-25 Thread Quentin Monnet
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko Add new `btf dump` sub-command to bpftool. It allows to dump human-readable low-level BTF types representation of BTF types. BTF can be retrieved from few different sources: - from BTF object by ID; - from PROG, if it has associated BTF; - fro

Re: [PATCH v3 bpf-next 3/4] bpftool: add bash completions for btf command

2019-04-25 Thread Quentin Monnet
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko Add full support for btf command in bash-completion script. Cc: Quentin Monnet Cc: Yonghong Song Cc: Alexei Starovoitov Cc: Daniel Borkmann Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/bash-completion/bpftool | 46 ++

Re: [PATCH v3 bpf-next 2/4] bpftool/docs: add btf sub-command documentation

2019-04-25 Thread Quentin Monnet
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko Document usage and sample output format for `btf dump` sub-command. Cc: Daniel Borkmann Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Martin KaFai Lau Cc: Song Liu Cc: Arnaldo Carvalho de Melo Acked-by: Yonghong Song Signed-off-by: Andrii Nakryi

Re: [PATCH v3 bpf-next 4/4] bpftool: fix indendation in bash-completion/bpftool

2019-04-25 Thread Quentin Monnet
2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko Fix misaligned default case branch for `prog dump` sub-command. Reported-by: Quentin Monnet Cc: Yonghong Song Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/bash-completion/bpftool | 22 +++--- 1 file changed, 11 insertions

Re: [PATCH net-next 3/4] net/tls: move definition of tls ops into net/tls.h

2019-04-25 Thread Saeed Mahameed
On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote: > There seems to be no reason for tls_ops to be defined in netdevice.h > which is included in a lot of places. Don't wrap the struct/enum > declaration in ifdefs, it trickles down unnecessary ifdefs into > driver code. > > Signed-off-by: Ja

Re: [bpf PATCH v2 1/3] bpf: tls, implement unhash to avoid transition out of ESTABLISHED

2019-04-25 Thread Jakub Kicinski
On Thu, 25 Apr 2019 09:03:08 -0700, John Fastabend wrote: > +static void tls_sk_proto_unhash(struct sock *sk) > +{ > + struct tls_context *ctx = tls_get_ctx(sk); > + void (*sk_proto_unhash)(struct sock *sk); > + bool free_ctx; > + > + if (!ctx) > + return sk->sk_prot->un

Re: [PATCH net-next 4/4] net/tls: byte swap device req TCP seq no upon setting

2019-04-25 Thread Saeed Mahameed
On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote: > To avoid a sparse warning byteswap the be32 sequence number > before it's stored in the atomic value. While at it drop > unnecessary brackets and use kernel's u64 type. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Reviewed-by: Simon

[PATCH net-next v2 4/4] net/tls: byte swap device req TCP seq no upon setting

2019-04-25 Thread Jakub Kicinski
To avoid a sparse warning byteswap the be32 sequence number before it's stored in the atomic value. While at it drop unnecessary brackets and use kernel's u64 type. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- include/net/tls.h| 2 +- net/tls/tls_device.c | 2 +- 2 files cha

[PATCH net-next v2 1/4] net/tls: don't log errors every time offload can't proceed

2019-04-25 Thread Jakub Kicinski
Currently when CONFIG_TLS_DEVICE is set each time kTLS connection is opened and the offload is not successful (either because the underlying device doesn't support it or e.g. it's tables are full) a rate limited error will be printed to the logs. There is nothing wrong with failing TLS offload. S

[PATCH net-next v2 2/4] net/tls: remove old exports of sk_destruct functions

2019-04-25 Thread Jakub Kicinski
tls_device_sk_destruct being set on a socket used to indicate that socket is a kTLS device one. That is no longer true - now we use sk_validate_xmit_skb pointer for that purpose. Remove the export. tls_device_attach() needs to be moved. While at it, remove the dead declaration of tls_sk_destruct

Re: [bpf PATCH v2 1/3] bpf: tls, implement unhash to avoid transition out of ESTABLISHED

2019-04-25 Thread John Fastabend
On 4/25/19 12:29 PM, Jakub Kicinski wrote: > On Thu, 25 Apr 2019 09:03:08 -0700, John Fastabend wrote: >> +static void tls_sk_proto_unhash(struct sock *sk) >> +{ >> +struct tls_context *ctx = tls_get_ctx(sk); >> +void (*sk_proto_unhash)(struct sock *sk); >> +bool free_ctx; >> + >> +

  1   2   >