On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote: > To avoid a sparse warning byteswap the be32 sequence number > before it's stored in the atomic value. While at it drop > unnecessary brackets and use kernel's u64 type. > > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> > Reviewed-by: Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- > include/net/tls.h | 2 +- > net/tls/tls_device.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/net/tls.h b/include/net/tls.h > index 41a2ee643fc5..39ea62f0c1f6 100644 > --- a/include/net/tls.h > +++ b/include/net/tls.h > @@ -562,7 +562,7 @@ static inline void > tls_offload_rx_resync_request(struct sock *sk, __be32 seq) > struct tls_context *tls_ctx = tls_get_ctx(sk); > struct tls_offload_context_rx *rx_ctx = > tls_offload_ctx_rx(tls_ctx); > > - atomic64_set(&rx_ctx->resync_req, ((((uint64_t)seq) << 32) | > 1)); > + atomic64_set(&rx_ctx->resync_req, ((u64)ntohl(seq) << 32) | 1); > } > > > diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c > index cb368efe3567..6686013b4e9e 100644 > --- a/net/tls/tls_device.c > +++ b/net/tls/tls_device.c > @@ -567,7 +567,7 @@ void (struct sock *sk, u32 > seq, u64 rcd_sn) > > rx_ctx = tls_offload_ctx_rx(tls_ctx); > resync_req = atomic64_read(&rx_ctx->resync_req); > - req_seq = ntohl(resync_req >> 32) - ((u32)TLS_HEADER_SIZE - 1); > + req_seq = (resync_req >> 32) - ((u32)TLS_HEADER_SIZE - 1);
this is not equivalent to what was before, resync_req is expected to be in network order, (TLS_HEADER_SIZE -1) is still in cpu indianness. > is_req_pending = resync_req; > > if (unlikely(is_req_pending) && req_seq == seq &&
