On Wed, 3 Apr 2019 01:11:36 +0200
Matteo Croce wrote:
> The thunderx driver forbids to load an eBPF program if the MTU is higher
> than 1500 bytes, but this can be circumvented by first loading the eBPF,
> and then raising the MTU.
>
> XDP assumes that SKBs are linear and fit in a single page,
Kevin 'ldir' Darbyshire-Bryant wrote on 02/04/2019 12:24:
> Hi Cong & all,
>
>> On 1 Apr 2019, at 22:06, Cong Wang wrote:
>>
>> On Mon, Apr 1, 2019 at 7:22 AM Paul Blakey wrote:
>>>
>>
>
>>
>>>
>>> This would probably be better off with the previous name act_conndscp.
>>
>>
>> If naming is th
On 04/02/2019 06:17 PM, Jakub Kicinski wrote:
> On Fri, 22 Mar 2019 08:56:40 -0700, Eric Dumazet wrote:
>> Often times, recvmsg() system calls and BH handling for a particular
>> TCP socket are done on different cpus.
>>
>> This means the incoming skb had to be allocated on a cpu,
>> but freed o
> On 3 Apr 2019, at 08:47, Paul Blakey wrote:
>
>
>
> Kevin 'ldir' Darbyshire-Bryant wrote on 02/04/2019 12:24:
>> Hi Cong & all,
>>
>>> On 1 Apr 2019, at 22:06, Cong Wang wrote:
>>>
>>> On Mon, Apr 1, 2019 at 7:22 AM Paul Blakey wrote:
>>>
>>
>
>
> Hi Kevin,
> If you'd like, Yo
2019-03-29, 21:16:21 +0100, Florian Westphal wrote:
> This series removes all function pointers from the xfrm_mode struct.
> They are either replaced by direct calls or a static helper.
>
> This reduces code size: even merging all xfrm{4,6}_,mode* modules
> into the core reduces total size, as the
On Tue, Apr 02, 2019 at 09:49:50AM -0700, andrii.nakry...@gmail.com wrote:
> From: Andrii Nakryiko
>
> This patch adds new config option to trigger generation of BTF type
> information from DWARF debuginfo for vmlinux and kernel modules through
> pahole, which in turn relies on libbpf for btf_ded
On 04/03/2019 10:46 AM, Jiri Olsa wrote:
> On Tue, Apr 02, 2019 at 09:49:50AM -0700, andrii.nakry...@gmail.com wrote:
>> From: Andrii Nakryiko
>>
>> This patch adds new config option to trigger generation of BTF type
>> information from DWARF debuginfo for vmlinux and kernel modules through
>> pah
On Wed, Apr 03, 2019 at 11:04:28AM +0200, Daniel Borkmann wrote:
> On 04/03/2019 10:46 AM, Jiri Olsa wrote:
> > On Tue, Apr 02, 2019 at 09:49:50AM -0700, andrii.nakry...@gmail.com wrote:
> >> From: Andrii Nakryiko
> >>
> >> This patch adds new config option to trigger generation of BTF type
> >> i
This header is not in use - remove it.
Signed-off-by: Yuval Shaia
---
net/core/dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 2b67f2aa59dd..21a8205a7896 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -131,7 +131,6 @@
#include
#include
#in
On 04/03/2019 11:12 AM, Jiri Olsa wrote:
> On Wed, Apr 03, 2019 at 11:04:28AM +0200, Daniel Borkmann wrote:
>> On 04/03/2019 10:46 AM, Jiri Olsa wrote:
>>> On Tue, Apr 02, 2019 at 09:49:50AM -0700, andrii.nakry...@gmail.com wrote:
From: Andrii Nakryiko
This patch adds new config opt
Kevin 'ldir' Darbyshire-Bryant wrote on 03/04/2019 11:23:
>
>
>> On 3 Apr 2019, at 08:47, Paul Blakey wrote:
>>
>>
>>
>> Kevin 'ldir' Darbyshire-Bryant wrote on 02/04/2019 12:24:
>>> Hi Cong & all,
>>>
On 1 Apr 2019, at 22:06, Cong Wang wrote:
On Mon, Apr 1, 2019 at 7:22 AM Pau
BITS_TO_LONGS() uses DIV_ROUND_UP() because of
this ppmax value can be greater than available
per cpu page pods.
This patch removes BITS_TO_LONGS() to fix this
issue.
Signed-off-by: Varun Prakash
---
drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c | 9 -
1 file changed, 8 insertions(
Em Wed, Apr 03, 2019 at 11:12:58AM +0200, Jiri Olsa escreveu:
> On Wed, Apr 03, 2019 at 11:04:28AM +0200, Daniel Borkmann wrote:
> > On 04/03/2019 10:46 AM, Jiri Olsa wrote:
> > > On Tue, Apr 02, 2019 at 09:49:50AM -0700, andrii.nakry...@gmail.com wrote:
> > >> From: Andrii Nakryiko
> > >>
> > >>
On 04/02/2019 11:28 PM, Florian Westphal wrote:
> syzbot reports:
> BUG: using __this_cpu_read() in preemptible code:
> caller is dev_recursion_level include/linux/netdevice.h:3052 [inline]
> __this_cpu_preempt_check+0x246/0x270 lib/smp_processor_id.c:47
> dev_recursion_level include/linux/net
From: Jiri Pirko
Extend devlink port attrs to contain switch ID and change drivers that
register devlink ports to use that.
Jiri Pirko (13):
net: devlink: convert devlink_port_attrs bools to bits
net: devlink: extend port attrs for switch ID
net: devlink: introduce devlink_compat_switch_id
From: Jiri Pirko
Currently the switch_id is being only initialized when switching eswitch
mode from "legacy" to "switchdev". However, nothing prevents the id to
be initialized from the very beginning. Physical ports can show it even
in "legacy" mode.
Signed-off-by: Jiri Pirko
---
v3->v4:
- new
From: Jiri Pirko
Introduce devlink_compat_switch_id_get() helper which fills up switch_id
according to passed netdev pointer. Call it directly from
dev_get_port_parent_id() as a fallback when ndo_get_port_parent_id
is not defined for given netdev.
Signed-off-by: Jiri Pirko
---
v3->v4:
- continu
From: Jiri Pirko
Pass the switch ID down the to devlink through devlink_port_attrs_set()
so it can be used by devlink_compat_switch_id_get(). Leave
ndo_get_port_parent_id implementation only for legacy.
Signed-off-by: Jiri Pirko
Reviewed-by: Florian Fainelli
---
v2->v3:
- fix parent id ndo com
From: Jiri Pirko
Extend devlink_port_attrs_set() to pass switch ID for ports which are
part of switch and store it in port attrs. For other ports, this is
NULL.
Note that this allows the driver to group devlink ports into one or more
switches according to the actual topology.
Signed-off-by: Jir
From: Jiri Pirko
Pass the switch ID down the to devlink through devlink_port_attrs_set()
so it can be used by devlink_compat_switch_id_get().
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 6 --
drivers/net/ethernet/mellanox/mlxsw/core.h | 4 +++-
driver
From: Jiri Pirko
Remove implementation of get_port_parent_id ndo and rely on core calling
into devlink for the information directly.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/minimal.c | 13 -
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 13
From: Jiri Pirko
Currently if the driver registers devlink port instance, he should set
the devlink port attributes as well. Then the devlink core is able to
obtain switch id itself, no need for driver to implement the ndo.
Once all drivers will implement devlink port registration, this ndo
shoul
From: Jiri Pirko
In order to save space in the struct, convert bools to bits.
Signed-off-by: Jiri Pirko
Reviewed-by: Florian Fainelli
Reviewed-by: Jakub Kicinski
---
include/net/devlink.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/devlink.h b/include/
From: Jiri Pirko
Obtain HW id and pass it down to mlxsw_core_port_init() as it would be
used as switch_id in devlink and exposed to user.
Signed-off-by: Jiri Pirko
---
.../net/ethernet/mellanox/mlxsw/switchib.c| 22 ++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff
From: Jiri Pirko
Remove implementation of get_port_parent_id ndo and rely on core calling
into devlink for the information directly.
Signed-off-by: Jiri Pirko
Reviewed-by: Jakub Kicinski
---
.../net/ethernet/netronome/nfp/nfp_net_common.c | 1 -
.../net/ethernet/netronome/nfp/nfp_net_repr.c
From: Jiri Pirko
Pass the switch ID down the to devlink through devlink_port_attrs_set()
so it can be used by devlink_compat_switch_id_get().
Signed-off-by: Jiri Pirko
Reviewed-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 5 -
1 file changed, 4 insertions(+),
From: Jiri Pirko
Pass the switch ID down the to devlink through devlink_port_attrs_set()
so it can be used by devlink_compat_switch_id_get().
Signed-off-by: Jiri Pirko
---
rfc->v1:
- new patch
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 3 ++-
1 file changed, 2 insertions(+), 1 del
From: Jiri Pirko
Remove implementation of get_port_parent_id ndo and rely on core calling
into devlink for the information directly.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnx
> On 3 Apr 2019, at 12:56, Paul Blakey wrote:
>
>
>
> Kevin 'ldir' Darbyshire-Bryant wrote on 03/04/2019 11:23:
>>
>>
>>> On 3 Apr 2019, at 08:47, Paul Blakey wrote:
>>>
>>>
>>>
>>> Kevin 'ldir' Darbyshire-Bryant wrote on 02/04/2019 12:24:
Hi Cong & all,
> On 1 Apr 2019,
Recent refactoring of fl_change aims to use the classifier spinlock to
avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer()
function was moved to before the lock is taken. This can create problems
for drivers if duplicate filters are created (commmon in ovs tc offload
due to filters
[+cc Frederick]
On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote:
> On 02.04.2019 23:57, Bjorn Helgaas wrote:
> > On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote:
> >> On 02.04.2019 22:16, Florian Fainelli wrote:
> >>> On 4/2/19 12:55 PM, Heiner Kallweit wrote:
> >>>
On Sun, Mar 31, 2019 at 9:06 PM David Ahern wrote:
>
> On 3/26/19 1:18 PM, Steve Wise wrote:
> > This function sends the constructed netlink message and then
> > receives the response.
> >
> > Change rd_recv_msg() to display any error messages.
> >
> > Change 'rdma dev set' to use rd_sendrecv_msg(
On Tue, Apr 02, 2019 at 10:39:29AM -0700, Alexei Starovoitov wrote:
> On Tue, Apr 02, 2019 at 04:37:19PM +0200, Daniel Borkmann wrote:
> > On 04/02/2019 01:58 PM, Paul Chaignon wrote:
> > > Three checks for verifier bugs were introduced in commit f4d7e40 ("bpf:
> > > introduce function calls (verif
On 04/01/2019 10:57 PM, Stanislav Fomichev wrote:
> This patch series fixes the existing BPF flow dissector API to
> support calling BPF progs from the eth_get_headlen context (the support
> itself will be added in bpf-next tree).
>
> The summary of the changes:
> * fix VLAN handling in bpf_flow
Hi,
We just had this happen on 5.0.2
It looks like the interface went down, ended up in a broken state and
a ip li set down/up dev enp2s0f0 made it work again
It looks really weird and I haven't really seen anything like it,
anyone with a clue?
dmesg:
[1310361.808694] bnx2x :02:00.0 en
This patch adds tests validating that VRF and BPF-LWT
encap work together well, as requested by David Ahern.
Signed-off-by: Peter Oskolkov
---
.../selftests/bpf/test_lwt_ip_encap.sh| 134 +++---
1 file changed, 86 insertions(+), 48 deletions(-)
diff --git a/tools/testing/sel
On 02/04/2019 15:37, Daniel Borkmann wrote:
> If we really want to have a kernel warn, then lets add a
> helper macro verbose_and_warn(...) which will trigger a one-time warning, but
> keeps
> the verbose log intact as well.
+1
Any time the verifier detects that its internal invariants have been
On Wed 03 Apr 2019 at 01:53, John Hurley wrote:
> Recent changes to TC flower remove the requirement for rtnl lock when
> accessing and modifying filters. Refcounts now ensure access and deletion
> do not happen concurrently. However, the reoffload function which cycles
> through all filters and r
On 04/02/2019 10:19 PM, Andrey Ignatov wrote:
> It's hard to guarantee that whole memory is marked as initialized on
> helper return if uninitialized stack is accessed with variable offset
> since specific bounds are unknown to verifier. This may cause
> uninitialized stack leaking.
>
> Reject suc
On Wed 03 Apr 2019 at 15:37, John Hurley wrote:
> Recent refactoring of fl_change aims to use the classifier spinlock to
> avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer()
> function was moved to before the lock is taken. This can create problems
> for drivers if duplicate fi
On 04/03/2019 06:21 PM, Daniel Borkmann wrote:
> On 04/02/2019 10:19 PM, Andrey Ignatov wrote:
>> It's hard to guarantee that whole memory is marked as initialized on
>> helper return if uninitialized stack is accessed with variable offset
>> since specific bounds are unknown to verifier. This may
Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma
device to a netdev interface.
EG:
rdma link add rxe_eth0 type rxe netdev eth0
rdma link delete rxe_eth0
Signed-off-by: Steve Wise
Reviewed-by: Leon Romanovsky
---
rdma/link.c | 78 +++
This function sends the constructed netlink message and then
receives the response.
Change rd_recv_msg() to display any error messages.
Change 'rdma dev set' to use rd_sendrecv_msg().
Signed-off-by: Steve Wise
Reviewed-by: Leon Romanovsky
---
rdma/dev.c | 2 +-
rdma/rdma.h | 2 ++
rdma/r
.mailmap allows tracking multiple email addresses to the proper user name.
Signed-off-by: Steve Wise
Reviewed-by: Leon Romanovsky
---
.mailmap | 8
1 file changed, 8 insertions(+)
create mode 100644 .mailmap
diff --git a/.mailmap b/.mailmap
new file mode 100644
index ..c012d3
This series adds rdmatool support for creating/deleting rdma links.
This will be used, mainly, by soft rdma drivers to allow adding/deleting
rdma links over netdev interfaces. It provides the user side for
the following kernel changes merged in linux-5.1.
Changes since v2:
- move checks for requ
Update the 'rdma link' man page with 'link add/delete' info.
Signed-off-by: Steve Wise
---
man/man8/rdma-link.8 | 47
1 file changed, 47 insertions(+)
diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8
index bddf3474..b3b40de7 100644
--- a/man/
On Wed, Apr 03, 2019 at 04:52:40PM +0100, Edward Cree wrote:
> On 02/04/2019 15:37, Daniel Borkmann wrote:
> > If we really want to have a kernel warn, then lets add a
> > helper macro verbose_and_warn(...) which will trigger a one-time warning,
> > but keeps
> > the verbose log intact as well.
>
On Wed, Apr 03, 2019 at 12:10:32PM -0500, Steve Wise wrote:
> Update the 'rdma link' man page with 'link add/delete' info.
>
> Signed-off-by: Steve Wise
> ---
> man/man8/rdma-link.8 | 47
> 1 file changed, 47 insertions(+)
>
Thanks,
Reviewed-by: Leon
On Wed, Apr 03, 2019 at 12:10:28PM -0500, Steve Wise wrote:
> This series adds rdmatool support for creating/deleting rdma links.
> This will be used, mainly, by soft rdma drivers to allow adding/deleting
> rdma links over netdev interfaces. It provides the user side for
> the following kernel cha
On 02/04/2019 21:10, Nikolay Aleksandrov wrote:
> On 02/04/2019 18:35, Mike Manning wrote:
>> If vlan bridge binding is enabled, then the link state of a vlan device
>> that is an upper device of the bridge should track the state of bridge
>> ports that are members of that vlan. So if a bridge port
On Tue, Apr 02, 2019 at 12:56:09PM +, Rundong Ge wrote:
> Problem:
> When bridge-nf-call-iptables is enabled, skb_dst(skb) of packets that
> in the nfqueue may be a dangling pointer if user delete the bridge.
> Because packets go through the br_nf_pre_routing_finish will set the dst
> pointer t
On 02/04/2019 20:22, Nikolay Aleksandrov wrote:
> On 02/04/2019 18:35, Mike Manning wrote:
>> In the case of vlan filtering on bridges, the bridge may also have the
>> corresponding vlan devices as upper devices. A vlan bridge binding mode
>> is added to allow the link state of the vlan device to t
On 03.04.2019 15:14, Bjorn Helgaas wrote:
> [+cc Frederick]
>
> On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote:
>> On 02.04.2019 23:57, Bjorn Helgaas wrote:
>>> On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote:
On 02.04.2019 22:16, Florian Fainelli wrote:
>
On 02/04/2019 21:15, Nikolay Aleksandrov wrote:
> On 02/04/2019 18:35, Mike Manning wrote:
>> In vlan bridge binding mode, the link state is no longer transferred
>> from the lower device. Instead it is set by the bridge module according
>> to the state of bridge ports that are members of the vlan.
On 03/04/2019 20:43, Mike Manning wrote:
> On 02/04/2019 20:22, Nikolay Aleksandrov wrote:
>> On 02/04/2019 18:35, Mike Manning wrote:
>>> In the case of vlan filtering on bridges, the bridge may also have the
>>> corresponding vlan devices as upper devices. A vlan bridge binding mode
>>> is added
This reverts commit 6578229d4efb7ea6287861bfc2bd306140458e07.
netif_receive_skb_list() doesn't support GRO, therefore we may have
scenarios with decreased performance. See discussion here [0].
[0] https://marc.info/?t=15540384741&r=1&w=2
Signed-off-by: Heiner Kallweit
---
drivers/net/ethern
On 4/2/19, 4:26 PM, "David Miller" wrote:
> From: Michael Zhivich
> Date: Mon, 1 Apr 2019 13:14:28 -0400
>
>> When building C++ userspace code that includes ethtool.h
>> with "-Werror -Wall", g++ complains about signed-unsigned comparison in
>> ethtool_validate_speed() due to definition of SPEE
On 03/04/2019 20:53, Nikolay Aleksandrov wrote:
> On 03/04/2019 20:43, Mike Manning wrote:
>> On 02/04/2019 20:22, Nikolay Aleksandrov wrote:
>>> On 02/04/2019 18:35, Mike Manning wrote:
In the case of vlan filtering on bridges, the bridge may also have the
corresponding vlan devices as u
Meanwhile we have generic functions for reading the abilities of
Clause 22 / 45 PHY's. This allows to use them as fallback in case
callback get_features isn't set. Benefit is the reduction of
boilerplate code in PHY drivers.
Heiner Kallweit (2):
net: phy: allow a PHY driver to define neither fea
Meanwhile we have generic functions for reading the abilities of
Clause 22 / 45 PHY's. This allows to use them as fallback in case
callback get_features isn't set. Benefit is the reduction of
boilerplate code in PHY drivers.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/phy_device.c | 17 ++
Now that phylib uses genphy_read_abilities() as fallback, we don't have
to set callback get_features any longer.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/realtek.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index
On 03/04/2019 21:17, Nikolay Aleksandrov wrote:
> On 03/04/2019 20:53, Nikolay Aleksandrov wrote:
>> On 03/04/2019 20:43, Mike Manning wrote:
>>> On 02/04/2019 20:22, Nikolay Aleksandrov wrote:
On 02/04/2019 18:35, Mike Manning wrote:
> In the case of vlan filtering on bridges, the bridge
On Mon, 1 Apr 2019 13:57:34 -0700
Stanislav Fomichev wrote:
> diff --git a/Documentation/networking/bpf_flow_dissector.txt
> b/Documentation/networking/bpf_flow_dissector.txt
> new file mode 100644
> index ..513be8e20afb
> --- /dev/null
> +++ b/Documentation/networking/bpf_flow_diss
On 04/03, Jesper Dangaard Brouer wrote:
> On Mon, 1 Apr 2019 13:57:34 -0700
> Stanislav Fomichev wrote:
>
> > diff --git a/Documentation/networking/bpf_flow_dissector.txt
> > b/Documentation/networking/bpf_flow_dissector.txt
> > new file mode 100644
> > index ..513be8e20afb
> > ---
Begin forwarded message:
Date: Wed, 03 Apr 2019 04:49:49 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 203137] New: Bridge does not forward multicast if
multicast_querier is enabled
https://bugzilla.kernel.org/show_bug.cgi?id=203137
On 4/2/19 11:27 PM, Martin Lau wrote:
> On Tue, Apr 02, 2019 at 02:11:53PM -0700, David Ahern wrote:
>> From: David Ahern
>>
>> Second set of three with the end goal of enabling IPv6 gateways with IPv4
>> routes.
> I am still not completely convinced on the new "*nhc" in patch 2 without
> seeing a
On 4/3/19 11:10 AM, Steve Wise wrote:
> This series adds rdmatool support for creating/deleting rdma links.
> This will be used, mainly, by soft rdma drivers to allow adding/deleting
> rdma links over netdev interfaces. It provides the user side for
> the following kernel changes merged in linux-5
Heiner Kallweit wrote on 4/3/19 12:45 PM:
On 03.04.2019 15:14, Bjorn Helgaas wrote:
[+cc Frederick]
On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote:
On 02.04.2019 23:57, Bjorn Helgaas wrote:
On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote:
On 02.04.2019 22:16,
On 03/04/2019 21:53, Stephen Hemminger wrote:
>
>
> Begin forwarded message:
>
> Date: Wed, 03 Apr 2019 04:49:49 +
> From: bugzilla-dae...@bugzilla.kernel.org
> To: step...@networkplumber.org
> Subject: [Bug 203137] New: Bridge does not forward multicast if
> multicast_querier is enabled
>
On 03.04.2019 21:18, Frederick Lawler wrote:
> Heiner Kallweit wrote on 4/3/19 12:45 PM:
>> On 03.04.2019 15:14, Bjorn Helgaas wrote:
>>> [+cc Frederick]
>>>
>>> On Wed, Apr 03, 2019 at 07:53:40AM +0200, Heiner Kallweit wrote:
On 02.04.2019 23:57, Bjorn Helgaas wrote:
> On Tue, Apr 02, 201
On 03/04/2019 18:30, Alexei Starovoitov wrote:
> verbose_and_warn() doesn't fit these two practical cases of warn + verbose.
> Hence I see no reason to combine warn and verbose into single helper.
> They're perfectly fine being separate.
Makes sense.
So presumably the right patch would be to add m
> @@ -2218,9 +2223,9 @@ int phy_driver_register(struct phy_driver *new_driver,
> struct module *owner)
> /* Either the features are hard coded, or dynamically
>* determine. It cannot be both or neither
>*/
Hi Heiner
The comment needs updating to match the code.
> - if
Rename bpf_flow_dissector.txt to bpf_flow_dissector.rst and fix
formatting. Also, link it from the Documentation/networking/index.rst.
Tested with 'make htmldocs' to make sure it looks reasonable.
Fixes: ae82899bbe92 ("flow_dissector: document BPF flow dissector environment")
Signed-off-by: Stani
On Wed, Apr 03, 2019 at 08:20:09PM +0200, Heiner Kallweit wrote:
> Now that phylib uses genphy_read_abilities() as fallback, we don't have
> to set callback get_features any longer.
Hi Heiner
I wonder how many PHY drivers we will break if we just remove
.features everywhere?
Maybe we should crea
Daniel Borkmann [Wed, 2019-04-03 09:22 -0700]:
> On 04/02/2019 10:19 PM, Andrey Ignatov wrote:
> > It's hard to guarantee that whole memory is marked as initialized on
> > helper return if uninitialized stack is accessed with variable offset
> > since specific bounds are unknown to verifier. This
On 03.04.2019 22:55, Andrew Lunn wrote:
> On Wed, Apr 03, 2019 at 08:20:09PM +0200, Heiner Kallweit wrote:
>> Now that phylib uses genphy_read_abilities() as fallback, we don't have
>> to set callback get_features any longer.
>
> Hi Heiner
>
> I wonder how many PHY drivers we will break if we jus
On 03.04.2019 22:46, Andrew Lunn wrote:
>> @@ -2218,9 +2223,9 @@ int phy_driver_register(struct phy_driver *new_driver,
>> struct module *owner)
>> /* Either the features are hard coded, or dynamically
>> * determine. It cannot be both or neither
>> */
>
> Hi Heiner
>
> The comm
Meanwhile we have generic functions for reading the abilities of
Clause 22 / 45 PHY's. This allows to use them as fallback in case
callback get_features isn't set. Benefit is the reduction of
boilerplate code in PHY drivers.
v2:
- adjust a comment in patch 1 to match the code
Heiner Kallweit (2):
Now that phylib uses genphy_read_abilities() as fallback, we don't have
to set callback get_features any longer.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/realtek.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index
Meanwhile we have generic functions for reading the abilities of
Clause 22 / 45 PHY's. This allows to use them as fallback in case
callback get_features isn't set. Benefit is the reduction of
boilerplate code in PHY drivers.
v2:
- adjust the comment in phy_driver_register to match the code
Signed
Hi all,
I've been looking at modem drivers, to see what the APIs are to interact
with them, and while I originally thought I had the story sorted out ...
not at all.
Here's the current things we seem to be doing:
(1) Channels are created/encoded as VLANs (cdc_mbim)
This is ... strange a
Daniel Borkmann [Wed, 2019-04-03 09:46 -0700]:
> On 04/03/2019 06:21 PM, Daniel Borkmann wrote:
> > On 04/02/2019 10:19 PM, Andrey Ignatov wrote:
> >> It's hard to guarantee that whole memory is marked as initialized on
> >> helper return if uninitialized stack is accessed with variable offset
> >
The tx bytecount is done twice. When running
'./xdpsock -t -N -i eth3' and 'ip -s link show dev eth3'
The avg packet size is 120 instead of 60. So remove the
extra one.
Signed-off-by: William Tu
---
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/
The total_packets count at ixgbe_clean_xdp_tx_irq is
always zero when testing with xdpsock -t -N. Set the gso_segs
to 1 to make the tx packet count correct.
Signed-off-by: William Tu
---
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/
On Wed, Apr 03, 2019 at 11:15:17PM +0200, Heiner Kallweit wrote:
> Now that phylib uses genphy_read_abilities() as fallback, we don't have
> to set callback get_features any longer.
>
> Signed-off-by: Heiner Kallweit
Reviewed-by: Andrew Lunn
Andrew
On Wed, Apr 03, 2019 at 11:14:33PM +0200, Heiner Kallweit wrote:
> Meanwhile we have generic functions for reading the abilities of
> Clause 22 / 45 PHY's. This allows to use them as fallback in case
> callback get_features isn't set. Benefit is the reduction of
> boilerplate code in PHY drivers.
>
It's hard to guarantee that whole memory is marked as initialized on
helper return if uninitialized stack is accessed with variable offset
since specific bounds are unknown to verifier. This may cause
uninitialized stack leaking.
Reject such an access in check_stack_boundary to prevent possible
le
Test that verifier rejects indirect access to uninitialized stack with
variable offset.
Example of output:
# ./test_verifier
...
#859/p indirect variable-offset stack access, uninitialized OK
Signed-off-by: Andrey Ignatov
---
.../testing/selftests/bpf/verifier/var_off.c | 27
Proper support of indirect stack access with variable offset in
unprivileged mode (!root) requires corresponding support in Spectre
masking for stack ALU in retrieve_ptr_limit().
There are no use-case for variable offset in unprivileged mode though so
make verifier reject such accesses for simplic
v1->v2:
- rely on meta = NULL to reject var_off stack access to uninit buffer.
This patch set is a follow-up for discussion [1].
It fixes variable offset stack access handling for raw and unprivileged
mode, rejecting both of them.
Patch 1 handles raw (uninitialized) mode.
Patch 2 adds test for r
Test that verifier rejects indirect stack access with variable offset in
unprivileged mode and accepts same code in privileged mode.
Since pointer arithmetics is prohibited in unprivileged mode verifier
should reject the program even before it gets to helper call that uses
variable offset, at the
check_stack_access() that prints verbose log is used in
adjust_ptr_min_max_vals() that prints its own verbose log and now they
stick together, e.g.:
variable stack access var_off=(0xfff0; 0x4) off=-16
size=1R2 stack pointer arithmetic goes out of range, prohibited for
!root
Add
Currently, ksym_search located at trace_helpers won't check symbols are
existing or not.
In ksym_search, when symbol is not found, it will return &syms[0](_stext).
But when the kernel symbols are not loaded, it will return NULL, which is
not a desired action.
This commit will add verification log
Since, ksym_search added with verification logic for symbols existence,
it could return NULL when the kernel symbols are not loaded.
This commit will add NULL check logic after ksym_search.
Signed-off-by: Daniel T. Lee
---
Changes in v3:
- Added NULL check for samples/spintest_user.c
Change
On 04/03/2019 11:02 PM, Andrey Ignatov wrote:
> Daniel Borkmann [Wed, 2019-04-03 09:22 -0700]:
>> On 04/02/2019 10:19 PM, Andrey Ignatov wrote:
>>> It's hard to guarantee that whole memory is marked as initialized on
>>> helper return if uninitialized stack is accessed with variable offset
>>> sin
On 04/03/2019 07:30 PM, Alexei Starovoitov wrote:
> On Wed, Apr 03, 2019 at 04:52:40PM +0100, Edward Cree wrote:
>> On 02/04/2019 15:37, Daniel Borkmann wrote:
>>> If we really want to have a kernel warn, then lets add a
>>> helper macro verbose_and_warn(...) which will trigger a one-time warning,
This patchset fixes the out-of-bound access in bluetooth stack.
Although it is large, all of them follow the same pattern, so
it should not be hard to review. I try to group them as much as
I can. This patchset should cover Dan's patch too.
Please check each patch for details.
(Resending v2 as it
hci_event_packet() blindly assumes all packets are sane, at least
for packets allocated via vhci_get_user() path this is not true.
We have to check if we access skb data out-of-bound with
pskb_may_pull() before each skb->data dereference on RX path.
Reported-and-tested-by: syzbot+cec7a50c412a2c03f
Similarly, we need to check skb->data boundary for
HCI_EV_CMD_COMPLETE event too.
Cc: Marcel Holtmann
Cc: Johan Hedberg
Cc: Dan Carpenter
Reviewed-by: Tomas Bortoli
Signed-off-by: Cong Wang
---
net/bluetooth/hci_event.c | 258 +++---
1 file changed, 215 insert
Similarly, we need to check skb->data boundary for
HCI_EV_LE_META event too.
Note, hci_le_adv_report_evt() and hci_le_ext_adv_report_evt()
are slightly complicated, as they read the length of the field
from the packet as well.
Cc: Marcel Holtmann
Cc: Johan Hedberg
Cc: Dan Carpenter
Reviewed-by
1 - 100 of 132 matches
Mail list logo
