On 03.04.2019 22:55, Andrew Lunn wrote: > On Wed, Apr 03, 2019 at 08:20:09PM +0200, Heiner Kallweit wrote: >> Now that phylib uses genphy_read_abilities() as fallback, we don't have >> to set callback get_features any longer. > > Hi Heiner > > I wonder how many PHY drivers we will break if we just remove > .features everywhere? > At least I have seen no C22 PHY yet that couldn't be handled by genphy_read_abilities. Just for non-TP modes there might be an issue. genphy_read_abilities only sets TP and MII, if a driver checks for e.g. ETHTOOL_LINK_MODE_FIBRE_BIT we may have some work.
> Maybe we should create patches for the Marvell driver and the Broadcom > drivers. I and Florian can test them. > > Andrew > Heiner
