Re: [PATCH v2 iproute2-next 04/11] devlink: Add helper functions for name and value separately

2019-02-24 Thread Aya Levin
On 2/21/2019 4:08 PM, Jiri Pirko wrote: > Thu, Feb 21, 2019 at 02:42:40PM CET, a...@mellanox.com wrote: >> Add a new helper functions which outputs only values (without name >> label) for different types: boolean, uint, uint64, string and binary. >> In addition add a helper function which prints o

Re: r8169 Kernel bug in 4.20.11

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 00:33, Ron Murray wrote: > Hi. > >    I've encountered this bug in the last couple of kernel versions now > (since, say 4.20.8 +/- 0.0.2). > >    I don't see a mention in this mailing list/ Apologies if you've > already seen it. > Thanks for the report. Please create a ticket in ke

pull request: bluetooth-next 2019-02-24

2019-02-24 Thread Johan Hedberg
Hi Dave, Here's the main bluetooth-next pull request for the 5.1 kernel. - Fixes & improvements to mediatek, hci_qca, btrtl, and btmrvl HCI drivers - Fixes to parsing invalid L2CAP config option sizes - Locking fix to bt_accept_enqueue() - Add support for new Marvel sd8977 chipset - Various

[PATCH v2 2/2] drivers: net: phy: mdio-mux: Add support for Generic Mux controls

2019-02-24 Thread Pankaj Bansal
Add support for Generic Mux controls, when Mdio mux node is a consumer of mux produced by some other device. Signed-off-by: Pankaj Bansal --- Notes: V2: - Moved the changes from mdio-mux module to new module mdio-mux-multiplexer - defined new CONFIG - using new compatible "mdio-m

[PATCH v2 1/2] dt-bindings: net: Add bindings for mdio mux consumers

2019-02-24 Thread Pankaj Bansal
When we use the bindings defined in Documentation/devicetree/bindings/mux to define mdio mux in producer and consumer terms, it results in two devices. one is mux producer and other is mux consumer. Add the bindings needed for Mdio mux consumer devices. Signed-off-by: Pankaj Bansal --- Notes:

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 00:42, Andrew Lunn wrote: >> it took me quite some time to debug this issue .. >> >> At first a bisect pointed to one of my commits: >> 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in >> genphy_read_status") >> >> Further digging lead me to some suspicious dsa code: >> In d

Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported

2019-02-24 Thread Or Gerlitz
On Sat, Feb 23, 2019 at 9:58 AM Tonghao Zhang wrote: > On Fri, Feb 22, 2019 at 5:07 PM Or Gerlitz wrote: > > On Fri, Feb 22, 2019 at 9:49 AM Tonghao Zhang > > wrote: > > > On Fri, Feb 22, 2019 at 12:32 AM Or Gerlitz wrote: > > > > On Thu, Feb 21, 2019 at 3:42 PM wrote: > > > > > > > > > > Fro

Re: [PATCH net-next 1/2] nfp: Remove switchdev.h inclusion

2019-02-24 Thread Jiri Pirko
Fri, Feb 22, 2019 at 09:31:33PM CET, f.faine...@gmail.com wrote: >This is no longer necessary after a5084bb71fa4 ("nfp: Implement >ndo_get_port_parent_id()") > >Signed-off-by: Florian Fainelli Acked-by: Jiri Pirko

Re: [PATCH net-next 2/2] net: Remove switchdev.h inclusion from team/bond/vlan

2019-02-24 Thread Jiri Pirko
Fri, Feb 22, 2019 at 09:31:34PM CET, f.faine...@gmail.com wrote: >This is no longer necessary after eca59f691566 ("net: Remove support for >bridge bypass ndos from stacked devices") > >Suggested-by: Ido Schimmel >Signed-off-by: Florian Fainelli Acked-by: Jiri Pirko

Re: [PATCH net-next v3 1/6] net: devlink: turn devlink into a built-in

2019-02-24 Thread Jiri Pirko
Fri, Feb 22, 2019 at 11:07:52PM CET, jakub.kicin...@netronome.com wrote: >Being able to build devlink as a module causes growing pains. >First all drivers had to add a meta dependency to make sure >they are not built in when devlink is built as a module. Now >we are struggling to invoke ethtool co

Re: [PATCH net-next v3 2/6] devlink: create a special NDO for getting the devlink instance

2019-02-24 Thread Jiri Pirko
Fri, Feb 22, 2019 at 11:07:53PM CET, jakub.kicin...@netronome.com wrote: >Instead of iterating over all devlink ports add a NDO which >will return the devlink instance from the driver. > >v2: add the netdev_to_devlink() helper (Michal) >v3: check that devlink has ops (Florian) > >Suggested-by: Jiri

Re: [PATCH net-next v3 3/6] nfp: add .ndo_get_devlink

2019-02-24 Thread Jiri Pirko
Fri, Feb 22, 2019 at 11:07:54PM CET, jakub.kicin...@netronome.com wrote: >Support getting devlink instance from a new NDO. > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko

Re: [PATCH net-next v3 4/6] nfp: remove ethtool flashing fallback

2019-02-24 Thread Jiri Pirko
Fri, Feb 22, 2019 at 11:07:55PM CET, jakub.kicin...@netronome.com wrote: >Now that devlink fallback will be called reliably, we can remove >the ethtool flashing code. > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko

Re: [PATCH net-next v3 5/6] devlink: hold a reference to the netdevice around ethtool compat

2019-02-24 Thread Jiri Pirko
Fri, Feb 22, 2019 at 11:07:56PM CET, jakub.kicin...@netronome.com wrote: >When ethtool is calling into devlink compat code make sure we have >a reference on the netdevice on which the operation was invoked. > >v3: move the hold/lock logic into devlink_compat_* functions (Florian) > >Signed-off-by:

Re: [PATCH net-next v3 6/6] devlink: add missing NULL checks for devlink ops

2019-02-24 Thread Jiri Pirko
Fri, Feb 22, 2019 at 11:07:57PM CET, jakub.kicin...@netronome.com wrote: >Commit 76726ccb7f46 ("devlink: add flash update command") and >commit 2d8dc5bbf4e7 ("devlink: Add support for reload") >access devlink ops without NULL-checking. Add the missing checks. >Note that all drivers currently implem

Re: [RFC v1 10/19] RDMA/irdma: Add connection manager

2019-02-24 Thread Gal Pressman
On 15-Feb-19 19:10, Shiraz Saleem wrote: > +/** > + * irdma_cm_teardown_connections - teardown QPs > + * @iwdev: device pointer > + * @ipaddr: Pointer to IPv4 or IPv6 address > + * @ipv4: flag indicating IPv4 when true There is no ipv4 parameter. > + * @disconnect_all: flag indicating disconnect

Re: [PATCH 1/3] bpf: add helper to check for a valid SYN cookie

2019-02-24 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Lorenz-Bauer/Allow-checking-SYN-cookies-from-XDP-and-tc-cls-act/20190224-180755 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-kexec (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the

Re: [PATCH v5 0/5] M_CAN Framework re-write

2019-02-24 Thread Wolfgang Grandegger
Hello Dan, Am 22.02.19 um 18:05 schrieb Dan Murphy: > Wolfgang > > On 2/22/19 6:50 AM, Dan Murphy wrote: >> Wolfgang >> >> On 2/22/19 3:38 AM, Wolfgang Grandegger wrote: >>> Hello Dan, >>> >>> what kernel version is that patch series for. I have problems to apply it! >>> >> >> It is based off of

Re: [PATCH 1/3] bpf: add helper to check for a valid SYN cookie

2019-02-24 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Lorenz-Bauer/Allow-checking-SYN-cookies-from-XDP-and-tc-cls-act/20190224-180755 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: m68k-sun3_defconfig (attached as .config) compiler: m68k-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0 reproduce

[REGRESSION] v5.0-rc5 rtl8192cu breakage

2019-02-24 Thread Vito Caputo
Never seen this before v5.0-rc5, rc5 is the only v5.0 build I've booted so far, if this is already fixed in a newer rc please let me know. Just wanted to give a heads up since we're so close to v5.0: WiFi stopped functioning abruptly, this appeared in dmesg: [968853.940102] usb 2-1: USB disconne

Re: [RFC v1 08/19] RDMA/irdma: Add privileged UDA queue implementation

2019-02-24 Thread Gal Pressman
On 15-Feb-19 19:10, Shiraz Saleem wrote: > +/** > + * irdma_puda_poll_info - poll cq for completion > + * @cq: cq for poll > + * @info: info return for successful completion > + */ > +static enum irdma_status_code > +irdma_puda_poll_info(struct irdma_sc_cq *cq, struct irdma_puda_cmpl_info > *info)

[PATCH v3 iproute2-next 05/11] devlink: Add devlink health show command

2019-02-24 Thread Aya Levin
Add devlink health show command which displays status and configuration info on a specific reporter on a device or dump the info on all reporters on all devices. Add helper functions to display status and dump's time stamp. Example: $ devlink health show pci/:00:09.0 reporter tx pci/:00:09.

[PATCH v3 iproute2-next 00/11] Add support for devlink health

2019-02-24 Thread Aya Levin
This series adds support for devlink health commands: devlink health show [ DEV reporter REPORTER_NAME ] devlink health recoverDEV reporter REPORTER_NAME devlink health diagnose DEV reporter REPORTER_NAME devlink health dump show DEV reporter REPORTER_NAME devlink health dump clear

[PATCH v3 iproute2-next 07/11] devlink: Add devlink health diagnose command

2019-02-24 Thread Aya Levin
Add devlink health diagnose command: enabling retrieval of diagnostics data by the user on a reporter on a device. The command's output is a free text defined by the reporter. This patch also introduces an infra structure for flexible format output. This allow the command to display different data

[PATCH v3 iproute2-next 08/11] devlink: Add devlink health dump show command

2019-02-24 Thread Aya Levin
Add devlink dump show command which displays the last saved dump. Devlink health saves a single dump. If a dump is not already stored by the devlink for this reporter, devlink generates a new dump. The dump can be generated automatically when a reporter reports on an error or manually by user's req

[PATCH v3 iproute2-next 09/11] devlink: Add devlink health dump clear command

2019-02-24 Thread Aya Levin
Add devlink dump clear command which deletes the last saved dump file. Clearing the last saved dump enables a new dump file to be saved. Example: $ devlink health dump clear pci/:00:09.0 reporter tx Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Acked-by: Jiri Pirko --- devlink/devlin

[PATCH v3 iproute2-next 11/11] devlink: Add devlink-health man page

2019-02-24 Thread Aya Levin
Add a man page describing devlink health's command set. Also add a reference link from devlink main man page. Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Acked-by: Jiri Pirko --- man/man8/devlink-health.8 | 197 ++ man/man8/devlink.8|

[PATCH v3 iproute2-next 01/11] devlink: Refactor validation of finding required arguments

2019-02-24 Thread Aya Levin
Introducing argument's metadata structure matching a bitmap flag per required argument and an error message if missing. Using this static array to refactor validation of finding required arguments in devlink command line and to ease further maintenance. Signed-off-by: Aya Levin Reviewed-by: Moshe

[PATCH v3 iproute2-next 10/11] devlink: Add devlink health set command

2019-02-24 Thread Aya Levin
Add devlink set command which enables the user to configure parameters related to the devlink health mechanism per reporter. 1) grace_period [msec] time interval between auto recoveries. 2) auto_recover [true/false] whether the devlink should execute automatic recover on error. Add a helper functio

[PATCH v3 iproute2-next 04/11] devlink: Add helper functions for name and value separately

2019-02-24 Thread Aya Levin
Add a new helper functions which outputs only values (without name label) for different types: boolean, uint, uint64, string and binary. In addition add a helper function which prints only the name label. Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Acked-by: Jiri Pirko --- devlink/devl

[PATCH v3 iproute2-next 03/11] devlink: Fix boolean JSON print

2019-02-24 Thread Aya Levin
This patch removes the inverted commas from boolean values in JSON format: true/false instead of "true"/"false". Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Acked-by: Jiri Pirko --- devlink/devlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/devlink/devl

[PATCH v3 iproute2-next 06/11] devlink: Add devlink health recover command

2019-02-24 Thread Aya Levin
Add devlink health recover command which enables the user to initiate a recovery on a reporter (if a recovery cb was supplied by the reporter). This operation will increment the recoveries counter displayed in the show command. Example: $ devlink health recover pci/:00:09.0 reporter tx Signed-

[PATCH v3 iproute2-next 02/11] devlink: Fix print of uint64_t

2019-02-24 Thread Aya Levin
This patch prints uint64_t with its corresponding format and avoid implicit cast to uint32_t. Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Acked-by: Jiri Pirko --- devlink/devlink.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/d

[PATCH 3/4] mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling it too late

2019-02-24 Thread Marc Zyngier
The mwifiex driver makes unsafe assumptions about the state of the wake-up interrupt. It requests it and only then disable it. Of course, the interrupt may be screaming for whatever reason at that time, and the handler will then be called without the interrupt having been registered with the PM/wak

[PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-24 Thread Marc Zyngier
For quite some time, I wondered why the PCI mwifiex device built in my Chromebook was unable to use the good old legacy interrupts. But as MSIs were working fine, I never really bothered investigating. I finally had a look, and the result isn't very pretty. On this machine (rk3399-based kevin), th

[PATCH 4/4] arm64: dts: rockchip: gru: Move wifi wake-up interrupt into its own subnode

2019-02-24 Thread Marc Zyngier
In order to get PCIe legacy interrupts working on gru-based Chromebooks, let's move the wake-up interrupt out of the way and into its own subnode. This ensures that this interrupt specifier will not be mistaken as a PCI interrupt. Signed-off-by: Marc Zyngier --- arch/arm64/boot/dts/rockchip/rk33

[PATCH 2/4] mwifiex: Fetch wake-up interrupt from 'wake-up' subnode when it exists

2019-02-24 Thread Marc Zyngier
Encoding the wake-up interrupt as part of the PCI DT node is completely broken, as it violates the most basic rules of PCI description in OF: the interrupts described in such node are supposed to apply to the PCI device, and not to some non-PCI stuff on the side. In such a configuration, both the

[PATCH 1/4] dt-bindings/marvell-8xxx: Allow wake-up interrupt to be placed in a separate node

2019-02-24 Thread Marc Zyngier
The DT binding for the PCI version of the Marvell 8xxx wifi devices is pretty broken (the fact that a PCI device requires a DT binding is quite telling on its own). The binding allows the description of a wake-up interrupt as a sideband signal, allowing the wifi device to wake-up the system. So fa

Re: [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs

2019-02-24 Thread Gal Pressman
On 15-Feb-19 19:10, Shiraz Saleem wrote: > /** > * irdma_dealloc_ucontext - deallocate the user context data structure > * @context: user context created during alloc > */ > static int irdma_dealloc_ucontext(struct ib_ucontext *context) > { > struct irdma_ucontext *ucontext = to_ucontext(c

Re: [PATCH v2 2/2] drivers: net: phy: mdio-mux: Add support for Generic Mux controls

2019-02-24 Thread Andrew Lunn
> +static int mdio_mux_multiplexer_switch_fn(int current_child, int > desired_child, > + void *data) > +{ > + struct platform_device *pdev; > + struct mdio_mux_multiplexer_state *s; > + int ret = 0; > + > + pdev = (struct platform_device *)data

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for mdio mux consumers

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 08:49:21AM +, Pankaj Bansal wrote: > When we use the bindings defined in Documentation/devicetree/bindings/mux > to define mdio mux in producer and consumer terms, it results in two > devices. one is mux producer and other is mux consumer. > > Add the bindings needed fo

Re: [RFC v1 04/19] RDMA/irdma: Add driver framework definitions

2019-02-24 Thread Gal Pressman
On 15-Feb-19 19:10, Shiraz Saleem wrote: > +/* client interface functions */ > +static const struct i40e_client_ops i40e_ops = { > + .open = i40iw_open, > + .close = i40iw_close, > + .l2_param_change = i40iw_l2param_change, > + .virtchnl_receive = NULL, > + .vf_reset = NULL, > +

Re: stmmac / meson8b-dwmac

2019-02-24 Thread Simon Huelck
Am 21.02.2019 um 18:46 schrieb Jerome Brunet: > On Thu, 2019-02-21 at 18:27 +0100, Simon Huelck wrote: >> Hi, >> >> >> >> this was changed recently, with a patch for the EEE stuff , see here: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.0-rc7&id=e35e26b26e95

Re: stmmac / meson8b-dwmac

2019-02-24 Thread Simon Huelck
Am 24.02.2019 um 16:00 schrieb Simon Huelck: > Am 21.02.2019 um 18:46 schrieb Jerome Brunet: >> On Thu, 2019-02-21 at 18:27 +0100, Simon Huelck wrote: >>> Hi, >>> >>> >>> >>> this was changed recently, with a patch for the EEE stuff , see here: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/gi

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Andrew Lunn
> I think what's not correct is that phydev->autoneg is set > (by phy_device_create) for a fixed link. Fixed-link tries to emulate auto-neg: bmsr |= BMSR_LSTATUS | BMSR_ANEGCOMPLETE; Maybe it needs better emulation of auto-neg? Andrew

[PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Tariq Toukan
From: Aya Levin Introduce 50Gbps per lane link modes and 200Gbps speed, update print functions and initialization functions accordingly. In addition, update related man page accordingly. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan --- ethtool-copy.h | 19 ++- ethtool.

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Russell King - ARM Linux admin
On Sun, Feb 24, 2019 at 04:04:03PM +0100, Andrew Lunn wrote: > > I think what's not correct is that phydev->autoneg is set > > (by phy_device_create) for a fixed link. > > Fixed-link tries to emulate auto-neg: > > bmsr |= BMSR_LSTATUS | BMSR_ANEGCOMPLETE; > > Maybe it needs bette

Re: [PATCH iproute2-next v2 00/19] Export object IDs to users

2019-02-24 Thread David Ahern
On 2/23/19 4:15 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v1->v2: > * Fixed commit messages > * Added Steve's ROB > v0->v1: > * Rebased to latest iproute2-next > * Added latest rdma_netlink.h and updated commit message to point >to kernel SHA commit. > > This se

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 16:15, Russell King - ARM Linux admin wrote: > On Sun, Feb 24, 2019 at 04:04:03PM +0100, Andrew Lunn wrote: >>> I think what's not correct is that phydev->autoneg is set >>> (by phy_device_create) for a fixed link. >> >> Fixed-link tries to emulate auto-neg: >> >> bmsr

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Russell King - ARM Linux admin
On Sun, Feb 24, 2019 at 12:42:35AM +0100, Andrew Lunn wrote: > Looking forward, at some point we are going to have to make fixed-link > support higher speeds. That probably means we need a swphy-c45 which > emulates the standard registers for 2.5G, 5G and 10G. At that point > genphy will not work..

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Russell King - ARM Linux admin
On Sun, Feb 24, 2019 at 04:28:32PM +0100, Heiner Kallweit wrote: > On 24.02.2019 16:15, Russell King - ARM Linux admin wrote: > > On Sun, Feb 24, 2019 at 04:04:03PM +0100, Andrew Lunn wrote: > >>> I think what's not correct is that phydev->autoneg is set > >>> (by phy_device_create) for a fixed lin

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 16:34, Russell King - ARM Linux admin wrote: > On Sun, Feb 24, 2019 at 04:28:32PM +0100, Heiner Kallweit wrote: >> On 24.02.2019 16:15, Russell King - ARM Linux admin wrote: >>> On Sun, Feb 24, 2019 at 04:04:03PM +0100, Andrew Lunn wrote: > I think what's not correct is that phyde

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Russell King - ARM Linux admin
On Sun, Feb 24, 2019 at 04:39:30PM +0100, Heiner Kallweit wrote: > On 24.02.2019 16:34, Russell King - ARM Linux admin wrote: > > On Sun, Feb 24, 2019 at 04:28:32PM +0100, Heiner Kallweit wrote: > >> On 24.02.2019 16:15, Russell King - ARM Linux admin wrote: > >>> On Sun, Feb 24, 2019 at 04:04:03PM

Re: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

2019-02-24 Thread Florian Fainelli
Le 2/23/19 à 12:45 AM, Ioana Ciornei a écrit : > >> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check >> >> port_switchdev_event() does not check that the target network device is >> actually backed by the ethsw driver, this could be problematic in a stacked >> environmen

Re: [PATCH 0/3] Cover letter: Add support for high speed MAC in Cadence controller driver

2019-02-24 Thread Florian Fainelli
Hi, Le 2/22/19 à 12:11 PM, Parshuram Thombare a écrit : > Hello ! > > This patch series contain changes to support high speed MAC and PCS > in Cadence ethernet controller driver. >From patch submission perspective, your cover letter and individual patches do not appear as a reply to this cover l

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Florian Fainelli
Le 2/24/19 à 7:49 AM, Russell King - ARM Linux admin a écrit : > On Sun, Feb 24, 2019 at 04:39:30PM +0100, Heiner Kallweit wrote: >> On 24.02.2019 16:34, Russell King - ARM Linux admin wrote: >>> On Sun, Feb 24, 2019 at 04:28:32PM +0100, Heiner Kallweit wrote: On 24.02.2019 16:15, Russell King

[PATCH net-next] net: phy: improve auto-neg emulation in swphy

2019-02-24 Thread Heiner Kallweit
Auto-neg emulation currently doesn't set bit BMCR_ANENABLE in BMCR, add this. Users will ignore speed and duplex settings in BMCR because we're emulating auto-neg, therefore we can remove related code. See also following discussion [0]. [0] https://marc.info/?t=15504178492&r=1&w=2 Signed-off-

Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section

2019-02-24 Thread Florian Fainelli
Le 2/22/19 à 11:58 AM, David Miller a écrit : > From: Florian Fainelli > Date: Wed, 20 Feb 2019 14:58:50 -0800 > >> Update the section about switchdev drivers having to implement a >> switchdev_port_attr_get() function to return >> SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid af

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-24 Thread Florian Fainelli
Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : > On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: >> Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field >> from all clients, which were migrated to use switchdev notification in >> the previous patches. >> >> Add a

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 05:08:21PM +0200, Tariq Toukan wrote: > From: Aya Levin > index 5a26cff5fb33..64ce0711ad5f 100644 > --- a/ethtool.8.in > +++ b/ethtool.8.in > @@ -650,6 +650,11 @@ lB l lB. > 0x4 5baseCR2 Full > 0x8 5baseKR2 Full > 0x100

[PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Heiner Kallweit
With the switch to phy_resolve_aneg_linkmode() we don't read from the chip any longer what is advertised but use phydev->advertising directly. For a fixed phy however this bitmap is empty so far, what results in no common mode being found. This breaks DSA. Fix this by advertising everything that is

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Andrew Lunn
> The added difficulty here and the reason why Andrew went with the > approach that is used by the code currently is because neither do the > CPU or DSA ports are backed by a net_device. It is somewhere on my TODO > to permit the use of PHYLINK without the need of a net_device to cover > those spec

Re: [PATCH iproute2-next v2 00/19] Export object IDs to users

2019-02-24 Thread Leon Romanovsky
On Sun, Feb 24, 2019 at 10:16:37AM -0500, David Ahern wrote: > On 2/23/19 4:15 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Changelog: > > v1->v2: > > * Fixed commit messages > > * Added Steve's ROB > > v0->v1: > > * Rebased to latest iproute2-next > > * Added latest rdma_netli

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 03:31:26PM +, Russell King - ARM Linux admin wrote: > On Sun, Feb 24, 2019 at 12:42:35AM +0100, Andrew Lunn wrote: > > Looking forward, at some point we are going to have to make fixed-link > > support higher speeds. That probably means we need a swphy-c45 which > > emul

Re: [PATCH net-next] net: phy: improve auto-neg emulation in swphy

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 05:41:47PM +0100, Heiner Kallweit wrote: > Auto-neg emulation currently doesn't set bit BMCR_ANENABLE in BMCR, > add this. Users will ignore speed and duplex settings in BMCR because > we're emulating auto-neg, therefore we can remove related code. > See also following discu

Re: [PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 06:01:18PM +0100, Heiner Kallweit wrote: > With the switch to phy_resolve_aneg_linkmode() we don't read from the > chip any longer what is advertised but use phydev->advertising directly. > For a fixed phy however this bitmap is empty so far, what results in > no common mode

Re: [PATCH v2 bpf-next 2/9] bpf: Add bpf helper bpf_tcp_enter_cwr

2019-02-24 Thread Eric Dumazet
On 02/23/2019 07:08 PM, Martin Lau wrote: > On Sat, Feb 23, 2019 at 05:32:14PM -0800, Eric Dumazet wrote: >> >> >> On 02/22/2019 05:06 PM, brakmo wrote: >>> From: Martin KaFai Lau >>> >>> This patch adds a new bpf helper BPF_FUNC_tcp_enter_cwr >>> "int bpf_tcp_enter_cwr(struct bpf_tcp_sock *tp)

Re: [PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 18:57, Andrew Lunn wrote: > On Sun, Feb 24, 2019 at 06:01:18PM +0100, Heiner Kallweit wrote: >> With the switch to phy_resolve_aneg_linkmode() we don't read from the >> chip any longer what is advertised but use phydev->advertising directly. >> For a fixed phy however this bitmap is e

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Michal Kubecek
On Sun, Feb 24, 2019 at 05:08:21PM +0200, Tariq Toukan wrote: > From: Aya Levin > > Introduce 50Gbps per lane link modes and 200Gbps speed, update print > functions and initialization functions accordingly. > In addition, update related man page accordingly. > > Signed-off-by: Aya Levin > Signe

Re: [GIT] Networking

2019-02-24 Thread pr-tracker-bot
The pull request you sent on Sat, 23 Feb 2019 18:57:10 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c4eb1e1852df60d61e04a6b580a0490460c9e31b Thank you! -- Deet-doot-dot, I

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Michal Kubecek
On Sun, Feb 24, 2019 at 05:47:51PM +0100, Andrew Lunn wrote: > On Sun, Feb 24, 2019 at 05:08:21PM +0200, Tariq Toukan wrote: > > From: Aya Levin > > index 5a26cff5fb33..64ce0711ad5f 100644 > > --- a/ethtool.8.in > > +++ b/ethtool.8.in > > @@ -650,6 +650,11 @@ lB l lB. > > 0x4

Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section

2019-02-24 Thread David Miller
From: Florian Fainelli Date: Sun, 24 Feb 2019 08:46:59 -0800 > Looks like you applied this to the "net" tree, and I missed prefixing > the patch to indicate this was targeted at the "net-next" tree. Are you > planning a merge from "net" to "net-next" anytime soon? Yes, I am working on that right

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-24 Thread Andy Lutomirski
On Sat, Feb 23, 2019 at 12:30 AM Nadav Amit wrote: > > > On Feb 22, 2019, at 3:59 PM, Andy Lutomirski wrote: > > > > On Fri, Feb 22, 2019 at 3:02 PM Jann Horn wrote: > >> On Fri, Feb 22, 2019 at 11:39 PM Nadav Amit wrote: > On Feb 22, 2019, at 2:21 PM, Nadav Amit wrote: > > > On

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Andrew Lunn
> > This is getting less friendly all the time, and it was never very > > friendly to start with. We have the strings which represent these link > > modes in the table used for dumping caps. How about allowing the user > > to list a comma separate list of modes. > > > > ethtool -s lan42 advertise

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Russell King - ARM Linux admin
On Sun, Feb 24, 2019 at 06:28:48PM +0100, Andrew Lunn wrote: > On Sun, Feb 24, 2019 at 03:31:26PM +, Russell King - ARM Linux admin > wrote: > > On Sun, Feb 24, 2019 at 12:42:35AM +0100, Andrew Lunn wrote: > > > Looking forward, at some point we are going to have to make fixed-link > > > suppo

[PATCH net-next] dsa: Remove phydev parameter from disable_port call

2019-02-24 Thread Andrew Lunn
No current DSA driver makes use of the phydev parameter passed to the disable_port call. Remove it. Signed-off-by: Andrew Lunn --- drivers/net/dsa/b53/b53_common.c | 4 ++-- drivers/net/dsa/b53/b53_priv.h | 2 +- drivers/net/dsa/bcm_sf2.c | 9 - drivers/net/dsa

Re: stmmac / meson8b-dwmac

2019-02-24 Thread Sebastian Gottschall
** **its clearly visible when i activated the other stream for getting duplex load ... The highest rate also stays alot under the possible 930MBits that i have seen earlier with 4.14. ** ** ** **the parallel stream reached around 450Mbits , which almost sums up to 660Mbits. This is what i me

[PATCH net-next 0/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
This series adds HWMON support for the temperature sensor and the related alarms on the 107/108/109 chips. Heiner Kallweit (2): net: phy: aquantia: rename aquantia.c to aquantia_main.c net: phy: aquantia: add hwmon support drivers/net/phy/Makefile | 1 + drivers/net/ph

[PATCH net-next 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
This adds HWMON support for the temperature sensor and the related alarms on the 107/108/109 chips. This patch is based on work from Nikita and Andrew. I added: - support for changing alarm thresholds via sysfs - move HWMON code to a separate source file to improve maintainability - smaller changes

[PATCH net-next 1/2] net: phy: aquantia: rename aquantia.c to aquantia_main.c

2019-02-24 Thread Heiner Kallweit
Rename aquantia.c to aquantia_main.c to be prepared for adding new functionality to separate source code files. Signed-off-by: Heiner Kallweit --- drivers/net/phy/Makefile| 1 + drivers/net/phy/{aquantia.c => aquantia_main.c} | 0 2 files changed, 1 insertion(+) rename d

Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section

2019-02-24 Thread David Miller
From: David Miller Date: Sun, 24 Feb 2019 11:26:30 -0800 (PST) > From: Florian Fainelli > Date: Sun, 24 Feb 2019 08:46:59 -0800 > >> Looks like you applied this to the "net" tree, and I missed prefixing >> the patch to indicate this was targeted at the "net-next" tree. Are you >> planning a mer

marvell10g.c merge into net-next

2019-02-24 Thread David Miller
Heiner, please look at net-next which I just merged net into. Net had a bug fix wherein the MDIO_AN_10GBT_CTRL_ADV_NBT_MASK bits are cleared in the 10gbt control register to work around a problem with some marvell10g phy chips. In the merge I preserved your usage of the generic c45 helpers in t

Re: [PATCH net-next 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Andrew Lunn
> diff --git a/drivers/net/phy/aquantia_hwmon.c > b/drivers/net/phy/aquantia_hwmon.c > new file mode 100644 > index 0..c0dd695f6 > --- /dev/null > +++ b/drivers/net/phy/aquantia_hwmon.c > @@ -0,0 +1,263 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* HWMON driver for Aquantia PHY > + * > +

Re: [PATCH 5/5] net: dsa: fix a leaked reference by adding missing of_node_put

2019-02-24 Thread David Miller
From: Wen Yang Date: Fri, 22 Feb 2019 15:15:42 +0800 > diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c > index 8c431e0..89823f0 100644 > --- a/net/dsa/dsa2.c > +++ b/net/dsa/dsa2.c > @@ -613,7 +613,7 @@ static int dsa_switch_parse_ports_of(struct dsa_switch > *ds, > struct device_node *ports,

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Michal Kubecek
On Sun, Feb 24, 2019 at 08:40:15PM +0100, Andrew Lunn wrote: > > > This is getting less friendly all the time, and it was never very > > > friendly to start with. We have the strings which represent these link > > > modes in the table used for dumping caps. How about allowing the user > > > to list

Re: stmmac / meson8b-dwmac

2019-02-24 Thread Simon Huelck
Am 24.02.2019 um 20:42 schrieb Sebastian Gottschall: > vice are you talking about? its not your windows pc. if its a ipq8064 > based device or something like that you should look > on a very different location. this platform like the r7800 has stmac > performance problems since the kernel clk code

Re: [PATCH net-next] net: phy: let genphy_c45_read_abilities also check aneg capability

2019-02-24 Thread David Miller
From: Heiner Kallweit Date: Fri, 22 Feb 2019 08:23:04 +0100 > When using genphy_c45_read_abilities() as get_features callback we > also have to set the autoneg capability in phydev->supported. > > Signed-off-by: Heiner Kallweit Applied, thanks.

Re: marvell10g.c merge into net-next

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 21:15, David Miller wrote: > > Heiner, please look at net-next which I just merged net into. > > Net had a bug fix wherein the MDIO_AN_10GBT_CTRL_ADV_NBT_MASK > bits are cleared in the 10gbt control register to work around > a problem with some marvell10g phy chips. > > In the merg

Re: [PATCH][net-next] net: Use RCU_INIT_POINTER() to set sk_wq

2019-02-24 Thread David Miller
From: Li RongQing Date: Fri, 22 Feb 2019 17:08:22 +0800 > This pointer is RCU protected, so proper primitives should be used. > > Signed-off-by: Zhang Yu > Signed-off-by: Li RongQing Applied.

Re: [PATCH net-next v2 2/2] doc: add phylink documentation to the networking book

2019-02-24 Thread David Miller
From: Russell King Date: Fri, 22 Feb 2019 11:31:46 + > Add some phylink documentation to the networking book detailing how > to convert network drivers from phylib to phylink. > > Signed-off-by: Russell King > --- > v2: updated with comments from Randy and updated to apply to net-next Appl

Re: [PATCH net-next v2 1/2] net: phylink: update mac_config() documentation

2019-02-24 Thread David Miller
From: Russell King Date: Fri, 22 Feb 2019 11:31:41 + > A detail for mac_config() had been missed in the documentation for the > method - it is expected that the method will update the MAC to the > settings, rather than completely reprogram the MAC on each call. > Update the documentation for

Re: [PATCH net-next] net: Skip GSO length estimation if transport header is not set

2019-02-24 Thread David Miller
From: Maxim Mikityanskiy Date: Fri, 22 Feb 2019 12:55:22 + > qdisc_pkt_len_init expects transport_header to be set for GSO packets. > Patch [1] skips transport_header validation for GSO packets that don't > have network_header set at the moment of calling virtio_net_hdr_to_skb, > and allows t

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Andrew Lunn
> > Hi Michal > > > > So are you doing a read/modify/write? In that case, off/on makes > > sense. For a pure write, i don't see the need for off/on. > > When using netlink interface, the read/modify/write cycle is limited to > kernel code and is done under rtnl_lock. The netlink interface allows

Re: [PATCH net-next 0/8] Add tests for unlocked flower classifier implementation

2019-02-24 Thread David Miller
From: Vlad Buslov Date: Fri, 22 Feb 2019 16:00:39 +0200 > Implement tests for tdc testsuite to verify concurrent rules update with > rtnl-unlocked flower classifier implementation. The goal of these tests > is to verify general flower classifier correctness by updating filters > on same classifie

32-bit Amlogic SoCs: avoid using Ethernet MAC addresses

2019-02-24 Thread Martin Blumenstingl
I have seen Anand's your question in [0]: > only issue is I have is the each time their is random MAC address so I > get new IP from dhcp server. > How can I avoid this. I have tried to enable eFuse driver but with no success. u-boot on the 64-bit SoCs can read the MAC address from the eFuse and p

Re: marvell10g.c merge into net-next

2019-02-24 Thread Maxime Chevallier
Hello Dave, Heiner, On Sun, 24 Feb 2019 21:35:11 +0100 Heiner Kallweit wrote: >On 24.02.2019 21:15, David Miller wrote: >> >> Heiner, please look at net-next which I just merged net into. >> >> Net had a bug fix wherein the MDIO_AN_10GBT_CTRL_ADV_NBT_MASK >> bits are cleared in the 10gbt contr

Re: [PATCH net-next 0/3] net: protodown support for macvlan and vxlan

2019-02-24 Thread David Miller
From: Andy Roulin Date: Fri, 22 Feb 2019 18:06:35 + > This patch series adds dev_change_proto_down_generic, a generic > implementation of ndo_change_proto_down, which sets the netdev carrier > state according to the new proto_down value. > > This handler adds the ability to set protodown on

Re: [PATCH net-next 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 21:29, Andrew Lunn wrote: >> diff --git a/drivers/net/phy/aquantia_hwmon.c >> b/drivers/net/phy/aquantia_hwmon.c >> new file mode 100644 >> index 0..c0dd695f6 >> --- /dev/null >> +++ b/drivers/net/phy/aquantia_hwmon.c >> @@ -0,0 +1,263 @@ >> +// SPDX-License-Identifier: GPL-2

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Florian Fainelli
On February 24, 2019 9:04:55 AM PST, Andrew Lunn wrote: >> The added difficulty here and the reason why Andrew went with the >> approach that is used by the code currently is because neither do the >> CPU or DSA ports are backed by a net_device. It is somewhere on my >TODO >> to permit the use

[PATCH net-next v2 0/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
This series adds HWMON support for the temperature sensor and the related alarms on the 107/108/109 chips. v2: - remove struct aqr_priv - rename header file to aquantia.h Heiner Kallweit (2): net: phy: aquantia: rename aquantia.c to aquantia_main.c net: phy: aquantia: add hwmon support driv

  1   2   >