[PATCHv2 net-next] tls: Return type of non-data records retrieved using MSG_PEEK in recvmsg

2019-02-23 Thread Vakul Garg
The patch enables returning 'type' in msghdr for records that are retrieved with MSG_PEEK in recvmsg. Further it prevents records peeked from socket from getting clubbed with any other record of different type when records are subsequently dequeued from strparser. For each record, we now retain it

[PATCHv3 net-next] tls: Return type of non-data records retrieved using MSG_PEEK in recvmsg

2019-02-23 Thread Vakul Garg
The patch enables returning 'type' in msghdr for records that are retrieved with MSG_PEEK in recvmsg. Further it prevents records peeked from socket from getting clubbed with any other record of different type when records are subsequently dequeued from strparser. For each record, we now retain it

RE: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

2019-02-23 Thread Ioana Ciornei
> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check > > port_switchdev_event() does not check that the target network device is > actually backed by the ethsw driver, this could be problematic in a stacked > environment case. > Just FYI, I sent a patch set containing

[PATCH 1/3] soc: fsl: dpio: enable frame data cache stashing per software portal

2019-02-23 Thread Ioana Ciornei
Enable cache stashing on the frame data dequeued using this software portal. Also, enable dropping a stash request transaction when the target request queue is almost full. Signed-off-by: Ioana Ciornei --- drivers/soc/fsl/dpio/qbman-portal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 2/3] soc: fsl: dpio: configure cache stashing destination

2019-02-23 Thread Ioana Ciornei
Depending on the SoC version and the CPU id, configure the cache stashing destination for a specific dpio. Signed-off-by: Ioana Ciornei --- drivers/soc/fsl/Kconfig| 1 + drivers/soc/fsl/dpio/dpio-cmd.h| 5 drivers/soc/fsl/dpio/dpio-driver.c | 52 +++

[PATCH 0/3] soc: fsl: dpio: enable and configure cache stashing

2019-02-23 Thread Ioana Ciornei
The first two patches enable cache stashing and configure the core cluster destination per software portal while the third patch is the one configuring the amount of stashing on a queue. Ioana Ciornei (3): soc: fsl: dpio: enable frame data cache stashing per software portal soc: fsl: dpio: con

[PATCH 3/3] dpaa2-eth: configure the cache stashing amount on a queue

2019-02-23 Thread Ioana Ciornei
Configure the amount of 64 bytes of frame, annotation and context data that will be cache stashed for a specific frame queue. Since the frame context is not used, configure that only 64 bytes of frame data and 64 bytes of annotation will be stashed. Signed-off-by: Ioana Ciornei --- drivers/net/

Re: [PATCH] net: phy: realtek: Dummy IRQ calls for RTL8366RB

2019-02-23 Thread Heiner Kallweit
On 23.02.2019 03:36, Linus Walleij wrote: > This fixes a regression introduced by > commit 0d2e778e38e0ddffab4bb2b0e9ed2ad5165c4bf7 > "net: phy: replace PHY_HAS_INTERRUPT with a check for > config_intr and ack_interrupt". > > This assumes that a PHY cannot trigger interrupt unless > it has .config

Re: [PATCH iproute2-next v1 04/19] rdma: Provide parent context index for all objects except CM_ID

2019-02-23 Thread Leon Romanovsky
On Thu, Feb 21, 2019 at 02:12:19PM -0600, Steve Wise wrote: > > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Leon Romanovsky > > Sent: Wednesday, February 20, 2019 1:21 AM > > To: David Ahern > > Cc: Leon Romanovsky ; netdev > > ;

Re: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file

2019-02-23 Thread Leon Romanovsky
On Thu, Feb 21, 2019 at 02:15:16PM -0600, Steve Wise wrote: > > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Leon Romanovsky > > Sent: Wednesday, February 20, 2019 1:21 AM > > To: David Ahern > > Cc: Leon Romanovsky ; netdev > > ;

Re: [PATCH net-next] route: Add a new fib_multipath_hash_policy base on cpu id for tunnel packet

2019-02-23 Thread Ido Schimmel
On Fri, Feb 22, 2019 at 10:19:41PM -0500, David Ahern wrote: > On 2/21/19 10:52 PM, we...@ucloud.cn wrote: > > From: wenxu > > > > Current fib_multipath_hash_policy can make hash based on the L3 or > > L4. But it only work on the outer IP. So a specific tunnel always > > has the same hash value.

[PATCH iproute2-next v2 01/19] rdma: update uapi headers

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Update rdma_netlink.h file upto kernel commit f2a0e45f36b0 RDMA/nldev: Don't expose number of not-visible entries Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/include/uapi/rdma/rdma_netlink.h | 64 +-- 1 file changed, 50 inserti

[PATCH iproute2-next v2 05/19] rdma: Move resource PD logic to separate file

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource PD logic to separate file, in order to make PD specific logic self-contained. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/res-pd.c | 110 rdma/res.c| 154 +++-

[PATCH iproute2-next v2 00/19] Export object IDs to users

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1->v2: * Fixed commit messages * Added Steve's ROB v0->v1: * Rebased to latest iproute2-next * Added latest rdma_netlink.h and updated commit message to point to kernel SHA commit. This series adds ability to present and query all known to rdmatool object

[PATCH iproute2-next v2 09/19] rdma: Move resource QP logic to separate file

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource QP logic to separate file, in order to make PD specific logic self-contained. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/res-qp.c | 234 + rdma/res.c

[PATCH iproute2-next v2 03/19] rdma: Provide unique indexes for all visible objects

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res.c | 83 +- 1 file changed, 63 insertions(+), 20 deletions(-) diff --git a/rdma/res.c b/rdma/res.c index 87865ec8..f941de5c 100644 --- a/rdma/res.c +++

[PATCH iproute2-next v2 04/19] rdma: Provide parent context index for all objects except CM_ID

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Allow users to correlate allocated object with relevant parent [leonro@server ~]$ rdma res show pd dev mlx5_0 users 5 pid 0 comm [ib_core] pdn 1 dev mlx5_0 users 7 pid 0 comm [ib_ipoib] pdn 2 dev mlx5_0 users 0 pid 0 comm [mlx5_ib] pdn 3 dev mlx5_0 users 2 pid 548 comm ibv_

[PATCH iproute2-next v2 06/19] rdma: Refactor out resource MR logic to separate file

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource MR logic to separate file, in order to make MR specific logic self-contained. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/res-mr.c | 117 +++ rdma/res.c

[PATCH iproute2-next v2 02/19] rdma: Remove duplicated print code

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky There is no need to keep same print functions for uint32_t and uint64_t, unify them into one function. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/rdma/r

[PATCH iproute2-next v2 12/19] rdma: Simplify CM_ID print code

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Refactor our the CM_ID print code. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res-cmid.c | 246 1 file changed, 124 insertions(+), 122 deletions(-) diff --git a/rdma/res-cmid.c b/rdma/res-cmid.c index

[PATCH iproute2-next v2 07/19] rdma: Move out resource CQ logic to separate file

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource CQ logic to separate file, in order to make CQ specific logic self-contained. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/res-cq.c | 143 rdma/res.c

[PATCH iproute2-next v2 10/19] rdma: Properly mark RDMAtool license

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky RDMA subsystem is dual-licensed with "GPL-2.0 OR Linux-OpenIB" proper license and Mellanox submission are supposed to have this type of license. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/dev.c| 7 +-- rdma/link.c | 7

[PATCH iproute2-next v2 11/19] rdma: Simplify code to reuse existing functions

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Remove duplicated functions in favour general res_print_uint() call. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res-cmid.c | 4 ++-- rdma/res-cq.c | 14 +++--- rdma/res-mr.c | 2 +- rdma/res-pd.c | 4 ++-- rdma/res-qp.c | 14 +++---

[PATCH iproute2-next v2 08/19] rdma: Move out resource CM-ID logic to separate file

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource CM-ID logic to separate file, in order to make CM-ID specific logic self-contained. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/Makefile | 3 +- rdma/res-cmid.c | 252 rdma/r

[PATCH iproute2-next v2 19/19] rdma: Provide and reuse filter functions

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Globally replace all filter function in safer variants of those is_filtered functions, which take into account the availability/lack of netlink attributes. Such conversion allowed to fix a number of places in the code, where the previous implementation didn't honor filter r

[PATCH iproute2-next v2 13/19] rdma: Refactor CQ prints

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res-cq.c | 177 ++ 1 file changed, 91 insertions(+), 86 deletions(-) diff --git a/rdma/res-cq.c b/rdma/res-cq.c index 93c18251..e50d76ce 100644 --- a/rdma/res-

[PATCH iproute2-next v2 15/19] rdma: Place PD parsing print routine into separate function

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res-pd.c | 170 ++ 1 file changed, 89 insertions(+), 81 deletions(-) diff --git a/rdma/res-pd.c b/rdma/res-pd.c index 24ac7f1b..3c9ffa4e 100644 --- a/rdma/res-

[PATCH iproute2-next v2 18/19] rdma: Perform single .doit call to query specific objects

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky If user provides specific index, we can speedup query by using .doit callback and save full dump and filtering after that. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/rdma.h | 10 +- rdma/res-cmid.c | 33 +-- rdma/res-cq.c |

[PATCH iproute2-next v2 14/19] rdma: Move MR code to be suitable for per-line parsing

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res-mr.c | 178 +- 1 file changed, 90 insertions(+), 88 deletions(-) diff --git a/rdma/res-mr.c b/rdma/res-mr.c index e373035a..36993b5e 100644 --- a/rdma/res-

[PATCH iproute2-next v2 16/19] rdma: Move QP code to separate function

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res-qp.c | 253 +- 1 file changed, 127 insertions(+), 126 deletions(-) diff --git a/rdma/res-qp.c b/rdma/res-qp.c index ecd2cbd6..e74c8b01 100644 --- a/rdma/re

[PATCH iproute2-next v2 17/19] rdma: Unify netlink attribute checks prior to prints

2019-02-23 Thread Leon Romanovsky
From: Leon Romanovsky Place check if netlink attribute available in general place, instead of doing the same check in many paces. Reviewed-by: Steve Wise Signed-off-by: Leon Romanovsky --- rdma/res-cmid.c | 9 - rdma/res-cq.c | 22 +++--- rdma/res-mr.c | 21 ++

[Patch net-next 02/12] net: hns3: avoid mult + div op in critical data path

2019-02-23 Thread Huazhong Tan
From: Yunsheng Lin This patch uses shift offset to avoid doing mult and div operation. Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 15 --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 3 +++ 2 files changed, 1

[Patch net-next 07/12] net: hns3: remove hnae3_get_bit in data path

2019-02-23 Thread Huazhong Tan
From: Yunsheng Lin The hnae3_get_bit uses hnae3_get_field, and hnae3_get_field masks the data, which is unnecessary in data path. Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 33 +++-- 1 file changed, 14 inse

[Patch net-next 04/12] net: hns3: remove some ops in struct hns3_nic_ops

2019-02-23 Thread Huazhong Tan
From: Yunsheng Lin The fill_desc ops has only one implementation, and get_rxd_bnum has not been used, so this patch removes them. Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 11 +-- drivers/net/ethernet/hisilicon/hns3/h

[Patch net-next 06/12] net: hns3: replace hnae3_set_bit and hnae3_set_field in data path

2019-02-23 Thread Huazhong Tan
From: Yunsheng Lin hnae3_set_bit and hnae3_set_field masks the data before setting the field or bit, which is unnecessary because the data is already zero initialized. Suggested-by: John Garry Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns

[Patch net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-02-23 Thread Huazhong Tan
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver. Huazhong Tan (1): net: hns3: fix improper error handling for hns3_client_start Jian Shen (2): net: hns3: enable VF VLAN filter for each VF when initializing net: hns3: fix get VF RSS issue Peng

[Patch net-next 11/12] net: hns3: fix setting of the hns reset_type for rdma hw errors

2019-02-23 Thread Huazhong Tan
From: Shiju Jose Presently the hns reset_type for the roce errors is set in the hclge_log_and_clear_rocee_ras_error function. This function is also called to detect and clear roce errors while enabling the rdma error interrupts. However there is no hns reset requested for this case. This can caus

[Patch net-next 05/12] net: hns3: add unlikely for error handling in data path

2019-02-23 Thread Huazhong Tan
From: Yunsheng Lin This patch adds unlikely hint for error handling in critical data path. Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers

[Patch net-next 01/12] net: hns3: add xps setting support for hns3 driver

2019-02-23 Thread Huazhong Tan
From: Yunsheng Lin This patch adds xps setting support for hns3 driver based on the interrupt affinity info. Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 24 1 file changed, 24 insertions(+) diff --git

[Patch net-next 10/12] net: hns3: fix get VF RSS issue

2019-02-23 Thread Huazhong Tan
From: Jian Shen For revision 0x20, VF shares the same RSS config with PF. In original codes, it always return 0 when query RSS hash key for VF. This patch fixes it by return the hash key got from PF. Fixes: 374ad291762a ("net: hns3: net: hns3: Add RSS general configuration support for VF") Sign

[Patch net-next 03/12] net: hns3: limit some variable scope in critical data path

2019-02-23 Thread Huazhong Tan
From: Yunsheng Lin This patch limits some variables' scope as much as possible in hns3_fill_desc. Also, only set l3_type and l4_type when necessary. Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 35 +++-- 1 f

[Patch net-next 08/12] net: hns3: add support to config depth for tx|rx ring separately

2019-02-23 Thread Huazhong Tan
From: Peng Li This patch adds support to config depth for tx|rx ring separately by ethtool command "-G". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 1 + drivers/net/ethernet/hisilicon/hns3/hnae3.h| 10 ++-- drivers/net/

[Patch net-next 12/12] net: hns3: fix improper error handling for hns3_client_start

2019-02-23 Thread Huazhong Tan
If hns3_client_start() failed in the hns3_client_init(), register_dev() should be undo in its error handling. Fixes: a6d818e31d08 ("net: hns3: Add vport alive state checking support") Signed-off-by: Huazhong Tan Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 +++-

[Patch net-next 09/12] net: hns3: enable VF VLAN filter for each VF when initializing

2019-02-23 Thread Huazhong Tan
From: Jian Shen For revision 0x21, the switch of VF VLAN filter is per function. It's necessary to enable VF VLAN filter for each VF when initializing. Otherwise, VF will be able to receive broadcast packets with unknown VLAN when PF enters promisc mode. Fixes: 64d114f0a750 ("net: hns3: Add egre

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-23 Thread Leon Romanovsky
On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > This function sends the constructed netlink message and then > receives the response, displaying any error text. > > Change 'rdma dev set' to use it. > > Signed-off-by: Steve Wise > --- > rdma/dev.c | 2 +- > rdma/rdma.h | 1 + >

Re: [PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h

2019-02-23 Thread Leon Romanovsky
On Thu, Feb 21, 2019 at 08:19:07AM -0800, Steve Wise wrote: > Pull in the latest rdma_netlink.h to get the RDMA_NLDEV_CMD_NEWLINK / > RDMA_NLDEV_CMD_DELLINK API. > > Signed-off-by: Steve Wise > --- > rdma/include/uapi/rdma/rdma_netlink.h | 74 > +++ > 1 file chang

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-23 Thread Leon Romanovsky
On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > > This function sends the constructed netlink message and then > > receives the response, displaying any error text. > > > > Change 'rdma dev set' to use it. > > > > Sign

Re: [PATCH v1 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-02-23 Thread Leon Romanovsky
On Thu, Feb 21, 2019 at 08:19:12AM -0800, Steve Wise wrote: > Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma > device to a netdev interface. > > EG: > > rdma link add rxe_eth0 type rxe netdev eth0 > rdma link delete rxe_eth0 > > Signed-off-by: Steve Wise > --- > rdma/li

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-23 Thread Ido Schimmel
On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: > Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field > from all clients, which were migrated to use switchdev notification in > the previous patches. > > Add a new function switchdev_port_attr_notify() that send

Re: [PATCH net-next 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET

2019-02-23 Thread Ido Schimmel
On Fri, Feb 22, 2019 at 03:59:19PM -0800, Florian Fainelli wrote: > In preparation for allowing switchdev enabled drivers to veto specific > attribute settings from within the context of the caller, introduce a > new switchdev notifier type for port attributes. > > Suggested-by: Ido Schimmel > Si

Re: [PATCH net-next 4/8] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-23 Thread Ido Schimmel
On Fri, Feb 22, 2019 at 03:59:22PM -0800, Florian Fainelli wrote: > Following patches will change the way we communicate setting a port's > attribute and use a notifier to perform those tasks. > > Prepare mlxsw to support receiving notifier events targeting > SWITCHDEV_PORT_ATTR_SET and utilize th

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-23 Thread Jesper Dangaard Brouer
On Fri, 22 Feb 2019 13:37:34 -0800 Jakub Kicinski wrote: > On Fri, 22 Feb 2019 11:13:50 +0100, Toke Høiland-Jørgensen wrote: > > Jakub Kicinski writes: > > > On Thu, 21 Feb 2019 12:56:54 +0100, Toke Høiland-Jørgensen wrote: [...] > > > > > > BPF programs don't obey by netns boundaries.

[PATCH] net: ax25: Add SPDX License to fix missing License warning

2019-02-23 Thread Jules Irenge
Signed-off-by: Jules Irenge --- net/ax25/af_ax25.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 5d01edf8d819..5048790a75f6 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Thi

[PATCH] net: ax25: Fix multiple blank lines warning

2019-02-23 Thread Jules Irenge
Signed-off-by: Jules Irenge --- net/ax25/af_ax25.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 5048790a75f6..2da349b7854a 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -49,8 +49,6 @@ #include #include - - HLIST_HEAD(ax25_

Re: [PATCH net-next 2/2] xdp: Add devmap_idx map type for looking up devices by ifindex

2019-02-23 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Fri, 22 Feb 2019 10:47:10 +0100, Toke Høiland-Jørgensen wrote: >> Jakub Kicinski writes: >> >> > On Fri, 22 Feb 2019 00:02:23 +0100, Toke Høiland-Jørgensen wrote: >> >> Jakub Kicinski writes: >> >> >> >> > On Thu, 21 Feb 2019 12:56:54 +0100, Toke Høiland-Jørgen

[PATCH] tun: fix blocking read

2019-02-23 Thread Timur Celik
This patch moves setting of the current state into the loop. Otherwise the task may end up in a busy wait loop if none of the break conditions are met. Signed-off-by: Timur Celik --- drivers/net/tun.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/tun.c b/dri

Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-02-23 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Fri, 22 Feb 2019 13:37:34 -0800 Jakub Kicinski > wrote: > >> On Fri, 22 Feb 2019 11:13:50 +0100, Toke Høiland-Jørgensen wrote: >> > Jakub Kicinski writes: >> > > On Thu, 21 Feb 2019 12:56:54 +0100, Toke Høiland-Jørgensen wrote: > [...] >> > > >> > > BP

Re: [PATCH] net: ax25: Add SPDX License to fix missing License warning

2019-02-23 Thread Greg KH
On Sat, Feb 23, 2019 at 11:11:00AM +, Jules Irenge wrote: > Signed-off-by: Jules Irenge I know I never take patches without any changelog text :( > --- > net/ax25/af_ax25.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c > index 5d01edf8d81

Re: [Outreachy kernel] [PATCH] net: ax25: Fix multiple blank lines warning

2019-02-23 Thread Greg KH
On Sat, Feb 23, 2019 at 11:17:51AM +, Jules Irenge wrote: > Signed-off-by: Jules Irenge > --- > net/ax25/af_ax25.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c > index 5048790a75f6..2da349b7854a 100644 > --- a/net/ax25/af_ax25.c > +++ b/ne

Re: [Outreachy kernel] [PATCH] net: ax25: Fix multiple blank lines warning

2019-02-23 Thread Ivan Ivanov
as usual, Outreachy is doing stiuupid almost-useless commits like remove two blank lines or fix a tiny typo. They are trying hard to pretend that they are useful by doing many lame patches like this, while promoting their SJW madness, anti-male sieexism and anti-white riaacism. But with the lame st

Re: [Outreachy kernel] [PATCH] net: ax25: Fix multiple blank lines warning

2019-02-23 Thread Julia Lawall
On Sat, 23 Feb 2019, Jules Irenge wrote: You need a commit message here. > Signed-off-by: Jules Irenge > --- > net/ax25/af_ax25.c | 2 -- This is the same file as in your previous patch, so they should be in a series. But please work on files in drivers/staging instead. julia > 1 file chang

[PATCH net-next v4] ip_tunnel: Add dst_cache support in lwtunnel_state of ip tunnel

2019-02-23 Thread wenxu
From: wenxu The lwtunnel_state is not init the dst_cache Which make the ip_md_tunnel_xmit can't use the dst_cache. It will lookup route table every packets. Signed-off-by: wenxu --- net/core/lwtunnel.c | 16 net/ipv4/ip_tunnel_core.c | 18 ++ 2 files chan

[PATCH net-next v3] route: Add multipath_hash in flowi_common to make user-define hash

2019-02-23 Thread wenxu
From: wenxu Current fib_multipath_hash_policy can make hash based on the L3 or L4. But it only work on the outer IP. So a specific tunnel always has the same hash value. But a specific tunnel may contain so many inner connections. This patch provide a generic multipath_hash in floi_common. It ca

Re: [PATCH] net: phy: realtek: Dummy IRQ calls for RTL8366RB

2019-02-23 Thread Andrew Lunn
On Sat, Feb 23, 2019 at 03:36:39AM +0100, Linus Walleij wrote: > This fixes a regression introduced by > commit 0d2e778e38e0ddffab4bb2b0e9ed2ad5165c4bf7 > "net: phy: replace PHY_HAS_INTERRUPT with a check for > config_intr and ack_interrupt". > > This assumes that a PHY cannot trigger interrupt un

Re: [PATCH 2/3] net: ethernet: add c45 PHY support in MDIO read/write functions.

2019-02-23 Thread Andrew Lunn
> >On Fri, Feb 22, 2019 at 08:12:42PM +, Parshuram Thombare wrote: > >> This patch modify MDIO read/write functions to support communication > >> with C45 PHY in Cadence ethernet controller driver. > > > >Hi Parshuram > > > >Are all versions of the MDIO controller capable of doing C45? > > > >

Re: [PATCH 2/3] net: ethernet: add c45 PHY support in MDIO read/write functions.

2019-02-23 Thread Andrew Lunn
On Fri, Feb 22, 2019 at 08:12:42PM +, Parshuram Thombare wrote: > This patch modify MDIO read/write functions to support > communication with C45 PHY in Cadence ethernet controller driver. > > Signed-off-by: Parshuram Thombare > --- > drivers/net/ethernet/cadence/macb.h | 15 +-- >

Re: [PATCH net-next v2 2/7] net: phy: marvell10g: Use linkmode_set_bit helper instead of __set_bit

2019-02-23 Thread Andrew Lunn
On Sat, Feb 23, 2019 at 12:37:39AM +0100, Maxime Chevallier wrote: > Cosmetic patch making use of helpers dedicated to linkmodes handling. > > Signed-off-by: Maxime Chevallier Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 1/7] net: phy: marvell10g: Use get_features to get the PHY abilities

2019-02-23 Thread Andrew Lunn
On Sat, Feb 23, 2019 at 12:37:38AM +0100, Maxime Chevallier wrote: > The Alaska family of 10G PHYs has more abilities than the ones listed in > PHY_10GBIT_FULL_FEATURES, the exact list depending on the model. > > Make use of the newly introduced .get_features call to build this list, > using genph

Re: [PATCH net-next v2 3/7] net: phy: marvell10g: Use 2500BASEX when using 2.5GBASET

2019-02-23 Thread Andrew Lunn
On Sat, Feb 23, 2019 at 12:37:40AM +0100, Maxime Chevallier wrote: > The Marvell Alaska family of PHYs supports 2.5GBaseT and 5GBaseT modes, > as defined in the 802.3bz specification. > > Upon establishing a 2.5GBASET link, the PHY will reconfigure it's MII > interface to 2500BASEX. > > At 5G, th

Re: [PATCH net-next v2 4/7] net: phy: marvell10g: Use a #define for 88X3310 family id

2019-02-23 Thread Andrew Lunn
On Sat, Feb 23, 2019 at 12:37:41AM +0100, Maxime Chevallier wrote: > The PHY ID corresponding to the 88X3310 is also used for other PHYs in > the same family, such as the 88E2010. Use a #define for the PHY id, that > ignores the last nibble. > > Signed-off-by: Maxime Chevallier Reviewed-by: Andr

Re: [PATCH net-next v2 5/7] net: phy: marvell10g: Force reading of 2.5/5G

2019-02-23 Thread Andrew Lunn
On Sat, Feb 23, 2019 at 12:37:42AM +0100, Maxime Chevallier wrote: > As per 802.3bz, if bit 14 of (1.11) "PMA Extended Abilities" indicates > whether or not we should read register (1.21) "2.52/5G PMA Extended > Abilities", which contains information on the support of 2.5GBASET and > 5GBASET. > >

Re: [PATCH net-next v2 7/7] net: phy: marvell10g: add support for the 88x2110 PHY

2019-02-23 Thread Andrew Lunn
On Sat, Feb 23, 2019 at 12:37:44AM +0100, Maxime Chevallier wrote: > This patch adds support for the 88x2110 PHY, which is similar to the > already supported 88x3310 PHY without the SFP interface. > > It supports 10/100/1000BASET along with 2.5GBASET, 5GBASET and 10GBASET, > with the same interfac

[PATCH net-next 1/2] net: dsa: mv88e6xxx: Add lockdep classes to fix false positive splat

2019-02-23 Thread Andrew Lunn
The following false positive lockdep splat has been observed. == WARNING: possible circular locking dependency detected 4.20.0+ #302 Not tainted -- systemd-udevd/160 is trying to acquire lock: e

[PATCH net-next 0/2] mv88e6xxx: Avoid false positive Lockdep splats

2019-02-23 Thread Andrew Lunn
When acquiring the GPIO interrupt line for the switch, it is possible to trigger lockdep splats. These are false positives, the mutex is in a different IRQ descriptor. But fix it anyway, since it could mask real locking issues. Andrew Lunn (2): net: dsa: mv88e6xxx: Add lockdep classes to fix fal

[PATCH net-next 2/2] net: dsa: mv88e6xxx: Release lock while requesting IRQ

2019-02-23 Thread Andrew Lunn
There is no need to hold the register lock while requesting the GPIO interrupt. By not holding it we can also avoid a false positive lockdep splat. Reported-by: Russell King Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dri

Re: [PATCH hyperv-fixes] hv_netvsc: Fix IP header checksum for coalesced packets

2019-02-23 Thread Stephen Hemminger
On Fri, 22 Feb 2019 18:25:03 + Haiyang Zhang wrote: > From: Haiyang Zhang > > Incoming packets may have IP header checksum verified by the host. > They may not have IP header checksum computed after coalescing. > This patch re-compute the checksum when necessary, otherwise the > packets may

Fw: [Bug 202651] New: Regression in atlantic.ko between 4.20 and 5.00-rc4 for Aquantia NIC 1d6a:87b1

2019-02-23 Thread Stephen Hemminger
Begin forwarded message: Date: Sat, 23 Feb 2019 09:01:29 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 202651] New: Regression in atlantic.ko between 4.20 and 5.00-rc4 for Aquantia NIC 1d6a:87b1 https://bugzilla.kernel.org/show_bug.cgi?id=202651

kTLS getsockopt TLS_RX support

2019-02-23 Thread Hayakawa Yutaro
Hello, While trying the kTLS, I found out that currently, there is no support for kTLS getsockopt TLS_RX which extracts receive side crypto information from kTLS socket. Since setting crypto information for RX side is supported, I felt wonder why it is not supported. Is there any particular re

RE: [PATCH hyperv-fixes] hv_netvsc: Fix IP header checksum for coalesced packets

2019-02-23 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, February 23, 2019 11:46 AM > To: Haiyang Zhang > Cc: Haiyang Zhang ; sas...@kernel.org; linux- > hyp...@vger.kernel.org; KY Srinivasan ; Stephen > Hemminger ; o...@aepfle.de; vkuznets > ; da...@davemloft.net; netdev@vger.

[PATCH v2 bpf-next 3/4] tools/bpf: sync bpf.h into tools

2019-02-23 Thread Alexei Starovoitov
sync bpf.h into tools directory Signed-off-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index bcdd2474eee7..d2cb85d85b39 100644 --- a/tools/include/uapi/linux/bpf.h

[PATCH v2 bpf-next 4/4] tools/bpftool: recognize bpf_prog_info runtime and runcnt

2019-02-23 Thread Alexei Starovoitov
$ bpftool p s 1: kprobe tag a56587d488d216c9 gpl runtime 79786 runcnt 8 loaded_at 2019-02-22T12:22:51-0800 uid 0 xlated 352B not jited memlock 4096B $ bpftool --json --pretty p s [{ "id": 1, "type": "kprobe", "tag": "a56587d488d216c9", "gpl_comp

[PATCH v2 bpf-next 0/4] bpf: per program stats

2019-02-23 Thread Alexei Starovoitov
Introduce per program stats to monitor the usage BPF v1->v2: - fixed u64 stats on 32-bit archs. Thanks Eric - use more verbose run_time_ns in json output as suggested by Andrii - refactored prog_alloc and clarified behavior of stats in subprogs Alexei Starovoitov (4): bpf: enable program stats

Re: [PATCH v2 bpf-next 1/4] bpf: enable program stats

2019-02-23 Thread Eric Dumazet
On 02/23/2019 09:44 AM, Alexei Starovoitov wrote: ... > > -#define BPF_PROG_RUN(filter, ctx) ({ cant_sleep(); > (*(filter)->bpf_func)(ctx, (filter)->insnsi); }) > +DECLARE_STATIC_KEY_FALSE(bpf_stats_enabled_key); > + > +#define BPF_PROG_RUN(prog, ctx) ({ \

Re: [PATCH v2 bpf-next 0/9] bpf: Network Resource Manager (NRM)

2019-02-23 Thread Eric Dumazet
On 02/22/2019 07:03 PM, David Ahern wrote: > On 2/22/19 8:06 PM, brakmo wrote: >> Network Resource Manager is a framework for limiting the bandwidth used >> by v2 cgroups. It consists of 4 BPF helpers and a sample BPF program to >> limit egress bandwdith as well as a sample user program and scri

[PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-23 Thread Eric Dumazet
If caller of bpf_setsockopt() is silly passing a negative optlen bad things happen. Fixes: 91b5b21c7c16 ("bpf: Add support for changing congestion control") Signed-off-by: Eric Dumazet Cc: Lawrence Brakmo --- net/core/filter.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --g

Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth

2019-02-23 Thread David Summers
On 22/02/2019 19:21, Vasily Khoruzhick wrote: On Fri, Feb 22, 2019 at 11:14 AM David Summers wrote: Hi Vasily, Just catching up with this series - good that you are doing it. We need it for users on ArchLinux ARM! On question though, what is "firmware-postfix" used for? I see in the documenta

Re: [PATCH v2 bpf-next 1/4] bpf: enable program stats

2019-02-23 Thread Alexei Starovoitov
On Sat, Feb 23, 2019 at 10:36:48AM -0800, Eric Dumazet wrote: > > > On 02/23/2019 09:44 AM, Alexei Starovoitov wrote: > > ... > > > > > -#define BPF_PROG_RUN(filter, ctx) ({ cant_sleep(); > > (*(filter)->bpf_func)(ctx, (filter)->insnsi); }) > > +DECLARE_STATIC_KEY_FALSE(bpf_stats_enabled_ke

Re: [PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-23 Thread Alexei Starovoitov
On Sat, Feb 23, 2019 at 11:07:09AM -0800, Eric Dumazet wrote: > If caller of bpf_setsockopt() is silly passing a negative optlen > bad things happen. > > Fixes: 91b5b21c7c16 ("bpf: Add support for changing congestion control") > Signed-off-by: Eric Dumazet > Cc: Lawrence Brakmo > --- > net/core

Re: [PATCH v2 bpf-next 0/9] bpf: Network Resource Manager (NRM)

2019-02-23 Thread Alexei Starovoitov
On Sat, Feb 23, 2019 at 10:39:53AM -0800, Eric Dumazet wrote: > > > On 02/22/2019 07:03 PM, David Ahern wrote: > > On 2/22/19 8:06 PM, brakmo wrote: > >> Network Resource Manager is a framework for limiting the bandwidth used > >> by v2 cgroups. It consists of 4 BPF helpers and a sample BPF progr

Re: [PATCH v2 bpf-next 0/9] bpf: Network Resource Manager (NRM)

2019-02-23 Thread Eric Dumazet
On 02/23/2019 12:40 PM, Alexei Starovoitov wrote: > On Sat, Feb 23, 2019 at 10:39:53AM -0800, Eric Dumazet wrote: >> >> >> On 02/22/2019 07:03 PM, David Ahern wrote: >>> On 2/22/19 8:06 PM, brakmo wrote: Network Resource Manager is a framework for limiting the bandwidth used by v2 cgro

Re: [PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-23 Thread Eric Dumazet
On 02/23/2019 12:38 PM, Alexei Starovoitov wrote: > On Sat, Feb 23, 2019 at 11:07:09AM -0800, Eric Dumazet wrote: >> If caller of bpf_setsockopt() is silly passing a negative optlen >> bad things happen. >> >> Fixes: 91b5b21c7c16 ("bpf: Add support for changing congestion control") >> Signed-off

[PATCH AUTOSEL 4.20 03/72] xfrm: Make set-mark default behavior backward compatible

2019-02-23 Thread Sasha Levin
From: Benedict Wong [ Upstream commit e2612cd496e7b465711d219ea6118893d7253f52 ] Fixes 9b42c1f179a6, which changed the default route lookup behavior for tunnel mode SAs in the outbound direction to use the skb mark, whereas previously mark=0 was used if the output mark was unspecified. In mark-b

[PATCH AUTOSEL 4.20 46/72] qed: Fix system crash in ll2 xmit

2019-02-23 Thread Sasha Levin
From: Manish Chopra [ Upstream commit 7c81626a3c37e4ac320b8ad785694ba498f24794 ] Cache number of fragments in the skb locally as in case of linear skb (with zero fragments), tx completion (or freeing of skb) may happen before driver tries to get number of frgaments from the skb which could lead

[PATCH AUTOSEL 4.20 55/72] net: macb: Apply RXUBR workaround only to versions with errata

2019-02-23 Thread Sasha Levin
From: Harini Katakam [ Upstream commit e501070e4db0b67a4c17a5557d1e9d098f3db310 ] The interrupt handler contains a workaround for RX hang applicable to Zynq and AT91RM9200 only. Subsequent versions do not need this workaround. This workaround unnecessarily resets RX whenever RX used bit read is

[PATCH AUTOSEL 4.19 03/65] xfrm: Make set-mark default behavior backward compatible

2019-02-23 Thread Sasha Levin
From: Benedict Wong [ Upstream commit e2612cd496e7b465711d219ea6118893d7253f52 ] Fixes 9b42c1f179a6, which changed the default route lookup behavior for tunnel mode SAs in the outbound direction to use the skb mark, whereas previously mark=0 was used if the output mark was unspecified. In mark-b

[PATCH AUTOSEL 4.19 30/65] net: hns: Restart autoneg need return failed when autoneg off

2019-02-23 Thread Sasha Levin
From: Yonglong Liu [ Upstream commit ed29ca8b9592562559c64d027fb5eb126e463e2c ] The hns driver of earlier devices, when autoneg off, restart autoneg will return -EINVAL, so make the hns driver for the latest devices do the same. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by

[PATCH AUTOSEL 3.18 10/18] net: altera_tse: fix msgdma_tx_completion on non-zero fill_level case

2019-02-23 Thread Sasha Levin
From: Tomonori Sakita [ Upstream commit 6571ebce112a21ec9be68ef2f53b96fcd41fd81b ] If fill_level was not zero and status was not BUSY, result of "tx_prod - tx_cons - inuse" might be zero. Subtracting 1 unconditionally results invalid negative return value on this case. Make sure not to return an

[PATCH AUTOSEL 3.18 04/18] ipvs: Fix signed integer overflow when setsockopt timeout

2019-02-23 Thread Sasha Levin
From: ZhangXiaoxu [ Upstream commit 53ab60baa1ac4f20b080a22c13b77b6373922fd7 ] There is a UBSAN bug report as below: UBSAN: Undefined behaviour in net/netfilter/ipvs/ip_vs_ctl.c:2227:21 signed integer overflow: -2147483647 * 1000 cannot be represented in type 'int' Reproduce program: #i

[PATCH AUTOSEL 4.4 12/26] net: altera_tse: fix msgdma_tx_completion on non-zero fill_level case

2019-02-23 Thread Sasha Levin
From: Tomonori Sakita [ Upstream commit 6571ebce112a21ec9be68ef2f53b96fcd41fd81b ] If fill_level was not zero and status was not BUSY, result of "tx_prod - tx_cons - inuse" might be zero. Subtracting 1 unconditionally results invalid negative return value on this case. Make sure not to return an

[PATCH AUTOSEL 4.4 13/26] net: hns: Fix wrong read accesses via Clause 45 MDIO protocol

2019-02-23 Thread Sasha Levin
From: Yonglong Liu [ Upstream commit cec8abba13e6a26729dfed41019720068eeeff2b ] When reading phy registers via Clause 45 MDIO protocol, after write address operation, the driver use another write address operation, so can not read the right value of any phy registers. This patch fixes it. Signe

  1   2   3   >