On Tue, 19 Feb 2019 14:36:29 +0100
Andrew Lunn wrote:
> This seems like an odd design. I've normally seen weak pull up/down
> resistors, not a switch, so i'm wondering why it is designed like
> this.
The key point here is that this "CONFIG" pin of the PHY is used during
reset to configure the PH
On Tue, Feb 19, 2019 at 10:33:38AM -0800, David Miller wrote:
> From: Ido Schimmel
> Date: Tue, 19 Feb 2019 09:30:31 +
>
> > We have a series for net-next that adds support for Spectrum-2 shared
> > buffers and it depends on this patch. I was wondering if you could merge
> > net into net-next
On Tue, Feb 19, 2019 at 06:27:59PM -0800, Jakub Kicinski wrote:
> On Mon, 18 Feb 2019 19:21:49 +0100 (CET), Michal Kubecek wrote:
> > + else if (is_u32)
> > + bitmap_from_arr32(val, bitmap, nbits);
> > + else
> > + bitmap_copy(val, bitmap, nbi
When a port is added to a team, its initial state is derived
from netif_carrier_ok rather than netif_oper_up.
If it is carrier up but operationally down at the time of being
added, the port state.linkup will be set prematurely.
port state.linkup should be set consistently using
netif_oper_up rather
Fix a possible NULL pointer dereference in ip6erspan_set_version checking
nlattr data pointer
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: [#1] PREEMPT SMP KASAN
CPU: 1 PID: 7549 Comm: syz-executor432 Not taint
Hi Tony,
On 19/02/2019 18.52, Tony Lindgren wrote:
> * Peter Ujfalusi [190219 08:02]:
>> On 18/02/2019 18.26, Tony Lindgren wrote:
>>> OK so sounds like these are OK to wait for v5.1 merge window
>>> then as the dts changes alone won't fix anything?
>>
>> I think it would be better to send these
On 2019/1/31 12:33, Tom Herbert wrote:
> On Wed, Jan 30, 2019 at 6:59 PM maowenan wrote:
>>
>>
>>
>> On 2019/1/31 10:43, Tom Herbert wrote:
>>> On Wed, Jan 30, 2019 at 5:58 PM maowenan wrote:
On 2019/1/30 4:24, Tom Herbert wrote:
> On Tue, Jan 29, 2019 at 12:08 AM maowe
Test case 'control_msg' has been updated to peek non-data record and
then verify the type of record received. Subsequently, the same record
is retrieved without MSG_PEEK flag in recvmsg().
Signed-off-by: Vakul Garg
---
tools/testing/selftests/net/tls.c | 14 ++
1 file changed, 14 ins
Wed, Feb 20, 2019 at 07:48:13AM CET, da...@davemloft.net wrote:
>From: Vinod Koul
>Date: Wed, 20 Feb 2019 10:10:55 +0530
>
>> On 20-02-19, 09:31, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>>>
>>> Fixes tag
>>
Wed, Feb 20, 2019 at 09:19:11AM CET, gwil...@vyatta.att-mail.com wrote:
>When a port is added to a team, its initial state is derived
>from netif_carrier_ok rather than netif_oper_up.
>If it is carrier up but operationally down at the time of being
>added, the port state.linkup will be set prematur
Wed, Feb 20, 2019 at 01:49:26AM CET, jakub.kicin...@netronome.com wrote:
>On Tue, 19 Feb 2019 10:19:42 +0100, Jiri Pirko wrote:
>> Fri, Feb 15, 2019 at 04:44:29PM CET, jakub.kicin...@netronome.com wrote:
>> >On Fri, 15 Feb 2019 11:15:14 +0100, Jiri Pirko wrote:
>> >> > static const struct ethtool
On 20/02/19 9:23 AM, Vaishali Thakkar wrote:
On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote:
Hi Himadri,
Thanks for the patch!
For the scope of Outreachy, we prefer that you send patches in staging
directory as Greg makes sure to pick them during the application
period. Of course, you'
From: Jiri Pirko
Dpipe table show command has a depencency on getting resources.
If resource get command is not supported by the driver, dpipe table
show fails. However, resource is only additional information
in dpipe table show output. So relax the dependency and let
the dpipe tables be shown e
From: Colin Ian King
There is an uppercase 'N' that should be a lowercase 'n', fix this.
Signed-off-by: Colin Ian King
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c
On Tue, Feb 19, 2019 at 02:18:30PM -0800, David Miller wrote:
> From: George Wilkie
> Date: Tue, 19 Feb 2019 15:57:15 +
>
> > Fixes: f1d22a1e0595 ("team: account for oper state")
> >
> > Signed-off-by: George Wilkie
>
> Please do not put an empty line between Fixes: and other tags, all tag
Hello,
syzbot found the following crash on:
HEAD commit:abf446c90405 Add linux-next specific files for 20190220
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=17f250d8c0
kernel config: https://syzkaller.appspot.com/x/.config?x=463cb576ac40e350
On Tue, 2019-02-19 at 11:05 -0800, Nick Desaulniers wrote:
> On Tue, Feb 19, 2019 at 10:21 AM Nathan Chancellor
> wrote:
> > Clang warns:
> >
> > drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:465:2:
> > warning:
> > comparison of distinct pointer types ('typeof ((rtt_avg)) *' (aka
> > 'l
Hi Daniel,
On Tue, Feb 19, 2019 at 05:00 PM CET, Daniel Borkmann wrote:
> On 02/11/2019 10:09 AM, Jakub Sitnicki wrote:
>> Backlog work for psock (sk_psock_backlog) might sleep while waiting for
>> memory to free up when sending packets. While sleeping, socket can
>> disappear from under our feet
On 02/20/2019 10:32 AM, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: abf446c90405 Add linux-next specific files for 20190220
> git tree: linux-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=17f250d8c0
&g
On Mon, Jan 28, 2019 at 09:28:36AM +0100, Dmitry Vyukov wrote:
>
> > Weird, this is the kfree() on the error path of br_multicast_new_group()
> > when rhashtable_lookup_insert_fast() fails, which means the entry should
> > not be linked in the rhashtable or the hlist.
> > All other frees are via kf
When a DSA port is added to a bridge and brought up, the resulting STP
state programmed into the hardware depends on the order that these
operations are performed. However, the Linux bridge code believes that
the port is in disabled mode.
If the DSA port is first added to a bridge and then brough
On Tue, Feb 19, 2019 at 7:22 PM Nathan Chancellor
wrote:
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c
> b/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c
> index e9822a3ec373..92b22250eb7d 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c
> +
Hello Russell,
On Thu, 7 Feb 2019 23:48:24 +
Russell King - ARM Linux admin wrote:
>On Thu, Feb 07, 2019 at 10:49:36AM +0100, Maxime Chevallier wrote:
>> The Marvell Alaska family of PHYs supports 2.5GBaseT and 5GBaseT modes,
>> as defined in the 802.3bz specification.
>>
>> When the link p
Correct STREERING to STEERING at macro name for BGX steering register.
Signed-off-by: Vadim Lomovtsev
---
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net
Move the link change polling task to VF side in order to
prevent races between VF and PF while sending link change
message(s). This commit is to implement link change request
to be initiated by VF.
Signed-off-by: Vadim Lomovtsev
---
drivers/net/ethernet/cavium/thunder/nic.h | 2 +-
.../net/
The ThunderX CN88XX NIC Virtual Function driver uses mailbox interface
to communicate to physical function driver. Each of VF has it's own pair
of mailbox registers to read from and write to. The mailbox registers
has no protection from possible races, so it has to be implemented
at software side.
To communicate to PF each of ThunderX NIC VF uses mailbox which is
pair of 64 bit registers available to both VFn and PF.
This commit is to change the xcast message structure in order to
fit it into 64 bit.
Signed-off-by: Vadim Lomovtsev
---
drivers/net/ethernet/cavium/thunder/nic.h| 6
Having one work queue for receive mode configuration ndo_set_rx_mode()
call for all VFs results in making each of them wait till the
set_rx_mode() call completes for another VF if any of close, set
receive mode and change flags calls being already invoked. Potentially
this could cause device state
At the end of NIC VF initialization VF sends CFG_DONE message to PF without
using nicvf_msg_send_to_pf routine. This potentially could re-write data in
mailbox. This commit is to implement common way of sending CFG_DONE message
by the same way with other configuration messages by using
nicvf_send_m
The rx_set_mode invokes number of messages to be send to PF for receive
mode configuration. In case if there any issues we need to stop sending
messages and release allocated memory.
This commit is to implement check of nicvf_msg_send_to_pf() result.
Signed-off-by: Vadim Lomovtsev
---
drivers/n
In some cases it could happen that nicvf_send_msg_to_pf() could be called
concurrently for the same NIC VF, and thus re-writing mailbox contents and
breaking messaging sequence with PF by re-writing NICVF data.
This commit is to implement mutex for NICVF to protect mailbox registers
and NICVF mess
Since link change polling routine was moved to nicvf side,
we don't need anymore polling function at nicpf side along
with link status info for all enabled Vfs as at VF side
this info is already tracked.
This commit is to remove unnecessary code & fields from
nicpf structure.
Signed-off-by: Vadim
In 568f196756ad ("bpf: check that BPF programs run with preemption disabled")
a check was added for BPF_PROG_RUN() that for every invocation preemption has
to be disabled to not break eBPF assumptions (e.g. per-cpu map). Of course this
does not count for seccomp because only cBPF -> eBPF is loaded
sorry for occasionally reply to old thread.
On Wed, Feb 20, 2019 at 11:02:42AM +, Vadim Lomovtsev wrote:
> The ThunderX CN88XX NIC Virtual Function driver uses mailbox interface
> to communicate to physical function driver. Each of VF has it's own pair
> of mailbox registers to read from and w
syzbot has found a reproducer for the following crash on:
HEAD commit:abf446c90405 Add linux-next specific files for 20190220
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=101e7fb0c0
kernel config: https://syzkaller.appspot.com/x/.config?x
On Tue, Feb 19, 2019 at 06:56:10PM -0800, Jakub Kicinski wrote:
> On Mon, 18 Feb 2019 19:22:14 +0100 (CET), Michal Kubecek wrote:
> > Requests a contents of one or more string sets, i.e. indexed arrays of
> > strings; this information is provided by ETHTOOL_GSSET_INFO and
> > ETHTOOL_GSTRINGS comma
Add support for the bridge flags to Marvell 88e6xxx bridges, allowing
the multicast and unicast flood properties to be controlled. These
can be controlled on a per-port basis via commands such as:
bridge link set dev lan1 flood on|off
bridge link set dev lan1 mcast_flood on|off
S
We have had some emails in private over this issue, this is my current
patch set rebased on top of net-next which provides working IPv6 (and
probably other protocols as well) over mv88e6xxx DSA switches.
The problem comes down to mv88e6xxx defaulting to not flood unknown
unicast and multicast data
The Linux bridge implementation allows various properties of the bridge
to be controlled, such as flooding unknown unicast and multicast frames.
This patch adds the necessary DSA infrastructure to allow the Linux
bridge support to control these properties for DSA switches.
We implement this by pro
Switches work by learning the MAC address for each attached station by
monitoring traffic from each station. When a station sends a packet,
the switch records which port the MAC address is connected to.
With IPv4 networking, before communication commences with a neighbour,
an ARP packet is broadc
On Tue, Feb 19, 2019 at 07:00:48PM -0800, Jakub Kicinski wrote:
> On Mon, 18 Feb 2019 19:22:29 +0100 (CET), Michal Kubecek wrote:
> > Add timestamping information as provided by ETHTOOL_GET_TS_INFO ioctl
> > command in GET_INFO reply if ETH_INFO_IM_TSINFO flag is set in the request.
> >
> > Add co
This is a small update to the community on the Netdev 0x13 conference
(March 20-22, in Prague, Czech Republic)
https://www.netdevconf.org/0x13
Early registration fees end today at 23:59 EST.
To Register: https://www.netdevconf.org/0x13/registration.html
Our bursaries are also going to close toda
Dear David,
currently do_tcp_sendpages() calls skb_can_coalesce() to merge proper tcp
fragments.
If these fragments are slab objects and the data is not transferred out of the
local host
then tcp_recvmsg() can crash host on BUG_ON (see [2] below).
There is known usecase when slab objects are pr
When a netdevice is unregistered, we flush the relevant exception
via rt6_sync_down_dev() -> fib6_ifdown() -> fib6_del() -> fib6_del_route().
Finally, we end-up calling rt6_remove_exception(), where we release
the relevant dst, while we keep the references to the related fib6_info and
dev. Such re
Hi,
Static analysis by CoverityScan has detected an uninitialized variable
error in drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c
Variable used_hw_queues in iwl_mvm_mac_ctxt_init() is no longer being
assigned an initial value, causing garbage to be found when calling
find_first_zero_bit() on
From: Thomas De Schampheleire
Commit c759116a0b2b6da8df9687b0a40ac69050132c77 introduced support for
AF_VSOCK. This define is only provided since glibc version 2.18, so
compilation fails when using older toolchains.
Provide the necessary definitions if needed.
Signed-off-by: Thomas De Schamphel
Hello,
syzbot found the following crash on:
HEAD commit:abf446c90405 Add linux-next specific files for 20190220
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=175c2248c0
kernel config: https://syzkaller.appspot.com/x/.config?x=463cb576ac40e350
On Wed, Feb 20, 2019 at 08:54:32AM +0530, Himadri Pandya wrote:
> Decrement the reference count on port while returning out of the loop.
>
> Signed-off-by: Himadri Pandya
Hi Himadri
Thanks for the patch. The code changes themselves look good.
Netdev has a few additional processes for submittin
>Subject: Re: [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs
>
>On Fri, Feb 15, 2019 at 11:10:59AM -0600, Shiraz Saleem wrote:
>
>> +static int irdma_alloc_pd(struct ib_pd *pd,
>> + struct ib_ucontext *context,
>> + struct ib_udata *udata)
>Subject: Re: [RFC v1 17/19] RDMA/irdma: Add ABI definitions
>
>On Fri, Feb 15, 2019 at 11:11:04AM -0600, Shiraz Saleem wrote:
>> From: Mustafa Ismail
>>
>> Add ABI definitions for irdma.
[]
>>
>> +
>> +#include
>> +
>> +#define IRDMA_ABI_VER 6
>
>Starting with high numbers?
It's a bu
>Subject: Re: [RFC v1 15/19] RDMA/irdma: Add miscellaneous utility definitions
>
>On Fri, Feb 15, 2019 at 11:11:02AM -0600, Shiraz Saleem wrote:
>> From: Mustafa Ismail
>>
>> Add miscellaneous utility functions and headers.
>>
[]
>
>> +#define to_device(ptr)
On Wed, Feb 20, 2019 at 08:54:01AM +0100, Rodolfo Giometti wrote:
> On 19/02/2019 01:03, Andrew Lunn wrote:
> >>diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> >>b/drivers/net/dsa/mv88e6xxx/chip.c
> >>index 54a5b660640a..bb46ebbb2bb8 100644
> >>--- a/drivers/net/dsa/mv88e6xxx/chip.c
> >>+++ b/driv
-20190220 so I tested the latest version.
Now the cpu port does not work again. I tracked it down to this commit
5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in
genphy_read_status") [4]
If I revert the offending commit, cpu port works fine. I suspect the
problem is on the qca8k d
> +static void mib_monitor(struct timer_list *t)
> +{
> + struct ksz_device *dev = from_timer(dev, t, mib_read_timer);
> + const struct dsa_port *dp;
> + struct net_device *netdev;
> + struct ksz_port_mib *mib;
> + struct ksz_port *p;
> + int i;
> +
> + mod_timer(&dev->m
On Tue, Feb 19, 2019 at 09:30:33PM -0800, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> Resending these as I had only 1 minor comment which I believe we have covered
> in this series. I was anticipating these going through the mm tree as they
> depend on a cleanup patch there and the IB chang
An issue has been found while testing zero-copy XDP that
causes a reset to be triggered. As it takes some time to
turn the carrier on after setting zc, and we already
start trying to transmit some packets, watchdog considers
this as an erroneous state and triggers a reset.
Don't do any work if net
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel.
Signed-off-by: Grygorii Strashko
---
arch/arm/boot/dts/am335x-baltos-ir2110.dts| 4
arch/arm/boot/dts/am335x-baltos-ir3220.dts| 4
arch/arm/boot/dts/am335x-baltos-ir5221.dts| 4
arch/arm/boot/dts/am
The cpsw-phy-sel driver was replaced with new PHY driver phy-gmii-sel, so
deprecate cpsw-phy-sel bindings.
Reviewed-by: Rob Herring
Signed-off-by: Grygorii Strashko
---
Documentation/devicetree/bindings/net/cpsw-phy-sel.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Doc
Deprecate cpsw-phy-sel driver as it's been replaced with new
TI phy-gmii-sel PHY driver.
Signed-off-by: Grygorii Strashko
---
drivers/net/ethernet/ti/Kconfig | 6 +++---
drivers/net/ethernet/ti/cpsw.h | 6 ++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/etherne
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel.
Signed-off-by: Grygorii Strashko
---
arch/arm/boot/dts/dra7-l4.dtsi | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
index bb45cb7fc3b6..414f
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel.
Signed-off-by: Grygorii Strashko
---
arch/arm/boot/dts/am437x-l4.dtsi | 17 +
arch/arm/boot/dts/am43x-epos-evm.dts | 5 +
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/am437x-l4.
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel.
Signed-off-by: Grygorii Strashko
---
arch/arm/boot/dts/dm814x.dtsi | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/dm814x.dtsi b/arch/arm/boot/dts/dm814x.dtsi
index 601c57afd4fe..413ae19
Hi Tony,
Hence prerequisite patches [1] have been merged already I'm sending final set
of DT patches to complete conversation of TI CPSW driver to use phy-gmii-sel
phy driver instead of cpsw-phy-sel.
[1] https://lkml.org/lkml/2018/11/26/154
Grygorii Strashko (6):
ARM: dts: dra7: switch to use
Here, we add a bitmap to the ixgbe_adapter that tracks if a
certain queue pair has been "zero-copy enabled" via the ndo_bpf.
The bitmap is used in ixgbe_xsk_umem, and enables zero-copy if
and only if XDP is enabled, the corresponding qid in the bitmap
is set, and the umem is non-NULL;
Signed-off-b
As current implementation of netdev already contains and provides
umems for us, we no longer have the need to contain these
structures in ixgbe_adapter.
Refactor the code to operate on netdev-provided umems.
Signed-off-by: Jan Sokolowski
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 11 +--
* Grygorii Strashko [190220 07:26]:
> Hi Tony,
>
> Hence prerequisite patches [1] have been merged already I'm sending final set
> of DT patches to complete conversation of TI CPSW driver to use phy-gmii-sel
> phy driver instead of cpsw-phy-sel.
>
> [1] https://lkml.org/lkml/2018/11/26/154
Gre
On Wed, Feb 20, 2019 at 6:28 AM Devi Sandeep Endluri V V
wrote:
>
> Userspace sends tcp connection (sock) destroy on network permission
> change. Kernel though doesn't send reset for the connections in
> SYN-SENT state and these connections continue to remain. Even as
> per RFC 793, there is no ha
From: Willem de Bruijn
Commit 121d57af308d ("gso: validate gso_type in GSO handlers") added
gso_type validation to existing gso_segment callback functions, to
filter out illegal and potentially dangerous SKB_GSO_DODGY packets.
Convert tunnels that now call inet_gso_segment and ipv6_gso_segment
d
On 02/20/2019 05:34 AM, Vasily Averin wrote:
> Dear David,
>
> currently do_tcp_sendpages() calls skb_can_coalesce() to merge proper tcp
> fragments.
> If these fragments are slab objects and the data is not transferred out of
> the local host
> then tcp_recvmsg() can crash host on BUG_ON (se
On Mon, 18 Feb 2019 at 13:37, Alan Maguire wrote:
>
> Naresh Kamboju noted the following oops during execution of selftest
> tools/testing/selftests/bpf/test_tunnel.sh on x86_64:
>
> [ 274.120445] BUG: unable to handle kernel NULL pointer dereference
> at
> [ 274.128285] #PF err
On Thu, Aug 2, 2018 at 3:05 PM syzbot
wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:44960f2a7b63 staging: ashmem: Fix SIGBUS crash when traver..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=10f7ea7240
> kernel config:
On Wed, 2019-02-20 at 15:08 +0100, Paolo Abeni wrote:
> When a netdevice is unregistered, we flush the relevant exception
> via rt6_sync_down_dev() -> fib6_ifdown() -> fib6_del() -> fib6_del_route().
>
> Finally, we end-up calling rt6_remove_exception(), where we release
> the relevant dst, while
Hi,
* Grygorii Strashko [190220 15:26]:
> Deprecate cpsw-phy-sel driver as it's been replaced with new
> TI phy-gmii-sel PHY driver.
I'm not going to pick up this one, seems that Dave can merge
this later on? That is unless Dave wants to ack this one.
Regards,
Tony
> Signed-off-by: Grygorii S
On Tue, Feb 19, 2019 at 8:12 PM Dominique Martinet
wrote:
>
> Dominique Martinet wrote on Fri, Feb 15, 2019:
> > With all that said I guess my patch should work correctly then, I'll try
> > to find some time to check the error does come back up the tcp socket in
> > my reproducer but I have no rea
On 2/20/19 6:53 PM, Eric Dumazet wrote:
> On 02/20/2019 05:34 AM, Vasily Averin wrote:
>> Dear David,
>>
>> currently do_tcp_sendpages() calls skb_can_coalesce() to merge proper tcp
>> fragments.
>> If these fragments are slab objects and the data is not transferred out of
>> the local host
>> th
Hello,
syzbot found the following crash on:
HEAD commit:1f43f400a2cb net: netcp: Fix ethss driver probe issue
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=1276fea2c0
kernel config: https://syzkaller.appspot.com/x/.config?x=ee434566c893c7b1
dashboard link
This patch simply changes the description of the mcast_flood flag
with "flood" instead of "be flooded with" to avoid confusion, and be
consistent with the description of the flooding flag, which "Controls
whether a given port will *flood* unicast traffic for which there is
no FDB entry."
At the sa
Hi Russell,
On Wed, 20 Feb 2019 00:05:29 +, Russell King - ARM Linux admin
wrote:
> I'm not sure if it's in the current iproute2, but there is a
> discrepency between the arguments for 'bridge' stated in the man page
> and the description thereof:
>
>bridge link set dev DEV [ cost
On 02/20/2019 08:19 AM, Vasily Averin wrote:
> Thank you for explanation,
> though this happen in real life and triggers BUG_ON only if receiving side is
> located on the same host.
> Is it probably makes sense to add WARN_ON into skb_can_coalesce to detect
> such cases?
Yes, but please do
On Wed, 20 Feb 2019 10:32:52 +, Russell King
wrote:
> When a DSA port is added to a bridge and brought up, the resulting STP
> state programmed into the hardware depends on the order that these
> operations are performed. However, the Linux bridge code believes that
> the port is in disabled
On Wed, Feb 20, 2019 at 02:52:03PM +, Saleem, Shiraz wrote:
> >Subject: Re: [RFC v1 17/19] RDMA/irdma: Add ABI definitions
> >
> >On Fri, Feb 15, 2019 at 11:11:04AM -0600, Shiraz Saleem wrote:
> >> From: Mustafa Ismail
> >>
> >> Add ABI definitions for irdma.
>
> []
> >>
> >> +
> >> +#inc
After an uptime of 2-4 days our routers are hitting a general protection fault
in dev_hard_start_xmit. We are going to try the latest 4.19.24 release to see
if the bug has been resolved, but I didn't see any obvious commits in the logs.
We are also going to test with a much older 4.9.159 kernel as
On Wed, Feb 20, 2019 at 02:52:31PM +, Saleem, Shiraz wrote:
> >All lists of things should be sorted. I saw many examples of unsorted lists.
>
> OK. We weren't aware of this rule in kernel drivers. Is this subsystem
> specific?
It is a general kernel preference - it helps avoid unnecessary m
On Wed, Feb 20, 2019 at 02:53:18PM +, Saleem, Shiraz wrote:
> >Subject: Re: [RFC v1 15/19] RDMA/irdma: Add miscellaneous utility definitions
> >
> >On Fri, Feb 15, 2019 at 11:11:02AM -0600, Shiraz Saleem wrote:
> >> From: Mustafa Ismail
> >>
> >> Add miscellaneous utility functions and headers
On Wed, Sep 26, 2018 at 9:49 AM syzbot
wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:739d0def85ca Merge branch 'hv_netvsc-Support-LRO-RSC-in-th..
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=13aa179e40
> kernel config:
Hi Stephen,
I think this patch is reasonably tested now. Eric, who reported the
original issue, is also satisfied with it. Is there any issue with it?
--
Stefano
On Thu, 14 Feb 2019 01:58:32 +0100
Stefano Brivio wrote:
> Eric reported that, with 10 million sockets, ss -emoi (about 1000 bytes
On Wed, Feb 20, 2019 at 12:06:29PM +0100, Daniel Borkmann wrote:
> In 568f196756ad ("bpf: check that BPF programs run with preemption disabled")
> a check was added for BPF_PROG_RUN() that for every invocation preemption has
> to be disabled to not break eBPF assumptions (e.g. per-cpu map). Of cour
We must access rt6_info->from under RCU read lock: move the
dereference under such lock, with proper annotation, and use
rcu_access_pointer() to check for null value outside the lock.
Fixes: a68886a69180 ("net/ipv6: Make from in rt6_info rcu protected")
Signed-off-by: Paolo Abeni
---
net/ipv6/ro
This series addresses a couple of RCU left-over dating back to rt6_info->from
conversion to RCU
Paolo Abeni (2):
ipv6: route: enforce RCU protection in rt6_update_exception_stamp_rt()
ipv6: route: enforce RCU protection in ip6_route_check_nh_onlink()
net/ipv6/route.c | 12
1 fil
We need a RCU critical section around rt6_info->from deference, and
proper annotation.
Fixes: 4ed591c8ab44 ("net/ipv6: Allow onlink routes to have a device mismatch
if it is the default route")
Signed-off-by: Paolo Abeni
---
net/ipv6/route.c | 6 +-
1 file changed, 5 insertions(+), 1 deleti
When a netdevice is unregistered, we flush the relevant exception
via rt6_sync_down_dev() -> fib6_ifdown() -> fib6_del() -> fib6_del_route().
Finally, we end-up calling rt6_remove_exception(), where we release
the relevant dst, while we keep the references to the related fib6_info and
dev. Such re
On 2/20/19 7:08 AM, Andrew Lunn wrote:
>> +static void mib_monitor(struct timer_list *t)
>> +{
>> +struct ksz_device *dev = from_timer(dev, t, mib_read_timer);
>> +const struct dsa_port *dp;
>> +struct net_device *netdev;
>> +struct ksz_port_mib *mib;
>> +struct ksz_port *p;
>>
On 2/20/19 2:32 AM, Russell King wrote:
> When a DSA port is added to a bridge and brought up, the resulting STP
> state programmed into the hardware depends on the order that these
> operations are performed. However, the Linux bridge code believes that
> the port is in disabled mode.
>
> If the
On Wed, 2019-02-20 at 18:10 +0100, Paolo Abeni wrote:
> We must access rt6_info->from under RCU read lock: move the
> dereference under such lock, with proper annotation, and use
> rcu_access_pointer() to check for null value outside the lock.
>
> Fixes: a68886a69180 ("net/ipv6: Make from in rt6_i
Hi Russell,
On Wed, 20 Feb 2019 12:36:59 +, Russell King
wrote:
> Switches work by learning the MAC address for each attached station by
> monitoring traffic from each station. When a station sends a packet,
> the switch records which port the MAC address is connected to.
>
> With IPv4 net
Hi Russell,
On Wed, 20 Feb 2019 12:36:54 +, Russell King
wrote:
> Add support for the bridge flags to Marvell 88e6xxx bridges, allowing
> the multicast and unicast flood properties to be controlled. These
> can be controlled on a per-port basis via commands such as:
>
> bridge link s
On Wed, Feb 20, 2019 at 09:22:30AM -0800, Florian Fainelli wrote:
> On 2/20/19 2:32 AM, Russell King wrote:
> > When a DSA port is added to a bridge and brought up, the resulting STP
> > state programmed into the hardware depends on the order that these
> > operations are performed. However, the L
Hi Russell,
On Wed, 20 Feb 2019 12:36:48 +, Russell King
wrote:
> The Linux bridge implementation allows various properties of the bridge
> to be controlled, such as flooding unknown unicast and multicast frames.
> This patch adds the necessary DSA infrastructure to allow the Linux
> bridge
On Wed, Feb 20, 2019 at 12:23:55PM -0500, Vivien Didelot wrote:
> Hi Russell,
>
> On Wed, 20 Feb 2019 12:36:59 +, Russell King
> wrote:
> > Switches work by learning the MAC address for each attached station by
> > monitoring traffic from each station. When a station sends a packet,
> > the
Colin King wrote:
> From: Colin Ian King
>
> There is an uppercase 'N' that should be a lowercase 'n', fix this.
>
> Signed-off-by: Colin Ian King
Patch applied to wireless-drivers-next.git, thanks.
0421dd4167ec rtlwifi: rtl8192ce: fix typo, "PairwiseENcAlgorithm" ->
"PairwiseEncAlgorithm"
1 - 100 of 239 matches
Mail list logo
