Re: [PATCH v3 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

On Wed, Sep 05, 2018 at 04:50:35PM +0300, Leon Romanovsky wrote: > On Mon, Sep 03, 2018 at 07:13:16PM +0300, Arseny Maslennikov wrote: > > Signed-off-by: Arseny Maslennikov > > --- > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 38 +++ > > 1 file changed, 38 insertions(+) > >

Re: [PATCH v3 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

On Wed, Sep 05, 2018 at 04:47:27PM +0100, Stephen Hemminger wrote: > On Mon, 3 Sep 2018 19:13:16 +0300 > Arseny Maslennikov wrote: > > > + if (ndev->dev_id == ndev->dev_port) { > > + netdev_info_once(ndev, > > + "\"%s\" wants to know my dev_id. " > > +

Re: [PATCH net 3/3] tls: zero the crypto information from tls_context before freeing

2018-09-05, 13:48:48 +, Vakul Garg wrote: > > > > -Original Message- > > From: netdev-ow...@vger.kernel.org On > > Behalf Of Sabrina Dubroca > > Sent: Wednesday, September 5, 2018 6:52 PM > > To: netdev@vger.kernel.org > > Cc: Sabrina Dubroca ; Boris Pismenny > > ; Ilya Lesokhin ; Av

Re: [PATCH net 2/3] tls: clear key material from kernel memory when do_tls_setsockopt_conf fails

2018-09-05, 16:53:54 +0300, Boris Pismenny wrote: > Hi Sabrina, > > On 9/5/2018 4:21 PM, Sabrina Dubroca wrote: > > Fixes: 3c4d7559159b ("tls: kernel TLS support") > > Signed-off-by: Sabrina Dubroca > > --- > > net/tls/tls_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >

[PATCH net-next 08/13] net: sched: rename tcf_block_get{_ext}() and tcf_block_put{_ext}()

Functions tcf_block_get{_ext}() and tcf_block_put{_ext}() actually attach/detach block to specific Qdisc besides just taking/putting reference. Rename them according to their purpose. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- include/net/pkt_cls.h| 36 ++---

[PATCH net-next 02/13] net: sched: rename qdisc_destroy() to qdisc_put()

Current implementation of qdisc_destroy() decrements Qdisc reference counter and only actually destroy Qdisc if reference counter value reached zero. Rename qdisc_destroy() to qdisc_put() in order for it to better describe the way in which this function currently implemented and used. Extract code

[PATCH net-next 11/13] net: sched: implement tcf_block_get() and tcf_block_put()

Implement get/put function for blocks that only take/release the reference and perform deallocation. These functions are intended to be used by unlocked rules update path to always hold reference to block while working with it. They use on new fine-grained locking mechanisms introduced in previous

[PATCH net-next 05/13] net: sched: use Qdisc rcu API instead of relying on rtnl lock

As a preparation from removing rtnl lock dependency from rules update path, use Qdisc rcu and reference counting capabilities instead of relying on rtnl lock while working with Qdiscs. Create new tcf_block_release() function, and use it to free resources taken by tcf_block_find(). Currently, this f

[PATCH net-next 13/13] net: sched: add flags to Qdisc class ops struct

Extend Qdisc_class_ops with flags. Create enum to hold possible class ops flag values. Add first class ops flags value QDISC_CLASS_OPS_DOIT_UNLOCKED to indicate that class ops functions can be called without taking rtnl lock. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- include/net/sch_g

[PATCH net-next 12/13] net: sched: use reference counting for tcf blocks on rules update

In order to remove dependency on rtnl lock on rules update path, always take reference to block while using it on rules update path. Change tcf_block_get() error handling to properly release block with reference counting, instead of just destroying it, in order to accommodate potential concurrent u

[PATCH net-next 09/13] net: sched: extend tcf_block with rcu

Extend tcf_block with rcu to allow safe deallocation when it is accessed concurrently. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- include/net/sch_generic.h | 1 + net/sched/cls_api.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/net/sch_generi

[PATCH net-next 04/13] net: sched: add helper function to take reference to Qdisc

Implement function to take reference to Qdisc that relies on rcu read lock instead of rtnl mutex. Function only takes reference to Qdisc if reference counter isn't zero. Intended to be used by unlocked cls API. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- include/net/sch_generic.h | 13 +

[PATCH net-next 10/13] net: sched: protect block idr with spinlock

Protect block idr access with spinlock, instead of relying on rtnl lock. Take tn->idr_lock spinlock during block insertion and removal. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- net/sched/cls_api.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/ne

[PATCH net-next 00/13] Refactor classifier API to work with Qdisc/blocks without rtnl lock

Currently, all netlink protocol handlers for updating rules, actions and qdiscs are protected with single global rtnl lock which removes any possibility for parallelism. This patch set is a third step to remove rtnl lock dependency from TC rules update path. Recently, new rtnl registration flag RT

[PATCH net-next 03/13] net: sched: extend Qdisc with rcu

Currently, Qdisc API functions assume that users have rtnl lock taken. To implement rtnl unlocked classifiers update interface, Qdisc API must be extended with functions that do not require rtnl lock. Extend Qdisc structure with rcu. Implement special version of put function qdisc_put_unlocked() t

[PATCH net-next 07/13] net: sched: implement functions to put and flush all chains

Extract code that flushes and puts all chains on tcf block to two standalone function to be shared with functions that locklessly get/put reference to block. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- net/sched/cls_api.c | 55 + 1 fil

[PATCH net-next 06/13] net: sched: change tcf block reference counter type to refcount_t

As a preparation for removing rtnl lock dependency from rules update path, change tcf block reference counter type to refcount_t to allow modification by concurrent users. In block put function perform decrement and check reference counter once to accommodate concurrent modification by unlocked us

[PATCH net-next 01/13] net: core: netlink: add helper refcount dec and lock function

Rtnl lock is encapsulated in netlink and cannot be accessed by other modules directly. This means that reference counted objects that rely on rtnl lock cannot use it with refcounter helper function that atomically releases decrements reference and obtains mutex. This patch implements simple wrappe

Re: [PATCH net-next 03/13] net: sched: extend Qdisc with rcu

On 09/06/2018 12:58 AM, Vlad Buslov wrote: ... > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > index 18e22a5a6550..239c73f29471 100644 > --- a/include/net/sch_generic.h > +++ b/include/net/sch_generic.h > @@ -90,6 +90,7 @@ struct Qdisc { > struct gnet_stats_queue _

Re: [PATCH net-next 03/13] net: sched: extend Qdisc with rcu

On 06.09.2018 11:30, Eric Dumazet wrote: > > > On 09/06/2018 12:58 AM, Vlad Buslov wrote: > > ... > >> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h >> index 18e22a5a6550..239c73f29471 100644 >> --- a/include/net/sch_generic.h >> +++ b/include/net/sch_generic.h >> @@ -90,6

[PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

Some userspace applications need to know about IGMP joins from the kernel for 2 reasons: 1. To allow the programming of multicast MAC filters in hardware 2. To form a multicast FORUS list for non link-local multicast groups to be sent to the kernel and from there to the interested party. (1)

[PATCH net-next v3 2/2] netlink: ipv6 MLD join notifications

Some userspace applications need to know about MLD joins from the kernel for 2 reasons: 1. To allow the programming of multicast MAC filters in hardware 2. To form a multicast FORUS list for non link-local multicast groups to be sent to the kernel and from there to the interested party. (1) c

Re: [PATCH net-next 03/13] net: sched: extend Qdisc with rcu

On 09/06/2018 01:39 AM, Kirill Tkhai wrote: > On 06.09.2018 11:30, Eric Dumazet wrote: >> >> >> On 09/06/2018 12:58 AM, Vlad Buslov wrote: >> >> ... >> >>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h >>> index 18e22a5a6550..239c73f29471 100644 >>> --- a/include/net/sch_gen

Re: [PATCH net-next 03/13] net: sched: extend Qdisc with rcu

On Thu 06 Sep 2018 at 08:39, Kirill Tkhai wrote: > On 06.09.2018 11:30, Eric Dumazet wrote: >> >> >> On 09/06/2018 12:58 AM, Vlad Buslov wrote: >> >> ... >> >>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h >>> index 18e22a5a6550..239c73f29471 100644 >>> --- a/include/ne

Re: [PATCH net-next 03/13] net: sched: extend Qdisc with rcu

On 09/06/2018 02:23 AM, Vlad Buslov wrote: > > On Thu 06 Sep 2018 at 08:39, Kirill Tkhai wrote: >> On 06.09.2018 11:30, Eric Dumazet wrote: >>> >>> >>> On 09/06/2018 12:58 AM, Vlad Buslov wrote: >>> >>> ... >>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h index

Re: [PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

On 06.09.2018 08:24, Saeed Mahameed wrote: On Sun, Sep 2, 2018 at 2:55 AM, Konstantin Khlebnikov wrote: On 02.09.2018 12:29, Tariq Toukan wrote: On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote: XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. It seems not enough for RFS. All o

Re: [PATCH 1/7] fix hnode refcounting

On 2018-09-05 3:04 p.m., Al Viro wrote: From: Al Viro cls_u32.c misuses refcounts for struct tc_u_hnode - it counts references via ->hlist and via ->tp_root together. u32_destroy() drops the former and, in case when there had been links, leaves the sucker on the list. As the result, there's n

Re: [PATCH 2/7] mark root hnode explicitly

On 2018-09-05 3:04 p.m., Al Viro wrote: From: Al Viro ... and disallow deleting or linking to such Signed-off-by: Al Viro Same comment as other one in regards to subject Since the flag space is coming from htnode which is exposed via uapi it makes sense to keep this one here because it is

Re: [PATCH 3/7] make sure that divisor is a power of 2

On 2018-09-05 3:04 p.m., Al Viro wrote: From: Al Viro Signed-off-by: Al Viro Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH 2/7] mark root hnode explicitly

On 2018-09-06 6:28 a.m., Jamal Hadi Salim wrote: On 2018-09-05 3:04 p.m., Al Viro wrote: From: Al Viro ... and disallow deleting or linking to such Signed-off-by: Al Viro Same comment as other one in regards to subject Since the flag space is coming from htnode which is exposed via uapi i

Re: [PATCH 5/7] get rid of tc_u_knode ->tp

On 2018-09-05 3:04 p.m., Al Viro wrote: From: Al Viro not used anymore Signed-off-by: Al Viro Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH 4/7] get rid of unused argument of u32_destroy_key()

On 2018-09-05 3:04 p.m., Al Viro wrote: From: Al Viro Signed-off-by: Al Viro Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH 6/7] get rid of tc_u_common ->rcu

On 2018-09-05 3:04 p.m., Al Viro wrote: From: Al Viro unused Signed-off-by: Al Viro Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH 7/7] clean tc_u_common hashtable

On 2018-09-05 3:04 p.m., Al Viro wrote: From: Al Viro * calculate key *once*, not for each hash chain element * let tc_u_hash() return the pointer to chain head rather than index - callers are cleaner that way. Signed-off-by: Al Viro Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH iproute2] tc/mqprio: Print extra info on invalid args.

On Wed, 5 Sep 2018 13:24:19 -0700 Caleb Raitto wrote: > From: Caleb Raitto > > Print the name of the argument that wasn't understood, and also print > the usage string. > > Signed-off-by: Caleb Raitto The standard code pattern in iproute2 is to use invarg(). Why not use that?

Re: [PATCH 2/7] mark root hnode explicitly

And a bunch of indentations... cheers, jamal diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 6d45ec4c218c..cb3bee12af78 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -485,7 +485,8 @@ static void u32_clear_hw_hnode(struct tcf_proto *tp, struct tc_u_hnode *h, struct

Re: [PATCH 2/7] mark root hnode explicitly

On Thu, Sep 06, 2018 at 06:34:00AM -0400, Jamal Hadi Salim wrote: > On 2018-09-06 6:28 a.m., Jamal Hadi Salim wrote: > > On 2018-09-05 3:04 p.m., Al Viro wrote: > > > From: Al Viro > > > > > > ... and disallow deleting or linking to such > > > > > > Signed-off-by: Al Viro > > > > Same comment

Re: [PATCH 2/7] mark root hnode explicitly

On 2018-09-06 6:59 a.m., Al Viro wrote: On Thu, Sep 06, 2018 at 06:34:00AM -0400, Jamal Hadi Salim wrote: On 2018-09-06 6:28 a.m., Jamal Hadi Salim wrote: [..] Point, and that one is IMO enough to give up on using ->flags for that. How about simply diff --git a/net/sched/cls_u32.c b/net/sc

[PATCH net-next] liquidio CN23XX: Remove set but not used variable 'ring_flag'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c: In function 'cn23xx_setup_octeon_vf_device': drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c:619:20: warning: variable 'ring_flag' set but not used [-Wunused-but-set-variable] Signed-

Re: [PATCH net-next] net: sched: change tcf_del_walker() to use concurrent-safe delete

On Wed 05 Sep 2018 at 20:32, Cong Wang wrote: > On Wed, Sep 5, 2018 at 12:05 AM Vlad Buslov wrote: >> >> >> On Tue 04 Sep 2018 at 22:41, Cong Wang wrote: >> > On Mon, Sep 3, 2018 at 1:33 PM Vlad Buslov wrote: >> >> >> >> >> >> On Mon 03 Sep 2018 at 18:50, Cong Wang wrote: >> >> > On Mon, Sep

Re: [PATCH net-next v1] net/tls: Set count of SG entries if sk_alloc_sg returns -ENOSPC

2018-09-05, 21:57:43 +0530, Vakul Garg wrote: > tls_sw_sendmsg() allocates plaintext and encrypted SG entries using > function sk_alloc_sg(). In case the number of SG entries hit > MAX_SKB_FRAGS, sk_alloc_sg() returns -ENOSPC and sets the variable for > current SG index to '0'. This leads to callin

[PATCH net-next] net: stmmac: Enable TC Ops for GMAC >= 4

GMAC >= 4 also supports CBS. Lets enable the TC Ops for these versions. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/hwif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

Re: [iproute PATCH] ip-route: Fix segfault with many nexthops

Hi, On Tue, Sep 04, 2018 at 07:15:44PM +0200, Phil Sutter wrote: [...] > diff --git a/ip/iproute.c b/ip/iproute.c > index 30833414a3f7f..9e5ae48c0715c 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c [...] > @@ -1036,15 +1044,18 @@ static int parse_nexthops(struct nlmsghdr *n, struct > rtmsg *r,

Re: [PATCH v3 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

On Thu, Sep 06, 2018 at 10:26:56AM +0300, Arseny Maslennikov wrote: > On Wed, Sep 05, 2018 at 04:47:27PM +0100, Stephen Hemminger wrote: > > On Mon, 3 Sep 2018 19:13:16 +0300 > > Arseny Maslennikov wrote: > > > > > + if (ndev->dev_id == ndev->dev_port) { > > > + netdev_info_once(ndev, > >

[PATCH net] net/ipv6: fix incorrect fib6 gateway info after do redirect

When receive a redirect message and call rt6_do_redirect(), we allocate a new rt6_info and set new flags and gateway info, but not update these info to fib6_info. Then if a user try to get the route info via `ip route get`, he will still get the old default gateway, because inet6_rtm_getroute() ge

Re: [PATCH iproute2] bridge/mdb: fix missing new line when show bridge mdb

On Wed, 5 Sep 2018 11:33:43 +0800 Hangbin Liu wrote: > The bridge mdb show is broken on current iproute2. e.g. > ]# bridge mdb show > 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp > > After fix: > ]# bridge mdb show > 34: br0 veth0_br 224.1.1.2 temp > 34: br0 veth0_b

Re: [PATCH v3 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

On Thu, Sep 06, 2018 at 10:04:33AM +0300, Arseny Maslennikov wrote: > On Wed, Sep 05, 2018 at 04:50:35PM +0300, Leon Romanovsky wrote: > > On Mon, Sep 03, 2018 at 07:13:16PM +0300, Arseny Maslennikov wrote: > > > Signed-off-by: Arseny Maslennikov > > > --- > > > drivers/infiniband/ulp/ipoib/ipoib

[PATCH net-next v2 1/7] net: aquantia: fix hw_atl_utils_fw_upload_dwords

From: Yana Esina This patch fixes the upload function, which worked incorrectly with some chips. Signed-off-by: Yana Esina Signed-off-by: Nikita Danilov Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- .../ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c | 8 + .../ethernet/aqu

[PATCH net-next v2 3/7] net: aquantia: implement WOL support

From: Yana Esina Add WOL support. Currently only magic packet (ethtool -s wol g) feature is implemented. Remove hw_set_power and move that to FW_OPS set_power: because WOL configuration behaves differently on 1x and 2x firmwares Signed-off-by: Yana Esina Signed-off-by: Nikita Danilov Tested-

[PATCH net-next v2 2/7] net: aquantia: definitions for WOL

From: Yana Esina Added definitions and structures needed to support WOL. Signed-off-by: Yana Esina Signed-off-by: Nikita Danilov Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_nic.h| 3 + .../aquantia/atlantic/hw_atl/hw_atl_utils.h

[PATCH net-next v2 7/7] net: aquantia: bump driver version

Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/ver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h index 94efc6477bdc..b48260114da3 100644 --- a/drivers/net/

[PATCH net-next v2 6/7] net: aquantia: renaming for better visibility

From: Nikita Danilov Removed extra characters from the names of structures to unify prefixes used through the driver code (we normally use hw_atl for hw specifics). HW_ATL_B0_ and HW_ATL_A0_ are the same and useless copies. Signed-off-by: Nikita Danilov Signed-off-by: Igor Russkikh --- driver

[PATCH net-next v2 0/7] net: aquantia: implement WOL and EEE support

This is v2 of WOL/EEE functionality patch for atlantic driver. Sorry for long gap, I was on vacation. In this patchset Yana Esina and Nikita Danilov implemented: - Upload function to interact with FW memory - Definitions and structures necessary for the correct operation of Wake ON Lan - The func

[PATCH net-next v2 5/7] net: aquantia: whitespace changes

From: Nikita Danilov Removed extra spaces, corrected alignment. Signed-off-by: Nikita Danilov Signed-off-by: Igor Russkikh --- .../net/ethernet/aquantia/atlantic/aq_ethtool.c| 4 +-- drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 12 drivers/net/ethernet/aquantia/atlantic/

[PATCH net-next v2 4/7] net: aquantia: implement EEE support

From: Yana Esina Support of Energy-Efficient Ethernet to aQuantia NIC's via ethtool (according to the IEEE 802.3az specifications) Signed-off-by: Yana Esina Signed-off-by: Nikita Danilov Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_com

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

Hey guys, I finally got some time to do a bisect and we narrowed the problem down to: b838d5e1c5b6e57b10ec8af2268824041e3ea911 is the first bad commit commit b838d5e1c5b6e57b10ec8af2268824041e3ea911 Author: Wei Wang Date: Sat Jun 17 10:42:32 2017 -0700 ipv4: mark DST_NOGC and remove the o

Re: [PATCH net-next v2 2/7] net: aquantia: definitions for WOL

On Thu, Sep 06, 2018 at 04:05:57PM +0300, Igor Russkikh wrote: > From: Yana Esina Hi Igor, Yana > @@ -134,13 +132,36 @@ struct __packed hw_aq_atl_utils_fw_rpc { > u32 pattern_offset; > u32 pattern_size; >

[iproute PATCH v2] ip-route: Fix segfault with many nexthops

It was possible to crash ip-route by adding an IPv6 route with 37 nexthop statements. A simple reproducer is: | for i in `seq 37`; do | nhs="nexthop via ::$i "$nhs | done | ip -6 route add ::/64 $nhs The related code was broken in multiple ways: * parse_one_nh() assumed that rta po

Re: [PATCH net-next v2 3/7] net: aquantia: implement WOL support

On Thu, Sep 06, 2018 at 04:05:58PM +0300, Igor Russkikh wrote: > From: Yana Esina > > Add WOL support. Currently only magic packet > (ethtool -s wol g) feature is implemented. > > Remove hw_set_power and move that to FW_OPS set_power: > because WOL configuration behaves differently on 1x and 2x

Re: [PATCH net-next v2 5/7] net: aquantia: whitespace changes

On Thu, Sep 06, 2018 at 04:06:00PM +0300, Igor Russkikh wrote: > From: Nikita Danilov > > Removed extra spaces, corrected alignment. > > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 01/17] asm: simd context helper API

On Sat, 1 Sep 2018, Jason A. Donenfeld wrote: > On Sat, Sep 1, 2018 at 2:32 PM Andy Lutomirski wrote: > > I tend to think the right approach is to merge Jason's code and then > > make it better later. Even with a totally perfect lazy FPU restore > > implementation on x86, we'll probably still nee

Re: [PATCH net-next v2 6/7] net: aquantia: renaming for better visibility

On Thu, Sep 06, 2018 at 04:06:01PM +0300, Igor Russkikh wrote: > From: Nikita Danilov > > Removed extra characters from the names of structures to unify prefixes > used through the driver code (we normally use hw_atl for hw specifics). > HW_ATL_B0_ and HW_ATL_A0_ are the same and useless copies.

Re: [PATCH net-next v2 3/7] net: aquantia: implement WOL support

On Thu, Sep 06, 2018 at 04:05:58PM +0300, Igor Russkikh wrote: > From: Yana Esina > > Add WOL support. Currently only magic packet > (ethtool -s wol g) feature is implemented. > > Remove hw_set_power and move that to FW_OPS set_power: > because WOL configuration behaves differently on 1x and 2x

[PATCH] tcp: really ignore MSG_ZEROCOPY if no SO_ZEROCOPY

According to the documentation in msg_zerocopy.rst, the SO_ZEROCOPY flag was introduced because send(2) ignores unknown message flags and any legacy application which was accidentally passing the equivalent of MSG_ZEROCOPY earlier should not see any new behaviour. Before commit f214f915e7db ("tcp:

[PATCH v2 net-next 0/4] net: batched receive in GRO path

This series listifies part of GRO processing, in a manner which allows those packets which are not GROed (i.e. for which dev_gro_receive returns GRO_NORMAL) to be passed on to the listified regular receive path. I have not listified dev_gro_receive() itself, or the per-protocol GRO callback, sin

[PATCH v2 net-next 1/4] net: introduce list entry point for GRO

Also export napi_frags_skb() so that drivers using the napi_gro_frags() interface can prepare their SKBs properly for submitting on such a list. Signed-off-by: Edward Cree --- include/linux/netdevice.h | 2 ++ net/core/dev.c| 28 +++- 2 files changed, 29 ins

[PATCH v2 net-next 3/4] net: make listified RX functions return number of good packets

Signed-off-by: Edward Cree --- include/linux/netdevice.h | 4 +-- include/net/ip.h | 4 +-- include/net/ipv6.h| 4 +-- net/core/dev.c| 63 +-- net/ipv4/ip_input.c | 39 ++--- net/ipv6/ip6_inp

[PATCH v2 net-next 4/4] net/core: handle GRO_NORMAL skbs as a list in napi_gro_receive_list

Allows GRO-using drivers to get the benefits of batching for non-GROable traffic. Signed-off-by: Edward Cree --- net/core/dev.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 69e2819994e4..9a937d2ac83b 100644 --- a/

[PATCH v2 net-next 2/4] sfc: use batched receive for GRO

Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/efx.c| 11 +-- drivers/net/ethernet/sfc/net_driver.h | 1 + drivers/net/ethernet/sfc/rx.c | 16 +--- 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/driver

Re: [PATCH net] net/ipv6: fix incorrect fib6 gateway info after do redirect

On 9/6/18 6:57 AM, Hangbin Liu wrote: > When receive a redirect message and call rt6_do_redirect(), we allocate > a new rt6_info and set new flags and gateway info, but not update these > info to fib6_info. > > Then if a user try to get the route info via `ip route get`, he will still > get the ol

Re: [PATCH net-next] qed*: Utilize FW 8.37.7.0

From: Denis Bolotin Date: Wed, 5 Sep 2018 18:35:55 +0300 > This patch adds a new qed firmware with fixes and support for new features. > > Fixes: > - Fix a rare case of device crash with iWARP, iSCSI or FCoE offload. > - Fix GRE tunneled traffic when iWARP offload is enabled. > - Fix RoCE failur

[PATCH v4 2/3] IB/ipoib: Use dev_port to expose network interface port numbers

Some InfiniBand network devices have multiple ports on the same PCI function. This initializes the `dev_port' sysfs field of those network interfaces with their port number. Prior to this the kernel erroneously used the `dev_id' sysfs field of those network interfaces to convey the port number to

Re: [PATCH net-next v3 0/5] net: dsa: b53: SerDes support

From: Florian Fainelli Date: Wed, 5 Sep 2018 12:42:10 -0700 > This patch series adds support for the SerDes found on NorthStar Plus > (NSP) which allows us to use the SFP port on the BCM958625HR board (and > other similar designs). > > Changes in v3: > > - properly hunk the request_threaded_ir

[PATCH v4 0/3] IB/ipoib: Use dev_port to disambiguate port numbers

Pre-3.15 userspace had trouble distinguishing different ports of a NIC on a single PCI bus/device/function. To solve this, a sysfs field `dev_port' was introduced quite a while ago (commit v3.14-rc3-739-g3f85944fe207), and some relevant device drivers were fixed to use it, but not in case of IPoIB.

[PATCH v4 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

Some tools may currently be using only the deprecated attribute; let's print an elaborate and clear deprecation notice to kmsg. To do that, we have to replace the whole sysfs file, since we inherit the original one from netdev. Signed-off-by: Arseny Maslennikov --- drivers/infiniband/ulp/ipoib/

[PATCH v4 1/3] Documentation/ABI: document /sys/class/net/*/dev_port

The sysfs field was introduced 4 years ago along with fixes to various drivers that erroneously used `dev_id' for that purpose, but it was not properly documented anywhere. See commit v3.14-rc3-739-g3f85944fe207. Signed-off-by: Arseny Maslennikov --- Documentation/ABI/testing/sysfs-class-net | 1

Re: [pull request][net 00/10] Mellanox, mlx5 fixes 2018-09-05

From: Saeed Mahameed Date: Wed, 5 Sep 2018 21:09:42 -0700 > This pull request contains some fixes for mlx5 etherent netdevice and > core driver. Pulled. > > For -stable v4.9: > ('net/mlx5: Fix debugfs cleanup in the device init/remove flow') > > For -stable v4.12: > ("net/mlx5: E-Switch, Fix

[PATCH iproute2 1/3] bridge: minor change to mdb print

Get port ifname once rather than on both sides of if(is_json_context). Signed-off-by: Stephen Hemminger --- bridge/mdb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bridge/mdb.c b/bridge/mdb.c index f38dc67c849a..9bdef0262c54 100644 --- a/bridge/mdb.c +++ b/bridge/m

[PATCH iproute2 3/3] bridge: fix vlan show formatting

The output of vlan show was broken previous change to use json_print. Clean the code up and return to original format. Note: the JSON syntax has changed to make the bridge vlan show more like other outputs (e.g. ip -j li show). Signed-off-by: Stephen Hemminger --- bridge/br_common.h | 2 +- br

[PATCH iproute2 2/3] bridge: use print_json for some outputs

Rather than using is_json_context(), use the print_string functions which handle both cases. Signed-off-by: Stephen Hemminger --- bridge/mdb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/bridge/mdb.c b/bridge/mdb.c index 9bdef0262c54..cc1b4547865c 100644 --- a

[PATCH net-next] net: sched: cls_flower: dump offload count value

Change flower in_hw_count type to fixed-size u32 and dump it as TCA_FLOWER_IN_HW_COUNT. This change is necessary to properly test shared blocks and re-offload functionality. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- include/net/sch_generic.h| 2 +- include/uapi/linux/pkt_cls.h | 2

[PATCH net-next, net v2] net/tls: Set count of SG entries if sk_alloc_sg returns -ENOSPC

tls_sw_sendmsg() allocates plaintext and encrypted SG entries using function sk_alloc_sg(). In case the number of SG entries hit MAX_SKB_FRAGS, sk_alloc_sg() returns -ENOSPC and sets the variable for current SG index to '0'. This leads to calling of function tls_push_record() with 'sg_encrypted_num

Re: [PATCH mlx5-next v1 05/15] net/mlx5: Break encap/decap into two separated flow table creation flags

On Thu, Sep 6, 2018 at 7:09 AM, Leon Romanovsky wrote: > On Thu, Sep 06, 2018 at 12:37:17AM +0300, Or Gerlitz wrote: >> On Wed, Sep 5, 2018 at 9:11 PM, Leon Romanovsky wrote: >> > On Wed, Sep 05, 2018 at 10:38:00AM -0600, Jason Gunthorpe wrote: >> >> On Wed, Sep 05, 2018 at 08:10:25AM +0300, Leon

[PATCH net] ip: frags: fix crash in ip_do_fragment()

A kernel crash occurrs when defragmented packet is fragmented in ip_do_fragment(). In defragment routine, skb_orphan() is called and skb->ip_defrag_offset is set. but skb->sk and skb->ip_defrag_offset are same union member. so that frag->sk is not NULL. Hence crash occurrs in skb->sk check routine

Re: [bpf-next V2 PATCH 0/3] XDP micro optimizations for redirect

On Mon, Sep 03, 2018 at 09:54:52AM +0200, Jesper Dangaard Brouer wrote: > This patchset contains XDP micro optimizations for the redirect core. > These are not functional changes. The optimizations revolve around > getting the compiler to layout the code in a way that reflect how XDP > redirect is

Re: [PATCH net] ip: frags: fix crash in ip_do_fragment()

On Thu, Sep 6, 2018 at 10:51 AM Taehee Yoo wrote: > > A kernel crash occurrs when defragmented packet is fragmented > in ip_do_fragment(). > In defragment routine, skb_orphan() is called and > skb->ip_defrag_offset is set. but skb->sk and > skb->ip_defrag_offset are same union member. so that > fr

Re: [PATCH bpf-next 0/4] tools/bpf: add bpftool net support

On Wed, Sep 05, 2018 at 04:58:02PM -0700, Yonghong Song wrote: > As bpf usage becomes more pervasive, people starts to worry > about their cpu and memory cost. On a particular host, > people often wanted to know all running bpf programs > and their attachment context. So they can relate > a perform

Re: [PATCH net] ip: frags: fix crash in ip_do_fragment()

On Thu, Sep 6, 2018 at 11:06 AM Eric Dumazet wrote: > > On Thu, Sep 6, 2018 at 10:51 AM Taehee Yoo wrote: > > > > A kernel crash occurrs when defragmented packet is fragmented > > in ip_do_fragment(). > > In defragment routine, skb_orphan() is called and > > skb->ip_defrag_offset is set. but skb-

Re: [PATCH net] ip: frags: fix crash in ip_do_fragment()

2018-09-07 3:23 GMT+09:00 Eric Dumazet : > On Thu, Sep 6, 2018 at 11:06 AM Eric Dumazet wrote: >> >> On Thu, Sep 6, 2018 at 10:51 AM Taehee Yoo wrote: >> > >> > A kernel crash occurrs when defragmented packet is fragmented >> > in ip_do_fragment(). >> > In defragment routine, skb_orphan() is call

Re: [PATCH] tcp: really ignore MSG_ZEROCOPY if no SO_ZEROCOPY

On Thu, Sep 6, 2018 at 9:58 AM Vincent Whitchurch wrote: > > According to the documentation in msg_zerocopy.rst, the SO_ZEROCOPY > flag was introduced because send(2) ignores unknown message flags and > any legacy application which was accidentally passing the equivalent of > MSG_ZEROCOPY earlier

Re: [PATCH net-next] net: sched: change tcf_del_walker() to use concurrent-safe delete

On Thu, Sep 6, 2018 at 4:14 AM Vlad Buslov wrote: > > Isn't a concurrent tcf_idr_check_alloc() able to livelock here with > > your change? > > > > idr_for_each_entry_ul{ > >spin_lock(&idrinfo->lock); > >idr_remove(); > >spin_unlock(&idrinfo->lock); > > // tcf_idr_check_alloc() ju

[PATCH iproute2 v2] tc/mqprio: Print extra info on invalid args.

From: Caleb Raitto Print the name of the argument that wasn't understood. Signed-off-by: Caleb Raitto --- tc/q_mqprio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c index 89b46002..7cd18ae1 100644 --- a/tc/q_mqprio.c +++ b/tc/q_mqprio.c @@

Re: [PATCH v2 net-next 7/7] net: dsa: Add Lantiq / Intel DSA driver for vrx200

On 09/03/2018 09:54 PM, Florian Fainelli wrote: > > > On 9/1/2018 5:05 AM, Hauke Mehrtens wrote: >> This adds the DSA driver for the GSWIP Switch found in the VRX200 SoC. >> This switch is integrated in the DSL SoC, this SoC uses a GSWIP version >> 2.1, there are other SoCs using different versio

Re: [PATCH v2 net-next 7/7] net: dsa: Add Lantiq / Intel DSA driver for vrx200

On 09/06/2018 02:11 PM, Hauke Mehrtens wrote: > On 09/03/2018 09:54 PM, Florian Fainelli wrote: >> >> >> On 9/1/2018 5:05 AM, Hauke Mehrtens wrote: >>> This adds the DSA driver for the GSWIP Switch found in the VRX200 SoC. >>> This switch is integrated in the DSL SoC, this SoC uses a GSWIP version

[Patch net] net_sched: properly cancel netlink dump on failure

When nla_put*() fails after nla_nest_start(), we need to call nla_nest_cancel() to cancel the message, otherwise we end up calling nla_nest_end() like a success. Fixes: 0ed5269f9e41 ("net/sched: add tunnel option support to act_tunnel_key") Cc: Davide Caratti Cc: Simon Horman Signed-off-by: Cong

Re: [pull request][net-next 0/9] Mellanox, mlx5 ethernet updates 2018-09-05

From: Saeed Mahameed Date: Wed, 5 Sep 2018 21:33:22 -0700 > This pull request provides some updates to mlx5 ethernet driver. > > For more information please see tag log below. > > Please pull and let me know if there's any problem. Pulled, thank you.

Re: [PATCH net-next] liquidio: Add spoof checking on a VF MAC address

From: Felix Manlunas Date: Wed, 5 Sep 2018 18:40:56 -0700 > From: Weilin Chang > > 1. Provide the API to set/unset the spoof checking feature. > 2. Add a function to periodically provide the count of found >packets with spoof VF MAC address. > 3. Prevent VF MAC address changing while the sp

Re: [PATCH net-next] liquidio CN23XX: Remove set but not used variable 'ring_flag'

From: YueHaibing Date: Thu, 6 Sep 2018 11:22:09 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c: In function > 'cn23xx_setup_octeon_vf_device': > drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c:619:20: warning: > variab

Re: [RFC PATCH bpf-next v2 0/4] Implement bpf queue/stack maps

On Fri, Aug 31, 2018 at 11:25:48PM +0200, Mauricio Vasquez B wrote: > In some applications this is needed have a pool of free elements, like for > example the list of free L4 ports in a SNAT. None of the current maps allow > to do it as it is not possibleto get an any element without having they k

Re: [PATCH iproute2] bridge/mdb: fix missing new line when show bridge mdb

Hi Stephen, On Thu, Sep 06, 2018 at 02:00:53PM +0100, Stephen Hemminger wrote: > > @@ -164,6 +168,10 @@ static void print_mdb_entry(FILE *f, int ifindex, > > const struct br_mdb_entry *e, > > print_string(PRINT_ANY, "timer", " %s", > > format_timer(timer)); > >

  1   2   >