On Thu, Sep 06, 2018 at 04:05:58PM +0300, Igor Russkikh wrote: > From: Yana Esina <yana.es...@aquantia.com> > > Add WOL support. Currently only magic packet > (ethtool -s <ethX> wol g) feature is implemented. > > Remove hw_set_power and move that to FW_OPS set_power: > because WOL configuration behaves differently on 1x and 2x > firmwares
Hi Igor, Yana It looks like the set_power refactor could of been a patch of its own. Then add the WOL support as a second patch. In the future, try to make a patch do one thing, and only one thing. It makes them easier to review. Andrew
