Re: [PATCH] rtnetlink: expose value from SET_NETDEV_DEVTYPE via IFLA_DEVTYPE attribute

2018-08-29 Thread Jiri Pirko
Tue, Aug 28, 2018 at 10:58:11PM CEST, mar...@holtmann.org wrote: >The name value from SET_NETDEV_DEVTYPE only ended up in the uevent sysfs >file as DEVTYPE= information. To avoid any kind of race conditions >between netlink messages and reading from sysfs, it is useful to add the >same string as ne

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-29 Thread Jason Wang
On 2018年08月29日 03:57, Willem de Bruijn wrote: On Mon, Jul 30, 2018 at 2:06 AM Jason Wang wrote: On 2018年07月25日 08:17, Jon Olson wrote: On Tue, Jul 24, 2018 at 3:46 PM Michael S. Tsirkin wrote: On Tue, Jul 24, 2018 at 06:31:54PM -0400, Willem de Bruijn wrote: On Tue, Jul 24, 2018 at 6:2

[PATCH net v2 0/2] net_sched: reject unknown tcfa_action values

2018-08-29 Thread Paolo Abeni
As agreed some time ago, this changeset reject unknown tcfa_action values, instead of changing such values under the hood. A tdc test is included to verify the new behavior. v1 -> v2: - helper is now static and renamed according to act_* convention - updated extack message, according to the new

[PATCH net v2 2/2] tc-testing: add test-cases for numeric and invalid control action

2018-08-29 Thread Paolo Abeni
Only the police action allows us to specify an arbitrary numeric value for the control action. This change introduces an explicit test case for the above feature and then leverage it for testing the kernel behavior for invalid control actions (reject). Signed-off-by: Paolo Abeni --- .../tc-testi

[PATCH net v2 1/2] net_sched: reject unknown tcfa_action values

2018-08-29 Thread Paolo Abeni
After the commit 802bfb19152c ("net/sched: user-space can't set unknown tcfa_action values"), unknown tcfa_action values are converted to TC_ACT_UNSPEC, but the common agreement is instead rejecting such configurations. This change also introduces a helper to simplify the destruction of a single a

Re: [PATCH net] vti6: remove !skb->ignore_df check from vti6_xmit()

2018-08-29 Thread Steffen Klassert
On Thu, Aug 23, 2018 at 07:49:54PM +0300, Alexey Kodanev wrote: > Before the commit d6990976af7c ("vti6: fix PMTU caching and reporting > on xmit") '!skb->ignore_df' check was always true because the function > skb_scrub_packet() was called before it, resetting ignore_df to zero. > > In the commit

Re: [PATCH ipsec-next] xfrm: allow driver to quietly refuse offload

2018-08-29 Thread Steffen Klassert
On Wed, Aug 22, 2018 at 02:38:10PM -0700, Shannon Nelson wrote: > If the "offload" attribute is used to create an IPsec SA > and the .xdo_dev_state_add() fails, the SA creation fails. > However, if the "offload" attribute is used on a device that > doesn't offer it, the attribute is quietly ignored

Re: [PATCH net v2 1/2] net_sched: reject unknown tcfa_action values

2018-08-29 Thread Jiri Pirko
Wed, Aug 29, 2018 at 10:22:33AM CEST, pab...@redhat.com wrote: >After the commit 802bfb19152c ("net/sched: user-space can't set >unknown tcfa_action values"), unknown tcfa_action values are >converted to TC_ACT_UNSPEC, but the common agreement is instead >rejecting such configurations. > >This chan

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-29 Thread Eelco Chaudron
On 23 Aug 2018, at 20:14, Jakub Kicinski wrote: On Mon, 20 Aug 2018 16:03:40 +0200, Eelco Chaudron wrote: On 17 Aug 2018, at 13:27, Jakub Kicinski wrote: On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote: On 11 Aug 2018, at 21:06, David Miller wrote: From: Jakub Kicinski Date: Th

Re: [PATCH 2/3] IB/ipoib: Stop using dev_id to expose port numbers

2018-08-29 Thread Sergei Shtylyov
Hello! On 8/29/2018 12:01 AM, Arseny Maslennikov wrote: Some InfiniBand network devices have multiple ports on the same PCI function. Prior to this the kernel erroneously used the `dev_id' sysfs field of those network interfaces to convey the port number to userspace. `dev_id' is currently res

[PATCH net 0/2] igmp: fix two incorrect unsolicit report count issues

2018-08-29 Thread Hangbin Liu
Just like the subject, fix two minor igmp unsolicit report count issues. Hangbin Liu (2): igmp: fix incorrect unsolicit report count when join group igmp: fix incorrect unsolicit report count after link down and up net/ipv4/igmp.c | 11 --- 1 file changed, 4 insertions(+), 7 deletion

[PATCH net 2/2] igmp: fix incorrect unsolicit report count after link down and up

2018-08-29 Thread Hangbin Liu
After link down and up, i.e. when call ip_mc_up(), we doesn't init im->unsolicit_count. So after igmp_timer_expire(), we will not start timer again and only send one unsolicit report at last. Fix it by initializing im->unsolicit_count in igmp_group_added(), so we can respect igmp robustness value.

[PATCH net 2/2] igmp: fix incorrect unsolicit report count after link down and up

2018-08-29 Thread Hangbin Liu
After link down and up, i.e. when call ip_mc_up(), we doesn't init im->unsolicit_count. So after igmp_timer_expire(), we will not start timer again and only send one unsolicit report at last. Fix it by initializing im->unsolicit_count in igmp_group_added(), so we can respect igmp robustness value.

[PATCH net 1/2] igmp: fix incorrect unsolicit report count when join group

2018-08-29 Thread Hangbin Liu
We should not start timer if im->unsolicit_count equal to 0 after decrease. Or we will send one more unsolicit report message. i.e. 3 instead of 2 by default. Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2") Signed-off-by: Hangbin Liu --- net/ipv4/igmp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 de

[PATCH net 1/2] igmp: fix incorrect unsolicit report count when join group

2018-08-29 Thread Hangbin Liu
We should not start timer if im->unsolicit_count equal to 0 after decrease. Or we will send one more unsolicit report message. i.e. 3 instead of 2 by default. Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2") Signed-off-by: Hangbin Liu --- net/ipv4/igmp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 de

[RFC net-next] veth: report NEWLINK event when moving the peer device in a new namespace

2018-08-29 Thread Lorenzo Bianconi
When moving a veth device to another namespace, userspace receives a RTM_DELLINK message indicating the device has been removed from current netns. However, the other peer does not receive a netlink event containing new values for IFLA_LINK_NETNSID and IFLA_LINK veth attributes. Fix that behaviour

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-29 Thread Paolo Abeni
On Thu, 2018-08-23 at 20:14 +0200, Jakub Kicinski wrote: > I asked Louis to run some tests while I'm travelling, and he reports > that my worry about reporting the extra stats was unfounded. Update > function does not show up in traces at all. It seems under stress > (generated with stress-ng) th

Re: [PATCH net 0/2] igmp: fix two incorrect unsolicit report count issues

2018-08-29 Thread Hangbin Liu
Opps, sent two duplicate mails by mistake. Please ignore the duplicate messages. Sorry. On Wed, Aug 29, 2018 at 06:06:07PM +0800, Hangbin Liu wrote: > Just like the subject, fix two minor igmp unsolicit report count issues. > > Hangbin Liu (2): > igmp: fix incorrect unsolicit report count when

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_transport_get_next

2018-08-29 Thread Neil Horman
On Wed, Aug 29, 2018 at 12:08:40AM +0800, Xin Long wrote: > On Mon, Aug 27, 2018 at 9:08 PM Neil Horman wrote: > > > > On Mon, Aug 27, 2018 at 06:38:31PM +0800, Xin Long wrote: > > > As Marcelo noticed, in sctp_transport_get_next, it is iterating over > > > transports but then also accessing the a

Kernel Panic on high bandwidth transfer over wifi

2018-08-29 Thread Nathaniel Munk
Hi all, I'm running Arch Linux on kernel 4.18.5 (same issue on both arch-provided kernel and mainline built-from-source). There is an issue whereby the kernel crashes when transferring at high bandwidths (approx 6mB/s) over a specific wifi connection. I can only reproduce the issue when using th

Re: Kernel Panic on high bandwidth transfer over wifi

2018-08-29 Thread Willy Tarreau
On Wed, Aug 29, 2018 at 11:42:44AM +, Nathaniel Munk wrote: > As you can see from the attached log You apparently forgot to attach the log. Willy

Re: Kernel Panic on high bandwidth transfer over wifi

2018-08-29 Thread Nathaniel Munk
Of course I did, sorry. --- Nathaniel Munk nathan...@munk.com.au 0435 726 099 ‐‐‐ Original Message ‐‐‐ On August 29, 2018 10:09 PM, Willy Tarreau wrote: > On Wed, Aug 29, 2018 at 11:42:44AM +, Nathaniel Munk wrote: > > > As you can see from the attached log > > You a

Re: [PATCH bpf-next 11/11] samples/bpf: add -c/--copy -z/--zero-copy flags to xdpsock

2018-08-29 Thread Jesper Dangaard Brouer
On Tue, 28 Aug 2018 14:44:35 +0200 Björn Töpel wrote: > From: Björn Töpel > > The -c/--copy -z/--zero-copy flags enforces either copy or zero-copy > mode. Nice, thanks for adding this. It allows me to quickly test the difference between normal-copy vs zero-copy modes. (Kernel bpf-next without

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-29 Thread Willem de Bruijn
On Wed, Aug 29, 2018 at 3:56 AM Jason Wang wrote: > > > > On 2018年08月29日 03:57, Willem de Bruijn wrote: > > On Mon, Jul 30, 2018 at 2:06 AM Jason Wang wrote: > >> > >> > >> On 2018年07月25日 08:17, Jon Olson wrote: > >>> On Tue, Jul 24, 2018 at 3:46 PM Michael S. Tsirkin > >>> wrote: > On Tue

[iproute PATCH] iprule: Fix for incorrect space between dst and prefix

2018-08-29 Thread Phil Sutter
This was added by accident when introducing JSON support. Fixes: 0dd4ccc56c0e3 ("iprule: add json support") Signed-off-by: Phil Sutter --- ip/iprule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iprule.c b/ip/iprule.c index 8b9421431c26a..744d6d88e3433 100644 --- a/ip/

[PATCH] ieee802154: mcr20a: read out of bounds in mcr20a_set_channel()

2018-08-29 Thread Dan Carpenter
The "channel" variable can be any u8 value. We need to make sure we don't read outside of the PLL_INT[] or PLL_FRAC[] arrays. Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") Signed-off-by: Dan Carpenter --- This patch is obviously harmless, but it's from stat

[PATCH bpf 1/3] bpf: fix msg->data/data_end after sg shift repair in bpf_msg_pull_data

2018-08-29 Thread Daniel Borkmann
In the current code, msg->data is set as sg_virt(&sg[i]) + start - offset and msg->data_end relative to it as msg->data + bytes. Using iterator i to point to the updated starting scatterlist element holds true for some cases, however not for all where we'd end up pointing out of bounds. It is /corr

[PATCH bpf 3/3] bpf: fix sg shift repair start offset in bpf_msg_pull_data

2018-08-29 Thread Daniel Borkmann
When we perform the sg shift repair for the scatterlist ring, we currently start out at i = first_sg + 1. However, this is not correct since the first_sg could point to the sge sitting at slot MAX_SKB_FRAGS - 1, and a subsequent i = MAX_SKB_FRAGS will access the scatterlist ring (sg) out of bounds.

[PATCH bpf 0/3] Three fixes for bpf_msg_pull_data

2018-08-29 Thread Daniel Borkmann
This set contains three more fixes for the bpf_msg_pull_data() mainly for correcting scatterlist ring wrap-arounds as well as fixing up data pointers. For details please see individual patches. Thanks! Daniel Borkmann (3): bpf: fix msg->data/data_end after sg shift repair in bpf_msg_pull_data

[PATCH bpf 2/3] bpf: fix shift upon scatterlist ring wrap-around in bpf_msg_pull_data

2018-08-29 Thread Daniel Borkmann
If first_sg and last_sg wraps around in the scatterlist ring, then we need to account for that in the shift as well. E.g. crafting such msgs where this is the case leads to a hang as shift becomes negative. E.g. consider the following scenario: first_sg := 14 |=>shift := -12 msg->sg_

[PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle

2018-08-29 Thread Tony Lindgren
The current cpsw usage for cpsw-phy-sel is undocumented but is used for all the boards using cpsw. And cpsw-phy-sel is not really a child of the cpsw device, it lives in the system control module instead. Let's document the existing usage, and improve it a bit where we prefer to use a phandle inst

[PATCH 2/2] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel

2018-08-29 Thread Tony Lindgren
The cpsw-phy-sel device is not a child of the cpsw interconnect target module. It lives in the system control module. Let's fix this issue by trying to use cpsw-phy-sel phandle first if it exists and if not fall back to current usage of trying to find the cpsw-phy-sel child. That way the phy sel d

Fw: [Bug 200967] New: No network with U.S. Robotics USR997902

2018-08-29 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 29 Aug 2018 04:36:20 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200967] New: No network with U.S. Robotics USR997902 https://bugzilla.kernel.org/show_bug.cgi?id=200967 Bug ID: 200967

Fw: [Bug 200943] New: Repeating tcp_mark_head_lost in dmesg

2018-08-29 Thread Stephen Hemminger
Begin forwarded message: Date: Sun, 26 Aug 2018 22:24:12 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200943] New: Repeating tcp_mark_head_lost in dmesg https://bugzilla.kernel.org/show_bug.cgi?id=200943 Bug ID: 200943 Su

Re: [PATCH v2 iproute2-next 2/5] bridge: colorize output and use JSON print library

2018-08-29 Thread Stephen Hemminger
On Sat, 14 Jul 2018 18:41:03 -0700 Roopa Prabhu wrote: > On Tue, Feb 20, 2018 at 11:24 AM, Stephen Hemminger > wrote: > > From: Stephen Hemminger > > > > Use new functions from json_print to simplify code. > > Provide standard flag for colorizing output. > > > > The shortened -c flag is ambiguo

mlx5 driver loading failing on v4.19 / net-next / bpf-next

2018-08-29 Thread Jesper Dangaard Brouer
Hi Saeed, I'm having issues loading mlx5 driver on v4.19 kernels (tested both net-next and bpf-next), while kernel v4.18 seems to work. It happens with a Mellanox ConnectX-5 NIC (and also a CX4-Lx but I removed that from the system now). One pain point is very long boot-time, caused by some time

Re: [PATCH] rtnetlink: expose value from SET_NETDEV_DEVTYPE via IFLA_DEVTYPE attribute

2018-08-29 Thread Marcel Holtmann
Hi Jiri, >> The name value from SET_NETDEV_DEVTYPE only ended up in the uevent sysfs >> file as DEVTYPE= information. To avoid any kind of race conditions >> between netlink messages and reading from sysfs, it is useful to add the >> same string as new IFLA_DEVTYPE attribute included in the RTM_NE

Re: [PATCH] rtnetlink: expose value from SET_NETDEV_DEVTYPE via IFLA_DEVTYPE attribute

2018-08-29 Thread Stephen Hemminger
On Wed, 29 Aug 2018 09:18:55 +0200 Jiri Pirko wrote: > Tue, Aug 28, 2018 at 10:58:11PM CEST, mar...@holtmann.org wrote: > >The name value from SET_NETDEV_DEVTYPE only ended up in the uevent sysfs > >file as DEVTYPE= information. To avoid any kind of race conditions > >between netlink messages and

Re: Kernel Panic on high bandwidth transfer over wifi

2018-08-29 Thread Eric Dumazet
On 08/29/2018 04:42 AM, Nathaniel Munk wrote: > Hi all, > I'm running Arch Linux on kernel 4.18.5 (same issue on both arch-provided > kernel and mainline built-from-source). There is an issue whereby the kernel > crashes when transferring at high bandwidths (approx 6mB/s) over a specific > wi

Re: [PATCH] rtnetlink: expose value from SET_NETDEV_DEVTYPE via IFLA_DEVTYPE attribute

2018-08-29 Thread Marcel Holtmann
Hi Stephen, >>> The name value from SET_NETDEV_DEVTYPE only ended up in the uevent sysfs >>> file as DEVTYPE= information. To avoid any kind of race conditions >>> between netlink messages and reading from sysfs, it is useful to add the >>> same string as new IFLA_DEVTYPE attribute included in the

Re: [PATCH bpf-next] bpf: remove duplicated include from syscall.c

2018-08-29 Thread Daniel Borkmann
On 08/28/2018 09:42 AM, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing Applied to bpf-next, thanks!

Re: [bpf-next PATCH 0/2] bpf: test_sockmap updates

2018-08-29 Thread Daniel Borkmann
On 08/28/2018 06:10 PM, John Fastabend wrote: > Two small test sockmap updates for bpf-next. These help me run some > additional tests with test_sockmap. Applied to bpf-next, thanks!

Re: [Patch iproute2] ss: add UNIX_DIAG_VFS and UNIX_DIAG_ICONS for unix sockets

2018-08-29 Thread Stephen Hemminger
On Tue, 28 Aug 2018 16:16:49 -0700 Cong Wang wrote: > On Mon, Aug 27, 2018 at 3:27 PM Stephen Hemminger > wrote: > > > > On Mon, 27 Aug 2018 14:46:52 -0700 > > Cong Wang wrote: > > > > > UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss, > > > make them available in ss -e output. > > > >

Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-29 Thread Alex Vesker
On Wed, Aug 1, 2018 at 4:13 PM, Saeed Mahameed wrote: On Wed, Aug 1, 2018 at 3:34 PM, Alexander Duyck wrote: On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed wrote: Hi Dave, This series provides devlink parameters updates to both devlink API and mlx5 driver, it is a 2nd iteration of the d

Re: [PATCH bpf-next 00/11] AF_XDP zero-copy support for i40e

2018-08-29 Thread Daniel Borkmann
On 08/28/2018 02:44 PM, Björn Töpel wrote: > From: Björn Töpel > > This patch set introduces zero-copy AF_XDP support for Intel's i40e > driver. In the first preparatory patch we also add support for > XDP_REDIRECT for zero-copy allocated frames so that XDP programs can > redirect them. This was

[PATCH net-next 0/2] hv_netvsc: associate VF and PV device by serial number

2018-08-29 Thread Stephen Hemminger
The Hyper-V implementation of PCI controller has concept of 32 bit serial number (not to be confused with PCI-E serial number). This value is sent in the protocol from the host to indicate SR-IOV VF device is attached to a synthetic NIC. Using the serial number (instead of MAC address) to associ

[PATCH net-next 1/2] PCI: hv: support reporting serial number as slot information

2018-08-29 Thread Stephen Hemminger
The Hyper-V host API for PCI provides a unique "serial number" which can be used as basis for sysfs PCI slot table. This can be useful for cases where userspace wants to find the PCI device based on serial number. When an SR-IOV NIC is added, the host sends an attach message with serial number. Th

[PATCH net-next 2/2] hv_netvsc: pair VF based on serial number

2018-08-29 Thread Stephen Hemminger
Matching network device based on MAC address is problematic since a non-VF network device can be created with a duplicate MAC address causing confusion and problems. The VMBus API provides a serial number that is a better matching method. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/

Re: [PATCH 0/4] clk-pmc-atom + r8169: Add ether_clk handling to fix suspend issues

2018-08-29 Thread Andy Shevchenko
On Mon, Aug 27, 2018 at 04:31:56PM +0200, Hans de Goede wrote: > Hi All, > > This series has as goal to revert commit d31fd43c0f9a ("clk: x86: Do not gate > clocks enabled by the firmware"), because that commit causes almost all > Cherry Trail devices to not use the S0i3 powerstate when suspending

Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-29 Thread Alexander Duyck
On Wed, Aug 29, 2018 at 8:43 AM Alex Vesker wrote: > > > > On Wed, Aug 1, 2018 at 4:13 PM, Saeed Mahameed > > wrote: > >> On Wed, Aug 1, 2018 at 3:34 PM, Alexander Duyck > >> wrote: > >>> On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed > >>> wrote: > Hi Dave, > > This series provi

Re: [PATCH 0/4] clk-pmc-atom + r8169: Add ether_clk handling to fix suspend issues

2018-08-29 Thread Hans de Goede
Hi, On 29-08-18 18:31, Andy Shevchenko wrote: On Mon, Aug 27, 2018 at 04:31:56PM +0200, Hans de Goede wrote: Hi All, This series has as goal to revert commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the firmware"), because that commit causes almost all Cherry Trail devices to not

[Patch iproute2 v2] ss: add UNIX_DIAG_VFS and UNIX_DIAG_ICONS for unix sockets

2018-08-29 Thread Cong Wang
UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss, make them available in ss -e output. Cc: Stephen Hemminger Signed-off-by: Cong Wang --- misc/ss.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/misc/ss.c b/misc/ss.c index 41e7762b..b2c634c8 100644 --- a/misc/ss.c

Re: [PATCH 2/4] r8169: Get and enable optional ether_clk clock

2018-08-29 Thread Hans de Goede
Hi, On 27-08-18 21:14, Stephen Boyd wrote: Quoting Hans de Goede (2018-08-27 11:53:19) On 27-08-18 20:47, Stephen Boyd wrote: How would you know that a clk device driver hasn't probed yet and isn't the driver that's actually providing the clk to this device on x86 systems? With DT systems we c

[Patch net-nnext] Revert "net: sched: act: add extack for lookup callback"

2018-08-29 Thread Cong Wang
This reverts commit 331a9295de23 ("net: sched: act: add extack for lookup callback"). This extack is never used after 6 months... In fact, it can be just set in the caller, right after ->lookup(). Cc: Alexander Aring Signed-off-by: Cong Wang --- include/net/act_api.h | 3 +-- net/sched/a

[Patch net-nnext] net_sched: add missing tcf_lock for act_connmark

2018-08-29 Thread Cong Wang
According to the new locking rule, we have to take tcf_lock for both ->init() and ->dump(), as RTNL will be removed. However, it is missing for act_connmark. Cc: Vlad Buslov Signed-off-by: Cong Wang --- net/sched/act_connmark.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-)

Re: [PATCH bpf 0/3] Three fixes for bpf_msg_pull_data

2018-08-29 Thread Alexei Starovoitov
On Wed, Aug 29, 2018 at 04:50:33PM +0200, Daniel Borkmann wrote: > This set contains three more fixes for the bpf_msg_pull_data() > mainly for correcting scatterlist ring wrap-arounds as well as > fixing up data pointers. For details please see individual patches. > Thanks! Applied to bpf tree, Th

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-29 Thread Jakub Kicinski
On Wed, 29 Aug 2018 12:23:15 +0200, Paolo Abeni wrote: > On Thu, 2018-08-23 at 20:14 +0200, Jakub Kicinski wrote: > > I asked Louis to run some tests while I'm travelling, and he reports > > that my worry about reporting the extra stats was unfounded. Update > > function does not show up in traces

Re: [bpf-next, 01/11] xdp: implement convert_to_xdp_frame for MEM_TYPE_ZERO_COPY

2018-08-29 Thread Maciek Fijalkowski
From: Maciej Fijalkowski > From: Björn Töpel > > This commit adds proper MEM_TYPE_ZERO_COPY support for > convert_to_xdp_frame. Converting a MEM_TYPE_ZERO_COPY xdp_buff to an > xdp_frame is done by transforming the MEM_TYPE_ZERO_COPY buffer into a > MEM_TYPE_PAGE_ORDER0 frame. This is costly, a

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-29 Thread Jakub Kicinski
On Wed, 29 Aug 2018 11:43:47 +0200, Eelco Chaudron wrote: > On 23 Aug 2018, at 20:14, Jakub Kicinski wrote: > > > On Mon, 20 Aug 2018 16:03:40 +0200, Eelco Chaudron wrote: > >> On 17 Aug 2018, at 13:27, Jakub Kicinski wrote: > >>> On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote: > >

Kernel warnings from tcp.c

2018-08-29 Thread Adam Mitchell
Anyone with experience in tcp.c have an idea what's causing this on our busy database server? Comes from this macro at line 2278: WARN_ON(sock_owned_by_user(sk)); [726780.788201] WARNING: CPU: 15 PID: 52245 at net/ipv4/tcp.c:2278 tcp_close+0x40f/0x430 [726780.794947] Modules linked in: bin

[PATCH net] Revert "packet: switch kvzalloc to allocate memory"

2018-08-29 Thread Eric Dumazet
This reverts commit 71e41286203c017d24f041a7cd71abea7ca7b1e0. mmap()/munmap() can not be backed by kmalloced pages : We fault in : VM_BUG_ON_PAGE(PageSlab(page), page); unmap_single_vma+0x8a/0x110 unmap_vmas+0x4b/0x90 unmap_region+0xc9/0x140 do_munmap+0x274/0x360 vm_munm

Re: bpfilter causes a leftover kernel process

2018-08-29 Thread Olivier Brunel
On Tue, 28 Aug 2018 22:35:38 -0700 Alexei Starovoitov wrote: > > Yeah, I have a similar thing happening on shutdown, except that > > we're talking about a kernel thread here, so that process is > > ignored by the mentionned killing spree as a result, thus leaving > > that process running. > >

pull-request: bpf 2018-08-29

2018-08-29 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix a build error in sk_reuseport_convert_ctx_access() when compiling with clang which cannot resolve hweight_long() at build time inside the BUILD_BUG_ON() assertion, from Stefan. 2) S

Re: [PATCH bpf-next 08/11] i40e: add AF_XDP zero-copy Rx support

2018-08-29 Thread Jakub Kicinski
On Tue, 28 Aug 2018 14:44:32 +0200, Björn Töpel wrote: > From: Björn Töpel > > This patch adds zero-copy Rx support for AF_XDP sockets. Instead of > allocating buffers of type MEM_TYPE_PAGE_SHARED, the Rx frames are > allocated as MEM_TYPE_ZERO_COPY when AF_XDP is enabled for a certain > queue. >

[RFC] net: xsk: add a simple buffer reuse queue

2018-08-29 Thread Jakub Kicinski
XSK UMEM is strongly single producer single consumer so reuse of frames is challenging. Add a simple "stash" of FILL packets to reuse for drivers to optionally make use of. This is useful when driver has to free (ndo_stop) or resize a ring with an active AF_XDP ZC socket. Signed-off-by: Jakub Ki

Re: [PATCH bpf-next 08/11] i40e: add AF_XDP zero-copy Rx support

2018-08-29 Thread Alexei Starovoitov
On Tue, Aug 28, 2018 at 02:44:32PM +0200, Björn Töpel wrote: > From: Björn Töpel > > This patch adds zero-copy Rx support for AF_XDP sockets. Instead of > allocating buffers of type MEM_TYPE_PAGE_SHARED, the Rx frames are > allocated as MEM_TYPE_ZERO_COPY when AF_XDP is enabled for a certain > qu

Re: Kernel warnings from tcp.c

2018-08-29 Thread Stephen Hemminger
On Wed, 29 Aug 2018 14:38:38 -0400 Adam Mitchell wrote: > Anyone with experience in tcp.c have an idea what's causing this on > our busy database server? Comes from this macro at line 2278: > WARN_ON(sock_owned_by_user(sk)); > > > [726780.788201] WARNING: CPU: 15 PID: 52245 at net/ipv4/tc

Re: [PATCH bpf-next 00/11] AF_XDP zero-copy support for i40e

2018-08-29 Thread Alexei Starovoitov
On Tue, Aug 28, 2018 at 02:44:24PM +0200, Björn Töpel wrote: > From: Björn Töpel > > This patch set introduces zero-copy AF_XDP support for Intel's i40e > driver. In the first preparatory patch we also add support for > XDP_REDIRECT for zero-copy allocated frames so that XDP programs can > redire

[PATCH net] nfp: wait for posted reconfigs when disabling the device

2018-08-29 Thread Jakub Kicinski
To avoid leaking a running timer we need to wait for the posted reconfigs after netdev is unregistered. In common case the process of deinitializing the device will perform synchronous reconfigs which wait for posted requests, but especially with VXLAN ports being actively added and removed there

Re: Fw: [Bug 200943] New: Repeating tcp_mark_head_lost in dmesg

2018-08-29 Thread Yuchung Cheng
On Wed, Aug 29, 2018 at 8:02 AM, Stephen Hemminger wrote: > > > > Begin forwarded message: > > Date: Sun, 26 Aug 2018 22:24:12 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject: [Bug 200943] New: Repeating tcp_mark_head_lost in dmesg > > > https://bugzill

Re: GPL compliance issue with liquidio/lio_23xx_vsw.bin firmware

2018-08-29 Thread Ben Hutchings
On Mon, 2018-08-27 at 17:04 -0700, Felix Manlunas wrote: > On Mon, Aug 27, 2018 at 05:01:10PM +0200, Florian Weimer wrote: > > liquidio/lio_23xx_vsw.bin contains a compiled MIPS Linux kernel: > > > > $ tail --bytes=+1313 liquidio/lio_23xx_vsw.bin > elf > > $ readelf -aW elf > > […] > > [ 6] __ks

Wine Enthusiasts List

2018-08-29 Thread Julie Wider
Hi, Greeting of the day! Would you be interested in reaching out to "Wine Enthusiasts list" from USA? Our Databases:- 1.Beer Enthusiasts List2.Alcohol Enthusiasts List 3.Beverage Consumers 4.Liquor Enthusiasts List 5.Chocolate Enth

Motorcycle Owners List

2018-08-29 Thread Marlene Royle
Hi, Greeting of the day! Would you are interested in acquiring an email list of "Motorcycle Owners"? from USA. We also having data of Harley Davidson Owners, Car Owners List, BMW Owners List, Luxury Car Owners List, RV Owners, Pick Up Truck Owners, Boat Owners, RV Owners List, HNI,Traveler

[PATCH bpf-next 3/3] tools/bpf: bpftool: add btf percpu map formated dump

2018-08-29 Thread Yonghong Song
The btf pretty print is added to percpu arraymap, percpu hashmap and percpu lru hashmap. For each pair, the following will be added to plain/json output: { "key": , "values": [{ "cpu": 0, "value": },{ "cpu": 1, "value

[PATCH bpf-next 0/3] bpf: implement percpu map pretty print for bpffs and bpftool

2018-08-29 Thread Yonghong Song
Commit a26ca7c982cb ("bpf: btf: Add pretty print support to the basic arraymap") and Commit 699c86d6ec21 ("bpf: btf: add pretty print for hash/lru_hash maps") added bpffs pretty print for array, hash and lru hash maps. The pretty print gives users a structurally formatted dump for keys/values which

[PATCH bpf-next 1/3] bpf: add bpffs pretty print for percpu arraymap/hash/lru_hash

2018-08-29 Thread Yonghong Song
Added bpffs pretty print for percpu arraymap, percpu hashmap and percpu lru hashmap. For each map pair, the format is: : { cpu0: cpu1: ... cpun: } For example, on my VM, there are 4 cpus, and for test_btf test in the next patch: cat /sys/fs/bpf/pprint_

[PATCH bpf-next 2/3] tools/bpf: add bpffs percpu map pretty print tests in test_btf

2018-08-29 Thread Yonghong Song
The bpf selftest test_btf is extended to test bpffs percpu map pretty print for percpu array, percpu hash and percpu lru hash. Signed-off-by: Yonghong Song --- tools/testing/selftests/bpf/test_btf.c | 179 ++--- 1 file changed, 144 insertions(+), 35 deletions(-) diff

[PATCH net-next] tcp: change IPv6 flow-label upon receiving spurious retransmission

2018-08-29 Thread Yuchung Cheng
Currently a Linux IPv6 TCP sender will change the flow label upon timeouts to potentially steer away from a data path that has gone bad. However this does not help if the problem is on the ACK path and the data path is healthy. In this case the receiver is likely to receive repeated spurious retran

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2018-08-29

2018-08-29 Thread Jeff Kirsher
This series contains updates to i40e, i40evf and virtchnl. Jake implements helper functions to use an array to handle the queue stats which reduces the boiler plate code as well as keep the complexity localized to a few functions. Paweł adds the ability to change a VF's MAC address from the host

[net-next 14/15] i40evf: cancel workqueue sync for adminq when a VF is removed

2018-08-29 Thread Jeff Kirsher
From: Lihong Yang If a VF is being removed, there is no need to continue with the workqueue sync for the adminq task, thus cancel it. Without this call, when VFs are created and removed right away, there might be a chance for the driver to crash with events stuck in the adminq. Signed-off-by: Li

[net-next 03/15] i40evf: update ethtool stats code and use helper functions

2018-08-29 Thread Jeff Kirsher
From: Jacob Keller Fix a bug in the way we handled VF queues, by always showing stats for the maximum number of queues, even if they aren't allocated. It is not safe to change the number of strings reported to ethtool, as grabbing statistics occurs over multiple ethtool ops for which the rtnl_loc

[net-next 10/15] i40e: report correct statistics when XDP is enabled

2018-08-29 Thread Jeff Kirsher
From: Björn Töpel When XDP is enabled, the driver will report incorrect statistics. Received frames will reported as transmitted frames. This commits fixes the i40e implementation of ndo_get_stats64 (struct net_device_ops), so that iproute2 will report correct statistics (e.g. when running "ip -

[net-next 04/15] i40evf: Change a VF mac without reloading the VF driver

2018-08-29 Thread Jeff Kirsher
From: Paweł Jabłoński Add possibility to change a VF mac address from host side without reloading the VF driver on the guest side. Without this patch it is not possible to change the VF mac because executing i40evf_virtchnl_completion function with VIRTCHNL_OP_GET_VF_RESOURCES opcode resets the V

[net-next 05/15] i40evf: Validate the number of queues a PF sends

2018-08-29 Thread Jeff Kirsher
From: Paul M Stillwell Jr A PF can send any number of queues to the VF and the VF may not be able to support that many. Check to see that the number of queues is less than or equal to the max number of queues the VF can have. Signed-off-by: Paul M Stillwell Jr Tested-by: Andrew Bowers Signed-o

[net-next 12/15] i40evf: Don't enable vlan stripping when rx offload is turned on

2018-08-29 Thread Jeff Kirsher
From: Patryk Małek With current implementation of i40evf_set_features when user sets any offload via ethtool we set I40EVF_FLAG_AQ_ENABLE_VLAN_STRIPPING as a required aq which triggers driver to call i40evf_enable_vlan_stripping. This shouldn't take place. This patches fixes it by setting the fla

[net-next 02/15] i40e: move ethtool stats boiler plate code to i40e_ethtool_stats.h

2018-08-29 Thread Jeff Kirsher
From: Jacob Keller Move the boiler plate structures and helper functions we recently added into their own header file, so that the complete collection is located together. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/i40e/i40e_et

[net-next 06/15] i40e: use correct length for strncpy

2018-08-29 Thread Jeff Kirsher
From: Mitch Williams Caught by GCC 8. When we provide a length for strncpy, we should not include the terminating null. So we must tell it one less than the size of the destination buffer. Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethe

[net-next 07/15] i40evf: set IFF_UNICAST_FLT flag for the VF

2018-08-29 Thread Jeff Kirsher
From: Lihong Yang Set IFF_UNICAST_FLT flag for the VF to prevent it from entering promiscuous mode when macvlan is added to the VF. Signed-off-by: Lihong Yang Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 ++ 1 file changed, 2 in

[net-next 01/15] i40e: convert queue stats to i40e_stats array

2018-08-29 Thread Jeff Kirsher
From: Jacob Keller Use an i40e_stats array to handle the queue stats, instead of coding similar functionality separately. Because of how the queue stats are accessed on some kernels, we can't easily use i40e_add_ethtool_stats. Instead, implement a separate helper, i40e_add_queue_stats, which we'

[net-next 13/15] i40e: hold the rtnl lock on clearing interrupt scheme

2018-08-29 Thread Jeff Kirsher
From: Patryk Małek Hold the rtnl lock when we're clearing interrupt scheme in i40e_shutdown and in i40e_remove. Signed-off-by: Patryk Małek Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 8 1 file changed, 8 insertions(+) diff

[net-next 09/15] i40e: static analysis report from community

2018-08-29 Thread Jeff Kirsher
From: Martyna Szapar Static analysis tools report a problem from original driver submission. Removing unnecessary check in condition. Signed-off-by: Martyna Szapar Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 i

[net-next 08/15] virtchnl: use u8 type for a field in the virtchnl_filter struct

2018-08-29 Thread Jeff Kirsher
From: Harshitha Ramamurthy The virtchnl_filter struct has a field called field_flags. A previous commit mistakenly had the type to be a __u8. What we want is for the field to be an unsigned 8 bit value, so let's just use the existing kernel type u8 for that. Signed-off-by: Harshitha Ramamurthy

[net-next 11/15] i40e: Check and correct speed values for link on open

2018-08-29 Thread Jeff Kirsher
From: Jan Sokolowski If our card has been put in an unstable state due to other drivers interacting with it, speed settings might be incorrect. If incorrect, forcefully reset them on open to known default values. Signed-off-by: Jan Sokolowski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirshe

[net-next 15/15] i40e: Prevent deleting MAC address from VF when set by PF

2018-08-29 Thread Jeff Kirsher
From: Patryk Małek To prevent VF from deleting MAC address that was assigned by the PF we need to check for that scenario when we try to delete a MAC address from a VF. Signed-off-by: Patryk Małek Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_v

Re: pull-request: bpf 2018-08-29

2018-08-29 Thread David Miller
From: Daniel Borkmann Date: Wed, 29 Aug 2018 21:07:24 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix a build error in sk_reuseport_convert_ctx_access() when >compiling with clang which cannot resolve hweight_long() at >b

[PATCH net-next] net/ipv4: Add extack message that dev is required for ONLINK

2018-08-29 Thread dsahern
From: David Ahern Make IPv4 consistent with IPv6 and return an extack message that the ONLINK flag requires a nexthop device. Signed-off-by: David Ahern --- net/ipv4/fib_semantics.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_s

[PATCH net-next] net/ipv6: Do not reset nl_net in ip6_route_info_create

2018-08-29 Thread dsahern
From: David Ahern nl_net is set on entry to ip6_route_info_create. Only devices within that namespace are considered so no need to reset it before returning. Signed-off-by: David Ahern --- net/ipv6/route.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c

[PATCH net] ebpf: fix bpf_msg_pull_data

2018-08-29 Thread Tushar Dave
While doing some preliminary testing it is found that bpf helper bpf_msg_pull_data does not calculate the data and data_end offset correctly. Fix it! Fixes: 015632bb30da ("bpf: sk_msg program helper bpf_sk_msg_pull_data") Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- net/core/filter

Re: [PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle

2018-08-29 Thread Grygorii Strashko
Hi Tony, On 08/29/2018 10:00 AM, Tony Lindgren wrote: > The current cpsw usage for cpsw-phy-sel is undocumented but is used for > all the boards using cpsw. And cpsw-phy-sel is not really a child of > the cpsw device, it lives in the system control module instead. > > Let's document the existing

Re: [PATCH bpf-next 00/11] AF_XDP zero-copy support for i40e

2018-08-29 Thread William Tu
> Thanks for working on this, LGTM! Are you also planning to get ixgbe > out after that? > I currently don't have i40e nic to test, so I'm also looking forward to the ixgbe patch! Thank you William

  1   2   >