Re: [PATCH bpf-next v4 10/10] tools: bpftool: add delimiters to multi-function JITed dumps

2018-05-24 Thread Jakub Kicinski
On Thu, 24 May 2018 12:26:54 +0530, Sandipan Das wrote: > This splits up the contiguous JITed dump obtained via the bpf > system call into more relatable chunks for each function in > the program. If the kernel symbols corresponding to these are > known, they are printed in the header for each JIT

[PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation

2018-05-24 Thread Robert Jarzmik
Now the dma_slave_map is available for PXA architecture, switch the SSP device to it. This specifically means that : - for platform data based machines, the DMA requestor channels are extracted from the slave map, where pxa-ssp-dai. is a 1-1 match to ssp., and the channels are either "rx" or "

[PATCH v2 07/13] net: smc91x: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel(). Signed-o

[PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel(). Signed-o

[PATCH v2 01/13] dmaengine: pxa: use a dma slave map

2018-05-24 Thread Robert Jarzmik
In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This won't impact MMP architecture, but is aimed only at all PXA boards. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static,

[PATCH v2 00/13] ARM: pxa: switch to DMA slave maps

2018-05-24 Thread Robert Jarzmik
This v1 cover letter is quoted in [1]. For maintainers the table below should help you focus on the patches targetted at you, and ignore the other noise. The differences since v1 is by maintainers / topic / patch : - Arnd and Daniel / PXA topic / 0002 devices.c split into pxa25x.c, pxa27x.c an

[PATCH v2 04/13] media: pxa_camera: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel(). Signed-o

[PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel(). Signed-o

[PATCH v2 10/13] dmaengine: pxa: document pxad_param

2018-05-24 Thread Robert Jarzmik
Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma/pxa-dma.h b/include/l

[PATCH v2 11/13] dmaengine: pxa: make the filter function internal

2018-05-24 Thread Robert Jarzmik
As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma/p

[PATCH v2 09/13] ata: pata_pxa: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel(). Signed-o

[PATCH v2 03/13] mmc: pxamci: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel(). Signed-o

[PATCH v2 02/13] ARM: pxa: add dma slave map

2018-05-24 Thread Robert Jarzmik
In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert Jarzmi

Re: [PATCH V4 0/8] net: ethernet: stmmac: add support for stm32mp1

2018-05-24 Thread Alexandre Torgue
On 05/23/2018 10:08 PM, David Miller wrote: From: Christophe Roullier Date: Wed, 23 May 2018 17:47:51 +0200 Patches to have Ethernet support on stm32mp1 Changelog: Remark from Rob Herring Move Documentation/devicetree/bindings/arm/stm32.txt in Documentation/devicetree/bindings/arm/stm32/stm3

Re: [PATCH V4 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c.

2018-05-24 Thread Alexandre Torgue
Hi, On 05/23/2018 05:47 PM, Christophe Roullier wrote: Glue codes to support stm32mp157c device and stay compatible with stm32 mcu family Signed-off-by: Christophe Roullier --- Acked-by: Alexandre TORGUE drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 270 -- 1

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-24 Thread Gi-Oh Kim
On Thu, May 24, 2018 at 1:22 AM, Qing Huang wrote: > When a system is under memory presure (high usage with fragments), > the original 256KB ICM chunk allocations will likely trigger kernel > memory management to enter slow path doing memory compact/migration > ops in order to complete high order

Re: [PATCH bpf-next v4 00/10] bpf: enhancements for multi-function programs

2018-05-24 Thread Daniel Borkmann
On 05/24/2018 08:56 AM, Sandipan Das wrote: > [1] Support for bpf-to-bpf function calls in the powerpc64 JIT compiler. > > [2] Provide a way for resolving function calls because of the way JITed > images are allocated in powerpc64. > > [3] Fix to get JITed instruction dumps for multi-function

Re: [PATCH bpf-next v4 02/10] bpf: powerpc64: pad function address loads with NOPs

2018-05-24 Thread Daniel Borkmann
On 05/24/2018 08:56 AM, Sandipan Das wrote: > For multi-function programs, loading the address of a callee > function to a register requires emitting instructions whose > count varies from one to five depending on the nature of the > address. > > Since we come to know of the callee's address only

Re: [PATCH v2 bpf-next] bpf: btf: Avoid variable length array

2018-05-24 Thread Daniel Borkmann
On 05/23/2018 08:32 PM, Martin KaFai Lau wrote: > Sparse warning: > kernel/bpf/btf.c:1985:34: warning: Variable length array is used. > > This patch directly uses ARRAY_SIZE(). > > Fixes: f80442a4cd18 ("bpf: btf: Change how section is supported in > btf_header") > Signed-off-by: Martin KaFai Lau

[PATCH v2 06/13] net: smc911x: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function dma_request_slave_channel(). Signed-o

[PATCH v2 12/13] ARM: pxa: remove the DMA IO resources

2018-05-24 Thread Robert Jarzmik
As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 136 1 file changed

Re: [PATCH bpf-next v2 0/3] bpf: add boot parameters for sysctl knobs

2018-05-24 Thread Jesper Dangaard Brouer
On Wed, 23 May 2018 15:02:45 -0700 Alexei Starovoitov wrote: > On Wed, May 23, 2018 at 02:18:19PM +0200, Eugene Syromiatnikov wrote: > > Some BPF sysctl knobs affect the loading of BPF programs, and during > > system boot/init stages these sysctls are not yet configured. > > A concrete example is

[PATCH net-next] bpfilter: don't pass O_CREAT when opening console for debug

2018-05-24 Thread Jakub Kicinski
Passing O_CREAT (0100) to open means we should also pass file mode as the third parameter. Creating /dev/console as a regular file may not be helpful anyway, so simply drop the flag when opening debug_fd. Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module") Signed-off-by: Jakub

Re: WARNING in ip_recv_error

2018-05-24 Thread Paolo Abeni
On Wed, 2018-05-23 at 11:40 -0400, Willem de Bruijn wrote: > On Sun, May 20, 2018 at 7:13 PM, Willem de Bruijn > wrote: > > On Fri, May 18, 2018 at 2:59 PM, Willem de Bruijn > > wrote: > > > On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn > > > wrote: > > > > On Fri, May 18, 2018 at 2:44 PM, W

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-24 Thread Jiri Pirko
Thu, May 24, 2018 at 08:56:20AM CEST, ilias.apalodi...@linaro.org wrote: >Hello, > >This is adding a new mode on the cpsw driver based around switchdev. >In order to enable this you need to enable CONFIG_NET_SWITCHDEV, >CONFIG_BRIDGE_VLAN_FILTERING, CONFIG_TI_CPSW_SWITCHDEV >and add to udev confi

Re: [PATCH bpf-next v4 02/10] bpf: powerpc64: pad function address loads with NOPs

2018-05-24 Thread Sandipan Das
On 05/24/2018 01:04 PM, Daniel Borkmann wrote: > On 05/24/2018 08:56 AM, Sandipan Das wrote: >> For multi-function programs, loading the address of a callee >> function to a register requires emitting instructions whose >> count varies from one to five depending on the nature of the >> address. >

suspicius csum initialization in vmxnet3_rx_csum

2018-05-24 Thread Paolo Abeni
Hi all, we are hitting the BUG() condition in skb_checksum_help() - skb_checksum_start_offset(skb) >= skb_headlen(skb) for skb received from vmnxnet3 and queued from OVS to user-space I think that the root cause is in vmxnet3_rx_csum(): if (gdesc->rcd.csum) {

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-24 Thread Ilias Apalodimas
On Thu, May 24, 2018 at 10:05:28AM +0200, Jiri Pirko wrote: > Thu, May 24, 2018 at 08:56:20AM CEST, ilias.apalodi...@linaro.org wrote: > Any reason you need cpu port? We don't need it in mlxsw and also in dsa. Yes i've seen that on mlxsw/rocker drivers and i was reluctant adding one here. The reas

[PATCH net-next] net: bridge: add support for port isolation

2018-05-24 Thread Nikolay Aleksandrov
This patch adds support for a new port flag - BR_ISOLATED. If it is set then isolated ports cannot communicate between each other, but they can still communicate with non-isolated ports. The same can be achieved via ACLs but they can't scale with large number of ports and also the complexity of the

Re: INFO: rcu detected stall in corrupted

2018-05-24 Thread Xin Long
On Thu, May 24, 2018 at 7:13 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 21, 2018 at 11:13:46AM -0700, Eric Dumazet wrote: >> >> >> On 05/21/2018 11:09 AM, David Miller wrote: >> > From: syzbot >> > Date: Mon, 21 May 2018 11:05:02 -0700 >> > >> >> find_match+0x244/0x13a0 net/ipv6/route.c:69

[PATCH v2 net-next] sfc: stop the TX queue before pushing new buffers

2018-05-24 Thread Martin Habets
efx_enqueue_skb() can push new buffers for the xmit_more functionality. We must stops the TX queue before this or else the TX queue does not get restarted and we get a netdev watchdog. In the error handling we may now need to unwind more than 1 packet, and we may need to push the new buffers onto

Re: [PATCH bpf-next v4 02/10] bpf: powerpc64: pad function address loads with NOPs

2018-05-24 Thread Daniel Borkmann
On 05/24/2018 10:25 AM, Sandipan Das wrote: > On 05/24/2018 01:04 PM, Daniel Borkmann wrote: >> On 05/24/2018 08:56 AM, Sandipan Das wrote: >>> For multi-function programs, loading the address of a callee >>> function to a register requires emitting instructions whose >>> count varies from one to f

Re: [PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

2018-05-24 Thread Miquel Raynal
Hi Robert, On Thu, 24 May 2018 09:06:55 +0200, Robert Jarzmik wrote: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource a

Re: STMMAC driver with TSO enabled issue

2018-05-24 Thread Jose Abreu
Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: > > After some time if check Tx descriptor status - then I see only > below > > [..] > [85788.286730] 027 [0x827951b0]: 0xf854f000 0x0 0x16d8 0x9000 > > index 025 and 026 descriptors processed but not index 027. > > At this stage Tx DMA is

Re: [PATCH net-next v3 0/7] Add support for QCA8334 switch

2018-05-24 Thread Michal Vokáč
On 23.5.2018 17:39, Florian Fainelli wrote: On 05/22/2018 11:20 PM, Michal Vokáč wrote: This series basically adds support for a QCA8334 ethernet switch to the qca8k driver. It is a four-port variant of the already supported seven port QCA8337. Register map is the same for the whole familly an

Re: [PATCH 3/4] cpsw_switchdev: add switchdev support files

2018-05-24 Thread Maxim Uvarov
2018-05-24 9:56 GMT+03:00 Ilias Apalodimas : > Signed-off-by: Ilias Apalodimas > --- > drivers/net/ethernet/ti/Kconfig | 9 + > drivers/net/ethernet/ti/Makefile | 1 + > drivers/net/ethernet/ti/cpsw_switchdev.c | 299 > +++ > drivers/net/ethernet/

[PATCH] net/9p: fix error path of p9_virtio_probe

2018-05-24 Thread Jean-Philippe Brucker
Currently when virtio_find_single_vq fails, we go through del_vqs which throws a warning (Trying to free already-free IRQ). Skip del_vqs if vq allocation failed. Signed-off-by: Jean-Philippe Brucker --- net/9p/trans_virtio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/n

Re: [PATCH bpf-next v7 0/6] ipv6: sr: introduce seg6local End.BPF action

2018-05-24 Thread Daniel Borkmann
On 05/20/2018 03:58 PM, Mathieu Xhonneux wrote: > As of Linux 4.14, it is possible to define advanced local processing for > IPv6 packets with a Segment Routing Header through the seg6local LWT > infrastructure. This LWT implements the network programming principles > defined in the IETF “SRv6 Netw

Re: [PATCH v6 0/5] PCI: Improve PCIe link status reporting

2018-05-24 Thread Ganesh Goudar
On Wednesday, May 05/23/18, 2018 at 16:46:51 -0500, Bjorn Helgaas wrote: > [+to Davem] > > On Thu, May 03, 2018 at 03:00:07PM -0500, Bjorn Helgaas wrote: > > This is based on Tal's recent work to unify the approach for reporting PCIe > > link speed/width and whether the device is being limited by

Re: [PATCH bpf-next v7 3/6] bpf: Add IPv6 Segment Routing helpers

2018-05-24 Thread Daniel Borkmann
On 05/20/2018 03:58 PM, Mathieu Xhonneux wrote: > The BPF seg6local hook should be powerful enough to enable users to > implement most of the use-cases one could think of. After some thinking, > we figured out that the following actions should be possible on a SRv6 > packet, requiring 3 specific he

Re: [PATCH net-next] bpfilter: fix build dependency

2018-05-24 Thread Daniel Borkmann
On 05/24/2018 06:29 AM, Alexei Starovoitov wrote: > BPFILTER could have been enabled without INET causing this build error: > ERROR: "bpfilter_process_sockopt" [net/bpfilter/bpfilter.ko] undefined! > > Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module") > Reported-by: Jakub Kicinsk

Re: [PATCH net-next] bpfilter: don't pass O_CREAT when opening console for debug

2018-05-24 Thread Daniel Borkmann
On 05/24/2018 09:41 AM, Jakub Kicinski wrote: > Passing O_CREAT (0100) to open means we should also pass file > mode as the third parameter. Creating /dev/console as a regular > file may not be helpful anyway, so simply drop the flag when > opening debug_fd. > > Fixes: d2ba09c17a06 ("net: add

Re: [PATCH v3] powerpc: Implement csum_ipv6_magic in assembly

2018-05-24 Thread Christophe Leroy
On 05/24/2018 06:20 AM, Christophe LEROY wrote: Le 23/05/2018 à 20:34, Segher Boessenkool a écrit : On Tue, May 22, 2018 at 08:57:01AM +0200, Christophe Leroy wrote: The generic csum_ipv6_magic() generates a pretty bad result Please try with a more recent compiler, what you used is pret

Re: [PATCH] netfilter: nft_numgen: fix ptr_ret.cocci warnings

2018-05-24 Thread Laura Garcia
On Wed, May 23, 2018 at 12:58 PM, kbuild test robot wrote: > From: kbuild test robot > > net/netfilter/nft_numgen.c:117:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Fixes: d734

[PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
The change replaces a custom implementation of .set_link_ksettings callback with a shared phy_ethtool_set_link_ksettings(), this fixes sleep in atomic context bug, which is encountered every time when link settings are changed by ethtool. Now duplex mode setting is enforced in ravb_adjust_link() o

[PATCH 2/6] ravb: remove custom .get_link_ksettings from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
The change replaces a custom implementation of .get_link_ksettings callback with a shared phy_ethtool_get_link_ksettings(), note that &priv->lock wrapping is not needed, because the lock does not serialize access to phydev fields. Signed-off-by: Vladimir Zapolskiy --- drivers/net/ethernet/renesa

[PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

2018-05-24 Thread Vladimir Zapolskiy
For ages trivial changes to RAVB and SuperH ethernet links by means of standard 'ethtool' trigger a 'sleeping function called from invalid context' bug, to visualize it on r8a7795 ULCB: % ethtool -r eth0 BUG: sleeping function called from invalid context at kernel/locking/mutex.c:747 in_ato

[PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
The change fixes a sleep in atomic context issue, which can be always triggered by running 'ethtool -r' command, because phy_start_aneg() protects phydev fields by a mutex. Another note is that the change implicitly replaces phy_start_aneg() with a newer phy_restart_aneg(). Signed-off-by: Vladimi

[PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
The change fixes a sleep in atomic context issue, which can be always triggered by running 'ethtool -r' command, because phy_start_aneg() protects phydev fields by a mutex. Another note is that the change implicitly replaces phy_start_aneg() with a newer phy_restart_aneg(). Signed-off-by: Vladimi

[PATCH 6/6] sh_eth: remove custom .set_link_ksettings from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
The change replaces a custom implementation of .set_link_ksettings callback with a shared phy_ethtool_set_link_ksettings(), this fixes sleep in atomic context bug, which is encountered every time when link settings are changed by ethtool. Now duplex mode setting is enforced in ravb_adjust_link() o

[PATCH 5/6] sh_eth: remove custom .get_link_ksettings from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
The change replaces a custom implementation of .get_link_ksettings callback with a shared phy_ethtool_get_link_ksettings(), note that &priv->lock wrapping is not needed, because the lock does not serialize access to phydev fields. Signed-off-by: Vladimir Zapolskiy --- drivers/net/ethernet/renesa

RE: [PATCH net-next 1/1] bnx2x: Collect the device debug information during Tx timeout.

2018-05-24 Thread Yuval Mintz
> Tx-timeout mostly happens due to some issue in the device. In such cases, > debug dump would be helpful for identifying the cause of the issue. > This patch adds support to spill debug data during the Tx timeout. Here > bnx2x_panic_dump() API is used instead of bnx2x_panic(), since we still > wan

[PATCH net-next] net: fec: remove stale comment

2018-05-24 Thread YueHaibing
This comment is outdated as fec_ptp_ioctl has been replaced by fec_ptp_set/fec_ptp_get since commit 1d5244d0e43b ("fec: Implement the SIOCGHWTSTAMP ioctl") Signed-off-by: YueHaibing --- drivers/net/ethernet/freescale/fec_ptp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/ne

RE: [PATCH net-next] net: fec: remove stale comment

2018-05-24 Thread Andy Duan
> From: YueHaibing Sent: 2018年5月24日 19:27 > This comment is outdated as fec_ptp_ioctl has been replaced by > fec_ptp_set/fec_ptp_get since commit 1d5244d0e43b ("fec: Implement > the SIOCGHWTSTAMP ioctl") > > Signed-off-by: YueHaibing Thanks. Acked-by: Fugang Duan > --- > drivers/net/ethernet/

RE: [PATCH net-next 1/1] bnx2x: Collect the device debug information during Tx timeout.

2018-05-24 Thread Kalluru, Sudarsana
-Original Message- From: Yuval Mintz [mailto:yuv...@mellanox.com] Sent: 24 May 2018 16:55 To: Kalluru, Sudarsana ; da...@davemloft.net Cc: netdev@vger.kernel.org Subject: RE: [PATCH net-next 1/1] bnx2x: Collect the device debug information during Tx timeout. > Tx-timeout mostly happens

[PATCH net-next v2 1/1] bnx2x: Collect the device debug information during Tx timeout.

2018-05-24 Thread Sudarsana Reddy Kalluru
Tx-timeout mostly happens due to some issue in the device. In such cases, debug dump would be helpful for identifying the cause of the issue. This patch adds support to spill debug data during the Tx timeout. Here bnx2x_panic_dump() API is used instead of bnx2x_panic(), since we still want to allow

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-24 Thread Tariq Toukan
On 24/05/2018 2:22 AM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory allocati

[PATCH 0/4] pull request for net: batman-adv 2018-05-24

2018-05-24 Thread Simon Wunderlich
in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20180524 for you to fetch changes up to 16116dac23396e73c0197b102e4833a4b205: batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs (2018-05-12 18:53:08 +0200

[PATCH 4/4] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs

2018-05-24 Thread Simon Wunderlich
From: Marek Lindner A translation table TVLV changset sent with an OGM consists of a number of headers (one per VLAN) plus the changeset itself (addition and/or deletion of entries). The per-VLAN headers are used by OGM recipients for consistency checks. Said consistency check might determine th

[PATCH 1/4] batman-adv: don't pass a NULL hard_iface to batadv_hardif_put

2018-05-24 Thread Simon Wunderlich
From: Colin Ian King In the case where hard_iface is NULL, the error path may pass a null pointer to batadv_hardif_put causing a null pointer dereference error. Avoid this by only calling the function if hard_iface not null. Detected by CoverityScan, CID#1466456 ("Explicit null dereferenced")

[PATCH 2/4] batman-adv: Avoid race in TT TVLV allocator helper

2018-05-24 Thread Simon Wunderlich
From: Sven Eckelmann The functions batadv_tt_prepare_tvlv_local_data and batadv_tt_prepare_tvlv_global_data are responsible for preparing a buffer which can be used to store the TVLV container for TT and add the VLAN information to it. This will be done in three phases: 1. count the number of V

[PATCH 3/4] batman-adv: Fix TT sync flags for intermediate TT responses

2018-05-24 Thread Simon Wunderlich
From: Linus Lüssing The previous TT sync fix so far only fixed TT responses issued by the target node directly. So far, TT responses issued by intermediate nodes still lead to the wrong flags being added, leading to CRC mismatches. This behaviour was observed at Freifunk Hannover in a 800 nodes

[PATCH 3/8] batman-adv: Avoid old nodes disabling multicast optimizations completely

2018-05-24 Thread Simon Wunderlich
From: Linus Lüssing Instead of disabling multicast optimizations mesh-wide once a node with no multicast optimizations capabilities joins the mesh, do the following: Just insert such nodes into the WANT_ALL_IPV4/IPV6 lists. This is sufficient to avoid multicast packet loss to such unsupportive n

[PATCH 8/8] batman-adv: enable B.A.T.M.A.N. V compilation by default

2018-05-24 Thread Simon Wunderlich
From: Marek Lindner Signed-off-by: Marek Lindner Acked-by: Antonio Quartulli Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig index bee0

[PATCH 4/8] batman-adv: Avoid bool in structures

2018-05-24 Thread Simon Wunderlich
From: Sven Eckelmann Using the bool type for structure member is considered inappropriate [1] for the kernel. Its size is not well defined (but usually 1 byte but maybe also 4 byte). [1] https://lkml.org/lkml/2017/11/21/384 Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- ne

[PATCH 6/8] batman-adv: fix batadv_interface_tx()'s return type

2018-05-24 Thread Simon Wunderlich
From: Luc Van Oostenryck The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck [s...@narfation.

[PATCH 5/8] batman-adv: Remove unused dentry without DEBUGFS

2018-05-24 Thread Simon Wunderlich
From: Sven Eckelmann The debug_dir variable in the main structures is only accessed when CONFIG_BATMAN_ADV_DEBUGFS is enabled. It can be dropped to potentially save some bytes of memory. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/types.h | 6 ++ 1 fil

[PATCH 7/8] batman-adv: disable ethtool link speed detection when auto negotiation off

2018-05-24 Thread Simon Wunderlich
From: Marek Lindner Virtual interface drivers such as tun / tap interfaces, VLAN, etc tend to initialize the interface throughput with some value for the sake of having a throughput number to export via ethtool. This exported throughput leaves batman-adv to conclude the interface throughput is ge

[PATCH 1/8] batman-adv: Start new development cycle

2018-05-24 Thread Simon Wunderlich
Signed-off-by: Simon Wunderlich --- net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 057a28a9fe88..8da3c9336111 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -25,7 +25,7 @@ #define BA

[PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

2018-05-24 Thread Simon Wunderlich
From: Sven Eckelmann All tools which were known to the batman-adv development team are supporting the batman-adv netlink interface since a while. Also debugfs is not supported for batman-adv interfaces in any non-default netns. Thus disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause

[PATCH 0/8] pull request for net-next: batman-adv 2017-05-24

2018-05-24 Thread Simon Wunderlich
the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20180524 for you to fetch changes up to 18cfb44cf1845d11d50f4733e039acb8b377c8eb: batman-adv: enable B.A.T.M.A.N. V compilation by default (2018-05-14 09:31:17 +0200

Re: [PATCH 8/8] batman-adv: enable B.A.T.M.A.N. V compilation by default

2018-05-24 Thread Joe Perches
On Thu, 2018-05-24 at 14:03 +0200, Simon Wunderlich wrote: > From: Marek Lindner > > Signed-off-by: Marek Lindner > Acked-by: Antonio Quartulli > Signed-off-by: Sven Eckelmann > Signed-off-by: Simon Wunderlich > --- > net/batman-adv/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod

2018-05-24 Thread Jamal Hadi Salim
On 23/05/18 07:01 PM, Cong Wang wrote: On Thu, May 17, 2018 at 12:33 PM, Fu, Qiaobin wrote: Hmm, but skbedit seems better than skbmod for this job, given: 1) It already modifies skb->priority, although with a given value 2) skbmod doesn't change skb metadata, it only changes payload I am _

[PATCH net-next v2] cxgb4/cxgb4vf: link management changes for new SFP

2018-05-24 Thread Ganesh Goudar
newer SFPs like SFP28 and QSFP28 Transceiver Modules present several new possibilities which we haven't faced before. Fix the assumptions in the code reflecting the more limited capabilities of previous Transceiver Module systems Original work by Casey Leedom Signed-off-by: Ganesh Goudar --- V2

[PATCH net-next] tcp: use data length instead of skb->len in tcp_probe

2018-05-24 Thread Yafang Shao
skb->len is meaningless to user. data length could be more helpful, with which we can easily filter out the packet without payload. Signed-off-by: Yafang Shao --- include/trace/events/tcp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/tcp.h b/inclu

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 11:48:31AM +0300, Ilias Apalodimas wrote: > On Thu, May 24, 2018 at 10:05:28AM +0200, Jiri Pirko wrote: > > Thu, May 24, 2018 at 08:56:20AM CEST, ilias.apalodi...@linaro.org wrote: > > Any reason you need cpu port? We don't need it in mlxsw and also in dsa. > Yes i've seen t

Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-24 Thread Jose Abreu
On 23-05-2018 16:00, Elad Nachman wrote: > Jose, > > I am not sure which drivers you have checked. I guess most non-networking > embedded drivers never use 802.1AD > so they stay broken unknowingly. > Specifically, I have tested Intel e1000e based card which works correctly > versus stmmac which

[PATCH net-next] cxgb4: clean up init_one

2018-05-24 Thread Ganesh Goudar
clean up init_one and use chip_ver consistently throughout init_one() for chip version. Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 47 +-- drivers/net/ethernet/chelsio/cxgb4/t4_chip_type.h | 2 + 2 files

Re: [PATCH 4/4] cpsw: add switchdev support

2018-05-24 Thread Andrew Lunn
> @@ -2626,7 +2750,11 @@ static int cpsw_probe_dt(struct cpsw_platform_data > *data, > data->mac_control = prop; > > if (of_property_read_bool(node, "dual_emac")) > - data->dual_emac = 1; > + data->switch_mode = CPSW_DUAL_EMAC; > + > + /* switchdev overrid

Re: [PATCH net-next v3 0/7] Add support for QCA8334 switch

2018-05-24 Thread Andrew Lunn
> Thank you too Florian. And also big thank to you Andrew. You helped me > a lot to debug the RGMII issue. I have been stuck at that for more than > a month and would not resolve it without your help. We are here to help. I also got stuck figuring out RGMII issues, so i know what it feels like...

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 02:11:53PM +0300, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. > > Another note is that the change implicitly repl

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 02:11:55PM +0300, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .set_link_ksettings > callback with a shared phy_ethtool_set_link_ksettings(), this fixes > sleep in atomic context bug, which is encountered every time when link > settings are chan

Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 02:11:56PM +0300, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. > > Another note is that the change implicitly repl

Re: [PATCH 5/6] sh_eth: remove custom .get_link_ksettings from ethtool ops

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 02:14:43PM +0300, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .get_link_ksettings > callback with a shared phy_ethtool_get_link_ksettings(), note that > &priv->lock wrapping is not needed, because the lock does not > serialize access to phydev

Re: [PATCH 4/4] cpsw: add switchdev support

2018-05-24 Thread Ilias Apalodimas
On Thu, May 24, 2018 at 03:12:29PM +0200, Andrew Lunn wrote: > Device tree is supposed to describe the hardware. Using that hardware > in different ways is not something you should describe in DT. > The new switchdev mode is applied with a .config option in the kernel. What you see is pre-existing

Re: [PATCH net-next] bpfilter: fix build dependency

2018-05-24 Thread David Miller
From: Alexei Starovoitov Date: Wed, 23 May 2018 21:29:05 -0700 > BPFILTER could have been enabled without INET causing this build error: > ERROR: "bpfilter_process_sockopt" [net/bpfilter/bpfilter.ko] undefined! > > Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module") > Reported-by

Re: [PATCH net-next] bpfilter: don't pass O_CREAT when opening console for debug

2018-05-24 Thread David Miller
From: Jakub Kicinski Date: Thu, 24 May 2018 00:41:19 -0700 > Passing O_CREAT (0100) to open means we should also pass file > mode as the third parameter. Creating /dev/console as a regular > file may not be helpful anyway, so simply drop the flag when > opening debug_fd. > > Fixes: d2ba09c1

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-24 Thread Ivan Vecera
On 24.5.2018 14:54, Andrew Lunn wrote: > On Thu, May 24, 2018 at 11:48:31AM +0300, Ilias Apalodimas wrote: >> On Thu, May 24, 2018 at 10:05:28AM +0200, Jiri Pirko wrote: >>> Thu, May 24, 2018 at 08:56:20AM CEST, ilias.apalodi...@linaro.org wrote: >>> Any reason you need cpu port? We don't need it i

Re: [PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

2018-05-24 Thread Mark Brown
On Thu, May 24, 2018 at 09:06:58AM +0200, Robert Jarzmik wrote: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. Acked-by: Mark Brown signature.asc Description: P

[PATCH net-next] cxgb4/cxgb4vf: Notify link changes to OS-dependent code

2018-05-24 Thread Ganesh Goudar
From: Arjun Vynipadath We have a confusion of two different abstractions in the Common Code: Physical Link (Port) and Logical Network Interface (Virtual Interface), and we haven't been properly managing the state of the intersection of those two abstractions. On the one hand we have the Physical

Re: [PATCH v2] ppp: remove the PPPIOCDETACH ioctl

2018-05-24 Thread Guillaume Nault
On Wed, May 23, 2018 at 02:37:38PM -0700, Eric Biggers wrote: > From: Eric Biggers > > The PPPIOCDETACH ioctl effectively tries to "close" the given ppp file > before f_count has reached 0, which is fundamentally a bad idea. It > does check 'f_count < 2', which excludes concurrent operations on

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
Hi Andrew, On 05/24/2018 04:29 PM, Andrew Lunn wrote: > On Thu, May 24, 2018 at 02:11:55PM +0300, Vladimir Zapolskiy wrote: >> The change replaces a custom implementation of .set_link_ksettings >> callback with a shared phy_ethtool_set_link_ksettings(), this fixes >> sleep in atomic context bug, w

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-24 Thread Ilias Apalodimas
On Thu, May 24, 2018 at 03:44:54PM +0200, Ivan Vecera wrote: > On 24.5.2018 14:54, Andrew Lunn wrote: > > On Thu, May 24, 2018 at 11:48:31AM +0300, Ilias Apalodimas wrote: > >> On Thu, May 24, 2018 at 10:05:28AM +0200, Jiri Pirko wrote: > >>> Thu, May 24, 2018 at 08:56:20AM CEST, ilias.apalodi...@l

[PATCH] net: stmmac: Use mutex instead of spinlock

2018-05-24 Thread Thierry Reding
From: Thierry Reding Some drivers, such as DWC EQOS on Tegra, need to perform operations that can sleep under this lock (clk_set_rate() in tegra_eqos_fix_speed()) for proper operation. Since there is no need for this lock to be a spinlock, convert it to a mutex instead. Fixes: e6ea2d16fc61 ("net

[PATCH net] selftests/net: Add missing config options for PMTU tests

2018-05-24 Thread Stefano Brivio
PMTU tests in pmtu.sh need support for VTI, VTI6 and dummy interfaces: add them to config file. Reported-by: Naresh Kamboju Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test") Signed-off-by: Stefano Brivio --- tools/testing/selftests/net/config | 5 + 1 file changed, 5 inserti

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
On 05/24/2018 04:22 PM, Andrew Lunn wrote: > On Thu, May 24, 2018 at 02:11:53PM +0300, Vladimir Zapolskiy wrote: >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phydev fields by a mutex. >> >

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-24 Thread Huy Nguyen
On 5/23/2018 3:19 PM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h index 2c0c6453c3f4..1ddc0a44c172 100644 --- a/include/uapi/linux/dcbnl.h +++ b/include/uapi/linux/dcbnl.h @@ -163,6 +163,15

[PATCH net-next 01/10] selftests: forwarding: Split mirror_gre_topo_lib.sh

2018-05-24 Thread Petr Machata
Move generic parts of mirror_gre_topo_lib.sh into a new file mirror_topo_lib.sh. Reuse the functions in GRE topo, adding the tunnel devices as necessary. Signed-off-by: Petr Machata --- .../net/forwarding/mirror_gre_topo_lib.sh | 53 ++-- .../selftests/net/forwarding/mirror_topo

[PATCH net-next 00/10] Mirroring tests involving VLAN

2018-05-24 Thread Petr Machata
This patchset tests mirror-to-gretap with various underlay configurations involving VLAN netdevice in particular. Some of the tests involve bridges as well, but tests aimed specifically at testing bridges (i.e. FDB, STP) are not part of this patchset. In patches #1-#6, the codebase is adapted to s

[PATCH net-next 05/10] selftests: forwarding: mirror_gre_lib: Support VLAN

2018-05-24 Thread Petr Machata
Add full_test_span_gre_dir_vlan_ips() and full_test_span_gre_dir_vlan() to support mirror-to-gre tests that involve VLAN. Signed-off-by: Petr Machata --- .../selftests/net/forwarding/mirror_gre_lib.sh | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tools/testing/s

  1   2   3   >