Re: [RFC PATCH bpf-next 05/12] xdp: add MEM_TYPE_ZERO_COPY

2018-05-17 Thread Björn Töpel
2018-05-17 7:57 GMT+02:00 Jesper Dangaard Brouer : > On Tue, 15 May 2018 21:06:08 +0200 > Björn Töpel wrote: > >> @@ -82,6 +88,10 @@ struct xdp_frame *convert_to_xdp_frame(struct xdp_buff >> *xdp) >> int metasize; >> int headroom; >> >> + // XXX implement clone, copy, use "native"

Re: [RFC PATCH bpf-next 05/12] xdp: add MEM_TYPE_ZERO_COPY

2018-05-17 Thread Björn Töpel
2018-05-17 9:08 GMT+02:00 Björn Töpel : > 2018-05-17 7:57 GMT+02:00 Jesper Dangaard Brouer : >> On Tue, 15 May 2018 21:06:08 +0200 >> Björn Töpel wrote: >> >>> @@ -82,6 +88,10 @@ struct xdp_frame *convert_to_xdp_frame(struct xdp_buff >>> *xdp) >>> int metasize; >>> int headroom; >>> >

Re: [PATCH 2/3] sh_eth: add EDMR.NBST support

2018-05-17 Thread Simon Horman
On Wed, May 16, 2018 at 10:58:26PM +0300, Sergei Shtylyov wrote: > The R-Car V3H (AKA R8A77980) GEther controller adds the DMA burst mode bit > (NBST) in EDMR and the manual tells to always set it before doing any DMA. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-of

Re: [PATCH 1/3] sh_eth: add RGMII support

2018-05-17 Thread Sergei Shtylyov
On 5/16/2018 11:37 PM, Andrew Lunn wrote: What about PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID, PHY_INTERFACE_MODE_RGMII_TXID, Oops, totally forgot about those... :-/ Everybody does. I keep intending to write a email template for this, and phy_int

[PATCH] net: qcom/emac: Allocate buffers from local node

2018-05-17 Thread Hemanth Puranik
Currently we use non-NUMA aware allocation for TPD and RRD buffers, this patch modifies to use NUMA friendly allocation. Signed-off-by: Hemanth Puranik --- drivers/net/ethernet/qualcomm/emac/emac-mac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next v3 06/10] net: mvpp2: 2500baseX support

2018-05-17 Thread Antoine Tenart
This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 51 +--- 1 file changed, 39 ins

[PATCH net-next v3 10/10] arm64: dts: marvell: 7040-db: describe the 10G interface as fixed-link

2018-05-17 Thread Antoine Tenart
This patch adds a fixed-link node to the 10G interface of the 7040-db board. This is required as the mvpp2 driver now uses phylink. The best solution would have been to describe the SFP cage but they are not wired correctly, and thus unusable, so we chose to use fixed-link instead. Signed-off-by:

[PATCH net-next v3 09/10] arm64: dts: marvell: 8040-db: describe the 10G interfaces as fixed-link

2018-05-17 Thread Antoine Tenart
This patch adds a fixed-link node to both 10G interfaces of the 8040-db board. This is required as the mvpp2 driver now uses phylink. The best solution would have been to describe the SFP cages but they are not wired correctly, and thus unusable, so we chose to use fixed-link instead. Signed-off-b

[PATCH net-next v3 01/10] net: mvpp2: align the ethtool ops definition

2018-05-17 Thread Antoine Tenart
Cosmetic patch to align the ethtool functions to ops definitions. This patch does not change in any way the driver's behaviour. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/dr

[PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Antoine Tenart
Hi Dave, Russell, This series convert the Marvell PPv2 driver to phylink (models the MAC to PHY link). One important point is the PPv2 driver supports two probe modes: device tree and ACPI. This series only brings phylink support for the device tree mode, as the ACPI one will need further work. S

[PATCH net-next v3 04/10] phy: cp110-comphy: 2.5G SGMII mode

2018-05-17 Thread Antoine Tenart
This patch allow the CP110 comphy to configure some lanes in the 2.5G SGMII mode. This mode is quite close to SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 17 ++--- 1 file changed, 14 insertions(+), 3 delet

[PATCH net-next v3 02/10] net: mvpp2: phylink support

2018-05-17 Thread Antoine Tenart
Convert the PPv2 driver to implement phylink helpers, and use phylink in DT mode. The other mode supported is ACPI, which will need further work in order to be entirely compatible with phylink. The MAC and GoP configuration functions were completely moved to fit into the phylink helpers. When a PH

[PATCH net-next v3 08/10] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-05-17 Thread Antoine Tenart
This patch enables the fourth network interface on the Marvell Macchiatobin. It is configured in the 2500Base-X PHY mode. The SFP cage is also described. Signed-off-by: Antoine Tenart --- .../boot/dts/marvell/armada-8040-mcbin.dts| 32 +++ 1 file changed, 32 insertions(+) di

[PATCH net-next 2/2] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-17 Thread Antoine Tenart
In case no Tx disable pin is available the SFP modules will always be emitting. This could be an issue when using modules using laser as their light source as we would have no way to disable it when the fiber is removed. This patch adds a warning when registering an SFP cage which do not have its t

[PATCH net-next v3 03/10] phy: add 2.5G SGMII mode to the phy_mode enum

2018-05-17 Thread Antoine Tenart
This patch adds one more generic PHY mode to the phy_mode enum, to allow configuring generic PHYs to the 2.5G SGMII mode by using the set_mode callback. Signed-off-by: Antoine Tenart Acked-by: Kishon Vijay Abraham I --- include/linux/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH net-next 0/2] net: sfp: small improvements

2018-05-17 Thread Antoine Tenart
Hi Russell, This series was part of the mvpp2 phylink one but as we reworked it to use fixed-link on the DB boards, the SFP commits weren't needed anymore for our use case. Two of the three patches still are needed I believe (I ditched the one about non-wired SFP cages), so they are sent here in a

[PATCH net-next v3 07/10] arm64: dts: marvell: mcbin: add 10G SFP support

2018-05-17 Thread Antoine Tenart
From: Russell King This patch adds the SFP cage description in the Marvell Armada 8040 mcbin, for both 10G interfaces. Signed-off-by: Russell King [Antoine: small reworks, commit message] Signed-off-by: Antoine Tenart --- .../boot/dts/marvell/armada-8040-mcbin.dts| 38 +++

[PATCH net-next 2/3] net: mvpp2: set mac address does not require the stop/start sequence

2018-05-17 Thread Antoine Tenart
From: Yan Markman Remove special stop/start handling from the set_mac_address callback. All this special care is not needed, and can be removed. It also simplifies the up/down status in the driver and helps avoiding possible link status mismatch issues. Signed-off-by: Yan Markman [Antoine: comm

[PATCH net-next 1/3] net: mvpp2: avoid checking for free aggregated descriptors twice

2018-05-17 Thread Antoine Tenart
From: Yan Markman Avoid repeating the check for free aggregated descriptors when it already failed at the beginning of the function. Signed-off-by: Yan Markman [Antoine: commit message] Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 7 +++ 1 file changed, 3 inser

[PATCH net-next 3/3] net: mvpp2: print rx error with rate-limit

2018-05-17 Thread Antoine Tenart
From: Yan Markman Prevent flood of RX error prints during heavy traffic with weak signal in link by checking net_ratelimit() before using netdev_err(). Signed-off-by: Yan Markman [Antoine: small rework, commit message] Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 1

[PATCH net-next v3 05/10] net: mvpp2: 1000baseX support

2018-05-17 Thread Antoine Tenart
This patch adds the 1000Base-X PHY mode support in the Marvell PPv2 driver. 1000Base-X is quite close the SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 72 1 file changed, 51 insertions(+), 21 delet

[PATCH net-next 0/3] net: mvpp2: small improvements

2018-05-17 Thread Antoine Tenart
Hi all, Those 3 patches are small improvements to the Marvell PPv2 driver. The series does not conflict with the one sent about phylink and 1000/2500baseX support, so the two series can live in parallel. Thanks! Antoine Yan Markman (3): net: mvpp2: avoid checking for free aggregated descriptor

[PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Antoine Tenart
The SFF,SFP documentation is clear about making all the DT properties, with the exception of the compatible, optional. In practice this is not the case and without an i2c-bus property provided the SFP code will throw NULL pointer exceptions. This patch is an attempt to fix this. Signed-off-by: An

[PATCH] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
When allocating a xt_table_info structure, we should be clearing out the full amount of memory that was allocated, not just the "header" of the structure. Otherwise odd values could be passed to userspace, which is not a good thing. Cc: stable Signed-off-by: Greg Kroah-Hartman --- net/netfilte

pull-request: wireless-drivers-next 2018-05-17

2018-05-17 Thread Kalle Valo
Hi Dave, here's a pull request to net-next for 4.18. I forgot to mention in the signed tag was that one id is added to include/linux/mmc/sdio_ids.h but that was acked by Ulf. I suspect hat because of my merge of wireless-drivers into wireless-drivers-next the diffstat from request-pull was wrong

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

2018-05-17 Thread Jiri Pirko
Thu, Mar 22, 2018 at 08:25:46PM CET, andrew.gospoda...@broadcom.com wrote: >On Thu, Mar 22, 2018 at 01:10:38PM -0600, David Ahern wrote: >> On 3/22/18 11:49 AM, Jiri Pirko wrote: >> > Thu, Mar 22, 2018 at 04:34:07PM CET, dsah...@gmail.com wrote: >> >> On 3/22/18 4:55 AM, Jiri Pirko wrote: >> >>> Fr

Re: [BUG] net: stmmac: dwmac-sun8i broken in linux-next

2018-05-17 Thread Jose Abreu
Hi Corentin, On 16-05-2018 19:32, Corentin Labbe wrote: > Hello > > The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX > errors as shown by ifconfig: > eth0: flags=4163 mtu 1500 > inet 192.168.1.204 netmask 255.255.255.0 broadcast 192.168.1.255 > ether

Re: net: ieee802154: 6lowpan: fix frag reassembly

2018-05-17 Thread Greg KH
On Mon, May 14, 2018 at 05:22:18PM +0200, Stefan Schmidt wrote: > Hello. > > > Please apply f18fa5de5ba7f1d6650951502bb96a6e4715a948 > > (net: ieee802154: 6lowpan: fix frag reassembly) to the 4.16.x stable tree. > > > Earlier trees are not needed as the problem was introduced in 4.16. Really?

Re: [PATCH] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Michal Kubecek
On Thu, May 17, 2018 at 10:44:42AM +0200, Greg Kroah-Hartman wrote: > When allocating a xt_table_info structure, we should be clearing out the > full amount of memory that was allocated, not just the "header" of the > structure. Otherwise odd values could be passed to userspace, which is > not a g

Re: [PATCH 3/3] sh_eth: add R8A77980 support

2018-05-17 Thread Simon Horman
On Wed, May 16, 2018 at 11:00:29PM +0300, Sergei Shtylyov wrote: > Finally, add support for the DT probing of the R-Car V3H (AKA R8A77980) -- > it's the only R-Car gen3 SoC having the GEther controller -- others have > only EtherAVB... > > Based on the original (and large) patch by Vladimir Barino

Re: [PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Russell King - ARM Linux
On Thu, May 17, 2018 at 10:29:29AM +0200, Antoine Tenart wrote: > Since v2: > - Removed the SFP description from the DB boards, as their SFP cages > are wired properly. We now use fixed-link. I think you mean "improperly" here. -- RMK's Patch system: http://www.armlinux.org.uk/developer/pa

Re: xdp and fragments with virtio

2018-05-17 Thread Jason Wang
On 2018年05月17日 10:55, David Ahern wrote: On 5/16/18 1:24 AM, Jason Wang wrote: On 2018年05月16日 11:51, David Ahern wrote: Hi Jason: I am trying to test MTU changes to the BPF fib_lookup helper and seeing something odd. Hoping you can help. I have a VM with multiple virtio based NICs and tap

Re: [PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Antoine Tenart
Hi Russell, On Thu, May 17, 2018 at 10:18:56AM +0100, Russell King - ARM Linux wrote: > On Thu, May 17, 2018 at 10:29:29AM +0200, Antoine Tenart wrote: > > Since v2: > > - Removed the SFP description from the DB boards, as their SFP cages > > are wired properly. We now use fixed-link. > > I

Re: [PATCH] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
On Thu, May 17, 2018 at 10:59:51AM +0200, Michal Kubecek wrote: > On Thu, May 17, 2018 at 10:44:42AM +0200, Greg Kroah-Hartman wrote: > > When allocating a xt_table_info structure, we should be clearing out the > > full amount of memory that was allocated, not just the "header" of the > > structure

[PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
When allocating a xt_table_info structure, we should be clearing out the full amount of memory that was allocated, not just the "header" of the structure. Otherwise odd values could be passed to userspace, which is not a good thing. Cc: stable Signed-off-by: Greg Kroah-Hartman --- v2: use kvzal

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Eric Dumazet
On 05/17/2018 02:34 AM, Greg Kroah-Hartman wrote: > When allocating a xt_table_info structure, we should be clearing out the > full amount of memory that was allocated, not just the "header" of the > structure. Otherwise odd values could be passed to userspace, which is > not a good thing. > >

[PATCH net-next] net: stmmac: Populate missing callbacks in HWIF initialization

2018-05-17 Thread Jose Abreu
Some HW specific setusp, like sun8i, do not populate all the necessary callbacks, which is what HWIF helpers were expecting. Fix this by always trying to get the generic helpers and populate them if they were not previously populated by HW specific setup. Signed-off-by: Jose Abreu Fixes: 5f0456b

[patch net-next] nfp: flower: set sysfs link to device for representors

2018-05-17 Thread Jiri Pirko
From: Jiri Pirko Do this so the sysfs has "device" link correctly set. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/netronome/nfp/flower/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flowe

[patch net-next] nfp: flower: fix error path during representor creation

2018-05-17 Thread Jiri Pirko
From: Jiri Pirko Don't store repr pointer to reprs array until the representor is successfully created. This avoids message about "representor destruction" even when it was never created. Also it cleans-up the flow. Also, check return value after port alloc. Signed-off-by: Jiri Pirko --- drive

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
On Thu, May 17, 2018 at 02:55:42AM -0700, Eric Dumazet wrote: > > > On 05/17/2018 02:34 AM, Greg Kroah-Hartman wrote: > > When allocating a xt_table_info structure, we should be clearing out the > > full amount of memory that was allocated, not just the "header" of the > > structure. Otherwise o

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Jan Engelhardt
On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: >> > --- a/net/netfilter/x_tables.c >> > +++ b/net/netfilter/x_tables.c >> > @@ -1183,11 +1183,10 @@ struct xt_table_info *xt_alloc_table_info(unsigned >> > int size) >> > * than shoot all processes down before realizing there is nothing

[PATCH net 1/1] net/smc: initialize tx_work before llc initial handshake

2018-05-17 Thread Ursula Braun
From: Karsten Graul When the llc handshake fails in an early state, the general cleanup routines may try to cancel an uninitialized worker. Avoid this by initializing the worker before the llc initial handshake starts. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/af_sm

[PATCH net-next] net/smc: init conn.tx_work & conn.send_lock sooner

2018-05-17 Thread Eric Dumazet
syzkaller found that following program crashes the host : { int fd = socket(AF_SMC, SOCK_STREAM, 0); int val = 1; listen(fd, 0); shutdown(fd, SHUT_RDWR); setsockopt(fd, 6, TCP_NODELAY, &val, 4); } Simply initialize conn.tx_work & conn.send_lock at socket creation, rather than deeper in

Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Eric Dumazet
On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: > The ACK filter is an optional feature of CAKE which is designed to improve > performance on links with very asymmetrical rate limits. On such links > (which are unfortunately quite prevalent, especially for DSL and cable > subscribers), the

Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: >> The ACK filter is an optional feature of CAKE which is designed to improve >> performance on links with very asymmetrical rate limits. On such links >> (which are unfortunately quite prevalent, especially for DSL and

[PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

2018-05-17 Thread Ramon Fried
From: Eyal Ilsar Introduce infrastructure for supporting Factory Test Mode (FTM) of the wireless LAN subsystem. In order for the user space to access the firmware in test mode the relevant netlink channel needs to be exposed from the kernel driver. The above is achieved as follows: 1) Register w

Re: [PATCH] net: qcom/emac: Allocate buffers from local node

2018-05-17 Thread Timur Tabi
On 5/17/18 3:28 AM, Hemanth Puranik wrote: Currently we use non-NUMA aware allocation for TPD and RRD buffers, this patch modifies to use NUMA friendly allocation. Signed-off-by: Hemanth Puranik Acked-by: Timur Tabi -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Techno

Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Eric Dumazet
On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: > > We don't do full parsing of SACKs, no; we were trying to keep things > simple... We do detect the presence of SACK options, though, and the > presence of SACK options on an ACK will make previous ACKs be considered > redundant. > But t

Re: [RFC v4 3/5] virtio_ring: add packed ring support

2018-05-17 Thread Jason Wang
On 2018年05月16日 22:33, Tiwei Bie wrote: On Wed, May 16, 2018 at 10:05:44PM +0800, Jason Wang wrote: On 2018年05月16日 21:45, Tiwei Bie wrote: On Wed, May 16, 2018 at 08:51:43PM +0800, Jason Wang wrote: On 2018年05月16日 20:39, Tiwei Bie wrote: On Wed, May 16, 2018 at 07:50:16PM +0800, Jason Wang w

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Quentin Monnet
2018-05-16 22:04 UTC+0100 ~ Sean Young > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be attached to using the bpf(BPF_PROG_ATTACH)

[PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Eric Dumazet
When TCP receives an out-of-order packet, it immediately sends a SACK packet, generating network load but also forcing the receiver to send 1-MSS pathological packets, increasing its RTX queue length/depth, and thus processing time. Wifi networks suffer from this aggressive behavior, but generally

[PATCH net-next 4/4] tcp: add TCPAckCompressed SNMP counter

2018-05-17 Thread Eric Dumazet
This counter tracks number of ACK packets that the host has not sent, thanks to ACK compression. Sample output : $ nstat -n;sleep 1;nstat|egrep "IpInReceives|IpOutRequests|TcpInSegs|TcpOutSegs|TcpExtTCPAckCompressed" IpInReceives123250 0.0 IpOutRequests

[PATCH net-next 1/4] tcp: use __sock_put() instead of sock_put() in tcp_clear_xmit_timers()

2018-05-17 Thread Eric Dumazet
Socket can not disappear under us. Signed-off-by: Eric Dumazet --- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index a08eab58ef7001b3e141e3722fd8a3875e5c5d7d..6ffc8bd894876ad23407f5ec4994350139af85e7 100644 --- a/i

[PATCH net-next 0/4] tcp: implement SACK compression

2018-05-17 Thread Eric Dumazet
When TCP receives an out-of-order packet, it immediately sends a SACK packet, generating network load but also forcing the receiver to send 1-MSS pathological packets, increasing its RTX queue length/depth, and thus processing time. Wifi networks suffer from this aggressive behavior, but generally

[PATCH net-next 2/4] tcp: do not force quickack when receiving out-of-order packets

2018-05-17 Thread Eric Dumazet
As explained in commit 9f9843a751d0 ("tcp: properly handle stretch acks in slow start"), TCP stacks have to consider how many packets are acknowledged in one single ACK, because of GRO, but also because of ACK compression or losses. We plan to add SACK compression in the following patch, we must t

Re: [PATCH net-next] net/smc: init conn.tx_work & conn.send_lock sooner

2018-05-17 Thread Ursula Braun
On 05/17/2018 12:54 PM, Eric Dumazet wrote: > syzkaller found that following program crashes the host : > > { > int fd = socket(AF_SMC, SOCK_STREAM, 0); > int val = 1; > > listen(fd, 0); > shutdown(fd, SHUT_RDWR); > setsockopt(fd, 6, TCP_NODELAY, &val, 4); > } > > Simply initialize c

Re: [PATCH net-next] net/smc: init conn.tx_work & conn.send_lock sooner

2018-05-17 Thread Eric Dumazet
On Thu, May 17, 2018 at 5:13 AM Ursula Braun wrote: > This problem should no longer show up with yesterday's net-next commit > 569bc6436568 ("net/smc: no tx work trigger for fallback sockets"). It definitely triggers on latest net-next, which includes 569bc6436568 Thanks.

Re: [PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Gregory CLEMENT
Hi Antoine, On jeu., mai 17 2018, Antoine Tenart wrote: > Hi Dave, Russell, > > This series convert the Marvell PPv2 driver to phylink (models the MAC > to PHY link). > > One important point is the PPv2 driver supports two probe modes: device > tree and ACPI. This series only brings phylink su

Re: [patch net-next] nfp: flower: set sysfs link to device for representors

2018-05-17 Thread Or Gerlitz
On Thu, May 17, 2018 at 1:05 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Do this so the sysfs has "device" link correctly set. please no This is likely to create bunch of issues with respect to how libvirt deals with the representors. We were discussing it off list between nfp and mlnx driver

[PATCH bpf-next v6 0/6] ipv6: sr: introduce seg6local End.BPF action

2018-05-17 Thread Mathieu Xhonneux
As of Linux 4.14, it is possible to define advanced local processing for IPv6 packets with a Segment Routing Header through the seg6local LWT infrastructure. This LWT implements the network programming principles defined in the IETF “SRv6 Network Programming” draft. The implemented operations are

[PATCH bpf-next v6 5/6] ipv6: sr: Add seg6local action End.BPF

2018-05-17 Thread Mathieu Xhonneux
This patch adds the End.BPF action to the LWT seg6local infrastructure. This action works like any other seg6local End action, meaning that an IPv6 header with SRH is needed, whose DA has to be equal to the SID of the action. It will also advance the SRH to the next segment, the BPF program does no

[PATCH bpf-next v6 2/6] ipv6: sr: export function lookup_nexthop

2018-05-17 Thread Mathieu Xhonneux
The function lookup_nexthop is essential to implement most of the seg6local actions. As we want to provide a BPF helper allowing to apply some of these actions on the packet being processed, the helper should be able to call this function, hence the need to make it public. Moreover, if one argumen

[PATCH bpf-next v6 4/6] bpf: Split lwt inout verifier structures

2018-05-17 Thread Mathieu Xhonneux
The new bpf_lwt_push_encap helper should only be accessible within the LWT BPF IN hook, and not the OUT one, as this may lead to a skb under panic. At the moment, both LWT BPF IN and OUT share the same list of helpers, whose calls are authorized by the verifier. This patch separates the verifier o

[PATCH bpf-next v6 1/6] ipv6: sr: make seg6.h includable without IPv6

2018-05-17 Thread Mathieu Xhonneux
include/net/seg6.h cannot be included in a source file if CONFIG_IPV6 is not enabled: include/net/seg6.h: In function 'seg6_pernet': >> include/net/seg6.h:52:14: error: 'struct net' has no member named 'ipv6'; did you mean 'ipv4'? return net->ipv6.seg

[PATCH bpf-next v6 6/6] selftests/bpf: test for seg6local End.BPF action

2018-05-17 Thread Mathieu Xhonneux
Add a new test for the seg6local End.BPF action. The following helpers are also tested: - bpf_lwt_push_encap within the LWT BPF IN hook - bpf_lwt_seg6_action - bpf_lwt_seg6_adjust_srh - bpf_lwt_seg6_store_bytes A chain of End.BPF actions is built. The SRH is injected through a LWT BPF IN hook bef

[PATCH bpf-next v6 3/6] bpf: Add IPv6 Segment Routing helpers

2018-05-17 Thread Mathieu Xhonneux
The BPF seg6local hook should be powerful enough to enable users to implement most of the use-cases one could think of. After some thinking, we figured out that the following actions should be possible on a SRv6 packet, requiring 3 specific helpers : - bpf_lwt_seg6_store_bytes: Modify non-sensi

[PATCH] net/ncsi: prevent a couple array underflows

2018-05-17 Thread Dan Carpenter
We recently refactored this code and introduced a static checker warning. Smatch complains that if cmd->index is zero then we would underflow the arrays. That's obviously true. The question is whether we prevent cmd->index from being zero at a different level. I've looked at the code and I don'

Re: [PATCH V2 8/8] dt-bindings: stm32: add compatible for syscon

2018-05-17 Thread Rob Herring
On Tue, May 15, 2018 at 11:19 AM, Christophe ROULLIER wrote: > Hi Rob, Please don't top post to lists. > > I do not understand, so let me explain our status: > > We have syscfg IP Harware in our SOC. Add a compatible string that uniquely identifies what the block is. So something like "st,stm32f

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Andrew Lunn
On Thu, May 17, 2018 at 10:29:06AM +0200, Antoine Tenart wrote: > The SFF,SFP documentation is clear about making all the DT properties, > with the exception of the compatible, optional. In practice this is not > the case and without an i2c-bus property provided the SFP code will > throw NULL point

Re: [patch net-next] nfp: flower: set sysfs link to device for representors

2018-05-17 Thread Jiri Pirko
Thu, May 17, 2018 at 02:25:14PM CEST, gerlitz...@gmail.com wrote: >On Thu, May 17, 2018 at 1:05 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Do this so the sysfs has "device" link correctly set. > >please no > >This is likely to create bunch of issues with respect to how libvirt >deals with th

[PATCH bpf-next] bpf: change eBPF helper doc parsing script to allow for smaller indent

2018-05-17 Thread Quentin Monnet
Documentation for eBPF helpers can be parsed from bpf.h and eventually turned into a man page. Commit 6f96674dbd8c ("bpf: relax constraints on formatting for eBPF helper documentation") changed the script used to parse it, in order to allow for different indent style and to ease the work for writin

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Antoine Tenart
Hi Andrew, On Thu, May 17, 2018 at 02:41:28PM +0200, Andrew Lunn wrote: > On Thu, May 17, 2018 at 10:29:06AM +0200, Antoine Tenart wrote: > > The SFF,SFP documentation is clear about making all the DT properties, > > with the exception of the compatible, optional. In practice this is not > > the c

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Andrew Lunn
On Thu, May 17, 2018 at 02:56:48PM +0200, Antoine Tenart wrote: > Hi Andrew, > > On Thu, May 17, 2018 at 02:41:28PM +0200, Andrew Lunn wrote: > > On Thu, May 17, 2018 at 10:29:06AM +0200, Antoine Tenart wrote: > > > The SFF,SFP documentation is clear about making all the DT properties, > > > with

[PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

2018-05-17 Thread Andrea Greco
From: Andrea Greco Add support for com20022I/com20020, io mapped. Signed-off-by: Andrea Greco --- drivers/net/arcnet/Kconfig | 9 +- drivers/net/arcnet/Makefile | 1 + drivers/net/arcnet/arcdevice.h | 14 ++ drivers/net/arcnet/com20020-io.c | 287 +

[PATCH 2/4] arcnet: com20020: bindings for smsc com20020

2018-05-17 Thread Andrea Greco
From: Andrea Greco Add devicetree bindings for smsc com20020 Signed-off-by: Andrea Greco --- .../devicetree/bindings/net/smsc-com20020.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/smsc-com20020.txt diff --git

[PATCH 3/4] arcnet: com20020: Fixup missing SLOWARB bit

2018-05-17 Thread Andrea Greco
From: Andrea Greco If com20020 clock is major of 40Mhz SLOWARB bit is requested. Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index 2fd00d2dd6bf..f1de02f05305

[PATCH 4/4] arcnet: com20020: Add ethtool support

2018-05-17 Thread Andrea Greco
From: Andrea Greco Setup ethtols for export com20020 diag register Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020-io.c | 1 + drivers/net/arcnet/com20020-isa.c | 1 + drivers/net/arcnet/com20020.c | 24 drivers/net/arcnet/com20020.h | 1 + driv

Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: > >> >> We don't do full parsing of SACKs, no; we were trying to keep things >> simple... We do detect the presence of SACK options, though, and the >> presence of SACK options on an ACK will make previous ACKs be consi

[PATCH net-next 1/1] tc-testing: fixed copy-pasting error in ife tests

2018-05-17 Thread Roman Mashak
Reported-by: Vlad Buslov Reported-by: Davide Caratti Signed-off-by: Roman Mashak --- .../selftests/tc-testing/tc-tests/actions/ife.json | 28 +++--- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/ife.json b/to

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Antoine Tenart
On Thu, May 17, 2018 at 03:04:06PM +0200, Andrew Lunn wrote: > > I was thinking about how it reads the bit rate from the EEPROM. From > that it determines what mode the MAC could use, 1000-Base-X, > 2500-Base-X, etc. Can you still configure this correctly via ethtool, > if you don't have the bitra

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: > >> > --- a/net/netfilter/x_tables.c > >> > +++ b/net/netfilter/x_tables.c > >> > @@ -1183,11 +1183,10 @@ struct xt_table_info > >> > *xt_alloc_table_info(unsigned int size

Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-17 Thread Jose Abreu
Hi David, Florian, Results of slowing down CPU follows bellow. On 16-05-2018 20:01, Florian Fainelli wrote: > On 05/16/2018 11:56 AM, David Miller wrote: >> From: Jose Abreu >> Date: Wed, 16 May 2018 13:50:42 +0100 >> >>> David raised some rightfull constrains about the use of indirect callbacks

[PATCH iproute2-next 1/1] tc: add missing space symbol in ife output

2018-05-17 Thread Roman Mashak
In order to make TDC tests match the output patterns, the missing space character must be added in the mode output string. Signed-off-by: Roman Mashak --- tc/m_ife.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_ife.c b/tc/m_ife.c index 5320e94dbd48..20e9c73d9a0e 10064

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-17 Thread Vlad Buslov
On Wed 16 May 2018 at 21:51, Jiri Pirko wrote: > Wed, May 16, 2018 at 11:23:41PM CEST, vla...@mellanox.com wrote: >> >>On Wed 16 May 2018 at 17:36, Roman Mashak wrote: >>> Vlad Buslov writes: >>> On Wed 16 May 2018 at 14:38, Roman Mashak wrote: > On Wed, May 16, 2018 at 2:43 AM, Vlad

[QUESTION] ehea memory notifier

2018-05-17 Thread David Hildenbrand
Hi, looking at the ehea_mem_notifier() and called functions, I wonder if it can tolerate addresses and sizes that are not aligned to EHEA_SECTSIZE. Looks like for MEM_ONLINE/MEM_GOING_OFFLINE ehea_update_busmap() will do nothing in case we don't span at least one EHEA_SECTSIZE. This implies, tha

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Sean Young
Hi Quentin, On Thu, May 17, 2018 at 01:10:56PM +0100, Quentin Monnet wrote: > 2018-05-16 22:04 UTC+0100 ~ Sean Young > > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > > that the last key should

KASAN: use-after-free Read in vhost_chr_write_iter

2018-05-17 Thread DaeRyong Jeong
We report the crash: KASAN: use-after-free Read in vhost_chr_write_iter This crash has been found in v4.17-rc1 using RaceFuzzer (a modified version of Syzkaller), which we describe more at the end of this report. Our analysis shows that the race occurs when invoking two syscalls concurrently, writ

Re: [PATCH net-next] net/smc: init conn.tx_work & conn.send_lock sooner

2018-05-17 Thread Ursula Braun
On 05/17/2018 02:20 PM, Eric Dumazet wrote: > On Thu, May 17, 2018 at 5:13 AM Ursula Braun wrote: > >> This problem should no longer show up with yesterday's net-next commit >> 569bc6436568 ("net/smc: no tx work trigger for fallback sockets"). > > It definitely triggers on latest net-next, whi

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-17 Thread Roopa Prabhu
On Wed, May 16, 2018 at 7:36 PM, David Miller wrote: > From: Roopa Prabhu > Date: Wed, 16 May 2018 13:30:28 -0700 > >> yes, but we hold rcu read lock before calling the reply function for >> fib result. I did consider allocating the skb before the read >> lock..but then the refactoring (into a s

[iproute2-next v3 1/1] tipc: fixed node and name table listings

2018-05-17 Thread Jon Maloy
We make it easier for users to correlate between 128-bit node identities and 32-bit node hash number by extending the 'node list' command to also show the hash number. We also improve the 'nametable show' command to show the node identity instead of the node hash number. Since the former potential

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-17 Thread Jiri Pirko
Fri, Mar 23, 2018 at 06:09:29PM CET, f.faine...@gmail.com wrote: >On 03/23/2018 07:49 AM, Jiri Pirko wrote: >> Fri, Mar 23, 2018 at 02:30:02PM CET, and...@lunn.ch wrote: >>> On Thu, Mar 22, 2018 at 11:55:14AM +0100, Jiri Pirko wrote: From: Jiri Pirko Set the attrs and allow to expos

[PATCH 0/2] bpf: sockmap, fix uninitialized variable and double-free

2018-05-17 Thread Gustavo A. R. Silva
This patchset aims to fix an uninitialized variable issue and a double-free issue in __sock_map_ctx_update_elem. Both issues were reported by Coverity. Thanks. Gustavo A. R. Silva (2): bpf: sockmap, fix uninitialized variable bpf: sockmap, fix double-free kernel/bpf/sockmap.c | 3 +-- 1 fi

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-17 Thread Florian Fainelli
On 05/17/2018 07:02 AM, Jiri Pirko wrote: > Fri, Mar 23, 2018 at 06:09:29PM CET, f.faine...@gmail.com wrote: >> On 03/23/2018 07:49 AM, Jiri Pirko wrote: >>> Fri, Mar 23, 2018 at 02:30:02PM CET, and...@lunn.ch wrote: On Thu, Mar 22, 2018 at 11:55:14AM +0100, Jiri Pirko wrote: > From: Jir

[PATCH 1/2] bpf: sockmap, fix uninitialized variable

2018-05-17 Thread Gustavo A. R. Silva
There is a potential execution path in which variable err is returned without being properly initialized previously. Fix this by initializing variable err to 0. Addresses-Coverity-ID: 1468964 ("Uninitialized scalar variable") Fixes: e5cd3abcb31a ("bpf: sockmap, refactor sockmap routines to work w

Re: STMMAC driver with TSO enabled issue

2018-05-17 Thread Jose Abreu
Hi Bhadram, On 15-05-2018 07:44, Bhadram Varka wrote: > Hi Jose, > > On 5/10/2018 9:15 PM, Jose Abreu wrote: >> >> >> On 10-05-2018 16:08, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: > ++net

Re: net: ieee802154: 6lowpan: fix frag reassembly

2018-05-17 Thread Stefan Schmidt
Hello Greg. On 17.05.2018 10:59, Greg KH wrote: > On Mon, May 14, 2018 at 05:22:18PM +0200, Stefan Schmidt wrote: >> Hello. >> >> >> Please apply f18fa5de5ba7f1d6650951502bb96a6e4715a948 >> >> (net: ieee802154: 6lowpan: fix frag reassembly) to the 4.16.x stable tree. >> >> >> Earlier trees are not

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-17 Thread Jiri Pirko
Thu, May 17, 2018 at 04:08:10PM CEST, f.faine...@gmail.com wrote: > > >On 05/17/2018 07:02 AM, Jiri Pirko wrote: >> Fri, Mar 23, 2018 at 06:09:29PM CET, f.faine...@gmail.com wrote: >>> On 03/23/2018 07:49 AM, Jiri Pirko wrote: Fri, Mar 23, 2018 at 02:30:02PM CET, and...@lunn.ch wrote: > On

[PATCH net 1/7] net: ip6_gre: Request headroom in __gre6_xmit()

2018-05-17 Thread Petr Machata
__gre6_xmit() pushes GRE headers before handing over to ip6_tnl_xmit() for generic IP-in-IP processing. However it doesn't make sure that there is enough headroom to push the header to. That can lead to the panic cited below. (Reproducer below that). Fix by requesting either needed_headroom if alr

[PATCH net 0/7] net: ip6_gre: Fixes in headroom handling

2018-05-17 Thread Petr Machata
This series mends some problems in headroom management in ip6_gre module. The current code base has the following three closely-related problems: - ip6gretap tunnels neglect to ensure there's enough writable headroom before pushing GRE headers. - ip6erspan does this, but assumes that dev->neede

[PATCH net 3/7] net: ip6_gre: Split up ip6gre_tnl_link_config()

2018-05-17 Thread Petr Machata
The function ip6gre_tnl_link_config() is used for setting up configuration of both ip6gretap and ip6erspan tunnels. Split the function into the common part and the route-lookup part. The latter then takes the calculated header length as an argument. This split will allow the patches down the line t

  1   2   3   4   >