[PATCH RFC net-next 07/11] udp: zerocopy

2018-04-17 Thread Willem de Bruijn
From: Willem de Bruijn Extend zerocopy to udp sockets. Allow setting sockopt SO_ZEROCOPY and interpret flag MSG_ZEROCOPY. This patch was previously part of the zerocopy RFC patchsets. Zerocopy is not effective at small MTU. With segmentation offload building larger datagram, the benefit of page

[PATCH RFC net-next 04/11] udp: paged allocation with gso

2018-04-17 Thread Willem de Bruijn
From: Willem de Bruijn When sending large datagrams that are later segmented, store data in page frags to avoid copying from linear in skb_segment. This logic will also be used by zerocopy. Signed-off-by: Willem de Bruijn --- net/ipv4/ip_output.c | 15 +++ net/ipv6/ip6_output.c |

[PATCH RFC net-next 10/11] selftests: udp gso with corking

2018-04-17 Thread Willem de Bruijn
From: Willem de Bruijn Corked sockets take a different path to construct a udp datagram than the lockless fast path. Test this alternate path. Segmentation offload requires checksum offload, which is not supported with corked sockets. This test fails after commit d749c9cbffd6 ("ipv4: no CHECKSUM

[PATCH RFC net-next 11/11] selftests: udp gso benchmark

2018-04-17 Thread Willem de Bruijn
From: Willem de Bruijn Send udp data between a source and sink, optionally with udp gso. The two processes are expected to be run on separate hosts. A script is included that runs them together over loopback in a single namespace. Signed-off-by: Willem de Bruijn --- tools/testing/selftests/ne

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-17 Thread Sowmini Varadhan
On (04/17/18 16:00), Willem de Bruijn wrote: > > This patchset implements GSO for UDP. A process can concatenate and > submit multiple datagrams to the same destination in one send call > by setting socket option SOL_UDP/UDP_SEGMENT with the segment size, > or passing an analogous cmsg at send tim

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-17 Thread Willem de Bruijn
On Tue, Apr 17, 2018 at 4:15 PM, Sowmini Varadhan wrote: > On (04/17/18 16:00), Willem de Bruijn wrote: >> >> This patchset implements GSO for UDP. A process can concatenate and >> submit multiple datagrams to the same destination in one send call >> by setting socket option SOL_UDP/UDP_SEGMENT wi

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Hi Adrian, On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz wrote: > On 04/17/2018 04:08 AM, Michael Schmitz wrote: >> >> From: John Paul Adrian Glaubitz > > This should be: > > From: Michael Karcher I haven't found a way to change that in my tree yet, sorry. Unless someone has a si

Re: [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support

2018-04-17 Thread Vlad Yasevich
On 04/02/2018 10:47 AM, Marcelo Ricardo Leitner wrote: > On Mon, Apr 02, 2018 at 09:40:01AM -0400, Vladislav Yasevich wrote: >> Now that we have SCTP offload capabilities in the kernel, we can add >> them to virtio as well. First step is SCTP checksum. > > Thanks. > >> As for GSO, the way sctp G

Fw: [Bug 199427] New: Wired Network interface goes repeatedly up and down with NetworkManager

2018-04-17 Thread Stephen Hemminger
Begin forwarded message: Date: Tue, 17 Apr 2018 18:57:20 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199427] New: Wired Network interface goes repeatedly up and down with NetworkManager https://bugzilla.kernel.org/show_bug.cgi?id=199427

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Thanks Geert, I'll fix that. I see my v2 series shows up as new series on patchwork - do I need to do something different when tagging the next version, Dave? Cheers, Michael On Wed, Apr 18, 2018 at 1:51 AM, David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 17 Apr 2018 10:20:25 +

Re: [PATCH net,stable] tun: fix vlan packet truncation

2018-04-17 Thread Bjørn Mork
David Miller writes: > The VLAN business might be bogus, and needs to be removed. > > However, the pskb_trim() has to stay in some form. I think this is what > Jason is trying to say. > > The semantics of running a BPF program is that the program returns the > desired packet length. We must tru

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread John Paul Adrian Glaubitz
On 04/17/2018 10:32 PM, Michael Schmitz wrote: >> From: Michael Karcher > > I haven't found a way to change that in my tree yet, sorry. Unless > someone has a simple way to fix patch authorship after a merge, I may > have to reimport from scratch. I guess you'll have to re-import then, sorry :(.

[PATCH bpf-next v4 04/10] bpf: btf: Add pretty print capability for data with BTF type info

2018-04-17 Thread Martin KaFai Lau
This patch adds pretty print capability for data with BTF type info. The current usage is to allow pretty print for a BPF map. The next few patches will allow a read() on a pinned map with BTF type info for its key and value. This patch uses the seq_printf() infra. Signed-off-by: Martin KaFai La

[PATCH v2 net,stable] tun: fix vlan packet truncation

2018-04-17 Thread Bjørn Mork
Bogus trimming in tun_net_xmit() causes truncated vlan packets. skb->len is correct whether or not skb_vlan_tag_present() is true. There is no more reason to adjust the skb length on xmit in this driver than any other driver. tun_put_user() adds 4 bytes to the total for tagged packets because it t

[PATCH bpf-next v4 08/10] bpf: btf: Sync bpf.h and btf.h to tools/

2018-04-17 Thread Martin KaFai Lau
This patch sync up the bpf.h and btf.h to tools/ Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 13 tools/include/uapi/linux/btf.h | 132 + 2 files changed, 145 insertions(+) create mode 100644 too

[PATCH bpf-next v4 09/10] bpf: btf: Add BTF support to libbpf

2018-04-17 Thread Martin KaFai Lau
If the ".BTF" elf section exists, libbpf will try to create a btf_fd (through BPF_BTF_LOAD). If that fails, it will still continue loading the bpf prog/map without the BTF. If the bpf_object has a BTF loaded, it will create a map with the btf_fd. libbpf will try to figure out the btf_key_id and b

[PATCH bpf-next v4 00/10] BTF: BPF Type Format

2018-04-17 Thread Martin KaFai Lau
This patch introduces BPF Type Format (BTF). BTF (BPF Type Format) is the meta data format which describes the data types of BPF program/map. Hence, it basically focus on the C programming language which the modern BPF is primary using. The first use case is to provide a generic pretty print cap

[PATCH bpf-next v4 01/10] bpf: btf: Introduce BPF Type Format (BTF)

2018-04-17 Thread Martin KaFai Lau
This patch introduces BPF type Format (BTF). BTF (BPF Type Format) is the meta data format which describes the data types of BPF program/map. Hence, it basically focus on the C programming language which the modern BPF is primary using. The first use case is to provide a generic pretty print cap

[PATCH bpf-next v4 02/10] bpf: btf: Validate type reference

2018-04-17 Thread Martin KaFai Lau
After collecting all btf_type in the first pass in an earlier patch, the second pass (in this patch) can validate the reference types (e.g. the referring type does exist and it does not refer to itself). While checking the reference type, it also gathers other information (e.g. the size of an arra

[PATCH bpf-next v4 03/10] bpf: btf: Check members of struct/union

2018-04-17 Thread Martin KaFai Lau
This patch checks a few things of struct's members: 1) It has a valid size (e.g. a "const void" is invalid) 2) A member's size (+ its member's offset) does not exceed the containing struct's size. 3) The member's offset satisfies the alignment requirement The above can only be done after the n

[PATCH bpf-next v4 10/10] bpf: btf: Add BTF tests

2018-04-17 Thread Martin KaFai Lau
This patch tests the BTF loading, map_create with BTF and the changes in libbpf. -r: Raw tests that test raw crafted BTF data -f: Test LLVM compiled bpf prog with BTF data -g: Test BPF_OBJ_GET_INFO_BY_FD for btf_fd -p: Test pretty print The tools/testing/selftests/bpf/Makefile will probe for BTF

[PATCH bpf-next v4 05/10] bpf: btf: Add BPF_BTF_LOAD command

2018-04-17 Thread Martin KaFai Lau
This patch adds a BPF_BTF_LOAD command which 1) loads and verifies the BTF (implemented in earlier patches) 2) returns a BTF fd to userspace. In the next patch, the BTF fd can be specified during BPF_MAP_CREATE. It currently limits to CAP_SYS_ADMIN. Signed-off-by: Martin KaFai Lau Acked-by:

[PATCH bpf-next v4 06/10] bpf: btf: Add BPF_OBJ_GET_INFO_BY_FD support to BTF fd

2018-04-17 Thread Martin KaFai Lau
This patch adds BPF_OBJ_GET_INFO_BY_FD support to BTF fd. The original BTF data, which was used to create the BTF fd during the earlier BPF_BTF_LOAD call, will be returned. The userspace is expected to allocate buffer to info.info and the buffer size is set to info.info_len before calling BPF_OBJ_

[PATCH bpf-next v4 07/10] bpf: btf: Add pretty print support to the basic arraymap

2018-04-17 Thread Martin KaFai Lau
This patch adds pretty print support to the basic arraymap. Support for other bpf maps can be added later. This patch adds new attrs to the BPF_MAP_CREATE command to allow specifying the btf_fd, btf_key_id and btf_value_id. The BPF_MAP_CREATE can then associate the btf to the map if the creating

[PATCH v3 net,stable] tun: fix vlan packet truncation

2018-04-17 Thread Bjørn Mork
Bogus trimming in tun_net_xmit() causes truncated vlan packets. skb->len is correct whether or not skb_vlan_tag_present() is true. There is no more reason to adjust the skb length on xmit in this driver than any other driver. tun_put_user() adds 4 bytes to the total for tagged packets because it t

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-17 Thread Sowmini Varadhan
On (04/17/18 16:23), Willem de Bruijn wrote: > > Assuming IPv4 with an MTU of 1500 and the maximum segment > size of 1472, the receiver will see three datagrams with MSS of > 1472B, 528B and 512B. so the recvmsg will also pass up 1472, 526, 512, right? If yes, how will the recvmsg differentiate b

[PATCH 3/8] ipconfig: BOOTP: Don't request IEN-116 name servers

2018-04-17 Thread Chris Novakovic
When ipconfig is autoconfigured via BOOTP, the request packet initialised by ic_bootp_init_ext() allocates 8 bytes for tag 5 ("Name Server" [1, §3.7]), but tag 5 in the response isn't processed by ic_do_bootp_ext(). Instead, allocate the 8 bytes to tag 6 ("Domain Name Server" [1, §3.8]), which is p

[PATCH 7/8] ipconfig: Write NTP server IPs to /proc/net/ntp

2018-04-17 Thread Chris Novakovic
Distributed filesystems are most effective when the server and client clocks are synchronised. Embedded devices often use NFS for their root filesystem but typically do not contain an RTC, so the clocks of the NFS server and the embedded device will be out-of-sync when the root filesystem is mounte

[PATCH 1/8] ipconfig: Document setting of NIS domain name

2018-04-17 Thread Chris Novakovic
ic_do_bootp_ext() is responsible for parsing the "ip=" and "nfsaddrs=" kernel parameters. If a "." character is found in parameter 4 (the client's hostname), everything before the first "." is used as the hostname, and everything after it is used as the NIS domain name (but not necessarily the DNS

[PATCH 8/8] CREDITS: Add Chris Novakovic

2018-04-17 Thread Chris Novakovic
Signed-off-by: Chris Novakovic --- CREDITS | 4 1 file changed, 4 insertions(+) diff --git a/CREDITS b/CREDITS index 989cda91c427..5a13bf62c569 100644 --- a/CREDITS +++ b/CREDITS @@ -2765,6 +2765,10 @@ E: nor...@nocrew.org W: http://www.lysator.liu.se/~noring/ D: dsp56k device driver +N

[PATCH 6/8] ipconfig: Correctly initialise ic_nameservers

2018-04-17 Thread Chris Novakovic
ic_nameservers, which stores the list of name servers discovered by ipconfig, is initialised (i.e. has all of its elements set to NONE, or 0x) by ic_nameservers_predef() in the following scenarios: - before the "ip=" and "nfsaddrs=" kernel command line parameters are parsed (in ip_auto

[PATCH 0/8] ipconfig: NTP server support, bug fixes, documentation improvements

2018-04-17 Thread Chris Novakovic
This series (against net-next) makes various improvements to ipconfig. It was mistakenly posted on 2018-04-07, while net-next was closed; it still applies cleanly. - Patch #1 correctly documents the behaviour of parameter 4 in the "ip=" and "nfsaddrs=" command line parameter. - Patch #2 tidie

[PATCH 4/8] ipconfig: BOOTP: Request CONF_NAMESERVERS_MAX name servers

2018-04-17 Thread Chris Novakovic
When ipconfig is autoconfigured via BOOTP, the request packet initialised by ic_bootp_init_ext() always allocates 8 bytes for the name server option, limiting the BOOTP server to responding with at most 2 name servers even though ipconfig in fact supports an arbitrary number of name servers (as def

[PATCH 2/8] ipconfig: Tidy up reporting of name servers

2018-04-17 Thread Chris Novakovic
Commit 5e953778a2aab04929a5e7b69f53dc26e39b079e ("ipconfig: add nameserver IPs to kernel-parameter ip=") adds the IP addresses of discovered name servers to the summary printed by ipconfig when configuration is complete. It appears the intention in ip_auto_config() was to print the name servers on

[PATCH 5/8] ipconfig: Document /proc/net/pnp

2018-04-17 Thread Chris Novakovic
Fully document the format used by the /proc/net/pnp file written by ipconfig, explain where its values originate from, and clarify that the tertiary name server IP and DNS domain name are only written to the file when autoconfiguration is used. Signed-off-by: Chris Novakovic --- Documentation/fi

Re: linux-next on x60: network manager often complains "network is disabled" after resume

2018-04-17 Thread Pavel Machek
Hi! On Mon 2018-03-26 10:33:55, Dan Williams wrote: > On Sun, 2018-03-25 at 08:19 +0200, Pavel Machek wrote: > > > > > Ok, what does 'nmcli dev' and 'nmcli radio' show? > > > > > > > > Broken state. > > > > > > > > pavel@amd:~$ nmcli dev > > > > DEVICE TYPE STATECONNECTION > > > > e

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-17 Thread Willem de Bruijn
On Tue, Apr 17, 2018 at 4:48 PM, Sowmini Varadhan wrote: > On (04/17/18 16:23), Willem de Bruijn wrote: >> >> Assuming IPv4 with an MTU of 1500 and the maximum segment >> size of 1472, the receiver will see three datagrams with MSS of >> 1472B, 528B and 512B. > > so the recvmsg will also pass up 1

Re: [PATCH 8/8] CREDITS: Add Chris Novakovic

2018-04-17 Thread Cong Wang
On Tue, Apr 17, 2018 at 1:58 PM, Chris Novakovic wrote: > Signed-off-by: Chris Novakovic > --- > CREDITS | 4 It is rare to update CREDITS, people now use git to credit contributions.

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Andrew Lunn
On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: > Hi Adrian, > > On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz > wrote: > > On 04/17/2018 04:08 AM, Michael Schmitz wrote: > >> > >> From: John Paul Adrian Glaubitz > > > > This should be: > > > > From: Michael Karche

[PATCH net-next 00/19] r8169: series with further smaller improvements

2018-04-17 Thread Heiner Kallweit
This series includes further smaller improvements. Then I think the basic cleanup has been done and next step would be preparing the switch to phylib. Heiner Kallweit (19): r8169: remove unused member features from struct rtl8169_private r8169: remove member align from struct rtl_cfg_info r

[PATCH net-next] hv_netvsc: propogate Hyper-V friendly name into interface alias

2018-04-17 Thread Stephen Hemminger
This patch implement the 'Device Naming' feature of the Hyper-V network device API. In Hyper-V on the host through the GUI or PowerShell it is possible to enable the device naming feature which causes the host to make available to the guest the name of the device. This shows up in the RNDIS protoco

[net-next PATCH v4 03/13] net: netcp: ethss: use macro for checking ss_version consistently

2018-04-17 Thread Murali Karicheri
Driver currently uses macro for NU and XBE hardwrae, while other places for older hardware such as that on K2H/K SoC (version 1.4 of the cpsw hardware, it explicitly check for the ss_version inline. Add a new macro for version 1.4 and use it to customize code in the driver. While at it also fix sim

[net-next PATCH v4 13/13] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-17 Thread Murali Karicheri
From: WingMan Kwok This patch adds support for promiscuous mode in k2g's network driver. When upper layer instructs to transition from non-promiscuous mode to promiscuous mode or vice versa K2G network driver needs to configure ALE accordingly so that in case of non-promiscuous mode, ALE will not

[net-next PATCH v4 05/13] net: netcp: ethss: add support for handling rgmii link interface

2018-04-17 Thread Murali Karicheri
2u cpsw hardware on K2G uses rgmii link to interface with Phy. So add support for this interface in the code so that driver can be re-used for 2u hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp.h | 2 ++ drivers/net/ethernet/ti/netcp_ethss.c | 15 +++---

[net-next PATCH v4 06/13] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-04-17 Thread Murali Karicheri
Introduce rgmii link status to handle link state events for 2u cpsw hardware on K2G. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/ti/netcp_eth

[net-next PATCH v4 12/13] net: netcp: add api to support set rx mode in netcp modules

2018-04-17 Thread Murali Karicheri
From: WingMan Kwok This patch adds an API to support setting rx mode in netcp modules. If a netcp module needs to be notified when upper layer transitions from one rx mode to another and react accordingly, such a module will implement the new API set_rx_mode added in this patch. Currently rx mo

[net-next PATCH v4 09/13] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-04-17 Thread Murali Karicheri
The phy used for K2G allows for internal delays to be added optionally to the clock circuitry based on board desing. To add this support, enhance the driver to use of_get_phy_mode() to read the phy-mode from the phy device and pass the same to phy through of_phy_connect(). Signed-off-by: Murali Ka

[net-next PATCH v4 01/13] soc: ti: K2G: enhancement to support QMSS in K2G NAVSS

2018-04-17 Thread Murali Karicheri
Navigator Subsystem (NAVSS) available on K2G SoC has a cut down version of QMSS with less number of queues, internal linking ram with lesser number of buffers etc. It doesn't have status and explicit push register space as in QMSS available on other K2 SoCs. So define reg indices specific to QMSS

[net-next PATCH v4 02/13] soc: ti: K2G: provide APIs to support driver probe deferral

2018-04-17 Thread Murali Karicheri
This patch provide APIs to allow client drivers to support probe deferral. On K2G SoC, devices can be probed only after the ti_sci_pm_domains driver is probed and ready. As drivers may get probed at different order, any driver that depends on knav dma and qmss drivers, for example netcp network dri

[net-next PATCH v4 08/13] net: netcp: ethss: re-use stats handling code for 2u hardware

2018-04-17 Thread Murali Karicheri
The stats block in 2u cpsw hardware is similar to the one on nu and hence handle it in a similar way by using a macro that includes 2u hardware as well. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[net-next PATCH v4 11/13] net: netcp: support probe deferral

2018-04-17 Thread Murali Karicheri
The netcp driver shouldn't proceed until the knav qmss and dma devices are ready. So return -EPROBE_DEFER if these devices are not ready. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/ti/netcp

[net-next PATCH v4 10/13] Revert "net: netcp: remove dead code from the driver"

2018-04-17 Thread Murali Karicheri
As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 9 + 1 file changed, 9

[net-next PATCH v4 04/13] net: netcp: ethss: make sgmii configuration conditional

2018-04-17 Thread Murali Karicheri
As a preparatory patch to add support for 2u cpsw hardware found on K2G SoC, make sgmii configuration conditional. This is required since 2u uses RGMII interface instead of SGMII and to allow for driver re-use. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 18 ++

[net-next PATCH v4 07/13] net: netcp: ethss: map vlan priorities to zero flow

2018-04-17 Thread Murali Karicheri
The driver currently support only vlan priority zero. So map the vlan priorities to zero flow in hardware. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/e

[net-next PATCH v4 00/13] Add support for netcp driver on K2G SoC

2018-04-17 Thread Murali Karicheri
K2G SoC is another variant of Keystone family of SoCs. This patch series add support for NetCP driver on this SoC. The QMSS found on K2G SoC is a cut down version of the QMSS found on other keystone devices with less number of queues, internal link ram etc. The patch series has 2 patch sets that go

Re: general protection fault in encode_rpcb_string

2018-04-17 Thread J. Bruce Fields
On Mon, Apr 16, 2018 at 09:02:01PM -0700, syzbot wrote: > syzbot hit the following crash on bpf-next commit > 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 +) > Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net > syzbot dashboard link: > https://syzkaller.appspo

[PATCH net-next 02/19] r8169: remove member align from struct rtl_cfg_info

2018-04-17 Thread Heiner Kallweit
Since commit 6f0333b8fde4 "r8169: use 50% less ram for RX ring" member align isn't used any longer, so remove it. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/eth

[PATCH net-next 01/19] r8169: remove unused member features from struct

2018-04-17 Thread Heiner Kallweit
Member features of struct rtl8169_private isn't used any longer since commit 6c6aa15fdea5 "r8169: improve interrupt handling", so remove it. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r

[PATCH net-next 08/19] r8169: remove unneeded check in rtl8169_rx_fill

2018-04-17 Thread Heiner Kallweit
rtl8169_rx_fill() is called only once and directly before the call array tp->Rx_databuff[] is filled with zero's. Therefore we don't need this check. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next 14/19] r8169: drop member opts1_mask from struct rtl8169_private

2018-04-17 Thread Heiner Kallweit
We can get rid of member opts1_mask and in addition save a few cpu cycles in the hot path of rtl_rx(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/realtek/r816

[PATCH net-next 16/19] r8169: improve rtl8169_get_mac_version

2018-04-17 Thread Heiner Kallweit
Certain entries in array mac_info[] are redundant, so remove them: 0x7cf, 0x2c20 (VER 33): matched by entry 0x7c8, 0x2c00 0x7cf, 0x2830 (VER 26): matched by entry 0x7c8, 0x2800 0x7cf, 0x3cb0 (VER 24): matched by entry 0x7c8, 0x3c80 0x7cf, 0x3c40 (VER 22): matched by entr

[PATCH net-next 18/19] r8169: improve pci region handling

2018-04-17 Thread Heiner Kallweit
The region to be used is always the first of type IORESOURCE_MEM. We can implement this rule directly w/o having to specify which region is the first one per configuration entry. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 16 +--- 1 file changed, 5 inse

[PATCH net-next 07/19] r8169: improve rtl8169_init_ring

2018-04-17 Thread Heiner Kallweit
This function doesn't use the net_device, therefore change the parameter to type struct rtl8169_private * to simplify the code. In addition we don't need the calculations in the memset statements, we can use the size of the arrays directly. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet

[PATCH net-next 06/19] r8169: simplify rtl8169_alloc_rx_data

2018-04-17 Thread Heiner Kallweit
dev->dev.parent has the same value as tp_to_dev(tp) (set by SET_NETDEV_DEV() in rtl_init_one()) and we know it can't be NULL. This allows us to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH net-next 13/19] r8169: change interrupt handler argument type

2018-04-17 Thread Heiner Kallweit
Code can be a little simplified by switching the interrupt handler argument type to struct rtl8169_private *. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b

[PATCH net-next 17/19] r8169: drop member txd_version from struct rtl8169_private

2018-04-17 Thread Heiner Kallweit
txd_version is used in rtl_init_one() only, so we can drop member txd_version from struct rtl8169_private. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c

[PATCH net-next 19/19] r8169: remove jumbo_tx_csum from chip config struct

2018-04-17 Thread Heiner Kallweit
According to the chip configuration entries only RTL8169 (ver <= 06) supports tx checksumming for jumbo packets. By the way: constant JUMBO_1K is a little misleading because it refers to the standard packet size and not to a jumbo packet size. By implementing this rule we can get rid of configurin

[PATCH net-next 10/19] r8169: remove rtl8169_map_to_asic

2018-04-17 Thread Heiner Kallweit
This function is very simple and used only once, so we can inline the two statements. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/

[PATCH net-next 09/19] r8169: replace rx_buf_sz with a constant

2018-04-17 Thread Heiner Kallweit
rx_buf_sz is constant, so we don't have to pass it as parameter and in general can replace it with a constant. When working on this I noticed that also before in rtl_set_rx_max_size() a value of 0x4000 is set, what is not in line with the chip spec. According to the spec only bits 0..13 are used a

[PATCH net-next 15/19] r8169: don't display tp->mmio_addr address

2018-04-17 Thread Heiner Kallweit
For security reasons since commit ad67b74d2469 "printk: hash addresses printed with %p" %p doesn't display the full address any longer. We could switch to %px, but I think the pointer address doesn't provide a real benefit, so remove printing the hashed address. Signed-off-by: Heiner Kallweit ---

[PATCH net-next 12/19] r8169: change argument type of counters handling functions

2018-04-17 Thread Heiner Kallweit
The counter handling functions don't deal with the net_device, so code can be simplified by changing the argument type to struct rtl8169_private *. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 32 +++- 1 file changed, 13 insertions(+), 19 dele

[PATCH net-next 11/19] r8169: change hw_start argument type

2018-04-17 Thread Heiner Kallweit
Code can be simplified by changing the argument type of hw_start callbacks from struct net_device * to struct rtl8169_private *. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 41 ++-- 1 file changed, 15 insertions(+), 26 deletions(-) diff --gi

[PATCH net-next 04/19] r8169: use constant NAPI_POLL_WAIT

2018-04-17 Thread Heiner Kallweit
We can use generic constant NAPI_POLL_WAIT instead of defining an own constant for the same value. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/eth

[PATCH net-next 05/19] r8169: switch to napi_schedule_irqoff

2018-04-17 Thread Heiner Kallweit
napi_schedule() is called from hard irq context, so we can switch to napi_schedule_irqoff() and avoid some overhead. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b

[PATCH net-next 03/19] r8169: use skb_copy_to_linear_data in rtl8169_try_rx_copy

2018-04-17 Thread Heiner Kallweit
Not a giant leap for mankind, but let's avoid the open-coded memcpy and use standard helper skb_copy_to_linear_data instead. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Hi Andrew, thanks, that's what I was looking for. The next version will have all but one patch correctly attributed to Michael Karcher. Cheers, Michael On Wed, Apr 18, 2018 at 9:13 AM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: >> Hi Adrian, >> >>

Re: [PATCH v2 net-next] net: introduce a new tracepoint for tcp_rcv_space_adjust

2018-04-17 Thread Yafang Shao
On Wed, Apr 18, 2018 at 1:27 AM, Eric Dumazet wrote: > > > On 04/17/2018 09:36 AM, Yafang Shao wrote: >> tcp_rcv_space_adjust is called every time data is copied to user space, >> introducing a tcp tracepoint for which could show us when the packet is >> copied to user. >> This could help us figur

Re: general protection fault in encode_rpcb_string

2018-04-17 Thread Trond Myklebust
On Tue, 2018-04-17 at 17:33 -0400, J. Bruce Fields wrote: > On Mon, Apr 16, 2018 at 09:02:01PM -0700, syzbot wrote: > > syzbot hit the following crash on bpf-next commit > > 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 > > +) > > Merge git://git.kernel.org/pub/scm/linux/ke

Re: [PATCH v2 net-next] net: introduce a new tracepoint for tcp_rcv_space_adjust

2018-04-17 Thread Yafang Shao
On Wed, Apr 18, 2018 at 1:38 AM, Song Liu wrote: > > >> On Apr 17, 2018, at 9:36 AM, Yafang Shao wrote: >> >> tcp_rcv_space_adjust is called every time data is copied to user space, >> introducing a tcp tracepoint for which could show us when the packet is >> copied to user. >> This could help us

[PATCH net-next] hv_netvsc: Add NetVSP v6 and v6.1 into version negotiation

2018-04-17 Thread Haiyang Zhang
From: Haiyang Zhang This patch adds the NetVSP v6 and 6.1 message structures, and includes these versions into NetVSC/NetVSP version negotiation process. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 164 drivers/net/hyperv/netvsc.c

Re: [PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-17 Thread Michael Schmitz
Hi Geert, thanks for your suggestions! On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven wrote: > Hi Michael, > > Thanks for your patch! > > On Tue, Apr 17, 2018 at 12:04 AM, Michael Schmitz > wrote: >> Add platform device driver to populate the ax88796 platform data from >> information prov

Re: [PATCH bpf-next 01/10] [bpf]: adding bpf_xdp_adjust_tail helper

2018-04-17 Thread Alexei Starovoitov
On Mon, Apr 16, 2018 at 11:51:22PM -0700, Nikita V. Shirokov wrote: > Adding new bpf helper which would allow us to manipulate > xdp's data_end pointer, and allow us to reduce packet's size > indended use case: to generate ICMP messages from XDP context, > where such message would contain truncated

Re: [PATCH v2 8/8] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-17 Thread Michael Schmitz
Hi Andrew, On Wed, Apr 18, 2018 at 1:26 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 02:08:15PM +1200, Michael Schmitz wrote: >> Add platform device driver to populate the ax88796 platform data from >> information provided by the XSurf100 zorro device driver. >> This driver will have to be lo

Re: [PATCH bpf-next 02/10] [bpf]: adding tests for bpf_xdp_adjust_tail

2018-04-17 Thread Alexei Starovoitov
On Mon, Apr 16, 2018 at 11:51:23PM -0700, Nikita V. Shirokov wrote: > adding selftests for bpf_xdp_adjust_tail helper. in this syntetic test > we are testing that 1) if data_end < data helper will return EINVAL > 2) for normal use case packet's length would be reduced. > > aside from adding new te

Re: [PATCH bpf-next 04/10] [bpf]: make generic xdp compatible w/ bpf_xdp_adjust_tail

2018-04-17 Thread Alexei Starovoitov
On Mon, Apr 16, 2018 at 11:51:25PM -0700, Nikita V. Shirokov wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for generic XDP we need to

Re: [PATCH bpf-next 05/10] [bpf]: make mlx4 compatible w/ bpf_xdp_adjust_tail

2018-04-17 Thread Alexei Starovoitov
On Mon, Apr 16, 2018 at 11:51:26PM -0700, Nikita V. Shirokov wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for mlx4 driver we will jus

Re: [PATCH bpf-next 06/10] [bpf]: make bnxt compatible w/ bpf_xdp_adjust_tail

2018-04-17 Thread Alexei Starovoitov
On Mon, Apr 16, 2018 at 11:51:27PM -0700, Nikita V. Shirokov wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for bnxt driver we will jus

Re: [PATCH bpf-next 07/10] [bpf]: make cavium thunder compatible w/ bpf_xdp_adjust_tail

2018-04-17 Thread Alexei Starovoitov
On Mon, Apr 16, 2018 at 11:51:28PM -0700, Nikita V. Shirokov wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for cavium's thunder driver

Re: [PATCH bpf-next 08/10] [bpf]: make netronome nfp compatible w/ bpf_xdp_adjust_tail

2018-04-17 Thread Alexei Starovoitov
On Mon, Apr 16, 2018 at 11:51:29PM -0700, Nikita V. Shirokov wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for nfp driver we will just

Re: [PATCH v2 bpf-next 1/3] bpftool: Support new prog types and attach types

2018-04-17 Thread Jakub Kicinski
On Tue, 17 Apr 2018 10:28:44 -0700, Andrey Ignatov wrote: > Add recently added prog types to `bpftool prog` and attach types to > `bpftool cgroup`. > > Update bpftool documentation and bash completion appropriately. > > Signed-off-by: Andrey Ignatov Acked-by: Jakub Kicinski Thank you!!

Re: SRIOV switchdev mode BoF minutes

2018-04-17 Thread Jakub Kicinski
On Tue, 17 Apr 2018 10:47:00 -0400, Andy Gospodarek wrote: > There is also a school of thought that the VF reps could be > pre-allocated on the SmartNIC so that any application processing that > traffic would sit idle when no traffic arrives on the rep, but could > process frames that do arrive whe

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2018-04-17 Thread Ben Greear
On 01/24/2018 03:59 PM, Ben Greear wrote: On 06/20/2017 08:03 PM, David Ahern wrote: On 6/20/17 5:41 PM, Ben Greear wrote: On 06/20/2017 11:05 AM, Michal Kubecek wrote: On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM,

Re: [PATCH] samples/bpf: correct comment in sock_example.c

2018-04-17 Thread Alexei Starovoitov
On Tue, Apr 17, 2018 at 10:25:20AM +0800, Wang Sheng-Hui wrote: > The program run against loopback interace "lo", not "eth0". > Correct the comment. > > Signed-off-by: Wang Sheng-Hui Acked-by: Alexei Starovoitov for future patches please use the following format for the subject: [PATCH bpf-nex

[PATCH net] net: qualcomm: rmnet: Fix warning seen with fill_info

2018-04-17 Thread Subash Abhinov Kasiviswanathan
When the last rmnet device attached to a real device is removed, the real device is unregistered from rmnet. As a result, the real device lookup fails resulting in a warning when the fill_info handler is called as part of the rmnet device unregistration. Fix this by returning the rmnet flags as 0

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

2018-04-17 Thread Jakub Kicinski
On Tue, 17 Apr 2018 16:23:48 +0300, Or Gerlitz wrote: > On Thu, Mar 22, 2018 at 1:55 PM, Jiri Pirko wrote: > > From: Jiri Pirko > > > > This patchset resolves 2 issues we have right now: > > 1) There are many netdevices / ports in the system, for port, pf, vf > >represenatation but the user h

Re: fix for bnx2x panic during ethtool reporting

2018-04-17 Thread Florian Fainelli
+netdev, Ariel, On 04/17/2018 10:21 AM, Sebastian Kuzminsky wrote: > "ethtool -i" on a bnx2x interface causes kernel panic when the > firmware version is longer than expected. The attached patch fixes > the problem by simplifying the string handling in bnx2x_fill_fw_str(). > It applies cleanly to

Re: [PATCH net-next] net: introduce a new tracepoint for tcp_rcv_space_adjust

2018-04-17 Thread Alexei Starovoitov
On Mon, Apr 16, 2018 at 08:43:31AM -0700, Eric Dumazet wrote: > > > On 04/16/2018 08:33 AM, Yafang Shao wrote: > > tcp_rcv_space_adjust is called every time data is copied to user space, > > introducing a tcp tracepoint for which could show us when the packet is > > copied to user. > > This could

Re: [RFC PATCH v3 bpf-next 2/5] bpf/verifier: rewrite subprog boundary detection

2018-04-17 Thread Alexei Starovoitov
On Fri, Apr 06, 2018 at 06:13:59PM +0100, Edward Cree wrote: > By storing a subprogno in each insn's aux data, we avoid the need to keep > the list of subprog starts sorted or bsearch() it in find_subprog(). > Also, get rid of the weird one-based indexing of subprog numbers. > > Signed-off-by: Ed

Re: One question about __tcp_select_window()

2018-04-17 Thread Wang Jian
Thanks for your reply, Eric. Actually, this is a query about the code while I am reading code. >From my instinct and the comment, I think we should choose the bigger one but maybe I miss something(like your said, autotuning) Anyway, I will read more codes and do more tests. Thanks. On Tue, Apr 1

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-17 Thread Siwei Liu
I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as illustrated in the reply below, cloud service providers require transparent live migration. Specifically, the main target of our case is to support SR-IOV live m

  1   2   3   4   5   >