[patch net-next] net: sched: silence uninitialized parent variable warning in tc_dump_tfilter

2018-01-18 Thread Jiri Pirko
From: Jiri Pirko When tcm->tcm_ifindex == TCM_IFINDEX_MAGIC_BLOCK, parent is still passed down but the value is never used. Compiler does not recognize it and issues a warning. Silence it down initializing parent to 0. Reported-by: David Miller Reported-by: Stephen Rothwell Signed-off-by: Jiri

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Pravin Shelar
On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: > When regular packets are forwarded, we validate their size against the > MTU of the destination device. However, when GSO packets are > forwarded, we do not validate their size against the MTU. We > implicitly assume that when they are segmen

Re: iscsi target regression due to "tcp: remove prequeue support" patch

2018-01-18 Thread Nicholas A. Bellinger
Hi Florian, (Adding netdev + DaveM CC') Thanks for the response. Comments below. On Mon, 2018-01-15 at 11:41 +0100, Florian Westphal wrote: > Mike Christie wrote: > > > Dec 13 17:55:01 rhel73n1 kernel: Got Login Command, Flags 0x81, ITT: > > 0x, CmdSN: 0x, ExpStatSN: 0xf86dc6

Re: iscsi target regression due to "tcp: remove prequeue support" patch

2018-01-18 Thread Nicholas A. Bellinger
On Mon, 2018-01-15 at 14:33 -0600, Mike Christie wrote: > On 01/15/2018 12:41 AM, Nicholas A. Bellinger wrote: > > Hey MNC & Co, > > > > Ping on the earlier iscsi-target authentication login failures atop > > 4.14 + commit e7942d063 removing tcp prequeue support. > > > > For reference, what is yo

Re: [Intel-wired-lan] [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

2018-01-18 Thread Miroslav Lichvar
On Wed, Jan 17, 2018 at 03:06:12PM -0800, Jesus Sanchez-Palencia wrote: > From: Richard Cochran > > This patch introduces SO_TXTIME. User space enables this option in > order to pass a desired future transmit time in a CMSG when calling > sendmsg(2). > > A new field is added to struct sockcm_co

Re: DPAA Ethernet traffice troubles with Linux kernel

2018-01-18 Thread Joakim Tjernlund
On Thu, 1970-01-01 at 00:00 +, Joakim Tjernlund wrote: > On Thu, 1970-01-01 at 00:00 +, Madalin-cristian Bucur wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is

Re: [PATCH next-queue 2/2] ixgbe: add unlikely notes to tx fastpath expressions

2018-01-18 Thread Yanjun Zhu
On 2018/1/9 6:47, Shannon Nelson wrote: Add unlikely() to a few error checking expressions in the Tx offload handling. Suggested-by: Yanjun Zhu Hi, I am fine with this patch. I have a question. The ipsec feature is supported in ixgbevf? Thanks a lot. Zhu Yanjun Signed-off-by: Shannon Ne

Re: [PATCH net] gso: validate gso_type if SKB_GSO_DODGY

2018-01-18 Thread Jason Wang
On 2018年01月18日 14:04, Willem de Bruijn wrote: On Thu, Jan 18, 2018 at 12:20 AM, Willem de Bruijn wrote: On Wed, Jan 17, 2018 at 10:48 PM, Jason Wang wrote: On 2018年01月18日 07:11, Willem de Bruijn wrote: From: Willem de Bruijn Validate gso_type of untrusted SKB_GSO_DODGY packets during seg

Re: [PATCH net] net: validate untrusted gso packets

2018-01-18 Thread Jason Wang
On 2018年01月18日 13:09, Willem de Bruijn wrote: Also, a packet can just as easily spoof an esp packet. See also the discussion in the Link above. Then we probably need check there. Adding a check in every gso handler that does not expect packets with SKB_GSO_DODGY source seems backwards to m

[PATCH v2] tools/bpftool: silence a static checker warning

2018-01-18 Thread Dan Carpenter
There is a static checker warning that "proglen" has an upper bound but no lower bound. The allocation will just fail harmlessly so it's not a big deal. Signed-off-by: Dan Carpenter --- v2: change the type to unsigned instead of checking for negatives diff --git a/tools/bpf/bpf_jit_disasm.c b/t

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Jason Wang
On 2018年01月18日 16:28, Pravin Shelar wrote: On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: When regular packets are forwarded, we validate their size against the MTU of the destination device. However, when GSO packets are forwarded, we do not validate their size against the MTU. We imp

Re: [PATCH v6 00/36] Andes(nds32) Linux Kernel Port

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > This is the 6th version patchset to add the Linux kernel port for Andes(nds32) > processors. Almost all of the feedbacks from v5 patchseries has been > addressed. > Thanks to everyone who provided feedback on the previous version. > > > This

Re: [PATCH] net: fec: add necessary defines to work on ARM64

2018-01-18 Thread Lucas Stach
Hi Andy, Am Donnerstag, den 18.01.2018, 01:49 + schrieb Andy Duan: > From: Lucas Stach Sent: Thursday, January > 18, 2018 2:31 AM > > The i.MX8 is a ARMv8 based SoC, that uses the same FEC IP as the > > earlier, > > ARMv7 based, i.MX SoCs. Allow the driver to work on ARM64. > > > > Signed-of

Re: [PATCH v6 03/36] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > It will be built failed if commit id: d25ea659 is selected. This patch > can fix this build error. > > Signed-off-by: Greentime Hu The change is fine, but the reference to commit 'd25ea659' is not for two reasons: -

RE: [PATCH] net: fec: add necessary defines to work on ARM64

2018-01-18 Thread Andy Duan
From: Lucas Stach Sent: Thursday, January 18, 2018 5:54 PM >Hi Andy, > >Am Donnerstag, den 18.01.2018, 01:49 + schrieb Andy Duan: >> From: Lucas Stach Sent: Thursday, January 18, >> 2018 2:31 AM >> > The i.MX8 is a ARMv8 based SoC, that uses the same FEC IP as the >> > earlier, >> > ARMv7 ba

Re: [PATCH v6 04/36] earlycon: add reg-offset to physical address before mapping

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > It will get the wrong virtual address because port->mapbase is not added > the correct reg-offset yet. We have to update it before earlycon_map() > is called > > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann Cc

Re: [PATCH v6 05/36] nds32: Assembly macros and definitions

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes assembly macros, bit field definitions used in .S > files across arch/nds32/. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 06/36] nds32: Kernel booting and initialization

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: I had not looked at this patch in enough detail earlier, sorry about that. It should be easy enough to fix though. > +#ifdef CONFIG_VGA_CONSOLE > +struct screen_info screen_info; > +#endif I would assume that you can't ever have a VGA console

Re: [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II support

2018-01-18 Thread Jiri Benc
Looks much better. On Wed, 17 Jan 2018 09:32:51 -0800, William Tu wrote: > + OVS_ERSPAN_OPT_IDX, /* be32 index */ Why don't you convert this to u32 while passing to/from user space? > + [OVS_ERSPAN_OPT_IDX]= { .len = sizeof(u32) }, sizeof(__be32) but see above. Thanks, Jiri

Re: [PATCH v6 07/36] nds32: Exception handling

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes the exception/interrupt entries, pt_reg structure and > related accessors. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Here it would be good to have a more detailed explanation a

[PATCH 1/2] can: af_can: can_rcv(): replace WARN_ONCE by pr_warn_once

2018-01-18 Thread Marc Kleine-Budde
If an invalid CAN frame is received, from a driver or from a tun interface, a Kernel warning is generated. This patch replaces the WARN_ONCE by a simple pr_warn_once, so that a kernel, bootet with panic_on_warn, does not panic. A printk seems to be more appropriate here. Reported-by: syzbot+43867

pull-request: can 2018-01-18

2018-01-18 Thread Marc Kleine-Budde
: bpf: fix cls_bpf on filter replace (2018-01-17 17:14:06 -0500) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.15-20180118 for you to fetch changes up to d4689846881d160a4d12a514e991a740bcb5d65a

[PATCH 2/2] can: af_can: canfd_rcv(): replace WARN_ONCE by pr_warn_once

2018-01-18 Thread Marc Kleine-Budde
If an invalid CANFD frame is received, from a driver or from a tun interface, a Kernel warning is generated. This patch replaces the WARN_ONCE by a simple pr_warn_once, so that a kernel, bootet with panic_on_warn, does not panic. A printk seems to be more appropriate here. Reported-by: syzbot+e3b

Re: [PATCH v2 03/31] net: Introduce net_sem for protection of pernet_list

2018-01-18 Thread Kirill Tkhai
On 17.01.2018 23:04, Andrei Vagin wrote: > On Mon, Nov 20, 2017 at 09:32:34PM +0300, Kirill Tkhai wrote: >> Curently mutex is used to protect pernet operations list. It makes >> cleanup_net() to execute ->exit methods of the same operations set, >> which was used on the time of ->init, even after n

Re: [PATCH v6 08/36] nds32: MMU definitions

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes virtual memory layout, PHYS_OFFSET is defined as 0x0. It > also includes the 4KB/8KB page size configurations and pte operations. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acke

Re: [PATCH v2 05/31] net: Allow pernet_operations to be executed in parallel

2018-01-18 Thread Kirill Tkhai
On 17.01.2018 21:34, Andrei Vagin wrote: > On Mon, Nov 20, 2017 at 09:32:55PM +0300, Kirill Tkhai wrote: >> This adds new pernet_operations::async flag to indicate operations, >> which ->init(), ->exit() and ->exit_batch() methods are allowed >> to be executed in parallel with the methods of any ot

Re: [PATCH v6 09/36] nds32: MMU initialization

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes memory initializations and highmem supporting. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 10/36] nds32: MMU fault handling and page table management

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes page fault handler, mmap and fixup implementations. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 11/36] nds32: Cache and TLB routines

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch contains cache and TLB maintenance functions. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 12/36] nds32: Process management

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > +void machine_restart(char *__unused) > +{ > + /* > +* Clean and disable cache, and turn off interrupts > +*/ > + cpu_proc_fin(); > + > + /* > +* Tell the mm system that we are going to reboot - > +

Re: [PATCH v6 13/36] nds32: IRQ handling

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes irq related functions and irqchip_init(). > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 14/36] nds32: Atomic operations

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes the atomic and futex operations. Many atomic operations > use > the load-lock word(llw) and store-condition word(scw) operations. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Ack

Re: [PATCH v6 15/36] nds32: Device specific operations

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch introduces ioremap implementations. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 16/36] nds32: DMA mapping API

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for the DMA mapping API. It uses dma_map_ops for > flexibility. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu I'm still unhappy about the way the cache flushes are done here as

Re: [PATCH net-next v5 0/4] dwmac-meson8b: clock fixes for Meson8b

2018-01-18 Thread Yixun Lan
HI Jerome On 01/17/18 01:19, Jerome Brunet wrote: > On Tue, 2018-01-16 at 12:17 +0100, Martin Blumenstingl wrote: Hi Martin I'm having problem with this series applied. I've tested on the A113D (AXG) platform, if this patch is applied, the driver will choose MPLL2 as clk

Re: [PATCH v6 17/36] nds32: ELF definitions

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds definitions for the ELF format, relocation types, vdso > locations and EXEC_PAGESIZE. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 18/36] nds32: System calls handling

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for system calls. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu You seem to have finally addressed all my previous concerns, looks good. Reviewed-by: Arnd Bergmann

Re: [PATCH v6 19/36] nds32: VDSO support

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds VDSO support. The VDSO code is currently used for > sys_rt_sigreturn() and optimised gettimeofday() (using the SoC timer counter). > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-b

Re: [PATCH v6 20/36] nds32: Signal handling support

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for signal handling. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu I never feel qualified enough to properly review signal handling code, so no Ack from me for this code even t

Re: [PATCH v6 21/36] nds32: Library functions

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch add support for various library functions. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

[PATCH iproute2] tc/lexer: let quotes actually start strings

2018-01-18 Thread Wolfgang Bumiller
The lexer will go with the longest match, so previously the starting double quotes of a string would be swallowed by the [^ \t\r\n()]+ pattern leaving the user no way to actually use strings with escape sequences. Fix this by not allowing this case to start with double quotes. Signed-off-by: Wolfg

[PATCH net 2/2] net_sched: fix TCF_LAYER_LINK case in tcf_get_base_ptr

2018-01-18 Thread Wolfgang Bumiller
TCF_LAYER_LINK and TCF_LAYER_NETWORK returned the same pointer as skb->data points to the network header. Use skb_mac_header instead. Signed-off-by: Wolfgang Bumiller --- Alternatively this could return skb->head directly, but 'sk_buff->mac_header' is documented as 'Link layer header' and this se

[PATCH net 1/2] net: sched: em_nbyte: don't add the data offset twice

2018-01-18 Thread Wolfgang Bumiller
'ptr' is shifted by the offset and then validated, the memcmp should not add it a second time. Signed-off-by: Wolfgang Bumiller --- net/sched/em_nbyte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/em_nbyte.c b/net/sched/em_nbyte.c index df3110d69585..07c10bac06a

[PATCH net+iproute2 0/2] nbyte, cmp and text filter fixups

2018-01-18 Thread Wolfgang Bumiller
The iproute2 part allows the the actual use of the already existing quoted string parsing. The kernel side fixes an oob read in em_nbyte and allows 'layer 0' in cmp and nbyte (and em_text whose existence surprised me given that I did not see it exposed via iproute2) to actually match layer 0 rathe

Re: [PATCH v6 22/36] nds32: Debugging support

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds ptrace support. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu I must have missed this patch earlier, unfortunately I don't think this is ready: > +long arch_ptrace(struct task_struct

Re: [PATCH v6 23/36] nds32: L2 cache support

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds L2 cache support. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 24/36] nds32: Loadable modules

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for loadable modules. One detail: You still seem to have both the ELF_REL and ELF_RELA based functions implemented here, you should drop the unused ELF_REL version: > diff --git a/arch/nds32/k

Re: [PATCH v6 25/36] nds32: Generic timers support

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for timer. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > Reviewed-by: Linus Walleij Acked-by: Arnd Bergmann

Re: [PATCH v6 26/36] nds32: Device tree support

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for device tree. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 28/36] nds32: defconfig

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds nds32 defconfig. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH v6 30/36] MAINTAINERS: Add nds32

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > Signed-off-by: Greentime Hu Please add a changelog text to every single commit, otherwise: Acked-by: Arnd Bergmann

Re: [PATCH v6 32/36] dt-bindings: nds32 L2 cache controller Bindings

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds nds32 L2 cache controller binding documents. > > Signed-off-by: Greentime Hu > Reviewed-by: Rob Herring Acked-by: Arnd Bergmann

Re: [PATCH v6 34/36] dt-bindings: interrupt-controller: Andestech Internal Vector Interrupt Controller

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds an irqchip driver document for the Andestech Internal Vector > Interrupt Controller. > > Signed-off-by: Rick Chen > Signed-off-by: Greentime Hu > Reviewed-by: Rob Herring Acked-by: Arnd Bergmann

Re: [PATCH v6 27/36] nds32: Miscellaneous header files

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch introduces some miscellaneous header files. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-18 Thread Dmitry Vyukov
On Wed, Jan 17, 2018 at 11:11 AM, Henrique de Moraes Holschuh wrote: > On Wed, 17 Jan 2018, Dmitry Vyukov wrote: >> On Wed, Jan 17, 2018 at 10:32 AM, Pavel Machek wrote: >> > On Fri 2018-01-12 17:58:01, syzbot wrote: >> >> syzkaller hit the following crash on >> >> 19d28fbd306e7ae7c1acf05c3e6968b

Re: [PATCH net-next] macvlan: Pass SIOC[SG]HWTSTAMP ioctls and get_ts_info to lower device

2018-01-18 Thread Jiri Benc
On Thu, 18 Jan 2018 02:12:34 +0100, grzegorz.ha...@gmail.com wrote: > This patch allows to enable hardware timestamping on macvlan intefaces and > find out capabilities of the lower device. > > Signed-off-by: Grzegorz Halat NACK. This does not work. For start, how do you deal with fwd_priv? Wh

Re: [PATCH net+iproute2 0/2] nbyte, cmp and text filter fixups

2018-01-18 Thread Jiri Pirko
Thu, Jan 18, 2018 at 11:32:33AM CET, w.bumil...@proxmox.com wrote: >The iproute2 part allows the the actual use of the already existing >quoted string parsing. Makes no sense to send iproute2 patch which is not related with the kernel ones in the same set. Please send it separatelly. > >The kerne

Re: [PATCH v6 29/36] nds32: Build infrastructure

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds Makefile, Kconfig and vmlinux.lds.S files required for > building > an nds32 kernel. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu I find some new details every time I look here ;-)

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds nds32 CPU binding documents. > > Signed-off-by: Vincent Chen > Signed-off-by: Rick Chen > Signed-off-by: Zong Li > Signed-off-by: Greentime Hu > Reviewed-by: Rob Herring > --- > Documentation/devic

Re: [PATCH v6 33/36] dt-bindings: nds32 SoC Bindings

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds nds32 SoC(AE3XX and AG101P) binding documents. > > Signed-off-by: Greentime Hu > Reviewed-by: Rob Herring Acked-by: Arnd Bergmann

Re: [PATCH v6 36/36] net: faraday add nds32 support.

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch is used to support nds32 architecture to use these faraday > mac IP. > > Signed-off-by: Greentime Hu Acked-by: Arnd Bergmann

Re: [PATCH RFC net-next 1/6] sock: MSG_PEEK support for sk_error_queue

2018-01-18 Thread Sowmini Varadhan
On (01/17/18 18:50), Willem de Bruijn wrote: > > This can cause reordering with parallel readers. Can we avoid the need > for peeking? It also caused a slew of subtle bugs previously. Yes, I did notice the potential for re-ordering when writing the patch.. but these are not actuallly messages fro

Re: [PATCH v6 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:57 AM, Greentime Hu wrote: > From: Rick Chen > > Add a document to describe Andestech atcpit100 timer and > binding information. > > Signed-off-by: Rick Chen > Signed-off-by: Greentime Hu > Acked-by: Rob Herring Acked-by: Arnd Bergmann

Re: [PATCH v6 2/3] clocksource/drivers/atcpit100: VDSO support

2018-01-18 Thread Arnd Bergmann
On Mon, Jan 15, 2018 at 6:57 AM, Greentime Hu wrote: > From: Rick Chen > > VDSO needs real-time cycle count to ensure the time accuracy. > Unlike others, nds32 architecture does not define clock source, > hence VDSO needs atcpit100 offering real-time cycle count > to derive the correct time. > >

Re: [PATCH RFC net-next 5/6] rds: support for zcopy completion notification

2018-01-18 Thread Sowmini Varadhan
On (01/17/18 19:23), Willem de Bruijn wrote: > > +static void rds_rm_zerocopy_callback(struct rds_sock *rs) : > > + skb = alloc_skb(ncookies * sizeof(u32), GFP_ATOMIC); > > TCP zerocopy avoids this issue by allocating the notification skb when the > zerocopy packet is created, which wou

[patch net-next] mlxsw: spectrum: Upper-bound supported FW version

2018-01-18 Thread Jiri Pirko
From: Yuval Mintz During initialization the driver checks whether the flashed FW image suits its requirements by checking that it's sufficiently new. However, there's only a weak backward compatibility scheme that is actually guaranteed by the FW, so driver must also upper bound the version to pr

Re: [PATCH 1/3 net] ibmvnic: Modify buffer size on failover

2018-01-18 Thread kbuild test robot
Hi John, I love your patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/John-Allen/ibmvnic-Modify-buffer-size-on-failover/20180118-190528 config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc

[net-next: PATCH v4 6/7] net: mvpp2: use device_*/fwnode_* APIs instead of of_*

2018-01-18 Thread Marcin Wojtas
OF functions can be used only for the driver using DT. As a preparation for introducing ACPI support in mvpp2 driver, use struct fwnode_handle in order to obtain properties from the hardware description. This patch replaces of_* function with device_*/fwnode_* where possible in the mvpp2. Signed-

[net-next: PATCH v4 7/7] net: mvpp2: enable ACPI support in the driver

2018-01-18 Thread Marcin Wojtas
This patch introduces an alternative way of obtaining resources - via ACPI tables provided by firmware. Enabling coexistence with the DT support, in addition to the OF_*->device_*/fwnode_* API replacement, required following steps to be taken: * Add mvpp2_acpi_match table * Omit clock configuratio

[net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

2018-01-18 Thread Marcin Wojtas
Hi, I quickly resend the series, thanks to Antoine Tenart's remark, who spotted !CONFIG_ACPI compilation issue after introducing the new fwnode_irq_get() routine. Please see the details in the changelog below and the 3/7 commit log. mvpp2 driver can work with the ACPI representation, as exposed o

[net-next: PATCH v4 3/7] device property: Introduce fwnode_irq_get()

2018-01-18 Thread Marcin Wojtas
Until now there were two very similar functions allowing to get Linux IRQ number from ACPI handle (acpi_irq_get()) and OF node (of_irq_get()). The first one appeared to be used only as a subroutine of platform_irq_get(), which (in the generic code) limited IRQ obtaining from _CRS method only to nod

[net-next: PATCH v4 5/7] net: mvpp2: simplify maintaining enabled ports' list

2018-01-18 Thread Marcin Wojtas
'port_count' field of the mvpp2 structure holds an overall amount of available ports, based on DT nodes status. In order to be prepared to support other HW description, obtain the value by incrementing it upon each successful port initialization. This allowed for simplifying port indexing in the co

[net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

2018-01-18 Thread Marcin Wojtas
Until now there were two almost identical functions for obtaining MAC address - of_get_mac_address() and, more generic, device_get_mac_address(). However it is not uncommon, that the network interface is represented as a child of the actual controller, hence it is not associated directly to any str

[net-next: PATCH v4 2/7] device property: Introduce fwnode_get_phy_mode()

2018-01-18 Thread Marcin Wojtas
Until now there were two almost identical functions for obtaining network PHY mode - of_get_phy_mode() and, more generic, device_get_phy_mode(). However it is not uncommon, that the network interface is represented as a child of the actual controller, hence it is not associated directly to any stru

[net-next: PATCH v4 4/7] device property: Allow iterating over available child fwnodes

2018-01-18 Thread Marcin Wojtas
Implement a new helper function fwnode_get_next_available_child_node(), which enables obtaining next enabled child fwnode, which works on a similar basis to OF's of_get_next_available_child(). This commit also introduces a macro, thanks to which it is possible to iterate over the available fwnodes

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-18 Thread Lorenzo Pieralisi
[+cc Mika] On Tue, Jan 09, 2018 at 02:00:12PM +0100, Andrew Lunn wrote: > On Tue, Jan 09, 2018 at 11:22:00AM +0100, Marcin Wojtas wrote: > > 2018-01-09 11:19 GMT+01:00 Graeme Gregory : > > > On Mon, Jan 08, 2018 at 06:17:06PM +0100, Marcin Wojtas wrote: > > >> Hi Andrew, > > >> > > >> > > >> > > >

Re: [RFC PATCH net-next 00/12] selftests: forwarding: Add VRF-based tests

2018-01-18 Thread Andrew Lunn
> > > >> > > > >> br0 > > > >> + > > > >>vrf-h1 | vrf-h2 > > > >> ++---+++ > > > >> |||| > > > >> 192.0.2.1/24 ++

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-18 Thread Andrew Lunn
> I CC'ed Mika since he is more familiar with handling these bits of ACPI > specs - I wonder whether this is a problem that cropped up on x86 > systems too. Hi Lorenzo There is nothing about MDIO, PHYs, Ethernet switches, etc in version 6.2 of the spec. If x86 has this, it must be after 6.2 was r

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-18 Thread Dmitry Vyukov
On Thu, Jan 18, 2018 at 2:09 AM, Theodore Ts'o wrote: > On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: >> >> If syzkaller can only test one tree than linux-next should be the one. > > Well, there's been some controversy about that. The problem is that > it's often not clear i

[PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused

2018-01-18 Thread Arnd Bergmann
Building without CONFIG_PM results in a harmless warning: drivers/net/can/m_can/m_can.c:1763:12: error: 'm_can_runtime_resume' defined but not used [-Werror=unused-function] drivers/net/can/m_can/m_can.c:1752:12: error: 'm_can_runtime_suspend' defined but not used [-Werror=unused-function] Mark

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-18 Thread Dmitry Vyukov
On Thu, Jan 18, 2018 at 2:01 PM, Dmitry Vyukov wrote: > On Thu, Jan 18, 2018 at 2:09 AM, Theodore Ts'o wrote: >> On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: >>> >>> If syzkaller can only test one tree than linux-next should be the one. >> >> Well, there's been some controv

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Daniel Axtens
Pravin Shelar writes: > On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: >> When regular packets are forwarded, we validate their size against the >> MTU of the destination device. However, when GSO packets are >> forwarded, we do not validate their size against the MTU. We >> implicitly as

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-18 Thread Dmitry Vyukov
On Wed, Jan 17, 2018 at 12:09 PM, Dmitry Vyukov wrote: > On Wed, Jan 17, 2018 at 10:49 AM, Daniel Borkmann > wrote: >> Don't know if there's such a possibility, but it would be nice if we could >> target fuzzing for specific subsystems in related subtrees directly (e.g. >> for bpf in bpf and bpf

[PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

2018-01-18 Thread Arnd Bergmann
When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while mt76 is built-in, we run into a link error: drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_register_device': mac80211.c:(.text+0xb78): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `de

Re: [PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused

2018-01-18 Thread Marc Kleine-Budde
On 01/18/2018 02:04 PM, Arnd Bergmann wrote: > Building without CONFIG_PM results in a harmless warning: > > drivers/net/can/m_can/m_can.c:1763:12: error: 'm_can_runtime_resume' defined > but not used [-Werror=unused-function] > drivers/net/can/m_can/m_can.c:1752:12: error: 'm_can_runtime_suspend

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Daniel Axtens
Jason Wang writes: > On 2018年01月18日 16:28, Pravin Shelar wrote: >> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: >>> When regular packets are forwarded, we validate their size against the >>> MTU of the destination device. However, when GSO packets are >>> forwarded, we do not validate t

[PATCH] [net-next] net: sched: avoid uninitialized variable use

2018-01-18 Thread Arnd Bergmann
gcc has identified a code path in which we pass uninitialized data into tc_dump_tfilter(): net/sched/cls_api.c: In function 'tc_dump_tfilter': net/sched/cls_api.c:1268:8: error: 'parent' may be used uninitialized in this function [-Werror=maybe-uninitialized] This initializes the variable to the

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-18 Thread Will Deacon
Hi Dan, Linus, On Thu, Jan 11, 2018 at 05:41:08PM -0800, Dan Williams wrote: > On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds > wrote: > > On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams > > wrote: > >> > >> This series incorporates Mark Rutland's latest ARM changes and adds > >> the x86 specifi

Re: [net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

2018-01-18 Thread Antoine Tenart
Hi Marcin, I tested the series on a MacchiatoBin to ensure the mvpp2 DT support was still working. I was able to use all supported ports as before, and saw no issue. For all mvpp2 patches, you can add: Tested-by: Antoine Tenart Thanks! Antoine On Thu, Jan 18, 2018 at 01:31:37PM +0100, Marcin

Re: [PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

2018-01-18 Thread Kalle Valo
Arnd Bergmann writes: > When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while > mt76 is built-in, we run into a link error: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function > `mt76_register_device': > mac80211.c:(.text+0xb78): relocation truncated to fit: R_AARCH64_C

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-18 Thread Jamal Hadi Salim
On 18-01-17 06:06 PM, Jesus Sanchez-Palencia wrote: From: Vinicius Costa Gomes TBS (Time Based Scheduler) uses the information added earlier in this series (the socket option SO_TXTIME and the new role of sk_buff->tstamp) to schedule traffic transmission based on absolute time. For some worklo

[PATCH xfrm v1] xfrm: fix error flow in case of add state fails

2018-01-18 Thread Aviad Yehezkel
If add state fails in case of device offload, netdev refcount will be negative since gc task is attempting to dev_free this state. This is fixed by putting NULL in state dev field. Signed-off-by: Aviad Yehezkel Signed-off-by: Boris Pismeny --- net/xfrm/xfrm_device.c | 1 + 1 file changed, 1 ins

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-18 Thread Henrique de Moraes Holschuh
On Thu, 18 Jan 2018, Dmitry Vyukov wrote: > I've made a bunch of changes yesterday and today. This includes ... > and even per crash/tree. To alleviate this, syzbot will now say e.g. > "So far this crash happened 185 times on linux-next, mmots, net-next, > upstream". So that you can see that it's

Re: [PATCH v2] FIRMWARE: bcm47xx_nvram: Replace mac address parsing

2018-01-18 Thread Andy Shevchenko
On Thu, 2017-12-21 at 17:42 +0100, Hauke Mehrtens wrote: > > On 12/21/2017 03:40 PM, Andy Shevchenko wrote: > > Replace sscanf() with mac_pton(). > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Hauke Mehrtens > > The patch looks good, but I haven't tested them on my devices. Any news on

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

2018-01-18 Thread Jamal Hadi Salim
One more comment: Probably try to run a test with a very small delta with no offload (probably using something like prio as the root qdisc) and dump the stats. My gut feeling is your accounting of the backlog in particular is off. cheers, jamal On 18-01-18 08:35 AM, Jamal Hadi Salim wrote: On 1

Re: [PATCH] [net-next] net: sched: avoid uninitialized variable use

2018-01-18 Thread Jiri Pirko
Thu, Jan 18, 2018 at 02:17:28PM CET, a...@arndb.de wrote: >gcc has identified a code path in which we pass uninitialized >data into tc_dump_tfilter(): > >net/sched/cls_api.c: In function 'tc_dump_tfilter': >net/sched/cls_api.c:1268:8: error: 'parent' may be used uninitialized in this >function [-W

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-18 Thread Daniel Axtens
Daniel Axtens writes: > Jason Wang writes: > >> On 2018年01月18日 16:28, Pravin Shelar wrote: >>> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: When regular packets are forwarded, we validate their size against the MTU of the destination device. However, when GSO packets are

[PATCH iproute2 v2 0/9] ip/tunnel: Improve tunnel parameters printing

2018-01-18 Thread Serhey Popovych
Continue improvements to tunnel modules. Final goal is to make merge IP and IPv6 variants and make that transition as transparent as possible. Everything within this series is open for your comments, suggestions and criticism. See individual patch description message for details. v2 1) Fix che

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-18 Thread Greg Kroah-Hartman
On Thu, Jan 18, 2018 at 02:01:28PM +0100, Dmitry Vyukov wrote: > On Thu, Jan 18, 2018 at 2:09 AM, Theodore Ts'o wrote: > > On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: > >> > >> If syzkaller can only test one tree than linux-next should be the one. > > > > Well, there's been

[PATCH iproute2 v2 8/9] vti6/tunnel: Unify and simplify link type help functions

2018-01-18 Thread Serhey Popovych
Both of these two changes are missing for link_vti6.c: commit 8b47135474cd ("ip: link: Unify link type help functions a bit") commit 561e650eff67 ("ip link: Shortify printing the usage of link type") Replay them on link_vti6.c to bring link type help functions inline with other tunneling code

  1   2   3   4   >