RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

2018-01-08 Thread Chris Mi
> >> I wonder whether specifying the batch size is necessary at all. > >> Couldn't batch mode just collect messages until either EOF or an > >> incompatible command is encountered which then triggers a commit to > >> kernel? This might simplify code quite a bit. > > That's a good suggestion. > > T

RE: [PATCH net] of_mdio: avoid MDIO bus removal when a PHY is missing

2018-01-08 Thread Madalin-cristian Bucur
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, January 05, 2018 5:13 PM > To: Madalin-cristian Bucur > Subject: Re: [PATCH net] of_mdio: avoid MDIO bus removal when a PHY is > missing > > On Fri, Jan 05, 2018 at 11:36:14AM +0200, Madalin Bucur wrote: > >

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-01-08 Thread Tobias Hommel
On Fri, Jan 05, 2018 at 09:55:23PM +, Tobias Hommel wrote: > On Sat, Jan 06, 2018 at 12:27:11AM +0300, Ozgur wrote: > > > > > > 06.01.2018, 00:20, "Tobias Hommel" : > > > Hi, > > > > Hi Tobias, > > > > > I'm running into a NULL pointer dereference after updating from Linux > > > 4.1.6 to >

RE: [RFC -next 2/2] net: sched: red: don't reset the backlog on every stat dump

2018-01-08 Thread Nogah Frankel
> -Original Message- > From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > Sent: Thursday, January 04, 2018 10:19 PM > To: john.fastab...@gmail.com; j...@resnulli.us; xiyou.wangc...@gmail.com; > Nogah Frankel ; Yuval Mintz > > Cc: netdev@vger.kernel.org; oss-driv...@netronome.com;

BUG: 4.15.0-rc6 unable to handle kernel NULL pointer dereference in ixgbe_down

2018-01-08 Thread wangyunjian
Hi, I'm running into a NULL pointer dereference in ixgbe_down on b84449dc14d274a3f3c78cd734b702ca31aa4dd1 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master. I think the variable adapter->vfinfo has not been protected well, when disable sriov and down nic. Anyone has an ide

Re: dvb usb issues since kernel 4.9

2018-01-08 Thread Mauro Carvalho Chehab
Em Sun, 7 Jan 2018 10:41:37 -0500 (EST) Alan Stern escreveu: > On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote: > > > > > It seems that the original patch were designed to solve some IRQ issues > > > > with network cards with causes data losses on high traffic. However, > > > > it is also causin

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

2018-01-08 Thread Peter Zijlstra
On Sun, Jan 07, 2018 at 06:24:11PM -0800, Alexei Starovoitov wrote: > How about: > CONFIG_SPECTRE1_WORKAROUND_INDEX_MASK > CONFIG_SPECTRE1_WORKAROUND_LOAD_FENCE INSTRUCTION_FENCE if anything. LFENCE for Intel (and now also for AMD as per 0592b0bce169) is a misnomer, IFENCE would be a better name f

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

2018-01-08 Thread Peter Zijlstra
On Sun, Jan 07, 2018 at 06:57:35PM -0800, Alexei Starovoitov wrote: > On Sun, Jan 07, 2018 at 01:59:35PM +, Alan Cox wrote: > > lfence timing is also heavily dependent upon what work has to be done to > > retire previous live instructions. > > BPF does not normally do a lot of writing so you'

Re: WARNING: held lock freed!

2018-01-08 Thread Xin Long
On Mon, Jan 8, 2018 at 6:58 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 3219e264b984ec0a13923aa66385819c2e98d582 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is at

Re: dvb usb issues since kernel 4.9

2018-01-08 Thread Mauro Carvalho Chehab
Hi Linus, Em Sun, 7 Jan 2018 13:23:39 -0800 Linus Torvalds escreveu: > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > wrote: > > > > Em Sat, 6 Jan 2018 16:04:16 +0100 > > "Josef Griebichler" escreveu: > >> > >> the causing commit has been identified. > >> After reverting commit >

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

2018-01-08 Thread Andrea Arcangeli
On Sat, Jan 06, 2018 at 08:41:34PM +0100, Thomas Gleixner wrote: > optimized argumentation. We need to make sure that we have a solution which > kills the problem safely and then take it from there. Correctness first, > optimization later is the rule for this. Better safe than sorry. Agreed, assum

[PATCH] net: core: fix module type in sock_diag_bind

2018-01-08 Thread Andrii Vladyka
Use AF_INET6 instead of AF_INET in IPv6-related code path Signed-off-by: Andrii Vladyka --- net/core/sock_diag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock_diag.c b/net/core/sock_diag.c index 217f4e3..146b50e 100644 --- a/net/core/sock_diag.c +++ b/net/core

v4.15-rc7 regression/warning: suspicious RCU usage in net/wireless/util.c:778

2018-01-08 Thread Dominik Brodowski
On Sat, Dec 30, 2017 at 02:11:33PM +0100, Dominik Brodowski wrote: > On Fri, Dec 22, 2017 at 08:20:12AM +0100, Dominik Brodowski wrote: > > Dear all, > > > > once the (wifi) link becomes ready, the following warning is emitted on > > mainline (v4.15-rc4-202-gead68f216110) on my notebook: > > ...

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-08 Thread Peter Zijlstra
On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > wrote: > > In at least one place (mpls) you are patching a fast path. Compile out > > or don't load mpls by all means. But it is not acceptable to change the > > fast path without

Re: [PATCH 17/18] udf: prevent bounds-check bypass via speculative execution

2018-01-08 Thread Jan Kara
On Fri 05-01-18 17:11:26, Dan Williams wrote: > Static analysis reports that 'eahd->appAttrLocation' and > 'eahd->impAttrLocation' may be a user controlled values that are used as > data dependencies for calculating source and destination buffers for > memmove operations. In order to avoid potentia

[PATCH] net: gianfar_ptp: move set_fipers() to spinlock protecting area

2018-01-08 Thread Yangbo Lu
set_fipers() calling should be protected by spinlock. This patch is to move set_fipers() to spinlock protecting area in ptp_gianfar_adjtime() function. Signed-off-by: Yangbo Lu --- drivers/net/ethernet/freescale/gianfar_ptp.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --g

Re: [PATCH 02/31] fs: add new vfs_poll and file_can_poll helpers

2018-01-08 Thread Christoph Hellwig
On Sat, Jan 06, 2018 at 07:08:53PM +, Al Viro wrote: > On Thu, Jan 04, 2018 at 09:00:14AM +0100, Christoph Hellwig wrote: > > These abstract out calls to the poll method in preparation for changes to > > those methods. > > FWIW, I would make vfs_poll() > > static inline __poll_t vfs_poll(stru

Re: [PATCH 03/31] fs: introduce new ->get_poll_head and ->poll_mask methods

2018-01-08 Thread Christoph Hellwig
On Sat, Jan 06, 2018 at 07:12:42PM +, Al Viro wrote: > On Thu, Jan 04, 2018 at 09:00:15AM +0100, Christoph Hellwig wrote: > > ->get_poll_head returns the waitqueue that the poll operation is going > > to sleep on. Note that this means we can only use a single waitqueue > > for the poll, unlike

Re: IPv6 source based policy routing query

2018-01-08 Thread sundeep subbaraya
Hi David, Please let me know any other mailing list or persons I need to add. Thanks, Sundeep On Fri, Jan 5, 2018 at 12:07 PM, sundeep subbaraya wrote: > Hi, > > I am quite new to IPv6. > I ran to one problem hope you guys can help me. > I have multiple ethernet port box which runs by Altera's

Re: [PATCH 04/31] net: add support for ->poll_mask in proto_ops

2018-01-08 Thread Christoph Hellwig
On Sat, Jan 06, 2018 at 07:16:22PM +, Al Viro wrote: > On Thu, Jan 04, 2018 at 09:00:16AM +0100, Christoph Hellwig wrote: > > The socket file operations still implement ->poll until all protocols are > > switched over. > > > > Signed-off-by: Christoph Hellwig > > --- > > include/linux/net.h

Re: [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation

2018-01-08 Thread Vasundhara Volam
Hi Andy, If you are re-doing the patch, could you modify a minor comment below? On Sat, Jan 6, 2018 at 4:28 AM, Andy Gospodarek wrote: > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c > b/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c > new file mode 100644 > index 000..156e025

net: core: fix module type in sock_diag_bind

2018-01-08 Thread Andrii Vladyka
Use AF_INET6 instead of AF_INET in IPv6-related code path\ Signed-off-by: Andrii Vladyka --- net/core/sock_diag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock_diag.c b/net/core/sock_diag.c index 217f4e3..146b50e 100644 --- a/net/core/sock_diag.c +++ b/net/cor

Re: WARNING: CPU: 0 PID: 0 at ./include/linux/netfilter.h:233 arp_rcv

2018-01-08 Thread Marco Franchi
2018-01-08 4:32 GMT-02:00 Andy Duan : > From: Marco Franchi Sent: Friday, January 05, 2018 11:03 > PM >>Hi, >> >>I am getting the following warning on a imx6ul-evk board running linux-next >>20180105: >> >>[9.233290] [ cut here ] >>[9.242068] WARNING: CPU: 0 PID: 0

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

2018-01-08 Thread Laurent Pinchart
Hi Dan, Thank you for the patch. On Saturday, 6 January 2018 03:10:32 EET Dan Williams wrote: > Static analysis reports that 'index' may be a user controlled value that > is used as a data dependency to read 'pin' from the > 'selector->baSourceID' array. In order to avoid potential leaks of > ker

[PATCH] net: caif: use strlcpy() instead of strncpy()

2018-01-08 Thread Xiongfeng Wang
From: Xiongfeng Wang gcc-8 reports net/caif/caif_dev.c: In function 'caif_enroll_dev': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may be truncated copying 15 bytes from a string of length 15 [-Wstringop-truncation] net/caif/cfctrl.c: In function 'cfctrl_linkup_request':

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-08 Thread Alan Cox
On Mon, 8 Jan 2018 11:08:36 +0100 Peter Zijlstra wrote: > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > wrote: > > > In at least one place (mpls) you are patching a fast path. Compile out > > > or don't load mpls by al

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-08 Thread Peter Zijlstra
On Mon, Jan 08, 2018 at 11:43:42AM +, Alan Cox wrote: > On Mon, 8 Jan 2018 11:08:36 +0100 > Peter Zijlstra wrote: > > > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > > wrote: > > > > In at least one place (mpls) y

Re: KASAN: use-after-free Read in work_is_static_object

2018-01-08 Thread Dmitry Vyukov
On Mon, Jan 8, 2018 at 12:43 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > f66faae2f80a45feafc04ce63ef744ac4b6e8c05 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is a

Re: KASAN: use-after-free Read in work_is_static_object

2018-01-08 Thread Dmitry Vyukov
On Mon, Jan 8, 2018 at 12:55 PM, Dmitry Vyukov wrote: > On Mon, Jan 8, 2018 at 12:43 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> f66faae2f80a45feafc04ce63ef744ac4b6e8c05 >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master >> compiler: gcc (GC

Re: dvb usb issues since kernel 4.9

2018-01-08 Thread Jesper Dangaard Brouer
On Mon, 8 Jan 2018 08:02:00 -0200 Mauro Carvalho Chehab wrote: > Hi Linus, > > Em Sun, 7 Jan 2018 13:23:39 -0800 > Linus Torvalds escreveu: > > > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > > wrote: > > > > > > Em Sat, 6 Jan 2018 16:04:16 +0100 > > > "Josef Griebichler" escrev

RE: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

2018-01-08 Thread David Laight
From: Linus Torvalds > Sent: 07 January 2018 19:47 ... > Also, people definitely *are* noticing the performance issues with the > current set of patches, and they are causing real problems. Go search > for reports of Amazon AWS slowdowns. Try over 35% slowdown Given that AWS instance runs know

Re: WARNING: held lock freed!

2018-01-08 Thread Marcelo Ricardo Leitner
On Mon, Jan 08, 2018 at 06:01:14PM +0800, Xin Long wrote: > On Mon, Jan 8, 2018 at 6:58 AM, syzbot > wrote: > > Hello, > > > > syzkaller hit the following crash on > > 3219e264b984ec0a13923aa66385819c2e98d582 > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > > compiler:

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

2018-01-08 Thread Alan Cox
On Mon, 8 Jan 2018 12:00:28 + David Laight wrote: > From: Linus Torvalds > > Sent: 07 January 2018 19:47 > ... > > Also, people definitely *are* noticing the performance issues with the > > current set of patches, and they are causing real problems. Go search > > for reports of Amazon AWS s

RE: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

2018-01-08 Thread David Laight
From: Alan Cox > Sent: 08 January 2018 12:13 ... > > Try over 35% slowdown > > Given that AWS instance runs known code (user and kernel) why do we > > need to worry about any of these sideband attacks? > > You may not need to. Amazon themselves obviously need to worry that no > other VM steals

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-01-08 Thread Steffen Klassert
On Fri, Jan 05, 2018 at 10:13:23PM +0100, Tobias Hommel wrote: > Hi, > > I'm running into a NULL pointer dereference after updating from Linux 4.1.6 to > 4.14.11 (see kernel log below). I tried 4.14.3 initially which did not work > either. > Anyone has an idea what is happening here? > > The affe

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-01-08 Thread Steffen Klassert
On Sat, Jan 06, 2018 at 12:27:11AM +0300, Ozgur wrote: > > > 06.01.2018, 00:20, "Tobias Hommel" : > > Hi, > > Hi Tobias, > > > I'm running into a NULL pointer dereference after updating from Linux 4.1.6 > > to > > 4.14.11 (see kernel log below). I tried 4.14.3 initially which did not work > >

Re: dvb usb issues since kernel 4.9

2018-01-08 Thread Mauro Carvalho Chehab
Em Mon, 8 Jan 2018 12:59:10 +0100 Jesper Dangaard Brouer escreveu: > On Mon, 8 Jan 2018 08:02:00 -0200 > Mauro Carvalho Chehab wrote: > > > Hi Linus, > > > > Em Sun, 7 Jan 2018 13:23:39 -0800 > > Linus Torvalds escreveu: > > > > > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > >

Re: [PATCH] net: gianfar_ptp: move set_fipers() to spinlock protecting area

2018-01-08 Thread Fabio Estevam
On Mon, Jan 8, 2018 at 8:13 AM, Yangbo Lu wrote: > set_fipers() calling should be protected by spinlock. > This patch is to move set_fipers() to spinlock protecting > area in ptp_gianfar_adjtime() function. It would be nice to explay why. Thanks

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2018-01-08 Thread Masami Hiramatsu
On Sun, 7 Jan 2018 19:01:57 -0800 Alexei Starovoitov wrote: > On 12/29/17 12:20 AM, Masami Hiramatsu wrote: > >> Please run Josef's test in the !ftrace setup. > > Yes, I'll add the result of the test case. > > if Josef's test is passing in !ftrace config, > please resend your patches. > I think

RE: [RFCv2 4/4] bpf: inhibit speculated out-of-bounds pointers

2018-01-08 Thread Reshetova, Elena
> On Fri, Jan 05, 2018 at 02:57:50PM +, Mark Rutland wrote: > > Note: this patch is an *example* use of the nospec API. It is understood > > that this is incomplete, etc. > > > > Under speculation, CPUs may mis-predict branches in bounds checks. Thus, > > memory accesses under a bounds check ma

Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

2018-01-08 Thread Phil Sutter
Hi Chris, On Mon, Jan 08, 2018 at 02:03:53AM +, Chris Mi wrote: > > On Thu, Jan 04, 2018 at 04:34:51PM +0900, Chris Mi wrote: > > > The insertion rate is improved more than 10%. > > > > Did you measure the effect of increasing batch sizes? > Yes. Even if we enlarge the batch size bigger than

[PATCH net-next 0/3] ethtool ringparam upper bound

2018-01-08 Thread Tariq Toukan
Hi Dave, This patchset by Jenny adds sanity checks in ethtool ringparam operation for input upper bounds, similarly to what's done in ethtool_set_channels. The checks are added in patch 1, using a call to get_ringparam prior to calling set_ringparam NDO. Patch 2 changes the function's behavior i

[PATCH net-next 1/3] ethtool: Ensure new ring parameters are within bounds during SRINGPARAM

2018-01-08 Thread Tariq Toukan
From: Eugenia Emantayev Add a sanity check to ensure that all requested ring parameters are within bounds, which should reduce errors in driver implementation. Signed-off-by: Eugenia Emantayev Signed-off-by: Tariq Toukan --- net/core/ethtool.c | 13 +++-- 1 file changed, 11 insertions

[PATCH net-next 2/3] net/mlx4_en: Align behavior of set ring size flow via ethtool

2018-01-08 Thread Tariq Toukan
From: Eugenia Emantayev In current implementation, any requested RX/TX ring size value that is less than minimum is silently casted to nearest valid value. Update this behavior to align with mlx5 behavior by printing warning in dmesg and remaining the size unchanged. Kernel is responsible for ver

[PATCH net-next 3/3] net/mlx5e: Remove redundant checks in set_ringparam

2018-01-08 Thread Tariq Toukan
From: Eugenia Emantayev Since the checks are done in upper layer ethtool code, checks in driver are not needed any more. Signed-off-by: Eugenia Emantayev Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 15 --- 1 file changed, 15 deletions(-)

Re: [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation

2018-01-08 Thread Andy Gospodarek
On Mon, Jan 08, 2018 at 04:20:04PM +0530, Vasundhara Volam wrote: > Hi Andy, > > If you are re-doing the patch, could you modify a minor comment below? > > On Sat, Jan 6, 2018 at 4:28 AM, Andy Gospodarek wrote: > > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c > > b/drivers/net/

Re: [PATCH net-next v2 06/10] net/mlx5e: Change Mellanox references in DIM code

2018-01-08 Thread Andy Gospodarek
On Sun, Jan 07, 2018 at 11:44:48AM +0200, Tal Gilboa wrote: > > > On 1/6/2018 12:58 AM, Andy Gospodarek wrote: > > From: Andy Gospodarek > > > > Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and > > NET_DIM, respectively, in code that handles dynamic interrupt > > moderatio

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Graeme Gregory
On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote: > > > I already agreed with 'reg' being awkward in the later emails. > > > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > > > > Ah it is an actual address, then yes _ADR is probably more appropriate. > > Newbi

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Andrew Lunn
On Mon, Jan 08, 2018 at 02:45:48PM +, Graeme Gregory wrote: > On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote: > > > > I already agreed with 'reg' being awkward in the later emails. > > > > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > > > > > > Ah it is

[PATCH v2] net: ipv4: emulate READ_ONCE() on ->hdrincl bit-field in raw_sendmsg()

2018-01-08 Thread Nicolai Stange
y (with inspection of compiler output on x86_64). Note that there's still a ->hdrincl reload, but that's due to the inet_sk_flowi_flags() invocation and probably harmless. Applicable to linux-next-20180108. Changes to v2: - Apply review from Stefano Brivio, i.e. drop the __hdrincl

Re: [RFC] memdup_user() and friends

2018-01-08 Thread Marcelo Ricardo Leitner
On Sun, Jan 07, 2018 at 02:16:56AM +, Al Viro wrote: ... > > Everything else is definitely fine with GFP_USER - it's stuff like "copy of > ioctl > arguments in an ioctl never issued by the kernel code, must have come > straight from > ioctl(2)" and things like that. IMO we should simply swi

Re: [Xen-devel] [PATCH] xen-netfront: enable device after manual module load

2018-01-08 Thread Boris Ostrovsky
On 01/05/2018 03:42 AM, Eduardo Otubo wrote: > When loading the module after unloading it, the network interface would > not be enabled and thus wouldn't have a backend counterpart and unable > to be used by the guest. > > The guest would face errors like: > > [root@guest ~]# ethtool -i eth0 >

Re: [PATCH v2] net: ipv4: emulate READ_ONCE() on ->hdrincl bit-field in raw_sendmsg()

2018-01-08 Thread Stefano Brivio
On Mon, 8 Jan 2018 15:54:44 +0100 Nicolai Stange wrote: > Commit 8f659a03a0ba ("net: ipv4: fix for a race condition in > raw_sendmsg") fixed the issue of possibly inconsistent ->hdrincl handling > due to concurrent updates by reading this bit-field member into a local > variable and using the th

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Graeme Gregory
On Mon, Jan 08, 2018 at 03:53:12PM +0100, Andrew Lunn wrote: > On Mon, Jan 08, 2018 at 02:45:48PM +, Graeme Gregory wrote: > > On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote: > > > > > I already agreed with 'reg' being awkward in the later emails. > > > > > Wouldn't _ADR be more ap

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-08 Thread Marcelo Ricardo Leitner
On Sat, Jan 06, 2018 at 12:09:18AM +0100, Jiri Pirko wrote: ... > Note we cannot use the qdisc for filter manipulations for shared blocks: > > $ tc filter add dev ens8 ingress protocol ip pref 1 flower dst_ip > 192.168.100.2 action drop > Error: Cannot work with shared block, please use block ind

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2018-01-08 Thread Arnd Bergmann
On Fri, Jan 5, 2018 at 10:31 AM, Daniel Lezcano wrote: >>> No. Can't you add in arch/ndis32/Kconfig ? >>> >>> +select TIMER_ATCPIT100 >>> >>> Like: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/Kconfig#n50 >> >> IMHO, it might be a little bit wierd if w

RE: [PATCH] hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()

2018-01-08 Thread Haiyang Zhang
> -Original Message- > From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net] > Sent: Sunday, January 7, 2018 3:10 PM > To: de...@linuxdriverproject.org; netdev@vger.kernel.org; Haiyang Zhang > ; KY Srinivasan ; Stephen > Hemminger > Cc: LKML ; kernel-janit...@vger.kernel.org > S

Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

2018-01-08 Thread Stephen Hemminger
On Mon, 8 Jan 2018 08:00:00 + Chris Mi wrote: > > >> I wonder whether specifying the batch size is necessary at all. > > >> Couldn't batch mode just collect messages until either EOF or an > > >> incompatible command is encountered which then triggers a commit to > > >> kernel? This might sim

[nf-next:master 54/54] net//netfilter/nf_flow_table.c:196:6: error: void value not ignored as it ought to be

2018-01-08 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master head: 7844629488fd1489d19a08ce25a51e03e69834a7 commit: 7844629488fd1489d19a08ce25a51e03e69834a7 [54/54] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next config: ia64-allmodconfig (attached as .conf

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-08 Thread Jiri Pirko
Mon, Jan 08, 2018 at 04:23:06PM CET, marcelo.leit...@gmail.com wrote: >On Sat, Jan 06, 2018 at 12:09:18AM +0100, Jiri Pirko wrote: >... >> Note we cannot use the qdisc for filter manipulations for shared blocks: >> >> $ tc filter add dev ens8 ingress protocol ip pref 1 flower dst_ip >> 192.168.10

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Andrew Lunn
w> I am not familiar with MDIO, but if its similar or a specific > implementation of a serial bus that does sound sane! It is a two wire serial bus. A good overview can be found here: https://www.totalphase.com/support/articles/200349206-MDIO-Background Andrew

Re: rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

2018-01-08 Thread Kalle Valo
SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 29 Dec 2017 22:11:42 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > Acked-by: Stanislaw Gruszka

Re: [PATCHv3 0/2] capability controlled user-namespaces

2018-01-08 Thread Serge E. Hallyn
Quoting James Morris (james.l.mor...@oracle.com): > On Mon, 8 Jan 2018, Serge E. Hallyn wrote: > > > > Also, why do we need the concept of a controlled user-ns at all, if the > > > default whitelist maintains existing behavior? > > > > In past discussions two uses have been brought up: > > > >

Re: general protection fault in free_verifier_state (2)

2018-01-08 Thread Alexei Starovoitov
uffer: >(ftrace buffer empty) > Modules linked in: > CPU: 0 PID: 3468 Comm: syzkaller619543 Not tainted 4.15.0-rc6-next-20180108+ > #90 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > Google 01/01/2011 > RIP: 0010:free_func_state kernel/bpf/verif

[PATCH bpf-next] bpf: fix verifier GPF in kmalloc failure path

2018-01-08 Thread Alexei Starovoitov
From: Alexei Starovoitov syzbot reported the following panic in the verifier triggered by kmalloc error injection: kasan: GPF could be caused by NULL-ptr deref or user memory access RIP: 0010:copy_func_state kernel/bpf/verifier.c:403 [inline] RIP: 0010:copy_verifier_state+0x364/0x590 kernel/bpf/

Re: [PATCH 2/2] Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find."

2018-01-08 Thread Nicolas Dichtel
Le 05/01/2018 à 18:17, David Miller a écrit : [snip] > I will in my next batch of stable submissions. > Thank you!

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2018-01-08 Thread Daniel Lezcano
On 08/01/2018 16:26, Arnd Bergmann wrote: > On Fri, Jan 5, 2018 at 10:31 AM, Daniel Lezcano > wrote: No. Can't you add in arch/ndis32/Kconfig ? +select TIMER_ATCPIT100 Like: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/Kconfi

Re: dvb usb issues since kernel 4.9

2018-01-08 Thread Alan Stern
On Mon, 8 Jan 2018, Mauro Carvalho Chehab wrote: > Em Sun, 7 Jan 2018 10:41:37 -0500 (EST) > Alan Stern escreveu: > > > On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote: > > > > > > > It seems that the original patch were designed to solve some IRQ > > > > > issues > > > > > with network cards

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-08 Thread Bart Van Assche
On 01/05/18 22:30, Dan Williams wrote: On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman wrote: Please expand this. It is not clear what the static analysis is looking for. Have a clear description of what is being fixed is crucial for allowing any of these changes. For the details given in

[PATCH net] 9p: add missing module license for xen transport

2018-01-08 Thread Stephen Hemminger
The 9P of Xen module is missing required license and module information. See https://bugzilla.kernel.org/show_bug.cgi?id=198109 Reported-by: Alan Bartlett Fixes: 868eb122739a ("xen/9pfs: introduce Xen 9pfs transport driver") Signed-off-by: Stephen Hemminger --- net/9p/trans_xen.c | 4 1 fi

Re: dvb usb issues since kernel 4.9

2018-01-08 Thread Alan Stern
On Mon, 8 Jan 2018, Mauro Carvalho Chehab wrote: > > Let find the root-cause of this before reverting, as this will hurt the > > networking use-case. > > > > I want to see if the increase buffer will solve the issue (the current > > buffer of 0.63 ms seem too small). > > For TV, high latency has

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

2018-01-08 Thread Kalle Valo
Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai You submitted an identical patch a week earlier: https://patchwork.kernel.o

[PATCH net-next] ibmvnic: Don't handle RX interrupts when not up.

2018-01-08 Thread Nathan Fontenot
Initiating a kdump via the command line can cause a pending interrupt to be handled by the ibmvnic driver when initializing the sub-CRQ irqs during driver initialization. NIP [d0ca34f0] ibmvnic_interrupt_rx+0x40/0xd0 [ibmvnic] LR [c8132ef0] __handle_irq_event_percpu+0xa0/0x2f0 Call

Aw: Re: dvb usb issues since kernel 4.9

2018-01-08 Thread Josef Griebichler
Hi Maro, I tried your mentioned patch but unfortunately no real improvement for me. dmesg http://ix.io/DOg tvheadend service log http://ix.io/DOi Errors during recording are still there. Errors increase if there is additional tcp load on raspberry. Unfortunately there's no usbmon or tshark on lib

Re: [PATCH 02/18] Documentation: document nospec helpers

2018-01-08 Thread Jonathan Corbet
On Fri, 05 Jan 2018 17:10:03 -0800 Dan Williams wrote: > Document the rationale and usage of the new nospec*() helpers. I have just a couple of overall comments. - It would be nice if the document were done in RST and placed in the core-API manual, perhaps using kerneldoc comments for the m

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2018-01-08 Thread Arnd Bergmann
On Mon, Jan 8, 2018 at 5:08 PM, Daniel Lezcano wrote: > On 08/01/2018 16:26, Arnd Bergmann wrote: >> On Fri, Jan 5, 2018 at 10:31 AM, Daniel Lezcano >> wrote: >>> >>> etc ... >> >> I'd actually prefer to not do it for ARM either: Most other subsystems >> don't do that, and I don't see a strong r

Re: Aw: Re: dvb usb issues since kernel 4.9

2018-01-08 Thread Alan Stern
On Mon, 8 Jan 2018, Josef Griebichler wrote: > Hi Maro, > > I tried your mentioned patch but unfortunately no real improvement for me. > dmesg http://ix.io/DOg > tvheadend service log http://ix.io/DOi > Errors during recording are still there. > Errors increase if there is additional tcp load on

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

2018-01-08 Thread Larry Finger
On 01/08/2018 10:21 AM, Kalle Valo wrote: Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai You submitted an identical patch a week e

Re: [PATCH bpf] selftests/bpf: fix test_align

2018-01-08 Thread Edward Cree
On 05/01/18 23:02, Alexei Starovoitov wrote: > since commit 82abbf8d2fc4 the verifier rejects the bit-wise > arithmetic on pointers earlier. > The test 'dubious pointer arithmetic' now has less output to match on. > Adjust it. > > Fixes: 82abbf8d2fc4 ("bpf: do not allow root to mangle valid pointer

Re: b53 tags on bpi-r1 (bcm53125)

2018-01-08 Thread Jochen Friedrich
Hi Florian, Am 04.01.2018 um 05:49 schrieb Florian Fainelli: On 12/29/2017 07:22 PM, Florian Fainelli wrote: Le 12/29/17 à 13:56, Florian Fainelli a écrit : Le 12/29/17 à 12:21, Florian Fainelli a écrit : Hi Jochen, Le 12/18/17 à 02:44, Jochen Friedrich a écrit : Hi Florian, unfortunately,

[PATCH iproute2 v3 3/7] ip6/tunnel: Unify tclass printing

2018-01-08 Thread Serhey Popovych
Use @s2 buffer to store string representation of tclass and get rid of extra SPRINT_BUF(): no need to preserve @s2 contents for later. Use print_string(PRINT_ANY, ...) with prepared by snprintf() string for both PRINT_JSON and PRINT_FP cases. While there use __u32 for flowinfo in link_gre6.c and

[PATCH iproute2 v3 1/7] ip6/tunnel: Fix tclass output

2018-01-08 Thread Serhey Popovych
In link_gre6.c it seems copy paste error: tclass is 8 bits, not 20 as flowlabel. In link_iptnl.c rename "flowinfo_tclass" to "tclass" as it correct name since flowinfo is implementation internal name used to label combined within u32 attribute tclass and flowlabel. Fixes: 1facc1c61c07 ("ip: link_

[PATCH iproute2 v3 5/7] ip6/tunnel: Unify encap_limit printing

2018-01-08 Thread Serhey Popovych
Use %u format specifier to print it in link_gre6.c and make code more readable. Signed-off-by: Serhey Popovych --- ip/link_gre6.c | 11 --- ip/link_ip6tnl.c | 12 ++-- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/ip/link_gre6.c b/ip/link_gre6.c index 120

[PATCH iproute2 v3 6/7] gre6/tunnel: Output flowlabel after tclass

2018-01-08 Thread Serhey Popovych
To follow ip6tnl output print flowlabel after tclass in link_gre6.c. Signed-off-by: Serhey Popovych --- ip/link_gre6.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/ip/link_gre6.c b/ip/link_gre6.c index 8014207..55bd1fb 100644 --- a/ip/link_gre6

[PATCH iproute2 v3 2/7] ip6tnl/tunnel: Do not print obscure flowinfo

2018-01-08 Thread Serhey Popovych
It is implementation internal and main purpose of printing it seems debugging. Signed-off-by: Serhey Popovych --- ip/link_ip6tnl.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c index 8e84ed0..e084975 100644 --- a/ip/link_ip6tnl.c +++ b/ip/li

[PATCH iproute2 v3 0/7] ip6/tunnel: Unify tclass, flowlabel and encap_limit output

2018-01-08 Thread Serhey Popovych
With this series I want to improve printing of tclass, flowlabel and encapsulation limit (encap_limit) options. Everything within this series is open for your comments, suggestions and criticism. See individual patch description message for details. Thanks, Serhii Serhey Popovych (7): ip6/tun

Re: [PATCH bpf] bpf: prevent out-of-bounds speculation

2018-01-08 Thread Mark Rutland
Hi Alexei, On Thu, Jan 04, 2018 at 08:28:11PM -0800, Alexei Starovoitov wrote: > From: Alexei Starovoitov > > Under speculation, CPUs may mis-predict branches in bounds checks. Thus, > memory accesses under a bounds check may be speculated even if the > bounds check fails, providing a primitive

[PATCH iproute2 v3 4/7] ip6/tunnel: Unify flowlabel printing

2018-01-08 Thread Serhey Popovych
Use @s2 buffer to store string representation of flowlabel and get rid of extra SPRINT_BUF(): no need to preserve @s2 contents for later. Use print_string(PRINT_ANY, ...) with prepared by snprintf() string for both PRINT_JSON and PRINT_FP cases. Omit flowlabel from output if no flowinfo attribute

[PATCH iproute2 0/7] ip6/tunnel: Unify tclass, flowlabel and encap_limit output

2018-01-08 Thread Serhey Popovych
With this series I want to improve printing of tclass, flowlabel and encapsulation limit (encap_limit) options. Everything within this series is open for your comments, suggestions and criticism. See individual patch description message for details. Thanks, Serhii Serhey Popovych (7): ip6/tun

[PATCH iproute2 1/7] ip6/tunnel: Fix tclass output

2018-01-08 Thread Serhey Popovych
In link_gre6.c it seems copy paste error: tclass is 8 bits, not 20 as flowlabel. In link_iptnl.c rename "flowinfo_tclass" to "tclass" as it correct name since flowinfo is implementation internal name used to label combined within u32 attribute tclass and flowlabel. Fixes: 1facc1c61c07 ("ip: link_

[PATCH iproute2 4/7] ip6/tunnel: Unify flowlabel printing

2018-01-08 Thread Serhey Popovych
Use @s2 buffer to store string representation of flowlabel and get rid of extra SPRINT_BUF(): no need to preserve @s2 contents for later. Use print_string(PRINT_ANY, ...) with prepared by snprintf() string for both PRINT_JSON and PRINT_FP cases. Omit flowlabel from output if no flowinfo attribute

[PATCH iproute2 5/7] ip6/tunnel: Unify encap_limit printing

2018-01-08 Thread Serhey Popovych
Use %u format specifier to print it in link_gre6.c and make code more readable. Signed-off-by: Serhey Popovych --- ip/link_gre6.c | 11 --- ip/link_ip6tnl.c | 12 ++-- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/ip/link_gre6.c b/ip/link_gre6.c index 120

[PATCH iproute2 3/7] ip6/tunnel: Unify tclass printing

2018-01-08 Thread Serhey Popovych
Use @s2 buffer to store string representation of tclass and get rid of extra SPRINT_BUF(): no need to preserve @s2 contents for later. Use print_string(PRINT_ANY, ...) with prepared by snprintf() string for both PRINT_JSON and PRINT_FP cases. While there use __u32 for flowinfo in link_gre6.c and

[PATCH iproute2 7/7] ip6tnl/tunnel: Output hoplimit before encapsulation limit

2018-01-08 Thread Serhey Popovych
To follow gre6 output print hoplimit before encapsulation limit in link_ip6tnl.c. Signed-off-by: Serhey Popovych --- ip/link_ip6tnl.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c index 379eb33..bbc7878 100644 --- a/ip/lin

[PATCH iproute2 6/7] gre6/tunnel: Output flowlabel after tclass

2018-01-08 Thread Serhey Popovych
To follow ip6tnl output print flowlabel after tclass in link_gre6.c. Signed-off-by: Serhey Popovych --- ip/link_gre6.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/ip/link_gre6.c b/ip/link_gre6.c index 8014207..55bd1fb 100644 --- a/ip/link_gre6

Re: [PATCH iproute2 v3 0/7] ip6/tunnel: Unify tclass, flowlabel and encap_limit output

2018-01-08 Thread Serhey Popovych
Please ignore series: wrong series number (3). Sorry for noise. > With this series I want to improve printing of tclass, > flowlabel and encapsulation limit (encap_limit) options. > > Everything within this series is open for your comments, > suggestions and criticism. > > See individual patch

[PATCH iproute2 2/7] ip6tnl/tunnel: Do not print obscure flowinfo

2018-01-08 Thread Serhey Popovych
It is implementation internal and main purpose of printing it seems debugging. Signed-off-by: Serhey Popovych --- ip/link_ip6tnl.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c index 8e84ed0..e084975 100644 --- a/ip/link_ip6tnl.c +++ b/ip/li

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

2018-01-08 Thread Kalle Valo
Larry Finger writes: > On 01/08/2018 10:21 AM, Kalle Valo wrote: >> Jia-Ju Bai wrote: >> >>> b43_radio_2057_init_post is not called in an interrupt handler >>> nor holding a spinlock. >>> The function mdelay in it can be replaced with msleep, to reduce busy wait. >>> >>> Signed-off-by: Jia-Ju Ba

Re: [PATCH 02/18] Documentation: document nospec helpers

2018-01-08 Thread Mark Rutland
Hi Jon, On Mon, Jan 08, 2018 at 09:29:17AM -0700, Jonathan Corbet wrote: > On Fri, 05 Jan 2018 17:10:03 -0800 > Dan Williams wrote: > > > Document the rationale and usage of the new nospec*() helpers. > > I have just a couple of overall comments. > > - It would be nice if the document were do

Re: [PATCH net-next v5 2/2] net: thunderx: add timestamping support

2018-01-08 Thread Aleksey Makarov
On 12.12.2017 05:32, Richard Cochran wrote: > On Mon, Dec 11, 2017 at 05:14:31PM +0300, Aleksey Makarov wrote: >> diff --git a/drivers/net/ethernet/cavium/thunder/nic.h >> b/drivers/net/ethernet/cavium/thunder/nic.h >> index 4a02e618e318..204b234beb9d 100644 >> --- a/drivers/net/ethernet/cavium/

  1   2   3   4   >