> >> I wonder whether specifying the batch size is necessary at all. > >> Couldn't batch mode just collect messages until either EOF or an > >> incompatible command is encountered which then triggers a commit to > >> kernel? This might simplify code quite a bit. > > That's a good suggestion. > > Thanks for your time on this, Chris. After testing, I find that the message passed to kernel should not be too big. If it is bigger than about 64K, sendmsg returns -1, errno is 90 (EMSGSIZE). That is about 400 commands. So how about set batch size to 128 which is big enough?
- Re: [patch iproute2 v6 1/3] lib/libnetlink: A... David Ahern
- [patch iproute2 v6 2/3] tc: Add -bs option to batc... Chris Mi
- Re: [patch iproute2 v6 2/3] tc: Add -bs optio... Marcelo Ricardo Leitner
- Re: [patch iproute2 v6 2/3] tc: Add -bs optio... David Ahern
- Re: [patch iproute2 v6 2/3] tc: Add -bs o... Marcelo Ricardo Leitner
- Re: [patch iproute2 v6 0/3] tc: Add -bs option to ... Phil Sutter
- Re: [patch iproute2 v6 0/3] tc: Add -bs optio... David Ahern
- Re: [patch iproute2 v6 0/3] tc: Add -bs o... Marcelo Ricardo Leitner
- RE: [patch iproute2 v6 0/3] tc: Add -bs optio... Chris Mi
- Re: [patch iproute2 v6 0/3] tc: Add -bs o... David Ahern
- RE: [patch iproute2 v6 0/3] tc: Add -... Chris Mi
- Re: [patch iproute2 v6 0/3] tc: A... Stephen Hemminger
- RE: [patch iproute2 v6 0/3] ... Chris Mi
- Re: [patch iproute2 v6 0/3] tc: Add -bs o... Phil Sutter