Re: [8/10] ath9k: Use ARRAY_SIZE macro

2017-09-25 Thread Kalle Valo
Thomas Meyer wrote: > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > yourself. > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e > 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) > /ARRAY_SIZE(\1)/g' and manual check/ve

Re: ath10k: make ath10k_hw_ce_regs const

2017-09-25 Thread Kalle Valo
Bhumika Goyal wrote: > Make them const as they are not modified in the file referencing > them. They are only stored in the const field 'hw_ce_reg' of an ath10k > structure. Also, make the declarations in the header const. > > Signed-off-by: Bhumika Goyal > Signed-off-by: Kalle Valo Patch app

Re: [2/2] ath9k: Avoid a potential deadlock

2017-09-25 Thread Kalle Valo
Ville Syrjälä wrote: > Lockdep warns us that sc_pm_lock and cc_lock can cause a deadlock when > cc_lock is acquired by itself with interrupts enabled. Disable irqs > whenever taking cc_lock to avoid this. > > [ 19.094524] kworker/u2:0/5 just changed the state of lock: > [ 19.094578] (&(&sc->

Re: [PATCH net-next 10/10] net: hns3: Add mqprio support when interacting with network stack

2017-09-25 Thread Yunsheng Lin
Hi, Jiri On 2017/9/25 14:57, Jiri Pirko wrote: > Mon, Sep 25, 2017 at 02:45:08AM CEST, linyunsh...@huawei.com wrote: >> Hi, Jiri >> >> On 2017/9/24 19:37, Jiri Pirko wrote: >>> Sat, Sep 23, 2017 at 02:47:20AM CEST, linyunsh...@huawei.com wrote: Hi, Jiri On 2017/9/23 0:03, Jiri Pirko

[PATCH v2 1/4] net: af_packet: use setup_timer() helper.

2017-09-25 Thread Allen Pais
Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- v2: rebased to latest net-next. net/packet/af_packet.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c i

Re: [PATCH 0/5] use setup_timer() helper function.

2017-09-25 Thread Allen
> > There was a recent change to the nfc code in net-next which causes > your patches to not apply. > > Please repsin against net-next, thanks. Sent out V2. Thanks.

[PATCH v2 2/4] net: nfc: hci: use setup_timer() helper.

2017-09-25 Thread Allen Pais
Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- v2: rebased to latest net-next. net/nfc/hci/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c index b7

[PATCH v2 4/4] net: nfc: llcp_core: use setup_timer() helper.

2017-09-25 Thread Allen Pais
Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- v2: rebased to latest net-next. net/nfc/llcp_core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/net/nfc/llcp_core.c b/net/nfc/llcp_core.c

[PATCH v2 3/4] net: nfc: hci: llc_shdlc: use setup_timer() helper.

2017-09-25 Thread Allen Pais
Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- v2: rebased to latest net-next. net/nfc/hci/llc_shdlc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/net/nfc/hci/llc_shdlc.c b/net/nf

[PATCH net v2 0/4] net:ethernet:aquantia: Atlantic driver bugfixes und improvements

2017-09-25 Thread Igor Russkikh
This series contains bugfixes for aQuantia Atlantic driver. Changes in v2: Review comments applied: - min_mtu set removed - extra mtu range check is removed - err codes handling improved Igor Russkikh (3): net:ethernet:aquantia: Setup max_mtu in ndev to enable jumbo frames net:ethernet:aquant

[PATCH net v2 1/4] net:ethernet:aquantia: Setup max_mtu in ndev to enable jumbo frames

2017-09-25 Thread Igor Russkikh
Although hardware is capable for almost 16K MTU, without max_mtu field correctly set it only allows standard MTU to be used. This patch enables max MTU, calculating it from hardware maximum frame size of 16352 octets (including FCS). Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev

[PATCH net v2 3/4] net:ethernet:aquantia: Fix transient invalid link down/up indications

2017-09-25 Thread Igor Russkikh
Due to a bug in aquantia atlantic card firmware, it sometimes reports invalid link speed bits. That caused driver to report link down events, although link itself is totally fine. This patch ignores such out of blue readings. Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers

[PATCH net v2 4/4] net:ethernet:atlantic: fix iommu errors

2017-09-25 Thread Igor Russkikh
From: Pavel Belous Call skb_frag_dma_map multiple times if tx length is greater than device max and avoid processing tx ring until entire packet has been sent. Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 43 ++

[PATCH net v2 2/4] net:ethernet:aquantia: Fix Tx queue hangups

2017-09-25 Thread Igor Russkikh
Driver did a poor job in managing its Tx queues: Sometimes it could stop tx queues due to link down condition in aq_nic_xmit - but never waked up them. That led to Tx path total suspend. This patch fixes this and improves generic queue management: - introduces queue restart counter - uses generic n

Re: brcmsmac: make const array ucode_ofdm_rates static, reduces object code size

2017-09-25 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ucode_ofdm_rates on the stack, instead make it > static. Makes the object code smaller by 100 bytes: > > Before: >text data bss dec hex filename > 39482 564 0 400469c6e

Re: [v2] rtl8xxxu: Don't printk raw binary if serial number is not burned in.

2017-09-25 Thread Kalle Valo
Adam Borowski wrote: > I assume that a blank efuse comes with all ones, thus I did not bother > recognizing other possible junk values. This matches 100% of dongles > I've seen (a single Gembird 8192eu). > > Signed-off-by: Adam Borowski Patch applied to wireless-drivers-next.git, thanks. e0a

Re: mwifiex: make const array tos_to_ac static, reduces object code size

2017-09-25 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Don't populate the read-only const array tos_to_ac on the stack, > instead make it static. Makes the object code smaller by 250 bytes: > > Before: >text data bss dec hex filename > 26104 2720 128 28952

Re: b43: make const arrays static, reduces object code size

2017-09-25 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them static. > Makes the object code smaller by over 60 bytes: > > Before: >text data bss dec hex filename > 14816 1296 0 161123ef0 b43/phy_ht

Re: iwlegacy: make const array static to shink object code size

2017-09-25 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ac_to_fifo on the stack in an inlined > function, instead make it static. Makes the object code smaller > by over 800 bytes: > >text data bss dec hex filename > 159029 331541216

[patch net-next 09/10] mlxsw: spectrum_dpipe: Add support for adjacency table dump

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for adjacency table dump. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 238 + 1 file changed, 238 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/sp

[patch net-next 00/10] mlxsw: Add router adjacency dpipe table

2017-09-25 Thread Jiri Pirko
From: Jiri Pirko Arkadi says: This patchset adds router adjacency dpipe table support. This will provide the ability to observe the hardware offloaded IPv4/6 nexthops. Arkadi Sharshevsky (10): mlxsw: spectrum_dpipe: Fix indentation in header description mlxsw: Add fields for mlxsw's meta he

[patch net-next 08/10] mlxsw: spectrum: Add support for setting counters on nexthops

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for setting counters on nexthops based on dpipe's adjacency table counter status. This patch also adds the ability for getting the counter value, which will be used by the dpipe adjacency table dump implementation in the next patches. Signed-off-by: Arkadi Sh

[patch net-next 01/10] mlxsw: spectrum_dpipe: Fix indentation in header description

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Fix indentation in mlxsw_meta header's description. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 23 -- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/

[patch net-next 10/10] mlxsw: spectrum_dpipe: Add support for controlling nexthop counters

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for controlling nexthop counters via dpipe. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 24 ++ .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 12 +--

[patch net-next 05/10] mlxsw: spectrum_router: Add helpers for nexthop access

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky This is done as a preparation before introducing the ability to dump the adjacency table via dpipe, and to count the table size. The current table implementation avoids tunnel entries, thus a helper for checking if the nexthop group contains tunnel entries is also provide

[patch net-next 04/10] mlxsw: spectrum_router: Use helper to check for last neighbor

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Use list_is_last helper to check for last neighbor. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/

[patch net-next 02/10] mlxsw: Add fields for mlxsw's meta header for adjacency table

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky This patch adds field for mlxsw's meta header which will be used to describe the match/action behavior of the adjacency table. The fields are: 1. Adj_index - The global index of the nexthop group in the adjacency table. 2. Adj_hash_index - Local index offset which is

[patch net-next 03/10] mlxsw: spectrum_router: Keep nexthops in a linked list

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Keep nexthops in a linked list for easy access. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spect

[patch net-next 07/10] mlxsw: reg: Add support for counters on RATR

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky In order to add the ability for setting counters on nexthops the RATR register should be extended. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 44 --- 1 file changed, 35 insert

[patch net-next 06/10] mlxsw: spectrum_dpipe: Add initial support for the router adjacency table

2017-09-25 Thread Jiri Pirko
From: Arkadi Sharshevsky Add initial support for router adjacency table. The table does lookup based on the nexthop-group index and the local nexthop offset. After locating the nexthop entry it sets the destination MAC address and the egress RIF. Signed-off-by: Arkadi Sharshevsky Signed-off-by:

pull-request: wireless-drivers 2017-09-25

2017-09-25 Thread Kalle Valo
Hi Dave, here a pull request to net for 4.14, more info in the signed tag below. Please let me know if there are any problems. Kalle The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository at:

[patch net-next 1/3] mlxsw: spectrum_acl: Propagate errors from mlxsw_afa_block_jump/continue

2017-09-25 Thread Jiri Pirko
From: Jiri Pirko Propagate error instead of doing WARN_ON right away. Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c| 14 -- .../net/ethernet/mellanox/mlxsw/core_acl_flex_actions.h| 4 ++-- drivers/net/ethernet/mellanox/mlxsw/spectrum

[patch net-next 0/3] mlxsw: Introduce support for "pass" gact action offloading

2017-09-25 Thread Jiri Pirko
From: Jiri Pirko Very simple patchset adds ability for user to insert filters with "pass" gact action and offload it. That allows scenarios like this: $ tc filter add dev enp3s0np19 ingress protocol ip pref 10 flower skip_sw dst_ip 192.168.101.0/24 action drop $ tc filter add dev enp3s0np19 ing

[patch net-next 3/3] mlxsw: spectrum_flower: Offload "ok" termination action

2017-09-25 Thread Jiri Pirko
From: Jiri Pirko If action is "gact_ok", offload it to HW. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c b/drivers/net/ethernet/

[patch net-next 2/3] net: sched: introduce helper to identify gact pass action

2017-09-25 Thread Jiri Pirko
From: Jiri Pirko Introduce a helper called is_tcf_gact_pass which could be used to tell if the action is gact pass or not. Signed-off-by: Jiri Pirko --- include/net/tc_act/tc_gact.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/tc_act/tc_gact.h b/include/net/tc_act/tc_ga

Re: [patch net-next v2 01/12] fib: notifier: Add VIF add and delete event types

2017-09-25 Thread Nikolay Aleksandrov
On 24/09/17 20:22, Jiri Pirko wrote: > From: Yotam Gigi > > In order for an interface to forward packets according to the kernel > multicast routing table, it must be configured with a VIF index according > to the mroute user API. The VIF index is then used to refer to that > interface in the mro

Re: [patch net-next v2 02/12] ipmr: Add reference count to MFC entries

2017-09-25 Thread Nikolay Aleksandrov
On 24/09/17 20:22, Jiri Pirko wrote: > From: Yotam Gigi > > Next commits will introduce MFC notifications through the atomic > fib_notification chain, thus allowing modules to be aware of MFC entries. > > Due to the fact that modules may need to hold a reference to an MFC entry, > add reference

Re: [patch net-next v2 03/12] ipmr: Add FIB notification access functions

2017-09-25 Thread Nikolay Aleksandrov
On 24/09/17 20:22, Jiri Pirko wrote: > From: Yotam Gigi > > Make the ipmr module register as a FIB notifier. To do that, implement both > the ipmr_seq_read and ipmr_dump ops. > > The ipmr_seq_read op returns a sequence counter that is incremented on > every notification related operation done by

Re: [patch net-next v2 05/12] net: ipmr: Add MFC offload indication

2017-09-25 Thread Nikolay Aleksandrov
On 24/09/17 20:22, Jiri Pirko wrote: > From: Yotam Gigi > > Allow drivers, registered to the fib notification chain indicate whether a > multicast MFC route is offloaded or not, similarly to unicast routes. The > indication of whether a route is offloaded is done using the mfc_flags > field on an

Re: [patch net-next v2 06/12] net: mroute: Check if rule is a default rule

2017-09-25 Thread Nikolay Aleksandrov
On 24/09/17 20:22, Jiri Pirko wrote: > From: Yotam Gigi > > When the ipmr starts, it adds one default FIB rule that matches all packets > and sends them to the DEFAULT (multicast) FIB table. A more complex rule > can be added by user to specify that for a specific interface, a packet > should be

Re: [patch net-next v2 03/12] ipmr: Add FIB notification access functions

2017-09-25 Thread Nikolay Aleksandrov
On 25/09/17 12:35, Nikolay Aleksandrov wrote: > On 24/09/17 20:22, Jiri Pirko wrote: >> From: Yotam Gigi >> >> Make the ipmr module register as a FIB notifier. To do that, implement both >> the ipmr_seq_read and ipmr_dump ops. >> >> The ipmr_seq_read op returns a sequence counter that is increment

Re: tg3 pxe weirdness

2017-09-25 Thread Siva Reddy Kallam
On Fri, Sep 22, 2017 at 9:04 PM, Berend De Schouwer wrote: > On Fri, 2017-09-22 at 11:51 +0530, Siva Reddy Kallam wrote: >> >> >> Can you please share below details? >> 1) Model and Manufacturer of the system >> 2) Linux distro/kernel used? > > 4.13.3 gets a little further, but after some more dat

Re: [patch net-next v2 06/12] net: mroute: Check if rule is a default rule

2017-09-25 Thread Jiri Pirko
Mon, Sep 25, 2017 at 03:28:21AM CEST, linyunsh...@huawei.com wrote: >Hi, Jiri > >On 2017/9/25 1:22, Jiri Pirko wrote: >> From: Yotam Gigi >> >> When the ipmr starts, it adds one default FIB rule that matches all packets >> and sends them to the DEFAULT (multicast) FIB table. A more complex rule >

Re: [patch net-next v2 03/12] ipmr: Add FIB notification access functions

2017-09-25 Thread Jiri Pirko
Mon, Sep 25, 2017 at 11:40:16AM CEST, niko...@cumulusnetworks.com wrote: >On 25/09/17 12:35, Nikolay Aleksandrov wrote: >> On 24/09/17 20:22, Jiri Pirko wrote: >>> From: Yotam Gigi >>> >>> Make the ipmr module register as a FIB notifier. To do that, implement both >>> the ipmr_seq_read and ipmr_du

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Antoine Tenart
Hi Russell, On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > Convert the PPv2 driver to use phylink, which models the MAC to PHY > > link. The phylink support is made such a way the GoP link IRQ can stil

Re: [patch net-next v2 03/12] ipmr: Add FIB notification access functions

2017-09-25 Thread Nikolay Aleksandrov
On 25/09/17 12:47, Jiri Pirko wrote: > Mon, Sep 25, 2017 at 11:40:16AM CEST, niko...@cumulusnetworks.com wrote: >> On 25/09/17 12:35, Nikolay Aleksandrov wrote: >>> On 24/09/17 20:22, Jiri Pirko wrote: From: Yotam Gigi Make the ipmr module register as a FIB notifier. To do that, imp

Re: [patch net-next v2 06/12] net: mroute: Check if rule is a default rule

2017-09-25 Thread Nikolay Aleksandrov
On 25/09/17 12:45, Jiri Pirko wrote: > Mon, Sep 25, 2017 at 03:28:21AM CEST, linyunsh...@huawei.com wrote: >> Hi, Jiri >> >> On 2017/9/25 1:22, Jiri Pirko wrote: >>> From: Yotam Gigi >>> >>> When the ipmr starts, it adds one default FIB rule that matches all packets >>> and sends them to the DEFAU

[PATCH net v2] sctp: Fix a big endian bug in sctp_diag_dump()

2017-09-25 Thread Dan Carpenter
The sctp_for_each_transport() function takes an pointer to int. The cb->args[] array holds longs so it's only using the high 32 bits. It works on little endian system but will break on big endian 64 bit machines. Fixes: d25adbeb0cdb ("sctp: fix an use-after-free issue in sctp_sock_dump") Signed-

[PATCH net-next 1/7] nfp: add helper to get flower cmsg length

2017-09-25 Thread Simon Horman
From: John Hurley Add a helper function that returns the length of the cmsg data when given the cmsg skb Signed-off-by: John Hurley Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 5 + drivers/net/ethernet/netronome/nfp/flower/metadata.c | 2 +- 2 fi

[PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Simon Horman
From: Simon Horman John says: This patch set allows offloading of TC flower match and set tunnel fields to the NFP. The initial focus is on VXLAN traffic. Due to the current state of the NFP firmware, only VXLAN traffic on well known port 4789 is handled. The match and action fields must explici

[PATCH net-next 4/7] nfp: offload flower vxlan endpoint MAC addresses

2017-09-25 Thread Simon Horman
From: John Hurley Generate a list of MAC addresses of netdevs that could be used as VXLAN tunnel end points. Give offloaded MACs an index for storage on the NFP in the ranges: 0x100-0x1ff physical port representors 0x200-0x2ff VF port representors 0x300-0x3ff other offloads (e.g. vxlan netdevs, o

[PATCH net-next 6/7] nfp: flower vxlan neighbour offload

2017-09-25 Thread Simon Horman
From: John Hurley Receive a request when the NFP does not know the next hop for a packet that is to be encapsulated in a VXLAN tunnel. Do a route lookup, determine the next hop entry and update neighbour table on NFP. Monitor the kernel neighbour table for link changes and update NFP with relevan

[PATCH net-next 3/7] nfp: compile flower vxlan tunnel set actions

2017-09-25 Thread Simon Horman
From: John Hurley Compile set tunnel actions for tc flower. Only support VXLAN and ensure a tunnel destination port of 4789 is used. Signed-off-by: John Hurley Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/action.c | 169 ++--- drivers/net/ethernet/

[PATCH net-next 5/7] nfp: offload vxlan IPv4 endpoints of flower rules

2017-09-25 Thread Simon Horman
From: John Hurley Maintain a list of IPv4 addresses used as the tunnel destination IP match fields in currently active flower rules. Offload the entire list of NFP_FL_IPV4_ADDRS_MAX (even if some are unused) when new IPs are added or removed. The NFP should only be aware of tunnel end points that

[PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive

2017-09-25 Thread Simon Horman
From: John Hurley Periodically receive messages containing the destination IPs of tunnels that have recently forwarded traffic. Update the neighbour entries 'used' value for these IPs next hop. This prevents the neighbour entry from expiring on timeout but rather signals an ARP to verify the con

[PATCH net-next 2/7] nfp: compile flower vxlan tunnel metadata match fields

2017-09-25 Thread Simon Horman
From: John Hurley Compile ovs-tc flower vxlan metadata match fields for offloading. Only support offload of tunnel data when the VXLAN port specifically matches well known port 4789. Signed-off-by: John Hurley Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h

Re: [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases

2017-09-25 Thread Stephen Hemminger
On Fri, 22 Sep 2017 15:31:38 -0700 Haiyang Zhang wrote: > From: Haiyang Zhang > > For older hosts without multi-channel (vRSS) support, and some error > cases, we still need to set the real number of queues to one. > This patch adds this missing setting. > > Fixes: 8195b1396ec8 ("hv_netvsc: fi

Re: [patch net-next v2 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-25 Thread Nikolay Aleksandrov
On 24/09/17 20:22, Jiri Pirko wrote: > From: Yotam Gigi > > Add the multicast router offloading logic, which is in charge of handling > the VIF and MFC notifications and translating it to the hardware logic API. > > The offloading logic has to overcome several obstacles in order to safely > comp

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Russell King - ARM Linux
On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > Hi Russell, > > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > > Convert the PPv2 driver to use phylink, which models the MAC to PHY

Re: [patch net-next v2 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-25 Thread Yotam Gigi
On 09/25/2017 01:40 PM, Nikolay Aleksandrov wrote: > On 24/09/17 20:22, Jiri Pirko wrote: >> From: Yotam Gigi >> >> Add the multicast router offloading logic, which is in charge of handling >> the VIF and MFC notifications and translating it to the hardware logic API. >> >> The offloading logic ha

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Jakub Kicinski
On Mon, 25 Sep 2017 12:23:34 +0200, Simon Horman wrote: > From: Simon Horman > > John says: > > This patch set allows offloading of TC flower match and set tunnel fields > to the NFP. The initial focus is on VXLAN traffic. Due to the current > state of the NFP firmware, only VXLAN traffic on wel

[PATCH v2 11/16] thunderbolt: Use spinlock in ring serialization

2017-09-25 Thread Mika Westerberg
This makes it possible to enqueue frames also from atomic context which is needed for example, when networking packets are sent over a Thunderbolt cable. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat --- drivers/thunderbolt/nhi.c | 26 ++--

[PATCH v2 16/16] net: Add support for networking over Thunderbolt cable

2017-09-25 Thread Mika Westerberg
From: Amir Levy ThunderboltIP is a protocol created by Apple to tunnel IP/ethernet traffic over a Thunderbolt cable. The protocol consists of configuration phase where each side sends ThunderboltIP login packets (the protocol is determined by UUID in the XDomain packet header) over the configurat

[PATCH v2 13/16] thunderbolt: Add polling mode for rings

2017-09-25 Thread Mika Westerberg
In order to support things like networking over Thunderbolt cable, there needs to be a way to switch the ring to a mode where it can be polled with the interrupt masked. We implement such mode so that the caller can allocate a ring by passing pointer to a function that is then called when an interr

[PATCH v2 14/16] thunderbolt: Add function to retrieve DMA device for the ring

2017-09-25 Thread Mika Westerberg
This is needed when Thunderbolt service drivers need to DMA map memory before it is passed down to the ring. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat --- include/linux/thunderbolt.h | 13 + 1 file changed, 13 insertions(+) diff --git a

[PATCH v2 09/16] thunderbolt: Export ring handling functions to modules

2017-09-25 Thread Mika Westerberg
These are used by Thunderbolt services to send and receive frames over the high-speed DMA rings. We also put the functions to tb_ namespace to make sure we do not collide with others and add missing kernel-doc comments for the exported functions. Signed-off-by: Mika Westerberg Reviewed-by: Micha

[PATCH v2 05/16] thunderbolt: Move tb_switch_phy_port_from_link() to thunderbolt.h

2017-09-25 Thread Mika Westerberg
A Thunderbolt service might need to find the physical port from a link the cable is connected to. For instance networking driver uses this information to generate MAC address according the Apple ThunderboltIP protocol. Move this function to thunderbolt.h and rename it to tb_phy_port_from_link() to

[PATCH v2 12/16] thunderbolt: Use spinlock in NHI serialization

2017-09-25 Thread Mika Westerberg
This is needed because ring polling functionality can be called from atomic contexts when networking and other high-speed traffic is transferred over a Thunderbolt cable. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat --- drivers/thunderbolt/nhi.c | 75

[PATCH v2 02/16] thunderbolt: Add support for XDomain properties

2017-09-25 Thread Mika Westerberg
Thunderbolt XDomain discovery protocol uses directories which contain properties and other directories to exchange information about what capabilities the remote host supports. This also includes identification information like device ID and name. This adds support for parsing and formatting these

[PATCH v2 06/16] thunderbolt: Add support for XDomain discovery protocol

2017-09-25 Thread Mika Westerberg
When two hosts are connected over a Thunderbolt cable, there is a protocol they can use to communicate capabilities supported by the host. The discovery protocol uses automatically configured control channel (ring 0) and is build on top of request/response transactions using special XDomain primiti

[PATCH v2 15/16] thunderbolt: Allocate ring HopID automatically if requested

2017-09-25 Thread Mika Westerberg
Thunderbolt services should not care which HopID (ring) they use for sending and receiving packets over the high-speed DMA path, so make tb_ring_alloc_rx() and tb_ring_alloc_tx() accept negative HopID. This means that the NHI will allocate next available HopID for the caller automatically. These H

[PATCH v2 10/16] thunderbolt: Move ring descriptor flags to thunderbolt.h

2017-09-25 Thread Mika Westerberg
A Thunderbolt service driver might need to check if there was an error with the descriptor when in frame mode. We also add two Rx specific error flags RING_DESC_CRC_ERROR and RING_DESC_BUFFER_OVERRUN. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat --- dr

[PATCH v2 07/16] thunderbolt: Configure interrupt throttling for all interrupts

2017-09-25 Thread Mika Westerberg
This will keep the interrupt delivery rate reasonable. The value used here (128 us) is a recommendation from the hardware people. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat --- dr

[PATCH v2 01/16] byteorder: Move {cpu_to_be32,be32_to_cpu}_array() from Thunderbolt to core

2017-09-25 Thread Mika Westerberg
We will be using these when communicating XDomain discovery protocol over Thunderbolt link but they might be useful for other drivers as well. Make them available through byteorder/generic.h. Suggested-by: Andy Shevchenko Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Y

[PATCH v2 08/16] thunderbolt: Add support for frame mode

2017-09-25 Thread Mika Westerberg
When high-speed DMA paths are used to transfer arbitrary data over a Thunderbolt link, DMA rings should be in frame mode instead of raw mode. The latter is used by the control channel (ring 0). In frame mode each data frame can hold up to 4kB payload. This patch modifies the DMA ring code to allow

[PATCH v2 03/16] thunderbolt: Move enum tb_cfg_pkg_type to thunderbolt.h

2017-09-25 Thread Mika Westerberg
These will be needed by Thunderbolt services when sending and receiving XDomain control messages. While there change TB_CFG_PKG_PREPARE_TO_SLEEP value to be decimal in order to be consistent with other members. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Berna

[PATCH v2 04/16] thunderbolt: Move thunderbolt domain structure to thunderbolt.h

2017-09-25 Thread Mika Westerberg
These are needed by Thunderbolt services so move them to thunderbolt.h to make sure they are available outside of drivers/thunderbolt. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat --- drivers/thunderbolt/tb.h| 42 ---

Re: [PATCH net-next 5/6] bpf, nfp: add meta data support

2017-09-25 Thread Jakub Kicinski
On Mon, 25 Sep 2017 02:25:54 +0200, Daniel Borkmann wrote: > Implement support for transferring XDP meta data into skb for > nfp driver; before calling into the program, xdp.data_meta points > to xdp.data, where on program return with pass verdict, we call > into skb_metadata_set(). > > Signed-off

[PATCH v2 00/16] Thunderbolt networking

2017-09-25 Thread Mika Westerberg
Hi all, In addition of tunneling PCIe, Display Port and USB traffic, Thunderbolt allows connecting two hosts (domains) over a Thunderbolt cable. It is possible to tunnel arbitrary data packets over such connection using high-speed DMA rings available in the Thunderbolt host controller. In order t

Re: usb/wireless/rsi_91x: use-after-free write in __run_timers

2017-09-25 Thread Andrey Konovalov
On Mon, Sep 25, 2017 at 6:26 AM, Kalle Valo wrote: > Andrey Konovalov writes: > >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit 6e80ecdddf4ea6f3cd84e83720f3d852e6624a68 (Sep 21). >> >> == >>

Re: [patch net-next v2 05/12] net: ipmr: Add MFC offload indication

2017-09-25 Thread Yotam Gigi
On 09/25/2017 12:36 PM, Nikolay Aleksandrov wrote: > On 24/09/17 20:22, Jiri Pirko wrote: >> From: Yotam Gigi >> >> Allow drivers, registered to the fib notification chain indicate whether a >> multicast MFC route is offloaded or not, similarly to unicast routes. The >> indication of whether a rou

Re: [PATCH net v2] sctp: Fix a big endian bug in sctp_diag_dump()

2017-09-25 Thread Neil Horman
On Mon, Sep 25, 2017 at 01:19:26PM +0300, Dan Carpenter wrote: > The sctp_for_each_transport() function takes an pointer to int. The > cb->args[] array holds longs so it's only using the high 32 bits. It > works on little endian system but will break on big endian 64 bit > machines. > > Fixes: d

Re: [PATCH 5/5] xfrm: eradicate size_t

2017-09-25 Thread Steffen Klassert
On Thu, Sep 21, 2017 at 11:48:54PM +0300, Alexey Dobriyan wrote: > All netlink message sizes are a) unsigned, b) can't be >= 4GB in size > because netlink doesn't support >= 64KB messages in the first place. > > All those size_t across the code are a scam especially across networking > which likes

[PATCH RESEND] wireless: iwlwifi: fix minor code style issues

2017-09-25 Thread Christoph Böhmwalder
Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) di

Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

2017-09-25 Thread Coelho, Luciano
On Mon, 2017-09-25 at 13:37 +0200, Christoph Böhmwalder wrote: > Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder --- Why are you already resending this? You sent

Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

2017-09-25 Thread Christoph Böhmwalder
> Why are you already resending this? Sorry, I guess I was too impatient. I also messed up the spelling in a "To:" line and forgot triv...@kernel.org the first time I sent it, so I figured I'd just fix it in a resend. I'll make sure to wait a little longer next time. -- Regards, Christoph sig

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Antoine Tenart
On Mon, Sep 25, 2017 at 11:45:32AM +0100, Russell King - ARM Linux wrote: > On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > > > Con

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Russell King - ARM Linux
On Mon, Sep 25, 2017 at 01:53:03PM +0200, Antoine Tenart wrote: > On Mon, Sep 25, 2017 at 11:45:32AM +0100, Russell King - ARM Linux wrote: > > Can you describe what the GoP link IRQ is doing please? > > In cases where there is no PHY connected to the MAC and no SFP cage is > used. One example is

Re: usb/wireless/rsi_91x: use-after-free write in __run_timers

2017-09-25 Thread Kalle Valo
Andrey Konovalov writes: > On Mon, Sep 25, 2017 at 6:26 AM, Kalle Valo wrote: >> Andrey Konovalov writes: >> >>> I've got the following report while fuzzing the kernel with syzkaller. >>> >>> On commit 6e80ecdddf4ea6f3cd84e83720f3d852e6624a68 (Sep 21). >>> >>> ==

Re: [PATCH net v2] l2tp: fix race condition in l2tp_tunnel_delete

2017-09-25 Thread Guillaume Nault
On Fri, Sep 22, 2017 at 06:16:24PM +0200, Sabrina Dubroca wrote: > 2017-09-19, 18:43:37 +0200, Guillaume Nault wrote: > > On Tue, Sep 19, 2017 at 03:40:40PM +0200, Sabrina Dubroca wrote: > > > If we try to delete the same tunnel twice, the first delete operation > > > does a lookup (l2tp_tunnel_get

Re: [PATCH net 1/3] net: mvpp2: fix the dma_mask and coherent_dma_mask settings for PPv2.2

2017-09-25 Thread Antoine Tenart
On Thu, Sep 21, 2017 at 10:07:18AM -0700, David Miller wrote: > From: Antoine Tenart > Date: Thu, 21 Sep 2017 16:24:13 +0200 > > > That's also the default when the platform does not allocate dma_mask. > > That's the problem that needs to be fixed then. OK, I'll drop this patch until I find a pr

[PATCH net v2 1/3] net: mvpp2: fix parsing fragmentation detection

2017-09-25 Thread Antoine Tenart
From: Stefan Chulski Parsing fragmentation detection failed due to wrong configured parser TCAM entry's. Some traffic was marked as fragmented in RX descriptor, even it wasn't IP fragmented. The hardware also failed to calculate checksums which lead to use software checksum and caused performance

[PATCH net v2 2/3] net: mvpp2: fix port list indexing

2017-09-25 Thread Antoine Tenart
From: Yan Markman The private port_list array has a list of pointers to mvpp2_port instances. This list is allocated given the number of ports enabled in the device tree, but the pointers are set using the port-id property. If on a single port is enabled, the port_list array will be of size 1, bu

[PATCH net v2 3/3] net: mvpp2: do not select the internal source clock

2017-09-25 Thread Antoine Tenart
This patch stops the internal MAC Tx clock from being enabled as the internal clock isn't used. The definition used for the bit controlling this behaviour is renamed as well as it was wrongly named (bit 4 of GMAC_CTRL_2_REG). Fixes: 3919357fb0bb ("net: mvpp2: initialize the GMAC when using a port"

[PATCH net v2 0/3] net: mvpp2: various fixes

2017-09-25 Thread Antoine Tenart
Hi all, This series contains 3 fixes for the Marvell PPv2 driver. Thanks! Antoine Since v1: - Removed one patch about dma masks as it would need a better fix. - Added one fix about the MAC Tx clock source selection. Antoine Tenart (1): net: mvpp2: do not select the internal source clock

Re: [PATCH net-next] net: mvpp2: phylink support

2017-09-25 Thread Antoine Tenart
On Mon, Sep 25, 2017 at 01:13:43PM +0100, Russell King - ARM Linux wrote: > On Mon, Sep 25, 2017 at 01:53:03PM +0200, Antoine Tenart wrote: > > On Mon, Sep 25, 2017 at 11:45:32AM +0100, Russell King - ARM Linux wrote: > > > Can you describe what the GoP link IRQ is doing please? > > > > In cases w

Re: [PATCH net v2 2/3] net: mvpp2: fix port list indexing

2017-09-25 Thread Antoine Tenart
On Mon, Sep 25, 2017 at 02:59:47PM +0200, Antoine Tenart wrote: > From: Yan Markman > > The private port_list array has a list of pointers to mvpp2_port > instances. This list is allocated given the number of ports enabled in > the device tree, but the pointers are set using the port-id property.

Re: [PATCH net v2 1/3] net: mvpp2: fix parsing fragmentation detection

2017-09-25 Thread Antoine Tenart
On Mon, Sep 25, 2017 at 02:59:46PM +0200, Antoine Tenart wrote: > From: Stefan Chulski > > Parsing fragmentation detection failed due to wrong configured > parser TCAM entry's. Some traffic was marked as fragmented in RX > descriptor, even it wasn't IP fragmented. The hardware also failed to > ca

Re: [patch net-next v2 06/12] net: mroute: Check if rule is a default rule

2017-09-25 Thread Yotam Gigi
On 09/25/2017 01:02 PM, Nikolay Aleksandrov wrote: > On 25/09/17 12:45, Jiri Pirko wrote: >> Mon, Sep 25, 2017 at 03:28:21AM CEST, linyunsh...@huawei.com wrote: >>> Hi, Jiri >>> >>> On 2017/9/25 1:22, Jiri Pirko wrote: From: Yotam Gigi When the ipmr starts, it adds one default FIB r

[PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Yi Yang
v8->v9 - Fix build error reported by daily intel build because nsh module isn't selected by openvswitch v7->v8 - Rework nested value and mask for OVS_KEY_ATTR_NSH - Change pop_nsh to adapt to nsh kernel module - Fix many issues per comments from Jiri Benc v6->v7 - Remove NSH GSO patches i

  1   2   3   >