Re: stmmac driver timeout issue

2021-03-12 Thread Russell King - ARM Linux admin
On Fri, Mar 12, 2021 at 10:33:06AM -0800, Florian Fainelli wrote: > On 3/11/21 4:04 AM, Joakim Zhang wrote: > > I have a question about PHY framework, please point me if something I > > misunderstanding. > > There are many scenarios from PHY framework would trigger auto-nego, such > > as switch f

Re: stmmac driver timeout issue

2021-03-12 Thread Florian Fainelli
On 3/11/21 4:04 AM, Joakim Zhang wrote: > >> -Original Message- >> From: Florian Fainelli >> Sent: 2021年3月9日 1:57 >> To: Joakim Zhang ; Jakub Kicinski >> ; Andrew Lunn >> Cc: netdev@vger.kernel.org >> Subject: Re: stmmac driver timeout issu

RE: stmmac driver timeout issue

2021-03-11 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年3月9日 1:57 > To: Joakim Zhang ; Jakub Kicinski > ; Andrew Lunn > Cc: netdev@vger.kernel.org > Subject: Re: stmmac driver timeout issue > > On 3/8/21 4:45 AM, Joakim Zhang wrote: > > > >

Re: stmmac driver timeout issue

2021-03-08 Thread Florian Fainelli
On 3/8/21 4:45 AM, Joakim Zhang wrote: > > Hi Florian, Andrew, > > Thanks for your help, after debug, It seems related to PHY(RTL8211FDI). It > stop output RXC clock for dozens to hundreds milliseconds during > auto-negotiation, and there is no such issue with AR8031. > When do ifup/ifdown test

RE: stmmac driver timeout issue

2021-03-08 Thread Joakim Zhang
n > Cc: netdev@vger.kernel.org > Subject: Re: stmmac driver timeout issue > > On 3/4/21 5:14 AM, Joakim Zhang wrote: > > > > Hello Andrew, Hello Jakub, > > > > You may can give some suggestions based on your great networking > knowledge, thanks

Re: stmmac driver timeout issue

2021-03-04 Thread Florian Fainelli
On 3/4/21 5:14 AM, Joakim Zhang wrote: > > Hello Andrew, Hello Jakub, > > You may can give some suggestions based on your great networking knowledge, > thanks in advance! > > I found that add vlan id hw filter (stmmac_vlan_rx_add_vid) have possibility > timeout when accessing VLAN Filter regis

Re: stmmac driver timeout issue

2021-03-04 Thread Andrew Lunn
On Thu, Mar 04, 2021 at 01:14:31PM +, Joakim Zhang wrote: > > Hello Andrew, Hello Jakub, > > You may can give some suggestions based on your great networking knowledge, > thanks in advance! > > I found that add vlan id hw filter (stmmac_vlan_rx_add_vid) have possibility > timeout when acce

stmmac driver timeout issue

2021-03-04 Thread Joakim Zhang
Hello Andrew, Hello Jakub, You may can give some suggestions based on your great networking knowledge, thanks in advance! I found that add vlan id hw filter (stmmac_vlan_rx_add_vid) have possibility timeout when accessing VLAN Filter registers during ifup/ifdown stress test, and restore vlan

Re: [PATCH V5 net 0/5] ethernet: fixes for stmmac driver

2021-02-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 17:01:09 +0800 you wrote: > Fixes for stmmac driver. > > --- > ChangeLogs: > V1->V2: > * subject prefix: ethernet: stmmac: -> net: stmmac: > * use dma_addr_t

[PATCH V5 net 0/5] ethernet: fixes for stmmac driver

2021-02-25 Thread Joakim Zhang
Fixes for stmmac driver. --- ChangeLogs: V1->V2: * subject prefix: ethernet: stmmac: -> net: stmmac: * use dma_addr_t instead of unsigned int for physical address * use cpu_to_le32() V2->V3: * fix the build issue pointed out by kbuild bot. *

[PATCH V4 net 0/5] ethernet: fixes for stmmac driver

2021-02-04 Thread Joakim Zhang
Fixes for stmmac driver. --- ChangeLogs: V1->V2: * subject prefix: ethernet: stmmac: -> net: stmmac: * use dma_addr_t instead of unsigned int for physical address * use cpu_to_le32() V2->V3: * fix the build issue pointed out by kbuild bot. *

[PATCH net-next 0/2] patch for stmmac driver

2021-02-04 Thread Joakim Zhang
Small improvement for stmmac driver. Reviewer think patch #1 should go into net-next repo, and add patch #2. Joakim Zhang (2): net: stmmac: remove redundant null check for ptp clock net: stmmac: slightly adjust the order of the codes in stmmac_resume() .../net/ethernet/stmicro/stmmac

[PATCH V3 0/6] ethernet: fixes for stmmac driver

2021-01-26 Thread Joakim Zhang
Fixes for stmmac driver. --- ChangeLogs: V1->V2: * subject prefix: ethernet: stmmac: -> net: stmmac: * use dma_addr_t instead of unsigned int for physical address * use cpu_to_le32() V2-V3: * fix the build issue pointed out by kbuild bot. * add

Re: [PATCH V2 net 0/6] ethernet: fixes for stmmac driver

2021-01-25 Thread Jakub Kicinski
On Mon, 25 Jan 2021 04:53:00 + Joakim Zhang wrote: > Gentle Ping... Please fix the build issue pointed out by kbuild bot, ensure there is no other build problem and repost.

RE: [PATCH V2 net 0/6] ethernet: fixes for stmmac driver

2021-01-24 Thread Joakim Zhang
; > and...@lunn.ch; f.faine...@gmail.com > Subject: [PATCH V2 net 0/6] ethernet: fixes for stmmac driver > > Fixes for stmmac driver. > > --- > ChangeLogs: > V1->V2: > * subject prefix: ethernet: stmmac: -> net: stmmac: > * use dma_addr_t inst

[PATCH V2 net 0/6] ethernet: fixes for stmmac driver

2021-01-12 Thread Joakim Zhang
Fixes for stmmac driver. --- ChangeLogs: V1->V2: * subject prefix: ethernet: stmmac: -> net: stmmac: * use dma_addr_t instead of unsigned int for physical address * use cpu_to_le32() Joakim Zhang (6): net: stmmac: remove redundant null check for ptp clock net:

[PATCH 0/6] ethernet: fixes for stmmac driver

2021-01-11 Thread Joakim Zhang
Fixes for stmmac driver. Joakim Zhang (6): ethernet: stmmac: remove redundant null check for ptp clock ethernet: stmmac: stop each tx channal independently ethernet: stmmac: fix watchdog timeout during suspend/resume stress test ethernet: stmmac: fix dma physical address of descriptor

suspend/resume issue in stmmac driver

2021-01-05 Thread Joakim Zhang
Hi guys, When I do suspend/resume stress test with stmmac driver, I encountered some tricky issues. DWC EQOS version is 5.10, Linux kernel version is 5.10. 1. The first issue is net watchdog timeout. stmmac_xmit() call stmmac_tx_timer_arm() at the end to modify a timer to do the transmission

Re: STMMAC driver with TSO enabled issue

2018-05-29 Thread Bhadram Varka
Hi Jose, On 5/28/2018 4:26 PM, Jose Abreu wrote: Hi Bhadram, On 28-05-2018 10:15, Bhadram Varka wrote: Hi Jose, On 5/25/2018 8:02 PM, Jose Abreu wrote: On 25-05-2018 15:25, Bhadram Varka wrote: Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Vark

Re: STMMAC driver with TSO enabled issue

2018-05-28 Thread Jose Abreu
Hi Bhadram, On 28-05-2018 10:15, Bhadram Varka wrote: > Hi Jose, > > On 5/25/2018 8:02 PM, Jose Abreu wrote: >> On 25-05-2018 15:25, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: > Hi Jose,

Re: STMMAC driver with TSO enabled issue

2018-05-28 Thread Bhadram Varka
Hi Jose, On 5/25/2018 8:02 PM, Jose Abreu wrote: On 25-05-2018 15:25, Bhadram Varka wrote: Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Vark

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Jose Abreu
On 25-05-2018 15:25, Bhadram Varka wrote: > Hi Jose, > > On 5/25/2018 7:35 PM, Jose Abreu wrote: >> Hi Bhadram, >> >> On 25-05-2018 05:41, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: > >>>

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Bhadram Varka
Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: After some time if check Tx descriptor status - then I see only below [..] [85788.

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Jose Abreu
Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: > Hi Jose, > > On 5/24/2018 3:01 PM, Jose Abreu wrote: >> Hi Bhadram, >> >> On 24-05-2018 06:58, Bhadram Varka wrote: >>> >>> After some time if check Tx descriptor status - then I see only >>> below >>> >>> [..] >>> [85788.286730] 027 [0x82795

Re: STMMAC driver with TSO enabled issue

2018-05-24 Thread Bhadram Varka
Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: After some time if check Tx descriptor status - then I see only below [..] [85788.286730] 027 [0x827951b0]: 0xf854f000 0x0 0x16d8 0x9000 index 025 and 026 descriptors processed but not

Re: STMMAC driver with TSO enabled issue

2018-05-24 Thread Jose Abreu
Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: > > After some time if check Tx descriptor status - then I see only > below > > [..] > [85788.286730] 027 [0x827951b0]: 0xf854f000 0x0 0x16d8 0x9000 > > index 025 and 026 descriptors processed but not index 027. > > At this stage Tx DMA is

Re: STMMAC driver with TSO enabled issue

2018-05-23 Thread Bhadram Varka
Hi Jose, On 5/17/2018 7:43 PM, Jose Abreu wrote: Hi Bhadram, On 15-05-2018 07:44, Bhadram Varka wrote: Hi Jose, On 5/10/2018 9:15 PM, Jose Abreu wrote: On 10-05-2018 16:08, Bhadram Varka wrote: Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu

Re: STMMAC driver with TSO enabled issue

2018-05-17 Thread Jose Abreu
Hi Bhadram, On 15-05-2018 07:44, Bhadram Varka wrote: > Hi Jose, > > On 5/10/2018 9:15 PM, Jose Abreu wrote: >> >> >> On 10-05-2018 16:08, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: > ++net

Re: STMMAC driver with TSO enabled issue

2018-05-14 Thread Bhadram Varka
Hi Jose, On 5/10/2018 9:15 PM, Jose Abreu wrote: On 10-05-2018 16:08, Bhadram Varka wrote: Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: ++net-dev Hi Bhadram, On 09-05-2018 12:03, Bhadram Varka wrote: Hi, Thanks for responding. Tr

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Jose Abreu
On 10-05-2018 16:08, Bhadram Varka wrote: > Hi Jose, > > On 5/10/2018 7:59 PM, Jose Abreu wrote: >> Hi Bhadram, >> >> On 10-05-2018 09:55, Jose Abreu wrote: >>> ++net-dev >>> >>> Hi Bhadram, >>> >>> On 09-05-2018 12:03, Bhadram Varka wrote: Hi, Thanks for responding. Trie

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Bhadram Varka
Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: ++net-dev Hi Bhadram, On 09-05-2018 12:03, Bhadram Varka wrote: Hi, Thanks for responding. Tried below suggested way. Still observing the issue - It seems stmmac has a bug in the RX side w

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Jose Abreu
Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: > ++net-dev > > Hi Bhadram, > > On 09-05-2018 12:03, Bhadram Varka wrote: >> Hi, >> >> Thanks for responding. >> >> Tried below suggested way. Still observing the issue - > It seems stmmac has a bug in the RX side when using TSO which is > causing

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Jose Abreu
++net-dev Hi Bhadram, On 09-05-2018 12:03, Bhadram Varka wrote: > Hi, > > Thanks for responding. > > Tried below suggested way. Still observing the issue - It seems stmmac has a bug in the RX side when using TSO which is causing all the RX descriptors to be consumed. The stmmac_rx() function wil

Re: stmmac driver...

2016-12-14 Thread Giuseppe CAVALLARO
Hello Jie On 12/14/2016 5:05 AM, Jie Deng wrote: Hi Peppe, On 2016/12/12 22:17, Giuseppe CAVALLARO wrote: Hi David On 12/7/2016 7:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are list

Re: stmmac driver...

2016-12-14 Thread Jie Deng
Hi David, Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, and participatio

Re: stmmac driver...

2016-12-13 Thread Jie Deng
Hi Peppe, On 2016/12/12 22:17, Giuseppe CAVALLARO wrote: > Hi David > > On 12/7/2016 7:06 PM, David Miller wrote: >> >> Giuseppe and Alexandre, >> >> There are a lot of patches and discussions happening around the stammc >> driver lately and both of you are listed as the maintainers. >> >> I reall

Re: stmmac driver...

2016-12-12 Thread Giuseppe CAVALLARO
Hi David On 12/7/2016 7:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, and p

Re: Re: stmmac driver...

2016-12-12 Thread Niklas Cassel
100 >>>> >>>>> Maybe I forget some series. Do you have others in mind ? >>>> Please see the thread titled: >>>> >>>> "net: ethernet: Initial driver for Synopsys DWC XLGMAC" >>>> >>>> which seems to be discussing con

Re: stmmac driver...

2016-12-09 Thread Niklas Cassel
f the driver name and >> things like this, and wish the people doing that work would >> simply contribute to making whatever changes they need directly >> to the stmmac driver. >> >> You really need to voice your opinion when major changes are being >> proposed for the dr

Re: stmmac driver...

2016-12-09 Thread Jie Deng
; > > which seems to be discussing consolidation of various drivers > for the same IP core, of which stmmac is one. > > I personally am against any change of the driver name and > things like this, and wish the people doing that work would > simply contribute to making whatever cha

Re: stmmac driver...

2016-12-08 Thread Alexandre Torgue
discussing consolidation of various drivers for the same IP core, of which stmmac is one. I personally am against any change of the driver name and things like this, and wish the people doing that work would simply contribute to making whatever changes they need directly to the stmmac driver. You really nee

Re: stmmac driver...

2016-12-08 Thread David Miller
e IP core, of which stmmac is one. I personally am against any change of the driver name and things like this, and wish the people doing that work would simply contribute to making whatever changes they need directly to the stmmac driver. You really need to voice your opinion when major chan

Re: stmmac driver...

2016-12-08 Thread Alexandre Torgue
Hi David, On 12/07/2016 07:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, an

stmmac driver...

2016-12-07 Thread David Miller
Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, and participation in all discussions about the driver. Oth

Re: [RESEND PATCH net-next 00/13] Enhance stmmac driver to support GMAC4.x IP

2016-04-02 Thread David Miller
From: Alexandre TORGUE Date: Fri, 1 Apr 2016 11:37:24 +0200 > This is a subset of patch to enhance current stmmac driver to support > new GMAC4.x chips. New set of callbacks is defined to support this new > family: descriptors, dma, core. Series applied, thanks.

[RESEND PATCH net-next 00/13] Enhance stmmac driver to support GMAC4.x IP

2016-04-01 Thread Alexandre TORGUE
This is a subset of patch to enhance current stmmac driver to support new GMAC4.x chips. New set of callbacks is defined to support this new family: descriptors, dma, core. One of main changes of GMAC 4.xx IP is descriptors management. -descriptors are only used in ring mode. -A descriptor is

Re: [PATCH 00/13] Enhance stmmac driver to support GMAC4.x IP

2016-03-25 Thread Alexandre Torgue
Hi, On 03/25/2016 04:11 PM, David Miller wrote: It is absolutely not appropriate to submit new feature patches at this time. Please resubmit this after the net-next tree opens back out. No pb, I will wait and resend. Regards Alex Thank you.

Re: [PATCH 00/13] Enhance stmmac driver to support GMAC4.x IP

2016-03-25 Thread David Miller
It is absolutely not appropriate to submit new feature patches at this time. Please resubmit this after the net-next tree opens back out. Thank you.

[PATCH 00/13] Enhance stmmac driver to support GMAC4.x IP

2016-03-25 Thread Alexandre TORGUE
This is a subset of patch to enhance current stmmac driver to support new GMAC4.x chips. New set of callbacks is defined to support this new family: descriptors, dma, core. One of main changes of GMAC 4.xx IP is descriptors management. -descriptors are only used in ring mode. -A descriptor is

Re: [v6,1/4] stmmac: create of compatible mdio bus for stmmac driver

2016-02-17 Thread Gabriel Fernandez
Hi all, I work on STih410B2120 board and i have a regression since this patch (eth0: No PHY found) My configuration is an Ethernet MAC with a "fixed link", and not connected to a normal MDIO-managed PHY device. Please find my remark below. On 12/14/2015 04:31 AM, Phil Reid wrote: The DSA

[PATCH v6 1/4] stmmac: create of compatible mdio bus for stmmac driver

2015-12-13 Thread Phil Reid
The DSA driver needs to be passed a reference to an mdio bus. Typically the mac is configured to use a fixed link but the mdio bus still needs to be registered so that it con configure the switch. This patch follows the same process as the altera tse ethernet driver for creation of the mdio bus. A