From: Steve Wise <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 17:46:26 -0500
> We're talking about just for pktgen...eh?
My bad, I'm happy to review a patch that uses the
skb->destructor in pktgen to achieve this.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a
David Miller wrote:
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 14:57:13 -0700
This skb recycling can certainly work and has been done several
times before. It never gets into the kernel though.
Because it doesn't work.
A socket can hang onto a receive packet essentially f
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 14:57:13 -0700
> This skb recycling can certainly work and has been done several
> times before. It never gets into the kernel though.
Because it doesn't work.
A socket can hang onto a receive packet essentially forever.
You cannot th
Steve Wise wrote:
Ben Greear wrote:
Rick Jones wrote:
Perf-wise, you could clone the skbs up front, then deliver them to
the nic in a tight loop. This would mitigate the added overhead
introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a sm
Ben Greear wrote:
Rick Jones wrote:
Perf-wise, you could clone the skbs up front, then deliver them to
the nic in a tight loop. This would mitigate the added overhead
introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a small number of skbs.
Rick Jones wrote:
Perf-wise, you could clone the skbs up front, then deliver them to
the nic in a tight loop. This would mitigate the added overhead
introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a small number of skbs. You can't
pre-clon
Perf-wise, you could clone the skbs up front, then deliver them to the
nic in a tight loop. This would mitigate the added overhead
introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a small number of skbs. You can't
pre-clone several minutes w
From: Steve Wise <[EMAIL PROTECTED]>
Date: Mon, 24 Sep 2007 08:54:13 -0500
> I think pktgen should be cloning the skbs using skb_clone(). Then it
> will work for all devices, eh?
The problem is that skb_clone() is (relatively) expensive and
pktgen is trying to just grab a reference to the SKB i
Hi,
Steve Wise writes:
> I think pktgen should be cloning the skbs using skb_clone(). Then it
> will work for all devices, eh?
pktgen assumes for "fastpath" sending exclusive ownership of
the skb. And does a skb_get to avoid final skb destruction so
the same skb can be sent over and over
Steve Wise wrote:
Ben Greear wrote:
Steve Wise wrote:
I think pktgen should be cloning the skbs using skb_clone(). Then
it will work for all devices, eh?
That might work, but it would decrease performance slightly (or,
increase CPU load at least).
Perf-wise, you could clone the skbs up fro
Ben Greear wrote:
Steve Wise wrote:
I think pktgen should be cloning the skbs using skb_clone(). Then it
will work for all devices, eh?
That might work, but it would decrease performance slightly (or,
increase CPU load at least).
Perf-wise, you could clone the skbs up front, then deliver th
Steve Wise wrote:
I think pktgen should be cloning the skbs using skb_clone(). Then it
will work for all devices, eh?
That might work, but it would decrease performance slightly (or,
increase CPU load at least).
Maybe a new option: multi_clone
Ben
--
Ben Greear <[EMAIL PROTECTED]>
Candela
I think pktgen should be cloning the skbs using skb_clone(). Then it
will work for all devices, eh?
Ben Greear wrote:
jamal wrote:
On Sun, 2007-23-09 at 12:55 -0500, Steve Wise wrote:
Its a hack that breaks cxgb3 because cxgb3 uses the skb->cb area for
each skb passed down. So cxgb3 is
jamal wrote:
On Sun, 2007-23-09 at 12:55 -0500, Steve Wise wrote:
Its a hack that breaks cxgb3 because cxgb3 uses the skb->cb area for
each skb passed down. So cxgb3 is at fault then? IE a driver cannot
use the skb->cb field if the users count is > 1? Or maybe a driver can
_never_ use t
On Sun, 2007-23-09 at 12:55 -0500, Steve Wise wrote:
> Its a hack that breaks cxgb3 because cxgb3 uses the skb->cb area for
> each skb passed down. So cxgb3 is at fault then? IE a driver cannot
> use the skb->cb field if the users count is > 1? Or maybe a driver can
> _never_ use the cb fiel
Hi Steve.
On Sun, Sep 23, 2007 at 11:12:12AM -0500, Steve Wise ([EMAIL PROTECTED]) wrote:
> The pktgen module provides a way to "clone" the skb its using for
> transmission, and allows passing N clones of the originally created skb
> to the driver under test.However, it doesn't really use sk
Evgeniy Polyakov wrote:
Hi Steve.
On Sun, Sep 23, 2007 at 11:12:12AM -0500, Steve Wise ([EMAIL PROTECTED]) wrote:
The pktgen module provides a way to "clone" the skb its using for
transmission, and allows passing N clones of the originally created skb
to the driver under test.However, it
17 matches
Mail list logo
