Steve Wise wrote:

Ben Greear wrote:
Steve Wise wrote:
I think pktgen should be cloning the skbs using skb_clone(). Then it will work for all devices, eh?
That might work, but it would decrease performance slightly (or, increase CPU load at least).

Perf-wise, you could clone the skbs up front, then deliver them to the nic in a tight loop. This would mitigate the added overhead introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a small number of skbs. You can't pre-clone several minutes worth of 10Gbe traffic
with any normal amount of RAM.


Maybe a new option:  multi_clone


If the current code is busted, I think it should be fixed.
Well, it works fine when used correctly :)

Ben

--
Ben Greear <[EMAIL PROTECTED]> Candela Technologies Inc http://www.candelatech.com


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to