Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-12 Thread Eric Dumazet
On Tue, 2015-08-11 at 21:56 -0700, David Miller wrote: > Calling pskb_expand_head() with a shared SKB is absolutely, > positively, a bug. You just don't understand why it is. Definitely agree. Its a pain to find races otherwise. skb_get() in general is quite tricky. Better avoid it unless real

Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-11 Thread David Miller
From: Linus Lüssing Date: Tue, 11 Aug 2015 23:47:25 +0200 > On Tue, Aug 11, 2015 at 10:51:40PM +0200, Linus Lüssing wrote: >> On Mon, Aug 10, 2015 at 02:56:12PM -0700, Brenden Blanco wrote: >> > Doing some code reading with Alexei, we found a suspect commit, which >> > introduces an skb_get and s

Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-11 Thread Alexei Starovoitov
On Tue, Aug 11, 2015 at 11:47:25PM +0200, Linus Lüssing wrote: > On Tue, Aug 11, 2015 at 10:51:40PM +0200, Linus Lüssing wrote: > > On Mon, Aug 10, 2015 at 02:56:12PM -0700, Brenden Blanco wrote: > > > Doing some code reading with Alexei, we found a suspect commit, which > > > introduces an skb_get

Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-11 Thread Linus Lüssing
On Tue, Aug 11, 2015 at 10:51:40PM +0200, Linus Lüssing wrote: > On Mon, Aug 10, 2015 at 02:56:12PM -0700, Brenden Blanco wrote: > > Doing some code reading with Alexei, we found a suspect commit, which > > introduces an skb_get and skb_may_pull of the same skb, which leads to the > > BUG > > when

Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-11 Thread Linus Lüssing
On Mon, Aug 10, 2015 at 02:56:12PM -0700, Brenden Blanco wrote: > Doing some code reading with Alexei, we found a suspect commit, which > introduces an skb_get and skb_may_pull of the same skb, which leads to the BUG > when skb->len == len. Urgh, didn't know that pskb_may_pull() doesn't like an sk

ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-10 Thread Brenden Blanco
Hi folks, Here is a crash that I am able to easily reproduce. The setup is: 2 VMs, running in libvirt (qemu-kvm) CPU mode is host-passthrough, virtio drivers used wherever available Disable ipv6 (just to limit the amount of multicast noise) Set up a multicast vxlan tunnel between the two VMs Atta