On Tue, 2015-08-11 at 21:56 -0700, David Miller wrote: > Calling pskb_expand_head() with a shared SKB is absolutely, > positively, a bug. You just don't understand why it is.
Definitely agree. Its a pain to find races otherwise. skb_get() in general is quite tricky. Better avoid it unless really needed in performance critical paths. Relevant commits ba34e6d9d346fe4e05d7e417b9edf5140772d34c tcp: make sure skb is not shared before using skb_get() fc752f1f43c1c038a2c6ae58cc739ebb5953ccb0 ping: Fix race in free in receive path 1dc7b90f7cd050ef6d5e511e652347e52874469c ipv6: tcp: fix race in IPV6_2292PKTOPTIONS -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html