On Fri, Jan 25, 2019 at 11:00:46AM -0800, Florian Fainelli wrote:
> > +++ b/drivers/net/phy/phylink.c
> > @@ -409,7 +409,8 @@ static void phylink_resolve(struct work_struct *w)
> >
> > case MLO_AN_FIXED:
> > phylink_get_fixed_state(pl, &link_state);
> > -
On 1/22/19 6:10 PM, Andrew Lunn wrote:
>> Hi Andrew,
>>
>> I tested the patch and it has an issue that prevents the carrier from turning
>> on. I think it's caused by the change from using link_state to
>> phy->phy_state,
>> as later in the same function the link_state attributes are read when
>>
On Wed, Jan 23, 2019 at 03:10:32AM +0100, Andrew Lunn wrote:
> > Hi Andrew,
> >
> > I tested the patch and it has an issue that prevents the carrier from
> > turning
> > on. I think it's caused by the change from using link_state to
> > phy->phy_state,
> > as later in the same function the link_
> Hi Andrew,
>
> I tested the patch and it has an issue that prevents the carrier from turning
> on. I think it's caused by the change from using link_state to phy->phy_state,
> as later in the same function the link_state attributes are read when
> deciding if the carrier needs to be turned on.
> Hi Andrew,
>
> I've debugged the issue further by dumping all the values inside
> phylink_resolve to get a better understand how the link state behaves.
>
> As this is a fixed link the link_state structure is populated by
> phylink_get_fixed_state(), but in our case neither get_fixed_state call
On Thu, Jan 17, 2019 at 03:29:35AM +0100, Andrew Lunn wrote:
> Hi Samu
>
> Please could you try this patch. I've not had chance to properly test
> it, and i'm about to go away for a long weekend.
>
> Thanks
> Andrew
>
> From 02438712824d3c7a9dd1aab8bd5dfb4383e55bfd Mon Sep 17 00:00:00 2001
On Thu, Jan 17, 2019 at 03:29:35AM +0100, Andrew Lunn wrote:
> On Mon, Jan 14, 2019 at 01:34:44PM +0200, Samu Nuutamo wrote:
> > Hi,
> >
> > We have an imx6q-b450v3 board that has one of the switch ports configured
> > as a
> > fixed link. After upgrading the kernel to version 4.18 the link has
On Mon, Jan 14, 2019 at 01:34:44PM +0200, Samu Nuutamo wrote:
> Hi,
>
> We have an imx6q-b450v3 board that has one of the switch ports configured as a
> fixed link. After upgrading the kernel to version 4.18 the link has
> experienced
> a small amount of packet loss, around 0.15%.
>
> The issue
On Mon, Jan 14, 2019 at 10:03:57AM -0800, Florian Fainelli wrote:
> Samu, is this fixed link using a GPIO to determine the link state? Does
> this patch help at all?
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> b/drivers/net/dsa/mv88e6xxx/chip.c
> index 8a517d8fb9d1..9dedb9b22c13 100644
> -
On 1/14/19 6:23 AM, Andrew Lunn wrote:
> On Mon, Jan 14, 2019 at 01:34:44PM +0200, Samu Nuutamo wrote:
>> Hi,
>>
>> We have an imx6q-b450v3 board that has one of the switch ports configured as
>> a
>> fixed link. After upgrading the kernel to version 4.18 the link has
>> experienced
>> a small am
On Mon, Jan 14, 2019 at 01:34:44PM +0200, Samu Nuutamo wrote:
> Hi,
>
> We have an imx6q-b450v3 board that has one of the switch ports configured as a
> fixed link. After upgrading the kernel to version 4.18 the link has
> experienced
> a small amount of packet loss, around 0.15%.
>
> The issue
Hi,
We have an imx6q-b450v3 board that has one of the switch ports configured as a
fixed link. After upgrading the kernel to version 4.18 the link has experienced
a small amount of packet loss, around 0.15%.
The issue was bisected to a commit: aab9c4067d23 net: dsa: Plug in PHYLINK
support
Afte
12 matches
Mail list logo
