On Mon, Jan 14, 2019 at 10:03:57AM -0800, Florian Fainelli wrote:
> Samu, is this fixed link using a GPIO to determine the link state? Does
> this patch help at all?
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> b/drivers/net/dsa/mv88e6xxx/chip.c
> index 8a517d8fb9d1..9dedb9b22c13 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -721,7 +721,7 @@ static void mv88e6xxx_mac_config(struct dsa_switch
> *ds, int port,
>                 return;
> 
>         if (mode == MLO_AN_FIXED) {
> -               link = LINK_FORCED_UP;
> +               link = state->link;
>                 speed = state->speed;
>                 duplex = state->duplex;
>         } else if (!mv88e6xxx_phy_is_internal(ds, port)) {

Hi Florian,

I'm not 100% sure but it looks like GPIO is not used for that purpose.
I tested your patch but unfortunately it didn't work as the link keeps
cycling down/up.

- Samu

Reply via email to