Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Yanjun Zhu
On 2019/3/6 0:48, Gerd Rausch wrote: Hi Santosh, On 05/03/2019 08.41, Santosh Shilimkar wrote: On 3/5/2019 8:33 AM, Gerd Rausch wrote: If there's a mechanism that ensures compatibility with older (pre-4.1) versions of RDS I am not seeing it. Thats handled as part of the connection reject ha

Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Santosh Shilimkar
On 3/5/2019 8:48 AM, Gerd Rausch wrote: Hi Santosh, On 05/03/2019 08.41, Santosh Shilimkar wrote: On 3/5/2019 8:33 AM, Gerd Rausch wrote: If there's a mechanism that ensures compatibility with older (pre-4.1) versions of RDS I am not seeing it. Thats handled as part of the connection reject h

Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Gerd Rausch
Hi Santosh, On 05/03/2019 08.41, Santosh Shilimkar wrote: > On 3/5/2019 8:33 AM, Gerd Rausch wrote: >> If there's a mechanism that ensures compatibility with older (pre-4.1) >> versions >> of RDS I am not seeing it. > Thats handled as part of the connection reject handler as part of negotiation.

Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Santosh Shilimkar
On 3/5/2019 8:33 AM, Gerd Rausch wrote: Hi, This patchset breaks compatibility... On 04/02/2019 16.04, Santosh Shilimkar wrote: --- a/net/rds/ib_cm.c +++ b/net/rds/ib_cm.c @@ -868,7 +870,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id, bool isv6) /* If the peer doesn't do p

Re: [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos

2019-03-05 Thread Gerd Rausch
Hi, This patchset breaks compatibility... On 04/02/2019 16.04, Santosh Shilimkar wrote: > --- a/net/rds/ib_cm.c > +++ b/net/rds/ib_cm.c > @@ -868,7 +870,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id, > bool isv6) > > /* If the peer doesn't do protocol negotiation, we must